All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masahiro Yamada <masahiroy@kernel.org>
To: "Michal Suchánek" <msuchanek@suse.de>
Cc: linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: make STACKPROTECTOR_PER_TASK configurable.
Date: Wed, 10 Mar 2021 04:07:00 +0900	[thread overview]
Message-ID: <CAK7LNAQ_oJJem6sdEwTjLucjHF_R70Pa=C_c__v7x3QMz-WBAw@mail.gmail.com> (raw)
In-Reply-To: <20210309151046.GZ6564@kitsune.suse.cz>

On Wed, Mar 10, 2021 at 12:10 AM Michal Suchánek <msuchanek@suse.de> wrote:
>
> On Tue, Mar 09, 2021 at 11:53:21PM +0900, Masahiro Yamada wrote:
> > On Tue, Mar 9, 2021 at 10:35 PM Michal Suchánek <msuchanek@suse.de> wrote:
> > >
> > > On Tue, Mar 09, 2021 at 10:22:36PM +0900, Masahiro Yamada wrote:
> > > > On Tue, Mar 9, 2021 at 9:35 PM Michal Suchanek <msuchanek@suse.de> wrote:
> > > > >
> > > > > When using dummy-tools STACKPROTECTOR_PER_TASK is unconditionally
> > > > > selected. This defeats the purpose of the all-enabled tool.
> > > > >
> > > > > Description copied from arm
> > > > >
> > > > > Cc: Masahiro Yamada <masahiroy@kernel.org>
> > > > > Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> > > >
> > > >
> > > > Could you explain what problem
> > > > this patch is trying to solve?
> > >
> > > The option cannot be disabled when compiler has the required capability.
> >
> >
> > Yes.
> > Currently, this symbol claims "def_bool y",
> > so there is no way to disable it.
> >
> > But, it comes from the nature of Kconfig in general.
> >
> > dummy-tools is completely unrelated here.
>
> dummy-tools makes all configuration options available in order to be
> able to author configuration files on system different from the one
> where the kernel is built. This prevents authoring a configuration file
> with this option disabled.


No.
dummy-tools enables as many $(cc-option, ...)
and $(shell, ...) as possible. That's it.


In my understanding, STACKPROTECTOR_PER_TASK
should not be user-configurable.
That is why 'def_bool y'.

--
Best Regards
Masahiro Yamada

WARNING: multiple messages have this Message-ID (diff)
From: Masahiro Yamada <masahiroy@kernel.org>
To: "Michal Suchánek" <msuchanek@suse.de>
Cc: linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: make STACKPROTECTOR_PER_TASK configurable.
Date: Wed, 10 Mar 2021 04:07:00 +0900	[thread overview]
Message-ID: <CAK7LNAQ_oJJem6sdEwTjLucjHF_R70Pa=C_c__v7x3QMz-WBAw@mail.gmail.com> (raw)
In-Reply-To: <20210309151046.GZ6564@kitsune.suse.cz>

On Wed, Mar 10, 2021 at 12:10 AM Michal Suchánek <msuchanek@suse.de> wrote:
>
> On Tue, Mar 09, 2021 at 11:53:21PM +0900, Masahiro Yamada wrote:
> > On Tue, Mar 9, 2021 at 10:35 PM Michal Suchánek <msuchanek@suse.de> wrote:
> > >
> > > On Tue, Mar 09, 2021 at 10:22:36PM +0900, Masahiro Yamada wrote:
> > > > On Tue, Mar 9, 2021 at 9:35 PM Michal Suchanek <msuchanek@suse.de> wrote:
> > > > >
> > > > > When using dummy-tools STACKPROTECTOR_PER_TASK is unconditionally
> > > > > selected. This defeats the purpose of the all-enabled tool.
> > > > >
> > > > > Description copied from arm
> > > > >
> > > > > Cc: Masahiro Yamada <masahiroy@kernel.org>
> > > > > Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> > > >
> > > >
> > > > Could you explain what problem
> > > > this patch is trying to solve?
> > >
> > > The option cannot be disabled when compiler has the required capability.
> >
> >
> > Yes.
> > Currently, this symbol claims "def_bool y",
> > so there is no way to disable it.
> >
> > But, it comes from the nature of Kconfig in general.
> >
> > dummy-tools is completely unrelated here.
>
> dummy-tools makes all configuration options available in order to be
> able to author configuration files on system different from the one
> where the kernel is built. This prevents authoring a configuration file
> with this option disabled.


No.
dummy-tools enables as many $(cc-option, ...)
and $(shell, ...) as possible. That's it.


In my understanding, STACKPROTECTOR_PER_TASK
should not be user-configurable.
That is why 'def_bool y'.

--
Best Regards
Masahiro Yamada

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-03-09 19:09 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-09 12:35 [PATCH] arm64: make STACKPROTECTOR_PER_TASK configurable Michal Suchanek
2021-03-09 12:35 ` Michal Suchanek
2021-03-09 12:39 ` Ard Biesheuvel
2021-03-09 12:39   ` Ard Biesheuvel
2021-03-09 13:22 ` Masahiro Yamada
2021-03-09 13:22   ` Masahiro Yamada
2021-03-09 13:35   ` Michal Suchánek
2021-03-09 13:35     ` Michal Suchánek
2021-03-09 14:53     ` Masahiro Yamada
2021-03-09 14:53       ` Masahiro Yamada
2021-03-09 15:10       ` Michal Suchánek
2021-03-09 15:10         ` Michal Suchánek
2021-03-09 19:07         ` Masahiro Yamada [this message]
2021-03-09 19:07           ` Masahiro Yamada
2021-03-09 19:44           ` Michal Suchánek
2021-03-09 19:44             ` Michal Suchánek
2021-03-10 16:24           ` Michal Suchánek
2021-03-10 16:24             ` Michal Suchánek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK7LNAQ_oJJem6sdEwTjLucjHF_R70Pa=C_c__v7x3QMz-WBAw@mail.gmail.com' \
    --to=masahiroy@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=msuchanek@suse.de \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.