[PATCH] init/Kconfig: update KALLSYMS_ALL help text

[PATCH] init/Kconfig: update KALLSYMS_ALL help text

[Baruch Siach]

CONFIG_KALLSYMS_ALL is required for kernel live patching which is a
common use case that is enabled in some major distros. Update the
Kconfig help text to reflect that.

While at it, s/e.g./i.e./ to match the text intention.

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 init/Kconfig | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/init/Kconfig b/init/Kconfig
index c7900e8975f1..20ef72dd6f44 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -1722,16 +1722,17 @@ config KALLSYMS_ALL
 	help
 	  Normally kallsyms only contains the symbols of functions for nicer
 	  OOPS messages and backtraces (i.e., symbols from the text and inittext
-	  sections). This is sufficient for most cases. And only in very rare
-	  cases (e.g., when a debugger is used) all symbols are required (e.g.,
-	  names of variables from the data sections, etc).
+	  sections). This is sufficient for most cases. And only if you want to
+	  enable kernel live patching, or other less common use cases (e.g.,
+	  when a debugger is used) all symbols are required (i.e., names of
+	  variables from the data sections, etc).
 
 	  This option makes sure that all symbols are loaded into the kernel
 	  image (i.e., symbols from all sections) in cost of increased kernel
 	  size (depending on the kernel configuration, it may be 300KiB or
 	  something like this).
 
-	  Say N unless you really need all symbols.
+	  Say N unless you really need all symbols, or kernel live patching.
 
 config KALLSYMS_ABSOLUTE_PERCPU
 	bool
-- 
2.35.1

Re: [PATCH] init/Kconfig: update KALLSYMS_ALL help text

[Masahiro Yamada]

On Thu, Jul 7, 2022 at 1:45 PM Baruch Siach <baruch@tkos.co.il> wrote:
>
> CONFIG_KALLSYMS_ALL is required for kernel live patching which is a
> common use case that is enabled in some major distros. Update the
> Kconfig help text to reflect that.
>
> While at it, s/e.g./i.e./ to match the text intention.
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---


Applied to linux-kbuild.
Thanks.


>  init/Kconfig | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/init/Kconfig b/init/Kconfig
> index c7900e8975f1..20ef72dd6f44 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -1722,16 +1722,17 @@ config KALLSYMS_ALL
>         help
>           Normally kallsyms only contains the symbols of functions for nicer
>           OOPS messages and backtraces (i.e., symbols from the text and inittext
> -         sections). This is sufficient for most cases. And only in very rare
> -         cases (e.g., when a debugger is used) all symbols are required (e.g.,
> -         names of variables from the data sections, etc).
> +         sections). This is sufficient for most cases. And only if you want to
> +         enable kernel live patching, or other less common use cases (e.g.,
> +         when a debugger is used) all symbols are required (i.e., names of
> +         variables from the data sections, etc).
>
>           This option makes sure that all symbols are loaded into the kernel
>           image (i.e., symbols from all sections) in cost of increased kernel
>           size (depending on the kernel configuration, it may be 300KiB or
>           something like this).
>
> -         Say N unless you really need all symbols.
> +         Say N unless you really need all symbols, or kernel live patching.
>
>  config KALLSYMS_ABSOLUTE_PERCPU
>         bool
> --
> 2.35.1
>


-- 
Best Regards
Masahiro Yamada