* [PATCH 0/3] media: clean-up header search paths and add $(srctree)/ prefix
@ 2019-01-25 6:54 ` Masahiro Yamada
0 siblings, 0 replies; 15+ messages in thread
From: Masahiro Yamada @ 2019-01-25 6:54 UTC (permalink / raw)
To: Mauro Carvalho Chehab, linux-media
Cc: Abylay Ospan, Andy Walls, Sergey Kozlov, Akihiro Tsukada,
linux-kernel, Patrice Chotard, Hans Verkuil, Masahiro Yamada,
Sakari Ailus, linux-arm-kernel, Philipp Zabel, Hans Verkuil,
Mike Isely, Yasunari Takiguchi
My main motivation is to get rid of crappy header search path manipulation
from Kbuild core.
Before that, I want to do as many treewide cleanups as possible.
If you are interested in the big picture of this work,
the full patch set is available at:
git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git build-test
Masahiro Yamada (3):
media: coda: remove -I$(src) header search path
media: remove unneeded header search paths
media: prefix header search paths with $(srctree)/
drivers/media/common/b2c2/Makefile | 4 ++--
drivers/media/dvb-frontends/cxd2880/Makefile | 2 --
drivers/media/i2c/smiapp/Makefile | 2 +-
drivers/media/mmc/siano/Makefile | 3 +--
drivers/media/pci/b2c2/Makefile | 2 +-
drivers/media/pci/bt8xx/Makefile | 5 ++---
drivers/media/pci/cx18/Makefile | 4 ++--
drivers/media/pci/cx23885/Makefile | 4 ++--
drivers/media/pci/cx88/Makefile | 4 ++--
drivers/media/pci/ddbridge/Makefile | 4 ++--
drivers/media/pci/dm1105/Makefile | 2 +-
drivers/media/pci/mantis/Makefile | 2 +-
drivers/media/pci/netup_unidvb/Makefile | 2 +-
drivers/media/pci/ngene/Makefile | 4 ++--
drivers/media/pci/pluto2/Makefile | 2 +-
drivers/media/pci/pt1/Makefile | 4 ++--
drivers/media/pci/pt3/Makefile | 4 ++--
drivers/media/pci/smipcie/Makefile | 5 ++---
drivers/media/pci/ttpci/Makefile | 4 ++--
drivers/media/platform/coda/Makefile | 2 --
drivers/media/platform/coda/coda-h264.c | 3 ++-
drivers/media/platform/coda/trace.h | 2 +-
drivers/media/platform/sti/c8sectpfe/Makefile | 5 ++---
drivers/media/radio/Makefile | 2 --
drivers/media/spi/Makefile | 4 +---
drivers/media/usb/as102/Makefile | 2 +-
drivers/media/usb/au0828/Makefile | 4 ++--
drivers/media/usb/b2c2/Makefile | 2 +-
drivers/media/usb/cx231xx/Makefile | 5 ++---
drivers/media/usb/em28xx/Makefile | 4 ++--
drivers/media/usb/go7007/Makefile | 2 +-
drivers/media/usb/pvrusb2/Makefile | 4 ++--
drivers/media/usb/siano/Makefile | 2 +-
drivers/media/usb/tm6000/Makefile | 4 ++--
drivers/media/usb/ttusb-budget/Makefile | 2 +-
drivers/media/usb/usbvision/Makefile | 2 --
36 files changed, 50 insertions(+), 64 deletions(-)
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 1/3] media: coda: remove -I$(src) header search path
2019-01-25 6:54 ` Masahiro Yamada
(?)
@ 2019-01-25 6:54 ` Masahiro Yamada
-1 siblings, 0 replies; 15+ messages in thread
From: Masahiro Yamada @ 2019-01-25 6:54 UTC (permalink / raw)
To: Mauro Carvalho Chehab, linux-media
Cc: Masahiro Yamada, Philipp Zabel, linux-kernel
Remove the header search path to the current directory.
The compiler will search headers in the current directory by
using #include "..." instead of #include <...>
Also, change TRACE_INCLUDE_PATH to point to the location of trace.h.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/media/platform/coda/Makefile | 2 --
drivers/media/platform/coda/coda-h264.c | 3 ++-
drivers/media/platform/coda/trace.h | 2 +-
3 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/media/platform/coda/Makefile b/drivers/media/platform/coda/Makefile
index 8582843..3eed821 100644
--- a/drivers/media/platform/coda/Makefile
+++ b/drivers/media/platform/coda/Makefile
@@ -1,5 +1,3 @@
-ccflags-y += -I$(src)
-
coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-jpeg.o
obj-$(CONFIG_VIDEO_CODA) += coda.o
diff --git a/drivers/media/platform/coda/coda-h264.c b/drivers/media/platform/coda/coda-h264.c
index 635356a..6da82d1 100644
--- a/drivers/media/platform/coda/coda-h264.c
+++ b/drivers/media/platform/coda/coda-h264.c
@@ -14,7 +14,8 @@
#include <linux/kernel.h>
#include <linux/string.h>
#include <linux/videodev2.h>
-#include <coda.h>
+
+#include "coda.h"
static const u8 coda_filler_size[8] = { 0, 7, 14, 13, 12, 11, 10, 9 };
diff --git a/drivers/media/platform/coda/trace.h b/drivers/media/platform/coda/trace.h
index a672bfc..6cf5823 100644
--- a/drivers/media/platform/coda/trace.h
+++ b/drivers/media/platform/coda/trace.h
@@ -157,7 +157,7 @@ DEFINE_EVENT(coda_buf_meta_class, coda_dec_rot_done,
#endif /* __CODA_TRACE_H__ */
#undef TRACE_INCLUDE_PATH
-#define TRACE_INCLUDE_PATH .
+#define TRACE_INCLUDE_PATH ../../drivers/media/platform/coda
#undef TRACE_INCLUDE_FILE
#define TRACE_INCLUDE_FILE trace
--
2.7.4
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 2/3] media: remove unneeded header search paths
2019-01-25 6:54 ` Masahiro Yamada
@ 2019-01-25 6:54 ` Masahiro Yamada
-1 siblings, 0 replies; 15+ messages in thread
From: Masahiro Yamada @ 2019-01-25 6:54 UTC (permalink / raw)
To: Mauro Carvalho Chehab, linux-media
Cc: Masahiro Yamada, Patrice Chotard, linux-kernel, Hans Verkuil,
Yasunari Takiguchi, linux-arm-kernel
I was able to build without these extra header search paths.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/media/dvb-frontends/cxd2880/Makefile | 2 --
drivers/media/pci/bt8xx/Makefile | 1 -
drivers/media/platform/sti/c8sectpfe/Makefile | 1 -
drivers/media/radio/Makefile | 2 --
drivers/media/spi/Makefile | 2 --
drivers/media/usb/cx231xx/Makefile | 1 -
drivers/media/usb/usbvision/Makefile | 2 --
7 files changed, 11 deletions(-)
diff --git a/drivers/media/dvb-frontends/cxd2880/Makefile b/drivers/media/dvb-frontends/cxd2880/Makefile
index c6baa4c..646598b 100644
--- a/drivers/media/dvb-frontends/cxd2880/Makefile
+++ b/drivers/media/dvb-frontends/cxd2880/Makefile
@@ -14,5 +14,3 @@ cxd2880-objs := cxd2880_common.o \
cxd2880_top.o
obj-$(CONFIG_DVB_CXD2880) += cxd2880.o
-
-ccflags-y += -Idrivers/media/dvb-frontends
diff --git a/drivers/media/pci/bt8xx/Makefile b/drivers/media/pci/bt8xx/Makefile
index 7f1c3be..0b5032c 100644
--- a/drivers/media/pci/bt8xx/Makefile
+++ b/drivers/media/pci/bt8xx/Makefile
@@ -7,5 +7,4 @@ obj-$(CONFIG_VIDEO_BT848) += bttv.o
obj-$(CONFIG_DVB_BT8XX) += bt878.o dvb-bt8xx.o dst.o dst_ca.o
ccflags-y += -Idrivers/media/dvb-frontends
-ccflags-y += -Idrivers/media/common
ccflags-y += -Idrivers/media/tuners
diff --git a/drivers/media/platform/sti/c8sectpfe/Makefile b/drivers/media/platform/sti/c8sectpfe/Makefile
index 34d6947..4bf0c6b 100644
--- a/drivers/media/platform/sti/c8sectpfe/Makefile
+++ b/drivers/media/platform/sti/c8sectpfe/Makefile
@@ -4,6 +4,5 @@ c8sectpfe-y += c8sectpfe-core.o c8sectpfe-common.o c8sectpfe-dvb.o \
obj-$(CONFIG_DVB_C8SECTPFE) += c8sectpfe.o
-ccflags-y += -Idrivers/media/common
ccflags-y += -Idrivers/media/dvb-frontends/
ccflags-y += -Idrivers/media/tuners/
diff --git a/drivers/media/radio/Makefile b/drivers/media/radio/Makefile
index 37e6e82..53c7ae1 100644
--- a/drivers/media/radio/Makefile
+++ b/drivers/media/radio/Makefile
@@ -36,5 +36,3 @@ obj-$(CONFIG_RADIO_TEA575X) += tea575x.o
obj-$(CONFIG_USB_RAREMONO) += radio-raremono.o
shark2-objs := radio-shark2.o radio-tea5777.o
-
-ccflags-y += -Isound
diff --git a/drivers/media/spi/Makefile b/drivers/media/spi/Makefile
index 9e53677..c254e2a 100644
--- a/drivers/media/spi/Makefile
+++ b/drivers/media/spi/Makefile
@@ -1,6 +1,4 @@
obj-$(CONFIG_VIDEO_GS1662) += gs1662.o
obj-$(CONFIG_CXD2880_SPI_DRV) += cxd2880-spi.o
-ccflags-y += -Idrivers/media/dvb-core
-ccflags-y += -Idrivers/media/dvb-frontends
ccflags-y += -Idrivers/media/dvb-frontends/cxd2880
diff --git a/drivers/media/usb/cx231xx/Makefile b/drivers/media/usb/cx231xx/Makefile
index c023d97..af824fd 100644
--- a/drivers/media/usb/cx231xx/Makefile
+++ b/drivers/media/usb/cx231xx/Makefile
@@ -11,4 +11,3 @@ obj-$(CONFIG_VIDEO_CX231XX_DVB) += cx231xx-dvb.o
ccflags-y += -Idrivers/media/tuners
ccflags-y += -Idrivers/media/dvb-frontends
-ccflags-y += -Idrivers/media/usb/dvb-usb
diff --git a/drivers/media/usb/usbvision/Makefile b/drivers/media/usb/usbvision/Makefile
index 494d030..e8e5eda 100644
--- a/drivers/media/usb/usbvision/Makefile
+++ b/drivers/media/usb/usbvision/Makefile
@@ -1,5 +1,3 @@
usbvision-objs := usbvision-core.o usbvision-video.o usbvision-i2c.o usbvision-cards.o
obj-$(CONFIG_VIDEO_USBVISION) += usbvision.o
-
-ccflags-y += -Idrivers/media/tuners
--
2.7.4
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 2/3] media: remove unneeded header search paths
@ 2019-01-25 6:54 ` Masahiro Yamada
0 siblings, 0 replies; 15+ messages in thread
From: Masahiro Yamada @ 2019-01-25 6:54 UTC (permalink / raw)
To: Mauro Carvalho Chehab, linux-media
Cc: Yasunari Takiguchi, Patrice Chotard, linux-kernel, Hans Verkuil,
Masahiro Yamada, linux-arm-kernel
I was able to build without these extra header search paths.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/media/dvb-frontends/cxd2880/Makefile | 2 --
drivers/media/pci/bt8xx/Makefile | 1 -
drivers/media/platform/sti/c8sectpfe/Makefile | 1 -
drivers/media/radio/Makefile | 2 --
drivers/media/spi/Makefile | 2 --
drivers/media/usb/cx231xx/Makefile | 1 -
drivers/media/usb/usbvision/Makefile | 2 --
7 files changed, 11 deletions(-)
diff --git a/drivers/media/dvb-frontends/cxd2880/Makefile b/drivers/media/dvb-frontends/cxd2880/Makefile
index c6baa4c..646598b 100644
--- a/drivers/media/dvb-frontends/cxd2880/Makefile
+++ b/drivers/media/dvb-frontends/cxd2880/Makefile
@@ -14,5 +14,3 @@ cxd2880-objs := cxd2880_common.o \
cxd2880_top.o
obj-$(CONFIG_DVB_CXD2880) += cxd2880.o
-
-ccflags-y += -Idrivers/media/dvb-frontends
diff --git a/drivers/media/pci/bt8xx/Makefile b/drivers/media/pci/bt8xx/Makefile
index 7f1c3be..0b5032c 100644
--- a/drivers/media/pci/bt8xx/Makefile
+++ b/drivers/media/pci/bt8xx/Makefile
@@ -7,5 +7,4 @@ obj-$(CONFIG_VIDEO_BT848) += bttv.o
obj-$(CONFIG_DVB_BT8XX) += bt878.o dvb-bt8xx.o dst.o dst_ca.o
ccflags-y += -Idrivers/media/dvb-frontends
-ccflags-y += -Idrivers/media/common
ccflags-y += -Idrivers/media/tuners
diff --git a/drivers/media/platform/sti/c8sectpfe/Makefile b/drivers/media/platform/sti/c8sectpfe/Makefile
index 34d6947..4bf0c6b 100644
--- a/drivers/media/platform/sti/c8sectpfe/Makefile
+++ b/drivers/media/platform/sti/c8sectpfe/Makefile
@@ -4,6 +4,5 @@ c8sectpfe-y += c8sectpfe-core.o c8sectpfe-common.o c8sectpfe-dvb.o \
obj-$(CONFIG_DVB_C8SECTPFE) += c8sectpfe.o
-ccflags-y += -Idrivers/media/common
ccflags-y += -Idrivers/media/dvb-frontends/
ccflags-y += -Idrivers/media/tuners/
diff --git a/drivers/media/radio/Makefile b/drivers/media/radio/Makefile
index 37e6e82..53c7ae1 100644
--- a/drivers/media/radio/Makefile
+++ b/drivers/media/radio/Makefile
@@ -36,5 +36,3 @@ obj-$(CONFIG_RADIO_TEA575X) += tea575x.o
obj-$(CONFIG_USB_RAREMONO) += radio-raremono.o
shark2-objs := radio-shark2.o radio-tea5777.o
-
-ccflags-y += -Isound
diff --git a/drivers/media/spi/Makefile b/drivers/media/spi/Makefile
index 9e53677..c254e2a 100644
--- a/drivers/media/spi/Makefile
+++ b/drivers/media/spi/Makefile
@@ -1,6 +1,4 @@
obj-$(CONFIG_VIDEO_GS1662) += gs1662.o
obj-$(CONFIG_CXD2880_SPI_DRV) += cxd2880-spi.o
-ccflags-y += -Idrivers/media/dvb-core
-ccflags-y += -Idrivers/media/dvb-frontends
ccflags-y += -Idrivers/media/dvb-frontends/cxd2880
diff --git a/drivers/media/usb/cx231xx/Makefile b/drivers/media/usb/cx231xx/Makefile
index c023d97..af824fd 100644
--- a/drivers/media/usb/cx231xx/Makefile
+++ b/drivers/media/usb/cx231xx/Makefile
@@ -11,4 +11,3 @@ obj-$(CONFIG_VIDEO_CX231XX_DVB) += cx231xx-dvb.o
ccflags-y += -Idrivers/media/tuners
ccflags-y += -Idrivers/media/dvb-frontends
-ccflags-y += -Idrivers/media/usb/dvb-usb
diff --git a/drivers/media/usb/usbvision/Makefile b/drivers/media/usb/usbvision/Makefile
index 494d030..e8e5eda 100644
--- a/drivers/media/usb/usbvision/Makefile
+++ b/drivers/media/usb/usbvision/Makefile
@@ -1,5 +1,3 @@
usbvision-objs := usbvision-core.o usbvision-video.o usbvision-i2c.o usbvision-cards.o
obj-$(CONFIG_VIDEO_USBVISION) += usbvision.o
-
-ccflags-y += -Idrivers/media/tuners
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 3/3] media: prefix header search paths with $(srctree)/
2019-01-25 6:54 ` Masahiro Yamada
@ 2019-01-25 6:54 ` Masahiro Yamada
-1 siblings, 0 replies; 15+ messages in thread
From: Masahiro Yamada @ 2019-01-25 6:54 UTC (permalink / raw)
To: Mauro Carvalho Chehab, linux-media
Cc: Masahiro Yamada, Sakari Ailus, Patrice Chotard, Akihiro Tsukada,
linux-kernel, Abylay Ospan, Hans Verkuil, Sergey Kozlov,
Mike Isely, Andy Walls, linux-arm-kernel
Currently, the Kbuild core manipulates header search paths in a crazy
way [1].
To fix this mess, I want all Makefiles to add explicit $(srctree)/ to
the search paths in the srctree. Some Makefiles are already written in
that way, but not all. The goal of this work is to make the notation
consistent, and finally get rid of the gross hacks.
Having whitespaces after -I does not matter since commit 48f6e3cf5bc6
("kbuild: do not drop -I without parameter").
[1]: https://patchwork.kernel.org/patch/9632347/
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/media/common/b2c2/Makefile | 4 ++--
drivers/media/i2c/smiapp/Makefile | 2 +-
drivers/media/mmc/siano/Makefile | 3 +--
drivers/media/pci/b2c2/Makefile | 2 +-
drivers/media/pci/bt8xx/Makefile | 4 ++--
drivers/media/pci/cx18/Makefile | 4 ++--
drivers/media/pci/cx23885/Makefile | 4 ++--
drivers/media/pci/cx88/Makefile | 4 ++--
drivers/media/pci/ddbridge/Makefile | 4 ++--
drivers/media/pci/dm1105/Makefile | 2 +-
drivers/media/pci/mantis/Makefile | 2 +-
drivers/media/pci/netup_unidvb/Makefile | 2 +-
drivers/media/pci/ngene/Makefile | 4 ++--
drivers/media/pci/pluto2/Makefile | 2 +-
drivers/media/pci/pt1/Makefile | 4 ++--
drivers/media/pci/pt3/Makefile | 4 ++--
drivers/media/pci/smipcie/Makefile | 5 ++---
drivers/media/pci/ttpci/Makefile | 4 ++--
drivers/media/platform/sti/c8sectpfe/Makefile | 4 ++--
drivers/media/spi/Makefile | 2 +-
drivers/media/usb/as102/Makefile | 2 +-
drivers/media/usb/au0828/Makefile | 4 ++--
drivers/media/usb/b2c2/Makefile | 2 +-
drivers/media/usb/cx231xx/Makefile | 4 ++--
drivers/media/usb/em28xx/Makefile | 4 ++--
drivers/media/usb/go7007/Makefile | 2 +-
drivers/media/usb/pvrusb2/Makefile | 4 ++--
drivers/media/usb/siano/Makefile | 2 +-
drivers/media/usb/tm6000/Makefile | 4 ++--
drivers/media/usb/ttusb-budget/Makefile | 2 +-
30 files changed, 47 insertions(+), 49 deletions(-)
diff --git a/drivers/media/common/b2c2/Makefile b/drivers/media/common/b2c2/Makefile
index aa2dc24..0e32b77 100644
--- a/drivers/media/common/b2c2/Makefile
+++ b/drivers/media/common/b2c2/Makefile
@@ -4,5 +4,5 @@ b2c2-flexcop-objs += flexcop-sram.o flexcop-eeprom.o flexcop-misc.o
b2c2-flexcop-objs += flexcop-hw-filter.o
obj-$(CONFIG_DVB_B2C2_FLEXCOP) += b2c2-flexcop.o
-ccflags-y += -Idrivers/media/dvb-frontends/
-ccflags-y += -Idrivers/media/tuners/
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends/
+ccflags-y += -I $(srctree)/drivers/media/tuners/
diff --git a/drivers/media/i2c/smiapp/Makefile b/drivers/media/i2c/smiapp/Makefile
index f45a003..9f03aef 100644
--- a/drivers/media/i2c/smiapp/Makefile
+++ b/drivers/media/i2c/smiapp/Makefile
@@ -2,4 +2,4 @@ smiapp-objs += smiapp-core.o smiapp-regs.o \
smiapp-quirk.o smiapp-limits.o
obj-$(CONFIG_VIDEO_SMIAPP) += smiapp.o
-ccflags-y += -Idrivers/media/i2c
+ccflags-y += -I $(srctree)/drivers/media/i2c
diff --git a/drivers/media/mmc/siano/Makefile b/drivers/media/mmc/siano/Makefile
index 5fc3456..848548f 100644
--- a/drivers/media/mmc/siano/Makefile
+++ b/drivers/media/mmc/siano/Makefile
@@ -1,4 +1,3 @@
obj-$(CONFIG_SMS_SDIO_DRV) += smssdio.o
-ccflags-y += -Idrivers/media/common/siano
-
+ccflags-y += -I $(srctree)/drivers/media/common/siano
diff --git a/drivers/media/pci/b2c2/Makefile b/drivers/media/pci/b2c2/Makefile
index b43b916..14ed6e4 100644
--- a/drivers/media/pci/b2c2/Makefile
+++ b/drivers/media/pci/b2c2/Makefile
@@ -6,4 +6,4 @@ endif
b2c2-flexcop-pci-objs += flexcop-pci.o
obj-$(CONFIG_DVB_B2C2_FLEXCOP_PCI) += b2c2-flexcop-pci.o
-ccflags-y += -Idrivers/media/common/b2c2/
+ccflags-y += -I $(srctree)/drivers/media/common/b2c2/
diff --git a/drivers/media/pci/bt8xx/Makefile b/drivers/media/pci/bt8xx/Makefile
index 0b5032c..69bc0d9 100644
--- a/drivers/media/pci/bt8xx/Makefile
+++ b/drivers/media/pci/bt8xx/Makefile
@@ -6,5 +6,5 @@ bttv-objs := bttv-driver.o bttv-cards.o bttv-if.o \
obj-$(CONFIG_VIDEO_BT848) += bttv.o
obj-$(CONFIG_DVB_BT8XX) += bt878.o dvb-bt8xx.o dst.o dst_ca.o
-ccflags-y += -Idrivers/media/dvb-frontends
-ccflags-y += -Idrivers/media/tuners
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends
+ccflags-y += -I $(srctree)/drivers/media/tuners
diff --git a/drivers/media/pci/cx18/Makefile b/drivers/media/pci/cx18/Makefile
index 9c82c2d..df00ef8 100644
--- a/drivers/media/pci/cx18/Makefile
+++ b/drivers/media/pci/cx18/Makefile
@@ -9,5 +9,5 @@ cx18-alsa-objs := cx18-alsa-main.o cx18-alsa-pcm.o
obj-$(CONFIG_VIDEO_CX18) += cx18.o
obj-$(CONFIG_VIDEO_CX18_ALSA) += cx18-alsa.o
-ccflags-y += -Idrivers/media/dvb-frontends
-ccflags-y += -Idrivers/media/tuners
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends
+ccflags-y += -I $(srctree)/drivers/media/tuners
diff --git a/drivers/media/pci/cx23885/Makefile b/drivers/media/pci/cx23885/Makefile
index 130f0aa..a785169 100644
--- a/drivers/media/pci/cx23885/Makefile
+++ b/drivers/media/pci/cx23885/Makefile
@@ -8,7 +8,7 @@ cx23885-objs := cx23885-cards.o cx23885-video.o cx23885-vbi.o \
obj-$(CONFIG_VIDEO_CX23885) += cx23885.o
obj-$(CONFIG_MEDIA_ALTERA_CI) += altera-ci.o
-ccflags-y += -Idrivers/media/tuners
-ccflags-y += -Idrivers/media/dvb-frontends
+ccflags-y += -I $(srctree)/drivers/media/tuners
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends
ccflags-y += $(extra-cflags-y) $(extra-cflags-m)
diff --git a/drivers/media/pci/cx88/Makefile b/drivers/media/pci/cx88/Makefile
index d0f45d6..c2a0158 100644
--- a/drivers/media/pci/cx88/Makefile
+++ b/drivers/media/pci/cx88/Makefile
@@ -10,5 +10,5 @@ obj-$(CONFIG_VIDEO_CX88_ALSA) += cx88-alsa.o
obj-$(CONFIG_VIDEO_CX88_BLACKBIRD) += cx88-blackbird.o
obj-$(CONFIG_VIDEO_CX88_DVB) += cx88-dvb.o
obj-$(CONFIG_VIDEO_CX88_VP3054) += cx88-vp3054-i2c.o
-ccflags-y += -Idrivers/media/tuners
-ccflags-y += -Idrivers/media/dvb-frontends
+ccflags-y += -I $(srctree)/drivers/media/tuners
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends
diff --git a/drivers/media/pci/ddbridge/Makefile b/drivers/media/pci/ddbridge/Makefile
index 5b6d5bb..2b77c8d 100644
--- a/drivers/media/pci/ddbridge/Makefile
+++ b/drivers/media/pci/ddbridge/Makefile
@@ -9,5 +9,5 @@ ddbridge-objs := ddbridge-main.o ddbridge-core.o ddbridge-ci.o \
obj-$(CONFIG_DVB_DDBRIDGE) += ddbridge.o
-ccflags-y += -Idrivers/media/dvb-frontends/
-ccflags-y += -Idrivers/media/tuners/
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends/
+ccflags-y += -I $(srctree)/drivers/media/tuners/
diff --git a/drivers/media/pci/dm1105/Makefile b/drivers/media/pci/dm1105/Makefile
index d22c254..87e8e80 100644
--- a/drivers/media/pci/dm1105/Makefile
+++ b/drivers/media/pci/dm1105/Makefile
@@ -1,3 +1,3 @@
obj-$(CONFIG_DVB_DM1105) += dm1105.o
-ccflags-y += -Idrivers/media/dvb-frontends
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends
diff --git a/drivers/media/pci/mantis/Makefile b/drivers/media/pci/mantis/Makefile
index b5ef396..49e8224 100644
--- a/drivers/media/pci/mantis/Makefile
+++ b/drivers/media/pci/mantis/Makefile
@@ -26,4 +26,4 @@ obj-$(CONFIG_MANTIS_CORE) += mantis_core.o
obj-$(CONFIG_DVB_MANTIS) += mantis.o
obj-$(CONFIG_DVB_HOPPER) += hopper.o
-ccflags-y += -Idrivers/media/dvb-frontends/
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends/
diff --git a/drivers/media/pci/netup_unidvb/Makefile b/drivers/media/pci/netup_unidvb/Makefile
index 944c3e1..215bdaf 100644
--- a/drivers/media/pci/netup_unidvb/Makefile
+++ b/drivers/media/pci/netup_unidvb/Makefile
@@ -6,4 +6,4 @@ netup-unidvb-objs += netup_unidvb_spi.o
obj-$(CONFIG_DVB_NETUP_UNIDVB) += netup-unidvb.o
-ccflags-y += -Idrivers/media/dvb-frontends
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends
diff --git a/drivers/media/pci/ngene/Makefile b/drivers/media/pci/ngene/Makefile
index ec450ad..5d16090 100644
--- a/drivers/media/pci/ngene/Makefile
+++ b/drivers/media/pci/ngene/Makefile
@@ -7,5 +7,5 @@ ngene-objs := ngene-core.o ngene-i2c.o ngene-cards.o ngene-dvb.o
obj-$(CONFIG_DVB_NGENE) += ngene.o
-ccflags-y += -Idrivers/media/dvb-frontends/
-ccflags-y += -Idrivers/media/tuners/
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends/
+ccflags-y += -I $(srctree)/drivers/media/tuners/
diff --git a/drivers/media/pci/pluto2/Makefile b/drivers/media/pci/pluto2/Makefile
index 3c2aea1..4d21a2c 100644
--- a/drivers/media/pci/pluto2/Makefile
+++ b/drivers/media/pci/pluto2/Makefile
@@ -1,3 +1,3 @@
obj-$(CONFIG_DVB_PLUTO2) += pluto2.o
-ccflags-y += -Idrivers/media/dvb-frontends/
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends/
diff --git a/drivers/media/pci/pt1/Makefile b/drivers/media/pci/pt1/Makefile
index bc491e0..f80a1cd 100644
--- a/drivers/media/pci/pt1/Makefile
+++ b/drivers/media/pci/pt1/Makefile
@@ -2,5 +2,5 @@ earth-pt1-objs := pt1.o
obj-$(CONFIG_DVB_PT1) += earth-pt1.o
-ccflags-y += -Idrivers/media/dvb-frontends
-ccflags-y += -Idrivers/media/tuners
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends
+ccflags-y += -I $(srctree)/drivers/media/tuners
diff --git a/drivers/media/pci/pt3/Makefile b/drivers/media/pci/pt3/Makefile
index 8698d5d..da6b265 100644
--- a/drivers/media/pci/pt3/Makefile
+++ b/drivers/media/pci/pt3/Makefile
@@ -4,5 +4,5 @@ earth-pt3-objs += pt3.o pt3_i2c.o pt3_dma.o
obj-$(CONFIG_DVB_PT3) += earth-pt3.o
-ccflags-y += -Idrivers/media/dvb-frontends
-ccflags-y += -Idrivers/media/tuners
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends
+ccflags-y += -I $(srctree)/drivers/media/tuners
diff --git a/drivers/media/pci/smipcie/Makefile b/drivers/media/pci/smipcie/Makefile
index 214ebfe..2426b75 100644
--- a/drivers/media/pci/smipcie/Makefile
+++ b/drivers/media/pci/smipcie/Makefile
@@ -4,6 +4,5 @@ smipcie-objs := smipcie-main.o smipcie-ir.o
obj-$(CONFIG_DVB_SMIPCIE) += smipcie.o
-ccflags-y += -Idrivers/media/tuners
-ccflags-y += -Idrivers/media/dvb-frontends
-
+ccflags-y += -I $(srctree)/drivers/media/tuners
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends
diff --git a/drivers/media/pci/ttpci/Makefile b/drivers/media/pci/ttpci/Makefile
index 58ca127..9b44c47 100644
--- a/drivers/media/pci/ttpci/Makefile
+++ b/drivers/media/pci/ttpci/Makefile
@@ -18,5 +18,5 @@ obj-$(CONFIG_DVB_BUDGET_CI) += budget-ci.o
obj-$(CONFIG_DVB_BUDGET_PATCH) += budget-patch.o
obj-$(CONFIG_DVB_AV7110) += dvb-ttpci.o
-ccflags-y += -Idrivers/media/dvb-frontends/
-ccflags-y += -Idrivers/media/tuners
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends/
+ccflags-y += -I $(srctree)/drivers/media/tuners
diff --git a/drivers/media/platform/sti/c8sectpfe/Makefile b/drivers/media/platform/sti/c8sectpfe/Makefile
index 4bf0c6b..aedfc72 100644
--- a/drivers/media/platform/sti/c8sectpfe/Makefile
+++ b/drivers/media/platform/sti/c8sectpfe/Makefile
@@ -4,5 +4,5 @@ c8sectpfe-y += c8sectpfe-core.o c8sectpfe-common.o c8sectpfe-dvb.o \
obj-$(CONFIG_DVB_C8SECTPFE) += c8sectpfe.o
-ccflags-y += -Idrivers/media/dvb-frontends/
-ccflags-y += -Idrivers/media/tuners/
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends/
+ccflags-y += -I $(srctree)/drivers/media/tuners/
diff --git a/drivers/media/spi/Makefile b/drivers/media/spi/Makefile
index c254e2a..446e6c5 100644
--- a/drivers/media/spi/Makefile
+++ b/drivers/media/spi/Makefile
@@ -1,4 +1,4 @@
obj-$(CONFIG_VIDEO_GS1662) += gs1662.o
obj-$(CONFIG_CXD2880_SPI_DRV) += cxd2880-spi.o
-ccflags-y += -Idrivers/media/dvb-frontends/cxd2880
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends/cxd2880
diff --git a/drivers/media/usb/as102/Makefile b/drivers/media/usb/as102/Makefile
index b0b3196..de671ae 100644
--- a/drivers/media/usb/as102/Makefile
+++ b/drivers/media/usb/as102/Makefile
@@ -4,4 +4,4 @@ dvb-as102-objs := as102_drv.o as102_fw.o as10x_cmd.o as10x_cmd_stream.o \
obj-$(CONFIG_DVB_AS102) += dvb-as102.o
-ccflags-y += -Idrivers/media/dvb-frontends
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends
diff --git a/drivers/media/usb/au0828/Makefile b/drivers/media/usb/au0828/Makefile
index 5691881..4347812 100644
--- a/drivers/media/usb/au0828/Makefile
+++ b/drivers/media/usb/au0828/Makefile
@@ -11,7 +11,7 @@ endif
obj-$(CONFIG_VIDEO_AU0828) += au0828.o
-ccflags-y += -Idrivers/media/tuners
-ccflags-y += -Idrivers/media/dvb-frontends
+ccflags-y += -I $(srctree)/drivers/media/tuners
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends
ccflags-y += $(extra-cflags-y) $(extra-cflags-m)
diff --git a/drivers/media/usb/b2c2/Makefile b/drivers/media/usb/b2c2/Makefile
index f3cef05..e7f949d 100644
--- a/drivers/media/usb/b2c2/Makefile
+++ b/drivers/media/usb/b2c2/Makefile
@@ -1,4 +1,4 @@
b2c2-flexcop-usb-objs := flexcop-usb.o
obj-$(CONFIG_DVB_B2C2_FLEXCOP_USB) += b2c2-flexcop-usb.o
-ccflags-y += -Idrivers/media/common/b2c2/
+ccflags-y += -I $(srctree)/drivers/media/common/b2c2/
diff --git a/drivers/media/usb/cx231xx/Makefile b/drivers/media/usb/cx231xx/Makefile
index af824fd..8acbbcb 100644
--- a/drivers/media/usb/cx231xx/Makefile
+++ b/drivers/media/usb/cx231xx/Makefile
@@ -9,5 +9,5 @@ obj-$(CONFIG_VIDEO_CX231XX) += cx231xx.o
obj-$(CONFIG_VIDEO_CX231XX_ALSA) += cx231xx-alsa.o
obj-$(CONFIG_VIDEO_CX231XX_DVB) += cx231xx-dvb.o
-ccflags-y += -Idrivers/media/tuners
-ccflags-y += -Idrivers/media/dvb-frontends
+ccflags-y += -I $(srctree)/drivers/media/tuners
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends
diff --git a/drivers/media/usb/em28xx/Makefile b/drivers/media/usb/em28xx/Makefile
index 8a22400..8c2fc31 100644
--- a/drivers/media/usb/em28xx/Makefile
+++ b/drivers/media/usb/em28xx/Makefile
@@ -11,5 +11,5 @@ obj-$(CONFIG_VIDEO_EM28XX_ALSA) += em28xx-alsa.o
obj-$(CONFIG_VIDEO_EM28XX_DVB) += em28xx-dvb.o
obj-$(CONFIG_VIDEO_EM28XX_RC) += em28xx-rc.o
-ccflags-y += -Idrivers/media/tuners
-ccflags-y += -Idrivers/media/dvb-frontends
+ccflags-y += -I $(srctree)/drivers/media/tuners
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends
diff --git a/drivers/media/usb/go7007/Makefile b/drivers/media/usb/go7007/Makefile
index 3d95bbc..712a350 100644
--- a/drivers/media/usb/go7007/Makefile
+++ b/drivers/media/usb/go7007/Makefile
@@ -9,4 +9,4 @@ go7007-y := go7007-v4l2.o go7007-driver.o go7007-i2c.o go7007-fw.o \
s2250-y := s2250-board.o
-ccflags-$(CONFIG_VIDEO_GO7007_LOADER:m=y) += -Idrivers/media/common
+ccflags-$(CONFIG_VIDEO_GO7007_LOADER:m=y) += -I $(srctree)/drivers/media/common
diff --git a/drivers/media/usb/pvrusb2/Makefile b/drivers/media/usb/pvrusb2/Makefile
index 9facf68..2e71afc 100644
--- a/drivers/media/usb/pvrusb2/Makefile
+++ b/drivers/media/usb/pvrusb2/Makefile
@@ -17,5 +17,5 @@ pvrusb2-objs := pvrusb2-i2c-core.o \
obj-$(CONFIG_VIDEO_PVRUSB2) += pvrusb2.o
-ccflags-y += -Idrivers/media/tuners
-ccflags-y += -Idrivers/media/dvb-frontends
+ccflags-y += -I $(srctree)/drivers/media/tuners
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends
diff --git a/drivers/media/usb/siano/Makefile b/drivers/media/usb/siano/Makefile
index 7d48864..ba56e98 100644
--- a/drivers/media/usb/siano/Makefile
+++ b/drivers/media/usb/siano/Makefile
@@ -1,5 +1,5 @@
obj-$(CONFIG_SMS_USB_DRV) += smsusb.o
-ccflags-y += -Idrivers/media/common/siano
+ccflags-y += -I $(srctree)/drivers/media/common/siano
ccflags-y += $(extra-cflags-y) $(extra-cflags-m)
diff --git a/drivers/media/usb/tm6000/Makefile b/drivers/media/usb/tm6000/Makefile
index 744c039..75247a0 100644
--- a/drivers/media/usb/tm6000/Makefile
+++ b/drivers/media/usb/tm6000/Makefile
@@ -10,5 +10,5 @@ obj-$(CONFIG_VIDEO_TM6000) += tm6000.o
obj-$(CONFIG_VIDEO_TM6000_ALSA) += tm6000-alsa.o
obj-$(CONFIG_VIDEO_TM6000_DVB) += tm6000-dvb.o
-ccflags-y += -Idrivers/media/tuners
-ccflags-y += -Idrivers/media/dvb-frontends
+ccflags-y += -I $(srctree)/drivers/media/tuners
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends
diff --git a/drivers/media/usb/ttusb-budget/Makefile b/drivers/media/usb/ttusb-budget/Makefile
index fe4372d..37847d7 100644
--- a/drivers/media/usb/ttusb-budget/Makefile
+++ b/drivers/media/usb/ttusb-budget/Makefile
@@ -1,3 +1,3 @@
obj-$(CONFIG_DVB_TTUSB_BUDGET) += dvb-ttusb-budget.o
-ccflags-y += -Idrivers/media/dvb-frontends
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends
--
2.7.4
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 3/3] media: prefix header search paths with $(srctree)/
@ 2019-01-25 6:54 ` Masahiro Yamada
0 siblings, 0 replies; 15+ messages in thread
From: Masahiro Yamada @ 2019-01-25 6:54 UTC (permalink / raw)
To: Mauro Carvalho Chehab, linux-media
Cc: Abylay Ospan, Andy Walls, Sergey Kozlov, Akihiro Tsukada,
Patrice Chotard, linux-kernel, Masahiro Yamada, Sakari Ailus,
Hans Verkuil, Mike Isely, linux-arm-kernel
Currently, the Kbuild core manipulates header search paths in a crazy
way [1].
To fix this mess, I want all Makefiles to add explicit $(srctree)/ to
the search paths in the srctree. Some Makefiles are already written in
that way, but not all. The goal of this work is to make the notation
consistent, and finally get rid of the gross hacks.
Having whitespaces after -I does not matter since commit 48f6e3cf5bc6
("kbuild: do not drop -I without parameter").
[1]: https://patchwork.kernel.org/patch/9632347/
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/media/common/b2c2/Makefile | 4 ++--
drivers/media/i2c/smiapp/Makefile | 2 +-
drivers/media/mmc/siano/Makefile | 3 +--
drivers/media/pci/b2c2/Makefile | 2 +-
drivers/media/pci/bt8xx/Makefile | 4 ++--
drivers/media/pci/cx18/Makefile | 4 ++--
drivers/media/pci/cx23885/Makefile | 4 ++--
drivers/media/pci/cx88/Makefile | 4 ++--
drivers/media/pci/ddbridge/Makefile | 4 ++--
drivers/media/pci/dm1105/Makefile | 2 +-
drivers/media/pci/mantis/Makefile | 2 +-
drivers/media/pci/netup_unidvb/Makefile | 2 +-
drivers/media/pci/ngene/Makefile | 4 ++--
drivers/media/pci/pluto2/Makefile | 2 +-
drivers/media/pci/pt1/Makefile | 4 ++--
drivers/media/pci/pt3/Makefile | 4 ++--
drivers/media/pci/smipcie/Makefile | 5 ++---
drivers/media/pci/ttpci/Makefile | 4 ++--
drivers/media/platform/sti/c8sectpfe/Makefile | 4 ++--
drivers/media/spi/Makefile | 2 +-
drivers/media/usb/as102/Makefile | 2 +-
drivers/media/usb/au0828/Makefile | 4 ++--
drivers/media/usb/b2c2/Makefile | 2 +-
drivers/media/usb/cx231xx/Makefile | 4 ++--
drivers/media/usb/em28xx/Makefile | 4 ++--
drivers/media/usb/go7007/Makefile | 2 +-
drivers/media/usb/pvrusb2/Makefile | 4 ++--
drivers/media/usb/siano/Makefile | 2 +-
drivers/media/usb/tm6000/Makefile | 4 ++--
drivers/media/usb/ttusb-budget/Makefile | 2 +-
30 files changed, 47 insertions(+), 49 deletions(-)
diff --git a/drivers/media/common/b2c2/Makefile b/drivers/media/common/b2c2/Makefile
index aa2dc24..0e32b77 100644
--- a/drivers/media/common/b2c2/Makefile
+++ b/drivers/media/common/b2c2/Makefile
@@ -4,5 +4,5 @@ b2c2-flexcop-objs += flexcop-sram.o flexcop-eeprom.o flexcop-misc.o
b2c2-flexcop-objs += flexcop-hw-filter.o
obj-$(CONFIG_DVB_B2C2_FLEXCOP) += b2c2-flexcop.o
-ccflags-y += -Idrivers/media/dvb-frontends/
-ccflags-y += -Idrivers/media/tuners/
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends/
+ccflags-y += -I $(srctree)/drivers/media/tuners/
diff --git a/drivers/media/i2c/smiapp/Makefile b/drivers/media/i2c/smiapp/Makefile
index f45a003..9f03aef 100644
--- a/drivers/media/i2c/smiapp/Makefile
+++ b/drivers/media/i2c/smiapp/Makefile
@@ -2,4 +2,4 @@ smiapp-objs += smiapp-core.o smiapp-regs.o \
smiapp-quirk.o smiapp-limits.o
obj-$(CONFIG_VIDEO_SMIAPP) += smiapp.o
-ccflags-y += -Idrivers/media/i2c
+ccflags-y += -I $(srctree)/drivers/media/i2c
diff --git a/drivers/media/mmc/siano/Makefile b/drivers/media/mmc/siano/Makefile
index 5fc3456..848548f 100644
--- a/drivers/media/mmc/siano/Makefile
+++ b/drivers/media/mmc/siano/Makefile
@@ -1,4 +1,3 @@
obj-$(CONFIG_SMS_SDIO_DRV) += smssdio.o
-ccflags-y += -Idrivers/media/common/siano
-
+ccflags-y += -I $(srctree)/drivers/media/common/siano
diff --git a/drivers/media/pci/b2c2/Makefile b/drivers/media/pci/b2c2/Makefile
index b43b916..14ed6e4 100644
--- a/drivers/media/pci/b2c2/Makefile
+++ b/drivers/media/pci/b2c2/Makefile
@@ -6,4 +6,4 @@ endif
b2c2-flexcop-pci-objs += flexcop-pci.o
obj-$(CONFIG_DVB_B2C2_FLEXCOP_PCI) += b2c2-flexcop-pci.o
-ccflags-y += -Idrivers/media/common/b2c2/
+ccflags-y += -I $(srctree)/drivers/media/common/b2c2/
diff --git a/drivers/media/pci/bt8xx/Makefile b/drivers/media/pci/bt8xx/Makefile
index 0b5032c..69bc0d9 100644
--- a/drivers/media/pci/bt8xx/Makefile
+++ b/drivers/media/pci/bt8xx/Makefile
@@ -6,5 +6,5 @@ bttv-objs := bttv-driver.o bttv-cards.o bttv-if.o \
obj-$(CONFIG_VIDEO_BT848) += bttv.o
obj-$(CONFIG_DVB_BT8XX) += bt878.o dvb-bt8xx.o dst.o dst_ca.o
-ccflags-y += -Idrivers/media/dvb-frontends
-ccflags-y += -Idrivers/media/tuners
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends
+ccflags-y += -I $(srctree)/drivers/media/tuners
diff --git a/drivers/media/pci/cx18/Makefile b/drivers/media/pci/cx18/Makefile
index 9c82c2d..df00ef8 100644
--- a/drivers/media/pci/cx18/Makefile
+++ b/drivers/media/pci/cx18/Makefile
@@ -9,5 +9,5 @@ cx18-alsa-objs := cx18-alsa-main.o cx18-alsa-pcm.o
obj-$(CONFIG_VIDEO_CX18) += cx18.o
obj-$(CONFIG_VIDEO_CX18_ALSA) += cx18-alsa.o
-ccflags-y += -Idrivers/media/dvb-frontends
-ccflags-y += -Idrivers/media/tuners
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends
+ccflags-y += -I $(srctree)/drivers/media/tuners
diff --git a/drivers/media/pci/cx23885/Makefile b/drivers/media/pci/cx23885/Makefile
index 130f0aa..a785169 100644
--- a/drivers/media/pci/cx23885/Makefile
+++ b/drivers/media/pci/cx23885/Makefile
@@ -8,7 +8,7 @@ cx23885-objs := cx23885-cards.o cx23885-video.o cx23885-vbi.o \
obj-$(CONFIG_VIDEO_CX23885) += cx23885.o
obj-$(CONFIG_MEDIA_ALTERA_CI) += altera-ci.o
-ccflags-y += -Idrivers/media/tuners
-ccflags-y += -Idrivers/media/dvb-frontends
+ccflags-y += -I $(srctree)/drivers/media/tuners
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends
ccflags-y += $(extra-cflags-y) $(extra-cflags-m)
diff --git a/drivers/media/pci/cx88/Makefile b/drivers/media/pci/cx88/Makefile
index d0f45d6..c2a0158 100644
--- a/drivers/media/pci/cx88/Makefile
+++ b/drivers/media/pci/cx88/Makefile
@@ -10,5 +10,5 @@ obj-$(CONFIG_VIDEO_CX88_ALSA) += cx88-alsa.o
obj-$(CONFIG_VIDEO_CX88_BLACKBIRD) += cx88-blackbird.o
obj-$(CONFIG_VIDEO_CX88_DVB) += cx88-dvb.o
obj-$(CONFIG_VIDEO_CX88_VP3054) += cx88-vp3054-i2c.o
-ccflags-y += -Idrivers/media/tuners
-ccflags-y += -Idrivers/media/dvb-frontends
+ccflags-y += -I $(srctree)/drivers/media/tuners
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends
diff --git a/drivers/media/pci/ddbridge/Makefile b/drivers/media/pci/ddbridge/Makefile
index 5b6d5bb..2b77c8d 100644
--- a/drivers/media/pci/ddbridge/Makefile
+++ b/drivers/media/pci/ddbridge/Makefile
@@ -9,5 +9,5 @@ ddbridge-objs := ddbridge-main.o ddbridge-core.o ddbridge-ci.o \
obj-$(CONFIG_DVB_DDBRIDGE) += ddbridge.o
-ccflags-y += -Idrivers/media/dvb-frontends/
-ccflags-y += -Idrivers/media/tuners/
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends/
+ccflags-y += -I $(srctree)/drivers/media/tuners/
diff --git a/drivers/media/pci/dm1105/Makefile b/drivers/media/pci/dm1105/Makefile
index d22c254..87e8e80 100644
--- a/drivers/media/pci/dm1105/Makefile
+++ b/drivers/media/pci/dm1105/Makefile
@@ -1,3 +1,3 @@
obj-$(CONFIG_DVB_DM1105) += dm1105.o
-ccflags-y += -Idrivers/media/dvb-frontends
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends
diff --git a/drivers/media/pci/mantis/Makefile b/drivers/media/pci/mantis/Makefile
index b5ef396..49e8224 100644
--- a/drivers/media/pci/mantis/Makefile
+++ b/drivers/media/pci/mantis/Makefile
@@ -26,4 +26,4 @@ obj-$(CONFIG_MANTIS_CORE) += mantis_core.o
obj-$(CONFIG_DVB_MANTIS) += mantis.o
obj-$(CONFIG_DVB_HOPPER) += hopper.o
-ccflags-y += -Idrivers/media/dvb-frontends/
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends/
diff --git a/drivers/media/pci/netup_unidvb/Makefile b/drivers/media/pci/netup_unidvb/Makefile
index 944c3e1..215bdaf 100644
--- a/drivers/media/pci/netup_unidvb/Makefile
+++ b/drivers/media/pci/netup_unidvb/Makefile
@@ -6,4 +6,4 @@ netup-unidvb-objs += netup_unidvb_spi.o
obj-$(CONFIG_DVB_NETUP_UNIDVB) += netup-unidvb.o
-ccflags-y += -Idrivers/media/dvb-frontends
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends
diff --git a/drivers/media/pci/ngene/Makefile b/drivers/media/pci/ngene/Makefile
index ec450ad..5d16090 100644
--- a/drivers/media/pci/ngene/Makefile
+++ b/drivers/media/pci/ngene/Makefile
@@ -7,5 +7,5 @@ ngene-objs := ngene-core.o ngene-i2c.o ngene-cards.o ngene-dvb.o
obj-$(CONFIG_DVB_NGENE) += ngene.o
-ccflags-y += -Idrivers/media/dvb-frontends/
-ccflags-y += -Idrivers/media/tuners/
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends/
+ccflags-y += -I $(srctree)/drivers/media/tuners/
diff --git a/drivers/media/pci/pluto2/Makefile b/drivers/media/pci/pluto2/Makefile
index 3c2aea1..4d21a2c 100644
--- a/drivers/media/pci/pluto2/Makefile
+++ b/drivers/media/pci/pluto2/Makefile
@@ -1,3 +1,3 @@
obj-$(CONFIG_DVB_PLUTO2) += pluto2.o
-ccflags-y += -Idrivers/media/dvb-frontends/
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends/
diff --git a/drivers/media/pci/pt1/Makefile b/drivers/media/pci/pt1/Makefile
index bc491e0..f80a1cd 100644
--- a/drivers/media/pci/pt1/Makefile
+++ b/drivers/media/pci/pt1/Makefile
@@ -2,5 +2,5 @@ earth-pt1-objs := pt1.o
obj-$(CONFIG_DVB_PT1) += earth-pt1.o
-ccflags-y += -Idrivers/media/dvb-frontends
-ccflags-y += -Idrivers/media/tuners
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends
+ccflags-y += -I $(srctree)/drivers/media/tuners
diff --git a/drivers/media/pci/pt3/Makefile b/drivers/media/pci/pt3/Makefile
index 8698d5d..da6b265 100644
--- a/drivers/media/pci/pt3/Makefile
+++ b/drivers/media/pci/pt3/Makefile
@@ -4,5 +4,5 @@ earth-pt3-objs += pt3.o pt3_i2c.o pt3_dma.o
obj-$(CONFIG_DVB_PT3) += earth-pt3.o
-ccflags-y += -Idrivers/media/dvb-frontends
-ccflags-y += -Idrivers/media/tuners
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends
+ccflags-y += -I $(srctree)/drivers/media/tuners
diff --git a/drivers/media/pci/smipcie/Makefile b/drivers/media/pci/smipcie/Makefile
index 214ebfe..2426b75 100644
--- a/drivers/media/pci/smipcie/Makefile
+++ b/drivers/media/pci/smipcie/Makefile
@@ -4,6 +4,5 @@ smipcie-objs := smipcie-main.o smipcie-ir.o
obj-$(CONFIG_DVB_SMIPCIE) += smipcie.o
-ccflags-y += -Idrivers/media/tuners
-ccflags-y += -Idrivers/media/dvb-frontends
-
+ccflags-y += -I $(srctree)/drivers/media/tuners
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends
diff --git a/drivers/media/pci/ttpci/Makefile b/drivers/media/pci/ttpci/Makefile
index 58ca127..9b44c47 100644
--- a/drivers/media/pci/ttpci/Makefile
+++ b/drivers/media/pci/ttpci/Makefile
@@ -18,5 +18,5 @@ obj-$(CONFIG_DVB_BUDGET_CI) += budget-ci.o
obj-$(CONFIG_DVB_BUDGET_PATCH) += budget-patch.o
obj-$(CONFIG_DVB_AV7110) += dvb-ttpci.o
-ccflags-y += -Idrivers/media/dvb-frontends/
-ccflags-y += -Idrivers/media/tuners
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends/
+ccflags-y += -I $(srctree)/drivers/media/tuners
diff --git a/drivers/media/platform/sti/c8sectpfe/Makefile b/drivers/media/platform/sti/c8sectpfe/Makefile
index 4bf0c6b..aedfc72 100644
--- a/drivers/media/platform/sti/c8sectpfe/Makefile
+++ b/drivers/media/platform/sti/c8sectpfe/Makefile
@@ -4,5 +4,5 @@ c8sectpfe-y += c8sectpfe-core.o c8sectpfe-common.o c8sectpfe-dvb.o \
obj-$(CONFIG_DVB_C8SECTPFE) += c8sectpfe.o
-ccflags-y += -Idrivers/media/dvb-frontends/
-ccflags-y += -Idrivers/media/tuners/
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends/
+ccflags-y += -I $(srctree)/drivers/media/tuners/
diff --git a/drivers/media/spi/Makefile b/drivers/media/spi/Makefile
index c254e2a..446e6c5 100644
--- a/drivers/media/spi/Makefile
+++ b/drivers/media/spi/Makefile
@@ -1,4 +1,4 @@
obj-$(CONFIG_VIDEO_GS1662) += gs1662.o
obj-$(CONFIG_CXD2880_SPI_DRV) += cxd2880-spi.o
-ccflags-y += -Idrivers/media/dvb-frontends/cxd2880
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends/cxd2880
diff --git a/drivers/media/usb/as102/Makefile b/drivers/media/usb/as102/Makefile
index b0b3196..de671ae 100644
--- a/drivers/media/usb/as102/Makefile
+++ b/drivers/media/usb/as102/Makefile
@@ -4,4 +4,4 @@ dvb-as102-objs := as102_drv.o as102_fw.o as10x_cmd.o as10x_cmd_stream.o \
obj-$(CONFIG_DVB_AS102) += dvb-as102.o
-ccflags-y += -Idrivers/media/dvb-frontends
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends
diff --git a/drivers/media/usb/au0828/Makefile b/drivers/media/usb/au0828/Makefile
index 5691881..4347812 100644
--- a/drivers/media/usb/au0828/Makefile
+++ b/drivers/media/usb/au0828/Makefile
@@ -11,7 +11,7 @@ endif
obj-$(CONFIG_VIDEO_AU0828) += au0828.o
-ccflags-y += -Idrivers/media/tuners
-ccflags-y += -Idrivers/media/dvb-frontends
+ccflags-y += -I $(srctree)/drivers/media/tuners
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends
ccflags-y += $(extra-cflags-y) $(extra-cflags-m)
diff --git a/drivers/media/usb/b2c2/Makefile b/drivers/media/usb/b2c2/Makefile
index f3cef05..e7f949d 100644
--- a/drivers/media/usb/b2c2/Makefile
+++ b/drivers/media/usb/b2c2/Makefile
@@ -1,4 +1,4 @@
b2c2-flexcop-usb-objs := flexcop-usb.o
obj-$(CONFIG_DVB_B2C2_FLEXCOP_USB) += b2c2-flexcop-usb.o
-ccflags-y += -Idrivers/media/common/b2c2/
+ccflags-y += -I $(srctree)/drivers/media/common/b2c2/
diff --git a/drivers/media/usb/cx231xx/Makefile b/drivers/media/usb/cx231xx/Makefile
index af824fd..8acbbcb 100644
--- a/drivers/media/usb/cx231xx/Makefile
+++ b/drivers/media/usb/cx231xx/Makefile
@@ -9,5 +9,5 @@ obj-$(CONFIG_VIDEO_CX231XX) += cx231xx.o
obj-$(CONFIG_VIDEO_CX231XX_ALSA) += cx231xx-alsa.o
obj-$(CONFIG_VIDEO_CX231XX_DVB) += cx231xx-dvb.o
-ccflags-y += -Idrivers/media/tuners
-ccflags-y += -Idrivers/media/dvb-frontends
+ccflags-y += -I $(srctree)/drivers/media/tuners
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends
diff --git a/drivers/media/usb/em28xx/Makefile b/drivers/media/usb/em28xx/Makefile
index 8a22400..8c2fc31 100644
--- a/drivers/media/usb/em28xx/Makefile
+++ b/drivers/media/usb/em28xx/Makefile
@@ -11,5 +11,5 @@ obj-$(CONFIG_VIDEO_EM28XX_ALSA) += em28xx-alsa.o
obj-$(CONFIG_VIDEO_EM28XX_DVB) += em28xx-dvb.o
obj-$(CONFIG_VIDEO_EM28XX_RC) += em28xx-rc.o
-ccflags-y += -Idrivers/media/tuners
-ccflags-y += -Idrivers/media/dvb-frontends
+ccflags-y += -I $(srctree)/drivers/media/tuners
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends
diff --git a/drivers/media/usb/go7007/Makefile b/drivers/media/usb/go7007/Makefile
index 3d95bbc..712a350 100644
--- a/drivers/media/usb/go7007/Makefile
+++ b/drivers/media/usb/go7007/Makefile
@@ -9,4 +9,4 @@ go7007-y := go7007-v4l2.o go7007-driver.o go7007-i2c.o go7007-fw.o \
s2250-y := s2250-board.o
-ccflags-$(CONFIG_VIDEO_GO7007_LOADER:m=y) += -Idrivers/media/common
+ccflags-$(CONFIG_VIDEO_GO7007_LOADER:m=y) += -I $(srctree)/drivers/media/common
diff --git a/drivers/media/usb/pvrusb2/Makefile b/drivers/media/usb/pvrusb2/Makefile
index 9facf68..2e71afc 100644
--- a/drivers/media/usb/pvrusb2/Makefile
+++ b/drivers/media/usb/pvrusb2/Makefile
@@ -17,5 +17,5 @@ pvrusb2-objs := pvrusb2-i2c-core.o \
obj-$(CONFIG_VIDEO_PVRUSB2) += pvrusb2.o
-ccflags-y += -Idrivers/media/tuners
-ccflags-y += -Idrivers/media/dvb-frontends
+ccflags-y += -I $(srctree)/drivers/media/tuners
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends
diff --git a/drivers/media/usb/siano/Makefile b/drivers/media/usb/siano/Makefile
index 7d48864..ba56e98 100644
--- a/drivers/media/usb/siano/Makefile
+++ b/drivers/media/usb/siano/Makefile
@@ -1,5 +1,5 @@
obj-$(CONFIG_SMS_USB_DRV) += smsusb.o
-ccflags-y += -Idrivers/media/common/siano
+ccflags-y += -I $(srctree)/drivers/media/common/siano
ccflags-y += $(extra-cflags-y) $(extra-cflags-m)
diff --git a/drivers/media/usb/tm6000/Makefile b/drivers/media/usb/tm6000/Makefile
index 744c039..75247a0 100644
--- a/drivers/media/usb/tm6000/Makefile
+++ b/drivers/media/usb/tm6000/Makefile
@@ -10,5 +10,5 @@ obj-$(CONFIG_VIDEO_TM6000) += tm6000.o
obj-$(CONFIG_VIDEO_TM6000_ALSA) += tm6000-alsa.o
obj-$(CONFIG_VIDEO_TM6000_DVB) += tm6000-dvb.o
-ccflags-y += -Idrivers/media/tuners
-ccflags-y += -Idrivers/media/dvb-frontends
+ccflags-y += -I $(srctree)/drivers/media/tuners
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends
diff --git a/drivers/media/usb/ttusb-budget/Makefile b/drivers/media/usb/ttusb-budget/Makefile
index fe4372d..37847d7 100644
--- a/drivers/media/usb/ttusb-budget/Makefile
+++ b/drivers/media/usb/ttusb-budget/Makefile
@@ -1,3 +1,3 @@
obj-$(CONFIG_DVB_TTUSB_BUDGET) += dvb-ttusb-budget.o
-ccflags-y += -Idrivers/media/dvb-frontends
+ccflags-y += -I $(srctree)/drivers/media/dvb-frontends
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH 3/3] media: prefix header search paths with $(srctree)/
2019-01-25 6:54 ` Masahiro Yamada
@ 2019-04-12 7:06 ` Sakari Ailus
-1 siblings, 0 replies; 15+ messages in thread
From: Sakari Ailus @ 2019-04-12 7:06 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Mauro Carvalho Chehab, linux-media, Patrice Chotard,
Akihiro Tsukada, linux-kernel, Abylay Ospan, Hans Verkuil,
Sergey Kozlov, Mike Isely, Andy Walls, linux-arm-kernel
On Fri, Jan 25, 2019 at 03:54:19PM +0900, Masahiro Yamada wrote:
> Currently, the Kbuild core manipulates header search paths in a crazy
> way [1].
>
> To fix this mess, I want all Makefiles to add explicit $(srctree)/ to
> the search paths in the srctree. Some Makefiles are already written in
> that way, but not all. The goal of this work is to make the notation
> consistent, and finally get rid of the gross hacks.
>
> Having whitespaces after -I does not matter since commit 48f6e3cf5bc6
> ("kbuild: do not drop -I without parameter").
>
> [1]: https://patchwork.kernel.org/patch/9632347/
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Thanks, Yamada-san!
Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
--
Sakari Ailus
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH 3/3] media: prefix header search paths with $(srctree)/
@ 2019-04-12 7:06 ` Sakari Ailus
0 siblings, 0 replies; 15+ messages in thread
From: Sakari Ailus @ 2019-04-12 7:06 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Abylay Ospan, Andy Walls, Sergey Kozlov, Akihiro Tsukada,
linux-kernel, Patrice Chotard, Hans Verkuil,
Mauro Carvalho Chehab, Mike Isely, linux-arm-kernel, linux-media
On Fri, Jan 25, 2019 at 03:54:19PM +0900, Masahiro Yamada wrote:
> Currently, the Kbuild core manipulates header search paths in a crazy
> way [1].
>
> To fix this mess, I want all Makefiles to add explicit $(srctree)/ to
> the search paths in the srctree. Some Makefiles are already written in
> that way, but not all. The goal of this work is to make the notation
> consistent, and finally get rid of the gross hacks.
>
> Having whitespaces after -I does not matter since commit 48f6e3cf5bc6
> ("kbuild: do not drop -I without parameter").
>
> [1]: https://patchwork.kernel.org/patch/9632347/
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Thanks, Yamada-san!
Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
--
Sakari Ailus
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 0/3] media: clean-up header search paths and add $(srctree)/ prefix
2019-01-25 6:54 ` Masahiro Yamada
@ 2019-02-18 4:41 ` Masahiro Yamada
-1 siblings, 0 replies; 15+ messages in thread
From: Masahiro Yamada @ 2019-02-18 4:41 UTC (permalink / raw)
To: Mauro Carvalho Chehab, linux-media
Cc: Sakari Ailus, Patrice Chotard, Akihiro Tsukada, Philipp Zabel,
Linux Kernel Mailing List, Abylay Ospan, Hans Verkuil,
Sergey Kozlov, Mike Isely, Hans Verkuil, Yasunari Takiguchi,
Andy Walls, linux-arm-kernel
Hi Mauro,
On Fri, Jan 25, 2019 at 4:00 PM Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
>
> My main motivation is to get rid of crappy header search path manipulation
> from Kbuild core.
>
> Before that, I want to do as many treewide cleanups as possible.
>
> If you are interested in the big picture of this work,
> the full patch set is available at:
> git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git build-test
Could you take a look at this series, please?
>
>
>
> Masahiro Yamada (3):
> media: coda: remove -I$(src) header search path
> media: remove unneeded header search paths
> media: prefix header search paths with $(srctree)/
>
> drivers/media/common/b2c2/Makefile | 4 ++--
> drivers/media/dvb-frontends/cxd2880/Makefile | 2 --
> drivers/media/i2c/smiapp/Makefile | 2 +-
> drivers/media/mmc/siano/Makefile | 3 +--
> drivers/media/pci/b2c2/Makefile | 2 +-
> drivers/media/pci/bt8xx/Makefile | 5 ++---
> drivers/media/pci/cx18/Makefile | 4 ++--
> drivers/media/pci/cx23885/Makefile | 4 ++--
> drivers/media/pci/cx88/Makefile | 4 ++--
> drivers/media/pci/ddbridge/Makefile | 4 ++--
> drivers/media/pci/dm1105/Makefile | 2 +-
> drivers/media/pci/mantis/Makefile | 2 +-
> drivers/media/pci/netup_unidvb/Makefile | 2 +-
> drivers/media/pci/ngene/Makefile | 4 ++--
> drivers/media/pci/pluto2/Makefile | 2 +-
> drivers/media/pci/pt1/Makefile | 4 ++--
> drivers/media/pci/pt3/Makefile | 4 ++--
> drivers/media/pci/smipcie/Makefile | 5 ++---
> drivers/media/pci/ttpci/Makefile | 4 ++--
> drivers/media/platform/coda/Makefile | 2 --
> drivers/media/platform/coda/coda-h264.c | 3 ++-
> drivers/media/platform/coda/trace.h | 2 +-
> drivers/media/platform/sti/c8sectpfe/Makefile | 5 ++---
> drivers/media/radio/Makefile | 2 --
> drivers/media/spi/Makefile | 4 +---
> drivers/media/usb/as102/Makefile | 2 +-
> drivers/media/usb/au0828/Makefile | 4 ++--
> drivers/media/usb/b2c2/Makefile | 2 +-
> drivers/media/usb/cx231xx/Makefile | 5 ++---
> drivers/media/usb/em28xx/Makefile | 4 ++--
> drivers/media/usb/go7007/Makefile | 2 +-
> drivers/media/usb/pvrusb2/Makefile | 4 ++--
> drivers/media/usb/siano/Makefile | 2 +-
> drivers/media/usb/tm6000/Makefile | 4 ++--
> drivers/media/usb/ttusb-budget/Makefile | 2 +-
> drivers/media/usb/usbvision/Makefile | 2 --
> 36 files changed, 50 insertions(+), 64 deletions(-)
>
> --
> 2.7.4
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 0/3] media: clean-up header search paths and add $(srctree)/ prefix
@ 2019-02-18 4:41 ` Masahiro Yamada
0 siblings, 0 replies; 15+ messages in thread
From: Masahiro Yamada @ 2019-02-18 4:41 UTC (permalink / raw)
To: Mauro Carvalho Chehab, linux-media
Cc: Abylay Ospan, Andy Walls, Sergey Kozlov, Akihiro Tsukada,
Linux Kernel Mailing List, Patrice Chotard, Hans Verkuil,
Sakari Ailus, linux-arm-kernel, Philipp Zabel, Hans Verkuil,
Mike Isely, Yasunari Takiguchi
Hi Mauro,
On Fri, Jan 25, 2019 at 4:00 PM Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
>
> My main motivation is to get rid of crappy header search path manipulation
> from Kbuild core.
>
> Before that, I want to do as many treewide cleanups as possible.
>
> If you are interested in the big picture of this work,
> the full patch set is available at:
> git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git build-test
Could you take a look at this series, please?
>
>
>
> Masahiro Yamada (3):
> media: coda: remove -I$(src) header search path
> media: remove unneeded header search paths
> media: prefix header search paths with $(srctree)/
>
> drivers/media/common/b2c2/Makefile | 4 ++--
> drivers/media/dvb-frontends/cxd2880/Makefile | 2 --
> drivers/media/i2c/smiapp/Makefile | 2 +-
> drivers/media/mmc/siano/Makefile | 3 +--
> drivers/media/pci/b2c2/Makefile | 2 +-
> drivers/media/pci/bt8xx/Makefile | 5 ++---
> drivers/media/pci/cx18/Makefile | 4 ++--
> drivers/media/pci/cx23885/Makefile | 4 ++--
> drivers/media/pci/cx88/Makefile | 4 ++--
> drivers/media/pci/ddbridge/Makefile | 4 ++--
> drivers/media/pci/dm1105/Makefile | 2 +-
> drivers/media/pci/mantis/Makefile | 2 +-
> drivers/media/pci/netup_unidvb/Makefile | 2 +-
> drivers/media/pci/ngene/Makefile | 4 ++--
> drivers/media/pci/pluto2/Makefile | 2 +-
> drivers/media/pci/pt1/Makefile | 4 ++--
> drivers/media/pci/pt3/Makefile | 4 ++--
> drivers/media/pci/smipcie/Makefile | 5 ++---
> drivers/media/pci/ttpci/Makefile | 4 ++--
> drivers/media/platform/coda/Makefile | 2 --
> drivers/media/platform/coda/coda-h264.c | 3 ++-
> drivers/media/platform/coda/trace.h | 2 +-
> drivers/media/platform/sti/c8sectpfe/Makefile | 5 ++---
> drivers/media/radio/Makefile | 2 --
> drivers/media/spi/Makefile | 4 +---
> drivers/media/usb/as102/Makefile | 2 +-
> drivers/media/usb/au0828/Makefile | 4 ++--
> drivers/media/usb/b2c2/Makefile | 2 +-
> drivers/media/usb/cx231xx/Makefile | 5 ++---
> drivers/media/usb/em28xx/Makefile | 4 ++--
> drivers/media/usb/go7007/Makefile | 2 +-
> drivers/media/usb/pvrusb2/Makefile | 4 ++--
> drivers/media/usb/siano/Makefile | 2 +-
> drivers/media/usb/tm6000/Makefile | 4 ++--
> drivers/media/usb/ttusb-budget/Makefile | 2 +-
> drivers/media/usb/usbvision/Makefile | 2 --
> 36 files changed, 50 insertions(+), 64 deletions(-)
>
> --
> 2.7.4
>
--
Best Regards
Masahiro Yamada
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 0/3] media: clean-up header search paths and add $(srctree)/ prefix
2019-02-18 4:41 ` Masahiro Yamada
@ 2019-03-22 4:02 ` Masahiro Yamada
-1 siblings, 0 replies; 15+ messages in thread
From: Masahiro Yamada @ 2019-03-22 4:02 UTC (permalink / raw)
To: Mauro Carvalho Chehab, linux-media
Cc: Sakari Ailus, Patrice Chotard, Akihiro Tsukada, Philipp Zabel,
Linux Kernel Mailing List, Abylay Ospan, Hans Verkuil,
Sergey Kozlov, Mike Isely, Hans Verkuil, Yasunari Takiguchi,
Andy Walls, linux-arm-kernel
Hi Mauro,
On Mon, Feb 18, 2019 at 1:41 PM Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
>
> Hi Mauro,
>
> On Fri, Jan 25, 2019 at 4:00 PM Masahiro Yamada
> <yamada.masahiro@socionext.com> wrote:
> >
> > My main motivation is to get rid of crappy header search path manipulation
> > from Kbuild core.
> >
> > Before that, I want to do as many treewide cleanups as possible.
> >
> > If you are interested in the big picture of this work,
> > the full patch set is available at:
> > git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git build-test
>
>
> Could you take a look at this series, please?
Ping.
> >
> >
> >
> > Masahiro Yamada (3):
> > media: coda: remove -I$(src) header search path
> > media: remove unneeded header search paths
> > media: prefix header search paths with $(srctree)/
> >
> > drivers/media/common/b2c2/Makefile | 4 ++--
> > drivers/media/dvb-frontends/cxd2880/Makefile | 2 --
> > drivers/media/i2c/smiapp/Makefile | 2 +-
> > drivers/media/mmc/siano/Makefile | 3 +--
> > drivers/media/pci/b2c2/Makefile | 2 +-
> > drivers/media/pci/bt8xx/Makefile | 5 ++---
> > drivers/media/pci/cx18/Makefile | 4 ++--
> > drivers/media/pci/cx23885/Makefile | 4 ++--
> > drivers/media/pci/cx88/Makefile | 4 ++--
> > drivers/media/pci/ddbridge/Makefile | 4 ++--
> > drivers/media/pci/dm1105/Makefile | 2 +-
> > drivers/media/pci/mantis/Makefile | 2 +-
> > drivers/media/pci/netup_unidvb/Makefile | 2 +-
> > drivers/media/pci/ngene/Makefile | 4 ++--
> > drivers/media/pci/pluto2/Makefile | 2 +-
> > drivers/media/pci/pt1/Makefile | 4 ++--
> > drivers/media/pci/pt3/Makefile | 4 ++--
> > drivers/media/pci/smipcie/Makefile | 5 ++---
> > drivers/media/pci/ttpci/Makefile | 4 ++--
> > drivers/media/platform/coda/Makefile | 2 --
> > drivers/media/platform/coda/coda-h264.c | 3 ++-
> > drivers/media/platform/coda/trace.h | 2 +-
> > drivers/media/platform/sti/c8sectpfe/Makefile | 5 ++---
> > drivers/media/radio/Makefile | 2 --
> > drivers/media/spi/Makefile | 4 +---
> > drivers/media/usb/as102/Makefile | 2 +-
> > drivers/media/usb/au0828/Makefile | 4 ++--
> > drivers/media/usb/b2c2/Makefile | 2 +-
> > drivers/media/usb/cx231xx/Makefile | 5 ++---
> > drivers/media/usb/em28xx/Makefile | 4 ++--
> > drivers/media/usb/go7007/Makefile | 2 +-
> > drivers/media/usb/pvrusb2/Makefile | 4 ++--
> > drivers/media/usb/siano/Makefile | 2 +-
> > drivers/media/usb/tm6000/Makefile | 4 ++--
> > drivers/media/usb/ttusb-budget/Makefile | 2 +-
> > drivers/media/usb/usbvision/Makefile | 2 --
> > 36 files changed, 50 insertions(+), 64 deletions(-)
> >
> > --
> > 2.7.4
> >
>
>
> --
> Best Regards
> Masahiro Yamada
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 0/3] media: clean-up header search paths and add $(srctree)/ prefix
@ 2019-03-22 4:02 ` Masahiro Yamada
0 siblings, 0 replies; 15+ messages in thread
From: Masahiro Yamada @ 2019-03-22 4:02 UTC (permalink / raw)
To: Mauro Carvalho Chehab, linux-media
Cc: Abylay Ospan, Andy Walls, Sergey Kozlov, Akihiro Tsukada,
Linux Kernel Mailing List, Patrice Chotard, Hans Verkuil,
Sakari Ailus, linux-arm-kernel, Philipp Zabel, Hans Verkuil,
Mike Isely, Yasunari Takiguchi
Hi Mauro,
On Mon, Feb 18, 2019 at 1:41 PM Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
>
> Hi Mauro,
>
> On Fri, Jan 25, 2019 at 4:00 PM Masahiro Yamada
> <yamada.masahiro@socionext.com> wrote:
> >
> > My main motivation is to get rid of crappy header search path manipulation
> > from Kbuild core.
> >
> > Before that, I want to do as many treewide cleanups as possible.
> >
> > If you are interested in the big picture of this work,
> > the full patch set is available at:
> > git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git build-test
>
>
> Could you take a look at this series, please?
Ping.
> >
> >
> >
> > Masahiro Yamada (3):
> > media: coda: remove -I$(src) header search path
> > media: remove unneeded header search paths
> > media: prefix header search paths with $(srctree)/
> >
> > drivers/media/common/b2c2/Makefile | 4 ++--
> > drivers/media/dvb-frontends/cxd2880/Makefile | 2 --
> > drivers/media/i2c/smiapp/Makefile | 2 +-
> > drivers/media/mmc/siano/Makefile | 3 +--
> > drivers/media/pci/b2c2/Makefile | 2 +-
> > drivers/media/pci/bt8xx/Makefile | 5 ++---
> > drivers/media/pci/cx18/Makefile | 4 ++--
> > drivers/media/pci/cx23885/Makefile | 4 ++--
> > drivers/media/pci/cx88/Makefile | 4 ++--
> > drivers/media/pci/ddbridge/Makefile | 4 ++--
> > drivers/media/pci/dm1105/Makefile | 2 +-
> > drivers/media/pci/mantis/Makefile | 2 +-
> > drivers/media/pci/netup_unidvb/Makefile | 2 +-
> > drivers/media/pci/ngene/Makefile | 4 ++--
> > drivers/media/pci/pluto2/Makefile | 2 +-
> > drivers/media/pci/pt1/Makefile | 4 ++--
> > drivers/media/pci/pt3/Makefile | 4 ++--
> > drivers/media/pci/smipcie/Makefile | 5 ++---
> > drivers/media/pci/ttpci/Makefile | 4 ++--
> > drivers/media/platform/coda/Makefile | 2 --
> > drivers/media/platform/coda/coda-h264.c | 3 ++-
> > drivers/media/platform/coda/trace.h | 2 +-
> > drivers/media/platform/sti/c8sectpfe/Makefile | 5 ++---
> > drivers/media/radio/Makefile | 2 --
> > drivers/media/spi/Makefile | 4 +---
> > drivers/media/usb/as102/Makefile | 2 +-
> > drivers/media/usb/au0828/Makefile | 4 ++--
> > drivers/media/usb/b2c2/Makefile | 2 +-
> > drivers/media/usb/cx231xx/Makefile | 5 ++---
> > drivers/media/usb/em28xx/Makefile | 4 ++--
> > drivers/media/usb/go7007/Makefile | 2 +-
> > drivers/media/usb/pvrusb2/Makefile | 4 ++--
> > drivers/media/usb/siano/Makefile | 2 +-
> > drivers/media/usb/tm6000/Makefile | 4 ++--
> > drivers/media/usb/ttusb-budget/Makefile | 2 +-
> > drivers/media/usb/usbvision/Makefile | 2 --
> > 36 files changed, 50 insertions(+), 64 deletions(-)
> >
> > --
> > 2.7.4
> >
>
>
> --
> Best Regards
> Masahiro Yamada
--
Best Regards
Masahiro Yamada
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 0/3] media: clean-up header search paths and add $(srctree)/ prefix
2019-03-22 4:02 ` Masahiro Yamada
@ 2019-04-12 1:56 ` Masahiro Yamada
-1 siblings, 0 replies; 15+ messages in thread
From: Masahiro Yamada @ 2019-04-12 1:56 UTC (permalink / raw)
To: Mauro Carvalho Chehab, linux-media
Cc: Sakari Ailus, Patrice Chotard, Akihiro Tsukada, Philipp Zabel,
Linux Kernel Mailing List, Abylay Ospan, Hans Verkuil,
Sergey Kozlov, Mike Isely, Hans Verkuil, Yasunari Takiguchi,
Andy Walls, linux-arm-kernel
On Fri, Mar 22, 2019 at 1:02 PM Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
>
> Hi Mauro,
>
>
> On Mon, Feb 18, 2019 at 1:41 PM Masahiro Yamada
> <yamada.masahiro@socionext.com> wrote:
> >
> > Hi Mauro,
> >
> > On Fri, Jan 25, 2019 at 4:00 PM Masahiro Yamada
> > <yamada.masahiro@socionext.com> wrote:
> > >
> > > My main motivation is to get rid of crappy header search path manipulation
> > > from Kbuild core.
> > >
> > > Before that, I want to do as many treewide cleanups as possible.
> > >
> > > If you are interested in the big picture of this work,
> > > the full patch set is available at:
> > > git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git build-test
> >
> >
> > Could you take a look at this series, please?
>
> Ping.
Ping, 3rd time.
>
>
>
> > >
> > >
> > >
> > > Masahiro Yamada (3):
> > > media: coda: remove -I$(src) header search path
> > > media: remove unneeded header search paths
> > > media: prefix header search paths with $(srctree)/
> > >
> > > drivers/media/common/b2c2/Makefile | 4 ++--
> > > drivers/media/dvb-frontends/cxd2880/Makefile | 2 --
> > > drivers/media/i2c/smiapp/Makefile | 2 +-
> > > drivers/media/mmc/siano/Makefile | 3 +--
> > > drivers/media/pci/b2c2/Makefile | 2 +-
> > > drivers/media/pci/bt8xx/Makefile | 5 ++---
> > > drivers/media/pci/cx18/Makefile | 4 ++--
> > > drivers/media/pci/cx23885/Makefile | 4 ++--
> > > drivers/media/pci/cx88/Makefile | 4 ++--
> > > drivers/media/pci/ddbridge/Makefile | 4 ++--
> > > drivers/media/pci/dm1105/Makefile | 2 +-
> > > drivers/media/pci/mantis/Makefile | 2 +-
> > > drivers/media/pci/netup_unidvb/Makefile | 2 +-
> > > drivers/media/pci/ngene/Makefile | 4 ++--
> > > drivers/media/pci/pluto2/Makefile | 2 +-
> > > drivers/media/pci/pt1/Makefile | 4 ++--
> > > drivers/media/pci/pt3/Makefile | 4 ++--
> > > drivers/media/pci/smipcie/Makefile | 5 ++---
> > > drivers/media/pci/ttpci/Makefile | 4 ++--
> > > drivers/media/platform/coda/Makefile | 2 --
> > > drivers/media/platform/coda/coda-h264.c | 3 ++-
> > > drivers/media/platform/coda/trace.h | 2 +-
> > > drivers/media/platform/sti/c8sectpfe/Makefile | 5 ++---
> > > drivers/media/radio/Makefile | 2 --
> > > drivers/media/spi/Makefile | 4 +---
> > > drivers/media/usb/as102/Makefile | 2 +-
> > > drivers/media/usb/au0828/Makefile | 4 ++--
> > > drivers/media/usb/b2c2/Makefile | 2 +-
> > > drivers/media/usb/cx231xx/Makefile | 5 ++---
> > > drivers/media/usb/em28xx/Makefile | 4 ++--
> > > drivers/media/usb/go7007/Makefile | 2 +-
> > > drivers/media/usb/pvrusb2/Makefile | 4 ++--
> > > drivers/media/usb/siano/Makefile | 2 +-
> > > drivers/media/usb/tm6000/Makefile | 4 ++--
> > > drivers/media/usb/ttusb-budget/Makefile | 2 +-
> > > drivers/media/usb/usbvision/Makefile | 2 --
> > > 36 files changed, 50 insertions(+), 64 deletions(-)
> > >
> > > --
> > > 2.7.4
> > >
> >
> >
> > --
> > Best Regards
> > Masahiro Yamada
>
>
>
> --
> Best Regards
> Masahiro Yamada
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 0/3] media: clean-up header search paths and add $(srctree)/ prefix
@ 2019-04-12 1:56 ` Masahiro Yamada
0 siblings, 0 replies; 15+ messages in thread
From: Masahiro Yamada @ 2019-04-12 1:56 UTC (permalink / raw)
To: Mauro Carvalho Chehab, linux-media
Cc: Abylay Ospan, Andy Walls, Sergey Kozlov, Akihiro Tsukada,
Linux Kernel Mailing List, Patrice Chotard, Hans Verkuil,
Sakari Ailus, linux-arm-kernel, Philipp Zabel, Hans Verkuil,
Mike Isely, Yasunari Takiguchi
On Fri, Mar 22, 2019 at 1:02 PM Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
>
> Hi Mauro,
>
>
> On Mon, Feb 18, 2019 at 1:41 PM Masahiro Yamada
> <yamada.masahiro@socionext.com> wrote:
> >
> > Hi Mauro,
> >
> > On Fri, Jan 25, 2019 at 4:00 PM Masahiro Yamada
> > <yamada.masahiro@socionext.com> wrote:
> > >
> > > My main motivation is to get rid of crappy header search path manipulation
> > > from Kbuild core.
> > >
> > > Before that, I want to do as many treewide cleanups as possible.
> > >
> > > If you are interested in the big picture of this work,
> > > the full patch set is available at:
> > > git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git build-test
> >
> >
> > Could you take a look at this series, please?
>
> Ping.
Ping, 3rd time.
>
>
>
> > >
> > >
> > >
> > > Masahiro Yamada (3):
> > > media: coda: remove -I$(src) header search path
> > > media: remove unneeded header search paths
> > > media: prefix header search paths with $(srctree)/
> > >
> > > drivers/media/common/b2c2/Makefile | 4 ++--
> > > drivers/media/dvb-frontends/cxd2880/Makefile | 2 --
> > > drivers/media/i2c/smiapp/Makefile | 2 +-
> > > drivers/media/mmc/siano/Makefile | 3 +--
> > > drivers/media/pci/b2c2/Makefile | 2 +-
> > > drivers/media/pci/bt8xx/Makefile | 5 ++---
> > > drivers/media/pci/cx18/Makefile | 4 ++--
> > > drivers/media/pci/cx23885/Makefile | 4 ++--
> > > drivers/media/pci/cx88/Makefile | 4 ++--
> > > drivers/media/pci/ddbridge/Makefile | 4 ++--
> > > drivers/media/pci/dm1105/Makefile | 2 +-
> > > drivers/media/pci/mantis/Makefile | 2 +-
> > > drivers/media/pci/netup_unidvb/Makefile | 2 +-
> > > drivers/media/pci/ngene/Makefile | 4 ++--
> > > drivers/media/pci/pluto2/Makefile | 2 +-
> > > drivers/media/pci/pt1/Makefile | 4 ++--
> > > drivers/media/pci/pt3/Makefile | 4 ++--
> > > drivers/media/pci/smipcie/Makefile | 5 ++---
> > > drivers/media/pci/ttpci/Makefile | 4 ++--
> > > drivers/media/platform/coda/Makefile | 2 --
> > > drivers/media/platform/coda/coda-h264.c | 3 ++-
> > > drivers/media/platform/coda/trace.h | 2 +-
> > > drivers/media/platform/sti/c8sectpfe/Makefile | 5 ++---
> > > drivers/media/radio/Makefile | 2 --
> > > drivers/media/spi/Makefile | 4 +---
> > > drivers/media/usb/as102/Makefile | 2 +-
> > > drivers/media/usb/au0828/Makefile | 4 ++--
> > > drivers/media/usb/b2c2/Makefile | 2 +-
> > > drivers/media/usb/cx231xx/Makefile | 5 ++---
> > > drivers/media/usb/em28xx/Makefile | 4 ++--
> > > drivers/media/usb/go7007/Makefile | 2 +-
> > > drivers/media/usb/pvrusb2/Makefile | 4 ++--
> > > drivers/media/usb/siano/Makefile | 2 +-
> > > drivers/media/usb/tm6000/Makefile | 4 ++--
> > > drivers/media/usb/ttusb-budget/Makefile | 2 +-
> > > drivers/media/usb/usbvision/Makefile | 2 --
> > > 36 files changed, 50 insertions(+), 64 deletions(-)
> > >
> > > --
> > > 2.7.4
> > >
> >
> >
> > --
> > Best Regards
> > Masahiro Yamada
>
>
>
> --
> Best Regards
> Masahiro Yamada
--
Best Regards
Masahiro Yamada
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread