From: Masahiro Yamada <masahiroy@kernel.org> To: Amit Daniel Kachhap <amit.kachhap@arm.com> Cc: linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, Mark Rutland <mark.rutland@arm.com>, Kees Cook <keescook@chromium.org>, Ard Biesheuvel <ardb@kernel.org>, Catalin Marinas <catalin.marinas@arm.com>, Suzuki K Poulose <suzuki.poulose@arm.com>, Will Deacon <will@kernel.org>, Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>, Kristina Martsenko <kristina.martsenko@arm.com>, Dave Martin <Dave.Martin@arm.com>, James Morse <james.morse@arm.com>, Vincenzo Frascino <Vincenzo.Frascino@arm.com>, Mark Brown <broonie@kernel.org>, Linux Kbuild mailing list <linux-kbuild@vger.kernel.org> Subject: Re: [PATCH v5 15/17] kconfig: Add support for 'as-option' Date: Mon, 17 Feb 2020 18:39:44 +0900 [thread overview] Message-ID: <CAK7LNARTD88U1ZBxMU3fCDb1KxF=PavhgoUzqTt6ar9-+7eMQA@mail.gmail.com> (raw) In-Reply-To: <1581931668-11559-16-git-send-email-amit.kachhap@arm.com> Hi. On Mon, Feb 17, 2020 at 6:29 PM Amit Daniel Kachhap <amit.kachhap@arm.com> wrote: > > From: Vincenzo Frascino <vincenzo.frascino@arm.com> > > Currently kconfig does not have a feature that allows to detect if the > used assembler supports a specific compilation option. > > Introduce 'as-option' to serve this purpose in the context of Kconfig: > > config X > def_bool $(as-option,...) > > Cc: Masahiro Yamada <yamada.masahiro@socionext.com> > Cc: linux-kbuild@vger.kernel.org > Acked-by: Masahiro Yamada <masahiroy@kernel.org> > Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com> > Signed-off-by: Amit Daniel Kachhap <amit.kachhap@arm.com> > --- > scripts/Kconfig.include | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/scripts/Kconfig.include b/scripts/Kconfig.include > index 85334dc..374e251 100644 > --- a/scripts/Kconfig.include > +++ b/scripts/Kconfig.include > @@ -35,6 +35,10 @@ ld-option = $(success,$(LD) -v $(1)) > # Return y if the assembler supports <instr>, n otherwise > as-instr = $(success,printf "%b\n" "$(1)" | $(CC) $(CLANG_FLAGS) -c -x assembler -o /dev/null -) > > +# $(as-option,<flag>) > +# Return y if the assembler supports <flag>, n otherwise > +as-option =$(success, $(CC) $(CLANG_FLAGS) $(1) -c -x assembler /dev/null -o /dev/zero) > + I am still not convinced with using /dev/zero here. Does this work? as-option = $(success, cat /dev/null | $(CC) $(CLANG_FLAGS) $(1) -c -x assembler -o /dev/null -) [1] Could you insert as-option between ld-option and as-instr ? [2] Could you add some comments to explain why /dev/null -o /dev/null does not work? > # check if $(CC) and $(LD) exist > $(error-if,$(failure,command -v $(CC)),compiler '$(CC)' not found) > $(error-if,$(failure,command -v $(LD)),linker '$(LD)' not found) > -- > 2.7.4 > -- Best Regards Masahiro Yamada
WARNING: multiple messages have this Message-ID (diff)
From: Masahiro Yamada <masahiroy@kernel.org> To: Amit Daniel Kachhap <amit.kachhap@arm.com> Cc: Mark Rutland <mark.rutland@arm.com>, Kees Cook <keescook@chromium.org>, Suzuki K Poulose <suzuki.poulose@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>, Kristina Martsenko <kristina.martsenko@arm.com>, Dave Martin <Dave.Martin@arm.com>, Mark Brown <broonie@kernel.org>, James Morse <james.morse@arm.com>, Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>, Vincenzo Frascino <Vincenzo.Frascino@arm.com>, Will Deacon <will@kernel.org>, Ard Biesheuvel <ardb@kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v5 15/17] kconfig: Add support for 'as-option' Date: Mon, 17 Feb 2020 18:39:44 +0900 [thread overview] Message-ID: <CAK7LNARTD88U1ZBxMU3fCDb1KxF=PavhgoUzqTt6ar9-+7eMQA@mail.gmail.com> (raw) In-Reply-To: <1581931668-11559-16-git-send-email-amit.kachhap@arm.com> Hi. On Mon, Feb 17, 2020 at 6:29 PM Amit Daniel Kachhap <amit.kachhap@arm.com> wrote: > > From: Vincenzo Frascino <vincenzo.frascino@arm.com> > > Currently kconfig does not have a feature that allows to detect if the > used assembler supports a specific compilation option. > > Introduce 'as-option' to serve this purpose in the context of Kconfig: > > config X > def_bool $(as-option,...) > > Cc: Masahiro Yamada <yamada.masahiro@socionext.com> > Cc: linux-kbuild@vger.kernel.org > Acked-by: Masahiro Yamada <masahiroy@kernel.org> > Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com> > Signed-off-by: Amit Daniel Kachhap <amit.kachhap@arm.com> > --- > scripts/Kconfig.include | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/scripts/Kconfig.include b/scripts/Kconfig.include > index 85334dc..374e251 100644 > --- a/scripts/Kconfig.include > +++ b/scripts/Kconfig.include > @@ -35,6 +35,10 @@ ld-option = $(success,$(LD) -v $(1)) > # Return y if the assembler supports <instr>, n otherwise > as-instr = $(success,printf "%b\n" "$(1)" | $(CC) $(CLANG_FLAGS) -c -x assembler -o /dev/null -) > > +# $(as-option,<flag>) > +# Return y if the assembler supports <flag>, n otherwise > +as-option =$(success, $(CC) $(CLANG_FLAGS) $(1) -c -x assembler /dev/null -o /dev/zero) > + I am still not convinced with using /dev/zero here. Does this work? as-option = $(success, cat /dev/null | $(CC) $(CLANG_FLAGS) $(1) -c -x assembler -o /dev/null -) [1] Could you insert as-option between ld-option and as-instr ? [2] Could you add some comments to explain why /dev/null -o /dev/null does not work? > # check if $(CC) and $(LD) exist > $(error-if,$(failure,command -v $(CC)),compiler '$(CC)' not found) > $(error-if,$(failure,command -v $(LD)),linker '$(LD)' not found) > -- > 2.7.4 > -- Best Regards Masahiro Yamada _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-17 9:40 UTC|newest] Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-17 9:27 [PATCH v5 00/17] arm64: return address signing Amit Daniel Kachhap 2020-02-17 9:27 ` [PATCH v5 01/17] arm64: cpufeature: Fix meta-capability cpufeature check Amit Daniel Kachhap 2020-02-17 9:27 ` [PATCH v5 02/17] arm64: cpufeature: add pointer auth meta-capabilities Amit Daniel Kachhap 2020-02-17 9:27 ` [PATCH v5 03/17] arm64: rename ptrauth key structures to be user-specific Amit Daniel Kachhap 2020-02-17 9:27 ` [PATCH v5 04/17] arm64: install user ptrauth keys at kernel exit time Amit Daniel Kachhap 2020-02-17 9:27 ` [PATCH v5 05/17] arm64: create macro to park cpu in an infinite loop Amit Daniel Kachhap 2020-02-17 9:27 ` [PATCH v5 06/17] arm64: add bootup/runtime flags for __cpu_setup Amit Daniel Kachhap 2020-02-17 9:27 ` [PATCH v5 07/17] arm64: cpufeature: handle conflicts based on capability Amit Daniel Kachhap 2020-02-28 18:18 ` Catalin Marinas 2020-03-02 9:29 ` Amit Kachhap 2020-02-17 9:27 ` [PATCH v5 08/17] arm64: enable ptrauth earlier Amit Daniel Kachhap 2020-02-17 9:27 ` [PATCH v5 09/17] arm64: initialize and switch ptrauth kernel keys Amit Daniel Kachhap 2020-02-17 9:27 ` [PATCH v5 10/17] arm64: initialize ptrauth keys for kernel booting task Amit Daniel Kachhap 2020-02-17 9:27 ` [PATCH v5 11/17] arm64: mask PAC bits of __builtin_return_address Amit Daniel Kachhap 2020-02-17 9:27 ` [PATCH v5 12/17] arm64: unwind: strip PAC from kernel addresses Amit Daniel Kachhap 2020-02-17 9:27 ` [PATCH v5 13/17] arm64: __show_regs: strip PAC from lr in printk Amit Daniel Kachhap 2020-02-17 9:27 ` [PATCH v5 14/17] arm64: suspend: restore the kernel ptrauth keys Amit Daniel Kachhap 2020-02-28 18:18 ` Catalin Marinas 2020-03-02 10:13 ` Amit Kachhap 2020-02-17 9:27 ` [PATCH v5 15/17] kconfig: Add support for 'as-option' Amit Daniel Kachhap 2020-02-17 9:27 ` Amit Daniel Kachhap 2020-02-17 9:39 ` Masahiro Yamada [this message] 2020-02-17 9:39 ` Masahiro Yamada 2020-02-17 10:16 ` Vincenzo Frascino 2020-02-17 10:16 ` Vincenzo Frascino 2020-02-18 0:37 ` Masahiro Yamada 2020-02-18 0:37 ` Masahiro Yamada 2020-02-18 10:14 ` Vincenzo Frascino 2020-02-18 10:14 ` Vincenzo Frascino 2020-02-17 9:27 ` [PATCH v5 16/17] arm64: compile the kernel with ptrauth return address signing Amit Daniel Kachhap 2020-02-28 18:23 ` Catalin Marinas 2020-03-02 10:19 ` Amit Kachhap 2020-03-02 13:16 ` Mark Brown 2020-03-04 11:01 ` Vincenzo Frascino 2020-03-03 9:28 ` Amit Kachhap 2020-03-04 10:53 ` Vincenzo Frascino 2020-02-17 9:27 ` [PATCH v5 17/17] lkdtm: arm64: test kernel pointer authentication Amit Daniel Kachhap
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAK7LNARTD88U1ZBxMU3fCDb1KxF=PavhgoUzqTt6ar9-+7eMQA@mail.gmail.com' \ --to=masahiroy@kernel.org \ --cc=Dave.Martin@arm.com \ --cc=Vincenzo.Frascino@arm.com \ --cc=amit.kachhap@arm.com \ --cc=ardb@kernel.org \ --cc=broonie@kernel.org \ --cc=catalin.marinas@arm.com \ --cc=james.morse@arm.com \ --cc=keescook@chromium.org \ --cc=kristina.martsenko@arm.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kbuild@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=ramana.radhakrishnan@arm.com \ --cc=suzuki.poulose@arm.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.