* [PATCH] dt-bindings: rename .yamllint to yamllint
@ 2023-01-30 16:26 Masahiro Yamada
2023-01-30 19:52 ` Rob Herring
0 siblings, 1 reply; 4+ messages in thread
From: Masahiro Yamada @ 2023-01-30 16:26 UTC (permalink / raw)
To: devicetree, Rob Herring
Cc: linux-kernel, Masahiro Yamada, Krzysztof Kozlowski
This file is ignored by git by the '.*' rule in the top .gitignore.
I do not see a good reason why this should be a hidden file.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
I think many people are aware of this issue
since this is now W=1 warning due to this patch:
https://lore.kernel.org/all/20221229074310.906556-2-masahiroy@kernel.org/
Documentation/devicetree/bindings/Makefile | 4 ++--
Documentation/devicetree/bindings/{.yamllint => yamllint} | 0
2 files changed, 2 insertions(+), 2 deletions(-)
rename Documentation/devicetree/bindings/{.yamllint => yamllint} (100%)
diff --git a/Documentation/devicetree/bindings/Makefile b/Documentation/devicetree/bindings/Makefile
index bf2d8a8ced77..edc65522072b 100644
--- a/Documentation/devicetree/bindings/Makefile
+++ b/Documentation/devicetree/bindings/Makefile
@@ -34,7 +34,7 @@ CHK_DT_DOCS := $(shell $(find_cmd))
quiet_cmd_yamllint = LINT $(src)
cmd_yamllint = ($(find_cmd) | \
xargs -n200 -P$$(nproc) \
- $(DT_SCHEMA_LINT) -f parsable -c $(srctree)/$(src)/.yamllint >&2) || true
+ $(DT_SCHEMA_LINT) -f parsable -c $(srctree)/$(src)/yamllint >&2) || true
quiet_cmd_chk_bindings = CHKDT $@
cmd_chk_bindings = ($(find_cmd) | \
@@ -64,7 +64,7 @@ override DTC_FLAGS := \
# Disable undocumented compatible checks until warning free
override DT_CHECKER_FLAGS ?=
-$(obj)/processed-schema.json: $(DT_DOCS) $(src)/.yamllint check_dtschema_version FORCE
+$(obj)/processed-schema.json: $(DT_DOCS) $(src)/yamllint check_dtschema_version FORCE
$(call if_changed_rule,chkdt)
always-y += processed-schema.json
diff --git a/Documentation/devicetree/bindings/.yamllint b/Documentation/devicetree/bindings/yamllint
similarity index 100%
rename from Documentation/devicetree/bindings/.yamllint
rename to Documentation/devicetree/bindings/yamllint
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: rename .yamllint to yamllint
2023-01-30 16:26 [PATCH] dt-bindings: rename .yamllint to yamllint Masahiro Yamada
@ 2023-01-30 19:52 ` Rob Herring
2023-01-31 1:54 ` Masahiro Yamada
0 siblings, 1 reply; 4+ messages in thread
From: Rob Herring @ 2023-01-30 19:52 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: devicetree, linux-kernel, Krzysztof Kozlowski
On Mon, Jan 30, 2023 at 10:26 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> This file is ignored by git by the '.*' rule in the top .gitignore.
>
> I do not see a good reason why this should be a hidden file.
Only because that is the default name yamllint will pick up if it is
run from the bindings directory. Not really something I do though.
Rob
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: rename .yamllint to yamllint
2023-01-30 19:52 ` Rob Herring
@ 2023-01-31 1:54 ` Masahiro Yamada
2023-01-31 19:09 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: Masahiro Yamada @ 2023-01-31 1:54 UTC (permalink / raw)
To: Rob Herring; +Cc: devicetree, linux-kernel, Krzysztof Kozlowski
On Tue, Jan 31, 2023 at 4:53 AM Rob Herring <robh+dt@kernel.org> wrote:
>
> On Mon, Jan 30, 2023 at 10:26 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
> >
> > This file is ignored by git by the '.*' rule in the top .gitignore.
> >
> > I do not see a good reason why this should be a hidden file.
>
> Only because that is the default name yamllint will pick up if it is
> run from the bindings directory. Not really something I do though.
>
> Rob
Or, do you prefer adding
!/.yamllint
to Documentation/devicetree/bindings/.gitignore ?
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: rename .yamllint to yamllint
2023-01-31 1:54 ` Masahiro Yamada
@ 2023-01-31 19:09 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-31 19:09 UTC (permalink / raw)
To: Masahiro Yamada, Rob Herring
Cc: devicetree, linux-kernel, Krzysztof Kozlowski
On 31/01/2023 02:54, Masahiro Yamada wrote:
> On Tue, Jan 31, 2023 at 4:53 AM Rob Herring <robh+dt@kernel.org> wrote:
>>
>> On Mon, Jan 30, 2023 at 10:26 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>>>
>>> This file is ignored by git by the '.*' rule in the top .gitignore.
>>>
>>> I do not see a good reason why this should be a hidden file.
>>
>> Only because that is the default name yamllint will pick up if it is
>> run from the bindings directory. Not really something I do though.
>>
>> Rob
>
>
> Or, do you prefer adding
>
> !/.yamllint
>
> to Documentation/devicetree/bindings/.gitignore ?
https://lore.kernel.org/all/20230127150225.18148-1-andriy.shevchenko@linux.intel.com/
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-31 19:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-30 16:26 [PATCH] dt-bindings: rename .yamllint to yamllint Masahiro Yamada
2023-01-30 19:52 ` Rob Herring
2023-01-31 1:54 ` Masahiro Yamada
2023-01-31 19:09 ` Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.