[PATCH 0/3] alpha: improvements of arch/alpha/lib/Makefile

[PATCH 0/3] alpha: improvements of arch/alpha/lib/Makefile

[Masahiro Yamada]

While building for Alpha architecture, I noticed ugly long log
for division routines.  So, I took a look at the Makefile.
Here is a series of build rule cleanups.


Masahiro Yamada (3):
  alpha: add $(src)/ rather than $(obj)/ to make source file path
  alpha: merge build rules of division routines
  alpha: make short build log available for division routines

 arch/alpha/lib/Makefile | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

-- 
1.9.1

[PATCH 1/3] alpha: add $(src)/ rather than $(obj)/ to make source file path

[Masahiro Yamada]

$(ev6-y)divide.S is a source file, not a build-time generated file.
So, it should be prefixed with $(src)/ rather than $(obj)/.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 arch/alpha/lib/Makefile | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/alpha/lib/Makefile b/arch/alpha/lib/Makefile
index 5966074..7b694fe 100644
--- a/arch/alpha/lib/Makefile
+++ b/arch/alpha/lib/Makefile
@@ -46,11 +46,11 @@ AFLAGS___remqu.o =       -DREM
 AFLAGS___divlu.o = -DDIV       -DINTSIZE
 AFLAGS___remlu.o =       -DREM -DINTSIZE
 
-$(obj)/__divqu.o: $(obj)/$(ev6-y)divide.S
+$(obj)/__divqu.o: $(src)/$(ev6-y)divide.S
 	$(cmd_as_o_S)
-$(obj)/__remqu.o: $(obj)/$(ev6-y)divide.S
+$(obj)/__remqu.o: $(src)/$(ev6-y)divide.S
 	$(cmd_as_o_S)
-$(obj)/__divlu.o: $(obj)/$(ev6-y)divide.S
+$(obj)/__divlu.o: $(src)/$(ev6-y)divide.S
 	$(cmd_as_o_S)
-$(obj)/__remlu.o: $(obj)/$(ev6-y)divide.S
+$(obj)/__remlu.o: $(src)/$(ev6-y)divide.S
 	$(cmd_as_o_S)
-- 
1.9.1

[PATCH 2/3] alpha: merge build rules of division routines

[Masahiro Yamada]

These four objects are generated by the same build rule, with
different compile options.  The build rules can be merged.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 arch/alpha/lib/Makefile | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/arch/alpha/lib/Makefile b/arch/alpha/lib/Makefile
index 7b694fe..5f12e9d 100644
--- a/arch/alpha/lib/Makefile
+++ b/arch/alpha/lib/Makefile
@@ -46,11 +46,6 @@ AFLAGS___remqu.o =       -DREM
 AFLAGS___divlu.o = -DDIV       -DINTSIZE
 AFLAGS___remlu.o =       -DREM -DINTSIZE
 
-$(obj)/__divqu.o: $(src)/$(ev6-y)divide.S
-	$(cmd_as_o_S)
-$(obj)/__remqu.o: $(src)/$(ev6-y)divide.S
-	$(cmd_as_o_S)
-$(obj)/__divlu.o: $(src)/$(ev6-y)divide.S
-	$(cmd_as_o_S)
-$(obj)/__remlu.o: $(src)/$(ev6-y)divide.S
+$(addprefix $(obj)/,__divqu.o __remqu.o __divlu.o __remlu.o): \
+							$(src)/$(ev6-y)divide.S
 	$(cmd_as_o_S)
-- 
1.9.1

[PATCH 3/3] alpha: make short build log available for division routines

[Masahiro Yamada]

This enables the Kbuild standard log style as follows:

  AS      arch/alpha/lib/__divlu.o
  AS      arch/alpha/lib/__divqu.o
  AS      arch/alpha/lib/__remlu.o
  AS      arch/alpha/lib/__remqu.o

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 arch/alpha/lib/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/alpha/lib/Makefile b/arch/alpha/lib/Makefile
index 5f12e9d..7083434 100644
--- a/arch/alpha/lib/Makefile
+++ b/arch/alpha/lib/Makefile
@@ -47,5 +47,5 @@ AFLAGS___divlu.o = -DDIV       -DINTSIZE
 AFLAGS___remlu.o =       -DREM -DINTSIZE
 
 $(addprefix $(obj)/,__divqu.o __remqu.o __divlu.o __remlu.o): \
-							$(src)/$(ev6-y)divide.S
-	$(cmd_as_o_S)
+						$(src)/$(ev6-y)divide.S FORCE
+	$(call if_changed_rule,as_o_S)
-- 
1.9.1

Re: [PATCH 0/3] alpha: improvements of arch/alpha/lib/Makefile

[Masahiro Yamada]

2016-09-11 16:42 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> While building for Alpha architecture, I noticed ugly long log
> for division routines.  So, I took a look at the Makefile.
> Here is a series of build rule cleanups.
>
>
> Masahiro Yamada (3):
>   alpha: add $(src)/ rather than $(obj)/ to make source file path
>   alpha: merge build rules of division routines
>   alpha: make short build log available for division routines
>
>  arch/alpha/lib/Makefile | 11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)
>

No response for a long time
(probably because the maintainer status is Odd Fixes.)

Applied to linux-kbuild.



-- 
Best Regards
Masahiro Yamada