[6.2-rc4] warning: cannot check the header due to sha1sum missing

[6.2-rc4] warning: cannot check the header due to sha1sum missing

[Sedat Dilek]

Hi Masahiro,

I saw these warnings in my build-log:

  if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
::p' include/linux/atomic/
atomic-arch-fallback.h)" != "$(sed '$d'
include/linux/atomic/atomic-arch-fallback.h | sha1sum | sed 's/
.*//')" ]; then echo "error: include/linux/atomic/atomic-arch-f
allback.h has been modified." >&2; exit 1; fi; touch
.checked-atomic-arch-fallback.h
 if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
::p' include/linux/atomic/
atomic-instrumented.h)" != "$(sed '$d'
include/linux/atomic/atomic-instrumented.h | sha1sum | sed 's/ .*//')"
]; then echo "error: include/linux/atomic/atomic-instrume
nted.h has been modified." >&2; exit 1; fi; touch .checked-atomic-instrumented.h
 if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
::p' include/linux/atomic/
atomic-long.h)" != "$(sed '$d' include/linux/atomic/atomic-long.h |
sha1sum | sed 's/ .*//')" ]; then echo "error:
include/linux/atomic/atomic-long.h has been modified
." >&2; exit 1; fi; touch .checked-atomic-long.h

NOTE: I did a `make distclean` before I started my build.

Can you please comment on this?

Thanks.

Best regards,
-Sedat-

Re: [6.2-rc4] warning: cannot check the header due to sha1sum missing

[Masahiro Yamada]

On Mon, Jan 16, 2023 at 11:02 AM Sedat Dilek <sedat.dilek@gmail.com> wrote:
>
> Hi Masahiro,
>
> I saw these warnings in my build-log:
>
>   if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
> the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
> ::p' include/linux/atomic/
> atomic-arch-fallback.h)" != "$(sed '$d'
> include/linux/atomic/atomic-arch-fallback.h | sha1sum | sed 's/
> .*//')" ]; then echo "error: include/linux/atomic/atomic-arch-f
> allback.h has been modified." >&2; exit 1; fi; touch
> .checked-atomic-arch-fallback.h
>  if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
> the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
> ::p' include/linux/atomic/
> atomic-instrumented.h)" != "$(sed '$d'
> include/linux/atomic/atomic-instrumented.h | sha1sum | sed 's/ .*//')"
> ]; then echo "error: include/linux/atomic/atomic-instrume
> nted.h has been modified." >&2; exit 1; fi; touch .checked-atomic-instrumented.h
>  if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
> the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
> ::p' include/linux/atomic/
> atomic-long.h)" != "$(sed '$d' include/linux/atomic/atomic-long.h |
> sha1sum | sed 's/ .*//')" ]; then echo "error:
> include/linux/atomic/atomic-long.h has been modified
> ." >&2; exit 1; fi; touch .checked-atomic-long.h
>
> NOTE: I did a `make distclean` before I started my build.
>
> Can you please comment on this?




Please clarify your problem.

My best guess is, you just added V=1 option to
print the full log, didn't you?



I can see the same build log by running the following command.



$ make V=1 mrproper defconfig  prepare | grep sha1sum
+ [ clean = clean ]
+ cleanup
+ rm -f .btf.*
+ rm -f System.map
+ rm -f vmlinux
+ rm -f vmlinux.map
+ exit 0
  if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
::p' include/linux/atomic/atomic-arch-fallback.h)" != "$(sed '$d'
include/linux/atomic/atomic-arch-fallback.h | sha1sum | sed 's/
.*//')" ]; then echo "error:
include/linux/atomic/atomic-arch-fallback.h has been modified." >&2;
exit 1; fi; touch .checked-atomic-arch-fallback.h
  if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
::p' include/linux/atomic/atomic-instrumented.h)" != "$(sed '$d'
include/linux/atomic/atomic-instrumented.h | sha1sum | sed 's/ .*//')"
]; then echo "error: include/linux/atomic/atomic-instrumented.h has
been modified." >&2; exit 1; fi; touch .checked-atomic-instrumented.h
  if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
::p' include/linux/atomic/atomic-long.h)" != "$(sed '$d'
include/linux/atomic/atomic-long.h | sha1sum | sed 's/ .*//')" ]; then
echo "error: include/linux/atomic/atomic-long.h has been modified."
>&2; exit 1; fi; touch .checked-atomic-long.h






>
> Thanks.
>
> Best regards,
> -Sedat-




--
Best Regards
Masahiro Yamada

Re: [6.2-rc4] warning: cannot check the header due to sha1sum missing

[Sedat Dilek]

On Mon, Jan 16, 2023 at 4:21 AM Masahiro Yamada <masahiroy@kernel.org> wrote:

[ ... ]

> Please clarify your problem.
>
> My best guess is, you just added V=1 option to
> print the full log, didn't you?
>

Sorry, forgot the make-line (this morning posted from my smartphone):

$ /usr/bin/perf stat make V=1 -j4 LLVM=1 LLVM_IAS=1
PAHOLE=/opt/pahole/bin/pahole LOCALVERSION=-1-amd64-clang15-kcfi
KBUILD_BUILD_HOST=iniza KBUILD_BUILD_USER=sedat.dilek@gmail.com
KBUILD_BUILD_TIMESTAMP=2023-01-15 bindeb-pkg
KDEB_PKGVERSION=6.2.0~rc4-1~unstable+dileks1

>
> I can see the same build log by running the following command.
>
>
>
> $ make V=1 mrproper defconfig  prepare | grep sha1sum
> + [ clean = clean ]
> + cleanup
> + rm -f .btf.*
> + rm -f System.map
> + rm -f vmlinux
> + rm -f vmlinux.map
> + exit 0
>   if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
> the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
> ::p' include/linux/atomic/atomic-arch-fallback.h)" != "$(sed '$d'
> include/linux/atomic/atomic-arch-fallback.h | sha1sum | sed 's/
> .*//')" ]; then echo "error:
> include/linux/atomic/atomic-arch-fallback.h has been modified." >&2;
> exit 1; fi; touch .checked-atomic-arch-fallback.h
>   if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
> the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
> ::p' include/linux/atomic/atomic-instrumented.h)" != "$(sed '$d'
> include/linux/atomic/atomic-instrumented.h | sha1sum | sed 's/ .*//')"
> ]; then echo "error: include/linux/atomic/atomic-instrumented.h has
> been modified." >&2; exit 1; fi; touch .checked-atomic-instrumented.h
>   if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
> the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
> ::p' include/linux/atomic/atomic-long.h)" != "$(sed '$d'
> include/linux/atomic/atomic-long.h | sha1sum | sed 's/ .*//')" ]; then
> echo "error: include/linux/atomic/atomic-long.h has been modified."
> >&2; exit 1; fi; touch .checked-atomic-long.h
>
>
>
>
>
>
> >
> > Thanks.
> >
> > Best regards,
> > -Sedat-
>
>
>
>
> --
> Best Regards
> Masahiro Yamada

Re: [6.2-rc4] warning: cannot check the header due to sha1sum missing

[Sedat Dilek]

On Mon, Jan 16, 2023 at 4:21 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> On Mon, Jan 16, 2023 at 11:02 AM Sedat Dilek <sedat.dilek@gmail.com> wrote:
> >
> > Hi Masahiro,
> >
> > I saw these warnings in my build-log:
> >
> >   if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
> > the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
> > ::p' include/linux/atomic/
> > atomic-arch-fallback.h)" != "$(sed '$d'
> > include/linux/atomic/atomic-arch-fallback.h | sha1sum | sed 's/
> > .*//')" ]; then echo "error: include/linux/atomic/atomic-arch-f
> > allback.h has been modified." >&2; exit 1; fi; touch
> > .checked-atomic-arch-fallback.h
> >  if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
> > the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
> > ::p' include/linux/atomic/
> > atomic-instrumented.h)" != "$(sed '$d'
> > include/linux/atomic/atomic-instrumented.h | sha1sum | sed 's/ .*//')"
> > ]; then echo "error: include/linux/atomic/atomic-instrume
> > nted.h has been modified." >&2; exit 1; fi; touch .checked-atomic-instrumented.h
> >  if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
> > the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
> > ::p' include/linux/atomic/
> > atomic-long.h)" != "$(sed '$d' include/linux/atomic/atomic-long.h |
> > sha1sum | sed 's/ .*//')" ]; then echo "error:
> > include/linux/atomic/atomic-long.h has been modified
> > ." >&2; exit 1; fi; touch .checked-atomic-long.h
> >
> > NOTE: I did a `make distclean` before I started my build.
> >
> > Can you please comment on this?
>
>
>
>
> Please clarify your problem.
>
> My best guess is, you just added V=1 option to
> print the full log, didn't you?
>
>
>
> I can see the same build log by running the following command.
>

Hi Masahiro,

you had a chance to look into this?

Thanks.

Regards,
-Sedat-

>
> $ make V=1 mrproper defconfig  prepare | grep sha1sum
> + [ clean = clean ]
> + cleanup
> + rm -f .btf.*
> + rm -f System.map
> + rm -f vmlinux
> + rm -f vmlinux.map
> + exit 0
>   if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
> the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
> ::p' include/linux/atomic/atomic-arch-fallback.h)" != "$(sed '$d'
> include/linux/atomic/atomic-arch-fallback.h | sha1sum | sed 's/
> .*//')" ]; then echo "error:
> include/linux/atomic/atomic-arch-fallback.h has been modified." >&2;
> exit 1; fi; touch .checked-atomic-arch-fallback.h
>   if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
> the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
> ::p' include/linux/atomic/atomic-instrumented.h)" != "$(sed '$d'
> include/linux/atomic/atomic-instrumented.h | sha1sum | sed 's/ .*//')"
> ]; then echo "error: include/linux/atomic/atomic-instrumented.h has
> been modified." >&2; exit 1; fi; touch .checked-atomic-instrumented.h
>   if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
> the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
> ::p' include/linux/atomic/atomic-long.h)" != "$(sed '$d'
> include/linux/atomic/atomic-long.h | sha1sum | sed 's/ .*//')" ]; then
> echo "error: include/linux/atomic/atomic-long.h has been modified."
> >&2; exit 1; fi; touch .checked-atomic-long.h
>
>
>
>
>
>
> >
> > Thanks.
> >
> > Best regards,
> > -Sedat-
>
>
>
>
> --
> Best Regards
> Masahiro Yamada

Re: [6.2-rc4] warning: cannot check the header due to sha1sum missing

[Masahiro Yamada]

On Wed, Jan 18, 2023 at 4:45 PM Sedat Dilek <sedat.dilek@gmail.com> wrote:
>
> On Mon, Jan 16, 2023 at 4:21 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
> >
> > On Mon, Jan 16, 2023 at 11:02 AM Sedat Dilek <sedat.dilek@gmail.com> wrote:
> > >
> > > Hi Masahiro,
> > >
> > > I saw these warnings in my build-log:
> > >
> > >   if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
> > > the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
> > > ::p' include/linux/atomic/
> > > atomic-arch-fallback.h)" != "$(sed '$d'
> > > include/linux/atomic/atomic-arch-fallback.h | sha1sum | sed 's/
> > > .*//')" ]; then echo "error: include/linux/atomic/atomic-arch-f
> > > allback.h has been modified." >&2; exit 1; fi; touch
> > > .checked-atomic-arch-fallback.h
> > >  if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
> > > the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
> > > ::p' include/linux/atomic/
> > > atomic-instrumented.h)" != "$(sed '$d'
> > > include/linux/atomic/atomic-instrumented.h | sha1sum | sed 's/ .*//')"
> > > ]; then echo "error: include/linux/atomic/atomic-instrume
> > > nted.h has been modified." >&2; exit 1; fi; touch .checked-atomic-instrumented.h
> > >  if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
> > > the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
> > > ::p' include/linux/atomic/
> > > atomic-long.h)" != "$(sed '$d' include/linux/atomic/atomic-long.h |
> > > sha1sum | sed 's/ .*//')" ]; then echo "error:
> > > include/linux/atomic/atomic-long.h has been modified
> > > ." >&2; exit 1; fi; touch .checked-atomic-long.h
> > >
> > > NOTE: I did a `make distclean` before I started my build.
> > >
> > > Can you please comment on this?
> >
> >
> >
> >
> > Please clarify your problem.
> >
> > My best guess is, you just added V=1 option to
> > print the full log, didn't you?
> >
> >
> >
> > I can see the same build log by running the following command.
> >
>
> Hi Masahiro,
>
> you had a chance to look into this?


I already replied.
This is the output of V=1.
There is no issue.




>
> Thanks.
>
> Regards,
> -Sedat-
>
> >
> > $ make V=1 mrproper defconfig  prepare | grep sha1sum
> > + [ clean = clean ]
> > + cleanup
> > + rm -f .btf.*
> > + rm -f System.map
> > + rm -f vmlinux
> > + rm -f vmlinux.map
> > + exit 0
> >   if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
> > the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
> > ::p' include/linux/atomic/atomic-arch-fallback.h)" != "$(sed '$d'
> > include/linux/atomic/atomic-arch-fallback.h | sha1sum | sed 's/
> > .*//')" ]; then echo "error:
> > include/linux/atomic/atomic-arch-fallback.h has been modified." >&2;
> > exit 1; fi; touch .checked-atomic-arch-fallback.h
> >   if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
> > the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
> > ::p' include/linux/atomic/atomic-instrumented.h)" != "$(sed '$d'
> > include/linux/atomic/atomic-instrumented.h | sha1sum | sed 's/ .*//')"
> > ]; then echo "error: include/linux/atomic/atomic-instrumented.h has
> > been modified." >&2; exit 1; fi; touch .checked-atomic-instrumented.h
> >   if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
> > the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
> > ::p' include/linux/atomic/atomic-long.h)" != "$(sed '$d'
> > include/linux/atomic/atomic-long.h | sha1sum | sed 's/ .*//')" ]; then
> > echo "error: include/linux/atomic/atomic-long.h has been modified."
> > >&2; exit 1; fi; touch .checked-atomic-long.h
> >
> >
> >
> >
> >
> >
> > >
> > > Thanks.
> > >
> > > Best regards,
> > > -Sedat-
> >
> >
> >
> >
> > --
> > Best Regards
> > Masahiro Yamada



-- 
Best Regards
Masahiro Yamada

Re: [6.2-rc4] warning: cannot check the header due to sha1sum missing

[Sedat Dilek]

On Wed, Jan 18, 2023 at 8:51 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> On Wed, Jan 18, 2023 at 4:45 PM Sedat Dilek <sedat.dilek@gmail.com> wrote:
> >
> > On Mon, Jan 16, 2023 at 4:21 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
> > >
> > > On Mon, Jan 16, 2023 at 11:02 AM Sedat Dilek <sedat.dilek@gmail.com> wrote:
> > > >
> > > > Hi Masahiro,
> > > >
> > > > I saw these warnings in my build-log:
> > > >
> > > >   if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
> > > > the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
> > > > ::p' include/linux/atomic/
> > > > atomic-arch-fallback.h)" != "$(sed '$d'
> > > > include/linux/atomic/atomic-arch-fallback.h | sha1sum | sed 's/
> > > > .*//')" ]; then echo "error: include/linux/atomic/atomic-arch-f
> > > > allback.h has been modified." >&2; exit 1; fi; touch
> > > > .checked-atomic-arch-fallback.h
> > > >  if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
> > > > the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
> > > > ::p' include/linux/atomic/
> > > > atomic-instrumented.h)" != "$(sed '$d'
> > > > include/linux/atomic/atomic-instrumented.h | sha1sum | sed 's/ .*//')"
> > > > ]; then echo "error: include/linux/atomic/atomic-instrume
> > > > nted.h has been modified." >&2; exit 1; fi; touch .checked-atomic-instrumented.h
> > > >  if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
> > > > the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
> > > > ::p' include/linux/atomic/
> > > > atomic-long.h)" != "$(sed '$d' include/linux/atomic/atomic-long.h |
> > > > sha1sum | sed 's/ .*//')" ]; then echo "error:
> > > > include/linux/atomic/atomic-long.h has been modified
> > > > ." >&2; exit 1; fi; touch .checked-atomic-long.h
> > > >
> > > > NOTE: I did a `make distclean` before I started my build.
> > > >
> > > > Can you please comment on this?
> > >
> > >
> > >
> > >
> > > Please clarify your problem.
> > >
> > > My best guess is, you just added V=1 option to
> > > print the full log, didn't you?
> > >
> > >
> > >
> > > I can see the same build log by running the following command.
> > >
> >
> > Hi Masahiro,
> >
> > you had a chance to look into this?
>
>
> I already replied.
> This is the output of V=1.
> There is no issue.
>

Hi Masahiro,

No, I disagree.

You demonstrated by:

$ make V=1 mrproper defconfig  prepare | grep sha1sum

That you see these warnings, too.

There is no statement that these warnings are OK.
If so, why?

Are those headers generated in build-time thus getting no/wrong sha1sums?

Please, clarify.

If you have time:
kbuild-next with a rework/refactoring of make V=xx does show these warnings?

Sorry for being pedantic - I started with Linux v6.2-rc4, again doing
some kernel-testing.
My goal is to have a warning-free build with LLVM-15 (ThinLTO + KCFI).

Right now, I will do some more testing.

Thanks.

BR,
-Sedat-

>
> >
> > Thanks.
> >
> > Regards,
> > -Sedat-
> >
> > >
> > > $ make V=1 mrproper defconfig  prepare | grep sha1sum
> > > + [ clean = clean ]
> > > + cleanup
> > > + rm -f .btf.*
> > > + rm -f System.map
> > > + rm -f vmlinux
> > > + rm -f vmlinux.map
> > > + exit 0
> > >   if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
> > > the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
> > > ::p' include/linux/atomic/atomic-arch-fallback.h)" != "$(sed '$d'
> > > include/linux/atomic/atomic-arch-fallback.h | sha1sum | sed 's/
> > > .*//')" ]; then echo "error:
> > > include/linux/atomic/atomic-arch-fallback.h has been modified." >&2;
> > > exit 1; fi; touch .checked-atomic-arch-fallback.h
> > >   if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
> > > the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
> > > ::p' include/linux/atomic/atomic-instrumented.h)" != "$(sed '$d'
> > > include/linux/atomic/atomic-instrumented.h | sha1sum | sed 's/ .*//')"
> > > ]; then echo "error: include/linux/atomic/atomic-instrumented.h has
> > > been modified." >&2; exit 1; fi; touch .checked-atomic-instrumented.h
> > >   if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
> > > the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
> > > ::p' include/linux/atomic/atomic-long.h)" != "$(sed '$d'
> > > include/linux/atomic/atomic-long.h | sha1sum | sed 's/ .*//')" ]; then
> > > echo "error: include/linux/atomic/atomic-long.h has been modified."
> > > >&2; exit 1; fi; touch .checked-atomic-long.h
> > >
> > >
> > >
> > >
> > >
> > >
> > > >
> > > > Thanks.
> > > >
> > > > Best regards,
> > > > -Sedat-
> > >
> > >
> > >
> > >
> > > --
> > > Best Regards
> > > Masahiro Yamada
>
>
>
> --
> Best Regards
> Masahiro Yamada

Re: [6.2-rc4] warning: cannot check the header due to sha1sum missing

[Miguel Ojeda]

On Wed, Jan 18, 2023 at 11:12 AM Sedat Dilek <sedat.dilek@gmail.com> wrote:
>
> No, I disagree.

I agree with Masahiro -- either this is `V=1` output (and you
confirmed you used `V=1`) or your report is unclear about what you are
actually seeing.

Did you see the actual warnings in your output?

> You demonstrated by:
>
> $ make V=1 mrproper defconfig  prepare | grep sha1sum
>
> That you see these warnings, too.

There are no warnings in his output. They are `echo` parameters.

Cheers,
Miguel

Re: [6.2-rc4] warning: cannot check the header due to sha1sum missing

[Sedat Dilek]

On Wed, Jan 18, 2023 at 8:51 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> On Wed, Jan 18, 2023 at 4:45 PM Sedat Dilek <sedat.dilek@gmail.com> wrote:
> >
> > On Mon, Jan 16, 2023 at 4:21 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
> > >
> > > On Mon, Jan 16, 2023 at 11:02 AM Sedat Dilek <sedat.dilek@gmail.com> wrote:
> > > >
> > > > Hi Masahiro,
> > > >
> > > > I saw these warnings in my build-log:
> > > >
> > > >   if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
> > > > the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
> > > > ::p' include/linux/atomic/
> > > > atomic-arch-fallback.h)" != "$(sed '$d'
> > > > include/linux/atomic/atomic-arch-fallback.h | sha1sum | sed 's/
> > > > .*//')" ]; then echo "error: include/linux/atomic/atomic-arch-f
> > > > allback.h has been modified." >&2; exit 1; fi; touch
> > > > .checked-atomic-arch-fallback.h
> > > >  if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
> > > > the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
> > > > ::p' include/linux/atomic/
> > > > atomic-instrumented.h)" != "$(sed '$d'
> > > > include/linux/atomic/atomic-instrumented.h | sha1sum | sed 's/ .*//')"
> > > > ]; then echo "error: include/linux/atomic/atomic-instrume
> > > > nted.h has been modified." >&2; exit 1; fi; touch .checked-atomic-instrumented.h
> > > >  if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
> > > > the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
> > > > ::p' include/linux/atomic/
> > > > atomic-long.h)" != "$(sed '$d' include/linux/atomic/atomic-long.h |
> > > > sha1sum | sed 's/ .*//')" ]; then echo "error:
> > > > include/linux/atomic/atomic-long.h has been modified
> > > > ." >&2; exit 1; fi; touch .checked-atomic-long.h
> > > >
> > > > NOTE: I did a `make distclean` before I started my build.
> > > >
> > > > Can you please comment on this?
> > >
> > >
> > >
> > >
> > > Please clarify your problem.
> > >
> > > My best guess is, you just added V=1 option to
> > > print the full log, didn't you?
> > >
> > >
> > >
> > > I can see the same build log by running the following command.
> > >
> >
> > Hi Masahiro,
> >
> > you had a chance to look into this?
>
>
> I already replied.
> This is the output of V=1.
> There is no issue.
>

This due to this change?

commit b10fdeea8cf42c0d97b337e9e501c92da4389a03
"kbuild: check sha1sum just once for each atomic header"

$ LC_ALL=C git blame Kbuild | grep 'warning: cannot check the header
due to sha1sum missing'
b10fdeea8cf42 (Masahiro Yamada    2022-08-20 18:15:29 +0900 51)
         echo "warning: cannot check the header due to sha1sum
missing"; \

diff --git a/Kbuild b/Kbuild
index e122d93cee320..0b9e8a16a6212 100644
--- a/Kbuild
+++ b/Kbuild
...
+# Check the manual modification of atomic headers
+
+quiet_cmd_check_sha1 = CHKSHA1 $<
+      cmd_check_sha1 = \
+ if ! command -v sha1sum >/dev/null; then \
+ echo "warning: cannot check the header due to sha1sum missing"; \
+ exit 0; \
+ fi; \
+ if [ "$$(sed -n '$$s:// ::p' $<)" != \
+      "$$(sed '$$d' $< | sha1sum | sed 's/ .*//')" ]; then \
+ echo "error: $< has been modified." >&2; \
+ exit 1; \
+ fi; \
+ touch $@
+
+atomic-checks += $(addprefix $(obj)/.checked-, \
+   atomic-arch-fallback.h \
+   atomic-instrumented.h \
+   atomic-long.h)
+
+targets += $(atomic-checks)
+$(atomic-checks): $(obj)/.checked-%: include/linux/atomic/%  FORCE
+ $(call if_changed,check_sha1)
...

Again, what says my make V=1 log-file:

$ grep warning:
6.2.0-rc4-2-amd64-clang15-kcfi/build-log_6.2.0-rc4-2-amd64-clang15-kcfi.txt

222:  if ! command -v sha1sum >/dev/null; then echo "warning: cannot
check the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n
'$s:// ::p' include/linux/atomic/atomic-arch-fallback.h)" != "$(sed
'$d' include/linux/atomic/atomic-arch-fallback.h | sha1sum | sed 's/
.*//')" ]; then echo "error:
include/linux/atomic/atomic-arch-fallback.h has been modified." >&2;
exit 1; fi; touch .checked-atomic-arch-fallback.h

223:  if ! command -v sha1sum >/dev/null; then echo "warning: cannot
check the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n
'$s:// ::p' include/linux/atomic/atomic-instrumented.h)" != "$(sed
'$d' include/linux/atomic/atomic-instrumented.h | sha1sum | sed 's/
.*//')" ]; then echo "error:
include/linux/atomic/atomic-instrumented.h has been modified." >&2;
exit 1; fi; touch .checked-atomic-instrumented.h

224:  if ! command -v sha1sum >/dev/null; then echo "warning: cannot
check the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n
'$s:// ::p' include/linux/atomic/atomic-long.h)" != "$(sed '$d'
include/linux/atomic/atomic-long.h | sha1sum | sed 's/ .*//')" ]; then
echo "error: include/linux/atomic/atomic-long.h has been modified."
>&2; exit 1; fi; touch .checked-atomic-long.h

Does it only say I checked the timestamp and thus created
.checked-$atomic-header-file or does it say I have checked the
timestamp and see there were modifications and thus created
.checked-$atomic-header-file?

Thanks.

[1] https://git.kernel.org/linus/b10fdeea8cf42

>
>
>
> >
> > Thanks.
> >
> > Regards,
> > -Sedat-
> >
> > >
> > > $ make V=1 mrproper defconfig  prepare | grep sha1sum
> > > + [ clean = clean ]
> > > + cleanup
> > > + rm -f .btf.*
> > > + rm -f System.map
> > > + rm -f vmlinux
> > > + rm -f vmlinux.map
> > > + exit 0
> > >   if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
> > > the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
> > > ::p' include/linux/atomic/atomic-arch-fallback.h)" != "$(sed '$d'
> > > include/linux/atomic/atomic-arch-fallback.h | sha1sum | sed 's/
> > > .*//')" ]; then echo "error:
> > > include/linux/atomic/atomic-arch-fallback.h has been modified." >&2;
> > > exit 1; fi; touch .checked-atomic-arch-fallback.h
> > >   if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
> > > the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
> > > ::p' include/linux/atomic/atomic-instrumented.h)" != "$(sed '$d'
> > > include/linux/atomic/atomic-instrumented.h | sha1sum | sed 's/ .*//')"
> > > ]; then echo "error: include/linux/atomic/atomic-instrumented.h has
> > > been modified." >&2; exit 1; fi; touch .checked-atomic-instrumented.h
> > >   if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
> > > the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
> > > ::p' include/linux/atomic/atomic-long.h)" != "$(sed '$d'
> > > include/linux/atomic/atomic-long.h | sha1sum | sed 's/ .*//')" ]; then
> > > echo "error: include/linux/atomic/atomic-long.h has been modified."
> > > >&2; exit 1; fi; touch .checked-atomic-long.h
> > >
> > >
> > >
> > >
> > >
> > >
> > > >
> > > > Thanks.
> > > >
> > > > Best regards,
> > > > -Sedat-
> > >
> > >
> > >
> > >
> > > --
> > > Best Regards
> > > Masahiro Yamada
>
>
>
> --
> Best Regards
> Masahiro Yamada

Re: [6.2-rc4] warning: cannot check the header due to sha1sum missing

[Sedat Dilek]

Test-Case:

cd /path/to/linux.git

make clean

make distclean

sha1sum include/linux/atomic/atomic-* > ../SHA1SUM.before

make V=1 mrproper defconfig prepare 2>&1 | tee ../test-masahiro-sha1sum-v2.log

sha1sum include/linux/atomic/atomic-* > ../SHA1SUM.after

ll .checked-atomic-* ..checked-atomic-*
-rw-r--r-- 1 dileks dileks   0 20. Jan 17:22 .checked-atomic-arch-fallback.h
-rw-r--r-- 1 dileks dileks 460 20. Jan 17:22
..checked-atomic-arch-fallback.h.cmd
-rw-r--r-- 1 dileks dileks   0 20. Jan 17:22 .checked-atomic-instrumented.h
-rw-r--r-- 1 dileks dileks 455 20. Jan 17:22 ..checked-atomic-instrumented.h.cmd
-rw-r--r-- 1 dileks dileks   0 20. Jan 17:22 .checked-atomic-long.h
-rw-r--r-- 1 dileks dileks 415 20. Jan 17:22 ..checked-atomic-long.h.cmd

grep warning: ../test-masahiro-sha1sum-v2.log
2096:  if ! command -v sha1sum >/dev/null; then echo "warning: cannot
check the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n
'$s:// ::p' include/linux/atomic/atomic-arch-fallback.h)" != "$(sed
'$d' include/linux/atomic/atomic-arch-fallback.h | sha1sum | sed 's/
.*//')" ]; then echo "error:
include/linux/atomic/atomic-arch-fallback.h has been modified." >&2;
exit 1; fi; touch .checked-atomic-arch-fallback.h
2097:  if ! command -v sha1sum >/dev/null; then echo "warning: cannot
check the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n
'$s:// ::p' include/linux/atomic/atomic-instrumented.h)" != "$(sed
'$d' include/linux/atomic/atomic-instrumented.h | sha1sum | sed 's/
.*//')" ]; then echo "error:
include/linux/atomic/atomic-instrumented.h has been modified." >&2;
exit 1; fi; touch .checked-atomic-instrumented.h
2098:  if ! command -v sha1sum >/dev/null; then echo "warning: cannot
check the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n
'$s:// ::p' include/linux/atomic/atomic-long.h)" != "$(sed '$d'
include/linux/atomic/atomic-long.h | sha1sum | sed 's/ .*//')" ]; then
echo "error: include/linux/atomic/atomic-long.h has been modified."
>&2; exit 1; fi; touch .checked-atomic-long.h

cd ..

git diff SHA1SUM.before SHA1SUM.after
[ empty ]

OK, so no atomic header files were changed - looks to me like a "I
have checked them... found no diff... leave some checked files to
confirm this".

-Sedat-