From: Masahiro Yamada <masahiroy@kernel.org> To: Boris Kolpackov <boris@codesynthesis.com> Cc: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>, "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>, Jaroslav Kysela <perex@perex.cz>, Kalle Valo <kvalo@codeaurora.org>, Liam Girdwood <lgirdwood@gmail.com>, Luca Coelho <luciano.coelho@intel.com>, Mark Brown <broonie@kernel.org>, Peter Ujfalusi <peter.ujfalusi@gmail.com>, Takashi Iwai <tiwai@suse.com>, ALSA Development Mailing List <alsa-devel@alsa-project.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-wireless@vger.kernel.org, Networking <netdev@vger.kernel.org> Subject: Re: [PATCH] kconfig: forbid symbols that end with '_MODULE' Date: Thu, 26 Aug 2021 11:24:15 +0900 [thread overview] Message-ID: <CAK7LNAS-NhR=94uHYcZUhRkdUEm=dYZSRbGKkB5zJJGNRw0z2A@mail.gmail.com> (raw) In-Reply-To: <boris.20210825172545@codesynthesis.com> On Thu, Aug 26, 2021 at 12:42 AM Boris Kolpackov <boris@codesynthesis.com> wrote: > > Masahiro Yamada <masahiroy@kernel.org> writes: > > > Kconfig (syncconfig) generates include/generated/autoconf.h to make > > CONFIG options available to the pre-processor. > > > > The macros are suffixed with '_MODULE' for symbols with the value 'm'. > > > > Here is a conflict; CONFIG_FOO=m results in '#define CONFIG_FOO_MODULE 1', > > but CONFIG_FOO_MODULE=y also results in the same define. > > > > fixdep always assumes CONFIG_FOO_MODULE comes from CONFIG_FOO=m, so the > > dependency is not properly tracked for symbols that end with '_MODULE'. > > It seem to me the problem is in autoconf.h/fixdep, not in the Kconfig > language. Partly a Kconfig problem since autoconf.h is generated by Kconfig. So, what is your suggestion for doing this correctly? (of course without breaking the compatibility because this is how the kernel is configured/built for more than 20 years) > > > This commit makes Kconfig error out if it finds a symbol suffixed with > > '_MODULE'. > > I know you don't care, but I will voice my objection, for the record: > Kconfig is used by projects other than the Linux kernel and some of > them do not use the autoconf.h functionality. For such projects this > restriction seems arbitrary and potentially backwards-incompatible. I am not sure what your worry is, but this check resides in "if (modules_sym)" conditional, so projects using Kconfig but not module functionality (e.g. buildroot) will not be affected. -- Best Regards Masahiro Yamada
WARNING: multiple messages have this Message-ID (diff)
From: Masahiro Yamada <masahiroy@kernel.org> To: Boris Kolpackov <boris@codesynthesis.com> Cc: ALSA Development Mailing List <alsa-devel@alsa-project.org>, Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Takashi Iwai <tiwai@suse.com>, linux-wireless@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Luca Coelho <luciano.coelho@intel.com>, Networking <netdev@vger.kernel.org>, Jakub Kicinski <kuba@kernel.org>, Peter Ujfalusi <peter.ujfalusi@gmail.com>, "David S. Miller" <davem@davemloft.net>, Kalle Valo <kvalo@codeaurora.org> Subject: Re: [PATCH] kconfig: forbid symbols that end with '_MODULE' Date: Thu, 26 Aug 2021 11:24:15 +0900 [thread overview] Message-ID: <CAK7LNAS-NhR=94uHYcZUhRkdUEm=dYZSRbGKkB5zJJGNRw0z2A@mail.gmail.com> (raw) In-Reply-To: <boris.20210825172545@codesynthesis.com> On Thu, Aug 26, 2021 at 12:42 AM Boris Kolpackov <boris@codesynthesis.com> wrote: > > Masahiro Yamada <masahiroy@kernel.org> writes: > > > Kconfig (syncconfig) generates include/generated/autoconf.h to make > > CONFIG options available to the pre-processor. > > > > The macros are suffixed with '_MODULE' for symbols with the value 'm'. > > > > Here is a conflict; CONFIG_FOO=m results in '#define CONFIG_FOO_MODULE 1', > > but CONFIG_FOO_MODULE=y also results in the same define. > > > > fixdep always assumes CONFIG_FOO_MODULE comes from CONFIG_FOO=m, so the > > dependency is not properly tracked for symbols that end with '_MODULE'. > > It seem to me the problem is in autoconf.h/fixdep, not in the Kconfig > language. Partly a Kconfig problem since autoconf.h is generated by Kconfig. So, what is your suggestion for doing this correctly? (of course without breaking the compatibility because this is how the kernel is configured/built for more than 20 years) > > > This commit makes Kconfig error out if it finds a symbol suffixed with > > '_MODULE'. > > I know you don't care, but I will voice my objection, for the record: > Kconfig is used by projects other than the Linux kernel and some of > them do not use the autoconf.h functionality. For such projects this > restriction seems arbitrary and potentially backwards-incompatible. I am not sure what your worry is, but this check resides in "if (modules_sym)" conditional, so projects using Kconfig but not module functionality (e.g. buildroot) will not be affected. -- Best Regards Masahiro Yamada
next prev parent reply other threads:[~2021-08-26 2:25 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-25 4:16 [PATCH] kconfig: forbid symbols that end with '_MODULE' Masahiro Yamada 2021-08-25 4:16 ` Masahiro Yamada 2021-08-25 9:52 ` Mark Brown 2021-08-25 9:52 ` Mark Brown 2021-08-25 11:59 ` Péter Ujfalusi 2021-08-25 11:59 ` Péter Ujfalusi 2021-08-26 2:28 ` Masahiro Yamada 2021-08-26 2:28 ` Masahiro Yamada 2021-09-01 7:07 ` Péter Ujfalusi 2021-09-01 7:07 ` Péter Ujfalusi 2021-08-25 15:34 ` Boris Kolpackov 2021-08-25 15:34 ` Boris Kolpackov 2021-08-26 2:24 ` Masahiro Yamada [this message] 2021-08-26 2:24 ` Masahiro Yamada 2021-08-26 12:16 ` Boris Kolpackov 2021-08-26 12:16 ` Boris Kolpackov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAK7LNAS-NhR=94uHYcZUhRkdUEm=dYZSRbGKkB5zJJGNRw0z2A@mail.gmail.com' \ --to=masahiroy@kernel.org \ --cc=alsa-devel@alsa-project.org \ --cc=boris@codesynthesis.com \ --cc=broonie@kernel.org \ --cc=davem@davemloft.net \ --cc=kuba@kernel.org \ --cc=kvalo@codeaurora.org \ --cc=lgirdwood@gmail.com \ --cc=linux-kbuild@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-wireless@vger.kernel.org \ --cc=luciano.coelho@intel.com \ --cc=netdev@vger.kernel.org \ --cc=perex@perex.cz \ --cc=peter.ujfalusi@gmail.com \ --cc=tiwai@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.