From: Masahiro Yamada <yamada.masahiro@socionext.com> To: Michael Davidson <md@google.com> Cc: Michal Marek <mmarek@suse.com>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>, Herbert Xu <herbert@gondor.apana.org.au>, "David S. Miller" <davem@davemloft.net>, Shaohua Li <shli@kernel.org>, Alexander Potapenko <glider@google.com>, Dmitry Vyukov <dvyukov@google.com>, Matthias Kaehlcke <mka@chromium.org>, X86 ML <x86@kernel.org>, Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-crypto@vger.kernel.org, linux-raid@vger.kernel.org Subject: Re: [PATCH 1/7] Makefile, LLVM: add -no-integrated-as to KBUILD_[AC]FLAGS Date: Fri, 21 Apr 2017 16:49:53 +0900 [thread overview] Message-ID: <CAK7LNAS0i=Qtoqk3hZMhAyQOXWf-8=fb0bSMh=gMJ3-bunQ_5Q@mail.gmail.com> (raw) In-Reply-To: <20170317001520.85223-2-md@google.com> Hi Michael, 2017-03-17 9:15 GMT+09:00 Michael Davidson <md@google.com>: > Add -no-integrated-as to KBUILD_AFLAGS and KBUILD_CFLAGS > for clang. >From the code-diff, it is apparent that you added -no-integrated-as. Rather, I'd like to see "why" in the git-log. Obviously, clang needs this patch to build the kernel, but can you describe the reason why the integrated assembler is bad? With git-log reworded, I will pick up this shortly. Thanks! > Signed-off-by: Michael Davidson <md@google.com> > --- > Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Makefile b/Makefile > index b841fb36beb2..b21fd0ca2946 100644 > --- a/Makefile > +++ b/Makefile > @@ -704,6 +704,8 @@ KBUILD_CFLAGS += $(call cc-disable-warning, tautological-compare) > # See modpost pattern 2 > KBUILD_CFLAGS += $(call cc-option, -mno-global-merge,) > KBUILD_CFLAGS += $(call cc-option, -fcatch-undefined-behavior) > +KBUILD_CFLAGS += $(call cc-option, -no-integrated-as) > +KBUILD_AFLAGS += $(call cc-option, -no-integrated-as) > else > > # These warnings generated too much noise in a regular build. -- Best Regards Masahiro Yamada
WARNING: multiple messages have this Message-ID (diff)
From: Masahiro Yamada <yamada.masahiro@socionext.com> To: Michael Davidson <md@google.com> Cc: Michal Marek <mmarek@suse.com>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>, Herbert Xu <herbert@gondor.apana.org.au>, "David S. Miller" <davem@davemloft.net>, Shaohua Li <shli@kernel.org>, Alexander Potapenko <glider@google.com>, Dmitry Vyukov <dvyukov@google.com>, Matthias Kaehlcke <mka@chromium.org>, X86 ML <x86@kernel.org>, Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-crypto@vger.kernel.org, linux-raid@vger.kernel.org Subject: Re: [PATCH 1/7] Makefile, LLVM: add -no-integrated-as to KBUILD_[AC]FLAGS Date: Fri, 21 Apr 2017 16:49:53 +0900 [thread overview] Message-ID: <CAK7LNAS0i=Qtoqk3hZMhAyQOXWf-8=fb0bSMh=gMJ3-bunQ_5Q@mail.gmail.com> (raw) In-Reply-To: <20170317001520.85223-2-md@google.com> Hi Michael, 2017-03-17 9:15 GMT+09:00 Michael Davidson <md@google.com>: > Add -no-integrated-as to KBUILD_AFLAGS and KBUILD_CFLAGS > for clang. From the code-diff, it is apparent that you added -no-integrated-as. Rather, I'd like to see "why" in the git-log. Obviously, clang needs this patch to build the kernel, but can you describe the reason why the integrated assembler is bad? With git-log reworded, I will pick up this shortly. Thanks! > Signed-off-by: Michael Davidson <md@google.com> > --- > Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Makefile b/Makefile > index b841fb36beb2..b21fd0ca2946 100644 > --- a/Makefile > +++ b/Makefile > @@ -704,6 +704,8 @@ KBUILD_CFLAGS += $(call cc-disable-warning, tautological-compare) > # See modpost pattern 2 > KBUILD_CFLAGS += $(call cc-option, -mno-global-merge,) > KBUILD_CFLAGS += $(call cc-option, -fcatch-undefined-behavior) > +KBUILD_CFLAGS += $(call cc-option, -no-integrated-as) > +KBUILD_AFLAGS += $(call cc-option, -no-integrated-as) > else > > # These warnings generated too much noise in a regular build. -- Best Regards Masahiro Yamada
next prev parent reply other threads:[~2017-04-21 7:49 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-17 0:15 [PATCH 0/7] LLVM: make x86_64 kernel build with clang Michael Davidson 2017-03-17 0:15 ` [PATCH 1/7] Makefile, LLVM: add -no-integrated-as to KBUILD_[AC]FLAGS Michael Davidson 2017-04-03 22:49 ` Matthias Kaehlcke 2017-04-21 7:49 ` Masahiro Yamada [this message] 2017-04-21 7:49 ` Masahiro Yamada 2017-03-17 0:15 ` [PATCH 2/7] Makefile, x86, LLVM: disable unsupported optimization flags Michael Davidson 2017-03-17 21:32 ` H. Peter Anvin 2017-03-17 21:34 ` H. Peter Anvin 2017-04-05 18:08 ` Masahiro Yamada 2017-04-05 19:01 ` Matthias Kaehlcke 2017-04-05 19:11 ` Michael Davidson 2017-04-10 14:54 ` Masahiro Yamada 2017-03-17 0:15 ` [PATCH 3/7] x86, LLVM: suppress clang warnings about unaligned accesses Michael Davidson 2017-03-17 23:50 ` hpa 2017-04-03 23:01 ` Matthias Kaehlcke 2017-04-13 23:14 ` Matthias Kaehlcke 2017-04-13 23:55 ` H. Peter Anvin 2017-04-14 0:23 ` Matthias Kaehlcke 2017-04-14 5:30 ` hpa 2017-03-17 0:15 ` [PATCH 4/7] x86, boot, LLVM: #undef memcpy etc in string.c Michael Davidson 2017-06-22 22:31 ` Matthias Kaehlcke 2017-06-22 22:37 ` H. Peter Anvin 2017-06-30 18:32 ` Matthias Kaehlcke 2017-03-17 0:15 ` [PATCH 5/7] x86, boot, LLVM: Use regparm=0 for memcpy and memset Michael Davidson 2017-03-17 12:08 ` Peter Zijlstra 2017-06-22 22:38 ` H. Peter Anvin 2017-03-17 0:15 ` [PATCH 6/7] md/raid10, LLVM: get rid of variable length array Michael Davidson 2017-03-17 12:08 ` Peter Zijlstra 2017-03-17 12:31 ` Alexander Potapenko 2017-03-17 12:32 ` Alexander Potapenko 2017-03-17 18:03 ` Borislav Petkov 2017-03-17 18:47 ` Dmitry Vyukov 2017-03-17 18:57 ` Borislav Petkov 2017-03-17 19:05 ` Dmitry Vyukov 2017-03-17 19:26 ` Peter Zijlstra 2017-03-17 19:26 ` Peter Zijlstra 2017-03-17 19:29 ` Peter Zijlstra 2017-03-24 13:50 ` Dmitry Vyukov 2017-03-24 14:10 ` Peter Zijlstra 2017-03-24 14:22 ` Dmitry Vyukov 2017-03-18 0:41 ` Fengguang Wu 2017-03-17 12:44 ` Peter Zijlstra 2017-03-17 18:52 ` Michael Davidson 2017-03-17 19:27 ` Peter Zijlstra 2017-03-17 20:04 ` hpa 2017-03-24 13:47 ` Dmitry Vyukov 2017-03-24 14:09 ` Peter Zijlstra 2017-03-17 0:15 ` [PATCH 7/7] crypto, x86, LLVM: aesni - fix token pasting Michael Davidson 2017-04-03 23:14 ` Matthias Kaehlcke 2017-03-17 8:17 ` [PATCH 0/7] LLVM: make x86_64 kernel build with clang Dmitry Vyukov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAK7LNAS0i=Qtoqk3hZMhAyQOXWf-8=fb0bSMh=gMJ3-bunQ_5Q@mail.gmail.com' \ --to=yamada.masahiro@socionext.com \ --cc=davem@davemloft.net \ --cc=dvyukov@google.com \ --cc=glider@google.com \ --cc=herbert@gondor.apana.org.au \ --cc=hpa@zytor.com \ --cc=linux-crypto@vger.kernel.org \ --cc=linux-kbuild@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-raid@vger.kernel.org \ --cc=md@google.com \ --cc=mingo@redhat.com \ --cc=mka@chromium.org \ --cc=mmarek@suse.com \ --cc=shli@kernel.org \ --cc=tglx@linutronix.de \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.