All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masahiro Yamada <masahiroy@kernel.org>
To: "Uwe Kleine-König" <uwe@kleine-koenig.org>
Cc: Michal Marek <michal.lkml@markovi.net>,
	Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	cyril@debamax.com, Arnd Bergmann <arnd@arndb.de>,
	Maxime Ripard <mripard@kernel.org>,
	DTML <devicetree@vger.kernel.org>
Subject: Re: [PATCH] cmd_dtc: Enable generation of device tree symbols
Date: Tue, 26 Jan 2021 06:53:22 +0900	[thread overview]
Message-ID: <CAK7LNAS5t1wew0MMFjdB5HGCAMerhU7pAGiFhcTtCRUAAjGLpw@mail.gmail.com> (raw)
In-Reply-To: <20210125105757.661240-1-uwe@kleine-koenig.org>

On Mon, Jan 25, 2021 at 8:07 PM Uwe Kleine-König <uwe@kleine-koenig.org> wrote:
>
> Adding the -@ switch to dtc results in the binary devicetrees containing
> a list of symbolic references and their paths. This is necessary to
> apply device tree overlays e.g. on Raspberry Pi as described on
> https://www.raspberrypi.org/documentation/configuration/device-tree.md.
>
> Obviously the downside of this change is an increas of the size of the
> generated dtbs, for an arm out-of-tree build (multi_v7_defconfig):
>
>         $ du -s arch/arm/boot/dts*
>         101380  arch/arm/boot/dts-pre
>         114308  arch/arm/boot/dts-post
>
> so this is in average an increase of 12.8% in size.
>
> Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>


(CCing DT ML.)


https://www.spinics.net/lists/linux-kbuild/msg27904.html

See Rob's comment:

"We've already rejected doing that. Turning on '-@' can grow the dtb
size by a significant amount which could be problematic for some
boards."








> ---
>  scripts/Makefile.lib | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index 213677a5ed33..0683a5808f7f 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -319,7 +319,7 @@ $(obj)/%.dtb.S: $(obj)/%.dtb FORCE
>
>  quiet_cmd_dtc = DTC     $@
>  cmd_dtc = $(HOSTCC) -E $(dtc_cpp_flags) -x assembler-with-cpp -o $(dtc-tmp) $< ; \
> -       $(DTC) -O $(patsubst .%,%,$(suffix $@)) -o $@ -b 0 \
> +       $(DTC) -@ -O $(patsubst .%,%,$(suffix $@)) -o $@ -b 0 \
>                 $(addprefix -i,$(dir $<) $(DTC_INCLUDE)) $(DTC_FLAGS) \
>                 -d $(depfile).dtc.tmp $(dtc-tmp) ; \
>         cat $(depfile).pre.tmp $(depfile).dtc.tmp > $(depfile)
> --
> 2.29.2
>


--
Best Regards

Masahiro Yamada

WARNING: multiple messages have this Message-ID (diff)
From: Masahiro Yamada <masahiroy@kernel.org>
To: "Uwe Kleine-König" <uwe@kleine-koenig.org>
Cc: DTML <devicetree@vger.kernel.org>,
	Michal Marek <michal.lkml@markovi.net>,
	Arnd Bergmann <arnd@arndb.de>,
	Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Maxime Ripard <mripard@kernel.org>,
	cyril@debamax.com,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] cmd_dtc: Enable generation of device tree symbols
Date: Tue, 26 Jan 2021 06:53:22 +0900	[thread overview]
Message-ID: <CAK7LNAS5t1wew0MMFjdB5HGCAMerhU7pAGiFhcTtCRUAAjGLpw@mail.gmail.com> (raw)
In-Reply-To: <20210125105757.661240-1-uwe@kleine-koenig.org>

On Mon, Jan 25, 2021 at 8:07 PM Uwe Kleine-König <uwe@kleine-koenig.org> wrote:
>
> Adding the -@ switch to dtc results in the binary devicetrees containing
> a list of symbolic references and their paths. This is necessary to
> apply device tree overlays e.g. on Raspberry Pi as described on
> https://www.raspberrypi.org/documentation/configuration/device-tree.md.
>
> Obviously the downside of this change is an increas of the size of the
> generated dtbs, for an arm out-of-tree build (multi_v7_defconfig):
>
>         $ du -s arch/arm/boot/dts*
>         101380  arch/arm/boot/dts-pre
>         114308  arch/arm/boot/dts-post
>
> so this is in average an increase of 12.8% in size.
>
> Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>


(CCing DT ML.)


https://www.spinics.net/lists/linux-kbuild/msg27904.html

See Rob's comment:

"We've already rejected doing that. Turning on '-@' can grow the dtb
size by a significant amount which could be problematic for some
boards."








> ---
>  scripts/Makefile.lib | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index 213677a5ed33..0683a5808f7f 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -319,7 +319,7 @@ $(obj)/%.dtb.S: $(obj)/%.dtb FORCE
>
>  quiet_cmd_dtc = DTC     $@
>  cmd_dtc = $(HOSTCC) -E $(dtc_cpp_flags) -x assembler-with-cpp -o $(dtc-tmp) $< ; \
> -       $(DTC) -O $(patsubst .%,%,$(suffix $@)) -o $@ -b 0 \
> +       $(DTC) -@ -O $(patsubst .%,%,$(suffix $@)) -o $@ -b 0 \
>                 $(addprefix -i,$(dir $<) $(DTC_INCLUDE)) $(DTC_FLAGS) \
>                 -d $(depfile).dtc.tmp $(dtc-tmp) ; \
>         cat $(depfile).pre.tmp $(depfile).dtc.tmp > $(depfile)
> --
> 2.29.2
>


--
Best Regards

Masahiro Yamada

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-01-25 21:55 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-25 10:57 [PATCH] cmd_dtc: Enable generation of device tree symbols Uwe Kleine-König
2021-01-25 10:57 ` Uwe Kleine-König
2021-01-25 11:15 ` Cyril Brulebois
2021-01-25 11:15   ` Cyril Brulebois
2021-01-26 18:01   ` Frank Rowand
2021-01-26 18:01     ` Frank Rowand
2021-01-25 21:53 ` Masahiro Yamada [this message]
2021-01-25 21:53   ` Masahiro Yamada
2021-01-26  7:20   ` Uwe Kleine-König
2021-01-26  7:20     ` Uwe Kleine-König
2021-01-26  8:43     ` Geert Uytterhoeven
2021-01-26  8:43       ` Geert Uytterhoeven
2021-01-26 18:03       ` Frank Rowand
2021-01-26 18:03         ` Frank Rowand
2021-01-26 13:42     ` Rob Herring
2021-01-26 13:42       ` Rob Herring
2021-01-26 18:03     ` Frank Rowand
2021-01-26 18:03       ` Frank Rowand
2021-01-26 18:26       ` Frank Rowand
2021-01-26 18:26         ` Frank Rowand
2021-01-26 18:02   ` Frank Rowand
2021-01-26 18:02     ` Frank Rowand
2021-01-26 18:01 ` Frank Rowand
2021-01-26 18:01   ` Frank Rowand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK7LNAS5t1wew0MMFjdB5HGCAMerhU7pAGiFhcTtCRUAAjGLpw@mail.gmail.com \
    --to=masahiroy@kernel.org \
    --cc=arnd@arndb.de \
    --cc=cyril@debamax.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=mripard@kernel.org \
    --cc=uwe@kleine-koenig.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.