* [kbuild:kconfig2 1/10] arch/um/Kconfig:3: can't open file "arch/x86_64/um/Kconfig"
@ 2018-07-28 7:23 kbuild test robot
2018-07-29 2:11 ` Masahiro Yamada
0 siblings, 1 reply; 4+ messages in thread
From: kbuild test robot @ 2018-07-28 7:23 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: kbuild-all, linux-kbuild, Masahiro Yamada
tree: https://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git kconfig2
head: 0e83fd903bc85173711186755591b61405647cf3
commit: 2cc1bfaf2c45056c73970a99c3a7467e157f56aa [1/10] um: stop abusing KBUILD_KCONFIG
config: um-x86_64_defconfig
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
git checkout 2cc1bfaf2c45056c73970a99c3a7467e157f56aa
make ARCH=um SUBARCH=x86_64 defconfig
make ARCH=um SUBARCH=x86_64
All errors (new ones prefixed by >>):
>> arch/um/Kconfig:3: can't open file "arch/x86_64/um/Kconfig"
make[2]: *** [defconfig] Error 1
make[1]: *** [defconfig] Error 2
make: *** [sub-make] Error 2
--
>> arch/um/Kconfig:3: can't open file "arch/x86_64/um/Kconfig"
make[2]: *** [oldconfig] Error 1
make[1]: *** [oldconfig] Error 2
make: *** [sub-make] Error 2
--
>> arch/um/Kconfig:3: can't open file "arch/x86_64/um/Kconfig"
make[2]: *** [olddefconfig] Error 1
make[1]: *** [olddefconfig] Error 2
make: *** [sub-make] Error 2
vim +3 arch/um/Kconfig
2
> 3 source "arch/$(SUBARCH)/um/Kconfig"
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [kbuild:kconfig2 1/10] arch/um/Kconfig:3: can't open file "arch/x86_64/um/Kconfig"
2018-07-28 7:23 [kbuild:kconfig2 1/10] arch/um/Kconfig:3: can't open file "arch/x86_64/um/Kconfig" kbuild test robot
@ 2018-07-29 2:11 ` Masahiro Yamada
2018-07-30 9:42 ` Christoph Hellwig
0 siblings, 1 reply; 4+ messages in thread
From: Masahiro Yamada @ 2018-07-29 2:11 UTC (permalink / raw)
To: kbuild test robot
Cc: Christoph Hellwig, kbuild-all, Linux Kbuild mailing list, Randy Dunlap
Hi Christoph,
2018-07-28 16:23 GMT+09:00 kbuild test robot <lkp@intel.com>:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git kconfig2
> head: 0e83fd903bc85173711186755591b61405647cf3
> commit: 2cc1bfaf2c45056c73970a99c3a7467e157f56aa [1/10] um: stop abusing KBUILD_KCONFIG
> config: um-x86_64_defconfig
> compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
> reproduce:
> git checkout 2cc1bfaf2c45056c73970a99c3a7467e157f56aa
> make ARCH=um SUBARCH=x86_64 defconfig
> make ARCH=um SUBARCH=x86_64
Hmm.
SUBARCH is used by arch/x86/um/Kconfig
to choose 64BIT.
Maybe, do we need $(SUBSRCARCH) ?
(In hindsight, HOST_ARCH and HOST_SRCARCH
might be clearer, though...)
> All errors (new ones prefixed by >>):
>
>>> arch/um/Kconfig:3: can't open file "arch/x86_64/um/Kconfig"
> make[2]: *** [defconfig] Error 1
> make[1]: *** [defconfig] Error 2
> make: *** [sub-make] Error 2
> --
>>> arch/um/Kconfig:3: can't open file "arch/x86_64/um/Kconfig"
> make[2]: *** [oldconfig] Error 1
> make[1]: *** [oldconfig] Error 2
> make: *** [sub-make] Error 2
> --
>>> arch/um/Kconfig:3: can't open file "arch/x86_64/um/Kconfig"
> make[2]: *** [olddefconfig] Error 1
> make[1]: *** [olddefconfig] Error 2
> make: *** [sub-make] Error 2
>
> vim +3 arch/um/Kconfig
>
> 2
> > 3 source "arch/$(SUBARCH)/um/Kconfig"
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [kbuild:kconfig2 1/10] arch/um/Kconfig:3: can't open file "arch/x86_64/um/Kconfig"
2018-07-29 2:11 ` Masahiro Yamada
@ 2018-07-30 9:42 ` Christoph Hellwig
2018-07-30 16:59 ` Christoph Hellwig
0 siblings, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2018-07-30 9:42 UTC (permalink / raw)
To: Masahiro Yamada
Cc: kbuild test robot, Christoph Hellwig, kbuild-all,
Linux Kbuild mailing list, Randy Dunlap
On Sun, Jul 29, 2018 at 11:11:47AM +0900, Masahiro Yamada wrote:
> Hi Christoph,
>
> 2018-07-28 16:23 GMT+09:00 kbuild test robot <lkp@intel.com>:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git kconfig2
> > head: 0e83fd903bc85173711186755591b61405647cf3
> > commit: 2cc1bfaf2c45056c73970a99c3a7467e157f56aa [1/10] um: stop abusing KBUILD_KCONFIG
> > config: um-x86_64_defconfig
> > compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
> > reproduce:
> > git checkout 2cc1bfaf2c45056c73970a99c3a7467e157f56aa
> > make ARCH=um SUBARCH=x86_64 defconfig
> > make ARCH=um SUBARCH=x86_64
>
>
> Hmm.
> SUBARCH is used by arch/x86/um/Kconfig
> to choose 64BIT.
>
> Maybe, do we need $(SUBSRCARCH) ?
>
>
> (In hindsight, HOST_ARCH and HOST_SRCARCH
> might be clearer, though...)
Looks like it. I'll give it a spin and will resend (including the
folded PREEMPT_CODE fix).
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [kbuild:kconfig2 1/10] arch/um/Kconfig:3: can't open file "arch/x86_64/um/Kconfig"
2018-07-30 9:42 ` Christoph Hellwig
@ 2018-07-30 16:59 ` Christoph Hellwig
0 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2018-07-30 16:59 UTC (permalink / raw)
To: Masahiro Yamada
Cc: kbuild test robot, Christoph Hellwig, kbuild-all,
Linux Kbuild mailing list, Randy Dunlap
What do you think of the patch below? This reuses the HEADER_ARCH
variable that uml already needs to setup anyway:
diff --git a/arch/um/Kconfig b/arch/um/Kconfig
index dd4b67131105..6b9938919f0b 100644
--- a/arch/um/Kconfig
+++ b/arch/um/Kconfig
@@ -63,7 +63,7 @@ config NR_CPUS
range 1 1
default 1
-source "arch/$(SUBARCH)/um/Kconfig"
+source "arch/$(HEADER_ARCH)/um/Kconfig"
config STATIC_LINK
bool "Force a static link"
diff --git a/arch/um/Makefile b/arch/um/Makefile
index 0207f6316d71..a88b40ee0332 100644
--- a/arch/um/Makefile
+++ b/arch/um/Makefile
@@ -174,4 +174,4 @@ endef
include/generated/user_constants.h: $(HOST_DIR)/um/user-offsets.s
$(call filechk,gen-asm-offsets)
-export SUBARCH USER_CFLAGS CFLAGS_NO_HARDENING OS DEV_NULL_PATH
+export HEADER_ARCH USER_CFLAGS CFLAGS_NO_HARDENING OS DEV_NULL_PATH
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-30 18:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-28 7:23 [kbuild:kconfig2 1/10] arch/um/Kconfig:3: can't open file "arch/x86_64/um/Kconfig" kbuild test robot
2018-07-29 2:11 ` Masahiro Yamada
2018-07-30 9:42 ` Christoph Hellwig
2018-07-30 16:59 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.