From: Masahiro Yamada <yamada.masahiro@socionext.com> To: "Jason A. Donenfeld" <Jason@zx2c4.com> Cc: linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Russell King <rmk+kernel@armlinux.org.uk>, Arnd Bergmann <arnd@arndb.de>, Ard Biesheuvel <ard.biesheuvel@linaro.org> Subject: Re: [PATCH] arm: vdso: pass --be8 to linker if necessary Date: Tue, 18 Jun 2019 23:56:11 +0900 [thread overview] Message-ID: <CAK7LNAT4+O=eNoJHnW58pVob0Po0ULj3cEksXZ3w+kTGMNJj2w@mail.gmail.com> (raw) In-Reply-To: <CAHmME9rGAUW9hjjZ7ZqNvZvaOCGrVHs3JNhYyr6g2PhZgS3TQg@mail.gmail.com> Hi. On Fri, May 31, 2019 at 5:20 PM Jason A. Donenfeld <Jason@zx2c4.com> wrote: > > Hey Masahiro, > > I'm not sure exactly. I did just notice another place --be8 is being added: That is not my question. I just asked about your commit log: "big-endian ARM was relying on gcc to translate its -mbe8 option into ld's --be8 option" I grepped '-mbe8', but I did not see it anywhere in the source tree. So, I just wondered where it came from. > ifeq ($(CONFIG_CPU_ENDIAN_BE8),y) > LDFLAGS_vmlinux += --be8 > KBUILD_LDFLAGS_MODULE += --be8 > endif > > I suppose it's possible that this is kbuild related where one of those > isn't winding up in the right place. I did see that the commit that > this patch addresses uses "=" instead of the more usual ":=" or "+=" > for whatever reason. > > Jason Perhaps, the following will be cleaner: ldflags-$(CONFIG_CPU_ENDIAN_BE8) += --be8 ldflags-y += -Bsymbolic --no-undefined -soname=linux-vdso.so.1 \ -z max-page-size=4096 -z common-page-size=4096 \ -nostdlib -shared \ $(call ld-option, --hash-style=sysv) \ $(call ld-option, --build-id) \ -T I think this fix-up should be applied by Russell. Please note he does not pick up patches directly from ML. To ask him to pick up patches, you need to put patches into his patch tracker. (patches@arm.linux.org.uk) -- Best Regards Masahiro Yamada
WARNING: multiple messages have this Message-ID (diff)
From: Masahiro Yamada <yamada.masahiro@socionext.com> To: "Jason A. Donenfeld" <Jason@zx2c4.com> Cc: Russell King <rmk+kernel@armlinux.org.uk>, Arnd Bergmann <arnd@arndb.de>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, Ard Biesheuvel <ard.biesheuvel@linaro.org> Subject: Re: [PATCH] arm: vdso: pass --be8 to linker if necessary Date: Tue, 18 Jun 2019 23:56:11 +0900 [thread overview] Message-ID: <CAK7LNAT4+O=eNoJHnW58pVob0Po0ULj3cEksXZ3w+kTGMNJj2w@mail.gmail.com> (raw) In-Reply-To: <CAHmME9rGAUW9hjjZ7ZqNvZvaOCGrVHs3JNhYyr6g2PhZgS3TQg@mail.gmail.com> Hi. On Fri, May 31, 2019 at 5:20 PM Jason A. Donenfeld <Jason@zx2c4.com> wrote: > > Hey Masahiro, > > I'm not sure exactly. I did just notice another place --be8 is being added: That is not my question. I just asked about your commit log: "big-endian ARM was relying on gcc to translate its -mbe8 option into ld's --be8 option" I grepped '-mbe8', but I did not see it anywhere in the source tree. So, I just wondered where it came from. > ifeq ($(CONFIG_CPU_ENDIAN_BE8),y) > LDFLAGS_vmlinux += --be8 > KBUILD_LDFLAGS_MODULE += --be8 > endif > > I suppose it's possible that this is kbuild related where one of those > isn't winding up in the right place. I did see that the commit that > this patch addresses uses "=" instead of the more usual ":=" or "+=" > for whatever reason. > > Jason Perhaps, the following will be cleaner: ldflags-$(CONFIG_CPU_ENDIAN_BE8) += --be8 ldflags-y += -Bsymbolic --no-undefined -soname=linux-vdso.so.1 \ -z max-page-size=4096 -z common-page-size=4096 \ -nostdlib -shared \ $(call ld-option, --hash-style=sysv) \ $(call ld-option, --build-id) \ -T I think this fix-up should be applied by Russell. Please note he does not pick up patches directly from ML. To ask him to pick up patches, you need to put patches into his patch tracker. (patches@arm.linux.org.uk) -- Best Regards Masahiro Yamada _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-18 14:56 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-29 18:23 [PATCH] arm: vdso: pass --be8 to linker if necessary Jason A. Donenfeld 2019-05-29 18:23 ` Jason A. Donenfeld 2019-05-31 2:01 ` Masahiro Yamada 2019-05-31 2:01 ` Masahiro Yamada 2019-05-31 8:17 ` Jason A. Donenfeld 2019-05-31 8:17 ` Jason A. Donenfeld 2019-06-18 14:56 ` Masahiro Yamada [this message] 2019-06-18 14:56 ` Masahiro Yamada 2019-05-31 8:37 ` Russell King - ARM Linux admin 2019-05-31 8:37 ` Russell King - ARM Linux admin 2019-06-13 17:03 ` Jason A. Donenfeld 2019-06-13 17:03 ` Jason A. Donenfeld
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAK7LNAT4+O=eNoJHnW58pVob0Po0ULj3cEksXZ3w+kTGMNJj2w@mail.gmail.com' \ --to=yamada.masahiro@socionext.com \ --cc=Jason@zx2c4.com \ --cc=ard.biesheuvel@linaro.org \ --cc=arnd@arndb.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=rmk+kernel@armlinux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.