Re: [PATCH 4/5] x86/um: thin archives build fix

[Masahiro Yamada <yamada.masahiro@socionext.com>]

2017-06-09 14:24 GMT+09:00 Nicholas Piggin <npiggin@gmail.com>:
> The linker does not like vdso-syms.lds in input archive files.
> Make it an extra-y instead.
>
> Cc: Jeff Dike <jdike@addtoit.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: user-mode-linux-devel@lists.sourceforge.net
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> ---
>
> Arch maintainers please give an ack if we can take this through
> the kbuild tree.
>
> Thanks,
> Nick
>
>  arch/x86/um/vdso/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/um/vdso/Makefile b/arch/x86/um/vdso/Makefile
> index d72dec406ccb..329406224330 100644
> --- a/arch/x86/um/vdso/Makefile
> +++ b/arch/x86/um/vdso/Makefile
> @@ -53,7 +53,7 @@ CFLAGS_REMOVE_vdso-note.o = -pg -fprofile-arcs -ftest-coverage
>  CFLAGS_REMOVE_um_vdso.o = -pg -fprofile-arcs -ftest-coverage
>
>  targets += vdso-syms.lds
> -obj-$(VDSO64-y)                        += vdso-syms.lds
> +extra-$(VDSO64-y)                      += vdso-syms.lds


I agree this line is weird, but where is vdso-syms.lds used?


I removed the following, but it still built successfully.


targets += vdso-syms.lds
obj-$(VDSO64-y)                        += vdso-syms.lds

$(obj)/%-syms.lds: $(obj)/%.so.dbg FORCE
       $(call if_changed,vdsosym)





-- 
Best Regards
Masahiro Yamada