From: Rob Landley <rob@landley.net> To: Masahiro Yamada <yamada.masahiro@socionext.com>, Yoshinori Sato <ysato@users.sourceforge.jp>, linux-sh@vger.kernel.org, Rich Felker <dalias@libc.org> Cc: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>, Michal Marek <mmarek@suse.com>, Linus Torvalds <torvalds@linux-foundation.org>, Stephen Rothwell <sfr@canb.auug.org.au>, Nicholas Piggin <npiggin@gmail.com>, linux-arch <linux-arch@vger.kernel.org> Subject: Re: [PATCH 3/5] sh: thin archives fix linking Date: Wed, 21 Jun 2017 22:09:06 +0000 [thread overview] Message-ID: <7a1286aa-b656-7b71-2628-9093156143ff@landley.net> (raw) In-Reply-To: <CAK7LNARFQ0bLEYOgEKd+0oULevSxRqwFu_VSLn89gn_XBo+-uQ@mail.gmail.com> [-- Attachment #1: Type: text/plain, Size: 1166 bytes --] On 06/19/2017 01:19 AM, Masahiro Yamada wrote: > 2017-06-09 14:24 GMT+09:00 Nicholas Piggin <npiggin@gmail.com>: >> The VDSO symbols can't be linked into built-in.o when building with >> thin archives, so change this to linking them into the final link. >> >> Cc: Yoshinori Sato <ysato@users.sourceforge.jp> >> Cc: Rich Felker <dalias@libc.org> >> Cc: linux-sh@vger.kernel.org >> Signed-off-by: Nicholas Piggin <npiggin@gmail.com> >> --- > > SH maintainers, any comments for this patch? > > > I confirmed this patch solved the build error, > but I do not have access to any SH hardware. You can build and boot the kernel under qemu for several architectures (including sh4) by following the instructions on: https://github.com/landley/mkroot I believe I last built -rc6? You may need the attached patch to fix the serial port issue from: https://www.spinics.net/lists/linux-serial/msg26085.html Which is still there because the kernel guys don't care that they broke qemu, and the qemu guys are still using old kernel versions that work fine. My patch just reverts the kernel change (which enabled hardware buffer logic qemu doesn't implement). Rob [-- Attachment #2: qemu-sh4.patch --] [-- Type: text/x-diff, Size: 479 bytes --] diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c index 71707e8..a798def 100644 --- a/drivers/tty/serial/sh-sci.c +++ b/drivers/tty/serial/sh-sci.c @@ -2193,7 +2193,7 @@ static void sci_reset(struct uart_port *port) setup_timer(&s->rx_fifo_timer, rx_fifo_timer_fn, (unsigned long)s); } else { - if (port->type == PORT_SCIFA || + if (1 || port->type == PORT_SCIFA || port->type == PORT_SCIFB) scif_set_rtrg(port, 1); else
WARNING: multiple messages have this Message-ID (diff)
From: Rob Landley <rob@landley.net> To: Masahiro Yamada <yamada.masahiro@socionext.com>, Yoshinori Sato <ysato@users.sourceforge.jp>, linux-sh@vger.kernel.org, Rich Felker <dalias@libc.org> Cc: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>, Michal Marek <mmarek@suse.com>, Linus Torvalds <torvalds@linux-foundation.org>, Stephen Rothwell <sfr@canb.auug.org.au>, Nicholas Piggin <npiggin@gmail.com>, linux-arch <linux-arch@vger.kernel.org> Subject: Re: [PATCH 3/5] sh: thin archives fix linking Date: Wed, 21 Jun 2017 17:09:06 -0500 [thread overview] Message-ID: <7a1286aa-b656-7b71-2628-9093156143ff@landley.net> (raw) In-Reply-To: <CAK7LNARFQ0bLEYOgEKd+0oULevSxRqwFu_VSLn89gn_XBo+-uQ@mail.gmail.com> [-- Attachment #1: Type: text/plain, Size: 1166 bytes --] On 06/19/2017 01:19 AM, Masahiro Yamada wrote: > 2017-06-09 14:24 GMT+09:00 Nicholas Piggin <npiggin@gmail.com>: >> The VDSO symbols can't be linked into built-in.o when building with >> thin archives, so change this to linking them into the final link. >> >> Cc: Yoshinori Sato <ysato@users.sourceforge.jp> >> Cc: Rich Felker <dalias@libc.org> >> Cc: linux-sh@vger.kernel.org >> Signed-off-by: Nicholas Piggin <npiggin@gmail.com> >> --- > > SH maintainers, any comments for this patch? > > > I confirmed this patch solved the build error, > but I do not have access to any SH hardware. You can build and boot the kernel under qemu for several architectures (including sh4) by following the instructions on: https://github.com/landley/mkroot I believe I last built -rc6? You may need the attached patch to fix the serial port issue from: https://www.spinics.net/lists/linux-serial/msg26085.html Which is still there because the kernel guys don't care that they broke qemu, and the qemu guys are still using old kernel versions that work fine. My patch just reverts the kernel change (which enabled hardware buffer logic qemu doesn't implement). Rob [-- Attachment #2: qemu-sh4.patch --] [-- Type: text/x-diff, Size: 479 bytes --] diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c index 71707e8..a798def 100644 --- a/drivers/tty/serial/sh-sci.c +++ b/drivers/tty/serial/sh-sci.c @@ -2193,7 +2193,7 @@ static void sci_reset(struct uart_port *port) setup_timer(&s->rx_fifo_timer, rx_fifo_timer_fn, (unsigned long)s); } else { - if (port->type == PORT_SCIFA || + if (1 || port->type == PORT_SCIFA || port->type == PORT_SCIFB) scif_set_rtrg(port, 1); else
next prev parent reply other threads:[~2017-06-21 22:09 UTC|newest] Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-06-09 5:24 [PATCH 0/5] move everyone over to thin archives Nicholas Piggin 2017-06-09 5:24 ` [PATCH 1/5] kbuild: thin archives final link close --whole-archives option Nicholas Piggin 2017-06-19 6:16 ` Masahiro Yamada 2017-06-19 6:51 ` Nicholas Piggin 2017-06-19 8:14 ` Masahiro Yamada 2017-06-19 8:27 ` Nicholas Piggin 2017-06-19 8:35 ` Masahiro Yamada 2017-06-19 15:52 ` Nicholas Piggin 2017-06-19 23:48 ` Josh Triplett 2017-06-21 1:17 ` Masahiro Yamada 2017-06-21 2:47 ` Nicholas Piggin 2017-06-21 3:29 ` Masahiro Yamada 2017-06-21 4:04 ` Nicholas Piggin 2017-06-21 7:15 ` Arnd Bergmann 2017-06-21 9:16 ` Nicholas Piggin 2017-06-21 10:21 ` Arnd Bergmann 2017-06-21 10:38 ` Nicholas Piggin 2017-06-21 10:49 ` Arnd Bergmann 2017-06-21 10:51 ` Arnd Bergmann 2017-06-21 11:10 ` Nicholas Piggin 2017-06-21 11:32 ` Arnd Bergmann 2017-06-21 12:02 ` Nicholas Piggin 2017-06-21 12:21 ` Arnd Bergmann 2017-06-21 16:19 ` Stephen Boyd 2017-06-21 18:08 ` Nicholas Piggin 2017-06-21 20:55 ` Arnd Bergmann 2017-06-22 6:18 ` Maxime Ripard 2017-06-22 15:50 ` Nicholas Piggin 2017-06-23 5:31 ` Masahiro Yamada 2017-06-23 14:57 ` Maxime Ripard 2017-06-23 15:04 ` Arnd Bergmann 2017-06-25 3:55 ` Masahiro Yamada 2017-06-27 15:42 ` Maxime Ripard 2017-06-21 20:52 ` Arnd Bergmann 2017-06-21 21:30 ` Nicholas Piggin 2017-06-21 21:44 ` Arnd Bergmann 2017-06-22 16:12 ` Nicholas Piggin 2017-06-09 5:24 ` [PATCH 2/5] kbuild: thin archives use P option to ar Nicholas Piggin 2017-06-19 6:17 ` Masahiro Yamada 2017-06-19 6:52 ` Nicholas Piggin 2017-06-09 5:24 ` [PATCH 3/5] sh: thin archives fix linking Nicholas Piggin 2017-06-09 5:24 ` Nicholas Piggin 2017-06-19 6:19 ` Masahiro Yamada 2017-06-19 6:19 ` Masahiro Yamada 2017-06-21 22:09 ` Rob Landley [this message] 2017-06-21 22:09 ` Rob Landley 2017-06-09 5:24 ` [PATCH 4/5] x86/um: thin archives build fix Nicholas Piggin 2017-06-19 6:21 ` Masahiro Yamada 2017-06-09 5:24 ` [PATCH 5/5] kbuild: thin archives make default for all archs Nicholas Piggin 2017-06-19 6:22 ` Masahiro Yamada 2017-06-19 6:55 ` Nicholas Piggin 2017-06-17 13:10 ` [PATCH 0/5] move everyone over to thin archives Nicholas Piggin 2017-06-19 6:30 ` Masahiro Yamada
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7a1286aa-b656-7b71-2628-9093156143ff@landley.net \ --to=rob@landley.net \ --cc=dalias@libc.org \ --cc=linux-arch@vger.kernel.org \ --cc=linux-kbuild@vger.kernel.org \ --cc=linux-sh@vger.kernel.org \ --cc=mmarek@suse.com \ --cc=npiggin@gmail.com \ --cc=sfr@canb.auug.org.au \ --cc=torvalds@linux-foundation.org \ --cc=yamada.masahiro@socionext.com \ --cc=ysato@users.sourceforge.jp \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.