All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] kbuild: gcov: enable -fno-tree-loop-im if supported
@ 2018-04-26 21:28 Nick Desaulniers
  2018-04-26 21:41 ` Nick Desaulniers
  0 siblings, 1 reply; 3+ messages in thread
From: Nick Desaulniers @ 2018-04-26 21:28 UTC (permalink / raw)
  To: Masahiro Yamada
  Cc: Prasad Sodagudi, Nick Desaulniers, Michal Marek, linux-kbuild,
	linux-kernel

Clang does not recognize this compiler option.

Reported-by: Prasad Sodagudi <psodagud@quicinc.com>
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
---
 Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 83b6c541565a..7f653c924c18 100644
--- a/Makefile
+++ b/Makefile
@@ -623,7 +623,9 @@ all: vmlinux
 
 KBUILD_CFLAGS	+= $(call cc-option,-fno-PIE)
 KBUILD_AFLAGS	+= $(call cc-option,-fno-PIE)
-CFLAGS_GCOV	:= -fprofile-arcs -ftest-coverage -fno-tree-loop-im $(call cc-disable-warning,maybe-uninitialized,)
+CFLAGS_GCOV	:= -fprofile-arcs -ftest-coverage \
+	$(call cc-option,-fno-tree-loop-im) \
+	$(call cc-disable-warning,maybe-uninitialized,)
 export CFLAGS_GCOV CFLAGS_KCOV
 
 # The arch Makefile can set ARCH_{CPP,A,C}FLAGS to override the default
-- 
2.17.0.441.gb46fe60e1d-goog

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] kbuild: gcov: enable -fno-tree-loop-im if supported
  2018-04-26 21:28 [PATCH] kbuild: gcov: enable -fno-tree-loop-im if supported Nick Desaulniers
@ 2018-04-26 21:41 ` Nick Desaulniers
  2018-05-05 10:35   ` Masahiro Yamada
  0 siblings, 1 reply; 3+ messages in thread
From: Nick Desaulniers @ 2018-04-26 21:41 UTC (permalink / raw)
  To: Masahiro Yamada
  Cc: Prasad Sodagudi, Michal Marek, Linux Kbuild mailing list, LKML

Hi Masahiro and Michal,

The reporter has asked for their email address to be updated to:

psodagud@codeaurora.org

if you're ok with this version of the patch and choose to apply it, can you
please update the commit message. Otherwise, I'll make this change should
we need other changes necessitating a v2.
On Thu, Apr 26, 2018 at 2:29 PM Nick Desaulniers <ndesaulniers@google.com>
wrote:

> Clang does not recognize this compiler option.

> Reported-by: Prasad Sodagudi <psodagud@quicinc.com>
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
> ---
>   Makefile | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)

> diff --git a/Makefile b/Makefile
> index 83b6c541565a..7f653c924c18 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -623,7 +623,9 @@ all: vmlinux

>   KBUILD_CFLAGS  += $(call cc-option,-fno-PIE)
>   KBUILD_AFLAGS  += $(call cc-option,-fno-PIE)
> -CFLAGS_GCOV    := -fprofile-arcs -ftest-coverage -fno-tree-loop-im
$(call cc-disable-warning,maybe-uninitialized,)
> +CFLAGS_GCOV    := -fprofile-arcs -ftest-coverage \
> +       $(call cc-option,-fno-tree-loop-im) \
> +       $(call cc-disable-warning,maybe-uninitialized,)
>   export CFLAGS_GCOV CFLAGS_KCOV

>   # The arch Makefile can set ARCH_{CPP,A,C}FLAGS to override the default
> --
> 2.17.0.441.gb46fe60e1d-goog



--
Thanks,
~Nick Desaulniers

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] kbuild: gcov: enable -fno-tree-loop-im if supported
  2018-04-26 21:41 ` Nick Desaulniers
@ 2018-05-05 10:35   ` Masahiro Yamada
  0 siblings, 0 replies; 3+ messages in thread
From: Masahiro Yamada @ 2018-05-05 10:35 UTC (permalink / raw)
  To: Nick Desaulniers
  Cc: Prasad Sodagudi, Michal Marek, Linux Kbuild mailing list, LKML

2018-04-27 6:41 GMT+09:00 Nick Desaulniers <ndesaulniers@google.com>:
> Hi Masahiro and Michal,
>
> The reporter has asked for their email address to be updated to:
>
> psodagud@codeaurora.org
>
> if you're ok with this version of the patch and choose to apply it, can you
> please update the commit message. Otherwise, I'll make this change should
> we need other changes necessitating a v2.
> On Thu, Apr 26, 2018 at 2:29 PM Nick Desaulniers <ndesaulniers@google.com>
> wrote:
>
>> Clang does not recognize this compiler option.
>
>> Reported-by: Prasad Sodagudi <psodagud@quicinc.com>
>> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>

Applied to linux-kbuild
with the reporter's email address updated.

Thanks!




-- 
Best Regards
Masahiro Yamada

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-05-05 10:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-26 21:28 [PATCH] kbuild: gcov: enable -fno-tree-loop-im if supported Nick Desaulniers
2018-04-26 21:41 ` Nick Desaulniers
2018-05-05 10:35   ` Masahiro Yamada

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.