From: Masahiro Yamada <yamada.masahiro@socionext.com> To: Boris Brezillon <boris.brezillon@free-electrons.com> Cc: linux-mtd@lists.infradead.org, laurent.monat@idquantique.com, thorsten.christiansson@idquantique.com, Enrico Jorns <ejo@pengutronix.de>, Artem Bityutskiy <artem.bityutskiy@linux.intel.com>, Dinh Nguyen <dinguyen@kernel.org>, Marek Vasut <marek.vasut@gmail.com>, Graham Moore <grmoore@opensource.altera.com>, David Woodhouse <dwmw2@infradead.org>, Masami Hiramatsu <mhiramat@kernel.org>, Chuanxiao Dong <chuanxiao.dong@intel.com>, Jassi Brar <jaswinder.singh@linaro.org>, devicetree@vger.kernel.org, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Brian Norris <computersforpeace@gmail.com>, Richard Weinberger <richard@nod.at>, Cyrille Pitchen <cyrille.pitchen@atmel.com>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com> Subject: Re: [RESEND PATCH v2 00/53] mtd: nand: denali: 2nd round of Denali NAND IP patch bomb Date: Thu, 23 Mar 2017 10:54:08 +0900 [thread overview] Message-ID: <CAK7LNATT9uz+vqRx6Fndyxm=TeVVRseM1rsA+8tNw7un5bkB6A@mail.gmail.com> (raw) In-Reply-To: <20170322223550.1f1c97ae@bbrezillon> Hi Boris, 2017-03-23 6:35 GMT+09:00 Boris Brezillon <boris.brezillon@free-electrons.com>: > Hi Masahiro, > > On Thu, 23 Mar 2017 05:06:59 +0900 > Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > >> It took a couple months to update this series, but finally here is v2. >> (v1: https://lkml.org/lkml/2016/11/26/144 ) >> >> This driver includes many problems. >> >> One of the biggest one is a bunch of hard-coded parameters. This IP >> has many parameters that can be customized when a delivery RTL is >> generated. However, this driver was upstreamed by Intel, with >> Intel parameters hard-coded. Later, Altera added denali_dt.c to use >> this driver for embedded boards, but they did not fix the code in >> denali.c So, this driver has never worked. Even some DT bindings >> actually turned out wrong. >> >> There are more problems: [1] The driver just retrieves the OOB area as-is >> whereas the controller uses syndrome page layout. [2] Many NAND chip >> specific parameters are hard-coded in the driver. [3] ONFi devices are >> not working [4] It can not read Bad Block Marker >> >> This patch series intends to solve those problems. >> >> Since v1, here are more fixes/improvements: >> - Fix raw/oob callbacks for syndrome page layout >> - Implement setup_data_interface() callback >> - Fix/implement more commands for ONFi devices >> - Allow to skip the driver internal bounce buffer >> - Support PIO in case DMA is not supported >> - Switch from ->cmdfunc over to ->cmd_ctrl > > I'll probably pick a few patches for 4.12, so please wait a bit before > sending a v4. This will be helpful. I was refused by the SMTP server I use (probably due to too much volume at once). Please check the following as well. >> mtd: nand: do not check R/B# for CMD_READID in nand_command(_lp) >> mtd: nand: do not check R/B# for CMD_SET_FEATURES in nand_command(_lp) I noticed them when I switched from ->cmdfunc to ->cmd_ctrl hook. -- Best Regards Masahiro Yamada
WARNING: multiple messages have this Message-ID (diff)
From: Masahiro Yamada <yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org> To: Boris Brezillon <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> Cc: linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, laurent.monat-1zQW0WpQGTYgLlGVC3PcNw@public.gmane.org, thorsten.christiansson-1zQW0WpQGTYgLlGVC3PcNw@public.gmane.org, Enrico Jorns <ejo-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>, Artem Bityutskiy <artem.bityutskiy-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>, Dinh Nguyen <dinguyen-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Marek Vasut <marek.vasut-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Graham Moore <grmoore-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>, David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>, Masami Hiramatsu <mhiramat-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Chuanxiao Dong <chuanxiao.dong-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, Jassi Brar <jaswinder.singh-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linux Kernel Mailing List <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Brian Norris <computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Richard Weinberger <richard-/L3Ra7n9ekc@public.gmane.org>, Cyrille Pitchen <cyrille.pitchen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>, Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> Subject: Re: [RESEND PATCH v2 00/53] mtd: nand: denali: 2nd round of Denali NAND IP patch bomb Date: Thu, 23 Mar 2017 10:54:08 +0900 [thread overview] Message-ID: <CAK7LNATT9uz+vqRx6Fndyxm=TeVVRseM1rsA+8tNw7un5bkB6A@mail.gmail.com> (raw) In-Reply-To: <20170322223550.1f1c97ae@bbrezillon> Hi Boris, 2017-03-23 6:35 GMT+09:00 Boris Brezillon <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>: > Hi Masahiro, > > On Thu, 23 Mar 2017 05:06:59 +0900 > Masahiro Yamada <yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org> wrote: > >> It took a couple months to update this series, but finally here is v2. >> (v1: https://lkml.org/lkml/2016/11/26/144 ) >> >> This driver includes many problems. >> >> One of the biggest one is a bunch of hard-coded parameters. This IP >> has many parameters that can be customized when a delivery RTL is >> generated. However, this driver was upstreamed by Intel, with >> Intel parameters hard-coded. Later, Altera added denali_dt.c to use >> this driver for embedded boards, but they did not fix the code in >> denali.c So, this driver has never worked. Even some DT bindings >> actually turned out wrong. >> >> There are more problems: [1] The driver just retrieves the OOB area as-is >> whereas the controller uses syndrome page layout. [2] Many NAND chip >> specific parameters are hard-coded in the driver. [3] ONFi devices are >> not working [4] It can not read Bad Block Marker >> >> This patch series intends to solve those problems. >> >> Since v1, here are more fixes/improvements: >> - Fix raw/oob callbacks for syndrome page layout >> - Implement setup_data_interface() callback >> - Fix/implement more commands for ONFi devices >> - Allow to skip the driver internal bounce buffer >> - Support PIO in case DMA is not supported >> - Switch from ->cmdfunc over to ->cmd_ctrl > > I'll probably pick a few patches for 4.12, so please wait a bit before > sending a v4. This will be helpful. I was refused by the SMTP server I use (probably due to too much volume at once). Please check the following as well. >> mtd: nand: do not check R/B# for CMD_READID in nand_command(_lp) >> mtd: nand: do not check R/B# for CMD_SET_FEATURES in nand_command(_lp) I noticed them when I switched from ->cmdfunc to ->cmd_ctrl hook. -- Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-03-23 1:54 UTC|newest] Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-22 20:06 [RESEND PATCH v2 00/53] mtd: nand: denali: 2nd round of Denali NAND IP patch bomb Masahiro Yamada 2017-03-22 20:06 ` Masahiro Yamada 2017-03-22 20:07 ` [RESEND PATCH v2 01/53] mtd: nand: allow to set only one of ECC size and ECC strength from DT Masahiro Yamada 2017-03-22 20:07 ` [RESEND PATCH v2 02/53] mtd: nand: use read_oob() instead of cmdfunc() for bad block check Masahiro Yamada 2017-03-22 20:07 ` [RESEND PATCH v2 03/53] mtd: nand: denali: remove unused CONFIG option and macros Masahiro Yamada 2017-03-22 20:07 ` [RESEND PATCH v2 04/53] mtd: nand: denali: remove redundant define of BANK(x) Masahiro Yamada 2017-03-22 20:07 ` [RESEND PATCH v2 05/53] mtd: nand: denali: remove more unused struct members Masahiro Yamada 2017-03-22 20:07 ` [RESEND PATCH v2 06/53] mtd: nand: denali: fix comment of denali_nand_info::flash_mem Masahiro Yamada 2017-03-22 20:07 ` [RESEND PATCH v2 07/53] mtd: nand: denali: consolidate INTR_STATUS__* and INTR_EN__* macros Masahiro Yamada 2017-03-22 20:07 ` [RESEND PATCH v2 08/53] mtd: nand: denali: introduce capability flag Masahiro Yamada 2017-03-22 20:07 ` [RESEND PATCH v2 09/53] mtd: nand: denali: use int where no reason to use fixed width variable Masahiro Yamada 2017-03-22 20:07 ` [RESEND PATCH v2 10/53] mtd: nand: denali: fix erased page checking Masahiro Yamada 2017-03-22 20:07 ` [RESEND PATCH v2 11/53] mtd: nand: denali: fix bitflips calculation in handle_ecc() Masahiro Yamada 2017-03-22 20:07 ` [RESEND PATCH v2 12/53] mtd: nand: denali: support HW_ECC_FIXUP capability Masahiro Yamada 2017-03-22 20:07 ` [RESEND PATCH v2 13/53] mtd: nand: denali_dt: enable HW_ECC_FIXUP for Altera SOCFPGA variant Masahiro Yamada 2017-03-22 20:07 ` Masahiro Yamada 2017-03-29 2:00 ` Rob Herring 2017-03-29 2:00 ` Rob Herring 2017-03-22 20:07 ` [RESEND PATCH v2 14/53] mtd: nand: denali: support 64bit capable DMA engine Masahiro Yamada 2017-03-22 20:07 ` [RESEND PATCH v2 15/53] mtd: nand: denali_dt: remove dma-mask DT property Masahiro Yamada 2017-03-22 20:07 ` Masahiro Yamada 2017-03-22 20:07 ` [RESEND PATCH v2 16/53] mtd: nand: denali_dt: use pdev instead of ofdev for platform_device Masahiro Yamada 2017-03-22 20:07 ` [RESEND PATCH v2 17/53] mtd: nand: denali: allow to override revision number Masahiro Yamada 2017-03-22 20:07 ` [RESEND PATCH v2 18/53] mtd: nand: denali: use nand_chip to hold frequently accessed data Masahiro Yamada 2017-03-22 20:07 ` [RESEND PATCH v2 19/53] mtd: nand: denali: call nand_set_flash_node() to set DT node Masahiro Yamada 2017-03-22 20:07 ` [RESEND PATCH v2 20/53] mtd: nand: denali: do not set mtd->name Masahiro Yamada 2017-03-22 20:07 ` [RESEND PATCH v2 21/53] mtd: nand: denali: move multi device fixup code to a helper function Masahiro Yamada 2017-03-27 16:13 ` Boris Brezillon 2017-03-22 20:07 ` [RESEND PATCH v2 22/53] mtd: nand: denali: simplify multi device fixup code Masahiro Yamada 2017-03-22 20:07 ` [RESEND PATCH v2 23/53] mtd: nand: denali: set DEVICES_CONNECTED 1 if not set Masahiro Yamada 2017-03-22 20:07 ` [RESEND PATCH v2 24/53] mtd: nand: denali: remove meaningless writes to read-only registers Masahiro Yamada 2017-03-22 20:07 ` [RESEND PATCH v2 25/53] mtd: nand: denali: remove unnecessary writes to ECC_CORRECTION Masahiro Yamada 2017-03-22 20:07 ` [RESEND PATCH v2 26/53] mtd: nand: denali: support 1024 byte ECC step size Masahiro Yamada 2017-03-22 20:07 ` Masahiro Yamada 2017-03-22 21:32 ` Boris Brezillon 2017-03-22 21:32 ` Boris Brezillon 2017-03-23 6:53 ` Masahiro Yamada 2017-03-23 6:53 ` Masahiro Yamada 2017-03-23 8:39 ` Boris Brezillon 2017-03-23 8:39 ` Boris Brezillon 2017-03-24 3:23 ` Masahiro Yamada 2017-03-24 3:23 ` Masahiro Yamada 2017-03-24 8:02 ` Boris Brezillon 2017-03-24 8:02 ` Boris Brezillon 2017-03-22 21:35 ` [RESEND PATCH v2 00/53] mtd: nand: denali: 2nd round of Denali NAND IP patch bomb Boris Brezillon 2017-03-22 21:35 ` Boris Brezillon 2017-03-23 1:54 ` Masahiro Yamada [this message] 2017-03-23 1:54 ` Masahiro Yamada 2017-03-24 20:13 ` Boris Brezillon 2017-03-24 20:13 ` Boris Brezillon 2017-03-25 14:40 ` Masahiro Yamada 2017-03-25 14:40 ` Masahiro Yamada 2017-03-28 20:14 ` Boris Brezillon 2017-03-28 20:14 ` Boris Brezillon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAK7LNATT9uz+vqRx6Fndyxm=TeVVRseM1rsA+8tNw7un5bkB6A@mail.gmail.com' \ --to=yamada.masahiro@socionext.com \ --cc=artem.bityutskiy@linux.intel.com \ --cc=boris.brezillon@free-electrons.com \ --cc=chuanxiao.dong@intel.com \ --cc=computersforpeace@gmail.com \ --cc=cyrille.pitchen@atmel.com \ --cc=devicetree@vger.kernel.org \ --cc=dinguyen@kernel.org \ --cc=dwmw2@infradead.org \ --cc=ejo@pengutronix.de \ --cc=grmoore@opensource.altera.com \ --cc=jaswinder.singh@linaro.org \ --cc=laurent.monat@idquantique.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=marek.vasut@gmail.com \ --cc=mark.rutland@arm.com \ --cc=mhiramat@kernel.org \ --cc=richard@nod.at \ --cc=robh+dt@kernel.org \ --cc=thorsten.christiansson@idquantique.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.