[PATCH] kbuild: detect missing "WITH Linux-syscall-note" for uapi headers

[PATCH] kbuild: detect missing "WITH Linux-syscall-note" for uapi headers

[Masahiro Yamada]

UAPI headers licensed under GPL are supposed to have exception
"WITH Linux-syscall-note" so that they can be included into non-GPL
user space application code.

Unfortunately, people often miss to add it. Break 'make headers'
when any of exported headers lacks the exception note so that the
0-day bot can easily catch it.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

This patch depends on the following:

https://lore.kernel.org/patchwork/patch/1105289/

I will turn on the error after all headers are fixed.


 scripts/headers_install.sh | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/scripts/headers_install.sh b/scripts/headers_install.sh
index 47f6f3ea0771..bbaf29386995 100755
--- a/scripts/headers_install.sh
+++ b/scripts/headers_install.sh
@@ -23,6 +23,12 @@ TMPFILE=$OUTFILE.tmp
 
 trap 'rm -f $OUTFILE $TMPFILE' EXIT
 
+# SPDX-License-Identifier with GPL variants must have "WITH Linux-syscall-note"
+if [ -n "$(sed -n -e "/SPDX-License-Identifier:.*GPL-/{/WITH Linux-syscall-note/!p}" $INFILE)" ]; then
+	echo "error: $INFILE: missing \"WITH Linux-syscall-note\" for SPDX-License-Identifier" >&2
+	exit 1
+fi
+
 sed -E -e '
 	s/([[:space:](])(__user|__force|__iomem)[[:space:]]/\1/g
 	s/__attribute_const__([[:space:]]|$)/\1/g
-- 
2.17.1

Re: [PATCH] kbuild: detect missing "WITH Linux-syscall-note" for uapi headers

[Greg KH]

On Thu, Jul 25, 2019 at 05:05:13PM +0900, Masahiro Yamada wrote:
> UAPI headers licensed under GPL are supposed to have exception
> "WITH Linux-syscall-note" so that they can be included into non-GPL
> user space application code.
> 
> Unfortunately, people often miss to add it. Break 'make headers'
> when any of exported headers lacks the exception note so that the
> 0-day bot can easily catch it.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
> 
> This patch depends on the following:
> 
> https://lore.kernel.org/patchwork/patch/1105289/
> 
> I will turn on the error after all headers are fixed.

I've taken the dependancy here in the spdx tree and will send it to
Linus for 5.3-rc2.  I can also take this now through that tree, or you
can add it to yours afterward, which ever is easier for you.

thanks,

greg k-h

Re: [PATCH] kbuild: detect missing "WITH Linux-syscall-note" for uapi headers

[Masahiro Yamada]

On Thu, Jul 25, 2019 at 8:13 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Thu, Jul 25, 2019 at 05:05:13PM +0900, Masahiro Yamada wrote:
> > UAPI headers licensed under GPL are supposed to have exception
> > "WITH Linux-syscall-note" so that they can be included into non-GPL
> > user space application code.
> >
> > Unfortunately, people often miss to add it. Break 'make headers'
> > when any of exported headers lacks the exception note so that the
> > 0-day bot can easily catch it.
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > ---
> >
> > This patch depends on the following:
> >
> > https://lore.kernel.org/patchwork/patch/1105289/
> >
> > I will turn on the error after all headers are fixed.
>
> I've taken the dependancy here in the spdx tree and will send it to
> Linus for 5.3-rc2.

Thanks!

>  I can also take this now through that tree, or you
> can add it to yours afterward, which ever is easier for you.

I will create a branch on top 5.3-rc2
and queue this patch by myself.

Thank you.


-- 
Best Regards
Masahiro Yamada