* [PATCH] mmc: mmci_qcom_dml: include mmci_qcom_dml.h to fix sparse warnings
@ 2017-07-31 11:59 Masahiro Yamada
2017-08-03 10:51 ` Ulf Hansson
0 siblings, 1 reply; 3+ messages in thread
From: Masahiro Yamada @ 2017-07-31 11:59 UTC (permalink / raw)
To: linux-mmc; +Cc: Adrian Hunter, Masahiro Yamada, linux-kernel, Ulf Hansson
This fixes the following sparse warnings:
CHECK drivers/mmc/host/mmci_qcom_dml.c
drivers/mmc/host/mmci_qcom_dml.c:57:6: warning: symbol 'dml_start_xfer' was not declared. Should it be static?
drivers/mmc/host/mmci_qcom_dml.c:122:5: warning: symbol 'dml_hw_init' was not declared. Should it be static?
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/mmc/host/mmci_qcom_dml.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/host/mmci_qcom_dml.c b/drivers/mmc/host/mmci_qcom_dml.c
index 00750c9d3514..95de699853d2 100644
--- a/drivers/mmc/host/mmci_qcom_dml.c
+++ b/drivers/mmc/host/mmci_qcom_dml.c
@@ -18,6 +18,7 @@
#include <linux/mmc/host.h>
#include <linux/mmc/card.h>
#include "mmci.h"
+#include "mmci_qcom_dml.h"
/* Registers */
#define DML_CONFIG 0x00
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: mmci_qcom_dml: include mmci_qcom_dml.h to fix sparse warnings
2017-07-31 11:59 [PATCH] mmc: mmci_qcom_dml: include mmci_qcom_dml.h to fix sparse warnings Masahiro Yamada
@ 2017-08-03 10:51 ` Ulf Hansson
2017-08-04 13:04 ` Masahiro Yamada
0 siblings, 1 reply; 3+ messages in thread
From: Ulf Hansson @ 2017-08-03 10:51 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: linux-mmc, Adrian Hunter, linux-kernel
On 31 July 2017 at 13:59, Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> This fixes the following sparse warnings:
>
> CHECK drivers/mmc/host/mmci_qcom_dml.c
> drivers/mmc/host/mmci_qcom_dml.c:57:6: warning: symbol 'dml_start_xfer' was not declared. Should it be static?
> drivers/mmc/host/mmci_qcom_dml.c:122:5: warning: symbol 'dml_hw_init' was not declared. Should it be static?
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Thanks, applied for next!
Kind regards
Uffe
> ---
>
> drivers/mmc/host/mmci_qcom_dml.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/mmci_qcom_dml.c b/drivers/mmc/host/mmci_qcom_dml.c
> index 00750c9d3514..95de699853d2 100644
> --- a/drivers/mmc/host/mmci_qcom_dml.c
> +++ b/drivers/mmc/host/mmci_qcom_dml.c
> @@ -18,6 +18,7 @@
> #include <linux/mmc/host.h>
> #include <linux/mmc/card.h>
> #include "mmci.h"
> +#include "mmci_qcom_dml.h"
>
> /* Registers */
> #define DML_CONFIG 0x00
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: mmci_qcom_dml: include mmci_qcom_dml.h to fix sparse warnings
2017-08-03 10:51 ` Ulf Hansson
@ 2017-08-04 13:04 ` Masahiro Yamada
0 siblings, 0 replies; 3+ messages in thread
From: Masahiro Yamada @ 2017-08-04 13:04 UTC (permalink / raw)
To: Ulf Hansson; +Cc: linux-mmc, Adrian Hunter, linux-kernel
Hi Ulf,
2017-08-03 19:51 GMT+09:00 Ulf Hansson <ulf.hansson@linaro.org>:
> On 31 July 2017 at 13:59, Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
>> This fixes the following sparse warnings:
>>
>> CHECK drivers/mmc/host/mmci_qcom_dml.c
>> drivers/mmc/host/mmci_qcom_dml.c:57:6: warning: symbol 'dml_start_xfer' was not declared. Should it be static?
>> drivers/mmc/host/mmci_qcom_dml.c:122:5: warning: symbol 'dml_hw_init' was not declared. Should it be static?
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
> Thanks, applied for next!
>
> Kind regards
> Uffe
>
>> ---
>>
>> drivers/mmc/host/mmci_qcom_dml.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mmc/host/mmci_qcom_dml.c b/drivers/mmc/host/mmci_qcom_dml.c
>> index 00750c9d3514..95de699853d2 100644
>> --- a/drivers/mmc/host/mmci_qcom_dml.c
>> +++ b/drivers/mmc/host/mmci_qcom_dml.c
>> @@ -18,6 +18,7 @@
>> #include <linux/mmc/host.h>
>> #include <linux/mmc/card.h>
>> #include "mmci.h"
>> +#include "mmci_qcom_dml.h"
>>
>> /* Registers */
>> #define DML_CONFIG 0x00
Please drop this.
Kbuild test robot reported a build error
and it revealed another problem for this driver.
(#ifdef CONFIG_MMC_QCOM_DML must be #if IS_ENABLED(CONFIG_MMC_QCOM_DML)
because this driver is tristate)
I will send v2 soon.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-04 13:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-31 11:59 [PATCH] mmc: mmci_qcom_dml: include mmci_qcom_dml.h to fix sparse warnings Masahiro Yamada
2017-08-03 10:51 ` Ulf Hansson
2017-08-04 13:04 ` Masahiro Yamada
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.