* [PATCH v1 1/1] modpost: Mark uuid_le type to be suitable only for MEI
@ 2022-11-25 10:12 Andy Shevchenko
2022-11-26 23:11 ` Masahiro Yamada
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2022-11-25 10:12 UTC (permalink / raw)
To: linux-kbuild, linux-kernel
Cc: Masahiro Yamada, Nathan Chancellor, Nick Desaulniers,
Nicolas Schier, Andy Shevchenko
The uuid_le type is used only in MEI ABI, do not advertise it for others.
While at it, comment out that UUID types are not to be used in a new code.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
If you confused by acrn user of the uuid_le type, the patch to fix that
is pending for v6.2 as well 1dbb4f0235a4 ("virt: acrn: Mark the uuid
field as unused"). Nevertheless this patch doesn't break the things and
hence can go independently to the respective tree.
scripts/mod/file2alias.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/scripts/mod/file2alias.c b/scripts/mod/file2alias.c
index 7df23905fdf1..91c2e7ba5e52 100644
--- a/scripts/mod/file2alias.c
+++ b/scripts/mod/file2alias.c
@@ -34,19 +34,23 @@ typedef Elf64_Addr kernel_ulong_t;
typedef uint32_t __u32;
typedef uint16_t __u16;
typedef unsigned char __u8;
+
+/* UUID types for backward compatibility, don't use in new code */
typedef struct {
__u8 b[16];
} guid_t;
-/* backwards compatibility, don't use in new code */
-typedef struct {
- __u8 b[16];
-} uuid_le;
typedef struct {
__u8 b[16];
} uuid_t;
+
#define UUID_STRING_LEN 36
+/* MEI UUID type, don't use anywhere else */
+typedef struct {
+ __u8 b[16];
+} uuid_le;
+
/* Big exception to the "don't include kernel headers into userspace, which
* even potentially has different endianness and word sizes, since
* we handle those differences explicitly below */
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1 1/1] modpost: Mark uuid_le type to be suitable only for MEI
2022-11-25 10:12 [PATCH v1 1/1] modpost: Mark uuid_le type to be suitable only for MEI Andy Shevchenko
@ 2022-11-26 23:11 ` Masahiro Yamada
0 siblings, 0 replies; 2+ messages in thread
From: Masahiro Yamada @ 2022-11-26 23:11 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-kbuild, linux-kernel, Nathan Chancellor, Nick Desaulniers,
Nicolas Schier
On Fri, Nov 25, 2022 at 7:12 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> The uuid_le type is used only in MEI ABI, do not advertise it for others.
> While at it, comment out that UUID types are not to be used in a new code.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>
Applied to linux-kbuild.
Thanks.
> If you confused by acrn user of the uuid_le type, the patch to fix that
> is pending for v6.2 as well 1dbb4f0235a4 ("virt: acrn: Mark the uuid
> field as unused"). Nevertheless this patch doesn't break the things and
> hence can go independently to the respective tree.
>
> scripts/mod/file2alias.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/mod/file2alias.c b/scripts/mod/file2alias.c
> index 7df23905fdf1..91c2e7ba5e52 100644
> --- a/scripts/mod/file2alias.c
> +++ b/scripts/mod/file2alias.c
> @@ -34,19 +34,23 @@ typedef Elf64_Addr kernel_ulong_t;
> typedef uint32_t __u32;
> typedef uint16_t __u16;
> typedef unsigned char __u8;
> +
> +/* UUID types for backward compatibility, don't use in new code */
> typedef struct {
> __u8 b[16];
> } guid_t;
>
> -/* backwards compatibility, don't use in new code */
> -typedef struct {
> - __u8 b[16];
> -} uuid_le;
> typedef struct {
> __u8 b[16];
> } uuid_t;
> +
> #define UUID_STRING_LEN 36
>
> +/* MEI UUID type, don't use anywhere else */
> +typedef struct {
> + __u8 b[16];
> +} uuid_le;
> +
> /* Big exception to the "don't include kernel headers into userspace, which
> * even potentially has different endianness and word sizes, since
> * we handle those differences explicitly below */
> --
> 2.35.1
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-26 23:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-25 10:12 [PATCH v1 1/1] modpost: Mark uuid_le type to be suitable only for MEI Andy Shevchenko
2022-11-26 23:11 ` Masahiro Yamada
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.