All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masahiro Yamada <masahiroy@kernel.org>
To: Nick Terrell <terrelln@fb.com>
Cc: Ben Hutchings <ben@decadent.org.uk>,
	"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
	Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Subject: Re: vmlinux link failure on ia64 with zstd
Date: Tue, 15 Sep 2020 15:48:35 +0900	[thread overview]
Message-ID: <CAK7LNAToB3n9Y9OPXR55VKbDAkYgm1kUDO8gUu0Ak_+=6AhzCw@mail.gmail.com> (raw)
In-Reply-To: <6A76267A-6B60-4428-94DF-E05706EB85FB@fb.com>

On Tue, Sep 15, 2020 at 4:12 AM Nick Terrell <terrelln@fb.com> wrote:
>
>
>
> > On Sep 13, 2020, at 12:51 PM, Ben Hutchings <ben@decadent.org.uk> wrote:
> >
> > Enabling CONFIG_RD_ZSTD (which is enabled by default) resulted in a
> > link failure on ia64:
> >
> > + ld -r -o vmlinux.o --whole-archive arch/ia64/kernel/head.o init/built-in.a usr/built-in.a arch/ia64/kernel/built-in.a arch/ia64/mm/built-in.a kernel/built-in.a certs/built-in.a mm/built-in.a fs/built-in.a ipc/built-in.a security/built-in.a crypto/built-in.a block/built-in.a lib/built-in.a arch/ia64/lib/built-in.a lib/lib.a arch/ia64/lib/lib.a drivers/built-in.a sound/built-in.a net/built-in.a virt/built-in.a arch/ia64/pci/built-in.a arch/ia64/hp/common/built-in.a --no-whole-archive --start-group --end-group
> > ld: lib/zstd/entropy_common.o: linking constant-gp files with non-constant-gp files
> > ld: failed to merge target specific data of file lib/zstd/entropy_common.o
> > ld: lib/zstd/fse_decompress.o: linking constant-gp files with non-constant-gp files
> > ld: failed to merge target specific data of file lib/zstd/fse_decompress.o
> > ld: lib/zstd/zstd_common.o: linking constant-gp files with non-constant-gp files
> > ld: failed to merge target specific data of file lib/zstd/zstd_common.o
>
> I’ve never seen anything like this error before. I did some searching, and found that it may show up if an object file is empty.
>
> These three files are all included in both the zstd_compress and the zstd_decompress modules. We used to exclude these 3 files from the zstd_decompress module when both modules are built-in. But then commit dc35da16a2e2 [0] removed that, because Kbuild is supposed to handle that case.
>
> If you revert commit dc35da16a2e2 [0] does that fix the issue? I’m attempting to build with IA64, and I’ll let you know if I am able to reproduce the issue and test if this fixes it.
>
> CC: Masahiro Yamada <yamada.masahiro@socionext.com> author of the commit and the linux-kbuild mailing list.
>
> [0] https://github.com/torvalds/linux/commit/dc35da16a2e23db04822f0129cd5b28b7b0e72b4


dc35da16a2e2 is more than two years old (i.e. v4.17)

Are we discussing a long-standing issue
or something that arose recently?




> Best,
> Nick
>
> > This is seen on Debian unstable, with gcc 10.2 and binutils 2.35.  A
> > full build log is available at:
> > https://buildd.debian.org/status/fetch.php?pkg=linux&arch=ia64&ver=5.9~rc4-1~exp1&stamp=1599955166&raw=1
> >
> > Ben.
> >
> > --
> > Ben Hutchings
> > Humour is the best antidote to reality.
> >
>


-- 
Best Regards
Masahiro Yamada

WARNING: multiple messages have this Message-ID (diff)
From: Masahiro Yamada <masahiroy@kernel.org>
To: Nick Terrell <terrelln@fb.com>
Cc: Ben Hutchings <ben@decadent.org.uk>,
	"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
	Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Subject: Re: vmlinux link failure on ia64 with zstd
Date: Tue, 15 Sep 2020 06:48:35 +0000	[thread overview]
Message-ID: <CAK7LNAToB3n9Y9OPXR55VKbDAkYgm1kUDO8gUu0Ak_+=6AhzCw@mail.gmail.com> (raw)
In-Reply-To: <6A76267A-6B60-4428-94DF-E05706EB85FB@fb.com>

On Tue, Sep 15, 2020 at 4:12 AM Nick Terrell <terrelln@fb.com> wrote:
>
>
>
> > On Sep 13, 2020, at 12:51 PM, Ben Hutchings <ben@decadent.org.uk> wrote:
> >
> > Enabling CONFIG_RD_ZSTD (which is enabled by default) resulted in a
> > link failure on ia64:
> >
> > + ld -r -o vmlinux.o --whole-archive arch/ia64/kernel/head.o init/built-in.a usr/built-in.a arch/ia64/kernel/built-in.a arch/ia64/mm/built-in.a kernel/built-in.a certs/built-in.a mm/built-in.a fs/built-in.a ipc/built-in.a security/built-in.a crypto/built-in.a block/built-in.a lib/built-in.a arch/ia64/lib/built-in.a lib/lib.a arch/ia64/lib/lib.a drivers/built-in.a sound/built-in.a net/built-in.a virt/built-in.a arch/ia64/pci/built-in.a arch/ia64/hp/common/built-in.a --no-whole-archive --start-group --end-group
> > ld: lib/zstd/entropy_common.o: linking constant-gp files with non-constant-gp files
> > ld: failed to merge target specific data of file lib/zstd/entropy_common.o
> > ld: lib/zstd/fse_decompress.o: linking constant-gp files with non-constant-gp files
> > ld: failed to merge target specific data of file lib/zstd/fse_decompress.o
> > ld: lib/zstd/zstd_common.o: linking constant-gp files with non-constant-gp files
> > ld: failed to merge target specific data of file lib/zstd/zstd_common.o
>
> I’ve never seen anything like this error before. I did some searching, and found that it may show up if an object file is empty.
>
> These three files are all included in both the zstd_compress and the zstd_decompress modules. We used to exclude these 3 files from the zstd_decompress module when both modules are built-in. But then commit dc35da16a2e2 [0] removed that, because Kbuild is supposed to handle that case.
>
> If you revert commit dc35da16a2e2 [0] does that fix the issue? I’m attempting to build with IA64, and I’ll let you know if I am able to reproduce the issue and test if this fixes it.
>
> CC: Masahiro Yamada <yamada.masahiro@socionext.com> author of the commit and the linux-kbuild mailing list.
>
> [0] https://github.com/torvalds/linux/commit/dc35da16a2e23db04822f0129cd5b28b7b0e72b4


dc35da16a2e2 is more than two years old (i.e. v4.17)

Are we discussing a long-standing issue
or something that arose recently?




> Best,
> Nick
>
> > This is seen on Debian unstable, with gcc 10.2 and binutils 2.35.  A
> > full build log is available at:
> > https://buildd.debian.org/status/fetch.php?pkg=linux&arch=ia64&ver=5.9~rc4-1~exp1&stamp=1599955166&raw=1
> >
> > Ben.
> >
> > --
> > Ben Hutchings
> > Humour is the best antidote to reality.
> >
>


-- 
Best Regards
Masahiro Yamada

  reply	other threads:[~2020-09-15  6:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-13 19:51 vmlinux link failure on ia64 with zstd Ben Hutchings
2020-09-14 19:12 ` Nick Terrell
2020-09-14 19:12   ` Nick Terrell
2020-09-15  6:48   ` Masahiro Yamada [this message]
2020-09-15  6:48     ` Masahiro Yamada
2020-09-15  6:52     ` Nick Terrell
2020-09-15  6:52       ` Nick Terrell
2020-11-30 12:27     ` John Paul Adrian Glaubitz
2020-11-30 12:27       ` John Paul Adrian Glaubitz
2021-03-23 16:28 ` John Paul Adrian Glaubitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK7LNAToB3n9Y9OPXR55VKbDAkYgm1kUDO8gUu0Ak_+=6AhzCw@mail.gmail.com' \
    --to=masahiroy@kernel.org \
    --cc=ben@decadent.org.uk \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=terrelln@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.