All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masahiro Yamada <masahiroy@kernel.org>
To: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kbuild: run the checker after the compiler
Date: Tue, 23 Jun 2020 14:58:13 +0900	[thread overview]
Message-ID: <CAK7LNATu_vCFr1n7KRpxv0Q3RQ6hGRrNzTyD437GiSm57tRUWQ@mail.gmail.com> (raw)
In-Reply-To: <20200622154512.82758-1-luc.vanoostenryck@gmail.com>

On Tue, Jun 23, 2020 at 12:47 AM Luc Van Oostenryck
<luc.vanoostenryck@gmail.com> wrote:
>
> Since the pre-git time the checker is run first, before the compiler.
> But if the source file contains some syntax error, the warnings from
> the compiler are more useful than those from sparse (and other
> checker most probably too).
>
> So move the 'check' command to run after the compiler.
>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>

Applied to linux-kbuild.
Thanks.

> ---
>  scripts/Makefile.build | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/Makefile.build b/scripts/Makefile.build
> index 2e8810b7e5ed..7ba6a752d5bd 100644
> --- a/scripts/Makefile.build
> +++ b/scripts/Makefile.build
> @@ -252,9 +252,9 @@ cmd_gen_ksymdeps = \
>  endif
>
>  define rule_cc_o_c
> -       $(call cmd,checksrc)
>         $(call cmd_and_fixdep,cc_o_c)
>         $(call cmd,gen_ksymdeps)
> +       $(call cmd,checksrc)
>         $(call cmd,checkdoc)
>         $(call cmd,objtool)
>         $(call cmd,modversions_c)
> @@ -277,8 +277,8 @@ endif
>
>  # Built-in and composite module parts
>  $(obj)/%.o: $(src)/%.c $(recordmcount_source) $(objtool_dep) FORCE
> -       $(call cmd,force_checksrc)
>         $(call if_changed_rule,cc_o_c)
> +       $(call cmd,force_checksrc)
>
>  cmd_mod = { \
>         echo $(if $($*-objs)$($*-y)$($*-m), $(addprefix $(obj)/, $($*-objs) $($*-y) $($*-m)), $(@:.mod=.o)); \
>
> base-commit: 48778464bb7d346b47157d21ffde2af6b2d39110
> --
> 2.27.0
>


-- 
Best Regards
Masahiro Yamada

      reply	other threads:[~2020-06-23  5:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-22 15:45 [PATCH] kbuild: run the checker after the compiler Luc Van Oostenryck
2020-06-23  5:58 ` Masahiro Yamada [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK7LNATu_vCFr1n7KRpxv0Q3RQ6hGRrNzTyD437GiSm57tRUWQ@mail.gmail.com \
    --to=masahiroy@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luc.vanoostenryck@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.