* [PATCH] kbuild: run the checker after the compiler
@ 2020-06-22 15:45 Luc Van Oostenryck
2020-06-23 5:58 ` Masahiro Yamada
0 siblings, 1 reply; 2+ messages in thread
From: Luc Van Oostenryck @ 2020-06-22 15:45 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: linux-kernel, Luc Van Oostenryck
Since the pre-git time the checker is run first, before the compiler.
But if the source file contains some syntax error, the warnings from
the compiler are more useful than those from sparse (and other
checker most probably too).
So move the 'check' command to run after the compiler.
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
scripts/Makefile.build | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/Makefile.build b/scripts/Makefile.build
index 2e8810b7e5ed..7ba6a752d5bd 100644
--- a/scripts/Makefile.build
+++ b/scripts/Makefile.build
@@ -252,9 +252,9 @@ cmd_gen_ksymdeps = \
endif
define rule_cc_o_c
- $(call cmd,checksrc)
$(call cmd_and_fixdep,cc_o_c)
$(call cmd,gen_ksymdeps)
+ $(call cmd,checksrc)
$(call cmd,checkdoc)
$(call cmd,objtool)
$(call cmd,modversions_c)
@@ -277,8 +277,8 @@ endif
# Built-in and composite module parts
$(obj)/%.o: $(src)/%.c $(recordmcount_source) $(objtool_dep) FORCE
- $(call cmd,force_checksrc)
$(call if_changed_rule,cc_o_c)
+ $(call cmd,force_checksrc)
cmd_mod = { \
echo $(if $($*-objs)$($*-y)$($*-m), $(addprefix $(obj)/, $($*-objs) $($*-y) $($*-m)), $(@:.mod=.o)); \
base-commit: 48778464bb7d346b47157d21ffde2af6b2d39110
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kbuild: run the checker after the compiler
2020-06-22 15:45 [PATCH] kbuild: run the checker after the compiler Luc Van Oostenryck
@ 2020-06-23 5:58 ` Masahiro Yamada
0 siblings, 0 replies; 2+ messages in thread
From: Masahiro Yamada @ 2020-06-23 5:58 UTC (permalink / raw)
To: Luc Van Oostenryck; +Cc: Linux Kernel Mailing List
On Tue, Jun 23, 2020 at 12:47 AM Luc Van Oostenryck
<luc.vanoostenryck@gmail.com> wrote:
>
> Since the pre-git time the checker is run first, before the compiler.
> But if the source file contains some syntax error, the warnings from
> the compiler are more useful than those from sparse (and other
> checker most probably too).
>
> So move the 'check' command to run after the compiler.
>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Applied to linux-kbuild.
Thanks.
> ---
> scripts/Makefile.build | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/Makefile.build b/scripts/Makefile.build
> index 2e8810b7e5ed..7ba6a752d5bd 100644
> --- a/scripts/Makefile.build
> +++ b/scripts/Makefile.build
> @@ -252,9 +252,9 @@ cmd_gen_ksymdeps = \
> endif
>
> define rule_cc_o_c
> - $(call cmd,checksrc)
> $(call cmd_and_fixdep,cc_o_c)
> $(call cmd,gen_ksymdeps)
> + $(call cmd,checksrc)
> $(call cmd,checkdoc)
> $(call cmd,objtool)
> $(call cmd,modversions_c)
> @@ -277,8 +277,8 @@ endif
>
> # Built-in and composite module parts
> $(obj)/%.o: $(src)/%.c $(recordmcount_source) $(objtool_dep) FORCE
> - $(call cmd,force_checksrc)
> $(call if_changed_rule,cc_o_c)
> + $(call cmd,force_checksrc)
>
> cmd_mod = { \
> echo $(if $($*-objs)$($*-y)$($*-m), $(addprefix $(obj)/, $($*-objs) $($*-y) $($*-m)), $(@:.mod=.o)); \
>
> base-commit: 48778464bb7d346b47157d21ffde2af6b2d39110
> --
> 2.27.0
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-23 5:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-22 15:45 [PATCH] kbuild: run the checker after the compiler Luc Van Oostenryck
2020-06-23 5:58 ` Masahiro Yamada
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.