* Re: [Intel-gfx] [PATCH v1] drm/i915: fix null pointer dereference
2022-02-01 15:33 [Intel-gfx] [PATCH v1] drm/i915: fix null pointer dereference Lukasz Bartosik
@ 2022-02-01 15:49 ` Jani Nikula
2022-02-08 16:20 ` Łukasz Bartosik
2022-02-02 14:27 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (8 subsequent siblings)
9 siblings, 1 reply; 25+ messages in thread
From: Jani Nikula @ 2022-02-01 15:49 UTC (permalink / raw)
To: Lukasz Bartosik, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin
Cc: upstream, intel-gfx
Thanks for the patch, adding some Cc's from the commit that regressed.
BR,
Jani.
On Tue, 01 Feb 2022, Lukasz Bartosik <lb@semihalf.com> wrote:
> From: Łukasz Bartosik <lb@semihalf.com>
>
> Asus chromebook CX550 crashes during boot on v5.17-rc1 kernel.
> The root cause is null pointer defeference of bi_next
> in tgl_get_bw_info() in drivers/gpu/drm/i915/display/intel_bw.c.
>
> BUG: kernel NULL pointer dereference, address: 000000000000002e
> PGD 0 P4D 0
> Oops: 0002 [#1] PREEMPT SMP NOPTI
> CPU: 0 PID: 1 Comm: swapper/0 Tainted: G U 5.17.0-rc1
> Hardware name: Google Delbin/Delbin, BIOS Google_Delbin.13672.156.3 05/14/2021
> RIP: 0010:tgl_get_bw_info+0x2de/0x510
> ...
> [ 2.554467] Call Trace:
> [ 2.554467] <TASK>
> [ 2.554467] intel_bw_init_hw+0x14a/0x434
> [ 2.554467] ? _printk+0x59/0x73
> [ 2.554467] ? _dev_err+0x77/0x91
> [ 2.554467] i915_driver_hw_probe+0x329/0x33e
> [ 2.554467] i915_driver_probe+0x4c8/0x638
> [ 2.554467] i915_pci_probe+0xf8/0x14e
> [ 2.554467] ? _raw_spin_unlock_irqrestore+0x12/0x2c
> [ 2.554467] pci_device_probe+0xaa/0x142
> [ 2.554467] really_probe+0x13f/0x2f4
> [ 2.554467] __driver_probe_device+0x9e/0xd3
> [ 2.554467] driver_probe_device+0x24/0x7c
> [ 2.554467] __driver_attach+0xba/0xcf
> [ 2.554467] ? driver_attach+0x1f/0x1f
> [ 2.554467] bus_for_each_dev+0x8c/0xc0
> [ 2.554467] bus_add_driver+0x11b/0x1f7
> [ 2.554467] driver_register+0x60/0xea
> [ 2.554467] ? mipi_dsi_bus_init+0x16/0x16
> [ 2.554467] i915_init+0x2c/0xb9
> [ 2.554467] ? mipi_dsi_bus_init+0x16/0x16
> [ 2.554467] do_one_initcall+0x12e/0x2b3
> [ 2.554467] do_initcall_level+0xd6/0xf3
> [ 2.554467] do_initcalls+0x4e/0x79
> [ 2.554467] kernel_init_freeable+0xed/0x14d
> [ 2.554467] ? rest_init+0xc1/0xc1
> [ 2.554467] kernel_init+0x1a/0x120
> [ 2.554467] ret_from_fork+0x1f/0x30
> [ 2.554467] </TASK>
> ...
> Kernel panic - not syncing: Fatal exception
>
> Fixes: c64a9a7c05be ("drm/i915: Update memory bandwidth formulae")
> Signed-off-by: Łukasz Bartosik <lb@semihalf.com>
> ---
> drivers/gpu/drm/i915/display/intel_bw.c | 16 +++++++++-------
> 1 file changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
> index 2da4aacc956b..bd0ed68b7faa 100644
> --- a/drivers/gpu/drm/i915/display/intel_bw.c
> +++ b/drivers/gpu/drm/i915/display/intel_bw.c
> @@ -404,15 +404,17 @@ static int tgl_get_bw_info(struct drm_i915_private *dev_priv, const struct intel
> int clpchgroup;
> int j;
>
> - if (i < num_groups - 1)
> - bi_next = &dev_priv->max_bw[i + 1];
> -
> clpchgroup = (sa->deburst * qi.deinterleave / num_channels) << i;
>
> - if (i < num_groups - 1 && clpchgroup < clperchgroup)
> - bi_next->num_planes = (ipqdepth - clpchgroup) / clpchgroup + 1;
> - else
> - bi_next->num_planes = 0;
> + if (i < num_groups - 1) {
> + bi_next = &dev_priv->max_bw[i + 1];
> +
> + if (clpchgroup < clperchgroup)
> + bi_next->num_planes = (ipqdepth - clpchgroup) /
> + clpchgroup + 1;
> + else
> + bi_next->num_planes = 0;
> + }
>
> bi->num_qgv_points = qi.num_points;
> bi->num_psf_gv_points = qi.num_psf_points;
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [Intel-gfx] [PATCH v1] drm/i915: fix null pointer dereference
2022-02-01 15:49 ` Jani Nikula
@ 2022-02-08 16:20 ` Łukasz Bartosik
2022-02-09 2:02 ` Sripada, Radhakrishna
0 siblings, 1 reply; 25+ messages in thread
From: Łukasz Bartosik @ 2022-02-08 16:20 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin
Cc: upstream, intel-gfx
Have you had a chance to review the patch ? The crash is still there
on v5.17-rc3.
Thanks,
Lukasz
wt., 1 lut 2022 o 16:49 Jani Nikula <jani.nikula@linux.intel.com> napisał(a):
>
>
> Thanks for the patch, adding some Cc's from the commit that regressed.
>
> BR,
> Jani.
>
> On Tue, 01 Feb 2022, Lukasz Bartosik <lb@semihalf.com> wrote:
> > From: Łukasz Bartosik <lb@semihalf.com>
> >
> > Asus chromebook CX550 crashes during boot on v5.17-rc1 kernel.
> > The root cause is null pointer defeference of bi_next
> > in tgl_get_bw_info() in drivers/gpu/drm/i915/display/intel_bw.c.
> >
> > BUG: kernel NULL pointer dereference, address: 000000000000002e
> > PGD 0 P4D 0
> > Oops: 0002 [#1] PREEMPT SMP NOPTI
> > CPU: 0 PID: 1 Comm: swapper/0 Tainted: G U 5.17.0-rc1
> > Hardware name: Google Delbin/Delbin, BIOS Google_Delbin.13672.156.3 05/14/2021
> > RIP: 0010:tgl_get_bw_info+0x2de/0x510
> > ...
> > [ 2.554467] Call Trace:
> > [ 2.554467] <TASK>
> > [ 2.554467] intel_bw_init_hw+0x14a/0x434
> > [ 2.554467] ? _printk+0x59/0x73
> > [ 2.554467] ? _dev_err+0x77/0x91
> > [ 2.554467] i915_driver_hw_probe+0x329/0x33e
> > [ 2.554467] i915_driver_probe+0x4c8/0x638
> > [ 2.554467] i915_pci_probe+0xf8/0x14e
> > [ 2.554467] ? _raw_spin_unlock_irqrestore+0x12/0x2c
> > [ 2.554467] pci_device_probe+0xaa/0x142
> > [ 2.554467] really_probe+0x13f/0x2f4
> > [ 2.554467] __driver_probe_device+0x9e/0xd3
> > [ 2.554467] driver_probe_device+0x24/0x7c
> > [ 2.554467] __driver_attach+0xba/0xcf
> > [ 2.554467] ? driver_attach+0x1f/0x1f
> > [ 2.554467] bus_for_each_dev+0x8c/0xc0
> > [ 2.554467] bus_add_driver+0x11b/0x1f7
> > [ 2.554467] driver_register+0x60/0xea
> > [ 2.554467] ? mipi_dsi_bus_init+0x16/0x16
> > [ 2.554467] i915_init+0x2c/0xb9
> > [ 2.554467] ? mipi_dsi_bus_init+0x16/0x16
> > [ 2.554467] do_one_initcall+0x12e/0x2b3
> > [ 2.554467] do_initcall_level+0xd6/0xf3
> > [ 2.554467] do_initcalls+0x4e/0x79
> > [ 2.554467] kernel_init_freeable+0xed/0x14d
> > [ 2.554467] ? rest_init+0xc1/0xc1
> > [ 2.554467] kernel_init+0x1a/0x120
> > [ 2.554467] ret_from_fork+0x1f/0x30
> > [ 2.554467] </TASK>
> > ...
> > Kernel panic - not syncing: Fatal exception
> >
> > Fixes: c64a9a7c05be ("drm/i915: Update memory bandwidth formulae")
> > Signed-off-by: Łukasz Bartosik <lb@semihalf.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_bw.c | 16 +++++++++-------
> > 1 file changed, 9 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
> > index 2da4aacc956b..bd0ed68b7faa 100644
> > --- a/drivers/gpu/drm/i915/display/intel_bw.c
> > +++ b/drivers/gpu/drm/i915/display/intel_bw.c
> > @@ -404,15 +404,17 @@ static int tgl_get_bw_info(struct drm_i915_private *dev_priv, const struct intel
> > int clpchgroup;
> > int j;
> >
> > - if (i < num_groups - 1)
> > - bi_next = &dev_priv->max_bw[i + 1];
> > -
> > clpchgroup = (sa->deburst * qi.deinterleave / num_channels) << i;
> >
> > - if (i < num_groups - 1 && clpchgroup < clperchgroup)
> > - bi_next->num_planes = (ipqdepth - clpchgroup) / clpchgroup + 1;
> > - else
> > - bi_next->num_planes = 0;
> > + if (i < num_groups - 1) {
> > + bi_next = &dev_priv->max_bw[i + 1];
> > +
> > + if (clpchgroup < clperchgroup)
> > + bi_next->num_planes = (ipqdepth - clpchgroup) /
> > + clpchgroup + 1;
> > + else
> > + bi_next->num_planes = 0;
> > + }
> >
> > bi->num_qgv_points = qi.num_points;
> > bi->num_psf_gv_points = qi.num_psf_points;
>
> --
> Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [Intel-gfx] [PATCH v1] drm/i915: fix null pointer dereference
2022-02-08 16:20 ` Łukasz Bartosik
@ 2022-02-09 2:02 ` Sripada, Radhakrishna
2022-02-09 10:31 ` Ville Syrjälä
0 siblings, 1 reply; 25+ messages in thread
From: Sripada, Radhakrishna @ 2022-02-09 2:02 UTC (permalink / raw)
To: Łukasz Bartosik, Jani Nikula, Joonas Lahtinen, Vivi,
Rodrigo, Tvrtko Ursulin
Cc: intel-gfx, upstream
> -----Original Message-----
> From: Łukasz Bartosik <lb@semihalf.com>
> Sent: Tuesday, February 8, 2022 8:20 AM
> To: Jani Nikula <jani.nikula@linux.intel.com>; Joonas Lahtinen
> <joonas.lahtinen@linux.intel.com>; Vivi, Rodrigo <rodrigo.vivi@intel.com>;
> Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Cc: Sripada, Radhakrishna <radhakrishna.sripada@intel.com>; intel-
> gfx@lists.freedesktop.org; upstream@semihalf.com; Ville Syrjälä
> <ville.syrjala@linux.intel.com>; Roper, Matthew D
> <matthew.d.roper@intel.com>; Srivatsa, Anusha <anusha.srivatsa@intel.com>
> Subject: Re: [PATCH v1] drm/i915: fix null pointer dereference
>
> Have you had a chance to review the patch ? The crash is still there
> on v5.17-rc3.
>
> Thanks,
> Lukasz
>
> wt., 1 lut 2022 o 16:49 Jani Nikula <jani.nikula@linux.intel.com> napisał(a):
> >
> >
> > Thanks for the patch, adding some Cc's from the commit that regressed.
> >
> > BR,
> > Jani.
> >
> > On Tue, 01 Feb 2022, Lukasz Bartosik <lb@semihalf.com> wrote:
> > > From: Łukasz Bartosik <lb@semihalf.com>
> > >
> > > Asus chromebook CX550 crashes during boot on v5.17-rc1 kernel.
> > > The root cause is null pointer defeference of bi_next
> > > in tgl_get_bw_info() in drivers/gpu/drm/i915/display/intel_bw.c.
> > >
> > > BUG: kernel NULL pointer dereference, address: 000000000000002e
> > > PGD 0 P4D 0
> > > Oops: 0002 [#1] PREEMPT SMP NOPTI
> > > CPU: 0 PID: 1 Comm: swapper/0 Tainted: G U 5.17.0-rc1
> > > Hardware name: Google Delbin/Delbin, BIOS Google_Delbin.13672.156.3
> 05/14/2021
> > > RIP: 0010:tgl_get_bw_info+0x2de/0x510
> > > ...
> > > [ 2.554467] Call Trace:
> > > [ 2.554467] <TASK>
> > > [ 2.554467] intel_bw_init_hw+0x14a/0x434
> > > [ 2.554467] ? _printk+0x59/0x73
> > > [ 2.554467] ? _dev_err+0x77/0x91
> > > [ 2.554467] i915_driver_hw_probe+0x329/0x33e
> > > [ 2.554467] i915_driver_probe+0x4c8/0x638
> > > [ 2.554467] i915_pci_probe+0xf8/0x14e
> > > [ 2.554467] ? _raw_spin_unlock_irqrestore+0x12/0x2c
> > > [ 2.554467] pci_device_probe+0xaa/0x142
> > > [ 2.554467] really_probe+0x13f/0x2f4
> > > [ 2.554467] __driver_probe_device+0x9e/0xd3
> > > [ 2.554467] driver_probe_device+0x24/0x7c
> > > [ 2.554467] __driver_attach+0xba/0xcf
> > > [ 2.554467] ? driver_attach+0x1f/0x1f
> > > [ 2.554467] bus_for_each_dev+0x8c/0xc0
> > > [ 2.554467] bus_add_driver+0x11b/0x1f7
> > > [ 2.554467] driver_register+0x60/0xea
> > > [ 2.554467] ? mipi_dsi_bus_init+0x16/0x16
> > > [ 2.554467] i915_init+0x2c/0xb9
> > > [ 2.554467] ? mipi_dsi_bus_init+0x16/0x16
> > > [ 2.554467] do_one_initcall+0x12e/0x2b3
> > > [ 2.554467] do_initcall_level+0xd6/0xf3
> > > [ 2.554467] do_initcalls+0x4e/0x79
> > > [ 2.554467] kernel_init_freeable+0xed/0x14d
> > > [ 2.554467] ? rest_init+0xc1/0xc1
> > > [ 2.554467] kernel_init+0x1a/0x120
> > > [ 2.554467] ret_from_fork+0x1f/0x30
> > > [ 2.554467] </TASK>
> > > ...
> > > Kernel panic - not syncing: Fatal exception
> > >
> > > Fixes: c64a9a7c05be ("drm/i915: Update memory bandwidth formulae")
LGTM,
Reviewed-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
> > > Signed-off-by: Łukasz Bartosik <lb@semihalf.com>
> > > ---
> > > drivers/gpu/drm/i915/display/intel_bw.c | 16 +++++++++-------
> > > 1 file changed, 9 insertions(+), 7 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/display/intel_bw.c
> b/drivers/gpu/drm/i915/display/intel_bw.c
> > > index 2da4aacc956b..bd0ed68b7faa 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_bw.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_bw.c
> > > @@ -404,15 +404,17 @@ static int tgl_get_bw_info(struct
> drm_i915_private *dev_priv, const struct intel
> > > int clpchgroup;
> > > int j;
> > >
> > > - if (i < num_groups - 1)
> > > - bi_next = &dev_priv->max_bw[i + 1];
> > > -
> > > clpchgroup = (sa->deburst * qi.deinterleave / num_channels) << i;
> > >
> > > - if (i < num_groups - 1 && clpchgroup < clperchgroup)
> > > - bi_next->num_planes = (ipqdepth - clpchgroup) / clpchgroup + 1;
> > > - else
> > > - bi_next->num_planes = 0;
> > > + if (i < num_groups - 1) {
> > > + bi_next = &dev_priv->max_bw[i + 1];
> > > +
> > > + if (clpchgroup < clperchgroup)
> > > + bi_next->num_planes = (ipqdepth - clpchgroup) /
> > > + clpchgroup + 1;
> > > + else
> > > + bi_next->num_planes = 0;
> > > + }
> > >
> > > bi->num_qgv_points = qi.num_points;
> > > bi->num_psf_gv_points = qi.num_psf_points;
> >
> > --
> > Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [Intel-gfx] [PATCH v1] drm/i915: fix null pointer dereference
2022-02-09 2:02 ` Sripada, Radhakrishna
@ 2022-02-09 10:31 ` Ville Syrjälä
2022-03-08 15:38 ` Łukasz Bartosik
0 siblings, 1 reply; 25+ messages in thread
From: Ville Syrjälä @ 2022-02-09 10:31 UTC (permalink / raw)
To: Sripada, Radhakrishna; +Cc: upstream, Łukasz Bartosik, intel-gfx
On Wed, Feb 09, 2022 at 02:02:05AM +0000, Sripada, Radhakrishna wrote:
>
>
> > -----Original Message-----
> > From: Łukasz Bartosik <lb@semihalf.com>
> > Sent: Tuesday, February 8, 2022 8:20 AM
> > To: Jani Nikula <jani.nikula@linux.intel.com>; Joonas Lahtinen
> > <joonas.lahtinen@linux.intel.com>; Vivi, Rodrigo <rodrigo.vivi@intel.com>;
> > Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> > Cc: Sripada, Radhakrishna <radhakrishna.sripada@intel.com>; intel-
> > gfx@lists.freedesktop.org; upstream@semihalf.com; Ville Syrjälä
> > <ville.syrjala@linux.intel.com>; Roper, Matthew D
> > <matthew.d.roper@intel.com>; Srivatsa, Anusha <anusha.srivatsa@intel.com>
> > Subject: Re: [PATCH v1] drm/i915: fix null pointer dereference
> >
> > Have you had a chance to review the patch ? The crash is still there
> > on v5.17-rc3.
> >
> > Thanks,
> > Lukasz
> >
> > wt., 1 lut 2022 o 16:49 Jani Nikula <jani.nikula@linux.intel.com> napisał(a):
> > >
> > >
> > > Thanks for the patch, adding some Cc's from the commit that regressed.
> > >
> > > BR,
> > > Jani.
> > >
> > > On Tue, 01 Feb 2022, Lukasz Bartosik <lb@semihalf.com> wrote:
> > > > From: Łukasz Bartosik <lb@semihalf.com>
> > > >
> > > > Asus chromebook CX550 crashes during boot on v5.17-rc1 kernel.
> > > > The root cause is null pointer defeference of bi_next
> > > > in tgl_get_bw_info() in drivers/gpu/drm/i915/display/intel_bw.c.
> > > >
> > > > BUG: kernel NULL pointer dereference, address: 000000000000002e
> > > > PGD 0 P4D 0
> > > > Oops: 0002 [#1] PREEMPT SMP NOPTI
> > > > CPU: 0 PID: 1 Comm: swapper/0 Tainted: G U 5.17.0-rc1
> > > > Hardware name: Google Delbin/Delbin, BIOS Google_Delbin.13672.156.3
> > 05/14/2021
> > > > RIP: 0010:tgl_get_bw_info+0x2de/0x510
> > > > ...
> > > > [ 2.554467] Call Trace:
> > > > [ 2.554467] <TASK>
> > > > [ 2.554467] intel_bw_init_hw+0x14a/0x434
> > > > [ 2.554467] ? _printk+0x59/0x73
> > > > [ 2.554467] ? _dev_err+0x77/0x91
> > > > [ 2.554467] i915_driver_hw_probe+0x329/0x33e
> > > > [ 2.554467] i915_driver_probe+0x4c8/0x638
> > > > [ 2.554467] i915_pci_probe+0xf8/0x14e
> > > > [ 2.554467] ? _raw_spin_unlock_irqrestore+0x12/0x2c
> > > > [ 2.554467] pci_device_probe+0xaa/0x142
> > > > [ 2.554467] really_probe+0x13f/0x2f4
> > > > [ 2.554467] __driver_probe_device+0x9e/0xd3
> > > > [ 2.554467] driver_probe_device+0x24/0x7c
> > > > [ 2.554467] __driver_attach+0xba/0xcf
> > > > [ 2.554467] ? driver_attach+0x1f/0x1f
> > > > [ 2.554467] bus_for_each_dev+0x8c/0xc0
> > > > [ 2.554467] bus_add_driver+0x11b/0x1f7
> > > > [ 2.554467] driver_register+0x60/0xea
> > > > [ 2.554467] ? mipi_dsi_bus_init+0x16/0x16
> > > > [ 2.554467] i915_init+0x2c/0xb9
> > > > [ 2.554467] ? mipi_dsi_bus_init+0x16/0x16
> > > > [ 2.554467] do_one_initcall+0x12e/0x2b3
> > > > [ 2.554467] do_initcall_level+0xd6/0xf3
> > > > [ 2.554467] do_initcalls+0x4e/0x79
> > > > [ 2.554467] kernel_init_freeable+0xed/0x14d
> > > > [ 2.554467] ? rest_init+0xc1/0xc1
> > > > [ 2.554467] kernel_init+0x1a/0x120
> > > > [ 2.554467] ret_from_fork+0x1f/0x30
> > > > [ 2.554467] </TASK>
> > > > ...
> > > > Kernel panic - not syncing: Fatal exception
> > > >
> > > > Fixes: c64a9a7c05be ("drm/i915: Update memory bandwidth formulae")
>
> LGTM,
> Reviewed-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
>
> > > > Signed-off-by: Łukasz Bartosik <lb@semihalf.com>
> > > > ---
> > > > drivers/gpu/drm/i915/display/intel_bw.c | 16 +++++++++-------
> > > > 1 file changed, 9 insertions(+), 7 deletions(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/i915/display/intel_bw.c
> > b/drivers/gpu/drm/i915/display/intel_bw.c
> > > > index 2da4aacc956b..bd0ed68b7faa 100644
> > > > --- a/drivers/gpu/drm/i915/display/intel_bw.c
> > > > +++ b/drivers/gpu/drm/i915/display/intel_bw.c
> > > > @@ -404,15 +404,17 @@ static int tgl_get_bw_info(struct
> > drm_i915_private *dev_priv, const struct intel
> > > > int clpchgroup;
> > > > int j;
> > > >
> > > > - if (i < num_groups - 1)
> > > > - bi_next = &dev_priv->max_bw[i + 1];
> > > > -
> > > > clpchgroup = (sa->deburst * qi.deinterleave / num_channels) << i;
> > > >
> > > > - if (i < num_groups - 1 && clpchgroup < clperchgroup)
> > > > - bi_next->num_planes = (ipqdepth - clpchgroup) / clpchgroup + 1;
> > > > - else
> > > > - bi_next->num_planes = 0;
> > > > + if (i < num_groups - 1) {
> > > > + bi_next = &dev_priv->max_bw[i + 1];
> > > > +
> > > > + if (clpchgroup < clperchgroup)
> > > > + bi_next->num_planes = (ipqdepth - clpchgroup) /
> > > > + clpchgroup + 1;
> > > > + else
> > > > + bi_next->num_planes = 0;
> > > > + }
BTW this code makes me rather suspicious overall. num_planes==0 means
no planes can be enabled at all. Is that even correct? IIRC the icl
code did not have qgv points that had num_planes==0.
Also IIRC I added that 'num_planes = ... + 1' to the icl code
ot make it actually sensible. The icl sample code didn't have
that +1 and instead it used '>' as opposed to '>=' in the
comparison to the actual number of enabled planes thus
implying the +1. But now here in the tgl+ code we have the
+1 for in one branch of the if, but the other branch just has
a 0 (so no +1).
And it doesn't help that the code is doing this weird [i] + [i+1]
stuff inside the single loop. Would be a lot more legible if we
just did two loops I think. Though I see the same awkward construct
is used in spec sample code as well.
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [Intel-gfx] [PATCH v1] drm/i915: fix null pointer dereference
2022-02-09 10:31 ` Ville Syrjälä
@ 2022-03-08 15:38 ` Łukasz Bartosik
0 siblings, 0 replies; 25+ messages in thread
From: Łukasz Bartosik @ 2022-03-08 15:38 UTC (permalink / raw)
To: Ville Syrjälä, Sripada, Radhakrishna
Cc: upstream, intel-gfx, Vivi, Rodrigo
>
> On Wed, Feb 09, 2022 at 02:02:05AM +0000, Sripada, Radhakrishna wrote:
> >
> >
> > > -----Original Message-----
> > > From: Łukasz Bartosik <lb@semihalf.com>
> > > Sent: Tuesday, February 8, 2022 8:20 AM
> > > To: Jani Nikula <jani.nikula@linux.intel.com>; Joonas Lahtinen
> > > <joonas.lahtinen@linux.intel.com>; Vivi, Rodrigo <rodrigo.vivi@intel.com>;
> > > Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> > > Cc: Sripada, Radhakrishna <radhakrishna.sripada@intel.com>; intel-
> > > gfx@lists.freedesktop.org; upstream@semihalf.com; Ville Syrjälä
> > > <ville.syrjala@linux.intel.com>; Roper, Matthew D
> > > <matthew.d.roper@intel.com>; Srivatsa, Anusha <anusha.srivatsa@intel.com>
> > > Subject: Re: [PATCH v1] drm/i915: fix null pointer dereference
> > >
> > > Have you had a chance to review the patch ? The crash is still there
> > > on v5.17-rc3.
> > >
> > > Thanks,
> > > Lukasz
> > >
> > > wt., 1 lut 2022 o 16:49 Jani Nikula <jani.nikula@linux.intel.com> napisał(a):
> > > >
> > > >
> > > > Thanks for the patch, adding some Cc's from the commit that regressed.
> > > >
> > > > BR,
> > > > Jani.
> > > >
> > > > On Tue, 01 Feb 2022, Lukasz Bartosik <lb@semihalf.com> wrote:
> > > > > From: Łukasz Bartosik <lb@semihalf.com>
> > > > >
> > > > > Asus chromebook CX550 crashes during boot on v5.17-rc1 kernel.
> > > > > The root cause is null pointer defeference of bi_next
> > > > > in tgl_get_bw_info() in drivers/gpu/drm/i915/display/intel_bw.c.
> > > > >
> > > > > BUG: kernel NULL pointer dereference, address: 000000000000002e
> > > > > PGD 0 P4D 0
> > > > > Oops: 0002 [#1] PREEMPT SMP NOPTI
> > > > > CPU: 0 PID: 1 Comm: swapper/0 Tainted: G U 5.17.0-rc1
> > > > > Hardware name: Google Delbin/Delbin, BIOS Google_Delbin.13672.156.3
> > > 05/14/2021
> > > > > RIP: 0010:tgl_get_bw_info+0x2de/0x510
> > > > > ...
> > > > > [ 2.554467] Call Trace:
> > > > > [ 2.554467] <TASK>
> > > > > [ 2.554467] intel_bw_init_hw+0x14a/0x434
> > > > > [ 2.554467] ? _printk+0x59/0x73
> > > > > [ 2.554467] ? _dev_err+0x77/0x91
> > > > > [ 2.554467] i915_driver_hw_probe+0x329/0x33e
> > > > > [ 2.554467] i915_driver_probe+0x4c8/0x638
> > > > > [ 2.554467] i915_pci_probe+0xf8/0x14e
> > > > > [ 2.554467] ? _raw_spin_unlock_irqrestore+0x12/0x2c
> > > > > [ 2.554467] pci_device_probe+0xaa/0x142
> > > > > [ 2.554467] really_probe+0x13f/0x2f4
> > > > > [ 2.554467] __driver_probe_device+0x9e/0xd3
> > > > > [ 2.554467] driver_probe_device+0x24/0x7c
> > > > > [ 2.554467] __driver_attach+0xba/0xcf
> > > > > [ 2.554467] ? driver_attach+0x1f/0x1f
> > > > > [ 2.554467] bus_for_each_dev+0x8c/0xc0
> > > > > [ 2.554467] bus_add_driver+0x11b/0x1f7
> > > > > [ 2.554467] driver_register+0x60/0xea
> > > > > [ 2.554467] ? mipi_dsi_bus_init+0x16/0x16
> > > > > [ 2.554467] i915_init+0x2c/0xb9
> > > > > [ 2.554467] ? mipi_dsi_bus_init+0x16/0x16
> > > > > [ 2.554467] do_one_initcall+0x12e/0x2b3
> > > > > [ 2.554467] do_initcall_level+0xd6/0xf3
> > > > > [ 2.554467] do_initcalls+0x4e/0x79
> > > > > [ 2.554467] kernel_init_freeable+0xed/0x14d
> > > > > [ 2.554467] ? rest_init+0xc1/0xc1
> > > > > [ 2.554467] kernel_init+0x1a/0x120
> > > > > [ 2.554467] ret_from_fork+0x1f/0x30
> > > > > [ 2.554467] </TASK>
> > > > > ...
> > > > > Kernel panic - not syncing: Fatal exception
> > > > >
> > > > > Fixes: c64a9a7c05be ("drm/i915: Update memory bandwidth formulae")
> >
> > LGTM,
> > Reviewed-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
> >
> > > > > Signed-off-by: Łukasz Bartosik <lb@semihalf.com>
> > > > > ---
> > > > > drivers/gpu/drm/i915/display/intel_bw.c | 16 +++++++++-------
> > > > > 1 file changed, 9 insertions(+), 7 deletions(-)
> > > > >
> > > > > diff --git a/drivers/gpu/drm/i915/display/intel_bw.c
> > > b/drivers/gpu/drm/i915/display/intel_bw.c
> > > > > index 2da4aacc956b..bd0ed68b7faa 100644
> > > > > --- a/drivers/gpu/drm/i915/display/intel_bw.c
> > > > > +++ b/drivers/gpu/drm/i915/display/intel_bw.c
> > > > > @@ -404,15 +404,17 @@ static int tgl_get_bw_info(struct
> > > drm_i915_private *dev_priv, const struct intel
> > > > > int clpchgroup;
> > > > > int j;
> > > > >
> > > > > - if (i < num_groups - 1)
> > > > > - bi_next = &dev_priv->max_bw[i + 1];
> > > > > -
> > > > > clpchgroup = (sa->deburst * qi.deinterleave / num_channels) << i;
> > > > >
> > > > > - if (i < num_groups - 1 && clpchgroup < clperchgroup)
> > > > > - bi_next->num_planes = (ipqdepth - clpchgroup) / clpchgroup + 1;
> > > > > - else
> > > > > - bi_next->num_planes = 0;
> > > > > + if (i < num_groups - 1) {
> > > > > + bi_next = &dev_priv->max_bw[i + 1];
> > > > > +
> > > > > + if (clpchgroup < clperchgroup)
> > > > > + bi_next->num_planes = (ipqdepth - clpchgroup) /
> > > > > + clpchgroup + 1;
> > > > > + else
> > > > > + bi_next->num_planes = 0;
> > > > > + }
>
> BTW this code makes me rather suspicious overall. num_planes==0 means
> no planes can be enabled at all. Is that even correct? IIRC the icl
> code did not have qgv points that had num_planes==0.
>
> Also IIRC I added that 'num_planes = ... + 1' to the icl code
> ot make it actually sensible. The icl sample code didn't have
> that +1 and instead it used '>' as opposed to '>=' in the
> comparison to the actual number of enabled planes thus
> implying the +1. But now here in the tgl+ code we have the
> +1 for in one branch of the if, but the other branch just has
> a 0 (so no +1).
>
> And it doesn't help that the code is doing this weird [i] + [i+1]
> stuff inside the single loop. Would be a lot more legible if we
> just did two loops I think. Though I see the same awkward construct
> is used in spec sample code as well.
>
> --
> Ville Syrjälä
> Intel
The crash still occurs in the v5.17-rc7.
Regards,
Lukasz
^ permalink raw reply [flat|nested] 25+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: fix null pointer dereference
2022-02-01 15:33 [Intel-gfx] [PATCH v1] drm/i915: fix null pointer dereference Lukasz Bartosik
2022-02-01 15:49 ` Jani Nikula
@ 2022-02-02 14:27 ` Patchwork
2022-02-02 15:31 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
` (7 subsequent siblings)
9 siblings, 0 replies; 25+ messages in thread
From: Patchwork @ 2022-02-02 14:27 UTC (permalink / raw)
To: Lukasz Bartosik; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 8428 bytes --]
== Series Details ==
Series: drm/i915: fix null pointer dereference
URL : https://patchwork.freedesktop.org/series/99621/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11177 -> Patchwork_22158
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/index.html
Participating hosts (48 -> 43)
------------------------------
Additional (1): bat-dg1-5
Missing (6): shard-tglu fi-bsw-cyan fi-icl-u2 shard-rkl shard-dg1 fi-bdw-samus
Known issues
------------
Here are the changes found in Patchwork_22158 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_cs_nop@sync-fork-compute0:
- fi-snb-2600: NOTRUN -> [SKIP][1] ([fdo#109271]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/fi-snb-2600/igt@amdgpu/amd_cs_nop@sync-fork-compute0.html
* igt@gem_exec_gttfill@basic:
- bat-dg1-5: NOTRUN -> [SKIP][2] ([i915#4086])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/bat-dg1-5/igt@gem_exec_gttfill@basic.html
* igt@gem_exec_suspend@basic-s3@smem:
- fi-skl-6600u: [PASS][3] -> [INCOMPLETE][4] ([i915#4547])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/fi-skl-6600u/igt@gem_exec_suspend@basic-s3@smem.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/fi-skl-6600u/igt@gem_exec_suspend@basic-s3@smem.html
* igt@gem_mmap@basic:
- bat-dg1-5: NOTRUN -> [SKIP][5] ([i915#4083])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/bat-dg1-5/igt@gem_mmap@basic.html
* igt@gem_mmap_gtt@basic:
- bat-dg1-5: NOTRUN -> [SKIP][6] ([i915#4077]) +2 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/bat-dg1-5/igt@gem_mmap_gtt@basic.html
* igt@gem_tiled_pread_basic:
- bat-dg1-5: NOTRUN -> [SKIP][7] ([i915#4079]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/bat-dg1-5/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- bat-dg1-5: NOTRUN -> [SKIP][8] ([i915#1155])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/bat-dg1-5/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_selftest@live@hangcheck:
- bat-dg1-5: NOTRUN -> [DMESG-FAIL][9] ([i915#4494] / [i915#4957])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/bat-dg1-5/igt@i915_selftest@live@hangcheck.html
* igt@kms_addfb_basic@basic-y-tiled-legacy:
- bat-dg1-5: NOTRUN -> [SKIP][10] ([i915#4215])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/bat-dg1-5/igt@kms_addfb_basic@basic-y-tiled-legacy.html
* igt@kms_addfb_basic@tile-pitch-mismatch:
- bat-dg1-5: NOTRUN -> [SKIP][11] ([i915#4212]) +7 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/bat-dg1-5/igt@kms_addfb_basic@tile-pitch-mismatch.html
* igt@kms_chamelium@dp-hpd-fast:
- bat-dg1-5: NOTRUN -> [SKIP][12] ([fdo#111827]) +8 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/bat-dg1-5/igt@kms_chamelium@dp-hpd-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- bat-dg1-5: NOTRUN -> [SKIP][13] ([i915#4103] / [i915#4213]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/bat-dg1-5/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_force_connector_basic@force-load-detect:
- bat-dg1-5: NOTRUN -> [SKIP][14] ([fdo#109285])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/bat-dg1-5/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_psr@primary_page_flip:
- bat-dg1-5: NOTRUN -> [SKIP][15] ([i915#1072] / [i915#4078]) +3 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/bat-dg1-5/igt@kms_psr@primary_page_flip.html
* igt@prime_vgem@basic-fence-flip:
- bat-dg1-5: NOTRUN -> [SKIP][16] ([i915#3708]) +3 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/bat-dg1-5/igt@prime_vgem@basic-fence-flip.html
* igt@prime_vgem@basic-fence-mmap:
- bat-dg1-5: NOTRUN -> [SKIP][17] ([i915#3708] / [i915#4077]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/bat-dg1-5/igt@prime_vgem@basic-fence-mmap.html
* igt@prime_vgem@basic-userptr:
- bat-dg1-5: NOTRUN -> [SKIP][18] ([i915#3708] / [i915#4873])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/bat-dg1-5/igt@prime_vgem@basic-userptr.html
* igt@runner@aborted:
- fi-skl-6600u: NOTRUN -> [FAIL][19] ([i915#4312])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/fi-skl-6600u/igt@runner@aborted.html
#### Possible fixes ####
* igt@i915_selftest@live@hangcheck:
- fi-snb-2600: [INCOMPLETE][20] ([i915#3921]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
* igt@kms_frontbuffer_tracking@basic:
- fi-cfl-8109u: [DMESG-FAIL][22] ([i915#295]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_pipe_crc_basic@read-crc-pipe-b:
- fi-cfl-8109u: [DMESG-WARN][24] ([i915#295]) -> [PASS][25] +10 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/fi-cfl-8109u/igt@kms_pipe_crc_basic@read-crc-pipe-b.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/fi-cfl-8109u/igt@kms_pipe_crc_basic@read-crc-pipe-b.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#295]: https://gitlab.freedesktop.org/drm/intel/issues/295
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4086]: https://gitlab.freedesktop.org/drm/intel/issues/4086
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4898]: https://gitlab.freedesktop.org/drm/intel/issues/4898
[i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
Build changes
-------------
* Linux: CI_DRM_11177 -> Patchwork_22158
CI-20190529: 20190529
CI_DRM_11177: 22db355d36b6c879c506e293b0255bf951df1dff @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6337: 7c9c034619ef9dbfbfe041fbf3973a1cf1ac7a22 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_22158: e5ea5fc3b043ec00f19f8367a04acf9c6f527791 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
e5ea5fc3b043 drm/i915: fix null pointer dereference
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/index.html
[-- Attachment #2: Type: text/html, Size: 9701 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: fix null pointer dereference
2022-02-01 15:33 [Intel-gfx] [PATCH v1] drm/i915: fix null pointer dereference Lukasz Bartosik
2022-02-01 15:49 ` Jani Nikula
2022-02-02 14:27 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2022-02-02 15:31 ` Patchwork
2022-08-22 17:14 ` [Intel-gfx] [PATCH v1] " Nathan Chancellor
` (6 subsequent siblings)
9 siblings, 0 replies; 25+ messages in thread
From: Patchwork @ 2022-02-02 15:31 UTC (permalink / raw)
To: Lukasz Bartosik; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 29637 bytes --]
== Series Details ==
Series: drm/i915: fix null pointer dereference
URL : https://patchwork.freedesktop.org/series/99621/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11177_full -> Patchwork_22158_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (13 -> 10)
------------------------------
Missing (3): shard-rkl shard-dg1 shard-tglu
Known issues
------------
Here are the changes found in Patchwork_22158_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_balancer@parallel-keep-submit-fence:
- shard-iclb: [PASS][1] -> [SKIP][2] ([i915#4525])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-iclb1/igt@gem_exec_balancer@parallel-keep-submit-fence.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-iclb6/igt@gem_exec_balancer@parallel-keep-submit-fence.html
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-skl: NOTRUN -> [SKIP][3] ([fdo#109271]) +51 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-skl2/igt@gem_exec_fair@basic-flow@rcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-kbl: [PASS][4] -> [FAIL][5] ([i915#2842]) +1 similar issue
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-kbl4/igt@gem_exec_fair@basic-pace@rcs0.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-kbl6/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_lmem_swapping@parallel-random-engines:
- shard-skl: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#4613])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-skl9/igt@gem_lmem_swapping@parallel-random-engines.html
- shard-kbl: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#4613]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-kbl7/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@gem_pxp@verify-pxp-key-change-after-suspend-resume:
- shard-iclb: NOTRUN -> [SKIP][8] ([i915#4270])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-iclb3/igt@gem_pxp@verify-pxp-key-change-after-suspend-resume.html
* igt@gem_softpin@allocator-evict-all-engines:
- shard-glk: [PASS][9] -> [FAIL][10] ([i915#4171])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-glk5/igt@gem_softpin@allocator-evict-all-engines.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-glk5/igt@gem_softpin@allocator-evict-all-engines.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-kbl: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#3323])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-kbl7/igt@gem_userptr_blits@dmabuf-sync.html
- shard-skl: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#3323])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-skl9/igt@gem_userptr_blits@dmabuf-sync.html
* igt@gem_workarounds@suspend-resume-fd:
- shard-kbl: NOTRUN -> [DMESG-WARN][13] ([i915#180])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-kbl1/igt@gem_workarounds@suspend-resume-fd.html
* igt@gen9_exec_parse@allowed-all:
- shard-apl: [PASS][14] -> [DMESG-WARN][15] ([i915#1436] / [i915#716])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-apl4/igt@gen9_exec_parse@allowed-all.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-apl7/igt@gen9_exec_parse@allowed-all.html
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-skl: NOTRUN -> [SKIP][16] ([fdo#109271] / [i915#658])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-skl9/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@i915_suspend@sysfs-reader:
- shard-apl: [PASS][17] -> [DMESG-WARN][18] ([i915#180]) +2 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-apl1/igt@i915_suspend@sysfs-reader.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-apl6/igt@i915_suspend@sysfs-reader.html
* igt@kms_async_flips@alternate-sync-async-flip:
- shard-skl: [PASS][19] -> [FAIL][20] ([i915#2521])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-skl1/igt@kms_async_flips@alternate-sync-async-flip.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-skl1/igt@kms_async_flips@alternate-sync-async-flip.html
- shard-kbl: [PASS][21] -> [FAIL][22] ([i915#2521])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-kbl6/igt@kms_async_flips@alternate-sync-async-flip.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-kbl1/igt@kms_async_flips@alternate-sync-async-flip.html
* igt@kms_big_fb@linear-16bpp-rotate-90:
- shard-iclb: NOTRUN -> [SKIP][23] ([fdo#110725] / [fdo#111614])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-iclb3/igt@kms_big_fb@linear-16bpp-rotate-90.html
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-skl: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#3777]) +2 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-skl9/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
- shard-kbl: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#3777]) +3 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-kbl6/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
* igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#3886])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-apl2/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-a-crc-primary-basic-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#3886]) +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-skl9/igt@kms_ccs@pipe-a-crc-primary-basic-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][28] ([fdo#109271] / [i915#3886]) +6 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-kbl4/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc:
- shard-iclb: NOTRUN -> [SKIP][29] ([fdo#109278] / [i915#3886])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-iclb3/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_chamelium@hdmi-hpd-storm:
- shard-kbl: NOTRUN -> [SKIP][30] ([fdo#109271] / [fdo#111827]) +9 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-kbl6/igt@kms_chamelium@hdmi-hpd-storm.html
* igt@kms_chamelium@hdmi-hpd-storm-disable:
- shard-skl: NOTRUN -> [SKIP][31] ([fdo#109271] / [fdo#111827]) +5 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-skl9/igt@kms_chamelium@hdmi-hpd-storm-disable.html
* igt@kms_chamelium@vga-hpd-after-suspend:
- shard-snb: NOTRUN -> [SKIP][32] ([fdo#109271] / [fdo#111827]) +1 similar issue
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-snb6/igt@kms_chamelium@vga-hpd-after-suspend.html
* igt@kms_color_chamelium@pipe-c-ctm-max:
- shard-apl: NOTRUN -> [SKIP][33] ([fdo#109271] / [fdo#111827]) +2 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-apl2/igt@kms_color_chamelium@pipe-c-ctm-max.html
* igt@kms_cursor_crc@pipe-c-cursor-alpha-opaque:
- shard-snb: NOTRUN -> [SKIP][34] ([fdo#109271]) +24 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-snb6/igt@kms_cursor_crc@pipe-c-cursor-alpha-opaque.html
* igt@kms_cursor_crc@pipe-d-cursor-suspend:
- shard-kbl: NOTRUN -> [SKIP][35] ([fdo#109271]) +119 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-kbl7/igt@kms_cursor_crc@pipe-d-cursor-suspend.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-tglb: [PASS][36] -> [FAIL][37] ([i915#2346] / [i915#533])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-tglb2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-tglb7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@flip-vs-cursor-varying-size:
- shard-iclb: [PASS][38] -> [FAIL][39] ([i915#2346])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-iclb8/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-iclb7/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html
* igt@kms_flip@2x-plain-flip-interruptible:
- shard-iclb: NOTRUN -> [SKIP][40] ([fdo#109274])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-iclb3/igt@kms_flip@2x-plain-flip-interruptible.html
* igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@c-edp1:
- shard-skl: NOTRUN -> [FAIL][41] ([i915#2122])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-skl2/igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@c-edp1.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1:
- shard-skl: [PASS][42] -> [FAIL][43] ([i915#2122])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-skl2/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-skl2/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [PASS][44] -> [DMESG-WARN][45] ([i915#180]) +5 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-suspend.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-indfb-draw-blt:
- shard-apl: NOTRUN -> [SKIP][46] ([fdo#109271]) +26 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-apl2/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-indfb-draw-blt.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][47] -> [FAIL][48] ([i915#1188]) +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-skl7/igt@kms_hdr@bpc-switch-dpms.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-skl4/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-d:
- shard-kbl: NOTRUN -> [SKIP][49] ([fdo#109271] / [i915#533])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-kbl4/igt@kms_pipe_crc_basic@hang-read-crc-pipe-d.html
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-kbl: NOTRUN -> [FAIL][50] ([fdo#108145] / [i915#265])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-kbl4/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-basic:
- shard-apl: NOTRUN -> [FAIL][51] ([fdo#108145] / [i915#265]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-apl2/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb:
- shard-skl: NOTRUN -> [FAIL][52] ([i915#265])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-skl9/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-skl: NOTRUN -> [FAIL][53] ([fdo#108145] / [i915#265])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][54] -> [FAIL][55] ([fdo#108145] / [i915#265])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_plane_alpha_blend@pipe-d-constant-alpha-max:
- shard-iclb: NOTRUN -> [SKIP][56] ([fdo#109278]) +3 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-iclb3/igt@kms_plane_alpha_blend@pipe-d-constant-alpha-max.html
* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-kbl: NOTRUN -> [SKIP][57] ([fdo#109271] / [i915#658]) +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-kbl4/igt@kms_psr2_su@page_flip-xrgb8888.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [PASS][58] -> [SKIP][59] ([fdo#109441]) +1 similar issue
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-iclb1/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@perf@polling-parameterized:
- shard-glk: [PASS][60] -> [FAIL][61] ([i915#1542])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-glk7/igt@perf@polling-parameterized.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-glk8/igt@perf@polling-parameterized.html
* igt@sysfs_clients@busy:
- shard-apl: NOTRUN -> [SKIP][62] ([fdo#109271] / [i915#2994])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-apl2/igt@sysfs_clients@busy.html
* igt@sysfs_clients@split-25:
- shard-kbl: NOTRUN -> [SKIP][63] ([fdo#109271] / [i915#2994])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-kbl4/igt@sysfs_clients@split-25.html
#### Possible fixes ####
* igt@gem_exec_balancer@parallel-contexts:
- shard-iclb: [SKIP][64] ([i915#4525]) -> [PASS][65]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-iclb7/igt@gem_exec_balancer@parallel-contexts.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-iclb2/igt@gem_exec_balancer@parallel-contexts.html
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-tglb: [FAIL][66] ([i915#2842]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-tglb3/igt@gem_exec_fair@basic-none-rrul@rcs0.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-tglb6/igt@gem_exec_fair@basic-none-rrul@rcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-apl: [FAIL][68] ([i915#2842]) -> [PASS][69]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-apl3/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-apl1/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [FAIL][70] ([i915#2842]) -> [PASS][71] +1 similar issue
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-kbl4/igt@gem_exec_fair@basic-pace@vecs0.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-kbl6/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_exec_whisper@basic-forked:
- shard-glk: [DMESG-WARN][72] ([i915#118]) -> [PASS][73] +1 similar issue
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-glk2/igt@gem_exec_whisper@basic-forked.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-glk4/igt@gem_exec_whisper@basic-forked.html
* igt@i915_selftest@live@hangcheck:
- shard-snb: [INCOMPLETE][74] ([i915#3921]) -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-snb6/igt@i915_selftest@live@hangcheck.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-snb6/igt@i915_selftest@live@hangcheck.html
* igt@i915_suspend@forcewake:
- shard-apl: [DMESG-WARN][76] ([i915#180]) -> [PASS][77]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-apl8/igt@i915_suspend@forcewake.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-apl2/igt@i915_suspend@forcewake.html
* igt@kms_color@pipe-b-ctm-red-to-blue:
- shard-skl: [DMESG-WARN][78] ([i915#1982]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-skl6/igt@kms_color@pipe-b-ctm-red-to-blue.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-skl2/igt@kms_color@pipe-b-ctm-red-to-blue.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: [FAIL][80] ([i915#2346] / [i915#533]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-skl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-skl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling:
- shard-glk: [FAIL][82] ([i915#4911]) -> [PASS][83] +1 similar issue
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-glk8/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-glk9/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling:
- shard-iclb: [SKIP][84] ([i915#3701]) -> [PASS][85]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling.html
* igt@kms_lease@lease_unleased_connector:
- shard-snb: [SKIP][86] ([fdo#109271]) -> [PASS][87]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-snb5/igt@kms_lease@lease_unleased_connector.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-snb4/igt@kms_lease@lease_unleased_connector.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-kbl: [DMESG-WARN][88] ([i915#180]) -> [PASS][89] +2 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-kbl6/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-kbl1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [SKIP][90] ([fdo#109441]) -> [PASS][91] +3 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-iclb5/igt@kms_psr@psr2_cursor_blt.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
* igt@kms_psr@suspend:
- shard-skl: [INCOMPLETE][92] ([i915#4939]) -> [PASS][93]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-skl6/igt@kms_psr@suspend.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-skl2/igt@kms_psr@suspend.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [DMESG-WARN][94] ([i915#180] / [i915#295]) -> [PASS][95]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-kbl1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-kbl7/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
#### Warnings ####
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-glk: [FAIL][96] ([i915#2842]) -> [DMESG-WARN][97] ([i915#118])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-glk4/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-glk1/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [WARN][98] ([i915#1804] / [i915#2684]) -> [WARN][99] ([i915#2684])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-iclb6/igt@i915_pm_rc6_residency@rc6-idle.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-iclb8/igt@i915_pm_rc6_residency@rc6-idle.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area:
- shard-iclb: [SKIP][100] ([i915#2920]) -> [SKIP][101] ([fdo#111068] / [i915#658])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-iclb3/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area.html
* igt@runner@aborted:
- shard-kbl: ([FAIL][102], [FAIL][103], [FAIL][104], [FAIL][105], [FAIL][106], [FAIL][107], [FAIL][108], [FAIL][109], [FAIL][110], [FAIL][111]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#3002] / [i915#4312] / [i915#602]) -> ([FAIL][112], [FAIL][113], [FAIL][114], [FAIL][115], [FAIL][116], [FAIL][117], [FAIL][118], [FAIL][119], [FAIL][120], [FAIL][121], [FAIL][122]) ([fdo#109271] / [i915#1436] / [i915#180] / [i915#1814] / [i915#3002] / [i915#4312])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-kbl7/igt@runner@aborted.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-kbl7/igt@runner@aborted.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-kbl1/igt@runner@aborted.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-kbl6/igt@runner@aborted.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-kbl1/igt@runner@aborted.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-kbl6/igt@runner@aborted.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-kbl7/igt@runner@aborted.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-kbl6/igt@runner@aborted.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-kbl1/igt@runner@aborted.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-kbl4/igt@runner@aborted.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-kbl6/igt@runner@aborted.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-kbl6/igt@runner@aborted.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-kbl7/igt@runner@aborted.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-kbl1/igt@runner@aborted.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-kbl1/igt@runner@aborted.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-kbl7/igt@runner@aborted.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-kbl1/igt@runner@aborted.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-kbl3/igt@runner@aborted.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-kbl7/igt@runner@aborted.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-kbl1/igt@runner@aborted.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-kbl7/igt@runner@aborted.html
- shard-apl: ([FAIL][123], [FAIL][124], [FAIL][125], [FAIL][126]) ([i915#180] / [i915#3002] / [i915#4312]) -> ([FAIL][127], [FAIL][128], [FAIL][129], [FAIL][130], [FAIL][131], [FAIL][132]) ([fdo#109271] / [i915#180] / [i915#1814] / [i915#3002] / [i915#4312])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-apl1/igt@runner@aborted.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-apl3/igt@runner@aborted.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-apl4/igt@runner@aborted.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-apl8/igt@runner@aborted.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-apl3/igt@runner@aborted.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-apl6/igt@runner@aborted.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-apl1/igt@runner@aborted.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-apl2/igt@runner@aborted.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-apl6/igt@runner@aborted.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-apl7/igt@runner@aborted.html
- shard-skl: ([FAIL][133], [FAIL][134], [FAIL][135]) ([i915#3002] / [i915#4312]) -> [FAIL][136] ([i915#4312])
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-skl1/igt@runner@aborted.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-skl9/igt@runner@aborted.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11177/shard-skl1/igt@runner@aborted.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/shard-skl1/igt@runner@aborted.html
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110725]: https://bugs.freedesktop.org/show_bug.cgi?id=110725
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#295]: https://gitlab.freedesktop.org/drm/intel/issues/295
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3701]: https://gitlab.freedesktop.org/drm/intel/issues/3701
[i915#3777]: https://gitlab.freedesktop.org/drm/intel/issues/3777
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#4171]: https://gitlab.freedesktop.org/drm/intel/issues/4171
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4911]: https://gitlab.freedesktop.org/drm/intel/issues/4911
[i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#602]: https://gitlab.freedesktop.org/drm/intel/issues/602
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
Build changes
-------------
* Linux: CI_DRM_11177 -> Patchwork_22158
CI-20190529: 20190529
CI_DRM_11177: 22db355d36b6c879c506e293b0255bf951df1dff @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6337: 7c9c034619ef9dbfbfe041fbf3973a1cf1ac7a22 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_22158: e5ea5fc3b043ec00f19f8367a04acf9c6f527791 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22158/index.html
[-- Attachment #2: Type: text/html, Size: 37565 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [Intel-gfx] [PATCH v1] drm/i915: fix null pointer dereference
2022-02-01 15:33 [Intel-gfx] [PATCH v1] drm/i915: fix null pointer dereference Lukasz Bartosik
` (2 preceding siblings ...)
2022-02-02 15:31 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2022-08-22 17:14 ` Nathan Chancellor
2022-08-22 20:30 ` Kees Cook
` (5 subsequent siblings)
9 siblings, 0 replies; 25+ messages in thread
From: Nathan Chancellor @ 2022-08-22 17:14 UTC (permalink / raw)
To: Lukasz Bartosik; +Cc: upstream, intel-gfx, Rodrigo Vivi
Hi all,
On Tue, Feb 01, 2022 at 04:33:54PM +0100, Lukasz Bartosik wrote:
> From: Łukasz Bartosik <lb@semihalf.com>
>
> Asus chromebook CX550 crashes during boot on v5.17-rc1 kernel.
> The root cause is null pointer defeference of bi_next
> in tgl_get_bw_info() in drivers/gpu/drm/i915/display/intel_bw.c.
>
> BUG: kernel NULL pointer dereference, address: 000000000000002e
> PGD 0 P4D 0
> Oops: 0002 [#1] PREEMPT SMP NOPTI
> CPU: 0 PID: 1 Comm: swapper/0 Tainted: G U 5.17.0-rc1
> Hardware name: Google Delbin/Delbin, BIOS Google_Delbin.13672.156.3 05/14/2021
> RIP: 0010:tgl_get_bw_info+0x2de/0x510
> ...
> [ 2.554467] Call Trace:
> [ 2.554467] <TASK>
> [ 2.554467] intel_bw_init_hw+0x14a/0x434
> [ 2.554467] ? _printk+0x59/0x73
> [ 2.554467] ? _dev_err+0x77/0x91
> [ 2.554467] i915_driver_hw_probe+0x329/0x33e
> [ 2.554467] i915_driver_probe+0x4c8/0x638
> [ 2.554467] i915_pci_probe+0xf8/0x14e
> [ 2.554467] ? _raw_spin_unlock_irqrestore+0x12/0x2c
> [ 2.554467] pci_device_probe+0xaa/0x142
> [ 2.554467] really_probe+0x13f/0x2f4
> [ 2.554467] __driver_probe_device+0x9e/0xd3
> [ 2.554467] driver_probe_device+0x24/0x7c
> [ 2.554467] __driver_attach+0xba/0xcf
> [ 2.554467] ? driver_attach+0x1f/0x1f
> [ 2.554467] bus_for_each_dev+0x8c/0xc0
> [ 2.554467] bus_add_driver+0x11b/0x1f7
> [ 2.554467] driver_register+0x60/0xea
> [ 2.554467] ? mipi_dsi_bus_init+0x16/0x16
> [ 2.554467] i915_init+0x2c/0xb9
> [ 2.554467] ? mipi_dsi_bus_init+0x16/0x16
> [ 2.554467] do_one_initcall+0x12e/0x2b3
> [ 2.554467] do_initcall_level+0xd6/0xf3
> [ 2.554467] do_initcalls+0x4e/0x79
> [ 2.554467] kernel_init_freeable+0xed/0x14d
> [ 2.554467] ? rest_init+0xc1/0xc1
> [ 2.554467] kernel_init+0x1a/0x120
> [ 2.554467] ret_from_fork+0x1f/0x30
> [ 2.554467] </TASK>
> ...
> Kernel panic - not syncing: Fatal exception
>
> Fixes: c64a9a7c05be ("drm/i915: Update memory bandwidth formulae")
> Signed-off-by: Łukasz Bartosik <lb@semihalf.com>
> ---
> drivers/gpu/drm/i915/display/intel_bw.c | 16 +++++++++-------
> 1 file changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
> index 2da4aacc956b..bd0ed68b7faa 100644
> --- a/drivers/gpu/drm/i915/display/intel_bw.c
> +++ b/drivers/gpu/drm/i915/display/intel_bw.c
> @@ -404,15 +404,17 @@ static int tgl_get_bw_info(struct drm_i915_private *dev_priv, const struct intel
> int clpchgroup;
> int j;
>
> - if (i < num_groups - 1)
> - bi_next = &dev_priv->max_bw[i + 1];
> -
> clpchgroup = (sa->deburst * qi.deinterleave / num_channels) << i;
>
> - if (i < num_groups - 1 && clpchgroup < clperchgroup)
> - bi_next->num_planes = (ipqdepth - clpchgroup) / clpchgroup + 1;
> - else
> - bi_next->num_planes = 0;
> + if (i < num_groups - 1) {
> + bi_next = &dev_priv->max_bw[i + 1];
> +
> + if (clpchgroup < clperchgroup)
> + bi_next->num_planes = (ipqdepth - clpchgroup) /
> + clpchgroup + 1;
> + else
> + bi_next->num_planes = 0;
> + }
>
> bi->num_qgv_points = qi.num_points;
> bi->num_psf_gv_points = qi.num_psf_points;
> --
> 2.35.0.rc2.247.g8bbb082509-goog
>
>
Was this patch ever applied or was the issue fixed in a different way?
If CONFIG_INIT_STACK_ALL_ZERO is enabled (it is on by default when the
compiler supports it), bi_next will be deterministically initialized to
NULL, which means 'bi_next->num_planes = 0' will crash when the first if
statement is not taken (i.e. 'i > num_groups - 1'). This was reported to
us at [1] so it impacts real users (and I have been applying this change
locally for six months).
I see some discussion in the thread, was it ever resolved?
[1]: https://github.com/ClangBuiltLinux/linux/issues/1626
Cheers,
Nathan
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [Intel-gfx] [PATCH v1] drm/i915: fix null pointer dereference
2022-02-01 15:33 [Intel-gfx] [PATCH v1] drm/i915: fix null pointer dereference Lukasz Bartosik
` (3 preceding siblings ...)
2022-08-22 17:14 ` [Intel-gfx] [PATCH v1] " Nathan Chancellor
@ 2022-08-22 20:30 ` Kees Cook
2022-08-22 20:33 ` Nathan Chancellor
` (4 subsequent siblings)
9 siblings, 0 replies; 25+ messages in thread
From: Kees Cook @ 2022-08-22 20:30 UTC (permalink / raw)
To: Lukasz Bartosik; +Cc: upstream, intel-gfx, Rodrigo Vivi
On Tue, Feb 01, 2022 at 04:33:54PM +0100, Lukasz Bartosik wrote:
> From: Łukasz Bartosik <lb@semihalf.com>
>
> Asus chromebook CX550 crashes during boot on v5.17-rc1 kernel.
> The root cause is null pointer defeference of bi_next
> in tgl_get_bw_info() in drivers/gpu/drm/i915/display/intel_bw.c.
>
> BUG: kernel NULL pointer dereference, address: 000000000000002e
> PGD 0 P4D 0
> Oops: 0002 [#1] PREEMPT SMP NOPTI
> CPU: 0 PID: 1 Comm: swapper/0 Tainted: G U 5.17.0-rc1
> Hardware name: Google Delbin/Delbin, BIOS Google_Delbin.13672.156.3 05/14/2021
> RIP: 0010:tgl_get_bw_info+0x2de/0x510
> ...
> [ 2.554467] Call Trace:
> [ 2.554467] <TASK>
> [ 2.554467] intel_bw_init_hw+0x14a/0x434
> [ 2.554467] ? _printk+0x59/0x73
> [ 2.554467] ? _dev_err+0x77/0x91
> [ 2.554467] i915_driver_hw_probe+0x329/0x33e
> [ 2.554467] i915_driver_probe+0x4c8/0x638
> [ 2.554467] i915_pci_probe+0xf8/0x14e
> [ 2.554467] ? _raw_spin_unlock_irqrestore+0x12/0x2c
> [ 2.554467] pci_device_probe+0xaa/0x142
> [ 2.554467] really_probe+0x13f/0x2f4
> [ 2.554467] __driver_probe_device+0x9e/0xd3
> [ 2.554467] driver_probe_device+0x24/0x7c
> [ 2.554467] __driver_attach+0xba/0xcf
> [ 2.554467] ? driver_attach+0x1f/0x1f
> [ 2.554467] bus_for_each_dev+0x8c/0xc0
> [ 2.554467] bus_add_driver+0x11b/0x1f7
> [ 2.554467] driver_register+0x60/0xea
> [ 2.554467] ? mipi_dsi_bus_init+0x16/0x16
> [ 2.554467] i915_init+0x2c/0xb9
> [ 2.554467] ? mipi_dsi_bus_init+0x16/0x16
> [ 2.554467] do_one_initcall+0x12e/0x2b3
> [ 2.554467] do_initcall_level+0xd6/0xf3
> [ 2.554467] do_initcalls+0x4e/0x79
> [ 2.554467] kernel_init_freeable+0xed/0x14d
> [ 2.554467] ? rest_init+0xc1/0xc1
> [ 2.554467] kernel_init+0x1a/0x120
> [ 2.554467] ret_from_fork+0x1f/0x30
> [ 2.554467] </TASK>
> ...
> Kernel panic - not syncing: Fatal exception
>
> Fixes: c64a9a7c05be ("drm/i915: Update memory bandwidth formulae")
> Signed-off-by: Łukasz Bartosik <lb@semihalf.com>
> ---
> drivers/gpu/drm/i915/display/intel_bw.c | 16 +++++++++-------
> 1 file changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
> index 2da4aacc956b..bd0ed68b7faa 100644
> --- a/drivers/gpu/drm/i915/display/intel_bw.c
> +++ b/drivers/gpu/drm/i915/display/intel_bw.c
> @@ -404,15 +404,17 @@ static int tgl_get_bw_info(struct drm_i915_private *dev_priv, const struct intel
> int clpchgroup;
> int j;
>
> - if (i < num_groups - 1)
> - bi_next = &dev_priv->max_bw[i + 1];
> -
> clpchgroup = (sa->deburst * qi.deinterleave / num_channels) << i;
>
> - if (i < num_groups - 1 && clpchgroup < clperchgroup)
> - bi_next->num_planes = (ipqdepth - clpchgroup) / clpchgroup + 1;
> - else
> - bi_next->num_planes = 0;
> + if (i < num_groups - 1) {
> + bi_next = &dev_priv->max_bw[i + 1];
> +
> + if (clpchgroup < clperchgroup)
> + bi_next->num_planes = (ipqdepth - clpchgroup) /
> + clpchgroup + 1;
> + else
> + bi_next->num_planes = 0;
> + }
>
> bi->num_qgv_points = qi.num_points;
> bi->num_psf_gv_points = qi.num_psf_points;
(Some email path may be clogged; Nathan Chancellor has also sent email,
but I wanted to comment too.)
This patch solves https://github.com/ClangBuiltLinux/linux/issues/1626
And it's actually fixing a wild write as well: for folks where
"i < num_groups - 1" is false and they don't get "lucky" with a NULL
deref, this is writing to some address left over on the stack. :|
-Kees
--
Kees Cook
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [Intel-gfx] [PATCH v1] drm/i915: fix null pointer dereference
2022-02-01 15:33 [Intel-gfx] [PATCH v1] drm/i915: fix null pointer dereference Lukasz Bartosik
@ 2022-08-22 20:33 ` Nathan Chancellor
2022-02-02 14:27 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (8 subsequent siblings)
9 siblings, 0 replies; 25+ messages in thread
From: Nathan Chancellor @ 2022-08-22 20:33 UTC (permalink / raw)
To: Lukasz Bartosik
Cc: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin,
intel-gfx, upstream, llvm
Hi all,
Apologies in advance if you see this twice. I did not see the original
make it to either lore.kernel.org or the freedesktop.org archives so I
figured it might have been sent into the void.
On Tue, Feb 01, 2022 at 04:33:54PM +0100, Lukasz Bartosik wrote:
> From: Łukasz Bartosik <lb@semihalf.com>
>
> Asus chromebook CX550 crashes during boot on v5.17-rc1 kernel.
> The root cause is null pointer defeference of bi_next
> in tgl_get_bw_info() in drivers/gpu/drm/i915/display/intel_bw.c.
>
> BUG: kernel NULL pointer dereference, address: 000000000000002e
> PGD 0 P4D 0
> Oops: 0002 [#1] PREEMPT SMP NOPTI
> CPU: 0 PID: 1 Comm: swapper/0 Tainted: G U 5.17.0-rc1
> Hardware name: Google Delbin/Delbin, BIOS Google_Delbin.13672.156.3 05/14/2021
> RIP: 0010:tgl_get_bw_info+0x2de/0x510
> ...
> [ 2.554467] Call Trace:
> [ 2.554467] <TASK>
> [ 2.554467] intel_bw_init_hw+0x14a/0x434
> [ 2.554467] ? _printk+0x59/0x73
> [ 2.554467] ? _dev_err+0x77/0x91
> [ 2.554467] i915_driver_hw_probe+0x329/0x33e
> [ 2.554467] i915_driver_probe+0x4c8/0x638
> [ 2.554467] i915_pci_probe+0xf8/0x14e
> [ 2.554467] ? _raw_spin_unlock_irqrestore+0x12/0x2c
> [ 2.554467] pci_device_probe+0xaa/0x142
> [ 2.554467] really_probe+0x13f/0x2f4
> [ 2.554467] __driver_probe_device+0x9e/0xd3
> [ 2.554467] driver_probe_device+0x24/0x7c
> [ 2.554467] __driver_attach+0xba/0xcf
> [ 2.554467] ? driver_attach+0x1f/0x1f
> [ 2.554467] bus_for_each_dev+0x8c/0xc0
> [ 2.554467] bus_add_driver+0x11b/0x1f7
> [ 2.554467] driver_register+0x60/0xea
> [ 2.554467] ? mipi_dsi_bus_init+0x16/0x16
> [ 2.554467] i915_init+0x2c/0xb9
> [ 2.554467] ? mipi_dsi_bus_init+0x16/0x16
> [ 2.554467] do_one_initcall+0x12e/0x2b3
> [ 2.554467] do_initcall_level+0xd6/0xf3
> [ 2.554467] do_initcalls+0x4e/0x79
> [ 2.554467] kernel_init_freeable+0xed/0x14d
> [ 2.554467] ? rest_init+0xc1/0xc1
> [ 2.554467] kernel_init+0x1a/0x120
> [ 2.554467] ret_from_fork+0x1f/0x30
> [ 2.554467] </TASK>
> ...
> Kernel panic - not syncing: Fatal exception
>
> Fixes: c64a9a7c05be ("drm/i915: Update memory bandwidth formulae")
> Signed-off-by: Łukasz Bartosik <lb@semihalf.com>
> ---
> drivers/gpu/drm/i915/display/intel_bw.c | 16 +++++++++-------
> 1 file changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
> index 2da4aacc956b..bd0ed68b7faa 100644
> --- a/drivers/gpu/drm/i915/display/intel_bw.c
> +++ b/drivers/gpu/drm/i915/display/intel_bw.c
> @@ -404,15 +404,17 @@ static int tgl_get_bw_info(struct drm_i915_private *dev_priv, const struct intel
> int clpchgroup;
> int j;
>
> - if (i < num_groups - 1)
> - bi_next = &dev_priv->max_bw[i + 1];
> -
> clpchgroup = (sa->deburst * qi.deinterleave / num_channels) << i;
>
> - if (i < num_groups - 1 && clpchgroup < clperchgroup)
> - bi_next->num_planes = (ipqdepth - clpchgroup) / clpchgroup + 1;
> - else
> - bi_next->num_planes = 0;
> + if (i < num_groups - 1) {
> + bi_next = &dev_priv->max_bw[i + 1];
> +
> + if (clpchgroup < clperchgroup)
> + bi_next->num_planes = (ipqdepth - clpchgroup) /
> + clpchgroup + 1;
> + else
> + bi_next->num_planes = 0;
> + }
>
> bi->num_qgv_points = qi.num_points;
> bi->num_psf_gv_points = qi.num_psf_points;
> --
> 2.35.0.rc2.247.g8bbb082509-goog
>
>
Was this patch ever applied or was the issue fixed in a different way?
If CONFIG_INIT_STACK_ALL_ZERO is enabled (it is on by default when the
compiler supports it), bi_next will be deterministically initialized to
NULL, which means 'bi_next->num_planes = 0' will crash when the first if
statement is not taken (i.e. 'i > num_groups - 1'). This was reported to
us at [1] so it impacts real users (and I have been applying this change
locally for six months). I see some discussion in this thread, was it
ever resolved?
[1]: https://github.com/ClangBuiltLinux/linux/issues/1626
Cheers,
Nathan
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [Intel-gfx] [PATCH v1] drm/i915: fix null pointer dereference
@ 2022-08-22 20:33 ` Nathan Chancellor
0 siblings, 0 replies; 25+ messages in thread
From: Nathan Chancellor @ 2022-08-22 20:33 UTC (permalink / raw)
To: Lukasz Bartosik; +Cc: llvm, upstream, intel-gfx, Rodrigo Vivi
Hi all,
Apologies in advance if you see this twice. I did not see the original
make it to either lore.kernel.org or the freedesktop.org archives so I
figured it might have been sent into the void.
On Tue, Feb 01, 2022 at 04:33:54PM +0100, Lukasz Bartosik wrote:
> From: Łukasz Bartosik <lb@semihalf.com>
>
> Asus chromebook CX550 crashes during boot on v5.17-rc1 kernel.
> The root cause is null pointer defeference of bi_next
> in tgl_get_bw_info() in drivers/gpu/drm/i915/display/intel_bw.c.
>
> BUG: kernel NULL pointer dereference, address: 000000000000002e
> PGD 0 P4D 0
> Oops: 0002 [#1] PREEMPT SMP NOPTI
> CPU: 0 PID: 1 Comm: swapper/0 Tainted: G U 5.17.0-rc1
> Hardware name: Google Delbin/Delbin, BIOS Google_Delbin.13672.156.3 05/14/2021
> RIP: 0010:tgl_get_bw_info+0x2de/0x510
> ...
> [ 2.554467] Call Trace:
> [ 2.554467] <TASK>
> [ 2.554467] intel_bw_init_hw+0x14a/0x434
> [ 2.554467] ? _printk+0x59/0x73
> [ 2.554467] ? _dev_err+0x77/0x91
> [ 2.554467] i915_driver_hw_probe+0x329/0x33e
> [ 2.554467] i915_driver_probe+0x4c8/0x638
> [ 2.554467] i915_pci_probe+0xf8/0x14e
> [ 2.554467] ? _raw_spin_unlock_irqrestore+0x12/0x2c
> [ 2.554467] pci_device_probe+0xaa/0x142
> [ 2.554467] really_probe+0x13f/0x2f4
> [ 2.554467] __driver_probe_device+0x9e/0xd3
> [ 2.554467] driver_probe_device+0x24/0x7c
> [ 2.554467] __driver_attach+0xba/0xcf
> [ 2.554467] ? driver_attach+0x1f/0x1f
> [ 2.554467] bus_for_each_dev+0x8c/0xc0
> [ 2.554467] bus_add_driver+0x11b/0x1f7
> [ 2.554467] driver_register+0x60/0xea
> [ 2.554467] ? mipi_dsi_bus_init+0x16/0x16
> [ 2.554467] i915_init+0x2c/0xb9
> [ 2.554467] ? mipi_dsi_bus_init+0x16/0x16
> [ 2.554467] do_one_initcall+0x12e/0x2b3
> [ 2.554467] do_initcall_level+0xd6/0xf3
> [ 2.554467] do_initcalls+0x4e/0x79
> [ 2.554467] kernel_init_freeable+0xed/0x14d
> [ 2.554467] ? rest_init+0xc1/0xc1
> [ 2.554467] kernel_init+0x1a/0x120
> [ 2.554467] ret_from_fork+0x1f/0x30
> [ 2.554467] </TASK>
> ...
> Kernel panic - not syncing: Fatal exception
>
> Fixes: c64a9a7c05be ("drm/i915: Update memory bandwidth formulae")
> Signed-off-by: Łukasz Bartosik <lb@semihalf.com>
> ---
> drivers/gpu/drm/i915/display/intel_bw.c | 16 +++++++++-------
> 1 file changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
> index 2da4aacc956b..bd0ed68b7faa 100644
> --- a/drivers/gpu/drm/i915/display/intel_bw.c
> +++ b/drivers/gpu/drm/i915/display/intel_bw.c
> @@ -404,15 +404,17 @@ static int tgl_get_bw_info(struct drm_i915_private *dev_priv, const struct intel
> int clpchgroup;
> int j;
>
> - if (i < num_groups - 1)
> - bi_next = &dev_priv->max_bw[i + 1];
> -
> clpchgroup = (sa->deburst * qi.deinterleave / num_channels) << i;
>
> - if (i < num_groups - 1 && clpchgroup < clperchgroup)
> - bi_next->num_planes = (ipqdepth - clpchgroup) / clpchgroup + 1;
> - else
> - bi_next->num_planes = 0;
> + if (i < num_groups - 1) {
> + bi_next = &dev_priv->max_bw[i + 1];
> +
> + if (clpchgroup < clperchgroup)
> + bi_next->num_planes = (ipqdepth - clpchgroup) /
> + clpchgroup + 1;
> + else
> + bi_next->num_planes = 0;
> + }
>
> bi->num_qgv_points = qi.num_points;
> bi->num_psf_gv_points = qi.num_psf_points;
> --
> 2.35.0.rc2.247.g8bbb082509-goog
>
>
Was this patch ever applied or was the issue fixed in a different way?
If CONFIG_INIT_STACK_ALL_ZERO is enabled (it is on by default when the
compiler supports it), bi_next will be deterministically initialized to
NULL, which means 'bi_next->num_planes = 0' will crash when the first if
statement is not taken (i.e. 'i > num_groups - 1'). This was reported to
us at [1] so it impacts real users (and I have been applying this change
locally for six months). I see some discussion in this thread, was it
ever resolved?
[1]: https://github.com/ClangBuiltLinux/linux/issues/1626
Cheers,
Nathan
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [Intel-gfx] [PATCH v1] drm/i915: fix null pointer dereference
2022-08-22 20:33 ` Nathan Chancellor
(?)
@ 2022-08-23 7:47 ` Łukasz Bartosik
-1 siblings, 0 replies; 25+ messages in thread
From: Łukasz Bartosik @ 2022-08-23 7:47 UTC (permalink / raw)
To: linux-kernel, dri-devel, Nathan Chancellor, keescook
Cc: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin,
intel-gfx, upstream, llvm
>
> Hi all,
>
> Apologies in advance if you see this twice. I did not see the original
> make it to either lore.kernel.org or the freedesktop.org archives so I
> figured it might have been sent into the void.
>
> On Tue, Feb 01, 2022 at 04:33:54PM +0100, Lukasz Bartosik wrote:
> > From: Łukasz Bartosik <lb@semihalf.com>
> >
> > Asus chromebook CX550 crashes during boot on v5.17-rc1 kernel.
> > The root cause is null pointer defeference of bi_next
> > in tgl_get_bw_info() in drivers/gpu/drm/i915/display/intel_bw.c.
> >
> > BUG: kernel NULL pointer dereference, address: 000000000000002e
> > PGD 0 P4D 0
> > Oops: 0002 [#1] PREEMPT SMP NOPTI
> > CPU: 0 PID: 1 Comm: swapper/0 Tainted: G U 5.17.0-rc1
> > Hardware name: Google Delbin/Delbin, BIOS Google_Delbin.13672.156.3 05/14/2021
> > RIP: 0010:tgl_get_bw_info+0x2de/0x510
> > ...
> > [ 2.554467] Call Trace:
> > [ 2.554467] <TASK>
> > [ 2.554467] intel_bw_init_hw+0x14a/0x434
> > [ 2.554467] ? _printk+0x59/0x73
> > [ 2.554467] ? _dev_err+0x77/0x91
> > [ 2.554467] i915_driver_hw_probe+0x329/0x33e
> > [ 2.554467] i915_driver_probe+0x4c8/0x638
> > [ 2.554467] i915_pci_probe+0xf8/0x14e
> > [ 2.554467] ? _raw_spin_unlock_irqrestore+0x12/0x2c
> > [ 2.554467] pci_device_probe+0xaa/0x142
> > [ 2.554467] really_probe+0x13f/0x2f4
> > [ 2.554467] __driver_probe_device+0x9e/0xd3
> > [ 2.554467] driver_probe_device+0x24/0x7c
> > [ 2.554467] __driver_attach+0xba/0xcf
> > [ 2.554467] ? driver_attach+0x1f/0x1f
> > [ 2.554467] bus_for_each_dev+0x8c/0xc0
> > [ 2.554467] bus_add_driver+0x11b/0x1f7
> > [ 2.554467] driver_register+0x60/0xea
> > [ 2.554467] ? mipi_dsi_bus_init+0x16/0x16
> > [ 2.554467] i915_init+0x2c/0xb9
> > [ 2.554467] ? mipi_dsi_bus_init+0x16/0x16
> > [ 2.554467] do_one_initcall+0x12e/0x2b3
> > [ 2.554467] do_initcall_level+0xd6/0xf3
> > [ 2.554467] do_initcalls+0x4e/0x79
> > [ 2.554467] kernel_init_freeable+0xed/0x14d
> > [ 2.554467] ? rest_init+0xc1/0xc1
> > [ 2.554467] kernel_init+0x1a/0x120
> > [ 2.554467] ret_from_fork+0x1f/0x30
> > [ 2.554467] </TASK>
> > ...
> > Kernel panic - not syncing: Fatal exception
> >
> > Fixes: c64a9a7c05be ("drm/i915: Update memory bandwidth formulae")
> > Signed-off-by: Łukasz Bartosik <lb@semihalf.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_bw.c | 16 +++++++++-------
> > 1 file changed, 9 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
> > index 2da4aacc956b..bd0ed68b7faa 100644
> > --- a/drivers/gpu/drm/i915/display/intel_bw.c
> > +++ b/drivers/gpu/drm/i915/display/intel_bw.c
> > @@ -404,15 +404,17 @@ static int tgl_get_bw_info(struct drm_i915_private *dev_priv, const struct intel
> > int clpchgroup;
> > int j;
> >
> > - if (i < num_groups - 1)
> > - bi_next = &dev_priv->max_bw[i + 1];
> > -
> > clpchgroup = (sa->deburst * qi.deinterleave / num_channels) << i;
> >
> > - if (i < num_groups - 1 && clpchgroup < clperchgroup)
> > - bi_next->num_planes = (ipqdepth - clpchgroup) / clpchgroup + 1;
> > - else
> > - bi_next->num_planes = 0;
> > + if (i < num_groups - 1) {
> > + bi_next = &dev_priv->max_bw[i + 1];
> > +
> > + if (clpchgroup < clperchgroup)
> > + bi_next->num_planes = (ipqdepth - clpchgroup) /
> > + clpchgroup + 1;
> > + else
> > + bi_next->num_planes = 0;
> > + }
> >
> > bi->num_qgv_points = qi.num_points;
> > bi->num_psf_gv_points = qi.num_psf_points;
> > --
> > 2.35.0.rc2.247.g8bbb082509-goog
> >
> >
>
> Was this patch ever applied or was the issue fixed in a different way?
> If CONFIG_INIT_STACK_ALL_ZERO is enabled (it is on by default when the
> compiler supports it), bi_next will be deterministically initialized to
> NULL, which means 'bi_next->num_planes = 0' will crash when the first if
> statement is not taken (i.e. 'i > num_groups - 1'). This was reported to
> us at [1] so it impacts real users (and I have been applying this change
> locally for six months). I see some discussion in this thread, was it
> ever resolved?
>
> [1]: https://github.com/ClangBuiltLinux/linux/issues/1626
>
> Cheers,
> Nathan
The patch was not accepted by upstream. I gave up after sending two reminders
that the issue is still present which resulted in no upstream reaction.
I have been also applying that patch locally for a few months.
Thanks for bringing it up to upstream attention again.
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [Intel-gfx] [PATCH v1] drm/i915: fix null pointer dereference
@ 2022-08-23 7:47 ` Łukasz Bartosik
0 siblings, 0 replies; 25+ messages in thread
From: Łukasz Bartosik @ 2022-08-23 7:47 UTC (permalink / raw)
To: linux-kernel, dri-devel, Nathan Chancellor, keescook
Cc: llvm, upstream, intel-gfx, Rodrigo Vivi
>
> Hi all,
>
> Apologies in advance if you see this twice. I did not see the original
> make it to either lore.kernel.org or the freedesktop.org archives so I
> figured it might have been sent into the void.
>
> On Tue, Feb 01, 2022 at 04:33:54PM +0100, Lukasz Bartosik wrote:
> > From: Łukasz Bartosik <lb@semihalf.com>
> >
> > Asus chromebook CX550 crashes during boot on v5.17-rc1 kernel.
> > The root cause is null pointer defeference of bi_next
> > in tgl_get_bw_info() in drivers/gpu/drm/i915/display/intel_bw.c.
> >
> > BUG: kernel NULL pointer dereference, address: 000000000000002e
> > PGD 0 P4D 0
> > Oops: 0002 [#1] PREEMPT SMP NOPTI
> > CPU: 0 PID: 1 Comm: swapper/0 Tainted: G U 5.17.0-rc1
> > Hardware name: Google Delbin/Delbin, BIOS Google_Delbin.13672.156.3 05/14/2021
> > RIP: 0010:tgl_get_bw_info+0x2de/0x510
> > ...
> > [ 2.554467] Call Trace:
> > [ 2.554467] <TASK>
> > [ 2.554467] intel_bw_init_hw+0x14a/0x434
> > [ 2.554467] ? _printk+0x59/0x73
> > [ 2.554467] ? _dev_err+0x77/0x91
> > [ 2.554467] i915_driver_hw_probe+0x329/0x33e
> > [ 2.554467] i915_driver_probe+0x4c8/0x638
> > [ 2.554467] i915_pci_probe+0xf8/0x14e
> > [ 2.554467] ? _raw_spin_unlock_irqrestore+0x12/0x2c
> > [ 2.554467] pci_device_probe+0xaa/0x142
> > [ 2.554467] really_probe+0x13f/0x2f4
> > [ 2.554467] __driver_probe_device+0x9e/0xd3
> > [ 2.554467] driver_probe_device+0x24/0x7c
> > [ 2.554467] __driver_attach+0xba/0xcf
> > [ 2.554467] ? driver_attach+0x1f/0x1f
> > [ 2.554467] bus_for_each_dev+0x8c/0xc0
> > [ 2.554467] bus_add_driver+0x11b/0x1f7
> > [ 2.554467] driver_register+0x60/0xea
> > [ 2.554467] ? mipi_dsi_bus_init+0x16/0x16
> > [ 2.554467] i915_init+0x2c/0xb9
> > [ 2.554467] ? mipi_dsi_bus_init+0x16/0x16
> > [ 2.554467] do_one_initcall+0x12e/0x2b3
> > [ 2.554467] do_initcall_level+0xd6/0xf3
> > [ 2.554467] do_initcalls+0x4e/0x79
> > [ 2.554467] kernel_init_freeable+0xed/0x14d
> > [ 2.554467] ? rest_init+0xc1/0xc1
> > [ 2.554467] kernel_init+0x1a/0x120
> > [ 2.554467] ret_from_fork+0x1f/0x30
> > [ 2.554467] </TASK>
> > ...
> > Kernel panic - not syncing: Fatal exception
> >
> > Fixes: c64a9a7c05be ("drm/i915: Update memory bandwidth formulae")
> > Signed-off-by: Łukasz Bartosik <lb@semihalf.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_bw.c | 16 +++++++++-------
> > 1 file changed, 9 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
> > index 2da4aacc956b..bd0ed68b7faa 100644
> > --- a/drivers/gpu/drm/i915/display/intel_bw.c
> > +++ b/drivers/gpu/drm/i915/display/intel_bw.c
> > @@ -404,15 +404,17 @@ static int tgl_get_bw_info(struct drm_i915_private *dev_priv, const struct intel
> > int clpchgroup;
> > int j;
> >
> > - if (i < num_groups - 1)
> > - bi_next = &dev_priv->max_bw[i + 1];
> > -
> > clpchgroup = (sa->deburst * qi.deinterleave / num_channels) << i;
> >
> > - if (i < num_groups - 1 && clpchgroup < clperchgroup)
> > - bi_next->num_planes = (ipqdepth - clpchgroup) / clpchgroup + 1;
> > - else
> > - bi_next->num_planes = 0;
> > + if (i < num_groups - 1) {
> > + bi_next = &dev_priv->max_bw[i + 1];
> > +
> > + if (clpchgroup < clperchgroup)
> > + bi_next->num_planes = (ipqdepth - clpchgroup) /
> > + clpchgroup + 1;
> > + else
> > + bi_next->num_planes = 0;
> > + }
> >
> > bi->num_qgv_points = qi.num_points;
> > bi->num_psf_gv_points = qi.num_psf_points;
> > --
> > 2.35.0.rc2.247.g8bbb082509-goog
> >
> >
>
> Was this patch ever applied or was the issue fixed in a different way?
> If CONFIG_INIT_STACK_ALL_ZERO is enabled (it is on by default when the
> compiler supports it), bi_next will be deterministically initialized to
> NULL, which means 'bi_next->num_planes = 0' will crash when the first if
> statement is not taken (i.e. 'i > num_groups - 1'). This was reported to
> us at [1] so it impacts real users (and I have been applying this change
> locally for six months). I see some discussion in this thread, was it
> ever resolved?
>
> [1]: https://github.com/ClangBuiltLinux/linux/issues/1626
>
> Cheers,
> Nathan
The patch was not accepted by upstream. I gave up after sending two reminders
that the issue is still present which resulted in no upstream reaction.
I have been also applying that patch locally for a few months.
Thanks for bringing it up to upstream attention again.
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [Intel-gfx] [PATCH v1] drm/i915: fix null pointer dereference
@ 2022-08-23 7:47 ` Łukasz Bartosik
0 siblings, 0 replies; 25+ messages in thread
From: Łukasz Bartosik @ 2022-08-23 7:47 UTC (permalink / raw)
To: linux-kernel, dri-devel, Nathan Chancellor, keescook
Cc: Tvrtko Ursulin, llvm, upstream, intel-gfx, Rodrigo Vivi
>
> Hi all,
>
> Apologies in advance if you see this twice. I did not see the original
> make it to either lore.kernel.org or the freedesktop.org archives so I
> figured it might have been sent into the void.
>
> On Tue, Feb 01, 2022 at 04:33:54PM +0100, Lukasz Bartosik wrote:
> > From: Łukasz Bartosik <lb@semihalf.com>
> >
> > Asus chromebook CX550 crashes during boot on v5.17-rc1 kernel.
> > The root cause is null pointer defeference of bi_next
> > in tgl_get_bw_info() in drivers/gpu/drm/i915/display/intel_bw.c.
> >
> > BUG: kernel NULL pointer dereference, address: 000000000000002e
> > PGD 0 P4D 0
> > Oops: 0002 [#1] PREEMPT SMP NOPTI
> > CPU: 0 PID: 1 Comm: swapper/0 Tainted: G U 5.17.0-rc1
> > Hardware name: Google Delbin/Delbin, BIOS Google_Delbin.13672.156.3 05/14/2021
> > RIP: 0010:tgl_get_bw_info+0x2de/0x510
> > ...
> > [ 2.554467] Call Trace:
> > [ 2.554467] <TASK>
> > [ 2.554467] intel_bw_init_hw+0x14a/0x434
> > [ 2.554467] ? _printk+0x59/0x73
> > [ 2.554467] ? _dev_err+0x77/0x91
> > [ 2.554467] i915_driver_hw_probe+0x329/0x33e
> > [ 2.554467] i915_driver_probe+0x4c8/0x638
> > [ 2.554467] i915_pci_probe+0xf8/0x14e
> > [ 2.554467] ? _raw_spin_unlock_irqrestore+0x12/0x2c
> > [ 2.554467] pci_device_probe+0xaa/0x142
> > [ 2.554467] really_probe+0x13f/0x2f4
> > [ 2.554467] __driver_probe_device+0x9e/0xd3
> > [ 2.554467] driver_probe_device+0x24/0x7c
> > [ 2.554467] __driver_attach+0xba/0xcf
> > [ 2.554467] ? driver_attach+0x1f/0x1f
> > [ 2.554467] bus_for_each_dev+0x8c/0xc0
> > [ 2.554467] bus_add_driver+0x11b/0x1f7
> > [ 2.554467] driver_register+0x60/0xea
> > [ 2.554467] ? mipi_dsi_bus_init+0x16/0x16
> > [ 2.554467] i915_init+0x2c/0xb9
> > [ 2.554467] ? mipi_dsi_bus_init+0x16/0x16
> > [ 2.554467] do_one_initcall+0x12e/0x2b3
> > [ 2.554467] do_initcall_level+0xd6/0xf3
> > [ 2.554467] do_initcalls+0x4e/0x79
> > [ 2.554467] kernel_init_freeable+0xed/0x14d
> > [ 2.554467] ? rest_init+0xc1/0xc1
> > [ 2.554467] kernel_init+0x1a/0x120
> > [ 2.554467] ret_from_fork+0x1f/0x30
> > [ 2.554467] </TASK>
> > ...
> > Kernel panic - not syncing: Fatal exception
> >
> > Fixes: c64a9a7c05be ("drm/i915: Update memory bandwidth formulae")
> > Signed-off-by: Łukasz Bartosik <lb@semihalf.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_bw.c | 16 +++++++++-------
> > 1 file changed, 9 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
> > index 2da4aacc956b..bd0ed68b7faa 100644
> > --- a/drivers/gpu/drm/i915/display/intel_bw.c
> > +++ b/drivers/gpu/drm/i915/display/intel_bw.c
> > @@ -404,15 +404,17 @@ static int tgl_get_bw_info(struct drm_i915_private *dev_priv, const struct intel
> > int clpchgroup;
> > int j;
> >
> > - if (i < num_groups - 1)
> > - bi_next = &dev_priv->max_bw[i + 1];
> > -
> > clpchgroup = (sa->deburst * qi.deinterleave / num_channels) << i;
> >
> > - if (i < num_groups - 1 && clpchgroup < clperchgroup)
> > - bi_next->num_planes = (ipqdepth - clpchgroup) / clpchgroup + 1;
> > - else
> > - bi_next->num_planes = 0;
> > + if (i < num_groups - 1) {
> > + bi_next = &dev_priv->max_bw[i + 1];
> > +
> > + if (clpchgroup < clperchgroup)
> > + bi_next->num_planes = (ipqdepth - clpchgroup) /
> > + clpchgroup + 1;
> > + else
> > + bi_next->num_planes = 0;
> > + }
> >
> > bi->num_qgv_points = qi.num_points;
> > bi->num_psf_gv_points = qi.num_psf_points;
> > --
> > 2.35.0.rc2.247.g8bbb082509-goog
> >
> >
>
> Was this patch ever applied or was the issue fixed in a different way?
> If CONFIG_INIT_STACK_ALL_ZERO is enabled (it is on by default when the
> compiler supports it), bi_next will be deterministically initialized to
> NULL, which means 'bi_next->num_planes = 0' will crash when the first if
> statement is not taken (i.e. 'i > num_groups - 1'). This was reported to
> us at [1] so it impacts real users (and I have been applying this change
> locally for six months). I see some discussion in this thread, was it
> ever resolved?
>
> [1]: https://github.com/ClangBuiltLinux/linux/issues/1626
>
> Cheers,
> Nathan
The patch was not accepted by upstream. I gave up after sending two reminders
that the issue is still present which resulted in no upstream reaction.
I have been also applying that patch locally for a few months.
Thanks for bringing it up to upstream attention again.
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [Intel-gfx] [PATCH v1] drm/i915: fix null pointer dereference
2022-08-23 7:47 ` Łukasz Bartosik
(?)
@ 2022-08-25 7:37 ` Jani Nikula
-1 siblings, 0 replies; 25+ messages in thread
From: Jani Nikula @ 2022-08-25 7:37 UTC (permalink / raw)
To: Łukasz Bartosik, linux-kernel, dri-devel, Nathan Chancellor,
keescook
Cc: Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin, intel-gfx,
upstream, llvm, Sripada, Radhakrishna, Ville Syrjälä,
Matt Roper, Anusha Srivatsa
On Tue, 23 Aug 2022, Łukasz Bartosik <lb@semihalf.com> wrote:
>>
>> Hi all,
>>
>> Apologies in advance if you see this twice. I did not see the original
>> make it to either lore.kernel.org or the freedesktop.org archives so I
>> figured it might have been sent into the void.
>>
>> On Tue, Feb 01, 2022 at 04:33:54PM +0100, Lukasz Bartosik wrote:
>> > From: Łukasz Bartosik <lb@semihalf.com>
>> >
>> > Asus chromebook CX550 crashes during boot on v5.17-rc1 kernel.
>> > The root cause is null pointer defeference of bi_next
>> > in tgl_get_bw_info() in drivers/gpu/drm/i915/display/intel_bw.c.
>> >
>> > BUG: kernel NULL pointer dereference, address: 000000000000002e
>> > PGD 0 P4D 0
>> > Oops: 0002 [#1] PREEMPT SMP NOPTI
>> > CPU: 0 PID: 1 Comm: swapper/0 Tainted: G U 5.17.0-rc1
>> > Hardware name: Google Delbin/Delbin, BIOS Google_Delbin.13672.156.3 05/14/2021
>> > RIP: 0010:tgl_get_bw_info+0x2de/0x510
>> > ...
>> > [ 2.554467] Call Trace:
>> > [ 2.554467] <TASK>
>> > [ 2.554467] intel_bw_init_hw+0x14a/0x434
>> > [ 2.554467] ? _printk+0x59/0x73
>> > [ 2.554467] ? _dev_err+0x77/0x91
>> > [ 2.554467] i915_driver_hw_probe+0x329/0x33e
>> > [ 2.554467] i915_driver_probe+0x4c8/0x638
>> > [ 2.554467] i915_pci_probe+0xf8/0x14e
>> > [ 2.554467] ? _raw_spin_unlock_irqrestore+0x12/0x2c
>> > [ 2.554467] pci_device_probe+0xaa/0x142
>> > [ 2.554467] really_probe+0x13f/0x2f4
>> > [ 2.554467] __driver_probe_device+0x9e/0xd3
>> > [ 2.554467] driver_probe_device+0x24/0x7c
>> > [ 2.554467] __driver_attach+0xba/0xcf
>> > [ 2.554467] ? driver_attach+0x1f/0x1f
>> > [ 2.554467] bus_for_each_dev+0x8c/0xc0
>> > [ 2.554467] bus_add_driver+0x11b/0x1f7
>> > [ 2.554467] driver_register+0x60/0xea
>> > [ 2.554467] ? mipi_dsi_bus_init+0x16/0x16
>> > [ 2.554467] i915_init+0x2c/0xb9
>> > [ 2.554467] ? mipi_dsi_bus_init+0x16/0x16
>> > [ 2.554467] do_one_initcall+0x12e/0x2b3
>> > [ 2.554467] do_initcall_level+0xd6/0xf3
>> > [ 2.554467] do_initcalls+0x4e/0x79
>> > [ 2.554467] kernel_init_freeable+0xed/0x14d
>> > [ 2.554467] ? rest_init+0xc1/0xc1
>> > [ 2.554467] kernel_init+0x1a/0x120
>> > [ 2.554467] ret_from_fork+0x1f/0x30
>> > [ 2.554467] </TASK>
>> > ...
>> > Kernel panic - not syncing: Fatal exception
>> >
>> > Fixes: c64a9a7c05be ("drm/i915: Update memory bandwidth formulae")
>> > Signed-off-by: Łukasz Bartosik <lb@semihalf.com>
>> > ---
>> > drivers/gpu/drm/i915/display/intel_bw.c | 16 +++++++++-------
>> > 1 file changed, 9 insertions(+), 7 deletions(-)
>> >
>> > diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
>> > index 2da4aacc956b..bd0ed68b7faa 100644
>> > --- a/drivers/gpu/drm/i915/display/intel_bw.c
>> > +++ b/drivers/gpu/drm/i915/display/intel_bw.c
>> > @@ -404,15 +404,17 @@ static int tgl_get_bw_info(struct drm_i915_private *dev_priv, const struct intel
>> > int clpchgroup;
>> > int j;
>> >
>> > - if (i < num_groups - 1)
>> > - bi_next = &dev_priv->max_bw[i + 1];
>> > -
>> > clpchgroup = (sa->deburst * qi.deinterleave / num_channels) << i;
>> >
>> > - if (i < num_groups - 1 && clpchgroup < clperchgroup)
>> > - bi_next->num_planes = (ipqdepth - clpchgroup) / clpchgroup + 1;
>> > - else
>> > - bi_next->num_planes = 0;
>> > + if (i < num_groups - 1) {
>> > + bi_next = &dev_priv->max_bw[i + 1];
>> > +
>> > + if (clpchgroup < clperchgroup)
>> > + bi_next->num_planes = (ipqdepth - clpchgroup) /
>> > + clpchgroup + 1;
>> > + else
>> > + bi_next->num_planes = 0;
>> > + }
>> >
>> > bi->num_qgv_points = qi.num_points;
>> > bi->num_psf_gv_points = qi.num_psf_points;
>> > --
>> > 2.35.0.rc2.247.g8bbb082509-goog
>> >
>> >
>>
>> Was this patch ever applied or was the issue fixed in a different way?
>> If CONFIG_INIT_STACK_ALL_ZERO is enabled (it is on by default when the
>> compiler supports it), bi_next will be deterministically initialized to
>> NULL, which means 'bi_next->num_planes = 0' will crash when the first if
>> statement is not taken (i.e. 'i > num_groups - 1'). This was reported to
>> us at [1] so it impacts real users (and I have been applying this change
>> locally for six months). I see some discussion in this thread, was it
>> ever resolved?
>>
>> [1]: https://github.com/ClangBuiltLinux/linux/issues/1626
>>
>> Cheers,
>> Nathan
>
> The patch was not accepted by upstream. I gave up after sending two reminders
> that the issue is still present which resulted in no upstream reaction.
> I have been also applying that patch locally for a few months.
> Thanks for bringing it up to upstream attention again.
Apologies for us dropping the ball here. There were objections to the
code from Ville [1] but nobody stepped up to clean it up. I think this
was really more about the commit being fixed c64a9a7c05be ("drm/i915:
Update memory bandwidth formulae") than about the patch at hand.
In any case, I've gone ahead and pushed this patch to drm-intel-next
now. With the Fixes tag it should eventually find its way to stable
v5.17+. Thank you for the patch, review - and nagging. ;)
What still remains is cleaning up the code. But that should never have
stalled the fix for months. Sorry again.
BR,
Jani.
[1] https://lore.kernel.org/r/YgOYBfQJF7hIzEPE@intel.com
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [Intel-gfx] [PATCH v1] drm/i915: fix null pointer dereference
@ 2022-08-25 7:37 ` Jani Nikula
0 siblings, 0 replies; 25+ messages in thread
From: Jani Nikula @ 2022-08-25 7:37 UTC (permalink / raw)
To: Łukasz Bartosik, linux-kernel, dri-devel, Nathan Chancellor,
keescook
Cc: llvm, upstream, intel-gfx, Rodrigo Vivi
On Tue, 23 Aug 2022, Łukasz Bartosik <lb@semihalf.com> wrote:
>>
>> Hi all,
>>
>> Apologies in advance if you see this twice. I did not see the original
>> make it to either lore.kernel.org or the freedesktop.org archives so I
>> figured it might have been sent into the void.
>>
>> On Tue, Feb 01, 2022 at 04:33:54PM +0100, Lukasz Bartosik wrote:
>> > From: Łukasz Bartosik <lb@semihalf.com>
>> >
>> > Asus chromebook CX550 crashes during boot on v5.17-rc1 kernel.
>> > The root cause is null pointer defeference of bi_next
>> > in tgl_get_bw_info() in drivers/gpu/drm/i915/display/intel_bw.c.
>> >
>> > BUG: kernel NULL pointer dereference, address: 000000000000002e
>> > PGD 0 P4D 0
>> > Oops: 0002 [#1] PREEMPT SMP NOPTI
>> > CPU: 0 PID: 1 Comm: swapper/0 Tainted: G U 5.17.0-rc1
>> > Hardware name: Google Delbin/Delbin, BIOS Google_Delbin.13672.156.3 05/14/2021
>> > RIP: 0010:tgl_get_bw_info+0x2de/0x510
>> > ...
>> > [ 2.554467] Call Trace:
>> > [ 2.554467] <TASK>
>> > [ 2.554467] intel_bw_init_hw+0x14a/0x434
>> > [ 2.554467] ? _printk+0x59/0x73
>> > [ 2.554467] ? _dev_err+0x77/0x91
>> > [ 2.554467] i915_driver_hw_probe+0x329/0x33e
>> > [ 2.554467] i915_driver_probe+0x4c8/0x638
>> > [ 2.554467] i915_pci_probe+0xf8/0x14e
>> > [ 2.554467] ? _raw_spin_unlock_irqrestore+0x12/0x2c
>> > [ 2.554467] pci_device_probe+0xaa/0x142
>> > [ 2.554467] really_probe+0x13f/0x2f4
>> > [ 2.554467] __driver_probe_device+0x9e/0xd3
>> > [ 2.554467] driver_probe_device+0x24/0x7c
>> > [ 2.554467] __driver_attach+0xba/0xcf
>> > [ 2.554467] ? driver_attach+0x1f/0x1f
>> > [ 2.554467] bus_for_each_dev+0x8c/0xc0
>> > [ 2.554467] bus_add_driver+0x11b/0x1f7
>> > [ 2.554467] driver_register+0x60/0xea
>> > [ 2.554467] ? mipi_dsi_bus_init+0x16/0x16
>> > [ 2.554467] i915_init+0x2c/0xb9
>> > [ 2.554467] ? mipi_dsi_bus_init+0x16/0x16
>> > [ 2.554467] do_one_initcall+0x12e/0x2b3
>> > [ 2.554467] do_initcall_level+0xd6/0xf3
>> > [ 2.554467] do_initcalls+0x4e/0x79
>> > [ 2.554467] kernel_init_freeable+0xed/0x14d
>> > [ 2.554467] ? rest_init+0xc1/0xc1
>> > [ 2.554467] kernel_init+0x1a/0x120
>> > [ 2.554467] ret_from_fork+0x1f/0x30
>> > [ 2.554467] </TASK>
>> > ...
>> > Kernel panic - not syncing: Fatal exception
>> >
>> > Fixes: c64a9a7c05be ("drm/i915: Update memory bandwidth formulae")
>> > Signed-off-by: Łukasz Bartosik <lb@semihalf.com>
>> > ---
>> > drivers/gpu/drm/i915/display/intel_bw.c | 16 +++++++++-------
>> > 1 file changed, 9 insertions(+), 7 deletions(-)
>> >
>> > diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
>> > index 2da4aacc956b..bd0ed68b7faa 100644
>> > --- a/drivers/gpu/drm/i915/display/intel_bw.c
>> > +++ b/drivers/gpu/drm/i915/display/intel_bw.c
>> > @@ -404,15 +404,17 @@ static int tgl_get_bw_info(struct drm_i915_private *dev_priv, const struct intel
>> > int clpchgroup;
>> > int j;
>> >
>> > - if (i < num_groups - 1)
>> > - bi_next = &dev_priv->max_bw[i + 1];
>> > -
>> > clpchgroup = (sa->deburst * qi.deinterleave / num_channels) << i;
>> >
>> > - if (i < num_groups - 1 && clpchgroup < clperchgroup)
>> > - bi_next->num_planes = (ipqdepth - clpchgroup) / clpchgroup + 1;
>> > - else
>> > - bi_next->num_planes = 0;
>> > + if (i < num_groups - 1) {
>> > + bi_next = &dev_priv->max_bw[i + 1];
>> > +
>> > + if (clpchgroup < clperchgroup)
>> > + bi_next->num_planes = (ipqdepth - clpchgroup) /
>> > + clpchgroup + 1;
>> > + else
>> > + bi_next->num_planes = 0;
>> > + }
>> >
>> > bi->num_qgv_points = qi.num_points;
>> > bi->num_psf_gv_points = qi.num_psf_points;
>> > --
>> > 2.35.0.rc2.247.g8bbb082509-goog
>> >
>> >
>>
>> Was this patch ever applied or was the issue fixed in a different way?
>> If CONFIG_INIT_STACK_ALL_ZERO is enabled (it is on by default when the
>> compiler supports it), bi_next will be deterministically initialized to
>> NULL, which means 'bi_next->num_planes = 0' will crash when the first if
>> statement is not taken (i.e. 'i > num_groups - 1'). This was reported to
>> us at [1] so it impacts real users (and I have been applying this change
>> locally for six months). I see some discussion in this thread, was it
>> ever resolved?
>>
>> [1]: https://github.com/ClangBuiltLinux/linux/issues/1626
>>
>> Cheers,
>> Nathan
>
> The patch was not accepted by upstream. I gave up after sending two reminders
> that the issue is still present which resulted in no upstream reaction.
> I have been also applying that patch locally for a few months.
> Thanks for bringing it up to upstream attention again.
Apologies for us dropping the ball here. There were objections to the
code from Ville [1] but nobody stepped up to clean it up. I think this
was really more about the commit being fixed c64a9a7c05be ("drm/i915:
Update memory bandwidth formulae") than about the patch at hand.
In any case, I've gone ahead and pushed this patch to drm-intel-next
now. With the Fixes tag it should eventually find its way to stable
v5.17+. Thank you for the patch, review - and nagging. ;)
What still remains is cleaning up the code. But that should never have
stalled the fix for months. Sorry again.
BR,
Jani.
[1] https://lore.kernel.org/r/YgOYBfQJF7hIzEPE@intel.com
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [Intel-gfx] [PATCH v1] drm/i915: fix null pointer dereference
@ 2022-08-25 7:37 ` Jani Nikula
0 siblings, 0 replies; 25+ messages in thread
From: Jani Nikula @ 2022-08-25 7:37 UTC (permalink / raw)
To: Łukasz Bartosik, linux-kernel, dri-devel, Nathan Chancellor,
keescook
Cc: Tvrtko Ursulin, llvm, upstream, Sripada, Radhakrishna, intel-gfx,
Anusha Srivatsa, Rodrigo Vivi
On Tue, 23 Aug 2022, Łukasz Bartosik <lb@semihalf.com> wrote:
>>
>> Hi all,
>>
>> Apologies in advance if you see this twice. I did not see the original
>> make it to either lore.kernel.org or the freedesktop.org archives so I
>> figured it might have been sent into the void.
>>
>> On Tue, Feb 01, 2022 at 04:33:54PM +0100, Lukasz Bartosik wrote:
>> > From: Łukasz Bartosik <lb@semihalf.com>
>> >
>> > Asus chromebook CX550 crashes during boot on v5.17-rc1 kernel.
>> > The root cause is null pointer defeference of bi_next
>> > in tgl_get_bw_info() in drivers/gpu/drm/i915/display/intel_bw.c.
>> >
>> > BUG: kernel NULL pointer dereference, address: 000000000000002e
>> > PGD 0 P4D 0
>> > Oops: 0002 [#1] PREEMPT SMP NOPTI
>> > CPU: 0 PID: 1 Comm: swapper/0 Tainted: G U 5.17.0-rc1
>> > Hardware name: Google Delbin/Delbin, BIOS Google_Delbin.13672.156.3 05/14/2021
>> > RIP: 0010:tgl_get_bw_info+0x2de/0x510
>> > ...
>> > [ 2.554467] Call Trace:
>> > [ 2.554467] <TASK>
>> > [ 2.554467] intel_bw_init_hw+0x14a/0x434
>> > [ 2.554467] ? _printk+0x59/0x73
>> > [ 2.554467] ? _dev_err+0x77/0x91
>> > [ 2.554467] i915_driver_hw_probe+0x329/0x33e
>> > [ 2.554467] i915_driver_probe+0x4c8/0x638
>> > [ 2.554467] i915_pci_probe+0xf8/0x14e
>> > [ 2.554467] ? _raw_spin_unlock_irqrestore+0x12/0x2c
>> > [ 2.554467] pci_device_probe+0xaa/0x142
>> > [ 2.554467] really_probe+0x13f/0x2f4
>> > [ 2.554467] __driver_probe_device+0x9e/0xd3
>> > [ 2.554467] driver_probe_device+0x24/0x7c
>> > [ 2.554467] __driver_attach+0xba/0xcf
>> > [ 2.554467] ? driver_attach+0x1f/0x1f
>> > [ 2.554467] bus_for_each_dev+0x8c/0xc0
>> > [ 2.554467] bus_add_driver+0x11b/0x1f7
>> > [ 2.554467] driver_register+0x60/0xea
>> > [ 2.554467] ? mipi_dsi_bus_init+0x16/0x16
>> > [ 2.554467] i915_init+0x2c/0xb9
>> > [ 2.554467] ? mipi_dsi_bus_init+0x16/0x16
>> > [ 2.554467] do_one_initcall+0x12e/0x2b3
>> > [ 2.554467] do_initcall_level+0xd6/0xf3
>> > [ 2.554467] do_initcalls+0x4e/0x79
>> > [ 2.554467] kernel_init_freeable+0xed/0x14d
>> > [ 2.554467] ? rest_init+0xc1/0xc1
>> > [ 2.554467] kernel_init+0x1a/0x120
>> > [ 2.554467] ret_from_fork+0x1f/0x30
>> > [ 2.554467] </TASK>
>> > ...
>> > Kernel panic - not syncing: Fatal exception
>> >
>> > Fixes: c64a9a7c05be ("drm/i915: Update memory bandwidth formulae")
>> > Signed-off-by: Łukasz Bartosik <lb@semihalf.com>
>> > ---
>> > drivers/gpu/drm/i915/display/intel_bw.c | 16 +++++++++-------
>> > 1 file changed, 9 insertions(+), 7 deletions(-)
>> >
>> > diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
>> > index 2da4aacc956b..bd0ed68b7faa 100644
>> > --- a/drivers/gpu/drm/i915/display/intel_bw.c
>> > +++ b/drivers/gpu/drm/i915/display/intel_bw.c
>> > @@ -404,15 +404,17 @@ static int tgl_get_bw_info(struct drm_i915_private *dev_priv, const struct intel
>> > int clpchgroup;
>> > int j;
>> >
>> > - if (i < num_groups - 1)
>> > - bi_next = &dev_priv->max_bw[i + 1];
>> > -
>> > clpchgroup = (sa->deburst * qi.deinterleave / num_channels) << i;
>> >
>> > - if (i < num_groups - 1 && clpchgroup < clperchgroup)
>> > - bi_next->num_planes = (ipqdepth - clpchgroup) / clpchgroup + 1;
>> > - else
>> > - bi_next->num_planes = 0;
>> > + if (i < num_groups - 1) {
>> > + bi_next = &dev_priv->max_bw[i + 1];
>> > +
>> > + if (clpchgroup < clperchgroup)
>> > + bi_next->num_planes = (ipqdepth - clpchgroup) /
>> > + clpchgroup + 1;
>> > + else
>> > + bi_next->num_planes = 0;
>> > + }
>> >
>> > bi->num_qgv_points = qi.num_points;
>> > bi->num_psf_gv_points = qi.num_psf_points;
>> > --
>> > 2.35.0.rc2.247.g8bbb082509-goog
>> >
>> >
>>
>> Was this patch ever applied or was the issue fixed in a different way?
>> If CONFIG_INIT_STACK_ALL_ZERO is enabled (it is on by default when the
>> compiler supports it), bi_next will be deterministically initialized to
>> NULL, which means 'bi_next->num_planes = 0' will crash when the first if
>> statement is not taken (i.e. 'i > num_groups - 1'). This was reported to
>> us at [1] so it impacts real users (and I have been applying this change
>> locally for six months). I see some discussion in this thread, was it
>> ever resolved?
>>
>> [1]: https://github.com/ClangBuiltLinux/linux/issues/1626
>>
>> Cheers,
>> Nathan
>
> The patch was not accepted by upstream. I gave up after sending two reminders
> that the issue is still present which resulted in no upstream reaction.
> I have been also applying that patch locally for a few months.
> Thanks for bringing it up to upstream attention again.
Apologies for us dropping the ball here. There were objections to the
code from Ville [1] but nobody stepped up to clean it up. I think this
was really more about the commit being fixed c64a9a7c05be ("drm/i915:
Update memory bandwidth formulae") than about the patch at hand.
In any case, I've gone ahead and pushed this patch to drm-intel-next
now. With the Fixes tag it should eventually find its way to stable
v5.17+. Thank you for the patch, review - and nagging. ;)
What still remains is cleaning up the code. But that should never have
stalled the fix for months. Sorry again.
BR,
Jani.
[1] https://lore.kernel.org/r/YgOYBfQJF7hIzEPE@intel.com
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [Intel-gfx] [PATCH v1] drm/i915: fix null pointer dereference
2022-08-25 7:37 ` Jani Nikula
(?)
@ 2022-08-25 15:38 ` Nathan Chancellor
-1 siblings, 0 replies; 25+ messages in thread
From: Nathan Chancellor @ 2022-08-25 15:38 UTC (permalink / raw)
To: Jani Nikula
Cc: Łukasz Bartosik, linux-kernel, dri-devel, keescook,
Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin, intel-gfx,
upstream, llvm, Sripada, Radhakrishna, Ville Syrjälä,
Matt Roper, Anusha Srivatsa
On Thu, Aug 25, 2022 at 10:37:14AM +0300, Jani Nikula wrote:
> On Tue, 23 Aug 2022, Łukasz Bartosik <lb@semihalf.com> wrote:
> >>
> >> Hi all,
> >>
> >> Apologies in advance if you see this twice. I did not see the original
> >> make it to either lore.kernel.org or the freedesktop.org archives so I
> >> figured it might have been sent into the void.
> >>
> >> On Tue, Feb 01, 2022 at 04:33:54PM +0100, Lukasz Bartosik wrote:
> >> > From: Łukasz Bartosik <lb@semihalf.com>
> >> >
> >> > Asus chromebook CX550 crashes during boot on v5.17-rc1 kernel.
> >> > The root cause is null pointer defeference of bi_next
> >> > in tgl_get_bw_info() in drivers/gpu/drm/i915/display/intel_bw.c.
> >> >
> >> > BUG: kernel NULL pointer dereference, address: 000000000000002e
> >> > PGD 0 P4D 0
> >> > Oops: 0002 [#1] PREEMPT SMP NOPTI
> >> > CPU: 0 PID: 1 Comm: swapper/0 Tainted: G U 5.17.0-rc1
> >> > Hardware name: Google Delbin/Delbin, BIOS Google_Delbin.13672.156.3 05/14/2021
> >> > RIP: 0010:tgl_get_bw_info+0x2de/0x510
> >> > ...
> >> > [ 2.554467] Call Trace:
> >> > [ 2.554467] <TASK>
> >> > [ 2.554467] intel_bw_init_hw+0x14a/0x434
> >> > [ 2.554467] ? _printk+0x59/0x73
> >> > [ 2.554467] ? _dev_err+0x77/0x91
> >> > [ 2.554467] i915_driver_hw_probe+0x329/0x33e
> >> > [ 2.554467] i915_driver_probe+0x4c8/0x638
> >> > [ 2.554467] i915_pci_probe+0xf8/0x14e
> >> > [ 2.554467] ? _raw_spin_unlock_irqrestore+0x12/0x2c
> >> > [ 2.554467] pci_device_probe+0xaa/0x142
> >> > [ 2.554467] really_probe+0x13f/0x2f4
> >> > [ 2.554467] __driver_probe_device+0x9e/0xd3
> >> > [ 2.554467] driver_probe_device+0x24/0x7c
> >> > [ 2.554467] __driver_attach+0xba/0xcf
> >> > [ 2.554467] ? driver_attach+0x1f/0x1f
> >> > [ 2.554467] bus_for_each_dev+0x8c/0xc0
> >> > [ 2.554467] bus_add_driver+0x11b/0x1f7
> >> > [ 2.554467] driver_register+0x60/0xea
> >> > [ 2.554467] ? mipi_dsi_bus_init+0x16/0x16
> >> > [ 2.554467] i915_init+0x2c/0xb9
> >> > [ 2.554467] ? mipi_dsi_bus_init+0x16/0x16
> >> > [ 2.554467] do_one_initcall+0x12e/0x2b3
> >> > [ 2.554467] do_initcall_level+0xd6/0xf3
> >> > [ 2.554467] do_initcalls+0x4e/0x79
> >> > [ 2.554467] kernel_init_freeable+0xed/0x14d
> >> > [ 2.554467] ? rest_init+0xc1/0xc1
> >> > [ 2.554467] kernel_init+0x1a/0x120
> >> > [ 2.554467] ret_from_fork+0x1f/0x30
> >> > [ 2.554467] </TASK>
> >> > ...
> >> > Kernel panic - not syncing: Fatal exception
> >> >
> >> > Fixes: c64a9a7c05be ("drm/i915: Update memory bandwidth formulae")
> >> > Signed-off-by: Łukasz Bartosik <lb@semihalf.com>
> >> > ---
> >> > drivers/gpu/drm/i915/display/intel_bw.c | 16 +++++++++-------
> >> > 1 file changed, 9 insertions(+), 7 deletions(-)
> >> >
> >> > diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
> >> > index 2da4aacc956b..bd0ed68b7faa 100644
> >> > --- a/drivers/gpu/drm/i915/display/intel_bw.c
> >> > +++ b/drivers/gpu/drm/i915/display/intel_bw.c
> >> > @@ -404,15 +404,17 @@ static int tgl_get_bw_info(struct drm_i915_private *dev_priv, const struct intel
> >> > int clpchgroup;
> >> > int j;
> >> >
> >> > - if (i < num_groups - 1)
> >> > - bi_next = &dev_priv->max_bw[i + 1];
> >> > -
> >> > clpchgroup = (sa->deburst * qi.deinterleave / num_channels) << i;
> >> >
> >> > - if (i < num_groups - 1 && clpchgroup < clperchgroup)
> >> > - bi_next->num_planes = (ipqdepth - clpchgroup) / clpchgroup + 1;
> >> > - else
> >> > - bi_next->num_planes = 0;
> >> > + if (i < num_groups - 1) {
> >> > + bi_next = &dev_priv->max_bw[i + 1];
> >> > +
> >> > + if (clpchgroup < clperchgroup)
> >> > + bi_next->num_planes = (ipqdepth - clpchgroup) /
> >> > + clpchgroup + 1;
> >> > + else
> >> > + bi_next->num_planes = 0;
> >> > + }
> >> >
> >> > bi->num_qgv_points = qi.num_points;
> >> > bi->num_psf_gv_points = qi.num_psf_points;
> >> > --
> >> > 2.35.0.rc2.247.g8bbb082509-goog
> >> >
> >> >
> >>
> >> Was this patch ever applied or was the issue fixed in a different way?
> >> If CONFIG_INIT_STACK_ALL_ZERO is enabled (it is on by default when the
> >> compiler supports it), bi_next will be deterministically initialized to
> >> NULL, which means 'bi_next->num_planes = 0' will crash when the first if
> >> statement is not taken (i.e. 'i > num_groups - 1'). This was reported to
> >> us at [1] so it impacts real users (and I have been applying this change
> >> locally for six months). I see some discussion in this thread, was it
> >> ever resolved?
> >>
> >> [1]: https://github.com/ClangBuiltLinux/linux/issues/1626
> >>
> >> Cheers,
> >> Nathan
> >
> > The patch was not accepted by upstream. I gave up after sending two reminders
> > that the issue is still present which resulted in no upstream reaction.
> > I have been also applying that patch locally for a few months.
> > Thanks for bringing it up to upstream attention again.
>
> Apologies for us dropping the ball here. There were objections to the
> code from Ville [1] but nobody stepped up to clean it up. I think this
> was really more about the commit being fixed c64a9a7c05be ("drm/i915:
> Update memory bandwidth formulae") than about the patch at hand.
>
> In any case, I've gone ahead and pushed this patch to drm-intel-next
> now. With the Fixes tag it should eventually find its way to stable
> v5.17+. Thank you for the patch, review - and nagging. ;)
>
> What still remains is cleaning up the code. But that should never have
> stalled the fix for months. Sorry again.
No worries, better late than never :) Thanks for applying the change!
Cheers,
Nathan
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [Intel-gfx] [PATCH v1] drm/i915: fix null pointer dereference
@ 2022-08-25 15:38 ` Nathan Chancellor
0 siblings, 0 replies; 25+ messages in thread
From: Nathan Chancellor @ 2022-08-25 15:38 UTC (permalink / raw)
To: Jani Nikula
Cc: llvm, upstream, keescook, intel-gfx, linux-kernel, dri-devel,
Rodrigo Vivi, Łukasz Bartosik
On Thu, Aug 25, 2022 at 10:37:14AM +0300, Jani Nikula wrote:
> On Tue, 23 Aug 2022, Łukasz Bartosik <lb@semihalf.com> wrote:
> >>
> >> Hi all,
> >>
> >> Apologies in advance if you see this twice. I did not see the original
> >> make it to either lore.kernel.org or the freedesktop.org archives so I
> >> figured it might have been sent into the void.
> >>
> >> On Tue, Feb 01, 2022 at 04:33:54PM +0100, Lukasz Bartosik wrote:
> >> > From: Łukasz Bartosik <lb@semihalf.com>
> >> >
> >> > Asus chromebook CX550 crashes during boot on v5.17-rc1 kernel.
> >> > The root cause is null pointer defeference of bi_next
> >> > in tgl_get_bw_info() in drivers/gpu/drm/i915/display/intel_bw.c.
> >> >
> >> > BUG: kernel NULL pointer dereference, address: 000000000000002e
> >> > PGD 0 P4D 0
> >> > Oops: 0002 [#1] PREEMPT SMP NOPTI
> >> > CPU: 0 PID: 1 Comm: swapper/0 Tainted: G U 5.17.0-rc1
> >> > Hardware name: Google Delbin/Delbin, BIOS Google_Delbin.13672.156.3 05/14/2021
> >> > RIP: 0010:tgl_get_bw_info+0x2de/0x510
> >> > ...
> >> > [ 2.554467] Call Trace:
> >> > [ 2.554467] <TASK>
> >> > [ 2.554467] intel_bw_init_hw+0x14a/0x434
> >> > [ 2.554467] ? _printk+0x59/0x73
> >> > [ 2.554467] ? _dev_err+0x77/0x91
> >> > [ 2.554467] i915_driver_hw_probe+0x329/0x33e
> >> > [ 2.554467] i915_driver_probe+0x4c8/0x638
> >> > [ 2.554467] i915_pci_probe+0xf8/0x14e
> >> > [ 2.554467] ? _raw_spin_unlock_irqrestore+0x12/0x2c
> >> > [ 2.554467] pci_device_probe+0xaa/0x142
> >> > [ 2.554467] really_probe+0x13f/0x2f4
> >> > [ 2.554467] __driver_probe_device+0x9e/0xd3
> >> > [ 2.554467] driver_probe_device+0x24/0x7c
> >> > [ 2.554467] __driver_attach+0xba/0xcf
> >> > [ 2.554467] ? driver_attach+0x1f/0x1f
> >> > [ 2.554467] bus_for_each_dev+0x8c/0xc0
> >> > [ 2.554467] bus_add_driver+0x11b/0x1f7
> >> > [ 2.554467] driver_register+0x60/0xea
> >> > [ 2.554467] ? mipi_dsi_bus_init+0x16/0x16
> >> > [ 2.554467] i915_init+0x2c/0xb9
> >> > [ 2.554467] ? mipi_dsi_bus_init+0x16/0x16
> >> > [ 2.554467] do_one_initcall+0x12e/0x2b3
> >> > [ 2.554467] do_initcall_level+0xd6/0xf3
> >> > [ 2.554467] do_initcalls+0x4e/0x79
> >> > [ 2.554467] kernel_init_freeable+0xed/0x14d
> >> > [ 2.554467] ? rest_init+0xc1/0xc1
> >> > [ 2.554467] kernel_init+0x1a/0x120
> >> > [ 2.554467] ret_from_fork+0x1f/0x30
> >> > [ 2.554467] </TASK>
> >> > ...
> >> > Kernel panic - not syncing: Fatal exception
> >> >
> >> > Fixes: c64a9a7c05be ("drm/i915: Update memory bandwidth formulae")
> >> > Signed-off-by: Łukasz Bartosik <lb@semihalf.com>
> >> > ---
> >> > drivers/gpu/drm/i915/display/intel_bw.c | 16 +++++++++-------
> >> > 1 file changed, 9 insertions(+), 7 deletions(-)
> >> >
> >> > diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
> >> > index 2da4aacc956b..bd0ed68b7faa 100644
> >> > --- a/drivers/gpu/drm/i915/display/intel_bw.c
> >> > +++ b/drivers/gpu/drm/i915/display/intel_bw.c
> >> > @@ -404,15 +404,17 @@ static int tgl_get_bw_info(struct drm_i915_private *dev_priv, const struct intel
> >> > int clpchgroup;
> >> > int j;
> >> >
> >> > - if (i < num_groups - 1)
> >> > - bi_next = &dev_priv->max_bw[i + 1];
> >> > -
> >> > clpchgroup = (sa->deburst * qi.deinterleave / num_channels) << i;
> >> >
> >> > - if (i < num_groups - 1 && clpchgroup < clperchgroup)
> >> > - bi_next->num_planes = (ipqdepth - clpchgroup) / clpchgroup + 1;
> >> > - else
> >> > - bi_next->num_planes = 0;
> >> > + if (i < num_groups - 1) {
> >> > + bi_next = &dev_priv->max_bw[i + 1];
> >> > +
> >> > + if (clpchgroup < clperchgroup)
> >> > + bi_next->num_planes = (ipqdepth - clpchgroup) /
> >> > + clpchgroup + 1;
> >> > + else
> >> > + bi_next->num_planes = 0;
> >> > + }
> >> >
> >> > bi->num_qgv_points = qi.num_points;
> >> > bi->num_psf_gv_points = qi.num_psf_points;
> >> > --
> >> > 2.35.0.rc2.247.g8bbb082509-goog
> >> >
> >> >
> >>
> >> Was this patch ever applied or was the issue fixed in a different way?
> >> If CONFIG_INIT_STACK_ALL_ZERO is enabled (it is on by default when the
> >> compiler supports it), bi_next will be deterministically initialized to
> >> NULL, which means 'bi_next->num_planes = 0' will crash when the first if
> >> statement is not taken (i.e. 'i > num_groups - 1'). This was reported to
> >> us at [1] so it impacts real users (and I have been applying this change
> >> locally for six months). I see some discussion in this thread, was it
> >> ever resolved?
> >>
> >> [1]: https://github.com/ClangBuiltLinux/linux/issues/1626
> >>
> >> Cheers,
> >> Nathan
> >
> > The patch was not accepted by upstream. I gave up after sending two reminders
> > that the issue is still present which resulted in no upstream reaction.
> > I have been also applying that patch locally for a few months.
> > Thanks for bringing it up to upstream attention again.
>
> Apologies for us dropping the ball here. There were objections to the
> code from Ville [1] but nobody stepped up to clean it up. I think this
> was really more about the commit being fixed c64a9a7c05be ("drm/i915:
> Update memory bandwidth formulae") than about the patch at hand.
>
> In any case, I've gone ahead and pushed this patch to drm-intel-next
> now. With the Fixes tag it should eventually find its way to stable
> v5.17+. Thank you for the patch, review - and nagging. ;)
>
> What still remains is cleaning up the code. But that should never have
> stalled the fix for months. Sorry again.
No worries, better late than never :) Thanks for applying the change!
Cheers,
Nathan
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [Intel-gfx] [PATCH v1] drm/i915: fix null pointer dereference
@ 2022-08-25 15:38 ` Nathan Chancellor
0 siblings, 0 replies; 25+ messages in thread
From: Nathan Chancellor @ 2022-08-25 15:38 UTC (permalink / raw)
To: Jani Nikula
Cc: Tvrtko Ursulin, llvm, upstream, keescook, Sripada, Radhakrishna,
intel-gfx, linux-kernel, dri-devel, Anusha Srivatsa,
Rodrigo Vivi, Łukasz Bartosik
On Thu, Aug 25, 2022 at 10:37:14AM +0300, Jani Nikula wrote:
> On Tue, 23 Aug 2022, Łukasz Bartosik <lb@semihalf.com> wrote:
> >>
> >> Hi all,
> >>
> >> Apologies in advance if you see this twice. I did not see the original
> >> make it to either lore.kernel.org or the freedesktop.org archives so I
> >> figured it might have been sent into the void.
> >>
> >> On Tue, Feb 01, 2022 at 04:33:54PM +0100, Lukasz Bartosik wrote:
> >> > From: Łukasz Bartosik <lb@semihalf.com>
> >> >
> >> > Asus chromebook CX550 crashes during boot on v5.17-rc1 kernel.
> >> > The root cause is null pointer defeference of bi_next
> >> > in tgl_get_bw_info() in drivers/gpu/drm/i915/display/intel_bw.c.
> >> >
> >> > BUG: kernel NULL pointer dereference, address: 000000000000002e
> >> > PGD 0 P4D 0
> >> > Oops: 0002 [#1] PREEMPT SMP NOPTI
> >> > CPU: 0 PID: 1 Comm: swapper/0 Tainted: G U 5.17.0-rc1
> >> > Hardware name: Google Delbin/Delbin, BIOS Google_Delbin.13672.156.3 05/14/2021
> >> > RIP: 0010:tgl_get_bw_info+0x2de/0x510
> >> > ...
> >> > [ 2.554467] Call Trace:
> >> > [ 2.554467] <TASK>
> >> > [ 2.554467] intel_bw_init_hw+0x14a/0x434
> >> > [ 2.554467] ? _printk+0x59/0x73
> >> > [ 2.554467] ? _dev_err+0x77/0x91
> >> > [ 2.554467] i915_driver_hw_probe+0x329/0x33e
> >> > [ 2.554467] i915_driver_probe+0x4c8/0x638
> >> > [ 2.554467] i915_pci_probe+0xf8/0x14e
> >> > [ 2.554467] ? _raw_spin_unlock_irqrestore+0x12/0x2c
> >> > [ 2.554467] pci_device_probe+0xaa/0x142
> >> > [ 2.554467] really_probe+0x13f/0x2f4
> >> > [ 2.554467] __driver_probe_device+0x9e/0xd3
> >> > [ 2.554467] driver_probe_device+0x24/0x7c
> >> > [ 2.554467] __driver_attach+0xba/0xcf
> >> > [ 2.554467] ? driver_attach+0x1f/0x1f
> >> > [ 2.554467] bus_for_each_dev+0x8c/0xc0
> >> > [ 2.554467] bus_add_driver+0x11b/0x1f7
> >> > [ 2.554467] driver_register+0x60/0xea
> >> > [ 2.554467] ? mipi_dsi_bus_init+0x16/0x16
> >> > [ 2.554467] i915_init+0x2c/0xb9
> >> > [ 2.554467] ? mipi_dsi_bus_init+0x16/0x16
> >> > [ 2.554467] do_one_initcall+0x12e/0x2b3
> >> > [ 2.554467] do_initcall_level+0xd6/0xf3
> >> > [ 2.554467] do_initcalls+0x4e/0x79
> >> > [ 2.554467] kernel_init_freeable+0xed/0x14d
> >> > [ 2.554467] ? rest_init+0xc1/0xc1
> >> > [ 2.554467] kernel_init+0x1a/0x120
> >> > [ 2.554467] ret_from_fork+0x1f/0x30
> >> > [ 2.554467] </TASK>
> >> > ...
> >> > Kernel panic - not syncing: Fatal exception
> >> >
> >> > Fixes: c64a9a7c05be ("drm/i915: Update memory bandwidth formulae")
> >> > Signed-off-by: Łukasz Bartosik <lb@semihalf.com>
> >> > ---
> >> > drivers/gpu/drm/i915/display/intel_bw.c | 16 +++++++++-------
> >> > 1 file changed, 9 insertions(+), 7 deletions(-)
> >> >
> >> > diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
> >> > index 2da4aacc956b..bd0ed68b7faa 100644
> >> > --- a/drivers/gpu/drm/i915/display/intel_bw.c
> >> > +++ b/drivers/gpu/drm/i915/display/intel_bw.c
> >> > @@ -404,15 +404,17 @@ static int tgl_get_bw_info(struct drm_i915_private *dev_priv, const struct intel
> >> > int clpchgroup;
> >> > int j;
> >> >
> >> > - if (i < num_groups - 1)
> >> > - bi_next = &dev_priv->max_bw[i + 1];
> >> > -
> >> > clpchgroup = (sa->deburst * qi.deinterleave / num_channels) << i;
> >> >
> >> > - if (i < num_groups - 1 && clpchgroup < clperchgroup)
> >> > - bi_next->num_planes = (ipqdepth - clpchgroup) / clpchgroup + 1;
> >> > - else
> >> > - bi_next->num_planes = 0;
> >> > + if (i < num_groups - 1) {
> >> > + bi_next = &dev_priv->max_bw[i + 1];
> >> > +
> >> > + if (clpchgroup < clperchgroup)
> >> > + bi_next->num_planes = (ipqdepth - clpchgroup) /
> >> > + clpchgroup + 1;
> >> > + else
> >> > + bi_next->num_planes = 0;
> >> > + }
> >> >
> >> > bi->num_qgv_points = qi.num_points;
> >> > bi->num_psf_gv_points = qi.num_psf_points;
> >> > --
> >> > 2.35.0.rc2.247.g8bbb082509-goog
> >> >
> >> >
> >>
> >> Was this patch ever applied or was the issue fixed in a different way?
> >> If CONFIG_INIT_STACK_ALL_ZERO is enabled (it is on by default when the
> >> compiler supports it), bi_next will be deterministically initialized to
> >> NULL, which means 'bi_next->num_planes = 0' will crash when the first if
> >> statement is not taken (i.e. 'i > num_groups - 1'). This was reported to
> >> us at [1] so it impacts real users (and I have been applying this change
> >> locally for six months). I see some discussion in this thread, was it
> >> ever resolved?
> >>
> >> [1]: https://github.com/ClangBuiltLinux/linux/issues/1626
> >>
> >> Cheers,
> >> Nathan
> >
> > The patch was not accepted by upstream. I gave up after sending two reminders
> > that the issue is still present which resulted in no upstream reaction.
> > I have been also applying that patch locally for a few months.
> > Thanks for bringing it up to upstream attention again.
>
> Apologies for us dropping the ball here. There were objections to the
> code from Ville [1] but nobody stepped up to clean it up. I think this
> was really more about the commit being fixed c64a9a7c05be ("drm/i915:
> Update memory bandwidth formulae") than about the patch at hand.
>
> In any case, I've gone ahead and pushed this patch to drm-intel-next
> now. With the Fixes tag it should eventually find its way to stable
> v5.17+. Thank you for the patch, review - and nagging. ;)
>
> What still remains is cleaning up the code. But that should never have
> stalled the fix for months. Sorry again.
No worries, better late than never :) Thanks for applying the change!
Cheers,
Nathan
^ permalink raw reply [flat|nested] 25+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: fix null pointer dereference (rev2)
2022-02-01 15:33 [Intel-gfx] [PATCH v1] drm/i915: fix null pointer dereference Lukasz Bartosik
` (5 preceding siblings ...)
2022-08-22 20:33 ` Nathan Chancellor
@ 2022-08-23 9:27 ` Patchwork
2022-08-23 11:30 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: fix null pointer dereference (rev3) Patchwork
` (2 subsequent siblings)
9 siblings, 0 replies; 25+ messages in thread
From: Patchwork @ 2022-08-23 9:27 UTC (permalink / raw)
To: Łukasz Bartosik; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 19018 bytes --]
== Series Details ==
Series: drm/i915: fix null pointer dereference (rev2)
URL : https://patchwork.freedesktop.org/series/99621/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12014 -> Patchwork_99621v2
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_99621v2 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_99621v2, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/index.html
Participating hosts (30 -> 37)
------------------------------
Additional (7): fi-rkl-11600 bat-dg1-5 bat-dg2-8 bat-adlp-4 bat-rplp-1 bat-rpls-1 bat-dg2-10
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_99621v2:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@requests:
- bat-adlp-4: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/bat-adlp-4/igt@i915_selftest@live@requests.html
#### Warnings ####
* igt@i915_suspend@basic-s3-without-i915:
- fi-kbl-7567u: [INCOMPLETE][2] ([i915#6598]) -> [INCOMPLETE][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12014/fi-kbl-7567u/igt@i915_suspend@basic-s3-without-i915.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/fi-kbl-7567u/igt@i915_suspend@basic-s3-without-i915.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_selftest@live@gt_lrc:
- {bat-dg2-8}: NOTRUN -> [INCOMPLETE][4]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/bat-dg2-8/igt@i915_selftest@live@gt_lrc.html
Known issues
------------
Here are the changes found in Patchwork_99621v2 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@fbdev@info:
- bat-adlp-4: NOTRUN -> [SKIP][5] ([i915#2582]) +4 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/bat-adlp-4/igt@fbdev@info.html
* igt@fbdev@read:
- bat-dg1-5: NOTRUN -> [SKIP][6] ([i915#2582]) +4 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/bat-dg1-5/igt@fbdev@read.html
* igt@gem_huc_copy@huc-copy:
- fi-rkl-11600: NOTRUN -> [SKIP][7] ([i915#2190])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/fi-rkl-11600/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@parallel-random-engines:
- fi-rkl-11600: NOTRUN -> [SKIP][8] ([i915#4613]) +3 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/fi-rkl-11600/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@gem_lmem_swapping@verify-random:
- bat-adlp-4: NOTRUN -> [SKIP][9] ([i915#4613]) +3 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/bat-adlp-4/igt@gem_lmem_swapping@verify-random.html
* igt@gem_mmap@basic:
- bat-dg1-5: NOTRUN -> [SKIP][10] ([i915#4083])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/bat-dg1-5/igt@gem_mmap@basic.html
* igt@gem_tiled_fence_blits@basic:
- bat-dg1-5: NOTRUN -> [SKIP][11] ([i915#4077]) +2 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/bat-dg1-5/igt@gem_tiled_fence_blits@basic.html
* igt@gem_tiled_pread_basic:
- fi-rkl-11600: NOTRUN -> [SKIP][12] ([i915#3282])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/fi-rkl-11600/igt@gem_tiled_pread_basic.html
- bat-dg1-5: NOTRUN -> [SKIP][13] ([i915#4079]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/bat-dg1-5/igt@gem_tiled_pread_basic.html
- bat-adlp-4: NOTRUN -> [SKIP][14] ([i915#3282])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/bat-adlp-4/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- fi-rkl-11600: NOTRUN -> [SKIP][15] ([i915#3012])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/fi-rkl-11600/igt@i915_pm_backlight@basic-brightness.html
- bat-dg1-5: NOTRUN -> [SKIP][16] ([i915#1155])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/bat-dg1-5/igt@i915_pm_backlight@basic-brightness.html
- bat-adlp-4: NOTRUN -> [SKIP][17] ([i915#1155])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/bat-adlp-4/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_pm_rps@basic-api:
- bat-dg1-5: NOTRUN -> [SKIP][18] ([i915#6621])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/bat-dg1-5/igt@i915_pm_rps@basic-api.html
- bat-adlp-4: NOTRUN -> [SKIP][19] ([i915#6621])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/bat-adlp-4/igt@i915_pm_rps@basic-api.html
* igt@i915_suspend@basic-s2idle-without-i915:
- bat-dg1-5: NOTRUN -> [INCOMPLETE][20] ([i915#6011])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/bat-dg1-5/igt@i915_suspend@basic-s2idle-without-i915.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-rkl-11600: NOTRUN -> [INCOMPLETE][21] ([i915#5982])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
- fi-pnv-d510: NOTRUN -> [INCOMPLETE][22] ([i915#6598] / [i915#6601])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/fi-pnv-d510/igt@i915_suspend@basic-s3-without-i915.html
- fi-hsw-4770: NOTRUN -> [INCOMPLETE][23] ([i915#4817] / [i915#6598])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/fi-hsw-4770/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_addfb_basic@basic-x-tiled-legacy:
- bat-dg1-5: NOTRUN -> [SKIP][24] ([i915#4212]) +7 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/bat-dg1-5/igt@kms_addfb_basic@basic-x-tiled-legacy.html
* igt@kms_addfb_basic@basic-y-tiled-legacy:
- bat-dg1-5: NOTRUN -> [SKIP][25] ([i915#4215])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/bat-dg1-5/igt@kms_addfb_basic@basic-y-tiled-legacy.html
* igt@kms_busy@basic:
- bat-dg1-5: NOTRUN -> [SKIP][26] ([i915#1845] / [i915#4303])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/bat-dg1-5/igt@kms_busy@basic.html
* igt@kms_chamelium@dp-crc-fast:
- bat-adlp-4: NOTRUN -> [SKIP][27] ([fdo#111827]) +7 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/bat-adlp-4/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-rkl-11600: NOTRUN -> [SKIP][28] ([fdo#111827]) +7 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/fi-rkl-11600/igt@kms_chamelium@hdmi-hpd-fast.html
- bat-dg1-5: NOTRUN -> [SKIP][29] ([fdo#111827]) +7 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/bat-dg1-5/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor:
- fi-rkl-11600: NOTRUN -> [SKIP][30] ([i915#4103])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/fi-rkl-11600/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html
* igt@kms_flip@basic-plain-flip:
- bat-adlp-4: NOTRUN -> [SKIP][31] ([i915#3637]) +3 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/bat-adlp-4/igt@kms_flip@basic-plain-flip.html
* igt@kms_force_connector_basic@force-load-detect:
- fi-rkl-11600: NOTRUN -> [SKIP][32] ([fdo#109285] / [i915#4098])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/fi-rkl-11600/igt@kms_force_connector_basic@force-load-detect.html
- bat-dg1-5: NOTRUN -> [SKIP][33] ([fdo#109285])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/bat-dg1-5/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_force_connector_basic@prune-stale-modes:
- bat-adlp-4: NOTRUN -> [SKIP][34] ([i915#4093]) +3 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/bat-adlp-4/igt@kms_force_connector_basic@prune-stale-modes.html
* igt@kms_frontbuffer_tracking@basic:
- bat-adlp-4: NOTRUN -> [SKIP][35] ([i915#4342])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/bat-adlp-4/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_pipe_crc_basic@nonblocking-crc:
- bat-dg1-5: NOTRUN -> [SKIP][36] ([i915#4078]) +13 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/bat-dg1-5/igt@kms_pipe_crc_basic@nonblocking-crc.html
* igt@kms_pipe_crc_basic@read-crc:
- bat-adlp-4: NOTRUN -> [SKIP][37] ([i915#3546]) +9 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/bat-adlp-4/igt@kms_pipe_crc_basic@read-crc.html
* igt@kms_psr@sprite_plane_onoff:
- fi-rkl-11600: NOTRUN -> [SKIP][38] ([i915#1072]) +3 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/fi-rkl-11600/igt@kms_psr@sprite_plane_onoff.html
- bat-dg1-5: NOTRUN -> [SKIP][39] ([i915#1072] / [i915#4078]) +3 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/bat-dg1-5/igt@kms_psr@sprite_plane_onoff.html
- bat-adlp-4: NOTRUN -> [SKIP][40] ([i915#1072]) +3 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/bat-adlp-4/igt@kms_psr@sprite_plane_onoff.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-rkl-11600: NOTRUN -> [SKIP][41] ([i915#3555] / [i915#4098])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/fi-rkl-11600/igt@kms_setmode@basic-clone-single-crtc.html
- bat-dg1-5: NOTRUN -> [SKIP][42] ([i915#3555])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/bat-dg1-5/igt@kms_setmode@basic-clone-single-crtc.html
- bat-adlp-4: NOTRUN -> [SKIP][43] ([i915#3555] / [i915#4579])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/bat-adlp-4/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-fence-flip:
- bat-adlp-4: NOTRUN -> [SKIP][44] ([fdo#109295] / [i915#3546] / [i915#3708])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/bat-adlp-4/igt@prime_vgem@basic-fence-flip.html
- bat-dg1-5: NOTRUN -> [SKIP][45] ([i915#1845] / [i915#3708])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/bat-dg1-5/igt@prime_vgem@basic-fence-flip.html
* igt@prime_vgem@basic-fence-read:
- bat-dg1-5: NOTRUN -> [SKIP][46] ([i915#3708]) +2 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/bat-dg1-5/igt@prime_vgem@basic-fence-read.html
* igt@prime_vgem@basic-gtt:
- bat-dg1-5: NOTRUN -> [SKIP][47] ([i915#3708] / [i915#4077]) +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/bat-dg1-5/igt@prime_vgem@basic-gtt.html
* igt@prime_vgem@basic-read:
- fi-rkl-11600: NOTRUN -> [SKIP][48] ([fdo#109295] / [i915#3291] / [i915#3708]) +2 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/fi-rkl-11600/igt@prime_vgem@basic-read.html
* igt@prime_vgem@basic-userptr:
- bat-adlp-4: NOTRUN -> [SKIP][49] ([fdo#109295] / [i915#3301] / [i915#3708])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/bat-adlp-4/igt@prime_vgem@basic-userptr.html
- bat-dg1-5: NOTRUN -> [SKIP][50] ([i915#3708] / [i915#4873])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/bat-dg1-5/igt@prime_vgem@basic-userptr.html
- fi-rkl-11600: NOTRUN -> [SKIP][51] ([fdo#109295] / [i915#3301] / [i915#3708])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/fi-rkl-11600/igt@prime_vgem@basic-userptr.html
* igt@prime_vgem@basic-write:
- bat-adlp-4: NOTRUN -> [SKIP][52] ([fdo#109295] / [i915#3291] / [i915#3708]) +2 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/bat-adlp-4/igt@prime_vgem@basic-write.html
* igt@runner@aborted:
- bat-adlp-4: NOTRUN -> [FAIL][53] ([i915#4312] / [i915#6641])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/bat-adlp-4/igt@runner@aborted.html
- bat-dg1-5: NOTRUN -> [FAIL][54] ([i915#4312] / [i915#5257])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/bat-dg1-5/igt@runner@aborted.html
#### Possible fixes ####
* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [INCOMPLETE][55] ([i915#4785]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12014/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
* igt@i915_selftest@live@requests:
- fi-pnv-d510: [DMESG-FAIL][57] ([i915#4528]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12014/fi-pnv-d510/igt@i915_selftest@live@requests.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/fi-pnv-d510/igt@i915_selftest@live@requests.html
#### Warnings ####
* igt@i915_selftest@live@hangcheck:
- bat-dg1-6: [DMESG-FAIL][59] ([i915#4494] / [i915#4957]) -> [DMESG-FAIL][60] ([i915#4957])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12014/bat-dg1-6/igt@i915_selftest@live@hangcheck.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/bat-dg1-6/igt@i915_selftest@live@hangcheck.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-elk-e7500: [INCOMPLETE][61] ([i915#6648]) -> [INCOMPLETE][62] ([i915#6598] / [i915#6601] / [i915#6648])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12014/fi-elk-e7500/igt@i915_suspend@basic-s3-without-i915.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/fi-elk-e7500/igt@i915_suspend@basic-s3-without-i915.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3595]: https://gitlab.freedesktop.org/drm/intel/issues/3595
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4093]: https://gitlab.freedesktop.org/drm/intel/issues/4093
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4303]: https://gitlab.freedesktop.org/drm/intel/issues/4303
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4342]: https://gitlab.freedesktop.org/drm/intel/issues/4342
[i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5982]: https://gitlab.freedesktop.org/drm/intel/issues/5982
[i915#6011]: https://gitlab.freedesktop.org/drm/intel/issues/6011
[i915#6380]: https://gitlab.freedesktop.org/drm/intel/issues/6380
[i915#6530]: https://gitlab.freedesktop.org/drm/intel/issues/6530
[i915#6598]: https://gitlab.freedesktop.org/drm/intel/issues/6598
[i915#6601]: https://gitlab.freedesktop.org/drm/intel/issues/6601
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6641]: https://gitlab.freedesktop.org/drm/intel/issues/6641
[i915#6642]: https://gitlab.freedesktop.org/drm/intel/issues/6642
[i915#6648]: https://gitlab.freedesktop.org/drm/intel/issues/6648
Build changes
-------------
* Linux: CI_DRM_12014 -> Patchwork_99621v2
CI-20190529: 20190529
CI_DRM_12014: 1de33826aa86910c175ca773bc8f92d5948d094e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6634: e01fe99f00692864b709253638c809231d1fb333 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_99621v2: 1de33826aa86910c175ca773bc8f92d5948d094e @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
87a2a079237e drm/i915: fix null pointer dereference
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v2/index.html
[-- Attachment #2: Type: text/html, Size: 22716 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: fix null pointer dereference (rev3)
2022-02-01 15:33 [Intel-gfx] [PATCH v1] drm/i915: fix null pointer dereference Lukasz Bartosik
` (6 preceding siblings ...)
2022-08-23 9:27 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: fix null pointer dereference (rev2) Patchwork
@ 2022-08-23 11:30 ` Patchwork
2022-08-23 18:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: fix null pointer dereference (rev4) Patchwork
2022-08-24 23:27 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
9 siblings, 0 replies; 25+ messages in thread
From: Patchwork @ 2022-08-23 11:30 UTC (permalink / raw)
To: Łukasz Bartosik; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 17065 bytes --]
== Series Details ==
Series: drm/i915: fix null pointer dereference (rev3)
URL : https://patchwork.freedesktop.org/series/99621/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12014 -> Patchwork_99621v3
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_99621v3 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_99621v3, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/index.html
Participating hosts (30 -> 37)
------------------------------
Additional (8): fi-rkl-11600 bat-dg1-5 bat-dg2-8 bat-adlp-4 bat-jsl-3 bat-rplp-1 bat-rpls-1 bat-dg2-10
Missing (1): fi-hsw-4770
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_99621v3:
### CI changes ###
#### Possible regressions ####
* boot:
- fi-hsw-g3258: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12014/fi-hsw-g3258/boot.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/fi-hsw-g3258/boot.html
Known issues
------------
Here are the changes found in Patchwork_99621v3 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@fbdev@info:
- bat-adlp-4: NOTRUN -> [SKIP][3] ([i915#2582]) +4 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/bat-adlp-4/igt@fbdev@info.html
* igt@fbdev@read:
- bat-dg1-5: NOTRUN -> [SKIP][4] ([i915#2582]) +4 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/bat-dg1-5/igt@fbdev@read.html
* igt@gem_huc_copy@huc-copy:
- fi-rkl-11600: NOTRUN -> [SKIP][5] ([i915#2190])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/fi-rkl-11600/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@parallel-random-engines:
- fi-rkl-11600: NOTRUN -> [SKIP][6] ([i915#4613]) +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/fi-rkl-11600/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@gem_lmem_swapping@verify-random:
- bat-adlp-4: NOTRUN -> [SKIP][7] ([i915#4613]) +3 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/bat-adlp-4/igt@gem_lmem_swapping@verify-random.html
* igt@gem_mmap@basic:
- bat-dg1-5: NOTRUN -> [SKIP][8] ([i915#4083])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/bat-dg1-5/igt@gem_mmap@basic.html
* igt@gem_tiled_fence_blits@basic:
- bat-dg1-5: NOTRUN -> [SKIP][9] ([i915#4077]) +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/bat-dg1-5/igt@gem_tiled_fence_blits@basic.html
* igt@gem_tiled_pread_basic:
- fi-rkl-11600: NOTRUN -> [SKIP][10] ([i915#3282])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/fi-rkl-11600/igt@gem_tiled_pread_basic.html
- bat-dg1-5: NOTRUN -> [SKIP][11] ([i915#4079]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/bat-dg1-5/igt@gem_tiled_pread_basic.html
- bat-adlp-4: NOTRUN -> [SKIP][12] ([i915#3282])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/bat-adlp-4/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- fi-rkl-11600: NOTRUN -> [SKIP][13] ([i915#3012])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/fi-rkl-11600/igt@i915_pm_backlight@basic-brightness.html
- bat-dg1-5: NOTRUN -> [SKIP][14] ([i915#1155])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/bat-dg1-5/igt@i915_pm_backlight@basic-brightness.html
- bat-adlp-4: NOTRUN -> [SKIP][15] ([i915#1155])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/bat-adlp-4/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_pm_rps@basic-api:
- bat-dg1-5: NOTRUN -> [SKIP][16] ([i915#6621])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/bat-dg1-5/igt@i915_pm_rps@basic-api.html
- bat-adlp-4: NOTRUN -> [SKIP][17] ([i915#6621])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/bat-adlp-4/igt@i915_pm_rps@basic-api.html
* igt@i915_selftest@live@gem:
- fi-pnv-d510: NOTRUN -> [DMESG-FAIL][18] ([i915#4528])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/fi-pnv-d510/igt@i915_selftest@live@gem.html
* igt@i915_selftest@live@hangcheck:
- bat-dg1-5: NOTRUN -> [DMESG-FAIL][19] ([i915#4494] / [i915#4957])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/bat-dg1-5/igt@i915_selftest@live@hangcheck.html
* igt@i915_suspend@basic-s2idle-without-i915:
- bat-dg1-5: NOTRUN -> [INCOMPLETE][20] ([i915#6011])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/bat-dg1-5/igt@i915_suspend@basic-s2idle-without-i915.html
* igt@kms_addfb_basic@basic-x-tiled-legacy:
- bat-dg1-5: NOTRUN -> [SKIP][21] ([i915#4212]) +7 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/bat-dg1-5/igt@kms_addfb_basic@basic-x-tiled-legacy.html
* igt@kms_addfb_basic@basic-y-tiled-legacy:
- bat-dg1-5: NOTRUN -> [SKIP][22] ([i915#4215])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/bat-dg1-5/igt@kms_addfb_basic@basic-y-tiled-legacy.html
* igt@kms_busy@basic:
- bat-dg1-5: NOTRUN -> [SKIP][23] ([i915#1845] / [i915#4303])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/bat-dg1-5/igt@kms_busy@basic.html
* igt@kms_chamelium@dp-crc-fast:
- bat-adlp-4: NOTRUN -> [SKIP][24] ([fdo#111827]) +8 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/bat-adlp-4/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-rkl-11600: NOTRUN -> [SKIP][25] ([fdo#111827]) +8 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/fi-rkl-11600/igt@kms_chamelium@hdmi-hpd-fast.html
- bat-dg1-5: NOTRUN -> [SKIP][26] ([fdo#111827]) +7 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/bat-dg1-5/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor:
- fi-rkl-11600: NOTRUN -> [SKIP][27] ([i915#4103])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/fi-rkl-11600/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html
* igt@kms_flip@basic-plain-flip:
- bat-adlp-4: NOTRUN -> [SKIP][28] ([i915#3637]) +3 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/bat-adlp-4/igt@kms_flip@basic-plain-flip.html
* igt@kms_force_connector_basic@force-load-detect:
- fi-rkl-11600: NOTRUN -> [SKIP][29] ([fdo#109285] / [i915#4098])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/fi-rkl-11600/igt@kms_force_connector_basic@force-load-detect.html
- bat-dg1-5: NOTRUN -> [SKIP][30] ([fdo#109285])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/bat-dg1-5/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_force_connector_basic@prune-stale-modes:
- bat-adlp-4: NOTRUN -> [SKIP][31] ([i915#4093]) +3 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/bat-adlp-4/igt@kms_force_connector_basic@prune-stale-modes.html
* igt@kms_frontbuffer_tracking@basic:
- bat-adlp-4: NOTRUN -> [SKIP][32] ([i915#4342])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/bat-adlp-4/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_pipe_crc_basic@nonblocking-crc:
- bat-dg1-5: NOTRUN -> [SKIP][33] ([i915#4078]) +13 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/bat-dg1-5/igt@kms_pipe_crc_basic@nonblocking-crc.html
* igt@kms_pipe_crc_basic@read-crc:
- bat-adlp-4: NOTRUN -> [SKIP][34] ([i915#3546]) +10 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/bat-adlp-4/igt@kms_pipe_crc_basic@read-crc.html
* igt@kms_psr@sprite_plane_onoff:
- fi-rkl-11600: NOTRUN -> [SKIP][35] ([i915#1072]) +3 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/fi-rkl-11600/igt@kms_psr@sprite_plane_onoff.html
- bat-dg1-5: NOTRUN -> [SKIP][36] ([i915#1072] / [i915#4078]) +3 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/bat-dg1-5/igt@kms_psr@sprite_plane_onoff.html
- bat-adlp-4: NOTRUN -> [SKIP][37] ([i915#1072]) +3 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/bat-adlp-4/igt@kms_psr@sprite_plane_onoff.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-rkl-11600: NOTRUN -> [SKIP][38] ([i915#3555] / [i915#4098])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/fi-rkl-11600/igt@kms_setmode@basic-clone-single-crtc.html
- bat-dg1-5: NOTRUN -> [SKIP][39] ([i915#3555])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/bat-dg1-5/igt@kms_setmode@basic-clone-single-crtc.html
- bat-adlp-4: NOTRUN -> [SKIP][40] ([i915#3555] / [i915#4579])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/bat-adlp-4/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-fence-flip:
- bat-adlp-4: NOTRUN -> [SKIP][41] ([fdo#109295] / [i915#3546] / [i915#3708])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/bat-adlp-4/igt@prime_vgem@basic-fence-flip.html
- bat-dg1-5: NOTRUN -> [SKIP][42] ([i915#1845] / [i915#3708])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/bat-dg1-5/igt@prime_vgem@basic-fence-flip.html
* igt@prime_vgem@basic-fence-read:
- bat-dg1-5: NOTRUN -> [SKIP][43] ([i915#3708]) +2 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/bat-dg1-5/igt@prime_vgem@basic-fence-read.html
* igt@prime_vgem@basic-gtt:
- bat-dg1-5: NOTRUN -> [SKIP][44] ([i915#3708] / [i915#4077]) +1 similar issue
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/bat-dg1-5/igt@prime_vgem@basic-gtt.html
* igt@prime_vgem@basic-read:
- fi-rkl-11600: NOTRUN -> [SKIP][45] ([fdo#109295] / [i915#3291] / [i915#3708]) +2 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/fi-rkl-11600/igt@prime_vgem@basic-read.html
* igt@prime_vgem@basic-userptr:
- bat-adlp-4: NOTRUN -> [SKIP][46] ([fdo#109295] / [i915#3301] / [i915#3708])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/bat-adlp-4/igt@prime_vgem@basic-userptr.html
- bat-dg1-5: NOTRUN -> [SKIP][47] ([i915#3708] / [i915#4873])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/bat-dg1-5/igt@prime_vgem@basic-userptr.html
- fi-rkl-11600: NOTRUN -> [SKIP][48] ([fdo#109295] / [i915#3301] / [i915#3708])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/fi-rkl-11600/igt@prime_vgem@basic-userptr.html
* igt@prime_vgem@basic-write:
- bat-adlp-4: NOTRUN -> [SKIP][49] ([fdo#109295] / [i915#3291] / [i915#3708]) +2 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/bat-adlp-4/igt@prime_vgem@basic-write.html
* igt@runner@aborted:
- bat-dg1-5: NOTRUN -> [FAIL][50] ([i915#4312] / [i915#5257])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/bat-dg1-5/igt@runner@aborted.html
#### Possible fixes ####
* igt@i915_selftest@live@requests:
- fi-pnv-d510: [DMESG-FAIL][51] ([i915#4528]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12014/fi-pnv-d510/igt@i915_selftest@live@requests.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/fi-pnv-d510/igt@i915_selftest@live@requests.html
#### Warnings ####
* igt@i915_suspend@basic-s3-without-i915:
- fi-elk-e7500: [INCOMPLETE][53] ([i915#6648]) -> [INCOMPLETE][54] ([i915#6598] / [i915#6601] / [i915#6648])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12014/fi-elk-e7500/igt@i915_suspend@basic-s3-without-i915.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/fi-elk-e7500/igt@i915_suspend@basic-s3-without-i915.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#3003]: https://gitlab.freedesktop.org/drm/intel/issues/3003
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3595]: https://gitlab.freedesktop.org/drm/intel/issues/3595
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4093]: https://gitlab.freedesktop.org/drm/intel/issues/4093
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4303]: https://gitlab.freedesktop.org/drm/intel/issues/4303
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4342]: https://gitlab.freedesktop.org/drm/intel/issues/4342
[i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5828]: https://gitlab.freedesktop.org/drm/intel/issues/5828
[i915#6011]: https://gitlab.freedesktop.org/drm/intel/issues/6011
[i915#6530]: https://gitlab.freedesktop.org/drm/intel/issues/6530
[i915#6598]: https://gitlab.freedesktop.org/drm/intel/issues/6598
[i915#6601]: https://gitlab.freedesktop.org/drm/intel/issues/6601
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6642]: https://gitlab.freedesktop.org/drm/intel/issues/6642
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
[i915#6648]: https://gitlab.freedesktop.org/drm/intel/issues/6648
Build changes
-------------
* Linux: CI_DRM_12014 -> Patchwork_99621v3
CI-20190529: 20190529
CI_DRM_12014: 1de33826aa86910c175ca773bc8f92d5948d094e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6634: e01fe99f00692864b709253638c809231d1fb333 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_99621v3: 1de33826aa86910c175ca773bc8f92d5948d094e @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
3deea448520c drm/i915: fix null pointer dereference
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v3/index.html
[-- Attachment #2: Type: text/html, Size: 20221 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: fix null pointer dereference (rev4)
2022-02-01 15:33 [Intel-gfx] [PATCH v1] drm/i915: fix null pointer dereference Lukasz Bartosik
` (7 preceding siblings ...)
2022-08-23 11:30 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: fix null pointer dereference (rev3) Patchwork
@ 2022-08-23 18:53 ` Patchwork
2022-08-24 23:27 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
9 siblings, 0 replies; 25+ messages in thread
From: Patchwork @ 2022-08-23 18:53 UTC (permalink / raw)
To: Łukasz Bartosik; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 6674 bytes --]
== Series Details ==
Series: drm/i915: fix null pointer dereference (rev4)
URL : https://patchwork.freedesktop.org/series/99621/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12017 -> Patchwork_99621v4
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/index.html
Participating hosts (37 -> 37)
------------------------------
Additional (1): fi-hsw-4770
Missing (1): bat-dg2-8
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_99621v4:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@core_hotunplug@unbind-rebind:
- {bat-dg2-10}: [DMESG-WARN][1] ([i915#6643]) -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12017/bat-dg2-10/igt@core_hotunplug@unbind-rebind.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/bat-dg2-10/igt@core_hotunplug@unbind-rebind.html
Known issues
------------
Here are the changes found in Patchwork_99621v4 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_backlight@basic-brightness:
- fi-hsw-4770: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#3012])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/fi-hsw-4770/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_selftest@live@gem:
- fi-pnv-d510: NOTRUN -> [DMESG-FAIL][4] ([i915#4528])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/fi-pnv-d510/igt@i915_selftest@live@gem.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-hsw-4770: NOTRUN -> [INCOMPLETE][5] ([i915#4817] / [i915#6598])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/fi-hsw-4770/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- fi-hsw-4770: NOTRUN -> [SKIP][6] ([fdo#109271]) +9 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/fi-hsw-4770/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-bsw-kefka: NOTRUN -> [SKIP][7] ([fdo#109271] / [fdo#111827])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/fi-bsw-kefka/igt@kms_chamelium@common-hpd-after-suspend.html
- fi-rkl-11600: NOTRUN -> [SKIP][8] ([fdo#111827])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/fi-rkl-11600/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_chamelium@dp-crc-fast:
- fi-hsw-4770: NOTRUN -> [SKIP][9] ([fdo#109271] / [fdo#111827]) +7 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/fi-hsw-4770/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_psr@sprite_plane_onoff:
- fi-hsw-4770: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#1072]) +3 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/fi-hsw-4770/igt@kms_psr@sprite_plane_onoff.html
#### Possible fixes ####
* igt@i915_selftest@live@execlists:
- fi-bsw-kefka: [INCOMPLETE][11] ([i915#2940]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12017/fi-bsw-kefka/igt@i915_selftest@live@execlists.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/fi-bsw-kefka/igt@i915_selftest@live@execlists.html
* igt@i915_selftest@live@hangcheck:
- bat-dg1-6: [DMESG-FAIL][13] ([i915#4494] / [i915#4957]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12017/bat-dg1-6/igt@i915_selftest@live@hangcheck.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/bat-dg1-6/igt@i915_selftest@live@hangcheck.html
* igt@i915_selftest@live@requests:
- fi-pnv-d510: [DMESG-FAIL][15] ([i915#4528]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12017/fi-pnv-d510/igt@i915_selftest@live@requests.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/fi-pnv-d510/igt@i915_selftest@live@requests.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-rkl-11600: [INCOMPLETE][17] ([i915#5982]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12017/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
#### Warnings ####
* igt@i915_selftest@live@hangcheck:
- bat-dg1-5: [DMESG-FAIL][19] ([i915#4957]) -> [DMESG-FAIL][20] ([i915#4494] / [i915#4957])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12017/bat-dg1-5/igt@i915_selftest@live@hangcheck.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/bat-dg1-5/igt@i915_selftest@live@hangcheck.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
[i915#5982]: https://gitlab.freedesktop.org/drm/intel/issues/5982
[i915#6598]: https://gitlab.freedesktop.org/drm/intel/issues/6598
[i915#6643]: https://gitlab.freedesktop.org/drm/intel/issues/6643
Build changes
-------------
* Linux: CI_DRM_12017 -> Patchwork_99621v4
CI-20190529: 20190529
CI_DRM_12017: d09b6a64bd55b1c8c7baada7537621015f0cfd71 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6634: e01fe99f00692864b709253638c809231d1fb333 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_99621v4: d09b6a64bd55b1c8c7baada7537621015f0cfd71 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
af53b24d7eec drm/i915: fix null pointer dereference
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/index.html
[-- Attachment #2: Type: text/html, Size: 8215 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: fix null pointer dereference (rev4)
2022-02-01 15:33 [Intel-gfx] [PATCH v1] drm/i915: fix null pointer dereference Lukasz Bartosik
` (8 preceding siblings ...)
2022-08-23 18:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: fix null pointer dereference (rev4) Patchwork
@ 2022-08-24 23:27 ` Patchwork
9 siblings, 0 replies; 25+ messages in thread
From: Patchwork @ 2022-08-24 23:27 UTC (permalink / raw)
To: Łukasz Bartosik; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 21986 bytes --]
== Series Details ==
Series: drm/i915: fix null pointer dereference (rev4)
URL : https://patchwork.freedesktop.org/series/99621/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12017_full -> Patchwork_99621v4_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (12 -> 12)
------------------------------
No changes in participating hosts
Known issues
------------
Here are the changes found in Patchwork_99621v4_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_balancer@parallel:
- shard-iclb: [PASS][1] -> [SKIP][2] ([i915#4525])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12017/shard-iclb1/igt@gem_exec_balancer@parallel.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-iclb8/igt@gem_exec_balancer@parallel.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [PASS][3] -> [FAIL][4] ([i915#2842])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12017/shard-iclb8/igt@gem_exec_fair@basic-none-share@rcs0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-iclb3/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_huc_copy@huc-copy:
- shard-apl: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#2190])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-apl2/igt@gem_huc_copy@huc-copy.html
- shard-tglb: [PASS][6] -> [SKIP][7] ([i915#2190])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12017/shard-tglb3/igt@gem_huc_copy@huc-copy.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-tglb7/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@parallel-random-engines:
- shard-kbl: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#4613])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-kbl1/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][9] -> [FAIL][10] ([i915#454])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12017/shard-iclb7/igt@i915_pm_dc@dc6-psr.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-iclb7/igt@i915_pm_dc@dc6-psr.html
* igt@i915_selftest@live@hangcheck:
- shard-snb: [PASS][11] -> [INCOMPLETE][12] ([i915#3921])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12017/shard-snb5/igt@i915_selftest@live@hangcheck.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-snb6/igt@i915_selftest@live@hangcheck.html
* igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_ccs:
- shard-kbl: NOTRUN -> [SKIP][13] ([fdo#109271]) +57 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-kbl7/igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_ccs.html
* igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#3886]) +4 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-kbl1/igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][15] ([fdo#109271] / [i915#3886])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-apl2/igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_chamelium@dp-crc-single:
- shard-apl: NOTRUN -> [SKIP][16] ([fdo#109271] / [fdo#111827]) +1 similar issue
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-apl2/igt@kms_chamelium@dp-crc-single.html
* igt@kms_chamelium@dp-hpd-enable-disable-mode:
- shard-kbl: NOTRUN -> [SKIP][17] ([fdo#109271] / [fdo#111827]) +3 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-kbl1/igt@kms_chamelium@dp-hpd-enable-disable-mode.html
* igt@kms_content_protection@srm:
- shard-kbl: NOTRUN -> [TIMEOUT][18] ([i915#1319] / [i915#6637])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-kbl7/igt@kms_content_protection@srm.html
* igt@kms_flip@2x-flip-vs-expired-vblank@bc-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][19] -> [FAIL][20] ([i915#79])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12017/shard-glk1/igt@kms_flip@2x-flip-vs-expired-vblank@bc-hdmi-a1-hdmi-a2.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-glk8/igt@kms_flip@2x-flip-vs-expired-vblank@bc-hdmi-a1-hdmi-a2.html
* igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-upscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][21] ([i915#2672]) +4 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-iclb8/igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-upscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-linear-to-16bpp-linear-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][22] ([i915#3555]) +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-linear-to-16bpp-linear-downscaling@pipe-a-default-mode.html
* igt@kms_hdr@bpc-switch@pipe-a-dp-1:
- shard-kbl: [PASS][23] -> [FAIL][24] ([i915#1188])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12017/shard-kbl1/igt@kms_hdr@bpc-switch@pipe-a-dp-1.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-kbl1/igt@kms_hdr@bpc-switch@pipe-a-dp-1.html
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-a-dp-1:
- shard-apl: NOTRUN -> [INCOMPLETE][25] ([i915#6598])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-apl2/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-a-dp-1.html
* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-75@pipe-c-dp-1:
- shard-apl: NOTRUN -> [SKIP][26] ([fdo#109271]) +25 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-apl2/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-75@pipe-c-dp-1.html
* igt@sysfs_clients@split-50:
- shard-apl: NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#2994])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-apl2/igt@sysfs_clients@split-50.html
#### Possible fixes ####
* igt@drm_read@short-buffer-block:
- {shard-rkl}: [SKIP][28] ([i915#4098]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12017/shard-rkl-5/igt@drm_read@short-buffer-block.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-rkl-6/igt@drm_read@short-buffer-block.html
* igt@gem_ctx_persistence@engines-hang@bcs0:
- {shard-rkl}: [SKIP][30] ([i915#6252]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12017/shard-rkl-5/igt@gem_ctx_persistence@engines-hang@bcs0.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-rkl-6/igt@gem_ctx_persistence@engines-hang@bcs0.html
* igt@gem_eio@reset-stress:
- shard-tglb: [FAIL][32] ([i915#5784]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12017/shard-tglb5/igt@gem_eio@reset-stress.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-tglb7/igt@gem_eio@reset-stress.html
* igt@gem_exec_balancer@parallel-balancer:
- shard-iclb: [SKIP][34] ([i915#4525]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12017/shard-iclb6/igt@gem_exec_balancer@parallel-balancer.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-iclb2/igt@gem_exec_balancer@parallel-balancer.html
* igt@gem_exec_fair@basic-deadline:
- shard-kbl: [FAIL][36] ([i915#2846]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12017/shard-kbl4/igt@gem_exec_fair@basic-deadline.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-kbl1/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [FAIL][38] ([i915#2842]) -> [PASS][39] +1 similar issue
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12017/shard-apl1/igt@gem_exec_fair@basic-none-solo@rcs0.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-apl2/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [FAIL][40] ([i915#2842]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12017/shard-tglb5/igt@gem_exec_fair@basic-pace-share@rcs0.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-tglb3/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_suspend@basic-s3@smem:
- shard-apl: [DMESG-WARN][42] ([i915#180]) -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12017/shard-apl6/igt@gem_exec_suspend@basic-s3@smem.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-apl2/igt@gem_exec_suspend@basic-s3@smem.html
* igt@kms_atomic@plane-overlay-legacy:
- {shard-rkl}: [SKIP][44] ([i915#1845] / [i915#4098]) -> [PASS][45] +5 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12017/shard-rkl-5/igt@kms_atomic@plane-overlay-legacy.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-rkl-6/igt@kms_atomic@plane-overlay-legacy.html
* igt@kms_cursor_crc@cursor-suspend@pipe-b-dp-1:
- shard-kbl: [DMESG-WARN][46] ([i915#180]) -> [PASS][47] +2 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12017/shard-kbl7/igt@kms_cursor_crc@cursor-suspend@pipe-b-dp-1.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-kbl1/igt@kms_cursor_crc@cursor-suspend@pipe-b-dp-1.html
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-untiled:
- {shard-rkl}: [SKIP][48] ([fdo#111314] / [i915#4098] / [i915#4369]) -> [PASS][49] +2 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12017/shard-rkl-5/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-untiled.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-rkl-6/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-untiled.html
* igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-blt:
- {shard-rkl}: [SKIP][50] ([i915#1849] / [i915#4098]) -> [PASS][51] +5 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12017/shard-rkl-5/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-blt.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-blt.html
* igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1:
- shard-kbl: [FAIL][52] ([i915#1188]) -> [PASS][53]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12017/shard-kbl4/igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-kbl1/igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1.html
* igt@kms_plane@pixel-format-source-clamping@pipe-b-planes:
- {shard-rkl}: [SKIP][54] ([i915#1849] / [i915#3558]) -> [PASS][55] +1 similar issue
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12017/shard-rkl-5/igt@kms_plane@pixel-format-source-clamping@pipe-b-planes.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-rkl-6/igt@kms_plane@pixel-format-source-clamping@pipe-b-planes.html
* igt@kms_psr@cursor_mmap_cpu:
- {shard-rkl}: [SKIP][56] ([i915#1072]) -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12017/shard-rkl-5/igt@kms_psr@cursor_mmap_cpu.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-rkl-6/igt@kms_psr@cursor_mmap_cpu.html
* igt@kms_psr@psr2_sprite_render:
- shard-iclb: [SKIP][58] ([fdo#109441]) -> [PASS][59] +2 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12017/shard-iclb6/igt@kms_psr@psr2_sprite_render.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-iclb2/igt@kms_psr@psr2_sprite_render.html
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-kbl: [INCOMPLETE][60] ([i915#3614] / [i915#4939] / [i915#6598]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12017/shard-kbl4/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-kbl7/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
* igt@kms_vblank@pipe-b-wait-idle-hang:
- shard-snb: [SKIP][62] ([fdo#109271]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12017/shard-snb2/igt@kms_vblank@pipe-b-wait-idle-hang.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-snb4/igt@kms_vblank@pipe-b-wait-idle-hang.html
#### Warnings ####
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][64] ([i915#588]) -> [SKIP][65] ([i915#658])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12017/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-iclb8/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@kms_frontbuffer_tracking@fbcpsr-suspend:
- shard-iclb: [INCOMPLETE][66] ([i915#6598]) -> [INCOMPLETE][67] ([i915#1982] / [i915#6598])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12017/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html
* igt@kms_psr2_sf@overlay-plane-move-continuous-sf:
- shard-iclb: [SKIP][68] ([i915#2920]) -> [SKIP][69] ([i915#658])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12017/shard-iclb2/igt@kms_psr2_sf@overlay-plane-move-continuous-sf.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-iclb8/igt@kms_psr2_sf@overlay-plane-move-continuous-sf.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area:
- shard-iclb: [SKIP][70] ([fdo#111068] / [i915#658]) -> [SKIP][71] ([i915#2920])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12017/shard-iclb6/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area.html
* igt@kms_psr2_su@page_flip-p010:
- shard-iclb: [FAIL][72] ([i915#5939]) -> [SKIP][73] ([fdo#109642] / [fdo#111068] / [i915#658])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12017/shard-iclb2/igt@kms_psr2_su@page_flip-p010.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-iclb8/igt@kms_psr2_su@page_flip-p010.html
* igt@runner@aborted:
- shard-apl: ([FAIL][74], [FAIL][75], [FAIL][76]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#6599]) -> ([FAIL][77], [FAIL][78]) ([i915#3002] / [i915#4312] / [i915#5257] / [i915#6599])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12017/shard-apl6/igt@runner@aborted.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12017/shard-apl7/igt@runner@aborted.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12017/shard-apl3/igt@runner@aborted.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-apl6/igt@runner@aborted.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/shard-apl8/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111314]: https://bugs.freedesktop.org/show_bug.cgi?id=111314
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3614]: https://gitlab.freedesktop.org/drm/intel/issues/3614
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4369]: https://gitlab.freedesktop.org/drm/intel/issues/4369
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4877]: https://gitlab.freedesktop.org/drm/intel/issues/4877
[i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939
[i915#5030]: https://gitlab.freedesktop.org/drm/intel/issues/5030
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5287]: https://gitlab.freedesktop.org/drm/intel/issues/5287
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#5939]: https://gitlab.freedesktop.org/drm/intel/issues/5939
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6598]: https://gitlab.freedesktop.org/drm/intel/issues/6598
[i915#6599]: https://gitlab.freedesktop.org/drm/intel/issues/6599
[i915#6637]: https://gitlab.freedesktop.org/drm/intel/issues/6637
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_12017 -> Patchwork_99621v4
CI-20190529: 20190529
CI_DRM_12017: d09b6a64bd55b1c8c7baada7537621015f0cfd71 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6634: e01fe99f00692864b709253638c809231d1fb333 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_99621v4: d09b6a64bd55b1c8c7baada7537621015f0cfd71 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_99621v4/index.html
[-- Attachment #2: Type: text/html, Size: 23767 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread