From: Arnd Bergmann <arnd@arndb.de>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Linus Walleij <linus.walleij@linaro.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES"
<linux-samsung-soc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Necip Fazil Yildiran <fazilyildiran@gmail.com>,
"# 3.4.x" <stable@vger.kernel.org>
Subject: Re: [PATCH v2] pinctrl: samsung: fix missing GPIOLIB on ARM64 Exynos config
Date: Wed, 20 Apr 2022 22:44:30 +0200 [thread overview]
Message-ID: <CAK8P3a0QRgv3ebv_=UYHb61PdqprB0wC+mfQpsGHsw3KqQSo7w@mail.gmail.com> (raw)
In-Reply-To: <20220420141407.470955-1-krzysztof.kozlowski@linaro.org>
On Wed, Apr 20, 2022 at 4:14 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> The Samsung pinctrl drivers depend on OF_GPIO, which is part of GPIOLIB.
> ARMv7 Exynos platform selects GPIOLIB and Samsung pinctrl drivers. ARMv8
> Exynos selects only the latter leading to possible wrong configuration
> on ARMv8 build:
>
> WARNING: unmet direct dependencies detected for PINCTRL_EXYNOS
> Depends on [n]: PINCTRL [=y] && OF_GPIO [=n] && (ARCH_EXYNOS [=y] || ARCH_S5PV210 || COMPILE_TEST [=y])
> Selected by [y]:
> - ARCH_EXYNOS [=y]
>
> Always select the GPIOLIB from the Samsung pinctrl drivers to fix the
> issue. This requires removing of OF_GPIO dependency (to avoid recursive
> dependency), so add dependency on OF for COMPILE_TEST cases.
>
> Reported-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>
> Fixes: eed6b3eb20b9 ("arm64: Split out platform options to separate Kconfig")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Looks good to me,
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Linus Walleij <linus.walleij@linaro.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES"
<linux-samsung-soc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Necip Fazil Yildiran <fazilyildiran@gmail.com>,
"# 3.4.x" <stable@vger.kernel.org>
Subject: Re: [PATCH v2] pinctrl: samsung: fix missing GPIOLIB on ARM64 Exynos config
Date: Wed, 20 Apr 2022 22:44:30 +0200 [thread overview]
Message-ID: <CAK8P3a0QRgv3ebv_=UYHb61PdqprB0wC+mfQpsGHsw3KqQSo7w@mail.gmail.com> (raw)
In-Reply-To: <20220420141407.470955-1-krzysztof.kozlowski@linaro.org>
On Wed, Apr 20, 2022 at 4:14 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> The Samsung pinctrl drivers depend on OF_GPIO, which is part of GPIOLIB.
> ARMv7 Exynos platform selects GPIOLIB and Samsung pinctrl drivers. ARMv8
> Exynos selects only the latter leading to possible wrong configuration
> on ARMv8 build:
>
> WARNING: unmet direct dependencies detected for PINCTRL_EXYNOS
> Depends on [n]: PINCTRL [=y] && OF_GPIO [=n] && (ARCH_EXYNOS [=y] || ARCH_S5PV210 || COMPILE_TEST [=y])
> Selected by [y]:
> - ARCH_EXYNOS [=y]
>
> Always select the GPIOLIB from the Samsung pinctrl drivers to fix the
> issue. This requires removing of OF_GPIO dependency (to avoid recursive
> dependency), so add dependency on OF for COMPILE_TEST cases.
>
> Reported-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>
> Fixes: eed6b3eb20b9 ("arm64: Split out platform options to separate Kconfig")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Looks good to me,
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-20 20:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 14:14 [PATCH v2] pinctrl: samsung: fix missing GPIOLIB on ARM64 Exynos config Krzysztof Kozlowski
2022-04-20 14:14 ` Krzysztof Kozlowski
2022-04-20 20:44 ` Arnd Bergmann [this message]
2022-04-20 20:44 ` Arnd Bergmann
2022-04-21 6:59 ` Krzysztof Kozlowski
2022-04-21 6:59 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a0QRgv3ebv_=UYHb61PdqprB0wC+mfQpsGHsw3KqQSo7w@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=alim.akhtar@samsung.com \
--cc=fazilyildiran@gmail.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=stable@vger.kernel.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.