All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: nomadik: add interrupt-parent for clcd
@ 2018-01-15 16:37 ` Arnd Bergmann
  0 siblings, 0 replies; 9+ messages in thread
From: Arnd Bergmann @ 2018-01-15 16:37 UTC (permalink / raw)
  To: arm, Linus Walleij
  Cc: Arnd Bergmann, stable, Rob Herring, Mark Rutland,
	linux-arm-kernel, devicetree, linux-kernel

The clcd device is lacking an interrupt-parent property, which makes
the interrupt unusable and shows up as a warning with the latest
dtc version:

arch/arm/boot/dts/ste-nomadik-s8815.dtb: Warning (interrupts_property): Missing interrupt-parent for /amba/clcd@10120000
arch/arm/boot/dts/ste-nomadik-nhk15.dtb: Warning (interrupts_property): Missing interrupt-parent for /amba/clcd@10120000

I looked up the old board files and found that this interrupt has
the same irqchip as all the other on-chip device, it just needs one
extra line.

Fixes: 17470b7da11c ("ARM: dts: add the CLCD LCD display to the NHK15")
Cc: stable@vger.kernel.org
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm/boot/dts/ste-nomadik-stn8815.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/ste-nomadik-stn8815.dtsi b/arch/arm/boot/dts/ste-nomadik-stn8815.dtsi
index 68aab50a73ab..733678b75b88 100644
--- a/arch/arm/boot/dts/ste-nomadik-stn8815.dtsi
+++ b/arch/arm/boot/dts/ste-nomadik-stn8815.dtsi
@@ -750,6 +750,7 @@
 			reg = <0x10120000 0x1000>;
 			interrupt-names = "combined";
 			interrupts = <14>;
+			interrupt-parent = <&vica>;
 			clocks = <&clcdclk>, <&hclkclcd>;
 			clock-names = "clcdclk", "apb_pclk";
 			status = "disabled";
-- 
2.9.0

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH] ARM: dts: nomadik: add interrupt-parent for clcd
@ 2018-01-15 16:37 ` Arnd Bergmann
  0 siblings, 0 replies; 9+ messages in thread
From: Arnd Bergmann @ 2018-01-15 16:37 UTC (permalink / raw)
  To: arm, Linus Walleij
  Cc: Mark Rutland, devicetree, Arnd Bergmann, linux-kernel, stable,
	Rob Herring, linux-arm-kernel

The clcd device is lacking an interrupt-parent property, which makes
the interrupt unusable and shows up as a warning with the latest
dtc version:

arch/arm/boot/dts/ste-nomadik-s8815.dtb: Warning (interrupts_property): Missing interrupt-parent for /amba/clcd@10120000
arch/arm/boot/dts/ste-nomadik-nhk15.dtb: Warning (interrupts_property): Missing interrupt-parent for /amba/clcd@10120000

I looked up the old board files and found that this interrupt has
the same irqchip as all the other on-chip device, it just needs one
extra line.

Fixes: 17470b7da11c ("ARM: dts: add the CLCD LCD display to the NHK15")
Cc: stable@vger.kernel.org
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm/boot/dts/ste-nomadik-stn8815.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/ste-nomadik-stn8815.dtsi b/arch/arm/boot/dts/ste-nomadik-stn8815.dtsi
index 68aab50a73ab..733678b75b88 100644
--- a/arch/arm/boot/dts/ste-nomadik-stn8815.dtsi
+++ b/arch/arm/boot/dts/ste-nomadik-stn8815.dtsi
@@ -750,6 +750,7 @@
 			reg = <0x10120000 0x1000>;
 			interrupt-names = "combined";
 			interrupts = <14>;
+			interrupt-parent = <&vica>;
 			clocks = <&clcdclk>, <&hclkclcd>;
 			clock-names = "clcdclk", "apb_pclk";
 			status = "disabled";
-- 
2.9.0

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH] ARM: dts: nomadik: add interrupt-parent for clcd
@ 2018-01-15 16:37 ` Arnd Bergmann
  0 siblings, 0 replies; 9+ messages in thread
From: Arnd Bergmann @ 2018-01-15 16:37 UTC (permalink / raw)
  To: linux-arm-kernel

The clcd device is lacking an interrupt-parent property, which makes
the interrupt unusable and shows up as a warning with the latest
dtc version:

arch/arm/boot/dts/ste-nomadik-s8815.dtb: Warning (interrupts_property): Missing interrupt-parent for /amba/clcd at 10120000
arch/arm/boot/dts/ste-nomadik-nhk15.dtb: Warning (interrupts_property): Missing interrupt-parent for /amba/clcd at 10120000

I looked up the old board files and found that this interrupt has
the same irqchip as all the other on-chip device, it just needs one
extra line.

Fixes: 17470b7da11c ("ARM: dts: add the CLCD LCD display to the NHK15")
Cc: stable at vger.kernel.org
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm/boot/dts/ste-nomadik-stn8815.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/ste-nomadik-stn8815.dtsi b/arch/arm/boot/dts/ste-nomadik-stn8815.dtsi
index 68aab50a73ab..733678b75b88 100644
--- a/arch/arm/boot/dts/ste-nomadik-stn8815.dtsi
+++ b/arch/arm/boot/dts/ste-nomadik-stn8815.dtsi
@@ -750,6 +750,7 @@
 			reg = <0x10120000 0x1000>;
 			interrupt-names = "combined";
 			interrupts = <14>;
+			interrupt-parent = <&vica>;
 			clocks = <&clcdclk>, <&hclkclcd>;
 			clock-names = "clcdclk", "apb_pclk";
 			status = "disabled";
-- 
2.9.0

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: dts: nomadik: add interrupt-parent for clcd
  2018-01-15 16:37 ` Arnd Bergmann
  (?)
@ 2018-01-16  7:29   ` Linus Walleij
  -1 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2018-01-16  7:29 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: arm-soc, stable, Rob Herring, Mark Rutland, Linux ARM,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	linux-kernel

On Mon, Jan 15, 2018 at 5:37 PM, Arnd Bergmann <arnd@arndb.de> wrote:

> The clcd device is lacking an interrupt-parent property, which makes
> the interrupt unusable and shows up as a warning with the latest
> dtc version:
>
> arch/arm/boot/dts/ste-nomadik-s8815.dtb: Warning (interrupts_property): Missing interrupt-parent for /amba/clcd@10120000
> arch/arm/boot/dts/ste-nomadik-nhk15.dtb: Warning (interrupts_property): Missing interrupt-parent for /amba/clcd@10120000
>
> I looked up the old board files and found that this interrupt has
> the same irqchip as all the other on-chip device, it just needs one
> extra line.
>
> Fixes: 17470b7da11c ("ARM: dts: add the CLCD LCD display to the NHK15")
> Cc: stable@vger.kernel.org
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Sorry for not getting to fixing this myself quickly enough.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: dts: nomadik: add interrupt-parent for clcd
@ 2018-01-16  7:29   ` Linus Walleij
  0 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2018-01-16  7:29 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: arm-soc, stable, Rob Herring, Mark Rutland, Linux ARM,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	linux-kernel

On Mon, Jan 15, 2018 at 5:37 PM, Arnd Bergmann <arnd@arndb.de> wrote:

> The clcd device is lacking an interrupt-parent property, which makes
> the interrupt unusable and shows up as a warning with the latest
> dtc version:
>
> arch/arm/boot/dts/ste-nomadik-s8815.dtb: Warning (interrupts_property): Missing interrupt-parent for /amba/clcd@10120000
> arch/arm/boot/dts/ste-nomadik-nhk15.dtb: Warning (interrupts_property): Missing interrupt-parent for /amba/clcd@10120000
>
> I looked up the old board files and found that this interrupt has
> the same irqchip as all the other on-chip device, it just needs one
> extra line.
>
> Fixes: 17470b7da11c ("ARM: dts: add the CLCD LCD display to the NHK15")
> Cc: stable@vger.kernel.org
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Sorry for not getting to fixing this myself quickly enough.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [PATCH] ARM: dts: nomadik: add interrupt-parent for clcd
@ 2018-01-16  7:29   ` Linus Walleij
  0 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2018-01-16  7:29 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Jan 15, 2018 at 5:37 PM, Arnd Bergmann <arnd@arndb.de> wrote:

> The clcd device is lacking an interrupt-parent property, which makes
> the interrupt unusable and shows up as a warning with the latest
> dtc version:
>
> arch/arm/boot/dts/ste-nomadik-s8815.dtb: Warning (interrupts_property): Missing interrupt-parent for /amba/clcd at 10120000
> arch/arm/boot/dts/ste-nomadik-nhk15.dtb: Warning (interrupts_property): Missing interrupt-parent for /amba/clcd at 10120000
>
> I looked up the old board files and found that this interrupt has
> the same irqchip as all the other on-chip device, it just needs one
> extra line.
>
> Fixes: 17470b7da11c ("ARM: dts: add the CLCD LCD display to the NHK15")
> Cc: stable at vger.kernel.org
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Sorry for not getting to fixing this myself quickly enough.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: dts: nomadik: add interrupt-parent for clcd
@ 2018-01-19 15:22     ` Arnd Bergmann
  0 siblings, 0 replies; 9+ messages in thread
From: Arnd Bergmann @ 2018-01-19 15:22 UTC (permalink / raw)
  To: Linus Walleij
  Cc: arm-soc, stable, Rob Herring, Mark Rutland, Linux ARM,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	linux-kernel

On Tue, Jan 16, 2018 at 8:29 AM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Mon, Jan 15, 2018 at 5:37 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>
>> The clcd device is lacking an interrupt-parent property, which makes
>> the interrupt unusable and shows up as a warning with the latest
>> dtc version:
>>
>> arch/arm/boot/dts/ste-nomadik-s8815.dtb: Warning (interrupts_property): Missing interrupt-parent for /amba/clcd@10120000
>> arch/arm/boot/dts/ste-nomadik-nhk15.dtb: Warning (interrupts_property): Missing interrupt-parent for /amba/clcd@10120000
>>
>> I looked up the old board files and found that this interrupt has
>> the same irqchip as all the other on-chip device, it just needs one
>> extra line.
>>
>> Fixes: 17470b7da11c ("ARM: dts: add the CLCD LCD display to the NHK15")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> Sorry for not getting to fixing this myself quickly enough.

Applied to next/dt, thanks!

      Arnd

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: dts: nomadik: add interrupt-parent for clcd
@ 2018-01-19 15:22     ` Arnd Bergmann
  0 siblings, 0 replies; 9+ messages in thread
From: Arnd Bergmann @ 2018-01-19 15:22 UTC (permalink / raw)
  To: Linus Walleij
  Cc: arm-soc, stable, Rob Herring, Mark Rutland, Linux ARM,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

On Tue, Jan 16, 2018 at 8:29 AM, Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
> On Mon, Jan 15, 2018 at 5:37 PM, Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org> wrote:
>
>> The clcd device is lacking an interrupt-parent property, which makes
>> the interrupt unusable and shows up as a warning with the latest
>> dtc version:
>>
>> arch/arm/boot/dts/ste-nomadik-s8815.dtb: Warning (interrupts_property): Missing interrupt-parent for /amba/clcd@10120000
>> arch/arm/boot/dts/ste-nomadik-nhk15.dtb: Warning (interrupts_property): Missing interrupt-parent for /amba/clcd@10120000
>>
>> I looked up the old board files and found that this interrupt has
>> the same irqchip as all the other on-chip device, it just needs one
>> extra line.
>>
>> Fixes: 17470b7da11c ("ARM: dts: add the CLCD LCD display to the NHK15")
>> Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> Signed-off-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
>
> Reviewed-by: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>
> Sorry for not getting to fixing this myself quickly enough.

Applied to next/dt, thanks!

      Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [PATCH] ARM: dts: nomadik: add interrupt-parent for clcd
@ 2018-01-19 15:22     ` Arnd Bergmann
  0 siblings, 0 replies; 9+ messages in thread
From: Arnd Bergmann @ 2018-01-19 15:22 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Jan 16, 2018 at 8:29 AM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Mon, Jan 15, 2018 at 5:37 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>
>> The clcd device is lacking an interrupt-parent property, which makes
>> the interrupt unusable and shows up as a warning with the latest
>> dtc version:
>>
>> arch/arm/boot/dts/ste-nomadik-s8815.dtb: Warning (interrupts_property): Missing interrupt-parent for /amba/clcd at 10120000
>> arch/arm/boot/dts/ste-nomadik-nhk15.dtb: Warning (interrupts_property): Missing interrupt-parent for /amba/clcd at 10120000
>>
>> I looked up the old board files and found that this interrupt has
>> the same irqchip as all the other on-chip device, it just needs one
>> extra line.
>>
>> Fixes: 17470b7da11c ("ARM: dts: add the CLCD LCD display to the NHK15")
>> Cc: stable at vger.kernel.org
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> Sorry for not getting to fixing this myself quickly enough.

Applied to next/dt, thanks!

      Arnd

^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-01-19 15:22 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-15 16:37 [PATCH] ARM: dts: nomadik: add interrupt-parent for clcd Arnd Bergmann
2018-01-15 16:37 ` Arnd Bergmann
2018-01-15 16:37 ` Arnd Bergmann
2018-01-16  7:29 ` Linus Walleij
2018-01-16  7:29   ` Linus Walleij
2018-01-16  7:29   ` Linus Walleij
2018-01-19 15:22   ` Arnd Bergmann
2018-01-19 15:22     ` Arnd Bergmann
2018-01-19 15:22     ` Arnd Bergmann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.