All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] net/9p: trans_xen: add missing MODULE_AUTHOR/DESCRIPTION/LICENSE
@ 2018-01-10 16:37 Arnd Bergmann
  2018-01-10 17:27   ` Akemi Yagi
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Arnd Bergmann @ 2018-01-10 16:37 UTC (permalink / raw)
  To: Eric Van Hensbergen, Ron Minnich, Latchesar Ionkov
  Cc: Jesse Chan, Arnd Bergmann, David S. Miller, Juergen Gross,
	Stefano Stabellini, Boris Ostrovsky, Wei Yongjun,
	Tuomas Tynkkynen, v9fs-developer, netdev, linux-kernel

From: Jesse Chan <jc@linux.com>

This change resolves a new compile-time warning
when built as a loadable module:

WARNING: modpost: missing MODULE_LICENSE() in net/9p/9pnet_xen.o
see include/linux/module.h for more information

This adds the license as "Dual MIT/GPL", which matches the header of the file.

MODULE_DESCRIPTION and MODULE_AUTHOR are also added.

Signed-off-by: Jesse Chan <jc@linux.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 net/9p/trans_xen.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/net/9p/trans_xen.c b/net/9p/trans_xen.c
index 325c56043007..336576f7e9f1 100644
--- a/net/9p/trans_xen.c
+++ b/net/9p/trans_xen.c
@@ -543,3 +543,7 @@ static void p9_trans_xen_exit(void)
 	return xenbus_unregister_driver(&xen_9pfs_front_driver);
 }
 module_exit(p9_trans_xen_exit);
+
+MODULE_AUTHOR("Stefano Stabellini <stefano@aporeto.com>");
+MODULE_DESCRIPTION("Xen Transport for 9P");
+MODULE_LICENSE("Dual MIT/GPL");
-- 
2.9.0

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH] net/9p: trans_xen: add missing MODULE_AUTHOR/DESCRIPTION/LICENSE
  2018-01-10 16:37 [PATCH] net/9p: trans_xen: add missing MODULE_AUTHOR/DESCRIPTION/LICENSE Arnd Bergmann
@ 2018-01-10 17:27   ` Akemi Yagi
  2018-01-10 17:43 ` Stefano Stabellini
  2018-01-11  0:39 ` Stephen Hemminger
  2 siblings, 0 replies; 8+ messages in thread
From: Akemi Yagi @ 2018-01-10 17:27 UTC (permalink / raw)
  To: linux-kernel; +Cc: netdev

On Wed, 10 Jan 2018 17:37:47 +0100, Arnd Bergmann wrote:
> 
> MODULE_DESCRIPTION and MODULE_AUTHOR are also added.
> 
> Signed-off-by: Jesse Chan <jc@linux.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  net/9p/trans_xen.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/net/9p/trans_xen.c b/net/9p/trans_xen.c
> index 325c56043007..336576f7e9f1 100644
> --- a/net/9p/trans_xen.c
> +++ b/net/9p/trans_xen.c
> @@ -543,3 +543,7 @@ static void p9_trans_xen_exit(void)
>  	return xenbus_unregister_driver(&xen_9pfs_front_driver);
>  }
>  module_exit(p9_trans_xen_exit);
> +
> +MODULE_AUTHOR("Stefano Stabellini <stefano@aporeto.com>");
> +MODULE_DESCRIPTION("Xen Transport for 9P");
> +MODULE_LICENSE("Dual MIT/GPL");

Could you consider adding the credit to the people who are in this patch that addresses the same issue?

https://patchwork.ozlabs.org/patch/856908/

Thank you.

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] net/9p: trans_xen: add missing MODULE_AUTHOR/DESCRIPTION/LICENSE
@ 2018-01-10 17:27   ` Akemi Yagi
  0 siblings, 0 replies; 8+ messages in thread
From: Akemi Yagi @ 2018-01-10 17:27 UTC (permalink / raw)
  To: netdev; +Cc: linux-kernel

On Wed, 10 Jan 2018 17:37:47 +0100, Arnd Bergmann wrote:
> 
> MODULE_DESCRIPTION and MODULE_AUTHOR are also added.
> 
> Signed-off-by: Jesse Chan <jc@linux.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  net/9p/trans_xen.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/net/9p/trans_xen.c b/net/9p/trans_xen.c
> index 325c56043007..336576f7e9f1 100644
> --- a/net/9p/trans_xen.c
> +++ b/net/9p/trans_xen.c
> @@ -543,3 +543,7 @@ static void p9_trans_xen_exit(void)
>  	return xenbus_unregister_driver(&xen_9pfs_front_driver);
>  }
>  module_exit(p9_trans_xen_exit);
> +
> +MODULE_AUTHOR("Stefano Stabellini <stefano@aporeto.com>");
> +MODULE_DESCRIPTION("Xen Transport for 9P");
> +MODULE_LICENSE("Dual MIT/GPL");

Could you consider adding the credit to the people who are in this patch that addresses the same issue?

https://patchwork.ozlabs.org/patch/856908/

Thank you.

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] net/9p: trans_xen: add missing MODULE_AUTHOR/DESCRIPTION/LICENSE
  2018-01-10 16:37 [PATCH] net/9p: trans_xen: add missing MODULE_AUTHOR/DESCRIPTION/LICENSE Arnd Bergmann
  2018-01-10 17:27   ` Akemi Yagi
@ 2018-01-10 17:43 ` Stefano Stabellini
  2018-01-11  0:39 ` Stephen Hemminger
  2 siblings, 0 replies; 8+ messages in thread
From: Stefano Stabellini @ 2018-01-10 17:43 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Eric Van Hensbergen, Ron Minnich, Latchesar Ionkov, Jesse Chan,
	David S. Miller, Juergen Gross, Stefano Stabellini,
	Boris Ostrovsky, Wei Yongjun, Tuomas Tynkkynen, v9fs-developer,
	netdev, linux-kernel

On Wed, 10 Jan 2018, Arnd Bergmann wrote:
> From: Jesse Chan <jc@linux.com>
> 
> This change resolves a new compile-time warning
> when built as a loadable module:
> 
> WARNING: modpost: missing MODULE_LICENSE() in net/9p/9pnet_xen.o
> see include/linux/module.h for more information
> 
> This adds the license as "Dual MIT/GPL", which matches the header of the file.
> 
> MODULE_DESCRIPTION and MODULE_AUTHOR are also added.
> 
> Signed-off-by: Jesse Chan <jc@linux.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
>  net/9p/trans_xen.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/net/9p/trans_xen.c b/net/9p/trans_xen.c
> index 325c56043007..336576f7e9f1 100644
> --- a/net/9p/trans_xen.c
> +++ b/net/9p/trans_xen.c
> @@ -543,3 +543,7 @@ static void p9_trans_xen_exit(void)
>  	return xenbus_unregister_driver(&xen_9pfs_front_driver);
>  }
>  module_exit(p9_trans_xen_exit);
> +
> +MODULE_AUTHOR("Stefano Stabellini <stefano@aporeto.com>");
> +MODULE_DESCRIPTION("Xen Transport for 9P");
> +MODULE_LICENSE("Dual MIT/GPL");
> -- 
> 2.9.0
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] net/9p: trans_xen: add missing MODULE_AUTHOR/DESCRIPTION/LICENSE
  2018-01-10 17:27   ` Akemi Yagi
  (?)
@ 2018-01-10 21:11   ` Arnd Bergmann
  -1 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2018-01-10 21:11 UTC (permalink / raw)
  To: Akemi Yagi; +Cc: Networking, Linux Kernel Mailing List

On Wed, Jan 10, 2018 at 6:27 PM, Akemi Yagi <toracat@elrepo.org> wrote:
> On Wed, 10 Jan 2018 17:37:47 +0100, Arnd Bergmann wrote:
>>
>> MODULE_DESCRIPTION and MODULE_AUTHOR are also added.
>>
>> Signed-off-by: Jesse Chan <jc@linux.com>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>>  net/9p/trans_xen.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/net/9p/trans_xen.c b/net/9p/trans_xen.c
>> index 325c56043007..336576f7e9f1 100644
>> --- a/net/9p/trans_xen.c
>> +++ b/net/9p/trans_xen.c
>> @@ -543,3 +543,7 @@ static void p9_trans_xen_exit(void)
>>       return xenbus_unregister_driver(&xen_9pfs_front_driver);
>>  }
>>  module_exit(p9_trans_xen_exit);
>> +
>> +MODULE_AUTHOR("Stefano Stabellini <stefano@aporeto.com>");
>> +MODULE_DESCRIPTION("Xen Transport for 9P");
>> +MODULE_LICENSE("Dual MIT/GPL");
>
> Could you consider adding the credit to the people who are in this patch that addresses the same issue?
>
> https://patchwork.ozlabs.org/patch/856908/

Any version is fine with me, as long as the patch makes it in. I picked
up Jesse's patch and forwarded that one, as he seems to have been
the first person to send a patch back in November.

Comparing the two versions, I think that one is also better since it correctly
identifies the license as "Dual MIT/GPL", matching the comment.

        Arnd

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] net/9p: trans_xen: add missing MODULE_AUTHOR/DESCRIPTION/LICENSE
  2018-01-10 16:37 [PATCH] net/9p: trans_xen: add missing MODULE_AUTHOR/DESCRIPTION/LICENSE Arnd Bergmann
  2018-01-10 17:27   ` Akemi Yagi
  2018-01-10 17:43 ` Stefano Stabellini
@ 2018-01-11  0:39 ` Stephen Hemminger
  2 siblings, 0 replies; 8+ messages in thread
From: Stephen Hemminger @ 2018-01-11  0:39 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Eric Van Hensbergen, Ron Minnich, Latchesar Ionkov, Jesse Chan,
	David S. Miller, Juergen Gross, Stefano Stabellini,
	Boris Ostrovsky, Wei Yongjun, Tuomas Tynkkynen, v9fs-developer,
	netdev, linux-kernel

On Wed, 10 Jan 2018 17:37:47 +0100
Arnd Bergmann <arnd@arndb.de> wrote:

> From: Jesse Chan <jc@linux.com>
> 
> This change resolves a new compile-time warning
> when built as a loadable module:
> 
> WARNING: modpost: missing MODULE_LICENSE() in net/9p/9pnet_xen.o
> see include/linux/module.h for more information
> 
> This adds the license as "Dual MIT/GPL", which matches the header of the file.
> 
> MODULE_DESCRIPTION and MODULE_AUTHOR are also added.
> 
> Signed-off-by: Jesse Chan <jc@linux.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  net/9p/trans_xen.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/net/9p/trans_xen.c b/net/9p/trans_xen.c
> index 325c56043007..336576f7e9f1 100644
> --- a/net/9p/trans_xen.c
> +++ b/net/9p/trans_xen.c
> @@ -543,3 +543,7 @@ static void p9_trans_xen_exit(void)
>  	return xenbus_unregister_driver(&xen_9pfs_front_driver);
>  }
>  module_exit(p9_trans_xen_exit);
> +
> +MODULE_AUTHOR("Stefano Stabellini <stefano@aporeto.com>");
> +MODULE_DESCRIPTION("Xen Transport for 9P");
> +MODULE_LICENSE("Dual MIT/GPL");


I already submitted:
  https://patchwork.ozlabs.org/patch/856908/

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] net/9p: trans_xen: add missing MODULE_AUTHOR/DESCRIPTION/LICENSE
  2017-11-20  6:28 Jesse Chan
@ 2018-01-11  0:40 ` Stephen Hemminger
  0 siblings, 0 replies; 8+ messages in thread
From: Stephen Hemminger @ 2018-01-11  0:40 UTC (permalink / raw)
  To: Jesse Chan
  Cc: Eric Van Hensbergen, Ron Minnich, Latchesar Ionkov,
	David S. Miller, v9fs-developer, netdev

On Sun, 19 Nov 2017 22:28:29 -0800
Jesse Chan <jc@linux.com> wrote:

> Signed-off-by: Jesse Chan <jc@linux.com>
> ---
>  net/9p/trans_xen.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/net/9p/trans_xen.c b/net/9p/trans_xen.c
> index 6ad3e043c617..90402e744fbf 100644
> --- a/net/9p/trans_xen.c
> +++ b/net/9p/trans_xen.c
> @@ -543,3 +543,7 @@ static void p9_trans_xen_exit(void)
>  	return xenbus_unregister_driver(&xen_9pfs_front_driver);
>  }
>  module_exit(p9_trans_xen_exit);
> +
> +MODULE_AUTHOR("Stefano Stabellini <stefano@aporeto.com>");
> +MODULE_DESCRIPTION("Xen Transport for 9P");
> +MODULE_LICENSE("Dual MIT/GPL");


I already submitted:
  https://patchwork.ozlabs.org/patch/856908/

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH] net/9p: trans_xen: add missing MODULE_AUTHOR/DESCRIPTION/LICENSE
@ 2017-11-20  6:28 Jesse Chan
  2018-01-11  0:40 ` Stephen Hemminger
  0 siblings, 1 reply; 8+ messages in thread
From: Jesse Chan @ 2017-11-20  6:28 UTC (permalink / raw)
  Cc: Jesse Chan, Eric Van Hensbergen, Ron Minnich, Latchesar Ionkov,
	David S. Miller, v9fs-developer, netdev, linux-kernel

Signed-off-by: Jesse Chan <jc@linux.com>
---
 net/9p/trans_xen.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/net/9p/trans_xen.c b/net/9p/trans_xen.c
index 6ad3e043c617..90402e744fbf 100644
--- a/net/9p/trans_xen.c
+++ b/net/9p/trans_xen.c
@@ -543,3 +543,7 @@ static void p9_trans_xen_exit(void)
 	return xenbus_unregister_driver(&xen_9pfs_front_driver);
 }
 module_exit(p9_trans_xen_exit);
+
+MODULE_AUTHOR("Stefano Stabellini <stefano@aporeto.com>");
+MODULE_DESCRIPTION("Xen Transport for 9P");
+MODULE_LICENSE("Dual MIT/GPL");
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-01-11  0:40 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-10 16:37 [PATCH] net/9p: trans_xen: add missing MODULE_AUTHOR/DESCRIPTION/LICENSE Arnd Bergmann
2018-01-10 17:27 ` Akemi Yagi
2018-01-10 17:27   ` Akemi Yagi
2018-01-10 21:11   ` Arnd Bergmann
2018-01-10 17:43 ` Stefano Stabellini
2018-01-11  0:39 ` Stephen Hemminger
  -- strict thread matches above, loose matches on Subject: below --
2017-11-20  6:28 Jesse Chan
2018-01-11  0:40 ` Stephen Hemminger

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.