All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Dmitry Osipenko <digetx@gmail.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Stephen Boyd <sboyd@kernel.org>, Tony Lindgren <tony@atomide.com>,
	Paul Burton <paul.burton@mips.com>,
	John Crispin <john@phrozen.org>,
	"open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	linux-m68k <linux-m68k@lists.linux-m68k.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-tegra <linux-tegra@vger.kernel.org>,
	linux-clk <linux-clk@vger.kernel.org>,
	"open list:TI ETHERNET SWITCH DRIVER (CPSW)" 
	<linux-omap@vger.kernel.org>
Subject: Re: [PATCH v1] kbuild: Disable compile testing if HAVE_LEGACY_CLK enabled
Date: Fri, 28 May 2021 11:27:54 +0200	[thread overview]
Message-ID: <CAK8P3a0hZGEOh0jckDvt-386KopCCL09RM6hv4qAUie31LDSTQ@mail.gmail.com> (raw)
In-Reply-To: <3661fdba-ad32-5d16-7714-1ebc58caf435@infradead.org>

On Wed, May 26, 2021 at 2:39 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> On 5/25/21 2:29 PM, Dmitry Osipenko wrote:
> > 25.05.2021 15:19, Geert Uytterhoeven пишет:
> If you are messing around with HAVE_LEGACY_CLK and COMMON_CLK
> and don't mind, please have a look at this report from
> 'kernel test robot':
>   https://lore.kernel.org/lkml/202103162301.oomY9NwI-lkp@intel.com/
>
>
> Maybe this one is more MIPS-specific. I dunno.
> I tried to come up with a patch for it and failed.
>
> I will be happy to built-test any patches that you come up with.
>
> Maybe I have just looked at this too long...

This is exactly the case that Dmitry is trying to solve. The problem
is that bcm63xx
and lantiq set CONFIG_HAVE_LEGACY_CLK but lack the clk_set_parent()
and clk_get_parent() functions. We could add the same stubs for these
two that we have for the other legacy clk implementations, or rework the
handling of legacy clocks completely.

       Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Dmitry Osipenko <digetx@gmail.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	 Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	 Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	 Stephen Boyd <sboyd@kernel.org>,
	Tony Lindgren <tony@atomide.com>,
	Paul Burton <paul.burton@mips.com>,
	John Crispin <john@phrozen.org>,
	 "open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
	 Linux ARM <linux-arm-kernel@lists.infradead.org>,
	 linux-m68k <linux-m68k@lists.linux-m68k.org>,
	 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-tegra <linux-tegra@vger.kernel.org>,
	 linux-clk <linux-clk@vger.kernel.org>,
	 "open list:TI ETHERNET SWITCH DRIVER (CPSW)"
	<linux-omap@vger.kernel.org>
Subject: Re: [PATCH v1] kbuild: Disable compile testing if HAVE_LEGACY_CLK enabled
Date: Fri, 28 May 2021 11:27:54 +0200	[thread overview]
Message-ID: <CAK8P3a0hZGEOh0jckDvt-386KopCCL09RM6hv4qAUie31LDSTQ@mail.gmail.com> (raw)
In-Reply-To: <3661fdba-ad32-5d16-7714-1ebc58caf435@infradead.org>

On Wed, May 26, 2021 at 2:39 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> On 5/25/21 2:29 PM, Dmitry Osipenko wrote:
> > 25.05.2021 15:19, Geert Uytterhoeven пишет:
> If you are messing around with HAVE_LEGACY_CLK and COMMON_CLK
> and don't mind, please have a look at this report from
> 'kernel test robot':
>   https://lore.kernel.org/lkml/202103162301.oomY9NwI-lkp@intel.com/
>
>
> Maybe this one is more MIPS-specific. I dunno.
> I tried to come up with a patch for it and failed.
>
> I will be happy to built-test any patches that you come up with.
>
> Maybe I have just looked at this too long...

This is exactly the case that Dmitry is trying to solve. The problem
is that bcm63xx
and lantiq set CONFIG_HAVE_LEGACY_CLK but lack the clk_set_parent()
and clk_get_parent() functions. We could add the same stubs for these
two that we have for the other legacy clk implementations, or rework the
handling of legacy clocks completely.

       Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-05-28  9:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-23 23:25 [PATCH v1] kbuild: Disable compile testing if HAVE_LEGACY_CLK enabled Dmitry Osipenko
2021-05-23 23:25 ` Dmitry Osipenko
2021-05-24  8:54 ` Geert Uytterhoeven
2021-05-24  8:54   ` Geert Uytterhoeven
2021-05-24 12:39   ` Dmitry Osipenko
2021-05-24 12:39     ` Dmitry Osipenko
2021-05-25 12:03     ` Krzysztof Kozlowski
2021-05-25 12:03       ` Krzysztof Kozlowski
2021-05-25 12:19       ` Geert Uytterhoeven
2021-05-25 12:19         ` Geert Uytterhoeven
2021-05-25 21:29         ` Dmitry Osipenko
2021-05-25 21:29           ` Dmitry Osipenko
2021-05-26  0:39           ` Randy Dunlap
2021-05-26  0:39             ` Randy Dunlap
2021-05-28  9:27             ` Arnd Bergmann [this message]
2021-05-28  9:27               ` Arnd Bergmann
2021-05-28  9:24     ` Arnd Bergmann
2021-05-28  9:24       ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK8P3a0hZGEOh0jckDvt-386KopCCL09RM6hv4qAUie31LDSTQ@mail.gmail.com \
    --to=arnd@arndb.de \
    --cc=digetx@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=john@phrozen.org \
    --cc=jonathanh@nvidia.com \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=paul.burton@mips.com \
    --cc=rdunlap@infradead.org \
    --cc=sboyd@kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.