From: Arnd Bergmann <arnd@kernel.org>
To: Karol Herbst <kherbst@redhat.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lyude Paul <lyude@redhat.com>, Ben Skeggs <bskeggs@redhat.com>,
Randy Dunlap <rdunlap@infradead.org>,
Daniel Vetter <daniel@ffwll.ch>,
ML nouveau <nouveau@lists.freedesktop.org>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] nouveau: make backlight support non optional
Date: Sat, 24 Jul 2021 16:58:06 +0200 [thread overview]
Message-ID: <CAK8P3a0i0WP24Z0TScmPqKxmM2ovtKnmm+qZq6+Tc1ju+hma0w@mail.gmail.com> (raw)
In-Reply-To: <CACO55tswMuDE9u3asU2Ls7BhA0uKGGarLk+E-WTD6MVnLwc3tw@mail.gmail.com>
On Sat, Jul 24, 2021 at 4:14 PM Karol Herbst <kherbst@redhat.com> wrote:
>
> we use the MXM_WMI in code. We also have to keep arm in mind and not
> break stuff there. So I will try to play around with your changes and
> see how that goes.
Ok, should find any randconfig build failures for arm, arm64 or x86 over the
weekend. I also this on linux-next today
ld: drivers/gpu/drm/i915/display/intel_panel.o: in function
`intel_backlight_device_register':
intel_panel.c:(.text+0x2804): undefined reference to `backlight_device_register'
ld: intel_panel.c:(.text+0x284e): undefined reference to
`backlight_device_register'
ld: drivers/gpu/drm/i915/display/intel_panel.o: in function
`intel_backlight_device_unregister':
intel_panel.c:(.text+0x28b1): undefined reference to
`backlight_device_unregister'
and I added this same thing there to see how it goes:
diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
index 87825d36335b..69c6b7aec49e 100644
--- a/drivers/gpu/drm/i915/Kconfig
+++ b/drivers/gpu/drm/i915/Kconfig
@@ -3,6 +3,8 @@ config DRM_I915
tristate "Intel 8xx/9xx/G3x/G4x/HD Graphics"
depends on DRM
depends on X86 && PCI
+ depends on ACPI_VIDEO || !ACPI
+ depends on BACKLIGHT_CLASS_DEVICE
select INTEL_GTT
select INTERVAL_TREE
# we need shmfs for the swappable backing store, and in particular
@@ -16,10 +18,6 @@ config DRM_I915
select IRQ_WORK
# i915 depends on ACPI_VIDEO when ACPI is enabled
# but for select to work, need to select ACPI_VIDEO's dependencies, ick
- select DRM_I915_BACKLIGHT if ACPI
- select INPUT if ACPI
- select ACPI_VIDEO if ACPI
- select ACPI_BUTTON if ACPI
select SYNC_FILE
select IOSF_MBI
select CRC32
@@ -64,13 +62,7 @@ config DRM_I915_FORCE_PROBE
Use "*" to force probe the driver for all known devices.
config DRM_I915_BACKLIGHT
- tristate "Control backlight support"
- depends on DRM_I915
- default DRM_I915
- select BACKLIGHT_CLASS_DEVICE
- help
- Say Y here if you want to control the backlight of your display
- (e.g. a laptop panel).
+ def_tristate DRM_I915
config DRM_I915_CAPTURE_ERROR
bool "Enable capturing GPU state following a hang"
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@kernel.org>
To: Karol Herbst <kherbst@redhat.com>
Cc: ML nouveau <nouveau@lists.freedesktop.org>,
Randy Dunlap <rdunlap@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Ben Skeggs <bskeggs@redhat.com>, Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [Nouveau] [PATCH] nouveau: make backlight support non optional
Date: Sat, 24 Jul 2021 16:58:06 +0200 [thread overview]
Message-ID: <CAK8P3a0i0WP24Z0TScmPqKxmM2ovtKnmm+qZq6+Tc1ju+hma0w@mail.gmail.com> (raw)
In-Reply-To: <CACO55tswMuDE9u3asU2Ls7BhA0uKGGarLk+E-WTD6MVnLwc3tw@mail.gmail.com>
On Sat, Jul 24, 2021 at 4:14 PM Karol Herbst <kherbst@redhat.com> wrote:
>
> we use the MXM_WMI in code. We also have to keep arm in mind and not
> break stuff there. So I will try to play around with your changes and
> see how that goes.
Ok, should find any randconfig build failures for arm, arm64 or x86 over the
weekend. I also this on linux-next today
ld: drivers/gpu/drm/i915/display/intel_panel.o: in function
`intel_backlight_device_register':
intel_panel.c:(.text+0x2804): undefined reference to `backlight_device_register'
ld: intel_panel.c:(.text+0x284e): undefined reference to
`backlight_device_register'
ld: drivers/gpu/drm/i915/display/intel_panel.o: in function
`intel_backlight_device_unregister':
intel_panel.c:(.text+0x28b1): undefined reference to
`backlight_device_unregister'
and I added this same thing there to see how it goes:
diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
index 87825d36335b..69c6b7aec49e 100644
--- a/drivers/gpu/drm/i915/Kconfig
+++ b/drivers/gpu/drm/i915/Kconfig
@@ -3,6 +3,8 @@ config DRM_I915
tristate "Intel 8xx/9xx/G3x/G4x/HD Graphics"
depends on DRM
depends on X86 && PCI
+ depends on ACPI_VIDEO || !ACPI
+ depends on BACKLIGHT_CLASS_DEVICE
select INTEL_GTT
select INTERVAL_TREE
# we need shmfs for the swappable backing store, and in particular
@@ -16,10 +18,6 @@ config DRM_I915
select IRQ_WORK
# i915 depends on ACPI_VIDEO when ACPI is enabled
# but for select to work, need to select ACPI_VIDEO's dependencies, ick
- select DRM_I915_BACKLIGHT if ACPI
- select INPUT if ACPI
- select ACPI_VIDEO if ACPI
- select ACPI_BUTTON if ACPI
select SYNC_FILE
select IOSF_MBI
select CRC32
@@ -64,13 +62,7 @@ config DRM_I915_FORCE_PROBE
Use "*" to force probe the driver for all known devices.
config DRM_I915_BACKLIGHT
- tristate "Control backlight support"
- depends on DRM_I915
- default DRM_I915
- select BACKLIGHT_CLASS_DEVICE
- help
- Say Y here if you want to control the backlight of your display
- (e.g. a laptop panel).
+ def_tristate DRM_I915
config DRM_I915_CAPTURE_ERROR
bool "Enable capturing GPU state following a hang"
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@kernel.org>
To: Karol Herbst <kherbst@redhat.com>
Cc: ML nouveau <nouveau@lists.freedesktop.org>,
Randy Dunlap <rdunlap@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Ben Skeggs <bskeggs@redhat.com>
Subject: Re: [PATCH] nouveau: make backlight support non optional
Date: Sat, 24 Jul 2021 16:58:06 +0200 [thread overview]
Message-ID: <CAK8P3a0i0WP24Z0TScmPqKxmM2ovtKnmm+qZq6+Tc1ju+hma0w@mail.gmail.com> (raw)
In-Reply-To: <CACO55tswMuDE9u3asU2Ls7BhA0uKGGarLk+E-WTD6MVnLwc3tw@mail.gmail.com>
On Sat, Jul 24, 2021 at 4:14 PM Karol Herbst <kherbst@redhat.com> wrote:
>
> we use the MXM_WMI in code. We also have to keep arm in mind and not
> break stuff there. So I will try to play around with your changes and
> see how that goes.
Ok, should find any randconfig build failures for arm, arm64 or x86 over the
weekend. I also this on linux-next today
ld: drivers/gpu/drm/i915/display/intel_panel.o: in function
`intel_backlight_device_register':
intel_panel.c:(.text+0x2804): undefined reference to `backlight_device_register'
ld: intel_panel.c:(.text+0x284e): undefined reference to
`backlight_device_register'
ld: drivers/gpu/drm/i915/display/intel_panel.o: in function
`intel_backlight_device_unregister':
intel_panel.c:(.text+0x28b1): undefined reference to
`backlight_device_unregister'
and I added this same thing there to see how it goes:
diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
index 87825d36335b..69c6b7aec49e 100644
--- a/drivers/gpu/drm/i915/Kconfig
+++ b/drivers/gpu/drm/i915/Kconfig
@@ -3,6 +3,8 @@ config DRM_I915
tristate "Intel 8xx/9xx/G3x/G4x/HD Graphics"
depends on DRM
depends on X86 && PCI
+ depends on ACPI_VIDEO || !ACPI
+ depends on BACKLIGHT_CLASS_DEVICE
select INTEL_GTT
select INTERVAL_TREE
# we need shmfs for the swappable backing store, and in particular
@@ -16,10 +18,6 @@ config DRM_I915
select IRQ_WORK
# i915 depends on ACPI_VIDEO when ACPI is enabled
# but for select to work, need to select ACPI_VIDEO's dependencies, ick
- select DRM_I915_BACKLIGHT if ACPI
- select INPUT if ACPI
- select ACPI_VIDEO if ACPI
- select ACPI_BUTTON if ACPI
select SYNC_FILE
select IOSF_MBI
select CRC32
@@ -64,13 +62,7 @@ config DRM_I915_FORCE_PROBE
Use "*" to force probe the driver for all known devices.
config DRM_I915_BACKLIGHT
- tristate "Control backlight support"
- depends on DRM_I915
- default DRM_I915
- select BACKLIGHT_CLASS_DEVICE
- help
- Say Y here if you want to control the backlight of your display
- (e.g. a laptop panel).
+ def_tristate DRM_I915
config DRM_I915_CAPTURE_ERROR
bool "Enable capturing GPU state following a hang"
next prev parent reply other threads:[~2021-07-24 14:58 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 22:46 [PATCH] nouveau: make backlight support non optional Karol Herbst
2021-07-23 22:46 ` Karol Herbst
2021-07-23 22:46 ` [Nouveau] " Karol Herbst
2021-07-24 6:55 ` Arnd Bergmann
2021-07-24 6:55 ` Arnd Bergmann
2021-07-24 6:55 ` [Nouveau] " Arnd Bergmann
2021-07-24 9:54 ` Karol Herbst
2021-07-24 9:54 ` Karol Herbst
2021-07-24 9:54 ` [Nouveau] " Karol Herbst
2021-07-24 11:56 ` Arnd Bergmann
2021-07-24 11:56 ` Arnd Bergmann
2021-07-24 11:56 ` [Nouveau] " Arnd Bergmann
2021-07-24 12:10 ` Karol Herbst
2021-07-24 12:10 ` Karol Herbst
2021-07-24 12:10 ` [Nouveau] " Karol Herbst
2021-07-24 12:51 ` Karol Herbst
2021-07-24 12:51 ` Karol Herbst
2021-07-24 12:51 ` [Nouveau] " Karol Herbst
2021-07-24 14:04 ` Arnd Bergmann
2021-07-24 14:04 ` Arnd Bergmann
2021-07-24 14:04 ` [Nouveau] " Arnd Bergmann
2021-07-24 14:13 ` Karol Herbst
2021-07-24 14:13 ` Karol Herbst
2021-07-24 14:13 ` [Nouveau] " Karol Herbst
2021-07-24 14:58 ` Arnd Bergmann [this message]
2021-07-24 14:58 ` Arnd Bergmann
2021-07-24 14:58 ` [Nouveau] " Arnd Bergmann
2021-08-04 14:10 ` [PATCH] depend on BACKLIGHT_CLASS_DEVICE for more devices Karol Herbst
2021-08-04 14:10 ` [Nouveau] " Karol Herbst
2021-08-04 14:19 ` Arnd Bergmann
2021-08-04 14:19 ` Arnd Bergmann
2021-08-04 14:19 ` [Nouveau] " Arnd Bergmann
2021-08-04 14:43 ` Karol Herbst
2021-08-04 14:43 ` Karol Herbst
2021-08-04 14:43 ` [Nouveau] " Karol Herbst
2021-08-04 18:59 ` Karol Herbst
2021-08-04 18:59 ` Karol Herbst
2021-08-04 18:59 ` [Nouveau] " Karol Herbst
2021-08-04 21:09 ` Arnd Bergmann
2021-08-04 21:09 ` Arnd Bergmann
2021-08-04 21:09 ` [Nouveau] " Arnd Bergmann
2021-08-04 22:01 ` Karol Herbst
2021-08-04 22:01 ` Karol Herbst
2021-08-04 22:01 ` [Nouveau] " Karol Herbst
2021-08-05 6:50 ` Arnd Bergmann
2021-08-05 6:50 ` Arnd Bergmann
2021-08-05 6:50 ` [Nouveau] " Arnd Bergmann
2021-08-09 13:20 ` [PATCH] nouveau: make backlight support non optional Jani Nikula
2021-08-09 13:20 ` [Nouveau] " Jani Nikula
2021-08-09 13:30 ` Arnd Bergmann
2021-08-09 13:30 ` Arnd Bergmann
2021-08-09 13:30 ` [Nouveau] " Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a0i0WP24Z0TScmPqKxmM2ovtKnmm+qZq6+Tc1ju+hma0w@mail.gmail.com \
--to=arnd@kernel.org \
--cc=bskeggs@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kherbst@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=nouveau@lists.freedesktop.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.