All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@kernel.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Russell King <linux@armlinux.org.uk>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Linus Walleij <linus.walleij@linaro.org>,
	Christoph Hellwig <hch@infradead.org>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	USB list <linux-usb@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] ARM: sa1100/assabet: move dmabounce hack to ohci driver
Date: Tue, 1 Feb 2022 17:08:15 +0100	[thread overview]
Message-ID: <CAK8P3a1DghU4fm_6OA8=_SG_ODYsnrw0J_Z-kmC9ay1hH=Gqwg@mail.gmail.com> (raw)
In-Reply-To: <YflSNQQvignxL4PA@rowland.harvard.edu>

On Tue, Feb 1, 2022 at 4:31 PM Alan Stern <stern@rowland.harvard.edu> wrote:

> > diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
> > index 3c7c64ff3c0a..5f2fa46c7958 100644
> > --- a/drivers/usb/core/hcd.c
> > +++ b/drivers/usb/core/hcd.c
> > @@ -1260,7 +1260,8 @@ void usb_hcd_unlink_urb_from_ep(struct usb_hcd *hcd, struct urb *urb)
> >  EXPORT_SYMBOL_GPL(usb_hcd_unlink_urb_from_ep);
> >
> >  /*
> > - * Some usb host controllers can only perform dma using a small SRAM area.
> > + * Some usb host controllers can only perform dma using a small SRAM area,
> > + * or that have restrictions in addressable DRAM.
>
> s/that //
> s/in/on/

Fixed now.

> Otherwise the USB parts of this look okay to me.  I don't have suitable
> hardware to test either.  (I wonder if anyone is still using this
> platform...)

I assumed Russell was still using the Assabet, but his last upstream
commits for sa1100 are from 2016 (merged in 2019), so that may have
changed in the meantime.

> Acked-by: Alan Stern <stern@rowland.harvard.edu>

Thanks!

       Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@kernel.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Russell King <linux@armlinux.org.uk>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	 Arnd Bergmann <arnd@arndb.de>,
	Linus Walleij <linus.walleij@linaro.org>,
	 Christoph Hellwig <hch@infradead.org>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	 USB list <linux-usb@vger.kernel.org>,
	 Linux ARM <linux-arm-kernel@lists.infradead.org>,
	 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] ARM: sa1100/assabet: move dmabounce hack to ohci driver
Date: Tue, 1 Feb 2022 17:08:15 +0100	[thread overview]
Message-ID: <CAK8P3a1DghU4fm_6OA8=_SG_ODYsnrw0J_Z-kmC9ay1hH=Gqwg@mail.gmail.com> (raw)
In-Reply-To: <YflSNQQvignxL4PA@rowland.harvard.edu>

On Tue, Feb 1, 2022 at 4:31 PM Alan Stern <stern@rowland.harvard.edu> wrote:

> > diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
> > index 3c7c64ff3c0a..5f2fa46c7958 100644
> > --- a/drivers/usb/core/hcd.c
> > +++ b/drivers/usb/core/hcd.c
> > @@ -1260,7 +1260,8 @@ void usb_hcd_unlink_urb_from_ep(struct usb_hcd *hcd, struct urb *urb)
> >  EXPORT_SYMBOL_GPL(usb_hcd_unlink_urb_from_ep);
> >
> >  /*
> > - * Some usb host controllers can only perform dma using a small SRAM area.
> > + * Some usb host controllers can only perform dma using a small SRAM area,
> > + * or that have restrictions in addressable DRAM.
>
> s/that //
> s/in/on/

Fixed now.

> Otherwise the USB parts of this look okay to me.  I don't have suitable
> hardware to test either.  (I wonder if anyone is still using this
> platform...)

I assumed Russell was still using the Assabet, but his last upstream
commits for sa1100 are from 2016 (merged in 2019), so that may have
changed in the meantime.

> Acked-by: Alan Stern <stern@rowland.harvard.edu>

Thanks!

       Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-02-01 16:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-01 15:02 [RFC] ARM: sa1100/assabet: move dmabounce hack to ohci driver Arnd Bergmann
2022-02-01 15:02 ` Arnd Bergmann
2022-02-01 15:31 ` Alan Stern
2022-02-01 15:31   ` Alan Stern
2022-02-01 16:08   ` Arnd Bergmann [this message]
2022-02-01 16:08     ` Arnd Bergmann
2022-02-01 17:10 ` Robin Murphy
2022-02-01 17:10   ` Robin Murphy
2022-02-01 17:48   ` Russell King (Oracle)
2022-02-01 17:48     ` Russell King (Oracle)
2022-02-01 23:10     ` Arnd Bergmann
2022-02-01 23:10       ` Arnd Bergmann
2022-02-02  8:05       ` Arnd Bergmann
2022-02-02  8:05         ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK8P3a1DghU4fm_6OA8=_SG_ODYsnrw0J_Z-kmC9ay1hH=Gqwg@mail.gmail.com' \
    --to=arnd@kernel.org \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@infradead.org \
    --cc=laurentiu.tudor@nxp.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.