From: Arnd Bergmann <arnd@kernel.org>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Nick Desaulniers <ndesaulniers@google.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Wei Yang <richard.weiyang@linux.alibaba.com>,
Arnd Bergmann <arnd@arndb.de>, Vlastimil Babka <vbabka@suse.cz>,
Dmitry Safonov <0x7f454c46@gmail.com>,
Brian Geffon <bgeffon@google.com>, Linux-MM <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
clang-built-linux <clang-built-linux@googlegroups.com>
Subject: Re: [PATCH] mm/mremap: fix BUILD_BUG_ON() error in get_extent
Date: Tue, 5 Jan 2021 11:28:40 +0100 [thread overview]
Message-ID: <CAK8P3a1E3zWHSkNOaKY80ZfZqVuEe11dr_Rop=eDkbmmHo1Z6A@mail.gmail.com> (raw)
In-Reply-To: <20210104223634.GB2562866@ubuntu-m3-large-x86>
On Mon, Jan 4, 2021 at 11:36 PM Nathan Chancellor
<natechancellor@gmail.com> wrote:
>
> I am in agreement with Vlastimil, I would rather see the BUILD_BUG()
> dropped or converted into BUG() instead of papering over with
> __always_inline.
I see your point, but I also generally prefer build-time checks over
runtime ones wherever possible, and would prefer a way to keep
it in a form that allows that, at least if the check is considered useful
at all.
> For what it's worth, I only see this build failure
> with CONFIG_UBSAN_UNSIGNED_OVERFLOW, which you proposed disabling:
>
> https://lore.kernel.org/lkml/20201230154749.746641-1-arnd@kernel.org/
I'm building more randconfig kernels without this patch but with the
__always_inline
reverted now, will see if it comes back. If not, let's just drop this patch.
Arnd
next prev parent reply other threads:[~2021-01-05 10:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-30 15:40 [PATCH] mm/mremap: fix BUILD_BUG_ON() error in get_extent Arnd Bergmann
2021-01-04 11:34 ` Vlastimil Babka
2021-01-04 22:36 ` Nathan Chancellor
2021-01-05 10:28 ` Arnd Bergmann [this message]
2021-01-05 10:28 ` Arnd Bergmann
2021-01-12 19:16 ` Nathan Chancellor
2021-01-12 20:19 ` Sedat Dilek
2021-01-12 20:19 ` Sedat Dilek
2021-02-03 18:48 ` Nathan Chancellor
2021-02-03 20:03 ` Kees Cook
2021-02-05 19:00 ` Nathan Chancellor
2021-02-05 21:02 ` Andrew Morton
2021-02-05 21:27 ` Nathan Chancellor
2021-02-05 18:33 ` Nick Desaulniers
2021-02-05 18:33 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a1E3zWHSkNOaKY80ZfZqVuEe11dr_Rop=eDkbmmHo1Z6A@mail.gmail.com' \
--to=arnd@kernel.org \
--cc=0x7f454c46@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bgeffon@google.com \
--cc=clang-built-linux@googlegroups.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=richard.weiyang@linux.alibaba.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.