From: Arnd Bergmann <arnd@arndb.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: devel@driverdev.osuosl.org,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"Linux Media Mailing List" <linux-media@vger.kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Daeseok Youn" <daeseok.youn@gmail.com>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
adi-buildroot-devel@lists.sourceforge.net,
"Hans Verkuil" <hverkuil@xs4all.nl>,
IDE-ML <linux-ide@vger.kernel.org>,
"Guenter Roeck" <linux@roeck-us.net>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Tejun Heo" <tj@kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Robert Jarzmik" <robert.jarzmik@free.fr>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
"Alan Cox" <alan@linux.intel.com>
Subject: Re: [PATCH 14/14] [media] fix warning on v4l2_subdev_call() result interpreted as bool
Date: Fri, 14 Jul 2017 21:32:25 +0200 [thread overview]
Message-ID: <CAK8P3a1ckDk2VEhK9EWXU7ZWqh1UoZVMac9j3-1KGioj8EE+kw@mail.gmail.com> (raw)
In-Reply-To: <20170714130955.zqe26g6zpixr3xj2@mwanda>
On Fri, Jul 14, 2017 at 3:09 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Fri, Jul 14, 2017 at 03:55:26PM +0300, Dan Carpenter wrote:
>> I don't agree with it as a static analysis dev...
>
> What I mean is if it's a macro that returns -ENODEV or a function that
> returns -ENODEV, they should both be treated the same. The other
> warnings this check prints are quite clever.
I think this is what gcc tries to do, and it should work normally, but it
fails when using ccache. I know I had cases like that, not entirely sure
if this is one of them. Maybe it just means I should give up on using
ccache in preprocessor mode.
Arnd
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: devel@driverdev.osuosl.org, "Hans Verkuil" <hverkuil@xs4all.nl>,
"Alan Cox" <alan@linux.intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Daeseok Youn" <daeseok.youn@gmail.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
adi-buildroot-devel@lists.sourceforge.net,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
IDE-ML <linux-ide@vger.kernel.org>,
"Robert Jarzmik" <robert.jarzmik@free.fr>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Tejun Heo" <tj@kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"Guenter Roeck" <linux@roeck-us.net>,
"Linux Media Mailing List" <linux-media@vger.kernel.org>
Subject: Re: [PATCH 14/14] [media] fix warning on v4l2_subdev_call() result interpreted as bool
Date: Fri, 14 Jul 2017 21:32:25 +0200 [thread overview]
Message-ID: <CAK8P3a1ckDk2VEhK9EWXU7ZWqh1UoZVMac9j3-1KGioj8EE+kw@mail.gmail.com> (raw)
In-Reply-To: <20170714130955.zqe26g6zpixr3xj2@mwanda>
On Fri, Jul 14, 2017 at 3:09 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Fri, Jul 14, 2017 at 03:55:26PM +0300, Dan Carpenter wrote:
>> I don't agree with it as a static analysis dev...
>
> What I mean is if it's a macro that returns -ENODEV or a function that
> returns -ENODEV, they should both be treated the same. The other
> warnings this check prints are quite clever.
I think this is what gcc tries to do, and it should work normally, but it
fails when using ccache. I know I had cases like that, not entirely sure
if this is one of them. Maybe it just means I should give up on using
ccache in preprocessor mode.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 14/14] [media] fix warning on v4l2_subdev_call() result interpreted as bool
Date: Fri, 14 Jul 2017 21:32:25 +0200 [thread overview]
Message-ID: <CAK8P3a1ckDk2VEhK9EWXU7ZWqh1UoZVMac9j3-1KGioj8EE+kw@mail.gmail.com> (raw)
In-Reply-To: <20170714130955.zqe26g6zpixr3xj2@mwanda>
On Fri, Jul 14, 2017 at 3:09 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Fri, Jul 14, 2017 at 03:55:26PM +0300, Dan Carpenter wrote:
>> I don't agree with it as a static analysis dev...
>
> What I mean is if it's a macro that returns -ENODEV or a function that
> returns -ENODEV, they should both be treated the same. The other
> warnings this check prints are quite clever.
I think this is what gcc tries to do, and it should work normally, but it
fails when using ccache. I know I had cases like that, not entirely sure
if this is one of them. Maybe it just means I should give up on using
ccache in preprocessor mode.
Arnd
next prev parent reply other threads:[~2017-07-14 19:32 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-14 9:25 [PATCH 00/14] gcc-7 warnings Arnd Bergmann
2017-07-14 9:25 ` Arnd Bergmann
2017-07-14 9:25 ` [PATCH, RESEND 01/14] ide: avoid warning for timings calculation Arnd Bergmann
2017-07-14 9:25 ` Arnd Bergmann
2017-07-14 9:25 ` [PATCH, RESEND 02/14] ata: avoid gcc-7 warning in ata_timing_quantize Arnd Bergmann
2017-07-14 9:25 ` Arnd Bergmann
2017-07-15 10:56 ` Tejun Heo
2017-07-15 10:56 ` Tejun Heo
2017-07-14 9:25 ` [PATCH, RESEND 03/14] drm/vmwgfx: avoid gcc-7 parentheses warning Arnd Bergmann
2017-07-14 9:25 ` Arnd Bergmann
2017-07-14 10:11 ` Jani Nikula
2017-07-14 10:11 ` Jani Nikula
2017-07-14 19:21 ` Linus Torvalds
2017-07-14 19:21 ` Linus Torvalds
2017-07-14 19:23 ` Linus Torvalds
2017-07-14 20:28 ` Arnd Bergmann
2017-07-17 13:15 ` Sinclair Yeh
2017-07-17 13:15 ` Sinclair Yeh
2017-07-14 9:25 ` [PATCH 04/14] x86: math-emu: avoid -Wint-in-bool-context warning Arnd Bergmann
2017-07-14 9:25 ` Arnd Bergmann
2017-07-14 9:25 ` [PATCH 05/14] isdn: isdnloop: suppress a gcc-7 warning Arnd Bergmann
2017-07-14 9:25 ` Arnd Bergmann
2017-07-14 10:08 ` Joe Perches
2017-07-14 10:37 ` Arnd Bergmann
2017-07-15 4:20 ` Kevin Easton
2017-07-14 9:25 ` [PATCH 06/14] acpi: thermal: fix gcc-6/ccache warning Arnd Bergmann
2017-07-14 9:25 ` Arnd Bergmann
2017-07-14 9:25 ` [PATCH 07/14] proc/kcore: hide a harmless warning Arnd Bergmann
2017-07-14 9:25 ` Arnd Bergmann
2017-07-14 12:28 ` Ard Biesheuvel
2017-07-18 19:53 ` Arnd Bergmann
2017-07-18 19:53 ` Arnd Bergmann
2017-07-18 19:55 ` Ard Biesheuvel
2017-07-18 20:01 ` Arnd Bergmann
2017-07-18 20:07 ` Ard Biesheuvel
2017-07-18 20:21 ` Arnd Bergmann
2017-07-14 9:25 ` [PATCH 08/14] Input: adxl34x - fix gcc-7 -Wint-in-bool-context warning Arnd Bergmann
2017-07-14 9:25 ` Arnd Bergmann
2017-07-14 19:24 ` Linus Torvalds
2017-07-14 20:17 ` Arnd Bergmann
2017-07-14 21:40 ` Dmitry Torokhov
2017-07-14 9:30 ` [PATCH 09/14] SFI: fix tautological-compare warning Arnd Bergmann
2017-07-14 9:30 ` Arnd Bergmann
2017-07-14 9:31 ` [PATCH 10/14] staging:iio:resolver:ad2s1210 fix negative IIO_ANGL_VEL read Arnd Bergmann
2017-07-14 9:31 ` Arnd Bergmann
2017-07-15 11:42 ` Jonathan Cameron
2017-07-14 9:31 ` [PATCH 11/14] IB/uverbs: fix gcc-7 type warning Arnd Bergmann
2017-07-14 9:31 ` Arnd Bergmann
2017-07-14 9:46 ` Leon Romanovsky
2017-07-14 9:31 ` [PATCH 12/14] drm/nouveau/clk: fix gcc-7 -Wint-in-bool-context warning Arnd Bergmann
2017-07-14 9:31 ` Arnd Bergmann
2017-07-14 9:31 ` [PATCH 13/14] iopoll: avoid " Arnd Bergmann
2017-07-14 9:31 ` Arnd Bergmann
2017-07-14 9:55 ` Joe Perches
2017-07-14 10:22 ` Arnd Bergmann
2017-07-14 9:36 ` [PATCH 14/14] [media] fix warning on v4l2_subdev_call() result interpreted as bool Arnd Bergmann
2017-07-14 9:36 ` Arnd Bergmann
2017-07-14 9:36 ` Arnd Bergmann
2017-07-14 12:05 ` Dan Carpenter
2017-07-14 12:05 ` Dan Carpenter
2017-07-14 12:05 ` Dan Carpenter
2017-07-14 12:27 ` Arnd Bergmann
2017-07-14 12:27 ` Arnd Bergmann
2017-07-14 12:27 ` Arnd Bergmann
2017-07-14 12:55 ` Dan Carpenter
2017-07-14 12:55 ` Dan Carpenter
2017-07-14 12:55 ` Dan Carpenter
2017-07-14 13:09 ` Dan Carpenter
2017-07-14 13:09 ` Dan Carpenter
2017-07-14 13:09 ` Dan Carpenter
2017-07-14 19:32 ` Arnd Bergmann [this message]
2017-07-14 19:32 ` Arnd Bergmann
2017-07-14 19:32 ` Arnd Bergmann
2017-07-14 12:41 ` Dan Carpenter
2017-07-14 12:41 ` Dan Carpenter
2017-07-14 12:41 ` Dan Carpenter
2017-07-17 13:45 ` Hans Verkuil
2017-07-17 13:45 ` Hans Verkuil
2017-07-17 14:26 ` Arnd Bergmann
2017-07-17 14:26 ` Arnd Bergmann
2017-07-17 14:26 ` Arnd Bergmann
2017-07-17 14:28 ` Dan Carpenter
2017-07-17 14:28 ` Dan Carpenter
2017-07-17 14:28 ` Dan Carpenter
2017-07-17 14:32 ` Hans Verkuil
2017-07-17 14:32 ` Hans Verkuil
2017-07-17 14:32 ` Hans Verkuil
2017-07-17 14:35 ` Hans Verkuil
2017-07-17 14:35 ` Hans Verkuil
2017-07-17 14:35 ` Hans Verkuil
2017-07-17 21:23 ` Arnd Bergmann
2017-07-17 21:23 ` Arnd Bergmann
2017-07-17 21:23 ` Arnd Bergmann
2017-07-14 10:29 ` [PATCH 00/14] gcc-7 warnings Greg Kroah-Hartman
2017-07-14 10:29 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a1ckDk2VEhK9EWXU7ZWqh1UoZVMac9j3-1KGioj8EE+kw@mail.gmail.com \
--to=arnd@arndb.de \
--cc=adi-buildroot-devel@lists.sourceforge.net \
--cc=akpm@linux-foundation.org \
--cc=alan@linux.intel.com \
--cc=daeseok.youn@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=robert.jarzmik@free.fr \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.