All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Borislav Petkov <bp@alien8.de>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	James Morse <james.morse@arm.com>,
	"Zhuo, Qiuxu" <qiuxu.zhuo@intel.com>,
	"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] EDAC, {skx|i10nm}_edac: Fix randconfig build error
Date: Fri, 22 Mar 2019 20:56:27 +0100	[thread overview]
Message-ID: <CAK8P3a1gOzvWmkupO_5Lhfm17OPkV9FVoSO0qDboms=QRB+4ag@mail.gmail.com> (raw)
In-Reply-To: <20190322175504.GA11213@agluck-desk>

On Fri, Mar 22, 2019 at 6:55 PM Luck, Tony <tony.luck@intel.com> wrote:
>
> On Fri, Mar 22, 2019 at 03:00:25PM +0100, Arnd Bergmann wrote:
> > Sorry, this was my mistake, my email was garbled. The patch was
> > correct though: the idea here is not to change the Kconfig symbols
> > but to change the Makefile to do the right thing even when Kconfig
> > is set wrong.
>
> Well this does seem like a "clever" way out of the randconfig
> problem.  New patch applies and when I set .config to have:
>
> CONFIG_EDAC_DEBUG=y
> CONFIG_EDAC_SKX=y
> CONFIG_EDAC_I10NM=m
> CONFIG_EDAC_SKX_COMMON=y
>
> I don't see any build errors.
>
> There are lots of "skx_" symbols in System.map
>
> But I'm not at all sure what happened to the I10NM driver.
>
> I don't see it mentioned in the output from "make".
>
> It didn't get built as a module (no ".ko" file for it).
>
> It doesn't seem to be built in (no ".o" in drivers/edac/built-in.a)
>
> So I added a #error line to the start of i10nm_edac.c and
> ran "make" again.  Nothing.

Oops, I guess my testing method was also insufficient,
I only checked that the bug was gone, not that it actually
worked.

> So, I don't think this is doing what you think it should
> do.  Even if it did, it would seem very confusing to a user
> that asked for "one module, one built-in" in Kconfig, but
> found both built-in.
>
> Boris: I'm voting for Qiuxu's most recent solution (moving
> all the EDAC_DEBUG bits out of skx_common.c).

Yes, that's probably best then. My patch was likely close to
another correct solution, but I've screwed it up twice now ;-)

     Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Borislav Petkov <bp@alien8.de>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	James Morse <james.morse@arm.com>,
	"Zhuo, Qiuxu" <qiuxu.zhuo@intel.com>,
	"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: EDAC, {skx|i10nm}_edac: Fix randconfig build error
Date: Fri, 22 Mar 2019 20:56:27 +0100	[thread overview]
Message-ID: <CAK8P3a1gOzvWmkupO_5Lhfm17OPkV9FVoSO0qDboms=QRB+4ag@mail.gmail.com> (raw)

On Fri, Mar 22, 2019 at 6:55 PM Luck, Tony <tony.luck@intel.com> wrote:
>
> On Fri, Mar 22, 2019 at 03:00:25PM +0100, Arnd Bergmann wrote:
> > Sorry, this was my mistake, my email was garbled. The patch was
> > correct though: the idea here is not to change the Kconfig symbols
> > but to change the Makefile to do the right thing even when Kconfig
> > is set wrong.
>
> Well this does seem like a "clever" way out of the randconfig
> problem.  New patch applies and when I set .config to have:
>
> CONFIG_EDAC_DEBUG=y
> CONFIG_EDAC_SKX=y
> CONFIG_EDAC_I10NM=m
> CONFIG_EDAC_SKX_COMMON=y
>
> I don't see any build errors.
>
> There are lots of "skx_" symbols in System.map
>
> But I'm not at all sure what happened to the I10NM driver.
>
> I don't see it mentioned in the output from "make".
>
> It didn't get built as a module (no ".ko" file for it).
>
> It doesn't seem to be built in (no ".o" in drivers/edac/built-in.a)
>
> So I added a #error line to the start of i10nm_edac.c and
> ran "make" again.  Nothing.

Oops, I guess my testing method was also insufficient,
I only checked that the bug was gone, not that it actually
worked.

> So, I don't think this is doing what you think it should
> do.  Even if it did, it would seem very confusing to a user
> that asked for "one module, one built-in" in Kconfig, but
> found both built-in.
>
> Boris: I'm voting for Qiuxu's most recent solution (moving
> all the EDAC_DEBUG bits out of skx_common.c).

Yes, that's probably best then. My patch was likely close to
another correct solution, but I've screwed it up twice now ;-)

     Arnd

  reply	other threads:[~2019-03-22 19:56 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-05 13:21 [PATCH] EDAC: i10nm, skx: fix randconfig builds Arnd Bergmann
2019-03-05 13:21 ` Arnd Bergmann
2019-03-05 14:34 ` [PATCH] " Borislav Petkov
2019-03-05 14:34   ` Borislav Petkov
2019-03-06 13:48   ` [PATCH] " Arnd Bergmann
2019-03-06 13:48     ` Arnd Bergmann
2019-03-06 17:58     ` [PATCH] EDAC, {skx|i10nm}_edac: Fix randconfig build error Luck, Tony
2019-03-06 17:58       ` Luck, Tony
2019-03-06 20:15       ` [PATCH] " Arnd Bergmann
2019-03-06 20:15         ` Arnd Bergmann
2019-03-13 23:01         ` [PATCH] " Luck, Tony
2019-03-13 23:01           ` Luck, Tony
2019-03-14  7:09           ` [PATCH] " Arnd Bergmann
2019-03-14  7:09             ` Arnd Bergmann
2019-03-14 11:04             ` [PATCH] " Borislav Petkov
2019-03-14 11:04               ` Borislav Petkov
2019-03-14 21:59               ` [PATCH] " Luck, Tony
2019-03-14 21:59                 ` Luck, Tony
2019-03-15  9:43                 ` [PATCH] " Borislav Petkov
2019-03-15  9:43                   ` Borislav Petkov
2019-03-15 15:57                   ` [PATCH] " Luck, Tony
2019-03-15 15:57                     ` Luck, Tony
2019-03-15 17:37                     ` [PATCH] " Borislav Petkov
2019-03-15 17:37                       ` Borislav Petkov
2019-03-15 17:49                       ` [PATCH] " Luck, Tony
2019-03-15 17:49                         ` Luck, Tony
2019-03-15 18:02                         ` [PATCH] " Borislav Petkov
2019-03-15 18:02                           ` Borislav Petkov
2019-03-15 18:11                           ` [PATCH] " Luck, Tony
2019-03-15 18:11                             ` Luck, Tony
2019-03-15 21:03                             ` [PATCH] " Arnd Bergmann
2019-03-15 21:03                               ` Arnd Bergmann
2019-03-15 21:28                               ` [PATCH] " Luck, Tony
2019-03-15 21:28                                 ` Luck, Tony
2019-03-22 14:00                                 ` [PATCH] " Arnd Bergmann
2019-03-22 14:00                                   ` Arnd Bergmann
2019-03-22 17:55                                   ` [PATCH] " Luck, Tony
2019-03-22 17:55                                     ` Luck, Tony
2019-03-22 19:56                                     ` Arnd Bergmann [this message]
2019-03-22 19:56                                       ` Arnd Bergmann
2019-03-21 22:13                               ` [PATCH] " Luck, Tony
2019-03-21 22:13                                 ` Luck, Tony
2019-03-22 22:59                                 ` [PATCH] " Borislav Petkov
2019-03-22 22:59                                   ` Borislav Petkov
2019-03-22 14:02 [PATCH] " Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK8P3a1gOzvWmkupO_5Lhfm17OPkV9FVoSO0qDboms=QRB+4ag@mail.gmail.com' \
    --to=arnd@arndb.de \
    --cc=bp@alien8.de \
    --cc=james.morse@arm.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=qiuxu.zhuo@intel.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.