All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Michal Suchanek <msuchanek@suse.de>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] macintosh: Do not arbitrarily limit architecture for macintosh drivers.
Date: Wed, 29 Mar 2017 23:29:36 +0200	[thread overview]
Message-ID: <CAK8P3a1qh5YA6-UZnoxVVO_HBp_sbZ_UEwzBnTVtRgYwJg09QQ@mail.gmail.com> (raw)
In-Reply-To: <20170329133318.16189-1-msuchanek@suse.de>

On Wed, Mar 29, 2017 at 3:33 PM, Michal Suchanek <msuchanek@suse.de> wrote:
> The mac mouse emulation is neat solution for notebooks with suboptimal
> touchpads. For historical reason this is available on x86 but not arm or
> mips so remove the limitation.
>
> The other more specific drivers depend on various platform drivers
> anyway so users will not select those by accident.
>
> Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> ---
>  drivers/macintosh/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/macintosh/Kconfig b/drivers/macintosh/Kconfig
> index 97a420c11eed..c23c040bc668 100644
> --- a/drivers/macintosh/Kconfig
> +++ b/drivers/macintosh/Kconfig
> @@ -1,7 +1,6 @@
>
>  menuconfig MACINTOSH_DRIVERS
>         bool "Macintosh device drivers"
> -       depends on PPC || MAC || X86
>         default y if (PPC_PMAC || MAC)
>         ---help---
>           Say Y here to get to see options for devices used with Macintosh
> --

Why not move the mac_hid module to drivers/input instead so
it no longer depends on MACINTOSH_DRIVERS?

For the other mac drivers, it may be helpful to to add '|| COMPILE_TEST'
to the dependency line here to allow building them on ARM (after
you have verified that we can in fact build them all without warnings),
but that would be unrelated.

         Arnd

  reply	other threads:[~2017-03-29 21:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-29 13:33 [PATCH] macintosh: Do not arbitrarily limit architecture for macintosh drivers Michal Suchanek
2017-03-29 21:29 ` Arnd Bergmann [this message]
2017-03-29 22:56   ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK8P3a1qh5YA6-UZnoxVVO_HBp_sbZ_UEwzBnTVtRgYwJg09QQ@mail.gmail.com \
    --to=arnd@arndb.de \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=msuchanek@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.