From: Arnd Bergmann <arnd@arndb.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Jakub Kicinski <kuba@kernel.org>,
David Miller <davem@davemloft.net>,
Networking <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Jonathan Corbet <corbet@lwn.net>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Michael Ellerman <mpe@ellerman.id.au>,
Paul Mackerras <paulus@samba.org>,
sburla@marvell.com, vburru@marvell.com, aayarekar@marvell.com,
Arnd Bergmann <arnd@arndb.de>,
zhangyue1@kylinos.cn,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
"open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Parisc List <linux-parisc@vger.kernel.org>
Subject: Re: [PATCH net-next] eth: de4x5: remove support for Generic DECchip & DIGITAL EtherWORKS PCI/EISA
Date: Thu, 26 May 2022 10:17:14 +0200 [thread overview]
Message-ID: <CAK8P3a1z5_QBMq+X53wN=xP4_00ahrQDpz7Kd3GJCK-9Mn9AQQ@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2205260933520.394690@ramsan.of.borg>
On Thu, May 26, 2022 at 9:43 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Sat, 21 May 2022, Benjamin Herrenschmidt wrote:
> > On Wed, 2022-05-18 at 20:13 -0700, Jakub Kicinski wrote:
> >> Looks like almost all changes to this driver had been tree-wide
> >> refactoring since git era begun. There is one commit from Al
> >> 15 years ago which could potentially be fixing a real bug.
> >>
> >> The driver is using virt_to_bus() and is a real magnet for pointless
> >> cleanups. It seems unlikely to have real users. Let's try to shed
> >> this maintenance burden.
> >>
> >> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> >
> > Removing this driver will kill support for some rather old PowerMac
> > models (some PowerBooks I think, paulus would know). No objection on my
> > part, though. I doubt people still use these things with new kernels
> > but ... who knows ? :-)
>
> Aren't these PCI, and thus working fine with the PCI-only DE2104X
> (dc2104x) or TULIP (dc2114x) drivers?
>
> IIRC, I've initially used the de4x5 driver on Alpha (UDB/Multia) or PPC
> (CHRP), but switched to the TULIP driver later (that was before the
> dc2104x/dc2114x driver split, hence a loooong time ago).
The PCI device IDs say this is correct: there are four IDs in the
de4x5 driver, all of which are also listed in one of the two other
drivers.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Parisc List <linux-parisc@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Jonathan Corbet <corbet@lwn.net>,
sburla@marvell.com,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
"open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Eric Dumazet <edumazet@google.com>,
Paul Mackerras <paulus@samba.org>,
vburru@marvell.com, Networking <netdev@vger.kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
zhangyue1@kylinos.cn, Paolo Abeni <pabeni@redhat.com>,
aayarekar@marvell.com, David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next] eth: de4x5: remove support for Generic DECchip & DIGITAL EtherWORKS PCI/EISA
Date: Thu, 26 May 2022 10:17:14 +0200 [thread overview]
Message-ID: <CAK8P3a1z5_QBMq+X53wN=xP4_00ahrQDpz7Kd3GJCK-9Mn9AQQ@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2205260933520.394690@ramsan.of.borg>
On Thu, May 26, 2022 at 9:43 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Sat, 21 May 2022, Benjamin Herrenschmidt wrote:
> > On Wed, 2022-05-18 at 20:13 -0700, Jakub Kicinski wrote:
> >> Looks like almost all changes to this driver had been tree-wide
> >> refactoring since git era begun. There is one commit from Al
> >> 15 years ago which could potentially be fixing a real bug.
> >>
> >> The driver is using virt_to_bus() and is a real magnet for pointless
> >> cleanups. It seems unlikely to have real users. Let's try to shed
> >> this maintenance burden.
> >>
> >> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> >
> > Removing this driver will kill support for some rather old PowerMac
> > models (some PowerBooks I think, paulus would know). No objection on my
> > part, though. I doubt people still use these things with new kernels
> > but ... who knows ? :-)
>
> Aren't these PCI, and thus working fine with the PCI-only DE2104X
> (dc2104x) or TULIP (dc2114x) drivers?
>
> IIRC, I've initially used the de4x5 driver on Alpha (UDB/Multia) or PPC
> (CHRP), but switched to the TULIP driver later (that was before the
> dc2104x/dc2114x driver split, hence a loooong time ago).
The PCI device IDs say this is correct: there are four IDs in the
de4x5 driver, all of which are also listed in one of the two other
drivers.
Arnd
next prev parent reply other threads:[~2022-05-26 8:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 3:13 [PATCH net-next] eth: de4x5: remove support for Generic DECchip & DIGITAL EtherWORKS PCI/EISA Jakub Kicinski
2022-05-19 3:13 ` Jakub Kicinski
2022-05-20 10:40 ` Michael Ellerman
2022-05-20 10:40 ` Michael Ellerman
2022-05-20 12:30 ` Arnd Bergmann
2022-05-20 12:30 ` Arnd Bergmann
2022-05-21 2:47 ` Benjamin Herrenschmidt
2022-05-21 2:47 ` Benjamin Herrenschmidt
2022-05-26 7:43 ` Geert Uytterhoeven
2022-05-26 7:43 ` Geert Uytterhoeven
2022-05-26 8:17 ` Arnd Bergmann [this message]
2022-05-26 8:17 ` Arnd Bergmann
2022-05-27 0:16 ` Benjamin Herrenschmidt
2022-05-27 0:16 ` Benjamin Herrenschmidt
2022-05-23 10:50 ` patchwork-bot+netdevbpf
2022-05-23 10:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a1z5_QBMq+X53wN=xP4_00ahrQDpz7Kd3GJCK-9Mn9AQQ@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=aayarekar@marvell.com \
--cc=benh@kernel.crashing.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geert@linux-m68k.org \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paulus@samba.org \
--cc=sburla@marvell.com \
--cc=tsbogend@alpha.franken.de \
--cc=vburru@marvell.com \
--cc=zhangyue1@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.