All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Firoz Khan <firoz.khan@linaro.org>
Cc: linux-ia64@vger.kernel.org, Tony Luck <tony.luck@intel.com>,
	Fenghua Yu <fenghua.yu@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	gregkh <gregkh@linuxfoundation.org>,
	Philippe Ombredanne <pombredanne@nexb.com>,
	Kate Stewart <kstewart@linuxfoundation.org>,
	y2038 Mailman List <y2038@lists.linaro.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-arch <linux-arch@vger.kernel.org>,
	Deepa Dinamani <deepa.kernel@gmail.com>,
	Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
Subject: Re: [PATCH v2 7/7] ia64: add __IGNORE* entries in asm/unistd.h
Date: Fri, 28 Sep 2018 14:09:30 +0200	[thread overview]
Message-ID: <CAK8P3a2E2KJApEcwpJgqs9KHuyr-mzE8Y6F+D1E0akpXt8VK_Q@mail.gmail.com> (raw)
In-Reply-To: <1538057720-3392-8-git-send-email-firoz.khan@linaro.org>

On Thu, Sep 27, 2018 at 4:16 PM Firoz Khan <firoz.khan@linaro.org> wrote:
>
> Add __IGNORE* entries for perf_event_open, seccomp, pkey_
> mprotect, pkey_alloc, pkey_free, statx, io_pgetevents and
> rseq in the file asm/unistd.h as it is correct to keep
> __IGNORE* entry in non uapi header asm/unistd.h while uapi/
> asm/unistd.h must hold information only useful for user
> space applications.
>
> Signed-off-by: Firoz Khan <firoz.khan@linaro.org>
> ---

This patch looks wrong: We don't want to ignore the fact that the
syscalls are missing here, we should add them instead. I'd leave
that for a follow-up though, we may want to add further ones that
are currently marked as __IGNORE.

      Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Firoz Khan <firoz.khan@linaro.org>
Cc: linux-ia64@vger.kernel.org, Tony Luck <tony.luck@intel.com>,
	Fenghua Yu <fenghua.yu@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	gregkh <gregkh@linuxfoundation.org>,
	Philippe Ombredanne <pombredanne@nexb.com>,
	Kate Stewart <kstewart@linuxfoundation.org>,
	y2038 Mailman List <y2038@lists.linaro.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-arch <linux-arch@vger.kernel.org>,
	Deepa Dinamani <deepa.kernel@gmail.com>,
	Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
Subject: Re: [PATCH v2 7/7] ia64: add __IGNORE* entries in asm/unistd.h
Date: Fri, 28 Sep 2018 12:09:30 +0000	[thread overview]
Message-ID: <CAK8P3a2E2KJApEcwpJgqs9KHuyr-mzE8Y6F+D1E0akpXt8VK_Q@mail.gmail.com> (raw)
In-Reply-To: <1538057720-3392-8-git-send-email-firoz.khan@linaro.org>

On Thu, Sep 27, 2018 at 4:16 PM Firoz Khan <firoz.khan@linaro.org> wrote:
>
> Add __IGNORE* entries for perf_event_open, seccomp, pkey_
> mprotect, pkey_alloc, pkey_free, statx, io_pgetevents and
> rseq in the file asm/unistd.h as it is correct to keep
> __IGNORE* entry in non uapi header asm/unistd.h while uapi/
> asm/unistd.h must hold information only useful for user
> space applications.
>
> Signed-off-by: Firoz Khan <firoz.khan@linaro.org>
> ---

This patch looks wrong: We don't want to ignore the fact that the
syscalls are missing here, we should add them instead. I'd leave
that for a follow-up though, we may want to add further ones that
are currently marked as __IGNORE.

      Arnd

  reply	other threads:[~2018-09-28 12:09 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-27 14:15 [PATCH v2 0/7] System call table generation support Firoz Khan
2018-09-27 14:27 ` Firoz Khan
2018-09-27 14:15 ` [PATCH v2 1/7] ia64: add __NR_old_getpagesize macro Firoz Khan
2018-09-27 14:27   ` Firoz Khan
2018-09-28 12:11   ` Arnd Bergmann
2018-09-28 12:11     ` Arnd Bergmann
2018-09-28 12:11     ` Arnd Bergmann
2018-10-01 14:18     ` Firoz Khan
2018-10-01 14:30       ` Firoz Khan
2018-10-01 14:44       ` Arnd Bergmann
2018-10-01 14:44         ` Arnd Bergmann
2018-09-27 14:15 ` [PATCH v2 2/7] ia64: replace NR_syscalls macro from asm/unistd.h Firoz Khan
2018-09-27 14:27   ` Firoz Khan
2018-09-27 14:15 ` [PATCH v2 3/7] ia64: add an offset for system call number Firoz Khan
2018-09-27 14:27   ` Firoz Khan
2018-09-27 14:15 ` [PATCH v2 4/7] ia64: replace the system call table entries from entry.S Firoz Khan
2018-09-27 14:27   ` Firoz Khan
2018-09-27 14:15 ` [PATCH v2 5/7] ia64: add system call table generation support Firoz Khan
2018-09-27 14:27   ` Firoz Khan
2018-09-27 14:15 ` [PATCH v2 6/7] ia64: uapi header and system call table file generation Firoz Khan
2018-09-27 14:27   ` Firoz Khan
2018-09-28 12:10   ` Arnd Bergmann
2018-09-28 12:10     ` Arnd Bergmann
2018-10-01 14:15     ` Firoz Khan
2018-10-01 14:27       ` Firoz Khan
2018-09-27 14:15 ` [PATCH v2 7/7] ia64: add __IGNORE* entries in asm/unistd.h Firoz Khan
2018-09-27 14:27   ` Firoz Khan
2018-09-28 12:09   ` Arnd Bergmann [this message]
2018-09-28 12:09     ` Arnd Bergmann
2018-09-28 17:30 ` [PATCH v2 0/7] System call table generation support Luck, Tony
2018-09-28 17:30   ` Luck, Tony
2018-10-01 14:21   ` Firoz Khan
2018-10-01 14:33     ` Firoz Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK8P3a2E2KJApEcwpJgqs9KHuyr-mzE8Y6F+D1E0akpXt8VK_Q@mail.gmail.com \
    --to=arnd@arndb.de \
    --cc=deepa.kernel@gmail.com \
    --cc=fenghua.yu@intel.com \
    --cc=firoz.khan@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcin.juszkiewicz@linaro.org \
    --cc=pombredanne@nexb.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=y2038@lists.linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.