* [PATCH v2] spi-nor: intel-spi: Fix Kconfig dependency to LPC_ICH
@ 2017-10-24 6:59 Bin Meng
2017-10-24 9:21 ` Mika Westerberg
0 siblings, 1 reply; 3+ messages in thread
From: Bin Meng @ 2017-10-24 6:59 UTC (permalink / raw)
To: Mika Westerberg, Arnd Bergmann, Cyrille Pitchen, linux-mtd, linux-kernel
Cc: Stefan Roese
The Intel SPI-NOR driver is dependent on LPC_ICH to get the platform
data. Select it in the Kconfig.
Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---
Changes in v2:
- Enforce dependency on PCI
drivers/mtd/spi-nor/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig
index f26aaa6..abf453a 100644
--- a/drivers/mtd/spi-nor/Kconfig
+++ b/drivers/mtd/spi-nor/Kconfig
@@ -107,8 +107,9 @@ config SPI_INTEL_SPI_PCI
config SPI_INTEL_SPI_PLATFORM
tristate "Intel PCH/PCU SPI flash platform driver" if EXPERT
- depends on X86
+ depends on X86 && PCI
select SPI_INTEL_SPI
+ select LPC_ICH
help
This enables platform support for the Intel PCH/PCU SPI
controller in master mode. This controller is present in modern
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] spi-nor: intel-spi: Fix Kconfig dependency to LPC_ICH
2017-10-24 6:59 [PATCH v2] spi-nor: intel-spi: Fix Kconfig dependency to LPC_ICH Bin Meng
@ 2017-10-24 9:21 ` Mika Westerberg
2017-10-24 10:09 ` Arnd Bergmann
0 siblings, 1 reply; 3+ messages in thread
From: Mika Westerberg @ 2017-10-24 9:21 UTC (permalink / raw)
To: Bin Meng
Cc: Arnd Bergmann, Cyrille Pitchen, linux-mtd, linux-kernel, Stefan Roese
On Mon, Oct 23, 2017 at 11:59:39PM -0700, Bin Meng wrote:
> The Intel SPI-NOR driver is dependent on LPC_ICH to get the platform
> data. Select it in the Kconfig.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>
> ---
>
> Changes in v2:
> - Enforce dependency on PCI
>
> drivers/mtd/spi-nor/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig
> index f26aaa6..abf453a 100644
> --- a/drivers/mtd/spi-nor/Kconfig
> +++ b/drivers/mtd/spi-nor/Kconfig
> @@ -107,8 +107,9 @@ config SPI_INTEL_SPI_PCI
>
> config SPI_INTEL_SPI_PLATFORM
> tristate "Intel PCH/PCU SPI flash platform driver" if EXPERT
> - depends on X86
> + depends on X86 && PCI
It is kind of weird to depend on PCI if we want to enable *platform*
driver but whatever. I would still prefer to have dependency for LPC_ICH
instead.
No strong feelings though - as long as it builds and works fine :-)
> select SPI_INTEL_SPI
> + select LPC_ICH
> help
> This enables platform support for the Intel PCH/PCU SPI
> controller in master mode. This controller is present in modern
> --
> 2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] spi-nor: intel-spi: Fix Kconfig dependency to LPC_ICH
2017-10-24 9:21 ` Mika Westerberg
@ 2017-10-24 10:09 ` Arnd Bergmann
0 siblings, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2017-10-24 10:09 UTC (permalink / raw)
To: Mika Westerberg
Cc: Bin Meng, Cyrille Pitchen, linux-mtd, linux-kernel, Stefan Roese
On Tue, Oct 24, 2017 at 11:21 AM, Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
> On Mon, Oct 23, 2017 at 11:59:39PM -0700, Bin Meng wrote:
>> index f26aaa6..abf453a 100644
>> --- a/drivers/mtd/spi-nor/Kconfig
>> +++ b/drivers/mtd/spi-nor/Kconfig
>> @@ -107,8 +107,9 @@ config SPI_INTEL_SPI_PCI
>>
>> config SPI_INTEL_SPI_PLATFORM
>> tristate "Intel PCH/PCU SPI flash platform driver" if EXPERT
>> - depends on X86
>> + depends on X86 && PCI
>
> It is kind of weird to depend on PCI if we want to enable *platform*
> driver but whatever. I would still prefer to have dependency for LPC_ICH
> instead.
>
> No strong feelings though - as long as it builds and works fine :-)
Agreed, I think we are better off using a dependency here, but
then we should probably do that for all users of LPC_ICH and
change them over as well. I think there are two or three other drivers
that currently select LPC_ICH. Using 'select' like this is generally
a bad idea, but being inconsistent (using both depends and select)
is usually worse.
Arnd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-24 10:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-24 6:59 [PATCH v2] spi-nor: intel-spi: Fix Kconfig dependency to LPC_ICH Bin Meng
2017-10-24 9:21 ` Mika Westerberg
2017-10-24 10:09 ` Arnd Bergmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.