All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: David Howells <dhowells@redhat.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Tina Ruchandani <ruchandani.tina@gmail.com>,
	linux-afs@lists.infradead.org
Subject: Re: [PATCH 1/2] afs: Move UUID struct to linux/uuid.h
Date: Thu, 12 Jan 2017 17:23:57 +0100	[thread overview]
Message-ID: <CAK8P3a2zJzETQh8bQ9YeR0r6HhrpPr6P+gRvE39JuZLM6U1O3A@mail.gmail.com> (raw)
In-Reply-To: <20276.1484237654@warthog.procyon.org.uk>

On Thu, Jan 12, 2017 at 5:14 PM, David Howells <dhowells@redhat.com> wrote:
>> >         reply.ia.uuid[3] = htonl((s8) afs_uuid.clock_seq_hi_and_reserved);
>> >         reply.ia.uuid[4] = htonl((s8) afs_uuid.clock_seq_low);
>> >         for (loop = 0; loop < 6; loop++)
>>
>> Shouldn't this be ntohs() instead of ntohl(), like this:
>>
>>        reply.ia.uuid[1] = htonl(ntohl(afs_uuid.time_mid));
>>        reply.ia.uuid[2] = htonl(ntohl(afs_uuid.time_hi_and_version));
>
> I think you forgot to change ntohl() to ntohs() in that - and you're right.
>
> Okay, how about the attached?

Yes, looks good to me.

      Arnd

  reply	other threads:[~2017-01-12 16:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-12 11:56 [PATCH 1/2] afs: Move UUID struct to linux/uuid.h David Howells
2017-01-12 11:56 ` [PATCH 2/2] afs: Use core kernel UUID generation David Howells
2017-01-12 13:14 ` [PATCH 1/2] afs: Move UUID struct to linux/uuid.h Arnd Bergmann
2017-01-12 14:12 ` David Howells
2017-01-12 15:40   ` Arnd Bergmann
2017-01-12 16:14   ` David Howells
2017-01-12 16:23     ` Arnd Bergmann [this message]
2017-01-12 16:40     ` David Howells
2017-01-13  9:22 ` kbuild test robot
2017-01-13 10:28   ` David Howells
2017-01-13 10:48 ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK8P3a2zJzETQh8bQ9YeR0r6HhrpPr6P+gRvE39JuZLM6U1O3A@mail.gmail.com \
    --to=arnd@arndb.de \
    --cc=dhowells@redhat.com \
    --cc=linux-afs@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ruchandani.tina@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.