From: Arnd Bergmann <arnd@kernel.org> To: Cristian Marussi <cristian.marussi@arm.com> Cc: kbuild test robot <lkp@intel.com>, igor.skalkin@opensynergy.com, kbuild-all@lists.01.org, Linux-MM <linux-mm@kvack.org>, Sudeep Holla <sudeep.holla@arm.com>, peter.hilber@opensynergy.com Subject: Re: [PATCH] firmware: arm_scmi: Fix virtio transport Kconfig dependency Date: Mon, 16 Aug 2021 16:30:10 +0200 [thread overview] Message-ID: <CAK8P3a3+a5z0DuJ45VVHAm2aa3ELM922kqN0YbkPCCMsK3xQWw@mail.gmail.com> (raw) In-Reply-To: <20210816141609.41751-1-cristian.marussi@arm.com> On Mon, Aug 16, 2021 at 4:16 PM Cristian Marussi <cristian.marussi@arm.com> wrote: > > ARM_SCMI_TRANSPORT_VIRTIO is a 'bool' Kconfig used to include support for > the SCMI virtio transport inside the core SCMI stack; a bare transport > dependency attached here to this option, though, cannot be properly > propagated to the parent ARM_SCMI_PROTOCOL option and, as a result, it is > currently possible to configure a Kernel where SCMI core is builtin > and includes support for virtio while VirtIO core is =m. > This allowed combination breaks linking: > > ARM_SCMI_PROTOCOL=y > ARM_SCMI_TRANSPORT_VIRTIO=y > VIRTIO=m > > Bind the dependency in ARM_SCMI_TRANSPORT_VIRTIO to the chosen kind of > compilation of ARM_SCMI_PROTOCOL. > > Reported-by: kernel test robot <lkp@intel.com> > Suggested-by: Arnd Bergmann <arnd@kernel.org> > Signed-off-by: Cristian Marussi <cristian.marussi@arm.com> The description looks good Acked-by: Arnd Bergmann <arnd@arndb.de> > @@ -68,7 +68,7 @@ config ARM_SCMI_TRANSPORT_SMC > > config ARM_SCMI_TRANSPORT_VIRTIO > bool "SCMI transport based on VirtIO" > - depends on VIRTIO > + depends on VIRTIO=y || VIRTIO=ARM_SCMI_PROTOCOL > select ARM_SCMI_HAVE_TRANSPORT > select ARM_SCMI_HAVE_MSG Looking at this again, I noticed that this still needs the explicit 'depends on VIRTIO' line you removed, otherwise the prompt pops up when both VIRTIO and ARM_SCMI_PROTOCOL are disabled. Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@kernel.org> To: kbuild-all@lists.01.org Subject: Re: [PATCH] firmware: arm_scmi: Fix virtio transport Kconfig dependency Date: Mon, 16 Aug 2021 16:30:10 +0200 [thread overview] Message-ID: <CAK8P3a3+a5z0DuJ45VVHAm2aa3ELM922kqN0YbkPCCMsK3xQWw@mail.gmail.com> (raw) In-Reply-To: <20210816141609.41751-1-cristian.marussi@arm.com> [-- Attachment #1: Type: text/plain, Size: 1521 bytes --] On Mon, Aug 16, 2021 at 4:16 PM Cristian Marussi <cristian.marussi@arm.com> wrote: > > ARM_SCMI_TRANSPORT_VIRTIO is a 'bool' Kconfig used to include support for > the SCMI virtio transport inside the core SCMI stack; a bare transport > dependency attached here to this option, though, cannot be properly > propagated to the parent ARM_SCMI_PROTOCOL option and, as a result, it is > currently possible to configure a Kernel where SCMI core is builtin > and includes support for virtio while VirtIO core is =m. > This allowed combination breaks linking: > > ARM_SCMI_PROTOCOL=y > ARM_SCMI_TRANSPORT_VIRTIO=y > VIRTIO=m > > Bind the dependency in ARM_SCMI_TRANSPORT_VIRTIO to the chosen kind of > compilation of ARM_SCMI_PROTOCOL. > > Reported-by: kernel test robot <lkp@intel.com> > Suggested-by: Arnd Bergmann <arnd@kernel.org> > Signed-off-by: Cristian Marussi <cristian.marussi@arm.com> The description looks good Acked-by: Arnd Bergmann <arnd@arndb.de> > @@ -68,7 +68,7 @@ config ARM_SCMI_TRANSPORT_SMC > > config ARM_SCMI_TRANSPORT_VIRTIO > bool "SCMI transport based on VirtIO" > - depends on VIRTIO > + depends on VIRTIO=y || VIRTIO=ARM_SCMI_PROTOCOL > select ARM_SCMI_HAVE_TRANSPORT > select ARM_SCMI_HAVE_MSG Looking at this again, I noticed that this still needs the explicit 'depends on VIRTIO' line you removed, otherwise the prompt pops up when both VIRTIO and ARM_SCMI_PROTOCOL are disabled. Arnd
next prev parent reply other threads:[~2021-08-16 14:30 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-16 14:16 [PATCH] firmware: arm_scmi: Fix virtio transport Kconfig dependency Cristian Marussi 2021-08-16 14:16 ` Cristian Marussi 2021-08-16 14:30 ` Arnd Bergmann [this message] 2021-08-16 14:30 ` Arnd Bergmann 2021-08-16 14:47 ` Cristian Marussi 2021-08-16 14:47 ` Cristian Marussi 2021-08-16 15:29 ` Arnd Bergmann 2021-08-16 15:29 ` Arnd Bergmann 2021-08-19 5:39 ` Sudeep Holla 2021-08-19 5:39 ` Sudeep Holla
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAK8P3a3+a5z0DuJ45VVHAm2aa3ELM922kqN0YbkPCCMsK3xQWw@mail.gmail.com \ --to=arnd@kernel.org \ --cc=cristian.marussi@arm.com \ --cc=igor.skalkin@opensynergy.com \ --cc=kbuild-all@lists.01.org \ --cc=linux-mm@kvack.org \ --cc=lkp@intel.com \ --cc=peter.hilber@opensynergy.com \ --cc=sudeep.holla@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.