From: Arnd Bergmann <arnd@kernel.org> To: Sergei Trofimovich <slyfox@gentoo.org> Cc: "Martin K. Petersen" <martin.petersen@oracle.com>, John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>, Don Brace <don.brace@microchip.com>, linux-ia64@vger.kernel.org, storagedev@microchip.com, linux-scsi <linux-scsi@vger.kernel.org>, jszczype@redhat.com, Scott Benesh <scott.benesh@microchip.com>, Scott Teel <scott.teel@microchip.com>, thenzl@redhat.com, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v2 1/3] hpsa: use __packed on individual structs, not header-wide Date: Tue, 30 Mar 2021 09:30:44 +0200 [thread overview] Message-ID: <CAK8P3a32frskYgoXi2ncOcLfhqcMDssSBp79p7WSRg3VPhmSdA@mail.gmail.com> (raw) In-Reply-To: <20210330071958.3788214-1-slyfox@gentoo.org> On Tue, Mar 30, 2021 at 9:22 AM Sergei Trofimovich <slyfox@gentoo.org> wrote: > > Some of the structs contain `atomic_t` values and are not intended to be > sent to IO controller as is. > > The change adds __packed to every struct and union in the file. > Follow-up commits will fix `atomic_t` problems. > > The commit is a no-op at least on ia64: > $ diff -u <(objdump -d -r old.o) <(objdump -d -r new.o) This looks better to me, but I think it still has the same potential bug in the CommandList definition. Moving from #pragma to annotating the misaligned structures as __packed is more of a cleanup that could be done separately from the bugfix, but it does make it a little more robust. > #define HPSA_INQUIRY 0x12 > struct InquiryData { > u8 data_byte[36]; > -}; > +} __packed; Marking this one and a few others as __packed is a bit silly, but also obviously harmless, and closer to the original version, so that's ok. > @@ -451,7 +452,7 @@ struct CommandList { > bool retry_pending; > struct hpsa_scsi_dev_t *device; > atomic_t refcount; /* Must be last to avoid memset in hpsa_cmd_init() */ > -} __aligned(COMMANDLIST_ALIGNMENT); > +} __packed __aligned(COMMANDLIST_ALIGNMENT); You are still marking CommandList as __packed here, which is what caused the original problem. Please don't mark this one as __packed at all. If there are individual members that you want to be misaligned inside of the structure, you could mark those explicitly. Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@kernel.org> To: Sergei Trofimovich <slyfox@gentoo.org> Cc: "Martin K. Petersen" <martin.petersen@oracle.com>, John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>, Don Brace <don.brace@microchip.com>, linux-ia64@vger.kernel.org, storagedev@microchip.com, linux-scsi <linux-scsi@vger.kernel.org>, jszczype@redhat.com, Scott Benesh <scott.benesh@microchip.com>, Scott Teel <scott.teel@microchip.com>, thenzl@redhat.com, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v2 1/3] hpsa: use __packed on individual structs, not header-wide Date: Tue, 30 Mar 2021 07:30:44 +0000 [thread overview] Message-ID: <CAK8P3a32frskYgoXi2ncOcLfhqcMDssSBp79p7WSRg3VPhmSdA@mail.gmail.com> (raw) In-Reply-To: <20210330071958.3788214-1-slyfox@gentoo.org> On Tue, Mar 30, 2021 at 9:22 AM Sergei Trofimovich <slyfox@gentoo.org> wrote: > > Some of the structs contain `atomic_t` values and are not intended to be > sent to IO controller as is. > > The change adds __packed to every struct and union in the file. > Follow-up commits will fix `atomic_t` problems. > > The commit is a no-op at least on ia64: > $ diff -u <(objdump -d -r old.o) <(objdump -d -r new.o) This looks better to me, but I think it still has the same potential bug in the CommandList definition. Moving from #pragma to annotating the misaligned structures as __packed is more of a cleanup that could be done separately from the bugfix, but it does make it a little more robust. > #define HPSA_INQUIRY 0x12 > struct InquiryData { > u8 data_byte[36]; > -}; > +} __packed; Marking this one and a few others as __packed is a bit silly, but also obviously harmless, and closer to the original version, so that's ok. > @@ -451,7 +452,7 @@ struct CommandList { > bool retry_pending; > struct hpsa_scsi_dev_t *device; > atomic_t refcount; /* Must be last to avoid memset in hpsa_cmd_init() */ > -} __aligned(COMMANDLIST_ALIGNMENT); > +} __packed __aligned(COMMANDLIST_ALIGNMENT); You are still marking CommandList as __packed here, which is what caused the original problem. Please don't mark this one as __packed at all. If there are individual members that you want to be misaligned inside of the structure, you could mark those explicitly. Arnd
next prev parent reply other threads:[~2021-03-30 7:32 UTC|newest] Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <20210222230519.73f3e239@sf> 2021-02-22 23:34 ` 5.11 regression: "ia64: add support for TIF_NOTIFY_SIGNAL" breaks ia64 boot Jens Axboe 2021-02-22 23:34 ` Jens Axboe 2021-02-22 23:55 ` John Paul Adrian Glaubitz 2021-02-22 23:55 ` John Paul Adrian Glaubitz [not found] ` <20210223083507.43b5a6dd@sf> 2021-02-23 9:13 ` John Paul Adrian Glaubitz 2021-02-23 12:36 ` John Paul Adrian Glaubitz 2021-02-23 12:36 ` John Paul Adrian Glaubitz [not found] ` <20210223192743.0198d4a9@sf> [not found] ` <20210302222630.5056f243@sf> 2021-03-02 22:31 ` John Paul Adrian Glaubitz 2021-03-02 22:31 ` John Paul Adrian Glaubitz 2021-03-03 0:22 ` [bisected] 5.12-rc1 hpsa regression: "scsi: hpsa: Correct dev cmds outstanding for retried cmds" breaks hpsa P600 Sergei Trofimovich 2021-03-03 0:22 ` [bisected] 5.12-rc1 hpsa regression: "scsi: hpsa: Correct dev cmds outstanding for retried cmds" bre Sergei Trofimovich 2021-03-03 8:55 ` [bisected] 5.12-rc1 hpsa regression: "scsi: hpsa: Correct dev cmds outstanding for retried cmds" breaks hpsa P600 Sergei Trofimovich 2021-03-03 8:55 ` [bisected] 5.12-rc1 hpsa regression: "scsi: hpsa: Correct dev cmds outstanding for retried cmds" Sergei Trofimovich 2021-03-03 17:33 ` [bisected] 5.12-rc1 hpsa regression: "scsi: hpsa: Correct dev cmds outstanding for retried cmds" breaks hpsa P600 Don.Brace 2021-03-03 17:33 ` [bisected] 5.12-rc1 hpsa regression: "scsi: hpsa: Correct dev cmds outstanding for retried cmds" Don.Brace [not found] ` <20210303220401.501449e5@sf> 2021-03-04 17:00 ` [bisected] 5.12-rc1 hpsa regression: "scsi: hpsa: Correct dev cmds outstanding for retried cmds" breaks hpsa P600 Don.Brace 2021-03-04 17:00 ` [bisected] 5.12-rc1 hpsa regression: "scsi: hpsa: Correct dev cmds outstanding for retried cmds" Don.Brace 2021-03-05 13:26 ` [bisected] 5.12-rc1 hpsa regression: "scsi: hpsa: Correct dev cmds outstanding for retried cmds" breaks hpsa P600 Tomas Henzl 2021-03-05 13:26 ` [bisected] 5.12-rc1 hpsa regression: "scsi: hpsa: Correct dev cmds outstanding for retried cmds" Tomas Henzl 2021-03-12 22:27 ` [PATCH] hpsa: fix boot on ia64 (atomic_t alignment) Sergei Trofimovich 2021-03-12 22:27 ` Sergei Trofimovich 2021-03-16 16:30 ` Don.Brace 2021-03-16 16:30 ` Don.Brace 2021-03-16 18:28 ` Arnd Bergmann 2021-03-16 18:28 ` Arnd Bergmann 2021-03-17 2:25 ` Martin K. Petersen 2021-03-17 2:25 ` Martin K. Petersen 2021-03-17 13:19 ` David Laight 2021-03-17 19:06 ` Don.Brace 2021-03-17 19:06 ` Don.Brace 2021-03-17 17:28 ` John Paul Adrian Glaubitz 2021-03-17 17:28 ` John Paul Adrian Glaubitz 2021-03-27 10:24 ` Sergei Trofimovich 2021-03-24 7:08 ` John Paul Adrian Glaubitz 2021-03-24 7:08 ` John Paul Adrian Glaubitz 2021-03-24 18:37 ` Don.Brace 2021-03-24 18:37 ` Don.Brace 2021-03-29 11:25 ` John Paul Adrian Glaubitz 2021-03-29 11:25 ` John Paul Adrian Glaubitz 2021-03-29 14:22 ` Arnd Bergmann 2021-03-29 14:22 ` Arnd Bergmann 2021-03-30 3:02 ` Martin K. Petersen 2021-03-30 3:02 ` Martin K. Petersen 2021-03-30 7:19 ` [PATCH v2 1/3] hpsa: use __packed on individual structs, not header-wide Sergei Trofimovich 2021-03-30 7:19 ` Sergei Trofimovich 2021-03-30 7:19 ` [PATCH v2 2/3] hpsa: fix boot on ia64 (atomic_t alignment) Sergei Trofimovich 2021-03-30 7:19 ` Sergei Trofimovich 2021-03-30 7:19 ` [PATCH v2 3/3] hpsa: add an assert to prevent from __packed reintroduction Sergei Trofimovich 2021-03-30 7:19 ` Sergei Trofimovich 2021-03-30 7:34 ` Arnd Bergmann 2021-03-30 7:34 ` Arnd Bergmann 2021-04-02 14:40 ` Elliott, Robert (Servers) 2021-04-02 14:40 ` Elliott, Robert (Servers) 2021-04-03 14:51 ` Sergei Trofimovich 2021-04-03 14:51 ` Sergei Trofimovich 2021-03-30 7:30 ` Arnd Bergmann [this message] 2021-03-30 7:30 ` [PATCH v2 1/3] hpsa: use __packed on individual structs, not header-wide Arnd Bergmann 2021-03-30 7:43 ` Arnd Bergmann 2021-03-30 7:43 ` Arnd Bergmann 2021-04-02 3:54 ` Martin K. Petersen 2021-04-02 3:54 ` Martin K. Petersen 2021-04-15 18:41 ` Don.Brace 2021-04-15 18:41 ` Don.Brace 2021-03-05 9:22 ` [bisected] 5.12-rc1 hpsa regression: "scsi: hpsa: Correct dev cmds outstanding for retried cmds" breaks hpsa P600 Geert Uytterhoeven 2021-03-05 9:22 ` [bisected] 5.12-rc1 hpsa regression: "scsi: hpsa: Correct dev cmds outstanding for retried cmds" Geert Uytterhoeven 2021-03-05 13:31 ` [bisected] 5.12-rc1 hpsa regression: "scsi: hpsa: Correct dev cmds outstanding for retried cmds" breaks hpsa P600 Arnd Bergmann 2021-03-05 13:31 ` [bisected] 5.12-rc1 hpsa regression: "scsi: hpsa: Correct dev cmds outstanding for retried cmds" Arnd Bergmann 2021-03-05 20:45 ` [bisected] 5.12-rc1 hpsa regression: "scsi: hpsa: Correct dev cmds outstanding for retried cmds" breaks hpsa P600 Don.Brace 2021-03-05 20:45 ` [bisected] 5.12-rc1 hpsa regression: "scsi: hpsa: Correct dev cmds outstanding for retried cmds" Don.Brace 2021-03-03 15:42 ` [bisected] 5.12-rc1 hpsa regression: "scsi: hpsa: Correct dev cmds outstanding for retried cmds" breaks hpsa P600 Don.Brace 2021-03-03 15:42 ` [bisected] 5.12-rc1 hpsa regression: "scsi: hpsa: Correct dev cmds outstanding for retried cmds" Don.Brace 2021-03-17 17:42 ` 5.11 regression: "ia64: add support for TIF_NOTIFY_SIGNAL" breaks ia64 boot John Paul Adrian Glaubitz 2021-03-17 17:42 ` John Paul Adrian Glaubitz 2021-03-17 17:53 ` John Paul Adrian Glaubitz 2021-03-17 17:53 ` John Paul Adrian Glaubitz [not found] ` <20210222235359.75d1a912@sf> 2021-02-23 0:34 ` Jens Axboe 2021-02-23 0:34 ` Jens Axboe 2021-02-23 0:41 ` Jens Axboe 2021-02-23 0:41 ` Jens Axboe 2021-02-23 0:43 ` Jens Axboe 2021-02-23 0:43 ` Jens Axboe [not found] ` <20210223080830.23bccdbf@sf> 2021-03-02 22:07 ` Sergei Trofimovich 2021-03-02 22:07 ` Sergei Trofimovich 2021-03-02 22:31 ` Jens Axboe 2021-03-02 22:31 ` Jens Axboe [not found] ` <20210302232716.353ed49b@sf> 2021-03-03 0:34 ` Jens Axboe 2021-03-03 0:34 ` Jens Axboe 2021-03-03 3:51 ` Jens Axboe 2021-03-03 3:51 ` Jens Axboe
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAK8P3a32frskYgoXi2ncOcLfhqcMDssSBp79p7WSRg3VPhmSdA@mail.gmail.com \ --to=arnd@kernel.org \ --cc=don.brace@microchip.com \ --cc=glaubitz@physik.fu-berlin.de \ --cc=jszczype@redhat.com \ --cc=linux-ia64@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=scott.benesh@microchip.com \ --cc=scott.teel@microchip.com \ --cc=slyfox@gentoo.org \ --cc=storagedev@microchip.com \ --cc=thenzl@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.