From: Arnd Bergmann <arnd@arndb.de> To: Colin King <colin.king@canonical.com> Cc: Cliff Whickman <cpw@sgi.com>, Robin Holt <robinmholt@gmail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, kernel-janitors@vger.kernel.org, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] sgi-xp: remove redundant pointers ch and rp Date: Tue, 3 Jul 2018 21:32:56 +0200 [thread overview] Message-ID: <CAK8P3a3A_qN_DjfT8ck3Xr87Li6wa8oPEHBMJ-Bu1EONN=jS5w@mail.gmail.com> (raw) In-Reply-To: <20180703072305.29169-1-colin.king@canonical.com> On Tue, Jul 3, 2018 at 9:23 AM, Colin King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > The pointers ch and rp are set but are never used hence they are > redundant and can be removed. > > Cleans up clang warnings: > warning: variable 'ch' set but not used [-Wunused-but-set-variable] > warning: variable 'rp' set but not used [-Wunused-but-set-variable] > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/misc/sgi-xp/xpc_channel.c | 3 --- > drivers/misc/sgi-xp/xpc_partition.c | 3 --- > 2 files changed, 6 deletions(-) > > diff --git a/drivers/misc/sgi-xp/xpc_channel.c b/drivers/misc/sgi-xp/xpc_channel.c > index 128d5615c804..05a890ce2ab8 100644 > --- a/drivers/misc/sgi-xp/xpc_channel.c > +++ b/drivers/misc/sgi-xp/xpc_channel.c > @@ -656,7 +656,6 @@ xpc_initiate_connect(int ch_number) > { > short partid; > struct xpc_partition *part; > - struct xpc_channel *ch; > > DBUG_ON(ch_number < 0 || ch_number >= XPC_MAX_NCHANNELS); > > @@ -664,8 +663,6 @@ xpc_initiate_connect(int ch_number) > part = &xpc_partitions[partid]; > > if (xpc_part_ref(part)) { > - ch = &part->channels[ch_number]; > - > /* > * Initiate the establishment of a connection on the > * newly registered channel to the remote partition. This was left behind in 2005 when the last use of that variable got removed in commit e54af724c1ae ("[IA64-SGI] fixes for XPC disengage and open/close protocol") > diff --git a/drivers/misc/sgi-xp/xpc_partition.c b/drivers/misc/sgi-xp/xpc_partition.c > index 7284413dabfd..4e59b01ad7eb 100644 > --- a/drivers/misc/sgi-xp/xpc_partition.c > +++ b/drivers/misc/sgi-xp/xpc_partition.c > @@ -415,7 +415,6 @@ xpc_discovery(void) > int region_size; > int max_regions; > int nasid; > - struct xpc_rsvd_page *rp; > unsigned long *discovered_nasids; > enum xp_retval ret; > > @@ -432,8 +431,6 @@ xpc_discovery(void) > return; > } > > - rp = (struct xpc_rsvd_page *)xpc_rsvd_page; > - And this one in 4b38fcd48582 ("[IA64-SGI] XPC changes to support more than 2k nasids") Both changes look correct to me, Acked-by: Arnd Bergmann <arnd@arndb.de>
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de> To: Colin King <colin.king@canonical.com> Cc: Cliff Whickman <cpw@sgi.com>, Robin Holt <robinmholt@gmail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, kernel-janitors@vger.kernel.org, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] sgi-xp: remove redundant pointers ch and rp Date: Tue, 03 Jul 2018 19:32:56 +0000 [thread overview] Message-ID: <CAK8P3a3A_qN_DjfT8ck3Xr87Li6wa8oPEHBMJ-Bu1EONN=jS5w@mail.gmail.com> (raw) In-Reply-To: <20180703072305.29169-1-colin.king@canonical.com> On Tue, Jul 3, 2018 at 9:23 AM, Colin King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > The pointers ch and rp are set but are never used hence they are > redundant and can be removed. > > Cleans up clang warnings: > warning: variable 'ch' set but not used [-Wunused-but-set-variable] > warning: variable 'rp' set but not used [-Wunused-but-set-variable] > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/misc/sgi-xp/xpc_channel.c | 3 --- > drivers/misc/sgi-xp/xpc_partition.c | 3 --- > 2 files changed, 6 deletions(-) > > diff --git a/drivers/misc/sgi-xp/xpc_channel.c b/drivers/misc/sgi-xp/xpc_channel.c > index 128d5615c804..05a890ce2ab8 100644 > --- a/drivers/misc/sgi-xp/xpc_channel.c > +++ b/drivers/misc/sgi-xp/xpc_channel.c > @@ -656,7 +656,6 @@ xpc_initiate_connect(int ch_number) > { > short partid; > struct xpc_partition *part; > - struct xpc_channel *ch; > > DBUG_ON(ch_number < 0 || ch_number >= XPC_MAX_NCHANNELS); > > @@ -664,8 +663,6 @@ xpc_initiate_connect(int ch_number) > part = &xpc_partitions[partid]; > > if (xpc_part_ref(part)) { > - ch = &part->channels[ch_number]; > - > /* > * Initiate the establishment of a connection on the > * newly registered channel to the remote partition. This was left behind in 2005 when the last use of that variable got removed in commit e54af724c1ae ("[IA64-SGI] fixes for XPC disengage and open/close protocol") > diff --git a/drivers/misc/sgi-xp/xpc_partition.c b/drivers/misc/sgi-xp/xpc_partition.c > index 7284413dabfd..4e59b01ad7eb 100644 > --- a/drivers/misc/sgi-xp/xpc_partition.c > +++ b/drivers/misc/sgi-xp/xpc_partition.c > @@ -415,7 +415,6 @@ xpc_discovery(void) > int region_size; > int max_regions; > int nasid; > - struct xpc_rsvd_page *rp; > unsigned long *discovered_nasids; > enum xp_retval ret; > > @@ -432,8 +431,6 @@ xpc_discovery(void) > return; > } > > - rp = (struct xpc_rsvd_page *)xpc_rsvd_page; > - And this one in 4b38fcd48582 ("[IA64-SGI] XPC changes to support more than 2k nasids") Both changes look correct to me, Acked-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2018-07-03 19:33 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-07-03 7:23 [PATCH] sgi-xp: remove redundant pointers ch and rp Colin King 2018-07-03 7:23 ` Colin King 2018-07-03 19:32 ` Arnd Bergmann [this message] 2018-07-03 19:32 ` Arnd Bergmann 2018-07-05 16:23 ` Robin Holt 2018-07-05 16:23 ` Robin Holt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAK8P3a3A_qN_DjfT8ck3Xr87Li6wa8oPEHBMJ-Bu1EONN=jS5w@mail.gmail.com' \ --to=arnd@arndb.de \ --cc=colin.king@canonical.com \ --cc=cpw@sgi.com \ --cc=gregkh@linuxfoundation.org \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=robinmholt@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.