From: Arnd Bergmann <arnd@arndb.de>
To: Qin Jian <qinjian@cqplus1.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Rob Herring <robh+dt@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <maz@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Arnd Bergmann <arnd@arndb.de>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
DTML <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-clk <linux-clk@vger.kernel.org>
Subject: Re: [PATCH v12 3/9] reset: Add Sunplus SP7021 reset driver
Date: Thu, 31 Mar 2022 10:59:39 +0200 [thread overview]
Message-ID: <CAK8P3a3dRs=-XdK-Y3eHFJEkXTaCzRCm-YAdiUw_DRUcqHd02w@mail.gmail.com> (raw)
In-Reply-To: <840bf90d4e7ba05fe621cd94101b912162311e41.1648714851.git.qinjian@cqplus1.com>
On Thu, Mar 31, 2022 at 10:29 AM Qin Jian <qinjian@cqplus1.com> wrote:
> +
> +#include <linux/io.h>
> +#include <linux/init.h>
> +#include <linux/mod_devicetable.h>
> +#include <linux/platform_device.h>
> +#include <linux/reset-controller.h>
> +#include <linux/reboot.h>
> +
As commented on the binding header -- it looks again like you are not actually
relying on the header here, so it's almost certainly not needed.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Qin Jian <qinjian@cqplus1.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Rob Herring <robh+dt@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <maz@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Arnd Bergmann <arnd@arndb.de>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
DTML <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-clk <linux-clk@vger.kernel.org>
Subject: Re: [PATCH v12 3/9] reset: Add Sunplus SP7021 reset driver
Date: Thu, 31 Mar 2022 10:59:39 +0200 [thread overview]
Message-ID: <CAK8P3a3dRs=-XdK-Y3eHFJEkXTaCzRCm-YAdiUw_DRUcqHd02w@mail.gmail.com> (raw)
In-Reply-To: <840bf90d4e7ba05fe621cd94101b912162311e41.1648714851.git.qinjian@cqplus1.com>
On Thu, Mar 31, 2022 at 10:29 AM Qin Jian <qinjian@cqplus1.com> wrote:
> +
> +#include <linux/io.h>
> +#include <linux/init.h>
> +#include <linux/mod_devicetable.h>
> +#include <linux/platform_device.h>
> +#include <linux/reset-controller.h>
> +#include <linux/reboot.h>
> +
As commented on the binding header -- it looks again like you are not actually
relying on the header here, so it's almost certainly not needed.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-31 9:35 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 8:29 [PATCH v12 0/9] Add Sunplus SP7021 SoC Support Qin Jian
2022-03-31 8:29 ` Qin Jian
2022-03-31 8:29 ` [PATCH v12 1/9] dt-bindings: arm: sunplus: Add bindings for Sunplus SP7021 SoC boards Qin Jian
2022-03-31 8:29 ` Qin Jian
2022-03-31 8:29 ` [PATCH v12 2/9] dt-bindings: reset: Add bindings for SP7021 reset driver Qin Jian
2022-03-31 8:29 ` Qin Jian
2022-03-31 8:58 ` Arnd Bergmann
2022-03-31 8:58 ` Arnd Bergmann
2022-04-01 8:24 ` qinjian[覃健]
2022-04-01 8:24 ` qinjian[覃健]
2022-03-31 8:29 ` [PATCH v12 3/9] reset: Add Sunplus " Qin Jian
2022-03-31 8:29 ` Qin Jian
2022-03-31 8:59 ` Arnd Bergmann [this message]
2022-03-31 8:59 ` Arnd Bergmann
2022-03-31 8:29 ` [PATCH v12 4/9] dt-bindings: clock: Add bindings for SP7021 clock driver Qin Jian
2022-03-31 8:29 ` Qin Jian
2022-03-31 20:21 ` Krzysztof Kozlowski
2022-03-31 20:21 ` Krzysztof Kozlowski
2022-04-01 9:19 ` qinjian[覃健]
2022-04-01 9:19 ` qinjian[覃健]
2022-04-01 9:32 ` Krzysztof Kozlowski
2022-04-01 9:32 ` Krzysztof Kozlowski
2022-03-31 8:29 ` [PATCH v12 5/9] clk: Add Sunplus " Qin Jian
2022-03-31 8:29 ` Qin Jian
2022-03-31 9:22 ` Arnd Bergmann
2022-03-31 9:22 ` Arnd Bergmann
2022-04-01 9:47 ` qinjian[覃健]
2022-04-01 9:47 ` qinjian[覃健]
2022-04-01 10:09 ` Arnd Bergmann
2022-04-01 10:09 ` Arnd Bergmann
2022-04-02 3:37 ` qinjian[覃健]
2022-04-02 3:37 ` qinjian[覃健]
2022-03-31 8:29 ` [PATCH v12 6/9] dt-bindings: interrupt-controller: Add bindings for SP7021 interrupt controller Qin Jian
2022-03-31 8:29 ` Qin Jian
2022-03-31 20:44 ` Rob Herring
2022-03-31 20:44 ` Rob Herring
2022-04-01 2:29 ` qinjian[覃健]
2022-04-01 2:29 ` qinjian[覃健]
2022-04-01 17:53 ` Rob Herring
2022-04-01 17:53 ` Rob Herring
2022-04-02 2:43 ` qinjian[覃健]
2022-04-02 2:43 ` qinjian[覃健]
2022-03-31 8:29 ` [PATCH v12 7/9] irqchip: Add Sunplus SP7021 interrupt controller driver Qin Jian
2022-03-31 8:29 ` Qin Jian
2022-03-31 9:17 ` Arnd Bergmann
2022-03-31 9:17 ` Arnd Bergmann
2022-04-01 7:17 ` qinjian[覃健]
2022-04-01 7:17 ` qinjian[覃健]
2022-03-31 8:29 ` [PATCH v12 8/9] ARM: sunplus: Add initial support for Sunplus SP7021 SoC Qin Jian
2022-03-31 8:29 ` Qin Jian
2022-03-31 9:03 ` Arnd Bergmann
2022-03-31 9:03 ` Arnd Bergmann
2022-03-31 8:29 ` [PATCH v12 9/9] ARM: sp7021_defconfig: Add Sunplus SP7021 defconfig Qin Jian
2022-03-31 8:29 ` Qin Jian
2022-03-31 9:09 ` Arnd Bergmann
2022-03-31 9:09 ` Arnd Bergmann
2022-04-01 7:08 ` qinjian[覃健]
2022-04-01 7:08 ` qinjian[覃健]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a3dRs=-XdK-Y3eHFJEkXTaCzRCm-YAdiUw_DRUcqHd02w@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maz@kernel.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=qinjian@cqplus1.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.