All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	Wang Kefeng <wangkefeng.wang@huawei.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] amba: Drop builtin_amba_driver()
Date: Wed, 18 May 2022 13:20:59 +0100	[thread overview]
Message-ID: <CAK8P3a3eR-eiY4Y8TNbyQNZiFXoEA8rk5EObZXg-D=JmxjnGCA@mail.gmail.com> (raw)
In-Reply-To: <20220517062929.3109873-1-anshuman.khandual@arm.com>

On Tue, May 17, 2022 at 7:29 AM Anshuman Khandual
<anshuman.khandual@arm.com> wrote:
>
> Drop builtin_amba_driver() which is not used anymore.

The patch looks correct, but I don't see the purpose. Are you trying
to discourage
having amba drivers as built-in? Otherwise the next time we get an amba
driver that cannot be a loadable module, someone might want to add back the
same macro.

        Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>,
	 Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	 Russell King <linux@armlinux.org.uk>,
	Wang Kefeng <wangkefeng.wang@huawei.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] amba: Drop builtin_amba_driver()
Date: Wed, 18 May 2022 13:20:59 +0100	[thread overview]
Message-ID: <CAK8P3a3eR-eiY4Y8TNbyQNZiFXoEA8rk5EObZXg-D=JmxjnGCA@mail.gmail.com> (raw)
In-Reply-To: <20220517062929.3109873-1-anshuman.khandual@arm.com>

On Tue, May 17, 2022 at 7:29 AM Anshuman Khandual
<anshuman.khandual@arm.com> wrote:
>
> Drop builtin_amba_driver() which is not used anymore.

The patch looks correct, but I don't see the purpose. Are you trying
to discourage
having amba drivers as built-in? Otherwise the next time we get an amba
driver that cannot be a loadable module, someone might want to add back the
same macro.

        Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-05-18 12:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-17  6:29 [PATCH] amba: Drop builtin_amba_driver() Anshuman Khandual
2022-05-17  6:29 ` Anshuman Khandual
2022-05-18 12:20 ` Arnd Bergmann [this message]
2022-05-18 12:20   ` Arnd Bergmann
2022-05-19  3:08   ` Anshuman Khandual
2022-05-19  3:08     ` Anshuman Khandual
2022-05-19 10:53     ` Arnd Bergmann
2022-05-19 10:53       ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK8P3a3eR-eiY4Y8TNbyQNZiFXoEA8rk5EObZXg-D=JmxjnGCA@mail.gmail.com' \
    --to=arnd@arndb.de \
    --cc=anshuman.khandual@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=wangkefeng.wang@huawei.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.