From: Arnd Bergmann <arnd@arndb.de>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: Eric Anholt <eric@anholt.net>, John Youn <johnyoun@synopsys.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Felipe Balbi <balbi@kernel.org>,
Minas Harutyunyan <minas.harutyunyan@synopsys.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-usb@vger.kernel.org
Subject: usb: dwc2: Fix endless deferral probe
Date: Tue, 9 Jan 2018 22:33:40 +0100 [thread overview]
Message-ID: <CAK8P3a3eggC=XWLxr-A+pdaXj-0kMZ4aoX3hRyg5tLUknoDeBA@mail.gmail.com> (raw)
On Tue, Jan 9, 2018 at 8:28 PM, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> The dwc2 USB driver tries to find a generic PHY first and then look
> for an old style USB PHY. In case of a valid generic PHY node without
> a PHY driver, the PHY layer will return -EPROBE_DEFER forever. So dwc2
> will never tries for an USB PHY.
>
> Fix this issue by finding a generic PHY and an old style USB PHY
> at once.
This would fix only one of the USB controllers (dwc2), but not the others
that are affected. As I wrote in my suggested patch, dwc3 appears to be
affected the same way, and all other host drivers that call usb_add_hcd()
without first setting hcd->phy would suffer from this as well.
If we go down the route of addressing it here in the hcd drivers, we should
at least change all three of those, and hope this doesn't regress in
another way.
Arnd
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] usb: dwc2: Fix endless deferral probe
Date: Tue, 9 Jan 2018 22:33:40 +0100 [thread overview]
Message-ID: <CAK8P3a3eggC=XWLxr-A+pdaXj-0kMZ4aoX3hRyg5tLUknoDeBA@mail.gmail.com> (raw)
In-Reply-To: <1515526134-2148-1-git-send-email-stefan.wahren@i2se.com>
On Tue, Jan 9, 2018 at 8:28 PM, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> The dwc2 USB driver tries to find a generic PHY first and then look
> for an old style USB PHY. In case of a valid generic PHY node without
> a PHY driver, the PHY layer will return -EPROBE_DEFER forever. So dwc2
> will never tries for an USB PHY.
>
> Fix this issue by finding a generic PHY and an old style USB PHY
> at once.
This would fix only one of the USB controllers (dwc2), but not the others
that are affected. As I wrote in my suggested patch, dwc3 appears to be
affected the same way, and all other host drivers that call usb_add_hcd()
without first setting hcd->phy would suffer from this as well.
If we go down the route of addressing it here in the hcd drivers, we should
at least change all three of those, and hope this doesn't regress in
another way.
Arnd
next reply other threads:[~2018-01-09 21:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 21:33 Arnd Bergmann [this message]
2018-01-09 21:33 ` [PATCH] usb: dwc2: Fix endless deferral probe Arnd Bergmann
-- strict thread matches above, loose matches on Subject: below --
2018-01-12 19:45 Arnd Bergmann
2018-01-12 19:45 ` [PATCH] " Arnd Bergmann
2018-01-12 17:51 Mauro Carvalho Chehab
2018-01-12 17:51 ` [PATCH] " Mauro Carvalho Chehab
2018-01-12 9:18 Arnd Bergmann
2018-01-12 9:18 ` [PATCH] " Arnd Bergmann
2018-01-12 8:06 Stefan Wahren
2018-01-12 8:06 ` [PATCH] " Stefan Wahren
2018-01-11 23:32 Arnd Bergmann
2018-01-11 23:32 ` [PATCH] " Arnd Bergmann
2018-01-10 12:15 Stefan Wahren
2018-01-10 12:15 ` [PATCH] " Stefan Wahren
2018-01-09 19:28 Stefan Wahren
2018-01-09 19:28 ` [PATCH] " Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a3eggC=XWLxr-A+pdaXj-0kMZ4aoX3hRyg5tLUknoDeBA@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=balbi@kernel.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=johnyoun@synopsys.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=minas.harutyunyan@synopsys.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.