* [PATCH 1/1] mtd: diskonchip: Fix incorrect placement of __initdata
@ 2013-08-12 9:40 Sachin Kamat
2013-10-02 20:20 ` Brian Norris
0 siblings, 1 reply; 3+ messages in thread
From: Sachin Kamat @ 2013-08-12 9:40 UTC (permalink / raw)
To: linux-mtd; +Cc: sachin.kamat, artem.bityutskiy, dwmw2, dedekind1
__initdata should be placed between the variable name and equal
sign for the variable to be placed in the intended section.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/mtd/nand/diskonchip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/diskonchip.c b/drivers/mtd/nand/diskonchip.c
index eaa3c29..b68a495 100644
--- a/drivers/mtd/nand/diskonchip.c
+++ b/drivers/mtd/nand/diskonchip.c
@@ -38,7 +38,7 @@
#define CONFIG_MTD_NAND_DISKONCHIP_PROBE_ADDRESS 0
#endif
-static unsigned long __initdata doc_locations[] = {
+static unsigned long doc_locations[] __initdata = {
#if defined (__alpha__) || defined(__i386__) || defined(__x86_64__)
#ifdef CONFIG_MTD_NAND_DISKONCHIP_PROBE_HIGH
0xfffc8000, 0xfffca000, 0xfffcc000, 0xfffce000,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] mtd: diskonchip: Fix incorrect placement of __initdata
2013-08-12 9:40 [PATCH 1/1] mtd: diskonchip: Fix incorrect placement of __initdata Sachin Kamat
@ 2013-10-02 20:20 ` Brian Norris
2013-10-03 7:02 ` Sachin Kamat
0 siblings, 1 reply; 3+ messages in thread
From: Brian Norris @ 2013-10-02 20:20 UTC (permalink / raw)
To: Sachin Kamat; +Cc: artem.bityutskiy, linux-mtd, dwmw2, dedekind1
On Mon, Aug 12, 2013 at 03:10:47PM +0530, Sachin Kamat wrote:
> __initdata should be placed between the variable name and equal
> sign for the variable to be placed in the intended section.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/mtd/nand/diskonchip.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/diskonchip.c b/drivers/mtd/nand/diskonchip.c
> index eaa3c29..b68a495 100644
> --- a/drivers/mtd/nand/diskonchip.c
> +++ b/drivers/mtd/nand/diskonchip.c
> @@ -38,7 +38,7 @@
> #define CONFIG_MTD_NAND_DISKONCHIP_PROBE_ADDRESS 0
> #endif
>
> -static unsigned long __initdata doc_locations[] = {
> +static unsigned long doc_locations[] __initdata = {
> #if defined (__alpha__) || defined(__i386__) || defined(__x86_64__)
> #ifdef CONFIG_MTD_NAND_DISKONCHIP_PROBE_HIGH
> 0xfffc8000, 0xfffca000, 0xfffcc000, 0xfffce000,
Pushed to l2-mtd.git. If you're really interested in seeing this
changed, there are a few other similar places in drivers/mtd/. Feel free
to send a patch.
Thanks,
Brian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] mtd: diskonchip: Fix incorrect placement of __initdata
2013-10-02 20:20 ` Brian Norris
@ 2013-10-03 7:02 ` Sachin Kamat
0 siblings, 0 replies; 3+ messages in thread
From: Sachin Kamat @ 2013-10-03 7:02 UTC (permalink / raw)
To: Brian Norris
Cc: artem.bityutskiy, linux-mtd, David Woodhouse, Artem Bityutskiy
On 3 October 2013 01:50, Brian Norris <computersforpeace@gmail.com> wrote:
> On Mon, Aug 12, 2013 at 03:10:47PM +0530, Sachin Kamat wrote:
>> -static unsigned long __initdata doc_locations[] = {
>> +static unsigned long doc_locations[] __initdata = {
>> #if defined (__alpha__) || defined(__i386__) || defined(__x86_64__)
>> #ifdef CONFIG_MTD_NAND_DISKONCHIP_PROBE_HIGH
>> 0xfffc8000, 0xfffca000, 0xfffcc000, 0xfffce000,
>
> Pushed to l2-mtd.git.
Thanks.
> If you're really interested in seeing this
> changed, there are a few other similar places in drivers/mtd/. Feel free
> to send a patch.
>
Sure. I will take a look at remaining instances and send the necessary patches.
Thanks.
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-10-03 7:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-12 9:40 [PATCH 1/1] mtd: diskonchip: Fix incorrect placement of __initdata Sachin Kamat
2013-10-02 20:20 ` Brian Norris
2013-10-03 7:02 ` Sachin Kamat
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.