[PATCH 1/1] ACPI: ghes: Remove redundant platform_set_drvdata()

[PATCH 1/1] ACPI: ghes: Remove redundant platform_set_drvdata()

[Sachin Kamat]

Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Huang Ying <ying.huang@intel.com>
---
 drivers/acpi/apei/ghes.c |    2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
index d668a8a..e03c20e 100644
--- a/drivers/acpi/apei/ghes.c
+++ b/drivers/acpi/apei/ghes.c
@@ -1011,8 +1011,6 @@ static int ghes_remove(struct platform_device *ghes_dev)
 
 	kfree(ghes);
 
-	platform_set_drvdata(ghes_dev, NULL);
-
 	return 0;
 }
 
-- 
1.7.9.5

Re: [PATCH 1/1] ACPI: ghes: Remove redundant platform_set_drvdata()

[Chen Gong]

[-- Attachment #1: Type: text/plain, Size: 1370 bytes --]

On Wed, May 29, 2013 at 05:16:17PM +0530, Sachin Kamat wrote:
> Date:	Wed, 29 May 2013 17:16:17 +0530
> From: Sachin Kamat <sachin.kamat@linaro.org>
> To: linux-acpi@vger.kernel.org
> Cc: rjw@sisk.pl, lenb@kernel.org, sachin.kamat@linaro.org, Huang Ying
>  <ying.huang@intel.com>
> Subject: [PATCH 1/1] ACPI: ghes: Remove redundant platform_set_drvdata()
> X-Mailer: git-send-email 1.7.9.5
> 
> Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
> driver is bound) removes the need to set driver data field to
> NULL.
> 
Your description doesn't give any meaningful explanation.

> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Huang Ying <ying.huang@intel.com>
> ---
>  drivers/acpi/apei/ghes.c |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> index d668a8a..e03c20e 100644
> --- a/drivers/acpi/apei/ghes.c
> +++ b/drivers/acpi/apei/ghes.c
> @@ -1011,8 +1011,6 @@ static int ghes_remove(struct platform_device *ghes_dev)
>  
>  	kfree(ghes);
>  
> -	platform_set_drvdata(ghes_dev, NULL);
> -
>  	return 0;
>  }
>  
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH 1/1] ACPI: ghes: Remove redundant platform_set_drvdata()

[Sachin Kamat]

On 4 June 2013 08:48, Chen Gong <gong.chen@linux.intel.com> wrote:
> On Wed, May 29, 2013 at 05:16:17PM +0530, Sachin Kamat wrote:
>> Date: Wed, 29 May 2013 17:16:17 +0530
>> From: Sachin Kamat <sachin.kamat@linaro.org>
>> To: linux-acpi@vger.kernel.org
>> Cc: rjw@sisk.pl, lenb@kernel.org, sachin.kamat@linaro.org, Huang Ying
>>  <ying.huang@intel.com>
>> Subject: [PATCH 1/1] ACPI: ghes: Remove redundant platform_set_drvdata()
>> X-Mailer: git-send-email 1.7.9.5
>>
>> Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
>> driver is bound) removes the need to set driver data field to
>> NULL.
>>
> Your description doesn't give any meaningful explanation.

It just means that setting driver data to NULL is not necessary.

-- 
With warm regards,
Sachin

Re: [PATCH 1/1] ACPI: ghes: Remove redundant platform_set_drvdata()

[Rafael J. Wysocki]

On Tuesday, June 04, 2013 09:04:07 AM Sachin Kamat wrote:
> On 4 June 2013 08:48, Chen Gong <gong.chen@linux.intel.com> wrote:
> > On Wed, May 29, 2013 at 05:16:17PM +0530, Sachin Kamat wrote:
> >> Date: Wed, 29 May 2013 17:16:17 +0530
> >> From: Sachin Kamat <sachin.kamat@linaro.org>
> >> To: linux-acpi@vger.kernel.org
> >> Cc: rjw@sisk.pl, lenb@kernel.org, sachin.kamat@linaro.org, Huang Ying
> >>  <ying.huang@intel.com>
> >> Subject: [PATCH 1/1] ACPI: ghes: Remove redundant platform_set_drvdata()
> >> X-Mailer: git-send-email 1.7.9.5
> >>
> >> Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
> >> driver is bound) removes the need to set driver data field to
> >> NULL.
> >>
> > Your description doesn't give any meaningful explanation.
> 
> It just means that setting driver data to NULL is not necessary.

I've queued up the patch for 3.11.

Thanks,
Rafael


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

Re: [PATCH 1/1] ACPI: ghes: Remove redundant platform_set_drvdata()

[Sachin Kamat]

On 4 June 2013 16:40, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> On Tuesday, June 04, 2013 09:04:07 AM Sachin Kamat wrote:
>> On 4 June 2013 08:48, Chen Gong <gong.chen@linux.intel.com> wrote:
>> > On Wed, May 29, 2013 at 05:16:17PM +0530, Sachin Kamat wrote:
>> >> Date: Wed, 29 May 2013 17:16:17 +0530
>> >> From: Sachin Kamat <sachin.kamat@linaro.org>
>> >> To: linux-acpi@vger.kernel.org
>> >> Cc: rjw@sisk.pl, lenb@kernel.org, sachin.kamat@linaro.org, Huang Ying
>> >>  <ying.huang@intel.com>
>> >> Subject: [PATCH 1/1] ACPI: ghes: Remove redundant platform_set_drvdata()
>> >> X-Mailer: git-send-email 1.7.9.5
>> >>
>> >> Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
>> >> driver is bound) removes the need to set driver data field to
>> >> NULL.
>> >>
>> > Your description doesn't give any meaningful explanation.
>>
>> It just means that setting driver data to NULL is not necessary.
>
> I've queued up the patch for 3.11.

Thanks Rafael.


-- 
With warm regards,
Sachin

Re: [PATCH 1/1] ACPI: ghes: Remove redundant platform_set_drvdata()

[Sachin Kamat]

Hi Rafael,

On 4 June 2013 16:40, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> On Tuesday, June 04, 2013 09:04:07 AM Sachin Kamat wrote:
>> On 4 June 2013 08:48, Chen Gong <gong.chen@linux.intel.com> wrote:
>> > On Wed, May 29, 2013 at 05:16:17PM +0530, Sachin Kamat wrote:
>> >> Date: Wed, 29 May 2013 17:16:17 +0530
>> >> From: Sachin Kamat <sachin.kamat@linaro.org>
>> >> To: linux-acpi@vger.kernel.org
>> >> Cc: rjw@sisk.pl, lenb@kernel.org, sachin.kamat@linaro.org, Huang Ying
>> >>  <ying.huang@intel.com>
>> >> Subject: [PATCH 1/1] ACPI: ghes: Remove redundant platform_set_drvdata()
>> >> X-Mailer: git-send-email 1.7.9.5
>> >>
>> >> Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
>> >> driver is bound) removes the need to set driver data field to
>> >> NULL.
>> >>
>> > Your description doesn't give any meaningful explanation.
>>
>> It just means that setting driver data to NULL is not necessary.
>
> I've queued up the patch for 3.11.

Did not find the $subject patch in your merge queue for 3.11 [1].

Also. did not find any patches queued up in MyungJoo Ham's devfreq tree.

[1] https://lkml.org/lkml/2013/6/27/277

With warm regards,
Sachin

Re: [PATCH 1/1] ACPI: ghes: Remove redundant platform_set_drvdata()

[Rafael J. Wysocki]

On Friday, June 28, 2013 02:14:29 PM Sachin Kamat wrote:
> Hi Rafael,
> 
> On 4 June 2013 16:40, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> > On Tuesday, June 04, 2013 09:04:07 AM Sachin Kamat wrote:
> >> On 4 June 2013 08:48, Chen Gong <gong.chen@linux.intel.com> wrote:
> >> > On Wed, May 29, 2013 at 05:16:17PM +0530, Sachin Kamat wrote:
> >> >> Date: Wed, 29 May 2013 17:16:17 +0530
> >> >> From: Sachin Kamat <sachin.kamat@linaro.org>
> >> >> To: linux-acpi@vger.kernel.org
> >> >> Cc: rjw@sisk.pl, lenb@kernel.org, sachin.kamat@linaro.org, Huang Ying
> >> >>  <ying.huang@intel.com>
> >> >> Subject: [PATCH 1/1] ACPI: ghes: Remove redundant platform_set_drvdata()
> >> >> X-Mailer: git-send-email 1.7.9.5
> >> >>
> >> >> Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
> >> >> driver is bound) removes the need to set driver data field to
> >> >> NULL.
> >> >>
> >> > Your description doesn't give any meaningful explanation.
> >>
> >> It just means that setting driver data to NULL is not necessary.
> >
> > I've queued up the patch for 3.11.
> 
> Did not find the $subject patch in your merge queue for 3.11 [1].
> 
> Also. did not find any patches queued up in MyungJoo Ham's devfreq tree.
> 
> [1] https://lkml.org/lkml/2013/6/27/277

This particular patch has to go through the Tony Luck's RAS tree as it
modifies the APEI code.  I dropped it after we had a few patches in two trees
by mistake.

About devfreq status you need to ask MyungJoo Ham.

Thanks,
Rafael


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

Re: [PATCH 1/1] ACPI: ghes: Remove redundant platform_set_drvdata()

[Tony Luck]

On Fri, Jun 28, 2013 at 3:44 AM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> This particular patch has to go through the Tony Luck's RAS tree as it
> modifies the APEI code.  I dropped it after we had a few patches in two trees
> by mistake.

I'll be happy to look at it ... but I do agree with Chen Gong's comment that
your commit message is missing some detail.  It would be nice to see a
call stack that shows where ghes_remove() is called ... pointing out where
we now write the NULL which is making this one redundant.  Since the callers
are via function pointers through the ghes_platform_driver structure, some
simple "grep" is insufficient to show where this function is called from.

Thanks

-Tony