* [PATCH 1/1] ARM: EXYNOS: Fix compilation warning
@ 2014-05-05 9:26 ` Sachin Kamat
0 siblings, 0 replies; 8+ messages in thread
From: Sachin Kamat @ 2014-05-05 9:26 UTC (permalink / raw)
To: linux-arm-kernel
Cc: linux-samsung-soc, devicetree, robh+dt, kgene.kim, sachin.kamat,
Rob Herring
of_get_flat_dt_prop return type is now const.
Fixes the following compilation warning introduced by commit 9d0c4dfedd96
("of/fdt: update of_get_flat_dt_prop in prep for libfdt")
arch/arm/mach-exynos/exynos.c:259:6: warning:
assignment discards ‘const’ qualifier from pointer target type [enabled by default]
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Rob Herring <robh@kernel.org>
---
Based on linux-next (20140505)
---
arch/arm/mach-exynos/exynos.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
index 77293d39dfc9..f356c67a1fa9 100644
--- a/arch/arm/mach-exynos/exynos.c
+++ b/arch/arm/mach-exynos/exynos.c
@@ -249,7 +249,7 @@ static int __init exynos_fdt_map_chipid(unsigned long node, const char *uname,
int depth, void *data)
{
struct map_desc iodesc;
- __be32 *reg;
+ const __be32 *reg;
int len;
if (!of_flat_dt_is_compatible(node, "samsung,exynos4210-chipid") &&
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 1/1] ARM: EXYNOS: Fix compilation warning
@ 2014-05-05 9:26 ` Sachin Kamat
0 siblings, 0 replies; 8+ messages in thread
From: Sachin Kamat @ 2014-05-05 9:26 UTC (permalink / raw)
To: linux-arm-kernel
of_get_flat_dt_prop return type is now const.
Fixes the following compilation warning introduced by commit 9d0c4dfedd96
("of/fdt: update of_get_flat_dt_prop in prep for libfdt")
arch/arm/mach-exynos/exynos.c:259:6: warning:
assignment discards ?const? qualifier from pointer target type [enabled by default]
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Rob Herring <robh@kernel.org>
---
Based on linux-next (20140505)
---
arch/arm/mach-exynos/exynos.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
index 77293d39dfc9..f356c67a1fa9 100644
--- a/arch/arm/mach-exynos/exynos.c
+++ b/arch/arm/mach-exynos/exynos.c
@@ -249,7 +249,7 @@ static int __init exynos_fdt_map_chipid(unsigned long node, const char *uname,
int depth, void *data)
{
struct map_desc iodesc;
- __be32 *reg;
+ const __be32 *reg;
int len;
if (!of_flat_dt_is_compatible(node, "samsung,exynos4210-chipid") &&
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] ARM: EXYNOS: Fix compilation warning
2014-05-05 9:26 ` Sachin Kamat
@ 2014-05-21 11:26 ` Sachin Kamat
-1 siblings, 0 replies; 8+ messages in thread
From: Sachin Kamat @ 2014-05-21 11:26 UTC (permalink / raw)
To: linux-arm-kernel
Cc: linux-samsung-soc, devicetree, robh+dt, Kukjin Kim, Sachin Kamat,
Rob Herring
On 5 May 2014 14:56, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> of_get_flat_dt_prop return type is now const.
> Fixes the following compilation warning introduced by commit 9d0c4dfedd96
> ("of/fdt: update of_get_flat_dt_prop in prep for libfdt")
>
> arch/arm/mach-exynos/exynos.c:259:6: warning:
> assignment discards ‘const’ qualifier from pointer target type [enabled by default]
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Rob Herring <robh@kernel.org>
> ---
> Based on linux-next (20140505)
> ---
> arch/arm/mach-exynos/exynos.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
> index 77293d39dfc9..f356c67a1fa9 100644
> --- a/arch/arm/mach-exynos/exynos.c
> +++ b/arch/arm/mach-exynos/exynos.c
> @@ -249,7 +249,7 @@ static int __init exynos_fdt_map_chipid(unsigned long node, const char *uname,
> int depth, void *data)
> {
> struct map_desc iodesc;
> - __be32 *reg;
> + const __be32 *reg;
> int len;
>
> if (!of_flat_dt_is_compatible(node, "samsung,exynos4210-chipid") &&
> --
> 1.7.9.5
>
Ping. This warning is still seen in latest linux-next.
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/1] ARM: EXYNOS: Fix compilation warning
@ 2014-05-21 11:26 ` Sachin Kamat
0 siblings, 0 replies; 8+ messages in thread
From: Sachin Kamat @ 2014-05-21 11:26 UTC (permalink / raw)
To: linux-arm-kernel
On 5 May 2014 14:56, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> of_get_flat_dt_prop return type is now const.
> Fixes the following compilation warning introduced by commit 9d0c4dfedd96
> ("of/fdt: update of_get_flat_dt_prop in prep for libfdt")
>
> arch/arm/mach-exynos/exynos.c:259:6: warning:
> assignment discards ?const? qualifier from pointer target type [enabled by default]
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Rob Herring <robh@kernel.org>
> ---
> Based on linux-next (20140505)
> ---
> arch/arm/mach-exynos/exynos.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
> index 77293d39dfc9..f356c67a1fa9 100644
> --- a/arch/arm/mach-exynos/exynos.c
> +++ b/arch/arm/mach-exynos/exynos.c
> @@ -249,7 +249,7 @@ static int __init exynos_fdt_map_chipid(unsigned long node, const char *uname,
> int depth, void *data)
> {
> struct map_desc iodesc;
> - __be32 *reg;
> + const __be32 *reg;
> int len;
>
> if (!of_flat_dt_is_compatible(node, "samsung,exynos4210-chipid") &&
> --
> 1.7.9.5
>
Ping. This warning is still seen in latest linux-next.
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] ARM: EXYNOS: Fix compilation warning
2014-05-21 11:26 ` Sachin Kamat
@ 2014-05-22 3:29 ` Tushar Behera
-1 siblings, 0 replies; 8+ messages in thread
From: Tushar Behera @ 2014-05-22 3:29 UTC (permalink / raw)
To: Sachin Kamat, linux-arm-kernel
Cc: linux-samsung-soc, devicetree, robh+dt, Kukjin Kim, Rob Herring
On 05/21/2014 04:56 PM, Sachin Kamat wrote:
> On 5 May 2014 14:56, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>> of_get_flat_dt_prop return type is now const.
>> Fixes the following compilation warning introduced by commit 9d0c4dfedd96
>> ("of/fdt: update of_get_flat_dt_prop in prep for libfdt")
>>
>> arch/arm/mach-exynos/exynos.c:259:6: warning:
>> assignment discards ‘const’ qualifier from pointer target type [enabled by default]
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> Cc: Rob Herring <robh@kernel.org>
>> ---
Change looks good.
Reviewed-by: Tushar Behera <tushar.behera@linaro.org>
>> Based on linux-next (20140505)
>> ---
>> arch/arm/mach-exynos/exynos.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
>> index 77293d39dfc9..f356c67a1fa9 100644
>> --- a/arch/arm/mach-exynos/exynos.c
>> +++ b/arch/arm/mach-exynos/exynos.c
>> @@ -249,7 +249,7 @@ static int __init exynos_fdt_map_chipid(unsigned long node, const char *uname,
>> int depth, void *data)
>> {
>> struct map_desc iodesc;
>> - __be32 *reg;
>> + const __be32 *reg;
>> int len;
>>
>> if (!of_flat_dt_is_compatible(node, "samsung,exynos4210-chipid") &&
>> --
>> 1.7.9.5
>>
>
> Ping. This warning is still seen in latest linux-next.
>
--
Tushar Behera
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/1] ARM: EXYNOS: Fix compilation warning
@ 2014-05-22 3:29 ` Tushar Behera
0 siblings, 0 replies; 8+ messages in thread
From: Tushar Behera @ 2014-05-22 3:29 UTC (permalink / raw)
To: linux-arm-kernel
On 05/21/2014 04:56 PM, Sachin Kamat wrote:
> On 5 May 2014 14:56, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>> of_get_flat_dt_prop return type is now const.
>> Fixes the following compilation warning introduced by commit 9d0c4dfedd96
>> ("of/fdt: update of_get_flat_dt_prop in prep for libfdt")
>>
>> arch/arm/mach-exynos/exynos.c:259:6: warning:
>> assignment discards ?const? qualifier from pointer target type [enabled by default]
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> Cc: Rob Herring <robh@kernel.org>
>> ---
Change looks good.
Reviewed-by: Tushar Behera <tushar.behera@linaro.org>
>> Based on linux-next (20140505)
>> ---
>> arch/arm/mach-exynos/exynos.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
>> index 77293d39dfc9..f356c67a1fa9 100644
>> --- a/arch/arm/mach-exynos/exynos.c
>> +++ b/arch/arm/mach-exynos/exynos.c
>> @@ -249,7 +249,7 @@ static int __init exynos_fdt_map_chipid(unsigned long node, const char *uname,
>> int depth, void *data)
>> {
>> struct map_desc iodesc;
>> - __be32 *reg;
>> + const __be32 *reg;
>> int len;
>>
>> if (!of_flat_dt_is_compatible(node, "samsung,exynos4210-chipid") &&
>> --
>> 1.7.9.5
>>
>
> Ping. This warning is still seen in latest linux-next.
>
--
Tushar Behera
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] ARM: EXYNOS: Fix compilation warning
2014-05-22 3:29 ` Tushar Behera
@ 2014-06-13 14:52 ` Arnd Bergmann
-1 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2014-06-13 14:52 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Tushar Behera, Sachin Kamat, devicetree, linux-samsung-soc,
Kukjin Kim, robh+dt, Rob Herring
On Thursday 22 May 2014, Tushar Behera wrote:
> On 05/21/2014 04:56 PM, Sachin Kamat wrote:
> > On 5 May 2014 14:56, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> >> of_get_flat_dt_prop return type is now const.
> >> Fixes the following compilation warning introduced by commit 9d0c4dfedd96
> >> ("of/fdt: update of_get_flat_dt_prop in prep for libfdt")
> >>
> >> arch/arm/mach-exynos/exynos.c:259:6: warning:
> >> assignment discards ‘const’ qualifier from pointer target type [enabled by default]
> >>
> >> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> >> Cc: Rob Herring <robh@kernel.org>
> >> ---
>
> Change looks good.
>
> Reviewed-by: Tushar Behera <tushar.behera@linaro.org>
This hasn't shown up in linux-next yet, and hte bug is still there, so I'm applying
it directly to the fixes branch in arm-soc before we get more people sending
the same patch. Thanks!
Arnd
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/1] ARM: EXYNOS: Fix compilation warning
@ 2014-06-13 14:52 ` Arnd Bergmann
0 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2014-06-13 14:52 UTC (permalink / raw)
To: linux-arm-kernel
On Thursday 22 May 2014, Tushar Behera wrote:
> On 05/21/2014 04:56 PM, Sachin Kamat wrote:
> > On 5 May 2014 14:56, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> >> of_get_flat_dt_prop return type is now const.
> >> Fixes the following compilation warning introduced by commit 9d0c4dfedd96
> >> ("of/fdt: update of_get_flat_dt_prop in prep for libfdt")
> >>
> >> arch/arm/mach-exynos/exynos.c:259:6: warning:
> >> assignment discards ?const? qualifier from pointer target type [enabled by default]
> >>
> >> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> >> Cc: Rob Herring <robh@kernel.org>
> >> ---
>
> Change looks good.
>
> Reviewed-by: Tushar Behera <tushar.behera@linaro.org>
This hasn't shown up in linux-next yet, and hte bug is still there, so I'm applying
it directly to the fixes branch in arm-soc before we get more people sending
the same patch. Thanks!
Arnd
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-06-13 14:52 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-05 9:26 [PATCH 1/1] ARM: EXYNOS: Fix compilation warning Sachin Kamat
2014-05-05 9:26 ` Sachin Kamat
2014-05-21 11:26 ` Sachin Kamat
2014-05-21 11:26 ` Sachin Kamat
2014-05-22 3:29 ` Tushar Behera
2014-05-22 3:29 ` Tushar Behera
2014-06-13 14:52 ` Arnd Bergmann
2014-06-13 14:52 ` Arnd Bergmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.