* Warnings related to anonymous unions in s5p-tv driver
@ 2013-05-17 8:24 Sachin Kamat
2013-05-21 7:50 ` Sachin Kamat
2013-05-21 9:28 ` Hans Verkuil
0 siblings, 2 replies; 5+ messages in thread
From: Sachin Kamat @ 2013-05-17 8:24 UTC (permalink / raw)
To: Hans Verkuil
Cc: linux-media, Sylwester Nawrocki, Tomasz Stanislawski, hans.verkuil
Hi Hans,
I noticed the following sparse warnings with S5P HDMI driver which I
think got introduced due to the following commit:
5efb54b2b7b ([media] s5p-tv: add dv_timings support for hdmi)
Warnings:
drivers/media/platform/s5p-tv/hdmi_drv.c:483:18: error: unknown field
name in initializer
drivers/media/platform/s5p-tv/hdmi_drv.c:484:18: error: unknown field
name in initializer
drivers/media/platform/s5p-tv/hdmi_drv.c:485:18: error: unknown field
name in initializer
drivers/media/platform/s5p-tv/hdmi_drv.c:486:18: error: unknown field
name in initializer
drivers/media/platform/s5p-tv/hdmi_drv.c:487:18: error: unknown field
name in initializer
drivers/media/platform/s5p-tv/hdmi_drv.c:488:18: error: unknown field
name in initializer
drivers/media/platform/s5p-tv/hdmi_drv.c:489:18: error: unknown field
name in initializer
drivers/media/platform/s5p-tv/hdmi_drv.c:490:18: error: unknown field
name in initializer
drivers/media/platform/s5p-tv/hdmi_drv.c:491:18: error: unknown field
name in initializer
drivers/media/platform/s5p-tv/hdmi_drv.c:492:18: error: unknown field
name in initializer
This looks like the anonymous union initialization problem with GCC.
Surprisingly I get this with GCC 4.6, 4.7 and 4.8 as well.
If I add additional braces to the macro V4L2_INIT_BT_TIMINGS like done
for GCC version < 4.6
like
{ .bt = { _width , ## args } }
or if I change the GNUC_MINOR comparison to 9 like (__GNUC_MINOR__ < 9)
I dont see this error.
I am using the Linaro GCC toolchain.
I am not sure if this has already been reported and/or fixed.
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Warnings related to anonymous unions in s5p-tv driver
2013-05-17 8:24 Warnings related to anonymous unions in s5p-tv driver Sachin Kamat
@ 2013-05-21 7:50 ` Sachin Kamat
2013-05-21 9:28 ` Hans Verkuil
1 sibling, 0 replies; 5+ messages in thread
From: Sachin Kamat @ 2013-05-21 7:50 UTC (permalink / raw)
To: Hans Verkuil
Cc: linux-media, Sylwester Nawrocki, Tomasz Stanislawski, hans.verkuil
On 17 May 2013 13:54, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Hi Hans,
>
> I noticed the following sparse warnings with S5P HDMI driver which I
> think got introduced due to the following commit:
> 5efb54b2b7b ([media] s5p-tv: add dv_timings support for hdmi)
>
> Warnings:
> drivers/media/platform/s5p-tv/hdmi_drv.c:483:18: error: unknown field
> name in initializer
> drivers/media/platform/s5p-tv/hdmi_drv.c:484:18: error: unknown field
> name in initializer
> drivers/media/platform/s5p-tv/hdmi_drv.c:485:18: error: unknown field
> name in initializer
> drivers/media/platform/s5p-tv/hdmi_drv.c:486:18: error: unknown field
> name in initializer
> drivers/media/platform/s5p-tv/hdmi_drv.c:487:18: error: unknown field
> name in initializer
> drivers/media/platform/s5p-tv/hdmi_drv.c:488:18: error: unknown field
> name in initializer
> drivers/media/platform/s5p-tv/hdmi_drv.c:489:18: error: unknown field
> name in initializer
> drivers/media/platform/s5p-tv/hdmi_drv.c:490:18: error: unknown field
> name in initializer
> drivers/media/platform/s5p-tv/hdmi_drv.c:491:18: error: unknown field
> name in initializer
> drivers/media/platform/s5p-tv/hdmi_drv.c:492:18: error: unknown field
> name in initializer
>
> This looks like the anonymous union initialization problem with GCC.
> Surprisingly I get this with GCC 4.6, 4.7 and 4.8 as well.
>
> If I add additional braces to the macro V4L2_INIT_BT_TIMINGS like done
> for GCC version < 4.6
> like
> { .bt = { _width , ## args } }
>
> or if I change the GNUC_MINOR comparison to 9 like (__GNUC_MINOR__ < 9)
> I dont see this error.
>
> I am using the Linaro GCC toolchain.
>
> I am not sure if this has already been reported and/or fixed.
Ping Hans..
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Warnings related to anonymous unions in s5p-tv driver
2013-05-17 8:24 Warnings related to anonymous unions in s5p-tv driver Sachin Kamat
2013-05-21 7:50 ` Sachin Kamat
@ 2013-05-21 9:28 ` Hans Verkuil
2013-05-22 11:05 ` Sachin Kamat
1 sibling, 1 reply; 5+ messages in thread
From: Hans Verkuil @ 2013-05-21 9:28 UTC (permalink / raw)
To: Sachin Kamat
Cc: linux-media, Sylwester Nawrocki, Tomasz Stanislawski, hans.verkuil
On Fri 17 May 2013 10:24:50 Sachin Kamat wrote:
> Hi Hans,
>
> I noticed the following sparse warnings with S5P HDMI driver which I
> think got introduced due to the following commit:
> 5efb54b2b7b ([media] s5p-tv: add dv_timings support for hdmi)
>
> Warnings:
> drivers/media/platform/s5p-tv/hdmi_drv.c:483:18: error: unknown field
> name in initializer
> drivers/media/platform/s5p-tv/hdmi_drv.c:484:18: error: unknown field
> name in initializer
> drivers/media/platform/s5p-tv/hdmi_drv.c:485:18: error: unknown field
> name in initializer
> drivers/media/platform/s5p-tv/hdmi_drv.c:486:18: error: unknown field
> name in initializer
> drivers/media/platform/s5p-tv/hdmi_drv.c:487:18: error: unknown field
> name in initializer
> drivers/media/platform/s5p-tv/hdmi_drv.c:488:18: error: unknown field
> name in initializer
> drivers/media/platform/s5p-tv/hdmi_drv.c:489:18: error: unknown field
> name in initializer
> drivers/media/platform/s5p-tv/hdmi_drv.c:490:18: error: unknown field
> name in initializer
> drivers/media/platform/s5p-tv/hdmi_drv.c:491:18: error: unknown field
> name in initializer
> drivers/media/platform/s5p-tv/hdmi_drv.c:492:18: error: unknown field
> name in initializer
>
> This looks like the anonymous union initialization problem with GCC.
> Surprisingly I get this with GCC 4.6, 4.7 and 4.8 as well.
>
> If I add additional braces to the macro V4L2_INIT_BT_TIMINGS like done
> for GCC version < 4.6
> like
> { .bt = { _width , ## args } }
>
> or if I change the GNUC_MINOR comparison to 9 like (__GNUC_MINOR__ < 9)
> I dont see this error.
>
> I am using the Linaro GCC toolchain.
>
> I am not sure if this has already been reported and/or fixed.
>
Could it be that a different compiler version is used when using sparse?
I don't see these errors when running sparse during the daily build.
Regards,
Hans
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Warnings related to anonymous unions in s5p-tv driver
2013-05-21 9:28 ` Hans Verkuil
@ 2013-05-22 11:05 ` Sachin Kamat
2013-05-22 11:11 ` Hans Verkuil
0 siblings, 1 reply; 5+ messages in thread
From: Sachin Kamat @ 2013-05-22 11:05 UTC (permalink / raw)
To: Hans Verkuil
Cc: linux-media, Sylwester Nawrocki, Tomasz Stanislawski, hans.verkuil
On 21 May 2013 14:58, Hans Verkuil <hverkuil@xs4all.nl> wrote:
> On Fri 17 May 2013 10:24:50 Sachin Kamat wrote:
>> Hi Hans,
>>
>> I noticed the following sparse warnings with S5P HDMI driver which I
>> think got introduced due to the following commit:
>> 5efb54b2b7b ([media] s5p-tv: add dv_timings support for hdmi)
>>
>> Warnings:
>> drivers/media/platform/s5p-tv/hdmi_drv.c:483:18: error: unknown field
>> name in initializer
>> drivers/media/platform/s5p-tv/hdmi_drv.c:484:18: error: unknown field
>> name in initializer
>> drivers/media/platform/s5p-tv/hdmi_drv.c:485:18: error: unknown field
>> name in initializer
>> drivers/media/platform/s5p-tv/hdmi_drv.c:486:18: error: unknown field
>> name in initializer
>> drivers/media/platform/s5p-tv/hdmi_drv.c:487:18: error: unknown field
>> name in initializer
>> drivers/media/platform/s5p-tv/hdmi_drv.c:488:18: error: unknown field
>> name in initializer
>> drivers/media/platform/s5p-tv/hdmi_drv.c:489:18: error: unknown field
>> name in initializer
>> drivers/media/platform/s5p-tv/hdmi_drv.c:490:18: error: unknown field
>> name in initializer
>> drivers/media/platform/s5p-tv/hdmi_drv.c:491:18: error: unknown field
>> name in initializer
>> drivers/media/platform/s5p-tv/hdmi_drv.c:492:18: error: unknown field
>> name in initializer
>>
>> This looks like the anonymous union initialization problem with GCC.
>> Surprisingly I get this with GCC 4.6, 4.7 and 4.8 as well.
>>
>> If I add additional braces to the macro V4L2_INIT_BT_TIMINGS like done
>> for GCC version < 4.6
>> like
>> { .bt = { _width , ## args } }
>>
>> or if I change the GNUC_MINOR comparison to 9 like (__GNUC_MINOR__ < 9)
>> I dont see this error.
>>
>> I am using the Linaro GCC toolchain.
>>
>> I am not sure if this has already been reported and/or fixed.
>>
>
> Could it be that a different compiler version is used when using sparse?
> I don't see these errors when running sparse during the daily build.
Please let me know your compiler version. I could probably try with it and see.
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Warnings related to anonymous unions in s5p-tv driver
2013-05-22 11:05 ` Sachin Kamat
@ 2013-05-22 11:11 ` Hans Verkuil
0 siblings, 0 replies; 5+ messages in thread
From: Hans Verkuil @ 2013-05-22 11:11 UTC (permalink / raw)
To: Sachin Kamat
Cc: linux-media, Sylwester Nawrocki, Tomasz Stanislawski, hans.verkuil
On Wed 22 May 2013 13:05:29 Sachin Kamat wrote:
> On 21 May 2013 14:58, Hans Verkuil <hverkuil@xs4all.nl> wrote:
> > On Fri 17 May 2013 10:24:50 Sachin Kamat wrote:
> >> Hi Hans,
> >>
> >> I noticed the following sparse warnings with S5P HDMI driver which I
> >> think got introduced due to the following commit:
> >> 5efb54b2b7b ([media] s5p-tv: add dv_timings support for hdmi)
> >>
> >> Warnings:
> >> drivers/media/platform/s5p-tv/hdmi_drv.c:483:18: error: unknown field
> >> name in initializer
> >> drivers/media/platform/s5p-tv/hdmi_drv.c:484:18: error: unknown field
> >> name in initializer
> >> drivers/media/platform/s5p-tv/hdmi_drv.c:485:18: error: unknown field
> >> name in initializer
> >> drivers/media/platform/s5p-tv/hdmi_drv.c:486:18: error: unknown field
> >> name in initializer
> >> drivers/media/platform/s5p-tv/hdmi_drv.c:487:18: error: unknown field
> >> name in initializer
> >> drivers/media/platform/s5p-tv/hdmi_drv.c:488:18: error: unknown field
> >> name in initializer
> >> drivers/media/platform/s5p-tv/hdmi_drv.c:489:18: error: unknown field
> >> name in initializer
> >> drivers/media/platform/s5p-tv/hdmi_drv.c:490:18: error: unknown field
> >> name in initializer
> >> drivers/media/platform/s5p-tv/hdmi_drv.c:491:18: error: unknown field
> >> name in initializer
> >> drivers/media/platform/s5p-tv/hdmi_drv.c:492:18: error: unknown field
> >> name in initializer
> >>
> >> This looks like the anonymous union initialization problem with GCC.
> >> Surprisingly I get this with GCC 4.6, 4.7 and 4.8 as well.
> >>
> >> If I add additional braces to the macro V4L2_INIT_BT_TIMINGS like done
> >> for GCC version < 4.6
> >> like
> >> { .bt = { _width , ## args } }
> >>
> >> or if I change the GNUC_MINOR comparison to 9 like (__GNUC_MINOR__ < 9)
> >> I dont see this error.
> >>
> >> I am using the Linaro GCC toolchain.
> >>
> >> I am not sure if this has already been reported and/or fixed.
> >>
> >
> > Could it be that a different compiler version is used when using sparse?
> > I don't see these errors when running sparse during the daily build.
>
> Please let me know your compiler version. I could probably try with it and see.
For the sparse run I suspect it is using the standard compiler which is version
4.7.2. It might use a 4.8.0 cross-compiler, but certainly nothing older than 4.7.2.
Regards,
Hans
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-05-22 11:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-17 8:24 Warnings related to anonymous unions in s5p-tv driver Sachin Kamat
2013-05-21 7:50 ` Sachin Kamat
2013-05-21 9:28 ` Hans Verkuil
2013-05-22 11:05 ` Sachin Kamat
2013-05-22 11:11 ` Hans Verkuil
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.