* [PATCH 0/2] Add device tree and clock support for Gscaler.
@ 2012-07-06 12:45 Shaik Ameer Basha
2012-07-06 12:45 ` [PATCH 1/2] ARM: EXYNOS5: Add " Shaik Ameer Basha
2012-07-06 12:45 ` [PATCH 2/2] ARM: EXYNOS5: Add gscalar device from DT Shaik Ameer Basha
0 siblings, 2 replies; 7+ messages in thread
From: Shaik Ameer Basha @ 2012-07-06 12:45 UTC (permalink / raw)
To: linux-samsung-soc
Cc: kgene.kim, olofj, prashanth.g, joshi, ameersk, thomas.ab
This patch series adds clock support for Gscaler and device node
entries for Gscaler on exynos5.
This patch is based Kukjin Kim's for-next branch.
https://github.com/kgene/linux-samsung.git
Shaik Ameer Basha (2):
ARM: EXYNOS5: Add clock support for Gscaler
ARM: EXYNOS5: Add gscalar device from DT
arch/arm/boot/dts/exynos5250.dtsi | 31 ++++++++++++
arch/arm/mach-exynos/clock-exynos5.c | 79 ++++++++++++++++++++++++++++++++
arch/arm/mach-exynos/mach-exynos5-dt.c | 8 +++
3 files changed, 118 insertions(+), 0 deletions(-)
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] ARM: EXYNOS5: Add clock support for Gscaler
2012-07-06 12:45 [PATCH 0/2] Add device tree and clock support for Gscaler Shaik Ameer Basha
@ 2012-07-06 12:45 ` Shaik Ameer Basha
2012-07-06 15:00 ` Sachin Kamat
2012-07-06 12:45 ` [PATCH 2/2] ARM: EXYNOS5: Add gscalar device from DT Shaik Ameer Basha
1 sibling, 1 reply; 7+ messages in thread
From: Shaik Ameer Basha @ 2012-07-06 12:45 UTC (permalink / raw)
To: linux-samsung-soc
Cc: kgene.kim, olofj, prashanth.g, joshi, ameersk, thomas.ab
Add required clock support for Gscaler for exynos5
Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
Signed-off-by: Prathyush K <prathyush.k@samsung.com>
Signed-off-by: Shaik Ameer Basha <shaik.ameer@samsung.com>
---
arch/arm/mach-exynos/clock-exynos5.c | 79 ++++++++++++++++++++++++++++++++++
1 files changed, 79 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-exynos/clock-exynos5.c b/arch/arm/mach-exynos/clock-exynos5.c
index fefa336..49f98cd 100644
--- a/arch/arm/mach-exynos/clock-exynos5.c
+++ b/arch/arm/mach-exynos/clock-exynos5.c
@@ -741,6 +741,26 @@ static struct clk exynos5_init_clocks_off[] = {
.enable = exynos5_clk_ip_peric_ctrl,
.ctrlbit = (1 << 14),
}, {
+ .name = "gscl",
+ .devname = "exynos-gsc.0",
+ .enable = exynos5_clk_ip_gscl_ctrl,
+ .ctrlbit = (1 << 0),
+ }, {
+ .name = "gscl",
+ .devname = "exynos-gsc.1",
+ .enable = exynos5_clk_ip_gscl_ctrl,
+ .ctrlbit = (1 << 1),
+ }, {
+ .name = "gscl",
+ .devname = "exynos-gsc.2",
+ .enable = exynos5_clk_ip_gscl_ctrl,
+ .ctrlbit = (1 << 2),
+ }, {
+ .name = "gscl",
+ .devname = "exynos-gsc.3",
+ .enable = exynos5_clk_ip_gscl_ctrl,
+ .ctrlbit = (1 << 3),
+ }, {
.name = SYSMMU_CLOCK_NAME,
.devname = SYSMMU_CLOCK_DEVNAME(mfc_l, 0),
.enable = &exynos5_clk_ip_mfc_ctrl,
@@ -1116,6 +1136,61 @@ static struct clksrc_clk exynos5_clksrcs[] = {
},
};
+/* For ACLK_300_gscl_mid */
+static struct clksrc_clk exynos5_clk_mout_aclk_300_gscl_mid = {
+ .clk = {
+ .name = "mout_aclk_300_gscl_mid",
+ },
+ .sources = &exynos5_clkset_aclk,
+ .reg_src = { .reg = EXYNOS5_CLKSRC_TOP0, .shift = 24, .size = 1 },
+};
+
+/* For ACLK_300_gscl */
+struct clk *exynos5_clkset_aclk_300_gscl_list[] = {
+ [0] = &exynos5_clk_mout_aclk_300_gscl_mid.clk,
+ [1] = &exynos5_clk_sclk_vpll.clk,
+};
+
+struct clksrc_sources exynos5_clkset_aclk_300_gscl = {
+ .sources = exynos5_clkset_aclk_300_gscl_list,
+ .nr_sources = ARRAY_SIZE(exynos5_clkset_aclk_300_gscl_list),
+};
+
+static struct clksrc_clk exynos5_clk_mout_aclk_300_gscl = {
+ .clk = {
+ .name = "mout_aclk_300_gscl",
+ },
+ .sources = &exynos5_clkset_aclk_300_gscl,
+ .reg_src = { .reg = EXYNOS5_CLKSRC_TOP0, .shift = 25, .size = 1 },
+};
+
+static struct clksrc_clk exynos5_clk_dout_aclk_300_gscl = {
+ .clk = {
+ .name = "dout_aclk_300_gscl",
+ .parent = &exynos5_clk_mout_aclk_300_gscl.clk,
+ },
+ .reg_div = { .reg = EXYNOS5_CLKDIV_TOP1, .shift = 12, .size = 3 },
+};
+
+/* Possible clock sources for aclk_300_gscl_sub Mux */
+static struct clk *clk_src_gscl_300_list[] = {
+ [0] = &clk_ext_xtal_mux,
+ [1] = &exynos5_clk_dout_aclk_300_gscl.clk,
+};
+
+static struct clksrc_sources clk_src_gscl_300 = {
+ .sources = clk_src_gscl_300_list,
+ .nr_sources = ARRAY_SIZE(clk_src_gscl_300_list),
+};
+
+static struct clksrc_clk exynos5_clk_aclk_300_gscl = {
+ .clk = {
+ .name = "aclk_300_gscl",
+ },
+ .sources = &clk_src_gscl_300,
+ .reg_src = { .reg = EXYNOS5_CLKSRC_TOP3, .shift = 10, .size = 1 },
+};
+
/* Clock initialization code */
static struct clksrc_clk *exynos5_sysclks[] = {
&exynos5_clk_mout_apll,
@@ -1139,6 +1214,10 @@ static struct clksrc_clk *exynos5_sysclks[] = {
&exynos5_clk_aclk_266,
&exynos5_clk_aclk_200,
&exynos5_clk_aclk_166,
+ &exynos5_clk_mout_aclk_300_gscl_mid,
+ &exynos5_clk_mout_aclk_300_gscl,
+ &exynos5_clk_dout_aclk_300_gscl,
+ &exynos5_clk_aclk_300_gscl,
&exynos5_clk_aclk_66_pre,
&exynos5_clk_aclk_66,
&exynos5_clk_dout_mmc0,
--
1.7.0.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 1/2] ARM: EXYNOS5: Add clock support for Gscaler
2012-07-06 12:45 ` [PATCH 1/2] ARM: EXYNOS5: Add " Shaik Ameer Basha
@ 2012-07-06 15:00 ` Sachin Kamat
0 siblings, 0 replies; 7+ messages in thread
From: Sachin Kamat @ 2012-07-06 15:00 UTC (permalink / raw)
To: Shaik Ameer Basha
Cc: linux-samsung-soc, kgene.kim, olofj, prashanth.g, joshi, ameersk,
thomas.ab
Hi Shaik,
Some nits:
Patch subject: s/EXYNOS5/EXYNOS
On 6 July 2012 18:15, Shaik Ameer Basha <shaik.ameer@samsung.com> wrote:
> Add required clock support for Gscaler for exynos5
>
> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
> Signed-off-by: Prathyush K <prathyush.k@samsung.com>
> Signed-off-by: Shaik Ameer Basha <shaik.ameer@samsung.com>
> ---
> arch/arm/mach-exynos/clock-exynos5.c | 79 ++++++++++++++++++++++++++++++++++
> 1 files changed, 79 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/clock-exynos5.c b/arch/arm/mach-exynos/clock-exynos5.c
> index fefa336..49f98cd 100644
> --- a/arch/arm/mach-exynos/clock-exynos5.c
> +++ b/arch/arm/mach-exynos/clock-exynos5.c
> @@ -741,6 +741,26 @@ static struct clk exynos5_init_clocks_off[] = {
> .enable = exynos5_clk_ip_peric_ctrl,
> .ctrlbit = (1 << 14),
> }, {
> + .name = "gscl",
> + .devname = "exynos-gsc.0",
> + .enable = exynos5_clk_ip_gscl_ctrl,
> + .ctrlbit = (1 << 0),
> + }, {
> + .name = "gscl",
> + .devname = "exynos-gsc.1",
> + .enable = exynos5_clk_ip_gscl_ctrl,
> + .ctrlbit = (1 << 1),
> + }, {
> + .name = "gscl",
> + .devname = "exynos-gsc.2",
> + .enable = exynos5_clk_ip_gscl_ctrl,
> + .ctrlbit = (1 << 2),
> + }, {
> + .name = "gscl",
> + .devname = "exynos-gsc.3",
> + .enable = exynos5_clk_ip_gscl_ctrl,
> + .ctrlbit = (1 << 3),
> + }, {
> .name = SYSMMU_CLOCK_NAME,
> .devname = SYSMMU_CLOCK_DEVNAME(mfc_l, 0),
> .enable = &exynos5_clk_ip_mfc_ctrl,
> @@ -1116,6 +1136,61 @@ static struct clksrc_clk exynos5_clksrcs[] = {
> },
> };
>
> +/* For ACLK_300_gscl_mid */
> +static struct clksrc_clk exynos5_clk_mout_aclk_300_gscl_mid = {
> + .clk = {
> + .name = "mout_aclk_300_gscl_mid",
> + },
> + .sources = &exynos5_clkset_aclk,
> + .reg_src = { .reg = EXYNOS5_CLKSRC_TOP0, .shift = 24, .size = 1 },
> +};
> +
> +/* For ACLK_300_gscl */
> +struct clk *exynos5_clkset_aclk_300_gscl_list[] = {
> + [0] = &exynos5_clk_mout_aclk_300_gscl_mid.clk,
> + [1] = &exynos5_clk_sclk_vpll.clk,
> +};
> +
> +struct clksrc_sources exynos5_clkset_aclk_300_gscl = {
> + .sources = exynos5_clkset_aclk_300_gscl_list,
> + .nr_sources = ARRAY_SIZE(exynos5_clkset_aclk_300_gscl_list),
> +};
> +
> +static struct clksrc_clk exynos5_clk_mout_aclk_300_gscl = {
> + .clk = {
> + .name = "mout_aclk_300_gscl",
> + },
> + .sources = &exynos5_clkset_aclk_300_gscl,
> + .reg_src = { .reg = EXYNOS5_CLKSRC_TOP0, .shift = 25, .size = 1 },
> +};
> +
> +static struct clksrc_clk exynos5_clk_dout_aclk_300_gscl = {
> + .clk = {
> + .name = "dout_aclk_300_gscl",
> + .parent = &exynos5_clk_mout_aclk_300_gscl.clk,
> + },
> + .reg_div = { .reg = EXYNOS5_CLKDIV_TOP1, .shift = 12, .size = 3 },
> +};
> +
> +/* Possible clock sources for aclk_300_gscl_sub Mux */
> +static struct clk *clk_src_gscl_300_list[] = {
> + [0] = &clk_ext_xtal_mux,
> + [1] = &exynos5_clk_dout_aclk_300_gscl.clk,
> +};
> +
> +static struct clksrc_sources clk_src_gscl_300 = {
> + .sources = clk_src_gscl_300_list,
> + .nr_sources = ARRAY_SIZE(clk_src_gscl_300_list),
> +};
> +
> +static struct clksrc_clk exynos5_clk_aclk_300_gscl = {
> + .clk = {
> + .name = "aclk_300_gscl",
> + },
> + .sources = &clk_src_gscl_300,
> + .reg_src = { .reg = EXYNOS5_CLKSRC_TOP3, .shift = 10, .size = 1 },
> +};
> +
> /* Clock initialization code */
> static struct clksrc_clk *exynos5_sysclks[] = {
> &exynos5_clk_mout_apll,
> @@ -1139,6 +1214,10 @@ static struct clksrc_clk *exynos5_sysclks[] = {
> &exynos5_clk_aclk_266,
> &exynos5_clk_aclk_200,
> &exynos5_clk_aclk_166,
> + &exynos5_clk_mout_aclk_300_gscl_mid,
> + &exynos5_clk_mout_aclk_300_gscl,
> + &exynos5_clk_dout_aclk_300_gscl,
> + &exynos5_clk_aclk_300_gscl,
> &exynos5_clk_aclk_66_pre,
> &exynos5_clk_aclk_66,
> &exynos5_clk_dout_mmc0,
Please maintain the alphabetic order.
> --
> 1.7.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] ARM: EXYNOS5: Add gscalar device from DT
2012-07-06 12:45 [PATCH 0/2] Add device tree and clock support for Gscaler Shaik Ameer Basha
2012-07-06 12:45 ` [PATCH 1/2] ARM: EXYNOS5: Add " Shaik Ameer Basha
@ 2012-07-06 12:45 ` Shaik Ameer Basha
2012-07-06 18:50 ` Sylwester Nawrocki
2012-07-07 6:28 ` Sachin Kamat
1 sibling, 2 replies; 7+ messages in thread
From: Shaik Ameer Basha @ 2012-07-06 12:45 UTC (permalink / raw)
To: linux-samsung-soc
Cc: kgene.kim, olofj, prashanth.g, joshi, ameersk, thomas.ab
Adding all 4 gscalar devices from DT device list in machine file.
Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
Signed-off-by: Shaik Ameer Basha <shaik.ameer@samsung.com>
---
arch/arm/boot/dts/exynos5250.dtsi | 31 +++++++++++++++++++++++++++++++
arch/arm/mach-exynos/mach-exynos5-dt.c | 8 ++++++++
2 files changed, 39 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 4272b29..b945c00 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -23,6 +23,13 @@
compatible = "samsung,exynos5250";
interrupt-parent = <&gic>;
+ aliases {
+ gsc0 = &gsc_0;
+ gsc1 = &gsc_1;
+ gsc2 = &gsc_2;
+ gsc3 = &gsc_3;
+ };
+
gic:interrupt-controller@10481000 {
compatible = "arm,cortex-a9-gic";
#interrupt-cells = <3>;
@@ -424,4 +431,28 @@
#gpio-cells = <4>;
};
};
+
+ gsc_0: gsc@0x13e00000 {
+ compatible = "samsung,exynos-gsc";
+ reg = <0x13e00000 0x1000>;
+ interrupts = <0 85 0>;
+ };
+
+ gsc_1: gsc@0x13e10000 {
+ compatible = "samsung,exynos-gsc";
+ reg = <0x13e10000 0x1000>;
+ interrupts = <0 86 0>;
+ };
+
+ gsc_2: gsc@0x13e20000 {
+ compatible = "samsung,exynos-gsc";
+ reg = <0x13e20000 0x1000>;
+ interrupts = <0 87 0>;
+ };
+
+ gsc_3: gsc@0x13e30000 {
+ compatible = "samsung,exynos-gsc";
+ reg = <0x13e30000 0x1000>;
+ interrupts = <0 88 0>;
+ };
};
diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c b/arch/arm/mach-exynos/mach-exynos5-dt.c
index 7b1e11a..76b081c 100644
--- a/arch/arm/mach-exynos/mach-exynos5-dt.c
+++ b/arch/arm/mach-exynos/mach-exynos5-dt.c
@@ -50,6 +50,14 @@ static const struct of_dev_auxdata exynos5250_auxdata_lookup[] __initconst = {
OF_DEV_AUXDATA("arm,pl330", EXYNOS5_PA_PDMA0, "dma-pl330.0", NULL),
OF_DEV_AUXDATA("arm,pl330", EXYNOS5_PA_PDMA1, "dma-pl330.1", NULL),
OF_DEV_AUXDATA("arm,pl330", EXYNOS5_PA_MDMA1, "dma-pl330.2", NULL),
+ OF_DEV_AUXDATA("samsung,exynos-gsc", 0x13E00000,
+ "exynos-gsc.0", NULL),
+ OF_DEV_AUXDATA("samsung,exynos-gsc", 0x13E10000,
+ "exynos-gsc.1", NULL),
+ OF_DEV_AUXDATA("samsung,exynos-gsc", 0x13E20000,
+ "exynos-gsc.2", NULL),
+ OF_DEV_AUXDATA("samsung,exynos-gsc", 0x13E30000,
+ "exynos-gsc.3", NULL),
{},
};
--
1.7.0.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 2/2] ARM: EXYNOS5: Add gscalar device from DT
2012-07-06 12:45 ` [PATCH 2/2] ARM: EXYNOS5: Add gscalar device from DT Shaik Ameer Basha
@ 2012-07-06 18:50 ` Sylwester Nawrocki
2012-07-07 6:28 ` Sachin Kamat
1 sibling, 0 replies; 7+ messages in thread
From: Sylwester Nawrocki @ 2012-07-06 18:50 UTC (permalink / raw)
To: Shaik Ameer Basha
Cc: linux-samsung-soc, kgene.kim, olofj, prashanth.g, joshi, ameersk,
thomas.ab, devicetree-discuss
Hi Shaik,
On 07/06/2012 02:45 PM, Shaik Ameer Basha wrote:
> Adding all 4 gscalar devices from DT device list in machine file.
nit: s/gscalar/gscaler
The above sentence doesn't quite parse though.
> Signed-off-by: Abhilash Kesavan<a.kesavan@samsung.com>
> Signed-off-by: Leela Krishna Amudala<l.krishna@samsung.com>
> Signed-off-by: Shaik Ameer Basha<shaik.ameer@samsung.com>
> ---
> arch/arm/boot/dts/exynos5250.dtsi | 31 +++++++++++++++++++++++++++++++
> arch/arm/mach-exynos/mach-exynos5-dt.c | 8 ++++++++
> 2 files changed, 39 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index 4272b29..b945c00 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -23,6 +23,13 @@
> compatible = "samsung,exynos5250";
> interrupt-parent =<&gic>;
>
> + aliases {
> + gsc0 =&gsc_0;
> + gsc1 =&gsc_1;
> + gsc2 =&gsc_2;
> + gsc3 =&gsc_3;
> + };
> +
What are these aliases useful for ?
Also I think all DT related patches should be posted to
devicetree-discuss@lists.ozlabs.org as well.
> gic:interrupt-controller@10481000 {
> compatible = "arm,cortex-a9-gic";
> #interrupt-cells =<3>;
> @@ -424,4 +431,28 @@
> #gpio-cells =<4>;
> };
> };
> +
> + gsc_0: gsc@0x13e00000 {
> + compatible = "samsung,exynos-gsc";
> + reg =<0x13e00000 0x1000>;
> + interrupts =<0 85 0>;
> + };
> +
> + gsc_1: gsc@0x13e10000 {
> + compatible = "samsung,exynos-gsc";
> + reg =<0x13e10000 0x1000>;
> + interrupts =<0 86 0>;
> + };
> +
> + gsc_2: gsc@0x13e20000 {
> + compatible = "samsung,exynos-gsc";
> + reg =<0x13e20000 0x1000>;
> + interrupts =<0 87 0>;
> + };
> +
> + gsc_3: gsc@0x13e30000 {
> + compatible = "samsung,exynos-gsc";
> + reg =<0x13e30000 0x1000>;
> + interrupts =<0 88 0>;
> + };
> };
> diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c b/arch/arm/mach-exynos/mach-exynos5-dt.c
> index 7b1e11a..76b081c 100644
> --- a/arch/arm/mach-exynos/mach-exynos5-dt.c
> +++ b/arch/arm/mach-exynos/mach-exynos5-dt.c
> @@ -50,6 +50,14 @@ static const struct of_dev_auxdata exynos5250_auxdata_lookup[] __initconst = {
> OF_DEV_AUXDATA("arm,pl330", EXYNOS5_PA_PDMA0, "dma-pl330.0", NULL),
> OF_DEV_AUXDATA("arm,pl330", EXYNOS5_PA_PDMA1, "dma-pl330.1", NULL),
> OF_DEV_AUXDATA("arm,pl330", EXYNOS5_PA_MDMA1, "dma-pl330.2", NULL),
> + OF_DEV_AUXDATA("samsung,exynos-gsc", 0x13E00000,
> + "exynos-gsc.0", NULL),
> + OF_DEV_AUXDATA("samsung,exynos-gsc", 0x13E10000,
> + "exynos-gsc.1", NULL),
> + OF_DEV_AUXDATA("samsung,exynos-gsc", 0x13E20000,
> + "exynos-gsc.2", NULL),
> + OF_DEV_AUXDATA("samsung,exynos-gsc", 0x13E30000,
> + "exynos-gsc.3", NULL),
It's probably better to add relevant entry at
arch/arm/mach-exynos/include/mach/map. It's just a one line, e.g.
/* x = 0...3 */
#define EXYNOS5_PA_GSC(x) (0x13e00000 + ((x) * 0x10000))
And use it here instead of plain numbers.
--
Thanks,
Sylwester
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 2/2] ARM: EXYNOS5: Add gscalar device from DT
2012-07-06 12:45 ` [PATCH 2/2] ARM: EXYNOS5: Add gscalar device from DT Shaik Ameer Basha
2012-07-06 18:50 ` Sylwester Nawrocki
@ 2012-07-07 6:28 ` Sachin Kamat
1 sibling, 0 replies; 7+ messages in thread
From: Sachin Kamat @ 2012-07-07 6:28 UTC (permalink / raw)
To: Shaik Ameer Basha
Cc: linux-samsung-soc, kgene.kim, olofj, prashanth.g, joshi, ameersk,
thomas.ab
Hi Shaik,
On 6 July 2012 18:15, Shaik Ameer Basha <shaik.ameer@samsung.com> wrote:
> Adding all 4 gscalar devices from DT device list in machine file.
>
> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
> Signed-off-by: Shaik Ameer Basha <shaik.ameer@samsung.com>
> ---
> arch/arm/boot/dts/exynos5250.dtsi | 31 +++++++++++++++++++++++++++++++
> arch/arm/mach-exynos/mach-exynos5-dt.c | 8 ++++++++
> 2 files changed, 39 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index 4272b29..b945c00 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -23,6 +23,13 @@
> compatible = "samsung,exynos5250";
> interrupt-parent = <&gic>;
>
> + aliases {
> + gsc0 = &gsc_0;
> + gsc1 = &gsc_1;
> + gsc2 = &gsc_2;
> + gsc3 = &gsc_3;
> + };
> +
> gic:interrupt-controller@10481000 {
> compatible = "arm,cortex-a9-gic";
> #interrupt-cells = <3>;
> @@ -424,4 +431,28 @@
> #gpio-cells = <4>;
> };
> };
> +
> + gsc_0: gsc@0x13e00000 {
> + compatible = "samsung,exynos-gsc";
> + reg = <0x13e00000 0x1000>;
> + interrupts = <0 85 0>;
> + };
> +
> + gsc_1: gsc@0x13e10000 {
> + compatible = "samsung,exynos-gsc";
> + reg = <0x13e10000 0x1000>;
> + interrupts = <0 86 0>;
> + };
> +
> + gsc_2: gsc@0x13e20000 {
> + compatible = "samsung,exynos-gsc";
> + reg = <0x13e20000 0x1000>;
> + interrupts = <0 87 0>;
> + };
> +
> + gsc_3: gsc@0x13e30000 {
> + compatible = "samsung,exynos-gsc";
> + reg = <0x13e30000 0x1000>;
> + interrupts = <0 88 0>;
> + };
> };
Please also update the documentaion for these bindings.
> diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c b/arch/arm/mach-exynos/mach-exynos5-dt.c
> index 7b1e11a..76b081c 100644
> --- a/arch/arm/mach-exynos/mach-exynos5-dt.c
> +++ b/arch/arm/mach-exynos/mach-exynos5-dt.c
> @@ -50,6 +50,14 @@ static const struct of_dev_auxdata exynos5250_auxdata_lookup[] __initconst = {
> OF_DEV_AUXDATA("arm,pl330", EXYNOS5_PA_PDMA0, "dma-pl330.0", NULL),
> OF_DEV_AUXDATA("arm,pl330", EXYNOS5_PA_PDMA1, "dma-pl330.1", NULL),
> OF_DEV_AUXDATA("arm,pl330", EXYNOS5_PA_MDMA1, "dma-pl330.2", NULL),
> + OF_DEV_AUXDATA("samsung,exynos-gsc", 0x13E00000,
> + "exynos-gsc.0", NULL),
> + OF_DEV_AUXDATA("samsung,exynos-gsc", 0x13E10000,
> + "exynos-gsc.1", NULL),
> + OF_DEV_AUXDATA("samsung,exynos-gsc", 0x13E20000,
> + "exynos-gsc.2", NULL),
> + OF_DEV_AUXDATA("samsung,exynos-gsc", 0x13E30000,
> + "exynos-gsc.3", NULL),
> {},
> };
>
> --
> 1.7.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Re: [PATCH 2/2] ARM: EXYNOS5: Add gscalar device from DT
@ 2012-07-11 13:06 AMEER BASHA SHAIK
2012-07-11 18:12 ` Sylwester Nawrocki
0 siblings, 1 reply; 7+ messages in thread
From: AMEER BASHA SHAIK @ 2012-07-11 13:06 UTC (permalink / raw)
To: Sylwester Nawrocki
Cc: linux-samsung-soc, Kukjin Kim, olofj, PRASHANTH GODREHAL,
SUNIL JOSHI, ameersk, Thomas P Abraham, devicetree-discuss
Hi Sylwester,
On Sat, Jul 7, 2012 at 12:20 AM, Sylwester Nawrocki <sylvester.nawrocki@gmail.com> wrote:
>
> Hi Shaik,
>
>
> On 07/06/2012 02:45 PM, Shaik Ameer Basha wrote:
>>
>> Adding all 4 gscalar devices from DT device list in machine file.
>
>
> nit: s/gscalar/gscaler
>
> The above sentence doesn't quite parse though.
>
OK. I will fix it.
>
>> Signed-off-by: Abhilash Kesavan<a.kesavan@samsung.com>
>> Signed-off-by: Leela Krishna Amudala<l.krishna@samsung.com>
>> Signed-off-by: Shaik Ameer Basha<shaik.ameer@samsung.com>
>> ---
>> arch/arm/boot/dts/exynos5250.dtsi | 31
>> +++++++++++++++++++++++++++++++
>> arch/arm/mach-exynos/mach-exynos5-dt.c | 8 ++++++++
>> 2 files changed, 39 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
>> b/arch/arm/boot/dts/exynos5250.dtsi
>> index 4272b29..b945c00 100644
>> --- a/arch/arm/boot/dts/exynos5250.dtsi
>> +++ b/arch/arm/boot/dts/exynos5250.dtsi
>> @@ -23,6 +23,13 @@
>> compatible = "samsung,exynos5250";
>> interrupt-parent =<&gic>;
>>
>> + aliases {
>> + gsc0 =&gsc_0;
>> + gsc1 =&gsc_1;
>> + gsc2 =&gsc_2;
>> + gsc3 =&gsc_3;
>> + };
>> +
>
>
> What are these aliases useful for ?
GScaler driver uses the "of_alias_get_id()" call to retrieve the device IDs, which
internally uses these aliases...
> Also I think all DT related patches should be posted to
> devicetree-discuss@lists.ozlabs.org as well.
>
I will post the v2 version of this patch to the specified mailing list.
>
>> gic:interrupt-controller@10481000 {
>> compatible = "arm,cortex-a9-gic";
>> #interrupt-cells =<3>;
>> @@ -424,4 +431,28 @@
>> #gpio-cells =<4>;
>> };
>> };
>> +
>> + gsc_0: gsc@0x13e00000 {
>> + compatible = "samsung,exynos-gsc";
>> + reg =<0x13e00000 0x1000>;
>> + interrupts =<0 85 0>;
>> + };
>> +
>> + gsc_1: gsc@0x13e10000 {
>> + compatible = "samsung,exynos-gsc";
>> + reg =<0x13e10000 0x1000>;
>> + interrupts =<0 86 0>;
>> + };
>> +
>> + gsc_2: gsc@0x13e20000 {
>> + compatible = "samsung,exynos-gsc";
>> + reg =<0x13e20000 0x1000>;
>> + interrupts =<0 87 0>;
>> + };
>> +
>> + gsc_3: gsc@0x13e30000 {
>> + compatible = "samsung,exynos-gsc";
>> + reg =<0x13e30000 0x1000>;
>> + interrupts =<0 88 0>;
>> + };
>> };
>> diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c
>> b/arch/arm/mach-exynos/mach-exynos5-dt.c
>> index 7b1e11a..76b081c 100644
>> --- a/arch/arm/mach-exynos/mach-exynos5-dt.c
>> +++ b/arch/arm/mach-exynos/mach-exynos5-dt.c
>> @@ -50,6 +50,14 @@ static const struct of_dev_auxdata
>> exynos5250_auxdata_lookup[] __initconst = {
>> OF_DEV_AUXDATA("arm,pl330", EXYNOS5_PA_PDMA0, "dma-pl330.0",
>> NULL),
>> OF_DEV_AUXDATA("arm,pl330", EXYNOS5_PA_PDMA1, "dma-pl330.1",
>> NULL),
>> OF_DEV_AUXDATA("arm,pl330", EXYNOS5_PA_MDMA1, "dma-pl330.2",
>> NULL),
>> + OF_DEV_AUXDATA("samsung,exynos-gsc", 0x13E00000,
>> + "exynos-gsc.0", NULL),
>> + OF_DEV_AUXDATA("samsung,exynos-gsc", 0x13E10000,
>> + "exynos-gsc.1", NULL),
>> + OF_DEV_AUXDATA("samsung,exynos-gsc", 0x13E20000,
>> + "exynos-gsc.2", NULL),
>> + OF_DEV_AUXDATA("samsung,exynos-gsc", 0x13E30000,
>> + "exynos-gsc.3", NULL),
>
>
> It's probably better to add relevant entry at
> arch/arm/mach-exynos/include/mach/map. It's just a one line, e.g.
>
> /* x = 0...3 */
> #define EXYNOS5_PA_GSC(x) (0x13e00000 + ((x) * 0x10000))
>
> And use it here instead of plain numbers.
OK. will address these comments in v2.
>
> --
> Thanks,
> Sylwester
Regards,
Shaik Ameer Basha
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 2/2] ARM: EXYNOS5: Add gscalar device from DT
2012-07-11 13:06 AMEER BASHA SHAIK
@ 2012-07-11 18:12 ` Sylwester Nawrocki
0 siblings, 0 replies; 7+ messages in thread
From: Sylwester Nawrocki @ 2012-07-11 18:12 UTC (permalink / raw)
To: shaik.ameer
Cc: linux-samsung-soc, Kukjin Kim, olofj, PRASHANTH GODREHAL,
SUNIL JOSHI, ameersk, Thomas P Abraham, devicetree-discuss
Hi Shaik,
On 07/11/2012 03:06 PM, AMEER BASHA SHAIK wrote:
>>> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
>>> b/arch/arm/boot/dts/exynos5250.dtsi
>>> index 4272b29..b945c00 100644
>>> --- a/arch/arm/boot/dts/exynos5250.dtsi
>>> +++ b/arch/arm/boot/dts/exynos5250.dtsi
>>> @@ -23,6 +23,13 @@
>>> compatible = "samsung,exynos5250";
>>> interrupt-parent =<&gic>;
>>>
>>> + aliases {
>>> + gsc0 =&gsc_0;
>>> + gsc1 =&gsc_1;
>>> + gsc2 =&gsc_2;
>>> + gsc3 =&gsc_3;
>>> + };
>>> +
>>
>>
>> What are these aliases useful for ?
>
> GScaler driver uses the "of_alias_get_id()" call to retrieve the device IDs, which
> internally uses these aliases...
Yeah, just figured it out already... I didn't know then it was a preferred
way to represent device IDs in DT. I looked at the driver's code and it
seemed slightly incorrect to me. Let me comment on the relevant patch shortly.
Would be good to have things like this documented in the GScaler bindings
documentation. These aliases seem quite essential for the driver to work.
>> Also I think all DT related patches should be posted to
>> devicetree-discuss@lists.ozlabs.org as well.
>>
>
> I will post the v2 version of this patch to the specified mailing list.
>
>>
>>> gic:interrupt-controller@10481000 {
>>> compatible = "arm,cortex-a9-gic";
>>> #interrupt-cells =<3>;
>>> @@ -424,4 +431,28 @@
>>> #gpio-cells =<4>;
>>> };
>>> };
>>> +
>>> + gsc_0: gsc@0x13e00000 {
>>> + compatible = "samsung,exynos-gsc";
>>> + reg =<0x13e00000 0x1000>;
>>> + interrupts =<0 85 0>;
>>> + };
>>> +
>>> + gsc_1: gsc@0x13e10000 {
>>> + compatible = "samsung,exynos-gsc";
>>> + reg =<0x13e10000 0x1000>;
>>> + interrupts =<0 86 0>;
>>> + };
>>> +
>>> + gsc_2: gsc@0x13e20000 {
>>> + compatible = "samsung,exynos-gsc";
>>> + reg =<0x13e20000 0x1000>;
>>> + interrupts =<0 87 0>;
>>> + };
>>> +
>>> + gsc_3: gsc@0x13e30000 {
>>> + compatible = "samsung,exynos-gsc";
>>> + reg =<0x13e30000 0x1000>;
>>> + interrupts =<0 88 0>;
>>> + };
>>> };
>>> diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c
>>> b/arch/arm/mach-exynos/mach-exynos5-dt.c
>>> index 7b1e11a..76b081c 100644
>>> --- a/arch/arm/mach-exynos/mach-exynos5-dt.c
>>> +++ b/arch/arm/mach-exynos/mach-exynos5-dt.c
>>> @@ -50,6 +50,14 @@ static const struct of_dev_auxdata
>>> exynos5250_auxdata_lookup[] __initconst = {
>>> OF_DEV_AUXDATA("arm,pl330", EXYNOS5_PA_PDMA0, "dma-pl330.0",
>>> NULL),
>>> OF_DEV_AUXDATA("arm,pl330", EXYNOS5_PA_PDMA1, "dma-pl330.1",
>>> NULL),
>>> OF_DEV_AUXDATA("arm,pl330", EXYNOS5_PA_MDMA1, "dma-pl330.2",
>>> NULL),
>>> + OF_DEV_AUXDATA("samsung,exynos-gsc", 0x13E00000,
>>> + "exynos-gsc.0", NULL),
>>> + OF_DEV_AUXDATA("samsung,exynos-gsc", 0x13E10000,
>>> + "exynos-gsc.1", NULL),
>>> + OF_DEV_AUXDATA("samsung,exynos-gsc", 0x13E20000,
>>> + "exynos-gsc.2", NULL),
>>> + OF_DEV_AUXDATA("samsung,exynos-gsc", 0x13E30000,
>>> + "exynos-gsc.3", NULL),
>>
>>
>> It's probably better to add relevant entry at
>> arch/arm/mach-exynos/include/mach/map. It's just a one line, e.g.
>>
>> /* x = 0...3 */
>> #define EXYNOS5_PA_GSC(x) (0x13e00000 + ((x) * 0x10000))
>>
>> And use it here instead of plain numbers.
>
> OK. will address these comments in v2.
Thanks.
--
Regards,
Sylwester
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-07-11 18:12 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-06 12:45 [PATCH 0/2] Add device tree and clock support for Gscaler Shaik Ameer Basha
2012-07-06 12:45 ` [PATCH 1/2] ARM: EXYNOS5: Add " Shaik Ameer Basha
2012-07-06 15:00 ` Sachin Kamat
2012-07-06 12:45 ` [PATCH 2/2] ARM: EXYNOS5: Add gscalar device from DT Shaik Ameer Basha
2012-07-06 18:50 ` Sylwester Nawrocki
2012-07-07 6:28 ` Sachin Kamat
2012-07-11 13:06 AMEER BASHA SHAIK
2012-07-11 18:12 ` Sylwester Nawrocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.