* [PATCH 1/1] ARM: EXYNOS: Cleanup common.h file
@ 2013-07-11 8:57 Sachin Kamat
2013-07-22 16:30 ` Tomasz Figa
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Sachin Kamat @ 2013-07-11 8:57 UTC (permalink / raw)
To: linux-samsung-soc; +Cc: kgene.kim, sachin.kamat, patches
Remove unused declarations that got left behind subsequent to
making Exynos a DT-only platform.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
arch/arm/mach-exynos/common.h | 41 -----------------------------------------
1 file changed, 41 deletions(-)
diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h
index c4abde2..7318e62 100644
--- a/arch/arm/mach-exynos/common.h
+++ b/arch/arm/mach-exynos/common.h
@@ -17,7 +17,6 @@
void mct_init(void __iomem *base, int irq_g0, int irq_l0, int irq_l1);
void exynos_init_time(void);
-extern unsigned long xxti_f, xusbxti_f;
struct map_desc;
void exynos_init_io(void);
@@ -25,54 +24,14 @@ void exynos4_restart(enum reboot_mode mode, const char *cmd);
void exynos5_restart(enum reboot_mode mode, const char *cmd);
void exynos_init_late(void);
-/* ToDo: remove these after migrating legacy exynos4 platforms to dt */
-void exynos4_clk_init(struct device_node *np, int is_exynos4210, void __iomem *reg_base, unsigned long xom);
-void exynos4_clk_register_fixed_ext(unsigned long, unsigned long);
-
void exynos_firmware_init(void);
-void exynos_set_timer_source(u8 channels);
-
#ifdef CONFIG_PM_GENERIC_DOMAINS
int exynos_pm_late_initcall(void);
#else
static inline int exynos_pm_late_initcall(void) { return 0; }
#endif
-#ifdef CONFIG_ARCH_EXYNOS4
-void exynos4_register_clocks(void);
-void exynos4_setup_clocks(void);
-
-#else
-#define exynos4_register_clocks()
-#define exynos4_setup_clocks()
-#endif
-
-#ifdef CONFIG_ARCH_EXYNOS5
-void exynos5_register_clocks(void);
-void exynos5_setup_clocks(void);
-
-#else
-#define exynos5_register_clocks()
-#define exynos5_setup_clocks()
-#endif
-
-#ifdef CONFIG_CPU_EXYNOS4210
-void exynos4210_register_clocks(void);
-
-#else
-#define exynos4210_register_clocks()
-#endif
-
-#ifdef CONFIG_SOC_EXYNOS4212
-void exynos4212_register_clocks(void);
-
-#else
-#define exynos4212_register_clocks()
-#endif
-
-struct device_node;
-
extern struct smp_operations exynos_smp_ops;
extern void exynos_cpu_die(unsigned int cpu);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] ARM: EXYNOS: Cleanup common.h file
2013-07-11 8:57 [PATCH 1/1] ARM: EXYNOS: Cleanup common.h file Sachin Kamat
@ 2013-07-22 16:30 ` Tomasz Figa
2013-07-24 2:31 ` Kukjin Kim
2013-07-24 3:13 ` Kukjin Kim
2 siblings, 0 replies; 7+ messages in thread
From: Tomasz Figa @ 2013-07-22 16:30 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-samsung-soc, kgene.kim, patches
Hi Sachin,
On Thursday 11 of July 2013 14:27:27 Sachin Kamat wrote:
> Remove unused declarations that got left behind subsequent to
> making Exynos a DT-only platform.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> arch/arm/mach-exynos/common.h | 41
> ----------------------------------------- 1 file changed, 41
> deletions(-)
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
Best regards,
Tomasz
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH 1/1] ARM: EXYNOS: Cleanup common.h file
2013-07-11 8:57 [PATCH 1/1] ARM: EXYNOS: Cleanup common.h file Sachin Kamat
2013-07-22 16:30 ` Tomasz Figa
@ 2013-07-24 2:31 ` Kukjin Kim
2013-07-24 3:13 ` Kukjin Kim
2 siblings, 0 replies; 7+ messages in thread
From: Kukjin Kim @ 2013-07-24 2:31 UTC (permalink / raw)
To: 'Sachin Kamat', linux-samsung-soc; +Cc: patches
Sachin Kamat wrote:
>
> Remove unused declarations that got left behind subsequent to
> making Exynos a DT-only platform.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> arch/arm/mach-exynos/common.h | 41
-------------------------------------
> ----
> 1 file changed, 41 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h
> index c4abde2..7318e62 100644
> --- a/arch/arm/mach-exynos/common.h
> +++ b/arch/arm/mach-exynos/common.h
> @@ -17,7 +17,6 @@
>
> void mct_init(void __iomem *base, int irq_g0, int irq_l0, int irq_l1);
> void exynos_init_time(void);
> -extern unsigned long xxti_f, xusbxti_f;
>
> struct map_desc;
> void exynos_init_io(void);
> @@ -25,54 +24,14 @@ void exynos4_restart(enum reboot_mode mode, const char
> *cmd);
> void exynos5_restart(enum reboot_mode mode, const char *cmd);
> void exynos_init_late(void);
>
> -/* ToDo: remove these after migrating legacy exynos4 platforms to dt */
> -void exynos4_clk_init(struct device_node *np, int is_exynos4210, void
> __iomem *reg_base, unsigned long xom);
> -void exynos4_clk_register_fixed_ext(unsigned long, unsigned long);
> -
> void exynos_firmware_init(void);
>
> -void exynos_set_timer_source(u8 channels);
> -
> #ifdef CONFIG_PM_GENERIC_DOMAINS
> int exynos_pm_late_initcall(void);
> #else
> static inline int exynos_pm_late_initcall(void) { return 0; }
> #endif
>
> -#ifdef CONFIG_ARCH_EXYNOS4
> -void exynos4_register_clocks(void);
> -void exynos4_setup_clocks(void);
> -
> -#else
> -#define exynos4_register_clocks()
> -#define exynos4_setup_clocks()
> -#endif
> -
> -#ifdef CONFIG_ARCH_EXYNOS5
> -void exynos5_register_clocks(void);
> -void exynos5_setup_clocks(void);
> -
> -#else
> -#define exynos5_register_clocks()
> -#define exynos5_setup_clocks()
> -#endif
> -
> -#ifdef CONFIG_CPU_EXYNOS4210
> -void exynos4210_register_clocks(void);
> -
> -#else
> -#define exynos4210_register_clocks()
> -#endif
> -
> -#ifdef CONFIG_SOC_EXYNOS4212
> -void exynos4212_register_clocks(void);
> -
> -#else
> -#define exynos4212_register_clocks()
> -#endif
> -
> -struct device_node;
> -
> extern struct smp_operations exynos_smp_ops;
>
> extern void exynos_cpu_die(unsigned int cpu);
> --
> 1.7.9.5
Looks good to me, applied into -cleanup.
Thanks,
Kukjin
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH 1/1] ARM: EXYNOS: Cleanup common.h file
2013-07-11 8:57 [PATCH 1/1] ARM: EXYNOS: Cleanup common.h file Sachin Kamat
2013-07-22 16:30 ` Tomasz Figa
2013-07-24 2:31 ` Kukjin Kim
@ 2013-07-24 3:13 ` Kukjin Kim
2013-07-24 3:37 ` Sachin Kamat
2 siblings, 1 reply; 7+ messages in thread
From: Kukjin Kim @ 2013-07-24 3:13 UTC (permalink / raw)
To: 'Kukjin Kim', 'Sachin Kamat', linux-samsung-soc; +Cc: patches
Kukjin Kim wrote:
>
> Sachin Kamat wrote:
> >
> > Remove unused declarations that got left behind subsequent to
> > making Exynos a DT-only platform.
> >
> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> > ---
> > arch/arm/mach-exynos/common.h | 41
-----------------------------------
> --
> > ----
> > 1 file changed, 41 deletions(-)
> >
[...]
> > -
> > -struct device_node;
> > -
> > extern struct smp_operations exynos_smp_ops;
> >
> > extern void exynos_cpu_die(unsigned int cpu);
> > --
> > 1.7.9.5
>
> Looks good to me, applied into -cleanup.
>
Just note, needed following additionally.
-struct device_node;
-void combiner_init(void __iomem *combiner_base, struct device_node *np,
- unsigned int max_nr, int irq_base);
-
extern struct smp_operations exynos_smp_ops;
extern void exynos_cpu_die(unsigned int cpu);
---
Thanks,
Kukjin
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] ARM: EXYNOS: Cleanup common.h file
2013-07-24 3:13 ` Kukjin Kim
@ 2013-07-24 3:37 ` Sachin Kamat
2013-07-24 7:31 ` Kukjin Kim
0 siblings, 1 reply; 7+ messages in thread
From: Sachin Kamat @ 2013-07-24 3:37 UTC (permalink / raw)
To: Kukjin Kim; +Cc: Kukjin Kim, linux-samsung-soc, patches
On 24 July 2013 08:43, Kukjin Kim <kgene@kernel.org> wrote:
> Kukjin Kim wrote:
>>
>> Sachin Kamat wrote:
>> >
>> > Remove unused declarations that got left behind subsequent to
>> > making Exynos a DT-only platform.
>> >
>> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> > ---
>> > arch/arm/mach-exynos/common.h | 41
> -----------------------------------
>> --
>> > ----
>> > 1 file changed, 41 deletions(-)
>> >
>
> [...]
>
>> > -
>> > -struct device_node;
>> > -
>> > extern struct smp_operations exynos_smp_ops;
>> >
>> > extern void exynos_cpu_die(unsigned int cpu);
>> > --
>> > 1.7.9.5
>>
>> Looks good to me, applied into -cleanup.
>>
> Just note, needed following additionally.
>
> -struct device_node;
> -void combiner_init(void __iomem *combiner_base, struct device_node *np,
> - unsigned int max_nr, int irq_base);
> -
There is already a patch to clean that up [1] submitted earlier as
part of combiner cleanup series.
Please apply that first or squash it into this one.
[1] https://lkml.org/lkml/2013/6/26/296
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH 1/1] ARM: EXYNOS: Cleanup common.h file
2013-07-24 3:37 ` Sachin Kamat
@ 2013-07-24 7:31 ` Kukjin Kim
2013-07-24 9:00 ` Sachin Kamat
0 siblings, 1 reply; 7+ messages in thread
From: Kukjin Kim @ 2013-07-24 7:31 UTC (permalink / raw)
To: 'Sachin Kamat', 'Kukjin Kim'; +Cc: linux-samsung-soc, patches
Sachin Kamat wrote:
>
> On 24 July 2013 08:43, Kukjin Kim <kgene@kernel.org> wrote:
> > Kukjin Kim wrote:
> >>
> >> Sachin Kamat wrote:
> >> >
> >> > Remove unused declarations that got left behind subsequent to
> >> > making Exynos a DT-only platform.
> >> >
> >> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> >> > ---
> >> > arch/arm/mach-exynos/common.h | 41
> > -----------------------------------
> >> --
> >> > ----
> >> > 1 file changed, 41 deletions(-)
> >> >
> >
> > [...]
> >
> >> > -
> >> > -struct device_node;
> >> > -
> >> > extern struct smp_operations exynos_smp_ops;
> >> >
> >> > extern void exynos_cpu_die(unsigned int cpu);
> >> > --
> >> > 1.7.9.5
> >>
> >> Looks good to me, applied into -cleanup.
> >>
> > Just note, needed following additionally.
> >
> > -struct device_node;
> > -void combiner_init(void __iomem *combiner_base, struct device_node *np,
> > - unsigned int max_nr, int irq_base);
> > -
>
> There is already a patch to clean that up [1] submitted earlier as
> part of combiner cleanup series.
> Please apply that first or squash it into this one.
>
> [1] https://lkml.org/lkml/2013/6/26/296
>
Already did when I applied.
Thanks, Kukjin
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] ARM: EXYNOS: Cleanup common.h file
2013-07-24 7:31 ` Kukjin Kim
@ 2013-07-24 9:00 ` Sachin Kamat
0 siblings, 0 replies; 7+ messages in thread
From: Sachin Kamat @ 2013-07-24 9:00 UTC (permalink / raw)
To: Kukjin Kim; +Cc: Kukjin Kim, linux-samsung-soc, patches
On 24 July 2013 13:01, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Sachin Kamat wrote:
>>
>> On 24 July 2013 08:43, Kukjin Kim <kgene@kernel.org> wrote:
>> > Kukjin Kim wrote:
>> >>
>> >> Sachin Kamat wrote:
>> >> >
>> >> > Remove unused declarations that got left behind subsequent to
>> >> > making Exynos a DT-only platform.
>> >> >
>> >> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> >> > ---
>> >> > arch/arm/mach-exynos/common.h | 41
>> > -----------------------------------
>> >> --
>> >> > ----
>> >> > 1 file changed, 41 deletions(-)
>> >> >
>> >
>> > [...]
>> >
>> >> > -
>> >> > -struct device_node;
>> >> > -
>> >> > extern struct smp_operations exynos_smp_ops;
>> >> >
>> >> > extern void exynos_cpu_die(unsigned int cpu);
>> >> > --
>> >> > 1.7.9.5
>> >>
>> >> Looks good to me, applied into -cleanup.
>> >>
>> > Just note, needed following additionally.
>> >
>> > -struct device_node;
>> > -void combiner_init(void __iomem *combiner_base, struct device_node *np,
>> > - unsigned int max_nr, int irq_base);
>> > -
>>
>> There is already a patch to clean that up [1] submitted earlier as
>> part of combiner cleanup series.
>> Please apply that first or squash it into this one.
>>
>> [1] https://lkml.org/lkml/2013/6/26/296
>>
> Already did when I applied.
Thanks Kukjin.
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-07-24 9:00 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-11 8:57 [PATCH 1/1] ARM: EXYNOS: Cleanup common.h file Sachin Kamat
2013-07-22 16:30 ` Tomasz Figa
2013-07-24 2:31 ` Kukjin Kim
2013-07-24 3:13 ` Kukjin Kim
2013-07-24 3:37 ` Sachin Kamat
2013-07-24 7:31 ` Kukjin Kim
2013-07-24 9:00 ` Sachin Kamat
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.