* [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
@ 2024-01-30 9:04 Kelly Hung
2024-01-30 9:04 ` Kelly Hung
2024-02-01 9:24 ` Krzysztof Kozlowski
0 siblings, 2 replies; 35+ messages in thread
From: Kelly Hung @ 2024-01-30 9:04 UTC (permalink / raw)
To: openbmc; +Cc: Kelly Hung
This initial device-tree provides the necessary configuration for
basic BMC functionality and work on ASUS X4TF production.
Signed-off-by: Kelly Hung <Kelly_Hung@asus.com>
---
Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
index 749ee54a3ff8..80009948e14a 100644
--- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
+++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
@@ -74,6 +74,7 @@ properties:
- ampere,mtmitchell-bmc
- aspeed,ast2600-evb
- aspeed,ast2600-evb-a1
+ - asus,x4tf
- facebook,bletchley-bmc
- facebook,cloudripper-bmc
- facebook,elbert-bmc
--
2.25.1
^ permalink raw reply related [flat|nested] 35+ messages in thread
* [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
2024-01-30 9:04 [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC Kelly Hung
@ 2024-01-30 9:04 ` Kelly Hung
2024-02-01 9:24 ` Krzysztof Kozlowski
1 sibling, 0 replies; 35+ messages in thread
From: Kelly Hung @ 2024-01-30 9:04 UTC (permalink / raw)
To: openbmc; +Cc: kelly1732000
From: kelly1732000 <Kelly_Hung@asus.com>
This initial device-tree provides the necessary configuration for
basic BMC functionality and work on ASUS X4TF production.
Signed-off-by: kelly1732000 <Kelly_Hung@asus.com>
---
.../boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts | 828 ++++++++++++++++++
1 file changed, 828 insertions(+)
create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts
new file mode 100644
index 000000000000..723bbb33137f
--- /dev/null
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts
@@ -0,0 +1,828 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+// Copyright 2023 ASUS Corp.
+/dts-v1/;
+
+#include "aspeed-g6.dtsi"
+#include <dt-bindings/gpio/aspeed-gpio.h>
+#include <dt-bindings/i2c/i2c.h>
+
+
+/ {
+ model = "ASUS-X4TF";
+ compatible = "asus,x4tf", "aspeed,ast2600";
+
+ chosen {
+ stdout-path = &uart5;
+ bootargs = "console=ttyS4,115200n8 earlycon";
+ };
+
+ memory@80000000 {
+ device_type = "memory";
+ reg = <0x80000000 0x40000000>;
+ };
+
+ reserved-memory {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges;
+
+ gfx_memory: framebuffer {
+ size = <0x01000000>;
+ alignment = <0x01000000>;
+ compatible = "shared-dma-pool";
+ reusable;
+ };
+
+ video_engine_memory: video {
+ size = <0x04000000>;
+ alignment = <0x01000000>;
+ compatible = "shared-dma-pool";
+ reusable;
+ };
+
+ rvas_memory: rvas {
+ size = <0x04000000>;
+ alignment = <0x01000000>;
+ compatible = "shared-dma-pool";
+ reusable;
+ };
+
+ bmc_dev_memory: bmc_dev_memory {
+ size = <0x00100000>;
+ alignment = <0x00100000>;
+ compatible = "shared-dma-pool";
+ no-map;
+ };
+
+ pci_msi_memory: pci_msi_memory {
+ no-map;
+ reg = <0x9e770000 0x100>;
+ compatible = "shared-dma-pool";
+ };
+ /* 1GB memory */
+ vga_memory: region@bf000000 {
+ no-map;
+ compatible = "shared-dma-pool";
+ reg = <0xbf000000 0x01000000>; /* 16M */
+ };
+ ssp_memory: ssp_memory {
+ size = <0x02000000>;
+ alignment = <0x01000000>;
+ compatible = "shared-dma-pool";
+ no-map;
+ };
+ };
+
+ vcc_sdhci0: regulator-vcc-sdhci0 {
+ compatible = "regulator-fixed";
+ status = "disabled";
+ regulator-name = "SDHCI0 Vcc";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ gpios = <&gpio0 ASPEED_GPIO(V, 0) GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ };
+
+ vccq_sdhci0: regulator-vccq-sdhci0 {
+ compatible = "regulator-gpio";
+ status = "disabled";
+ regulator-name = "SDHCI0 VccQ";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ gpios = <&gpio0 ASPEED_GPIO(V, 1) GPIO_ACTIVE_HIGH>;
+ gpios-states = <1>;
+ states = <3300000 1>,
+ <1800000 0>;
+ };
+
+ vcc_sdhci1: regulator-vcc-sdhci1 {
+ compatible = "regulator-fixed";
+ status = "disabled";
+ regulator-name = "SDHCI1 Vcc";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ gpios = <&gpio0 ASPEED_GPIO(V, 2) GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ };
+
+ vccq_sdhci1: regulator-vccq-sdhci1 {
+ compatible = "regulator-gpio";
+ status = "disabled";
+ regulator-name = "SDHCI1 VccQ";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ gpios = <&gpio0 ASPEED_GPIO(V, 3) GPIO_ACTIVE_HIGH>;
+ gpios-states = <1>;
+ states = <3300000 1>,
+ <1800000 0>;
+ };
+ iio-hwmon {
+ compatible = "iio-hwmon";
+ io-channels = <&adc0 0>, <&adc0 1>, <&adc0 2>, <&adc0 3>,
+ <&adc0 4>, <&adc0 5>, <&adc0 6>, <&adc0 7>,
+ <&adc1 0>, <&adc1 1>, <&adc1 2>, <&adc1 3>,
+ <&adc1 4>, <&adc1 5>, <&adc1 6>, <&adc1 7>;
+ };
+
+ video-engine@1e700000 {
+ compatible = "aspeed,ast2600-video-engine";
+ reg = <0x1e700000 0x20000>;
+ clocks = <&syscon ASPEED_CLK_GATE_VCLK>, <&syscon ASPEED_CLK_GATE_ECLK>;
+ clock-names = "vclk", "eclk";
+ interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
+ memory-region = <&video_engine_memory>;
+ //resets = <&syscon ASPEED_RESET_VIDEO>;
+ };
+
+ leds {
+ compatible = "gpio-leds";
+
+ heartbeat {
+ gpios = <&gpio0 ASPEED_GPIO(P, 7) GPIO_ACTIVE_LOW>;
+ linux,default-trigger = "heartbeat";
+ };
+ uid_led {
+ gpios = <&gpio0 ASPEED_GPIO(P, 1) (GPIO_ACTIVE_LOW | GPIO_OPEN_DRAIN)>;
+ default-state = "off";
+ };
+ status_Y {
+ gpios = <&gpio1 ASPEED_GPIO(B, 1) GPIO_ACTIVE_LOW>;
+ default-state = "off";
+ };
+ sys_boot_status {
+ gpios = <&gpio1 ASPEED_GPIO(B, 0) GPIO_ACTIVE_LOW>;
+ default-state = "off";
+ };
+ };
+ spigpio {
+ status = "okay";
+ compatible = "spi-gpio";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ sck-gpios = <&gpio0 ASPEED_GPIO(Z, 3) GPIO_ACTIVE_HIGH>;
+ mosi-gpios = <&gpio0 ASPEED_GPIO(Z, 4) GPIO_ACTIVE_HIGH>;
+ miso-gpios = <&gpio0 ASPEED_GPIO(Z, 5) GPIO_ACTIVE_HIGH>;
+ num-chipselects = <1>;
+ cs-gpios = <&gpio0 ASPEED_GPIO(Z, 0) GPIO_ACTIVE_HIGH>;
+ };
+
+};
+
+&adc0 {
+ vref = <2500>;
+ status = "okay";
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_adc0_default &pinctrl_adc1_default
+ &pinctrl_adc2_default &pinctrl_adc3_default
+ &pinctrl_adc4_default &pinctrl_adc5_default
+ &pinctrl_adc6_default &pinctrl_adc7_default>;
+};
+
+&adc1 {
+ vref = <2500>;
+ status = "okay";
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_adc8_default &pinctrl_adc9_default
+ &pinctrl_adc10_default &pinctrl_adc11_default
+ &pinctrl_adc12_default &pinctrl_adc13_default
+ &pinctrl_adc14_default &pinctrl_adc15_default>;
+};
+
+&peci0 {
+ status = "okay";
+};
+
+&lpc_snoop {
+ snoop-ports = <0x80>;
+ status = "okay";
+};
+
+
+&mdio0 {
+ status = "disabled";
+};
+
+
+&mdio1 {
+ status = "disabled";
+};
+
+&mdio2 {
+ status = "okay";
+
+ ethphy2: ethernet-phy@0 {
+ compatible = "ethernet-phy-ieee802.3-c22";
+ reg = <0>;
+ };
+};
+
+&mdio3 {
+ status = "okay";
+
+ ethphy3: ethernet-phy@0 {
+ compatible = "ethernet-phy-ieee802.3-c22";
+ reg = <0>;
+ };
+};
+
+&mac0 {
+ status = "disabled";
+};
+
+&mac1 {
+ status = "disabled";
+};
+
+//for X4TF
+&mac2 {
+ status = "okay";
+ phy-mode = "rmii";
+ #phy-handle = <ðphy2>;
+ use-ncsi;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_rmii3_default>;
+};
+
+
+&mac3 {
+ status = "okay";
+ phy-mode = "rmii";
+ #phy-handle = <ðphy3>;
+ use-ncsi;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_rmii4_default>;
+};
+
+
+&syscon {
+ uart-clock-high-speed;
+ status = "okay";
+};
+
+&rtc {
+ status = "disabled";
+};
+
+&fmc {
+ status = "okay";
+ flash@0 {
+ status = "okay";
+ m25p,fast-read;
+ label = "bmc-spi";
+ spi-max-frequency = <50000000>;
+ spi-bus-width = <1>;
+ partitions {
+ compatible = "fixed-partitions";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ bmc@0 {
+ label = "bmc";
+ reg = <0x0 0x4000000>;
+ };
+ u-boot@0 {
+ label = "u-boot";
+ reg = <0x0 0x200000>;
+ };
+ u-boot-env@1f0000 {
+ label = "u-boot-env";
+ reg = <0x1f0000 0x10000>;
+ };
+ kernel@200000 {
+ label = "kernel";
+ reg = <0x200000 0xc00000>;
+ };
+ rofs@a00000 {
+ label = "rofs";
+ reg = <0xa00000 0x2a00000>;
+ };
+ rwfs@2a00000 {
+ label = "rwfs";
+ reg = <0x2a00000 0x43f0000>;
+ };
+ };
+ };
+};
+
+&spi1 {
+ status = "okay";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_spi1_default>;
+
+ flash@0 {
+ status = "okay";
+ w25q256,fast-read;
+ label = "bios-spi";
+ spi-max-frequency = <50000000>;
+ partitions {
+ compatible = "fixed-partitions";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ biosfullimg@0 {
+ reg = <0x0 0x2000000>; // 32768 *1024 = 0x2000000, 32 MB
+ label = "biosfullimg";
+ };
+ };
+ };
+};
+
+&i2c0 {
+ status = "okay";
+};
+
+&i2c1 {
+ status = "okay";
+};
+
+&i2c2 {
+ status = "okay";
+};
+
+&i2c3 {
+ status = "okay";
+};
+
+&i2c4 {
+ status = "okay";
+ tmp75@48 {
+ compatible = "ti,tmp75";
+ reg = <0x48>;
+ };
+ tmp75@49 {
+ compatible = "ti,tmp75";
+ reg = <0x49>;
+ };
+
+ pca9555_4_20: gpio@20 {
+ compatible = "nxp,pca9555";
+ reg = <0x20>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+
+ pca9555_4_22: gpio@22 {
+ compatible = "nxp,pca9555";
+ reg = <0x22>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+
+ pca9555_4_24: gpio@24 {
+ compatible = "nxp,pca9555";
+ reg = <0x24>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ gpio-line-names =
+ /*A0 - A7 0*/ "", "STRAP_BMC_BATTERY_GPIO1", "", "", "", "", "", "",
+ /*B0 - B7 8*/ "", "", "", "", "", "", "", "";
+ };
+
+ pca9555_4_26: gpio@26 {
+ compatible = "nxp,pca9555";
+ reg = <0x26>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+
+ i2c-switch@70 {
+ compatible = "nxp,pca9546";
+ status = "okay";
+ reg = <0x70>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ channel_1: i2c@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0>;
+ };
+
+ channel_2: i2c@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <1>;
+ };
+
+ channel_3: i2c@2 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <2>;
+ };
+
+ channel_4: i2c@3 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <3>;
+ };
+ };
+};
+
+&i2c5 {
+ status = "okay";
+ pca9555_5_24: gpio@24 {
+ compatible = "nxp,pca9555";
+ reg = <0x24>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+
+ i2c-switch@70 {
+ compatible = "nxp,pca9546";
+ status = "okay";
+ reg = <0x70 >;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ channel_5: i2c@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0>;
+ pca9555_5_5_20: gpio@20 {
+ compatible = "nxp,pca9555";
+ reg = <0x20>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ gpio-line-names =
+ /*A0 0*/ "", "", "", "", "", "", "", "",
+ /*B0 8*/ "", "", "SYS_FAN6", "SYS_FAN5",
+ /*B4 12*/ "SYS_FAN4", "SYS_FAN3", "SYS_FAN2", "SYS_FAN1";
+ };
+ pca9555_5_5_21: gpio@21 {
+ compatible = "nxp,pca9555";
+ reg = <0x21>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+ ina219@0x44 {
+ compatible = "ti,ina219";
+ reg = <0x44>;
+ rshunt = <2>;
+ };
+ };
+
+ channel_6: i2c@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <1>;
+ };
+
+ channel_7: i2c@2 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <2>;
+ };
+
+ channel_8: i2c@3 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <3>;
+ };
+ };
+};
+
+&i2c6 {
+ status = "okay";
+ pca9555_6_27: gpio@27 {
+ compatible = "nxp,pca9555";
+ reg = <0x27>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+ pca9555_6_20: gpio@20 {
+ compatible = "nxp,pca9555";
+ reg = <0x20>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ gpio-line-names =
+ /*A0 - A7 0*/ "", "", "", "", "", "", "", "",
+ /*B0 - B7 8*/ "Drive_NVMe1", "Drive_NVMe2", "", "", "", "", "", "";
+ };
+ pca9555_6_21: gpio@21 {
+ compatible = "nxp,pca9555";
+ reg = <0x21>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+};
+
+&i2c7 {
+ status = "okay";
+ i2c-switch@70 {
+ compatible = "nxp,pca9546";
+ status = "okay";
+ reg = <0x70>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ idle-state = <1>;
+
+ channel_9: i2c@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0>;
+ tmp75@48 {
+ compatible = "ti,tmp75";
+ reg = <0x48>;
+ };
+ tmp75@49 {
+ compatible = "ti,tmp75";
+ reg = <0x49>;
+ };
+ ina219@0x40 {
+ compatible = "ti,ina219";
+ reg = <0x40>;
+ rshunt = <2>;
+ };
+ ina219@0x41 {
+ compatible = "ti,ina219";
+ reg = <0x41>;
+ rshunt = <5>;
+ };
+ };
+
+ channel_10: i2c@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <1>;
+ };
+
+ channel_11: i2c@2 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <2>;
+ };
+
+ channel_12: i2c@3 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <3>;
+ };
+ };
+ i2c-switch@71 {
+ compatible = "nxp,pca9546";
+ status = "okay";
+ reg = <0x71>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ i2c-mux-idle-disconnect;
+
+ channel_13: i2c@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0>;
+ };
+
+ channel_14: i2c@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <1>;
+ };
+
+ channel_15: i2c@2 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <2>;
+ };
+
+ channel_16: i2c@3 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <3>;
+ };
+ };
+};
+
+&i2c8 {
+ status = "okay";
+ i2c-switch@70 {
+ compatible = "nxp,pca9546";
+ status = "okay";
+ reg = <0x70>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ i2c-mux-idle-disconnect;
+
+ channel_17: i2c@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0>;
+ };
+
+ channel_18: i2c@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <1>;
+ tmp75@48 {
+ compatible = "ti,tmp75";
+ reg = <0x48>;
+ };
+ ina219@0x41 {
+ compatible = "ti,ina219";
+ reg = <0x41>;
+ rshunt = <5>;
+ };
+ };
+
+ channel_19: i2c@2 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <2>;
+ };
+
+ channel_20: i2c@3 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <3>;
+ };
+ };
+};
+
+&i2c9 {
+ status = "okay";
+};
+
+&i2c10 {
+ status = "okay";
+};
+
+&i2c11 {
+ status = "okay";
+};
+
+&i2c12 {
+ status = "disabled";
+};
+
+&i2c13 {
+ status = "disabled";
+};
+
+&i2c14 {
+ status = "okay";
+ multi-master;
+ eeprom@50 {
+ compatible = "atmel,24c08";
+ reg = <0x50>;
+ };
+ eeprom@51 {
+ compatible = "atmel,24c08";
+ reg = <0x51>;
+ };
+};
+
+&sgpiom0 {
+ status = "okay";
+};
+
+&gfx {
+ pcie-reset-detect;
+ status = "disabled";
+ memory-region = <&gfx_memory>;
+};
+
+&sdc {
+ status = "okay";
+};
+
+&sdhci0 {
+ status = "disabled";
+ bus-width = <4>;
+ max-frequency = <100000000>;
+ sdhci-drive-type = /bits/ 8 <3>;
+ /* SDR104/DDR50/SDR50 bits in CAPA2 is not supported */
+ sdhci-caps-mask = <0x7 0x580000>;
+ sdhci,wp-inverted;
+};
+
+#if !defined(CONFIG_SPX_FEATURE_ENABLE_SSP)
+&sdhci1 {
+ status = "disabled";
+ bus-width = <4>;
+ max-frequency = <100000000>;
+ sdhci-drive-type = /bits/ 8 <3>;
+ sdhci-caps-mask = <0x7 0x580000>;
+ sdhci,wp-inverted;
+};
+#endif
+
+&lpc_snoop {
+ status = "okay";
+ snoop-ports = <0x80>;
+};
+
+&ibt {
+ status = "disabled";
+};
+
+&kcs1 {
+ kcs_addr = <0xca0>;
+ status = "okay";
+};
+
+&kcs2 {
+ kcs_addr = <0xca8>;
+ status = "okay";
+};
+
+&kcs3 {
+ kcs_addr = <0xca2>;
+ status = "okay";
+};
+
+&kcs4 {
+ kcs_addr = <0xca4>;
+ status = "disabled";
+};
+
+&uart1 {
+ status = "disabled";
+};
+
+&uart2 {
+ status = "disabled";
+};
+
+&uart3 {
+ status = "okay";
+};
+
+&uart4 {
+ status = "okay";
+ /* GPIOB6 will be used in ASD function, do not set to be TXD4 */
+ //pinctrl-0 = <&pinctrl_txd4_default &pinctrl_rxd4_default>;
+ pinctrl-0 = <&pinctrl_txd2_default &pinctrl_rxd2_default>;
+};
+
+&uart_routing {
+ status = "okay";
+};
+
+&uart5 {
+ status = "okay";
+};
+
+#if defined(CONFIG_SPX_FEATURE_ENABLE_SSP)
+&uart7 {
+ status = "okay";
+};
+#endif
+
+#if defined(CONFIG_SPX_FEATURE_PLATGUARDPLUS_SUPPORT)
+&uart11 {
+ status = "okay";
+};
+#endif
+#ifdef CONFIG_SPX_FEATURE_USB_PORT_B_HOST_SUPPORT
+&ehci1 {
+ status = "okay";
+};
+
+&uhci {
+ status = "okay";
+};
+#endif
+
+&vhub {
+ status = "okay";
+};
+
+#ifdef CONFIG_SPX_FEATURE_USB_PORT_B_SUPPORT
+&udc {
+ status = "okay";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usb2bd_default>;
+};
+#endif
+
+&gpio0 {
+ gpio-line-names =
+ /*A0 0*/ "", "", "", "", "", "", "", "",
+ /*B0 8*/ "", "", "", "", "", "", "PS_PWROK", "",
+ /*C0 16*/ "", "", "", "", "", "", "", "",
+ /*D0 24*/ "", "", "", "", "", "", "", "",
+ /*E0 32*/ "", "", "", "", "", "", "", "",
+ /*F0 40*/ "", "", "", "", "", "", "", "",
+ /*G0 48*/ "", "", "", "", "", "", "", "",
+ /*H0 56*/ "", "", "", "", "", "", "", "",
+ /*I0 64*/ "", "", "", "", "", "", "", "",
+ /*J0 72*/ "", "", "", "", "", "", "", "",
+ /*K0 80*/ "", "", "", "", "", "", "", "",
+ /*L0 88*/ "", "", "", "", "", "", "", "",
+ /*M0 96*/ "", "", "", "", "", "", "", "",
+ /*N0 104*/ "", "", "", "",
+ /*N4 108*/ "POST_COMPLETE", "ESR1_GPIO_AST_SPISEL", "", "",
+ /*O0 112*/ "", "", "", "", "", "", "", "",
+ /*P0 120*/ "ID_BUTTON", "ID_OUT", "POWER_BUTTON", "POWER_OUT",
+ /*P4 124*/ "RESET_BUTTON", "RESET_OUT", "", "HEARTBEAT",
+ /*Q0 128*/ "", "", "", "", "", "", "", "",
+ /*R0 136*/ "", "", "", "", "", "", "", "",
+ /*S0 144*/ "", "", "", "", "", "", "", "",
+ /*T0 152*/ "", "", "", "", "", "", "", "",
+ /*U0 160*/ "", "", "", "", "", "", "", "",
+ /*V0 168*/ "", "", "", "", "", "", "", "",
+ /*W0 176*/ "", "", "", "", "", "", "", "",
+ /*X0 184*/ "", "", "", "", "", "", "", "",
+ /*Y0 192*/ "", "", "", "", "", "", "", "",
+ /*Z0 200*/ "", "", "", "", "", "", "", "";
+};
--
2.25.1
^ permalink raw reply related [flat|nested] 35+ messages in thread
* Re: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
2024-01-30 9:04 [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC Kelly Hung
2024-01-30 9:04 ` Kelly Hung
@ 2024-02-01 9:24 ` Krzysztof Kozlowski
2024-03-05 6:30 ` Kelly Hung(洪嘉莉)
1 sibling, 1 reply; 35+ messages in thread
From: Krzysztof Kozlowski @ 2024-02-01 9:24 UTC (permalink / raw)
To: Kelly Hung, openbmc; +Cc: Kelly Hung
On 30/01/2024 10:04, Kelly Hung wrote:
> This initial device-tree provides the necessary configuration for
> basic BMC functionality and work on ASUS X4TF production.
>
> Signed-off-by: Kelly Hung <Kelly_Hung@asus.com>
> ---
> Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
> 1 file changed, 1 insertion(+)
I assume this is not a submission to mainline Linux kernel thus it is fine.
However if by any chance it is submission to mainline Linux kernel, then:
Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.
Tools like b4 or scripts_getmaintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, use mainline), work on fork of kernel (don't, use
mainline) or you ignore some maintainers (really don't). Just use b4 and
everything should be fine, although remember about `b4 prep
--auto-to-cc` if you added new patches to the patchset.
You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time, thus I will skip this patch entirely till you follow
the process allowing the patch to be tested.
Please kindly resend and include all necessary To/Cc entries.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 35+ messages in thread
* RE: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
2024-02-01 9:24 ` Krzysztof Kozlowski
@ 2024-03-05 6:30 ` Kelly Hung(洪嘉莉)
2024-03-05 7:09 ` Krzysztof Kozlowski
0 siblings, 1 reply; 35+ messages in thread
From: Kelly Hung(洪嘉莉) @ 2024-03-05 6:30 UTC (permalink / raw)
To: Krzysztof Kozlowski, Kelly Hung, openbmc
Cc: AllenYY Hsu(許幼岳)
Hi, Krzysztof,
I have already executed
- `git log --oneline -- DIRECTORY_OR_FILE`
- do scripts/get_maintainers.pl
I tried correcting subject prefix and resent on 2/22.
According this document: https://github.com/openbmc/docs/blob/master/kernel-development.md.
"You should feel welcome to cc the OpenBMC list when sending upstream, so other kernel developers can provide input where appropriate."
So, I also -cc to openbmc@lists.ozlabs.org.
Thanks for review.
Best Regards
Kelly
-----Original Message-----
From: Krzysztof Kozlowski <krzk@kernel.org>
Sent: Thursday, February 1, 2024 5:24 PM
To: Kelly Hung <ppighouse@gmail.com>; openbmc@lists.ozlabs.org
Cc: Kelly Hung(洪嘉莉) <Kelly_Hung@asus.com>
Subject: Re: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
External email : Ensure your email is secure before opening links and attachments.
On 30/01/2024 10:04, Kelly Hung wrote:
> This initial device-tree provides the necessary configuration for
> basic BMC functionality and work on ASUS X4TF production.
>
> Signed-off-by: Kelly Hung <Kelly_Hung@asus.com>
> ---
> Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
> 1 file changed, 1 insertion(+)
I assume this is not a submission to mainline Linux kernel thus it is fine.
However if by any chance it is submission to mainline Linux kernel, then:
Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching.
Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.
Tools like b4 or scripts_getmaintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, use mainline), work on fork of kernel (don't, use
mainline) or you ignore some maintainers (really don't). Just use b4 and everything should be fine, although remember about `b4 prep --auto-to-cc` if you added new patches to the patchset.
You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time, thus I will skip this patch entirely till you follow the process allowing the patch to be tested.
Please kindly resend and include all necessary To/Cc entries.
Best regards,
Krzysztof
<p></p>
===================================================================================================================================
This email and any attachments to it contain confidential information and are intended solely for the use of the individual to whom it is addressed. If you are not the intended recipient or receive it accidentally, please immediately notify the sender by e-mail and delete the message and any attachments from your computer system, and destroy all hard copies. Please be advised that any unauthorized disclosure, copying, distribution or any action taken or omitted in reliance on this, is illegal and prohibited. Any views or opinions expressed are solely those of the author and do not represent those of ASUSTeK.
For pricing information, ASUS is only entitled to set a recommendation resale price. All customers are free to set their own price as they wish.
===================================================================================================================================
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
2024-03-05 6:30 ` Kelly Hung(洪嘉莉)
@ 2024-03-05 7:09 ` Krzysztof Kozlowski
2024-03-05 9:42 ` Kelly Hung(洪嘉莉)
2024-03-26 8:19 ` Chia Li Hung
0 siblings, 2 replies; 35+ messages in thread
From: Krzysztof Kozlowski @ 2024-03-05 7:09 UTC (permalink / raw)
To: Kelly Hung(洪嘉莉), Kelly Hung, openbmc
Cc: AllenYY Hsu(許幼岳)
On 05/03/2024 07:30, Kelly Hung(洪嘉莉) wrote:
> Hi, Krzysztof,
>
> I have already executed
> - `git log --oneline -- DIRECTORY_OR_FILE`
> - do scripts/get_maintainers.pl
> I tried correcting subject prefix and resent on 2/22.
> According this document: https://github.com/openbmc/docs/blob/master/kernel-development.md.
> "You should feel welcome to cc the OpenBMC list when sending upstream, so other kernel developers can provide input where appropriate."
> So, I also -cc to openbmc@lists.ozlabs.org.
>
Please respond inline, instead of top-posting, because it makes your
emails hard to follow.
https://elixir.bootlin.com/linux/v6.8-rc7/source/Documentation/process/submitting-patches.rst#L340
You still ignored my tag.
> ===================================================================================================================================
> This email and any attachments to it contain confidential information and are intended solely for the use of the individual to whom it is addressed. If you are not the
Maybe I am the intended recipient of your message, maybe not. I don't
want to have any legal questions regarding upstream, public
collaboration, thus I will just remove your messages.
Please talk with your IT that such disclaimers in open-source are not
desired (and maybe even harmful).
If you do not understand why, please also see:
https://www.youtube.com/live/fMeH7wqOwXA?si=GY7igfbda6vnjXlJ&t=835
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 35+ messages in thread
* RE: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
2024-03-05 7:09 ` Krzysztof Kozlowski
@ 2024-03-05 9:42 ` Kelly Hung(洪嘉莉)
2024-03-05 9:44 ` Krzysztof Kozlowski
2024-03-26 8:19 ` Chia Li Hung
1 sibling, 1 reply; 35+ messages in thread
From: Kelly Hung(洪嘉莉) @ 2024-03-05 9:42 UTC (permalink / raw)
To: Krzysztof Kozlowski, Kelly Hung, openbmc
Cc: AllenYY Hsu(許幼岳),
Taijie Wu(吳泰頡)
-----Original Message-----
> >On 05/03/2024 07:30, Kelly Hung(洪嘉莉) wrote:
> >
> Please respond inline, instead of top-posting, because it makes your emails hard to follow.
> https://elixir.bootlin.com/linux/v6.8-rc7/source/Documentation/process/submitting-patches.rst#L340
>
Thanks for reminding me many times, I understand now.
> You still ignored my tag.
>
>
> > ======================================================================
> > =============================================================
> > This email and any attachments to it contain confidential information
> > and are intended solely for the use of the individual to whom it is
> > addressed. If you are not the
> Maybe I am the intended recipient of your message, maybe not. I don't want to have any legal questions regarding upstream, public collaboration, thus I will just remove your messages.
>
> Please talk with your IT that such disclaimers in open-source are not desired (and maybe even harmful).
>
> If you do not understand why, please also see:
> https://www.youtube.com/live/fMeH7wqOwXA?si=GY7igfbda6vnjXlJ&t=835
>
Hi, Krzysztof,
I have already asked our company's IT, and because of security laws, IT cannot help me delete that confidential information.
Best Regards
Kelly
===================================================================================================================================
This email and any attachments to it contain confidential information and are intended solely for the use of the individual to whom it is addressed. If you are not the intended recipient or receive it accidentally, please immediately notify the sender by e-mail and delete the message and any attachments from your computer system, and destroy all hard copies. Please be advised that any unauthorized disclosure, copying, distribution or any action taken or omitted in reliance on this, is illegal and prohibited. Any views or opinions expressed are solely those of the author and do not represent those of ASUSTeK.
For pricing information, ASUS is only entitled to set a recommendation resale price. All customers are free to set their own price as they wish.
===================================================================================================================================
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
2024-03-05 9:42 ` Kelly Hung(洪嘉莉)
@ 2024-03-05 9:44 ` Krzysztof Kozlowski
2024-03-05 9:57 ` Chia Li Hung
0 siblings, 1 reply; 35+ messages in thread
From: Krzysztof Kozlowski @ 2024-03-05 9:44 UTC (permalink / raw)
To: Kelly Hung(洪嘉莉), Kelly Hung, openbmc
Cc: AllenYY Hsu(許幼岳),
Taijie Wu(吳泰頡)
On 05/03/2024 10:42, Kelly Hung(洪嘉莉) wrote:
> -----Original Message-----
>
>>> On 05/03/2024 07:30, Kelly Hung(洪嘉莉) wrote:
>>>
>> Please respond inline, instead of top-posting, because it makes your emails hard to follow.
>> https://elixir.bootlin.com/linux/v6.8-rc7/source/Documentation/process/submitting-patches.rst#L340
>>
>
> Thanks for reminding me many times, I understand now.
>
>> You still ignored my tag.
>>
>>
>>> ======================================================================
>>> =============================================================
>>> This email and any attachments to it contain confidential information
>>> and are intended solely for the use of the individual to whom it is
>>> addressed. If you are not the
>
>> Maybe I am the intended recipient of your message, maybe not. I don't want to have any legal questions regarding upstream, public collaboration, thus I will just remove your messages.
>>
>> Please talk with your IT that such disclaimers in open-source are not desired (and maybe even harmful).
>>
>> If you do not understand why, please also see:
>> https://www.youtube.com/live/fMeH7wqOwXA?si=GY7igfbda6vnjXlJ&t=835
>>
> Hi, Krzysztof,
> I have already asked our company's IT, and because of security laws, IT cannot help me delete that confidential information.
Well, this puts me in quite difficult spot because I might be legally
obliged to delete your emails. I don't know how to proceed (and I don't
care), so I recommend using different email provider, but if you do not
want I will conform with the requirements and delete all emails from you.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
2024-03-05 9:44 ` Krzysztof Kozlowski
@ 2024-03-05 9:57 ` Chia Li Hung
0 siblings, 0 replies; 35+ messages in thread
From: Chia Li Hung @ 2024-03-05 9:57 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: AllenYY Hsu(許幼岳),
Taijie Wu(吳泰頡),
Kelly Hung(洪嘉莉),
openbmc
[-- Attachment #1: Type: text/plain, Size: 862 bytes --]
Krzysztof Kozlowski <krzk@kernel.org> 於 2024年3月5日 週二 下午5:44寫道：
> > -----Original Message-----
> >
> >>
> >> Hi, Krzysztof,
> >> I have already asked our company's IT, and because of security laws, IT
> cannot help me delete that confidential information.
>
> >Well, this puts me in quite difficult spot because I might be legally
> obliged to delete your emails. I don't know how to proceed (and I don't
> care), so I recommend using different email provider, but if you do not
> want I will conform with the requirements and delete all emails from you.
>
> >Best regards,
> >Krzysztof
>
> Hi, Krzysztof,
Yes, I replayed this email using my private Gmail account. I hope this
patch continues to be successful.
Please note that the email for my openbmc account is kelly_hung@asus.com.
Thanks.
Best Regards
Kelly
[-- Attachment #2: Type: text/html, Size: 1449 bytes --]
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
2024-03-05 7:09 ` Krzysztof Kozlowski
2024-03-05 9:42 ` Kelly Hung(洪嘉莉)
@ 2024-03-26 8:19 ` Chia Li Hung
2024-03-26 8:43 ` Krzysztof Kozlowski
1 sibling, 1 reply; 35+ messages in thread
From: Chia Li Hung @ 2024-03-26 8:19 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: AllenYY Hsu(許幼岳),
Kelly Hung(洪嘉莉),
openbmc
[-- Attachment #1: Type: text/plain, Size: 1836 bytes --]
Krzysztof Kozlowski <krzk@kernel.org> 於 2024年3月5日 週二 下午3:09寫道：
> On 05/03/2024 07:30, Kelly Hung(洪嘉莉) wrote:
> > Hi, Krzysztof,
> >
> > I have already executed
> > - `git log --oneline -- DIRECTORY_OR_FILE`
> > - do scripts/get_maintainers.pl
> > I tried correcting subject prefix and resent on 2/22.
> > According this document:
> https://github.com/openbmc/docs/blob/master/kernel-development.md.
> > "You should feel welcome to cc the OpenBMC list when sending upstream,
> so other kernel developers can provide input where appropriate."
> > So, I also -cc to openbmc@lists.ozlabs.org.
> >
>
> Please respond inline, instead of top-posting, because it makes your
> emails hard to follow.
>
> https://elixir.bootlin.com/linux/v6.8-rc7/source/Documentation/process/submitting-patches.rst#L340
>
> You still ignored my tag.
>
>
I reply inline using my Gmail account, thanks for your comment.
>
> >
> ===================================================================================================================================
> > This email and any attachments to it contain confidential information
> and are intended solely for the use of the individual to whom it is
> addressed. If you are not the
>
> Maybe I am the intended recipient of your message, maybe not. I don't
> want to have any legal questions regarding upstream, public
> collaboration, thus I will just remove your messages.
>
> Please talk with your IT that such disclaimers in open-source are not
> desired (and maybe even harmful).
>
> If you do not understand why, please also see:
> https://www.youtube.com/live/fMeH7wqOwXA?si=GY7igfbda6vnjXlJ&t=835
>
> Best regards,
> Krzysztof
>
>
I reply using my Gmail account so no more confidential information.
Best Regards,
Kelly
[-- Attachment #2: Type: text/html, Size: 2973 bytes --]
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
2024-03-26 8:19 ` Chia Li Hung
@ 2024-03-26 8:43 ` Krzysztof Kozlowski
2024-03-26 10:53 ` Chia Li Hung
0 siblings, 1 reply; 35+ messages in thread
From: Krzysztof Kozlowski @ 2024-03-26 8:43 UTC (permalink / raw)
To: Chia Li Hung
Cc: AllenYY Hsu(許幼岳),
Kelly Hung(洪嘉莉),
openbmc
On 26/03/2024 09:19, Chia Li Hung wrote:
> Krzysztof Kozlowski <krzk@kernel.org> 於 2024年3月5日 週二 下午3:09寫道：
>
>> On 05/03/2024 07:30, Kelly Hung(洪嘉莉) wrote:
>>> Hi, Krzysztof,
>>>
>>> I have already executed
>>> - `git log --oneline -- DIRECTORY_OR_FILE`
>>> - do scripts/get_maintainers.pl
>>> I tried correcting subject prefix and resent on 2/22.
>>> According this document:
>> https://github.com/openbmc/docs/blob/master/kernel-development.md.
>>> "You should feel welcome to cc the OpenBMC list when sending upstream,
>> so other kernel developers can provide input where appropriate."
>>> So, I also -cc to openbmc@lists.ozlabs.org.
>>>
>>
>> Please respond inline, instead of top-posting, because it makes your
>> emails hard to follow.
>>
>> https://elixir.bootlin.com/linux/v6.8-rc7/source/Documentation/process/submitting-patches.rst#L340
>>
>> You still ignored my tag.
>>
>>
> I reply inline using my Gmail account, thanks for your comment.
OK, and what about my tag? Did you read documentation I linked before?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
2024-03-26 8:43 ` Krzysztof Kozlowski
@ 2024-03-26 10:53 ` Chia Li Hung
2024-03-26 11:29 ` Krzysztof Kozlowski
0 siblings, 1 reply; 35+ messages in thread
From: Chia Li Hung @ 2024-03-26 10:53 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: AllenYY Hsu(許幼岳),
Kelly Hung(洪嘉莉),
openbmc
[-- Attachment #1: Type: text/plain, Size: 1477 bytes --]
Krzysztof Kozlowski <krzk@kernel.org> 於 2024年3月26日 週二 下午4:43寫道：
> On 26/03/2024 09:19, Chia Li Hung wrote:
> > Krzysztof Kozlowski <krzk@kernel.org> 於 2024年3月5日 週二 下午3:09寫道：
> >
> >> On 05/03/2024 07:30, Kelly Hung(洪嘉莉) wrote:
> >>> Hi, Krzysztof,
> >>>
> >>> I have already executed
> >>> - `git log --oneline -- DIRECTORY_OR_FILE`
> >>> - do scripts/get_maintainers.pl
> >>> I tried correcting subject prefix and resent on 2/22.
> >>> According this document:
> >> https://github.com/openbmc/docs/blob/master/kernel-development.md.
> >>> "You should feel welcome to cc the OpenBMC list when sending upstream,
> >> so other kernel developers can provide input where appropriate."
> >>> So, I also -cc to openbmc@lists.ozlabs.org.
> >>>
> >>
> >> Please respond inline, instead of top-posting, because it makes your
> >> emails hard to follow.
> >>
> >>
> https://elixir.bootlin.com/linux/v6.8-rc7/source/Documentation/process/submitting-patches.rst#L340
> >>
> >> You still ignored my tag.
> >>
> >>
> > I reply inline using my Gmail account, thanks for your comment.
>
> OK, and what about my tag? Did you read documentation I linked before?
>
> Hi, Krzysztof,
Regarding tags, I released the v6 patch and added Reviewed-by and Acked-by
tags.
Regarding the confidential information, ASUS has signed the CCLA, can we
add confidential information?
> Best regards,
> Krzysztof
>
>
[-- Attachment #2: Type: text/html, Size: 2641 bytes --]
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
2024-03-26 10:53 ` Chia Li Hung
@ 2024-03-26 11:29 ` Krzysztof Kozlowski
0 siblings, 0 replies; 35+ messages in thread
From: Krzysztof Kozlowski @ 2024-03-26 11:29 UTC (permalink / raw)
To: Chia Li Hung
Cc: AllenYY Hsu(許幼岳),
Kelly Hung(洪嘉莉),
openbmc
On 26/03/2024 11:53, Chia Li Hung wrote:
>>> I reply inline using my Gmail account, thanks for your comment.
>>
>> OK, and what about my tag? Did you read documentation I linked before?
>>
>> Hi, Krzysztof,
> Regarding tags, I released the v6 patch and added Reviewed-by and Acked-by
> tags.
Thank you.
> Regarding the confidential information, ASUS has signed the CCLA, can we
> add confidential information?
No clue what is CCLA, but I did not sign it.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
2024-03-04 11:23 ` Krzysztof Kozlowski
(?)
@ 2024-03-26 8:14 ` Chia Li Hung
-1 siblings, 0 replies; 35+ messages in thread
From: Chia Li Hung @ 2024-03-26 8:14 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: AllenYY Hsu(許幼岳),
Kelly Hung(洪嘉莉),
joel, krzysztof.kozlowski+dt, openbmc
[-- Attachment #1: Type: text/plain, Size: 616 bytes --]
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> 於 2024年3月4日 週一
下午7:23寫道：
> On 04/03/2024 11:45, Kelly Hung(洪嘉莉) wrote:
> > Hi, Krzysztof,
> >
> > Thanks for review, I notice there were a lot of errors. I've corrected
> them and done a schema and patch check, then resend the patch on 2/22.
>
> And what happened with my other messages? Why you were not replying to
> them? Why only some parts were implemented?
>
> Best regards,
> Krzysztof
>
>
Hi, Krzysztof,
I repllied to all emails using my Gamil account again.
Thanks for your comment.
Best Regards
Kelly
[-- Attachment #2: Type: text/html, Size: 1047 bytes --]
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
2024-01-30 10:39 ` Krzysztof Kozlowski
` (2 preceding siblings ...)
(?)
@ 2024-03-26 8:10 ` Chia Li Hung
-1 siblings, 0 replies; 35+ messages in thread
From: Chia Li Hung @ 2024-03-26 8:10 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: AllenYY Hsu(許幼岳),
kelly_hung, joel, krzysztof.kozlowski+dt, openbmc
[-- Attachment #1: Type: text/plain, Size: 17144 bytes --]
Hi, Krzysztof,
I use my Gmail account and response inline.
Thank you.
Best Regards
Kelly
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> 於 2024年1月30日 週二
下午6:39寫道：
> On 30/01/2024 09:56, Kelly Hung wrote:
> > From: kelly1732000 <Kelly_Hung@asus.com>
> >
> > This initial device-tree provides the necessary configuration for
> > basic BMC functionality and work on ASUS X4TF production.
> >
> > Signed-off-by: kelly1732000 <Kelly_Hung@asus.com>
> > ---
> > .../boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts | 828 ++++++++++++++++++
> > 1 file changed, 828 insertions(+)
> > create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts
>
> It's impossible to test this file. You miss Makefile.
>
> I added the Makfile and re-sent the v5 patch on February 29, 2024.
> >
> > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts
> b/arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts
> > new file mode 100644
> > index 000000000000..723bbb33137f
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts
> > @@ -0,0 +1,828 @@
> > +// SPDX-License-Identifier: GPL-2.0-or-later
> > +// Copyright 2023 ASUS Corp.
> > +/dts-v1/;
> > +
> > +#include "aspeed-g6.dtsi"
> > +#include <dt-bindings/gpio/aspeed-gpio.h>
> > +#include <dt-bindings/i2c/i2c.h>
> > +
> > +
> > +/ {
> > + model = "ASUS-X4TF";
> > + compatible = "asus,x4tf", "aspeed,ast2600";
> > +
> > + chosen {
> > + stdout-path = &uart5;
> > + bootargs = "console=ttyS4,115200n8 earlycon";
>
> earlycon is a debugging feature, not mainline. Also, move console to
> stdout-path, so entire bootargs can be dropped.
>
> I removed the bootargs and modified the stdouut-path and re-sent the v5
patch on Februarty 29, 2024.
> > + };
> > +
> > + memory@80000000 {
> > + device_type = "memory";
> > + reg = <0x80000000 0x40000000>;
> > + };
> > +
> > + reserved-memory {
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + ranges;
> > +
> > + gfx_memory: framebuffer {
> > + size = <0x01000000>;
> > + alignment = <0x01000000>;
> > + compatible = "shared-dma-pool";
> > + reusable;
> > + };
> > +
> > + video_engine_memory: video {
> > + size = <0x04000000>;
> > + alignment = <0x01000000>;
> > + compatible = "shared-dma-pool";
> > + reusable;
> > + };
> > +
> > + rvas_memory: rvas {
> > + size = <0x04000000>;
> > + alignment = <0x01000000>;
> > + compatible = "shared-dma-pool";
> > + reusable;
> > + };
> > +
> > + bmc_dev_memory: bmc_dev_memory {
>
> No underscores in node names. This applies everywhere.
>
> I removed the bmc_dev_memory and re-sent the v5 patch.
>
> > + size = <0x00100000>;
> > + alignment = <0x00100000>;
> > + compatible = "shared-dma-pool";
> > + no-map;
> > + };
> > +
> > + pci_msi_memory: pci_msi_memory {
> > + no-map;
> > + reg = <0x9e770000 0x100>;
> > + compatible = "shared-dma-pool";
> > + };
> > + /* 1GB memory */
> > + vga_memory: region@bf000000 {
> > + no-map;
> > + compatible = "shared-dma-pool";
> > + reg = <0xbf000000 0x01000000>; /* 16M */
> > + };
> > + ssp_memory: ssp_memory {
> > + size = <0x02000000>;
> > + alignment = <0x01000000>;
> > + compatible = "shared-dma-pool";
> > + no-map;
> > + };
> > + };
> > +
> > + vcc_sdhci0: regulator-vcc-sdhci0 {
> > + compatible = "regulator-fixed";
> > + status = "disabled";
>
> Why? It makes it entirely pointless.
>
I removed the vcc_sdhci0 and re-send the v5 pathch.
>
> > + regulator-name = "SDHCI0 Vcc";
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > + gpios = <&gpio0 ASPEED_GPIO(V, 0) GPIO_ACTIVE_HIGH>;
> > + enable-active-high;
> > + };
> > +
> > + vccq_sdhci0: regulator-vccq-sdhci0 {
> > + compatible = "regulator-gpio";
> > + status = "disabled";
>
> Pointless node.
>
> I removed the vccq_sdhci0 and re-send the v5 patch.
> > + regulator-name = "SDHCI0 VccQ";
> > + regulator-min-microvolt = <1800000>;
> > + regulator-max-microvolt = <3300000>;
> > + gpios = <&gpio0 ASPEED_GPIO(V, 1) GPIO_ACTIVE_HIGH>;
> > + gpios-states = <1>;
> > + states = <3300000 1>,
> > + <1800000 0>;
> > + };
> > +
> > + vcc_sdhci1: regulator-vcc-sdhci1 {
> > + compatible = "regulator-fixed";
> > + status = "disabled";
>
> Pointless node.
>
> I removed the vcc_sdhci1 and re-send the v5 patch.
>
> > + regulator-name = "SDHCI1 Vcc";
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > + gpios = <&gpio0 ASPEED_GPIO(V, 2) GPIO_ACTIVE_HIGH>;
> > + enable-active-high;
> > + };
> > +
> > + vccq_sdhci1: regulator-vccq-sdhci1 {
> > + compatible = "regulator-gpio";
> > + status = "disabled";
>
> Pointless node.
>
I removed the vccq_sdhci1 and re-send the v5 patch.
> > + regulator-name = "SDHCI1 VccQ";
> > + regulator-min-microvolt = <1800000>;
> > + regulator-max-microvolt = <3300000>;
> > + gpios = <&gpio0 ASPEED_GPIO(V, 3) GPIO_ACTIVE_HIGH>;
> > + gpios-states = <1>;
> > + states = <3300000 1>,
> > + <1800000 0>;
> > + };
>
> Missing blank line.
>
For the blank line issue, I've corrected them all and re-sent the v5 patch.
> > + iio-hwmon {
> > + compatible = "iio-hwmon";
> > + io-channels = <&adc0 0>, <&adc0 1>, <&adc0 2>, <&adc0 3>,
> > + <&adc0 4>, <&adc0 5>, <&adc0 6>, <&adc0 7>,
> > + <&adc1 0>, <&adc1 1>, <&adc1 2>, <&adc1 3>,
> > + <&adc1 4>, <&adc1 5>, <&adc1 6>, <&adc1 7>;
> > + };
> > +> + video-engine@1e700000 {
>
> Wrong placement. Also tools would tell you that.
>
I removed the video-engine.
>
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check W=1` (see
> Documentation/devicetree/bindings/writing-schema.rst or
>
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> for instructions).
>
> > + compatible = "aspeed,ast2600-video-engine";
> > + reg = <0x1e700000 0x20000>;
> > + clocks = <&syscon ASPEED_CLK_GATE_VCLK>, <&syscon
> ASPEED_CLK_GATE_ECLK>;
> > + clock-names = "vclk", "eclk";
> > + interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
> > + memory-region = <&video_engine_memory>;
> > + //resets = <&syscon ASPEED_RESET_VIDEO>;
>
> Dead code.
>
> > + };
> > +
> > + leds {
> > + compatible = "gpio-leds";
> > +
> > + heartbeat {
>
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check W=1` (see
> Documentation/devicetree/bindings/writing-schema.rst or
>
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> for instructions).
>
I've used the dts schema to check our dts.
>
> > + gpios = <&gpio0 ASPEED_GPIO(P, 7) GPIO_ACTIVE_LOW>;
> > + linux,default-trigger = "heartbeat";
> > + };
> > + uid_led {
>
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check W=1` (see
> Documentation/devicetree/bindings/writing-schema.rst or
>
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> for instructions).
>
> > + gpios = <&gpio0 ASPEED_GPIO(P, 1) (GPIO_ACTIVE_LOW
> | GPIO_OPEN_DRAIN)>;
> > + default-state = "off";
> > + };
>
> Missing blank line, everywhere.
>
For the blank line issue, I've corrected them all and re-sent the v5 patch.
>
> > + status_Y {
> > + gpios = <&gpio1 ASPEED_GPIO(B, 1) GPIO_ACTIVE_LOW>;
> > + default-state = "off";
> > + };
> > + sys_boot_status {
> > + gpios = <&gpio1 ASPEED_GPIO(B, 0) GPIO_ACTIVE_LOW>;
> > + default-state = "off";
> > + };
> > + };
> > + spigpio {
>
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check W=1` (see
> Documentation/devicetree/bindings/writing-schema.rst or
>
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> for instructions).
>
> I've used the dts schema to check our dts.
>
> > + status = "okay";
>
> Why?
>
> > + compatible = "spi-gpio";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + sck-gpios = <&gpio0 ASPEED_GPIO(Z, 3) GPIO_ACTIVE_HIGH>;
> > + mosi-gpios = <&gpio0 ASPEED_GPIO(Z, 4) GPIO_ACTIVE_HIGH>;
> > + miso-gpios = <&gpio0 ASPEED_GPIO(Z, 5) GPIO_ACTIVE_HIGH>;
> > + num-chipselects = <1>;
> > + cs-gpios = <&gpio0 ASPEED_GPIO(Z, 0) GPIO_ACTIVE_HIGH>;
> > + };
> > +
>
> Redundant blank line.
>
For the blank line issue, I've corrected them all and re-sent the v5 patch.
>
> > +};
> > +
> > +&adc0 {
> > + vref = <2500>;
> > + status = "okay";
> > +
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_adc0_default &pinctrl_adc1_default
> > + &pinctrl_adc2_default &pinctrl_adc3_default
> > + &pinctrl_adc4_default &pinctrl_adc5_default
> > + &pinctrl_adc6_default &pinctrl_adc7_default>;
> > +};
> > +
> > +&adc1 {
> > + vref = <2500>;
> > + status = "okay";
> > +
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_adc8_default &pinctrl_adc9_default
> > + &pinctrl_adc10_default &pinctrl_adc11_default
> > + &pinctrl_adc12_default &pinctrl_adc13_default
> > + &pinctrl_adc14_default &pinctrl_adc15_default>;
> > +};
> > +
> > +&peci0 {
> > + status = "okay";
> > +};
> > +
> > +&lpc_snoop {
> > + snoop-ports = <0x80>;
> > + status = "okay";
> > +};
> > +
> > +
>
> Redundant blank line. Clean this code before sending upstream from such
> trivialities.
>
For the blank line issue, I've corrected them all and re-sent the v5 patch.
>
> > +&mdio0 {
> > + status = "disabled";
> > +};
> > +
> > +
> > +&mdio1 {
> > + status = "disabled";
> > +};
> > +
> > +&mdio2 {
> > + status = "okay";
> > +
> > + ethphy2: ethernet-phy@0 {
> > + compatible = "ethernet-phy-ieee802.3-c22";
> > + reg = <0>;
> > + };
> > +};
> > +
> > +&mdio3 {
> > + status = "okay";
> > +
> > + ethphy3: ethernet-phy@0 {
> > + compatible = "ethernet-phy-ieee802.3-c22";
> > + reg = <0>;
> > + };
> > +};
> > +
> > +&mac0 {
> > + status = "disabled";
> > +};
> > +
> > +&mac1 {
> > + status = "disabled";
> > +};
> > +
> > +//for X4TF
> > +&mac2 {
> > + status = "okay";
> > + phy-mode = "rmii";
> > + #phy-handle = <ðphy2>;
> > + use-ncsi;
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_rmii3_default>;
> > +};
> > +
> > +
>
> Ditto
>
> For the blank line issue, I've corrected them all and re-sent the v5
patch.
> > +&mac3 {
> > + status = "okay";
> > + phy-mode = "rmii";
> > + #phy-handle = <ðphy3>;
> > + use-ncsi;
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_rmii4_default>;
> > +};
> > +
> > +
>
> Ditto
>
For the blank line issue, I've corrected them all and re-sent the v5 patch.
>
> > +&syscon {
> > + uart-clock-high-speed;
>
> That's a syscon property?
>
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check W=1` (see
> Documentation/devicetree/bindings/writing-schema.rst or
>
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> for instructions).
>
> > + status = "okay";
> > +};
> > +
> > +&rtc {
> > + status = "disabled";
> > +};
> > +
> > +&fmc {
> > + status = "okay";
> > + flash@0 {
> > + status = "okay";
>
> Drop. Everywhere where it is not needed.
>
> I have corrected the related flash configuration and re-send the v5 patch.
>
> > + m25p,fast-read;
> > + label = "bmc-spi";
> > + spi-max-frequency = <50000000>;
> > + spi-bus-width = <1>;
> > + partitions {
> > + compatible = "fixed-partitions";
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + bmc@0 {
> > + label = "bmc";
> > + reg = <0x0 0x4000000>;
> > + };
> > + u-boot@0 {
> > + label = "u-boot";
> > + reg = <0x0 0x200000>;
> > + };
> > + u-boot-env@1f0000 {
> > + label = "u-boot-env";
> > + reg = <0x1f0000 0x10000>;
> > + };
> > + kernel@200000 {
> > + label = "kernel";
> > + reg = <0x200000 0xc00000>;
> > + };
> > + rofs@a00000 {
> > + label = "rofs";
> > + reg = <0xa00000 0x2a00000>;
> > + };
> > + rwfs@2a00000 {
> > + label = "rwfs";
> > + reg = <0x2a00000 0x43f0000>;
> > + };
> > + };
> > + };
> > +};
> > +
> > +&spi1 {
> > + status = "okay";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_spi1_default>;
> > +
> > + flash@0 {
> > + status = "okay";
> > + w25q256,fast-read;
> > + label = "bios-spi";
> > + spi-max-frequency = <50000000>;
> > + partitions {
> > + compatible = "fixed-partitions";
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + biosfullimg@0 {
> > + reg = <0x0 0x2000000>; // 32768 *1024 =
> 0x2000000, 32 MB
> > + label = "biosfullimg";
> > + };
> > + };
> > + };
> > +};
> > +
> > +&i2c0 {
> > + status = "okay";
> > +};
> > +
> > +&i2c1 {
> > + status = "okay";
> > +};
> > +
> > +&i2c2 {
> > + status = "okay";
> > +};
> > +
> > +&i2c3 {
> > + status = "okay";
> > +};
> > +
> > +&i2c4 {
> > + status = "okay";
> > + tmp75@48 {
>
> Node names should be generic. See also an explanation and list of
> examples (not exhaustive) in DT specification:
>
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>
> I've used the dts schema to check our dts.
>
>
> > + compatible = "ti,tmp75";
> > + reg = <0x48>;
> > + };
> > + tmp75@49 {
>
> Node names should be generic. See also an explanation and list of
> examples (not exhaustive) in DT specification:
>
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>
>
I've used the dts schema to check our dts.
> I am going to skip the rest. Please fix all the trivialities and test
> your patches with tools.
>
> Best regards,
> Krzysztof
>
>
[-- Attachment #2: Type: text/html, Size: 27547 bytes --]
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
2024-01-30 10:35 ` Krzysztof Kozlowski
(?)
(?)
@ 2024-03-26 7:57 ` Chia Li Hung
-1 siblings, 0 replies; 35+ messages in thread
From: Chia Li Hung @ 2024-03-26 7:57 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: AllenYY Hsu(許幼岳),
kelly_hung, joel, krzysztof.kozlowski+dt, openbmc
[-- Attachment #1: Type: text/plain, Size: 788 bytes --]
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> 於 2024年1月30日 週二
下午6:35寫道：
> On 30/01/2024 09:56, Kelly Hung wrote:
> > This initial device-tree provides the necessary configuration for
> > basic BMC functionality and work on ASUS X4TF production.
> >
> > Signed-off-by: Kelly Hung <Kelly_Hung@asus.com>
>
> Please use subject prefixes matching the subsystem. You can get them for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching.
>
> Hi, Krzysztof,
I use my Gmail account and respond inline.
Yes, I used `git log --oneline -- DIRECTORY_OR_FILE` and re-sent the v5
patch on February 29, 2024.
[PATCH v5 1/2] dt-bindings: arm: aspeed: add ASUS X4TF board
> Best regards,
> Krzysztof
>
>
[-- Attachment #2: Type: text/html, Size: 1426 bytes --]
^ permalink raw reply [flat|nested] 35+ messages in thread
* RE: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
2024-01-30 10:35 ` Krzysztof Kozlowski
@ 2024-03-05 4:15 ` Kelly Hung(洪嘉莉)
-1 siblings, 0 replies; 35+ messages in thread
From: Kelly Hung(洪嘉莉) @ 2024-03-05 4:15 UTC (permalink / raw)
To: Krzysztof Kozlowski, Kelly Hung, robh+dt
Cc: krzysztof.kozlowski+dt, conor+dt, joel, andrew, devicetree,
linux-arm-kernel, linux-aspeed, linux-kernel,
AllenYY Hsu(許幼岳)
Hi, Krzysztof,
Thanks for reminding. I've finished and corrected my theme prefix.
Best Regards
Kelly
-----Original Message-----
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Sent: Tuesday, January 30, 2024 6:35 PM
To: Kelly Hung <ppighouse@gmail.com>; robh+dt@kernel.org
Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; joel@jms.id.au; andrew@codeconstruct.com.au; devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org; Kelly Hung(洪嘉莉) <Kelly_Hung@asus.com>
Subject: Re: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
External email : Ensure your email is secure before opening links and attachments.
On 30/01/2024 09:56, Kelly Hung wrote:
> This initial device-tree provides the necessary configuration for
> basic BMC functionality and work on ASUS X4TF production.
>
> Signed-off-by: Kelly Hung <Kelly_Hung@asus.com>
Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching.
Best regards,
Krzysztof
<p></p>
===================================================================================================================================
This email and any attachments to it contain confidential information and are intended solely for the use of the individual to whom it is addressed. If you are not the intended recipient or receive it accidentally, please immediately notify the sender by e-mail and delete the message and any attachments from your computer system, and destroy all hard copies. Please be advised that any unauthorized disclosure, copying, distribution or any action taken or omitted in reliance on this, is illegal and prohibited. Any views or opinions expressed are solely those of the author and do not represent those of ASUSTeK.
For pricing information, ASUS is only entitled to set a recommendation resale price. All customers are free to set their own price as they wish.
===================================================================================================================================
^ permalink raw reply [flat|nested] 35+ messages in thread
* RE: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
@ 2024-03-05 4:15 ` Kelly Hung(洪嘉莉)
0 siblings, 0 replies; 35+ messages in thread
From: Kelly Hung(洪嘉莉) @ 2024-03-05 4:15 UTC (permalink / raw)
To: Krzysztof Kozlowski, Kelly Hung, robh+dt
Cc: krzysztof.kozlowski+dt, conor+dt, joel, andrew, devicetree,
linux-arm-kernel, linux-aspeed, linux-kernel,
AllenYY Hsu(許幼岳)
Hi, Krzysztof,
Thanks for reminding. I've finished and corrected my theme prefix.
Best Regards
Kelly
-----Original Message-----
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Sent: Tuesday, January 30, 2024 6:35 PM
To: Kelly Hung <ppighouse@gmail.com>; robh+dt@kernel.org
Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; joel@jms.id.au; andrew@codeconstruct.com.au; devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org; Kelly Hung(洪嘉莉) <Kelly_Hung@asus.com>
Subject: Re: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
External email : Ensure your email is secure before opening links and attachments.
On 30/01/2024 09:56, Kelly Hung wrote:
> This initial device-tree provides the necessary configuration for
> basic BMC functionality and work on ASUS X4TF production.
>
> Signed-off-by: Kelly Hung <Kelly_Hung@asus.com>
Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching.
Best regards,
Krzysztof
<p></p>
===================================================================================================================================
This email and any attachments to it contain confidential information and are intended solely for the use of the individual to whom it is addressed. If you are not the intended recipient or receive it accidentally, please immediately notify the sender by e-mail and delete the message and any attachments from your computer system, and destroy all hard copies. Please be advised that any unauthorized disclosure, copying, distribution or any action taken or omitted in reliance on this, is illegal and prohibited. Any views or opinions expressed are solely those of the author and do not represent those of ASUSTeK.
For pricing information, ASUS is only entitled to set a recommendation resale price. All customers are free to set their own price as they wish.
===================================================================================================================================
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 35+ messages in thread
* RE: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
2024-01-30 10:39 ` Krzysztof Kozlowski
@ 2024-03-05 4:04 ` Kelly Hung(洪嘉莉)
-1 siblings, 0 replies; 35+ messages in thread
From: Kelly Hung(洪嘉莉) @ 2024-03-05 4:04 UTC (permalink / raw)
To: Krzysztof Kozlowski, Kelly Hung, robh+dt
Cc: krzysztof.kozlowski+dt, conor+dt, joel, andrew, devicetree,
linux-arm-kernel, linux-aspeed, linux-kernel,
AllenYY Hsu(許幼岳)
Hi, Krzysztof,
I'll use the full name in future patches.
Thanks for reminding.
Best Regards
Kelly
-----Original Message-----
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Sent: Tuesday, January 30, 2024 6:40 PM
To: Kelly Hung <ppighouse@gmail.com>; robh+dt@kernel.org
Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; joel@jms.id.au; andrew@codeconstruct.com.au; devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org; Kelly Hung(洪嘉莉) <Kelly_Hung@asus.com>
Subject: Re: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
External email : Ensure your email is secure before opening links and attachments.
On 30/01/2024 09:56, Kelly Hung wrote:
> From: kelly1732000 <Kelly_Hung@asus.com>
>
> This initial device-tree provides the necessary configuration for
> basic BMC functionality and work on ASUS X4TF production.
>
> Signed-off-by: kelly1732000 <Kelly_Hung@asus.com>
Please use full name.
Best regards,
Krzysztof
<p></p>
===================================================================================================================================
This email and any attachments to it contain confidential information and are intended solely for the use of the individual to whom it is addressed. If you are not the intended recipient or receive it accidentally, please immediately notify the sender by e-mail and delete the message and any attachments from your computer system, and destroy all hard copies. Please be advised that any unauthorized disclosure, copying, distribution or any action taken or omitted in reliance on this, is illegal and prohibited. Any views or opinions expressed are solely those of the author and do not represent those of ASUSTeK.
For pricing information, ASUS is only entitled to set a recommendation resale price. All customers are free to set their own price as they wish.
===================================================================================================================================
^ permalink raw reply [flat|nested] 35+ messages in thread
* RE: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
@ 2024-03-05 4:04 ` Kelly Hung(洪嘉莉)
0 siblings, 0 replies; 35+ messages in thread
From: Kelly Hung(洪嘉莉) @ 2024-03-05 4:04 UTC (permalink / raw)
To: Krzysztof Kozlowski, Kelly Hung, robh+dt
Cc: krzysztof.kozlowski+dt, conor+dt, joel, andrew, devicetree,
linux-arm-kernel, linux-aspeed, linux-kernel,
AllenYY Hsu(許幼岳)
Hi, Krzysztof,
I'll use the full name in future patches.
Thanks for reminding.
Best Regards
Kelly
-----Original Message-----
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Sent: Tuesday, January 30, 2024 6:40 PM
To: Kelly Hung <ppighouse@gmail.com>; robh+dt@kernel.org
Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; joel@jms.id.au; andrew@codeconstruct.com.au; devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org; Kelly Hung(洪嘉莉) <Kelly_Hung@asus.com>
Subject: Re: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
External email : Ensure your email is secure before opening links and attachments.
On 30/01/2024 09:56, Kelly Hung wrote:
> From: kelly1732000 <Kelly_Hung@asus.com>
>
> This initial device-tree provides the necessary configuration for
> basic BMC functionality and work on ASUS X4TF production.
>
> Signed-off-by: kelly1732000 <Kelly_Hung@asus.com>
Please use full name.
Best regards,
Krzysztof
<p></p>
===================================================================================================================================
This email and any attachments to it contain confidential information and are intended solely for the use of the individual to whom it is addressed. If you are not the intended recipient or receive it accidentally, please immediately notify the sender by e-mail and delete the message and any attachments from your computer system, and destroy all hard copies. Please be advised that any unauthorized disclosure, copying, distribution or any action taken or omitted in reliance on this, is illegal and prohibited. Any views or opinions expressed are solely those of the author and do not represent those of ASUSTeK.
For pricing information, ASUS is only entitled to set a recommendation resale price. All customers are free to set their own price as they wish.
===================================================================================================================================
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 35+ messages in thread
* RE: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
2024-01-30 10:39 ` Krzysztof Kozlowski
@ 2024-03-05 3:52 ` Kelly Hung(洪嘉莉)
-1 siblings, 0 replies; 35+ messages in thread
From: Kelly Hung(洪嘉莉) @ 2024-03-05 3:52 UTC (permalink / raw)
To: Krzysztof Kozlowski, Kelly Hung, robh+dt
Cc: krzysztof.kozlowski+dt, conor+dt, joel, andrew, devicetree,
linux-arm-kernel, linux-aspeed, linux-kernel,
AllenYY Hsu(許幼岳)
Hi, Krzysztof,
Please see my response below.
Thanks a log.
Best Regards
Kelly
-----Original Message-----
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Sent: Tuesday, January 30, 2024 6:39 PM
To: Kelly Hung <ppighouse@gmail.com>; robh+dt@kernel.org
Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; joel@jms.id.au; andrew@codeconstruct.com.au; devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org; Kelly Hung(洪嘉莉) <Kelly_Hung@asus.com>
Subject: Re: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
External email : Ensure your email is secure before opening links and attachments.
On 30/01/2024 09:56, Kelly Hung wrote:
> From: kelly1732000 <Kelly_Hung@asus.com>
>
> This initial device-tree provides the necessary configuration for
> basic BMC functionality and work on ASUS X4TF production.
>
> Signed-off-by: kelly1732000 <Kelly_Hung@asus.com>
> ---
> .../boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts | 828
> ++++++++++++++++++
> 1 file changed, 828 insertions(+)
> create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts
It's impossible to test this file. You miss Makefile.
Kelly: I've add aspeed-bmc-asus-x4tf.dtb in Makefle.
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts
> b/arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts
> new file mode 100644
> index 000000000000..723bbb33137f
> --- /dev/null
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts
> @@ -0,0 +1,828 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later // Copyright 2023 ASUS
> +Corp.
> +/dts-v1/;
> +
> +#include "aspeed-g6.dtsi"
> +#include <dt-bindings/gpio/aspeed-gpio.h> #include
> +<dt-bindings/i2c/i2c.h>
> +
> +
> +/ {
> + model = "ASUS-X4TF";
> + compatible = "asus,x4tf", "aspeed,ast2600";
> +
> + chosen {
> + stdout-path = &uart5;
> + bootargs = "console=ttyS4,115200n8 earlycon";
earlycon is a debugging feature, not mainline. Also, move console to stdout-path, so entire bootargs can be dropped.
Kelly: I've moved "bootargs" into "stdout-path" and resend my patch.
> + };
> +
> + memory@80000000 {
> + device_type = "memory";
> + reg = <0x80000000 0x40000000>;
> + };
> +
> + reserved-memory {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + gfx_memory: framebuffer {
> + size = <0x01000000>;
> + alignment = <0x01000000>;
> + compatible = "shared-dma-pool";
> + reusable;
> + };
> +
> + video_engine_memory: video {
> + size = <0x04000000>;
> + alignment = <0x01000000>;
> + compatible = "shared-dma-pool";
> + reusable;
> + };
> +
> + rvas_memory: rvas {
> + size = <0x04000000>;
> + alignment = <0x01000000>;
> + compatible = "shared-dma-pool";
> + reusable;
> + };
> +
> + bmc_dev_memory: bmc_dev_memory {
No underscores in node names. This applies everywhere.
Kelly: Yes, thanks for reminding, I've removed it and resent my patch.
> + size = <0x00100000>;
> + alignment = <0x00100000>;
> + compatible = "shared-dma-pool";
> + no-map;
> + };
> +
> + pci_msi_memory: pci_msi_memory {
> + no-map;
> + reg = <0x9e770000 0x100>;
> + compatible = "shared-dma-pool";
> + };
> + /* 1GB memory */
> + vga_memory: region@bf000000 {
> + no-map;
> + compatible = "shared-dma-pool";
> + reg = <0xbf000000 0x01000000>; /* 16M */
> + };
> + ssp_memory: ssp_memory {
> + size = <0x02000000>;
> + alignment = <0x01000000>;
> + compatible = "shared-dma-pool";
> + no-map;
> + };
> + };
> +
> + vcc_sdhci0: regulator-vcc-sdhci0 {
> + compatible = "regulator-fixed";
> + status = "disabled";
Why? It makes it entirely pointless.
Kelly: I've removed it and loaded into our X4TF platform and it boot into BMC console. I have resent my patch.
> + regulator-name = "SDHCI0 Vcc";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + gpios = <&gpio0 ASPEED_GPIO(V, 0) GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + };
> +
> + vccq_sdhci0: regulator-vccq-sdhci0 {
> + compatible = "regulator-gpio";
> + status = "disabled";
Pointless node.
Kelly: I've removed it and loaded into our X4TF platform and it boot into BMC console. I have resent my patch.
> + regulator-name = "SDHCI0 VccQ";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3300000>;
> + gpios = <&gpio0 ASPEED_GPIO(V, 1) GPIO_ACTIVE_HIGH>;
> + gpios-states = <1>;
> + states = <3300000 1>,
> + <1800000 0>;
> + };
> +
> + vcc_sdhci1: regulator-vcc-sdhci1 {
> + compatible = "regulator-fixed";
> + status = "disabled";
Pointless node.
Kelly: I've removed it and loaded into our X4TF platform and it boot into BMC console. I have resent my patch.
> + regulator-name = "SDHCI1 Vcc";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + gpios = <&gpio0 ASPEED_GPIO(V, 2) GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + };
> +
> + vccq_sdhci1: regulator-vccq-sdhci1 {
> + compatible = "regulator-gpio";
> + status = "disabled";
Pointless node.
Kelly: I've removed it and loaded into our X4TF platform and it boot into BMC console. I have resent my patch.
> + regulator-name = "SDHCI1 VccQ";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3300000>;
> + gpios = <&gpio0 ASPEED_GPIO(V, 3) GPIO_ACTIVE_HIGH>;
> + gpios-states = <1>;
> + states = <3300000 1>,
> + <1800000 0>;
> + };
Missing blank line.
Kelly: I've review our dts and add blank line or remove redundant blank lines.
> + iio-hwmon {
> + compatible = "iio-hwmon";
> + io-channels = <&adc0 0>, <&adc0 1>, <&adc0 2>, <&adc0 3>,
> + <&adc0 4>, <&adc0 5>, <&adc0 6>, <&adc0 7>,
> + <&adc1 0>, <&adc1 1>, <&adc1 2>, <&adc1 3>,
> + <&adc1 4>, <&adc1 5>, <&adc1 6>, <&adc1 7>;
> + };
> +> + video-engine@1e700000 {
Wrong placement. Also tools would tell you that.
It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Kelly: I've checked our dts, removed unnecessary parts and run the DTS check script.
> + compatible = "aspeed,ast2600-video-engine";
> + reg = <0x1e700000 0x20000>;
> + clocks = <&syscon ASPEED_CLK_GATE_VCLK>, <&syscon ASPEED_CLK_GATE_ECLK>;
> + clock-names = "vclk", "eclk";
> + interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
> + memory-region = <&video_engine_memory>;
> + //resets = <&syscon ASPEED_RESET_VIDEO>;
Dead code.
Kelly: I have removed this part and resent the patch.
> + };
> +
> + leds {
> + compatible = "gpio-leds";
> +
> + heartbeat {
It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Kelly: I added led- for all LED configurations. Heartbeat will be led-heartbeat.
> + gpios = <&gpio0 ASPEED_GPIO(P, 7) GPIO_ACTIVE_LOW>;
> + linux,default-trigger = "heartbeat";
> + };
> + uid_led {
It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Kelly: I added led- for all LED configurations.
> + gpios = <&gpio0 ASPEED_GPIO(P, 1) (GPIO_ACTIVE_LOW | GPIO_OPEN_DRAIN)>;
> + default-state = "off";
> + };
Missing blank line, everywhere.
Kelly: I've review our dts and add blank line or remove redundant blank lines.
> + status_Y {
> + gpios = <&gpio1 ASPEED_GPIO(B, 1) GPIO_ACTIVE_LOW>;
> + default-state = "off";
> + };
> + sys_boot_status {
> + gpios = <&gpio1 ASPEED_GPIO(B, 0) GPIO_ACTIVE_LOW>;
> + default-state = "off";
> + };
> + };
> + spigpio {
It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
> + status = "okay";
Why?
Kelly: I've removed spigpio and tested on our X4TF platform and it boots to the BMC console. I've resent our new patch.
> + compatible = "spi-gpio";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + sck-gpios = <&gpio0 ASPEED_GPIO(Z, 3) GPIO_ACTIVE_HIGH>;
> + mosi-gpios = <&gpio0 ASPEED_GPIO(Z, 4) GPIO_ACTIVE_HIGH>;
> + miso-gpios = <&gpio0 ASPEED_GPIO(Z, 5) GPIO_ACTIVE_HIGH>;
> + num-chipselects = <1>;
> + cs-gpios = <&gpio0 ASPEED_GPIO(Z, 0) GPIO_ACTIVE_HIGH>;
> + };
> +
Redundant blank line.
Kelly: I've review our dts and add blank line or remove redundant blank lines.
> +};
> +
> +&adc0 {
> + vref = <2500>;
> + status = "okay";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_adc0_default &pinctrl_adc1_default
> + &pinctrl_adc2_default &pinctrl_adc3_default
> + &pinctrl_adc4_default &pinctrl_adc5_default
> + &pinctrl_adc6_default &pinctrl_adc7_default>; };
> +
> +&adc1 {
> + vref = <2500>;
> + status = "okay";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_adc8_default &pinctrl_adc9_default
> + &pinctrl_adc10_default &pinctrl_adc11_default
> + &pinctrl_adc12_default &pinctrl_adc13_default
> + &pinctrl_adc14_default &pinctrl_adc15_default>; };
> +
> +&peci0 {
> + status = "okay";
> +};
> +
> +&lpc_snoop {
> + snoop-ports = <0x80>;
> + status = "okay";
> +};
> +
> +
Redundant blank line. Clean this code before sending upstream from such trivialities.
Kelly: I've review our dts and add blank line or remove redundant blank lines.
> +&mdio0 {
> + status = "disabled";
> +};
> +
> +
> +&mdio1 {
> + status = "disabled";
> +};
> +
> +&mdio2 {
> + status = "okay";
> +
> + ethphy2: ethernet-phy@0 {
> + compatible = "ethernet-phy-ieee802.3-c22";
> + reg = <0>;
> + };
> +};
> +
> +&mdio3 {
> + status = "okay";
> +
> + ethphy3: ethernet-phy@0 {
> + compatible = "ethernet-phy-ieee802.3-c22";
> + reg = <0>;
> + };
> +};
> +
> +&mac0 {
> + status = "disabled";
> +};
> +
> +&mac1 {
> + status = "disabled";
> +};
> +
> +//for X4TF
> +&mac2 {
> + status = "okay";
> + phy-mode = "rmii";
> + #phy-handle = <ðphy2>;
> + use-ncsi;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_rmii3_default>; };
> +
> +
Ditto
Kelly: I've review our dts and add blank line or remove redundant blank lines.
> +&mac3 {
> + status = "okay";
> + phy-mode = "rmii";
> + #phy-handle = <ðphy3>;
> + use-ncsi;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_rmii4_default>; };
> +
> +
Ditto
Kelly: I've review our dts and add blank line or remove redundant blank lines.
> +&syscon {
> + uart-clock-high-speed;
That's a syscon property?
It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Kelly: I've removed syscon and tested on our X4TF platform and it boots to the BMC console. I've resent our new patch.
> + status = "okay";
> +};
> +
> +&rtc {
> + status = "disabled";
> +};
> +
> +&fmc {
> + status = "okay";
> + flash@0 {
> + status = "okay";
Drop. Everywhere where it is not needed.
Kelly: I've adjusted fmc config and resent the patch.
> + m25p,fast-read;
> + label = "bmc-spi";
> + spi-max-frequency = <50000000>;
> + spi-bus-width = <1>;
> + partitions {
> + compatible = "fixed-partitions";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + bmc@0 {
> + label = "bmc";
> + reg = <0x0 0x4000000>;
> + };
> + u-boot@0 {
> + label = "u-boot";
> + reg = <0x0 0x200000>;
> + };
> + u-boot-env@1f0000 {
> + label = "u-boot-env";
> + reg = <0x1f0000 0x10000>;
> + };
> + kernel@200000 {
> + label = "kernel";
> + reg = <0x200000 0xc00000>;
> + };
> + rofs@a00000 {
> + label = "rofs";
> + reg = <0xa00000 0x2a00000>;
> + };
> + rwfs@2a00000 {
> + label = "rwfs";
> + reg = <0x2a00000 0x43f0000>;
> + };
> + };
> + };
> +};
> +
> +&spi1 {
> + status = "okay";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_spi1_default>;
> +
> + flash@0 {
> + status = "okay";
> + w25q256,fast-read;
> + label = "bios-spi";
> + spi-max-frequency = <50000000>;
> + partitions {
> + compatible = "fixed-partitions";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + biosfullimg@0 {
> + reg = <0x0 0x2000000>; // 32768 *1024 = 0x2000000, 32 MB
> + label = "biosfullimg";
> + };
> + };
> + };
> +};
> +
> +&i2c0 {
> + status = "okay";
> +};
> +
> +&i2c1 {
> + status = "okay";
> +};
> +
> +&i2c2 {
> + status = "okay";
> +};
> +
> +&i2c3 {
> + status = "okay";
> +};
> +
> +&i2c4 {
> + status = "okay";
> + tmp75@48 {
Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "ti,tmp75";
> + reg = <0x48>;
> + };
> + tmp75@49 {
Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
I am going to skip the rest. Please fix all the trivialities and test your patches with tools.
Kelly: I have renamed tmp75 as temperature-sensor.
I've checked our dts, removed unnecessary parts and run the DTS check script.
Best regards,
Krzysztof
<p></p>
===================================================================================================================================
This email and any attachments to it contain confidential information and are intended solely for the use of the individual to whom it is addressed. If you are not the intended recipient or receive it accidentally, please immediately notify the sender by e-mail and delete the message and any attachments from your computer system, and destroy all hard copies. Please be advised that any unauthorized disclosure, copying, distribution or any action taken or omitted in reliance on this, is illegal and prohibited. Any views or opinions expressed are solely those of the author and do not represent those of ASUSTeK.
For pricing information, ASUS is only entitled to set a recommendation resale price. All customers are free to set their own price as they wish.
===================================================================================================================================
^ permalink raw reply [flat|nested] 35+ messages in thread
* RE: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
@ 2024-03-05 3:52 ` Kelly Hung(洪嘉莉)
0 siblings, 0 replies; 35+ messages in thread
From: Kelly Hung(洪嘉莉) @ 2024-03-05 3:52 UTC (permalink / raw)
To: Krzysztof Kozlowski, Kelly Hung, robh+dt
Cc: krzysztof.kozlowski+dt, conor+dt, joel, andrew, devicetree,
linux-arm-kernel, linux-aspeed, linux-kernel,
AllenYY Hsu(許幼岳)
Hi, Krzysztof,
Please see my response below.
Thanks a log.
Best Regards
Kelly
-----Original Message-----
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Sent: Tuesday, January 30, 2024 6:39 PM
To: Kelly Hung <ppighouse@gmail.com>; robh+dt@kernel.org
Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; joel@jms.id.au; andrew@codeconstruct.com.au; devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org; Kelly Hung(洪嘉莉) <Kelly_Hung@asus.com>
Subject: Re: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
External email : Ensure your email is secure before opening links and attachments.
On 30/01/2024 09:56, Kelly Hung wrote:
> From: kelly1732000 <Kelly_Hung@asus.com>
>
> This initial device-tree provides the necessary configuration for
> basic BMC functionality and work on ASUS X4TF production.
>
> Signed-off-by: kelly1732000 <Kelly_Hung@asus.com>
> ---
> .../boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts | 828
> ++++++++++++++++++
> 1 file changed, 828 insertions(+)
> create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts
It's impossible to test this file. You miss Makefile.
Kelly: I've add aspeed-bmc-asus-x4tf.dtb in Makefle.
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts
> b/arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts
> new file mode 100644
> index 000000000000..723bbb33137f
> --- /dev/null
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts
> @@ -0,0 +1,828 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later // Copyright 2023 ASUS
> +Corp.
> +/dts-v1/;
> +
> +#include "aspeed-g6.dtsi"
> +#include <dt-bindings/gpio/aspeed-gpio.h> #include
> +<dt-bindings/i2c/i2c.h>
> +
> +
> +/ {
> + model = "ASUS-X4TF";
> + compatible = "asus,x4tf", "aspeed,ast2600";
> +
> + chosen {
> + stdout-path = &uart5;
> + bootargs = "console=ttyS4,115200n8 earlycon";
earlycon is a debugging feature, not mainline. Also, move console to stdout-path, so entire bootargs can be dropped.
Kelly: I've moved "bootargs" into "stdout-path" and resend my patch.
> + };
> +
> + memory@80000000 {
> + device_type = "memory";
> + reg = <0x80000000 0x40000000>;
> + };
> +
> + reserved-memory {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + gfx_memory: framebuffer {
> + size = <0x01000000>;
> + alignment = <0x01000000>;
> + compatible = "shared-dma-pool";
> + reusable;
> + };
> +
> + video_engine_memory: video {
> + size = <0x04000000>;
> + alignment = <0x01000000>;
> + compatible = "shared-dma-pool";
> + reusable;
> + };
> +
> + rvas_memory: rvas {
> + size = <0x04000000>;
> + alignment = <0x01000000>;
> + compatible = "shared-dma-pool";
> + reusable;
> + };
> +
> + bmc_dev_memory: bmc_dev_memory {
No underscores in node names. This applies everywhere.
Kelly: Yes, thanks for reminding, I've removed it and resent my patch.
> + size = <0x00100000>;
> + alignment = <0x00100000>;
> + compatible = "shared-dma-pool";
> + no-map;
> + };
> +
> + pci_msi_memory: pci_msi_memory {
> + no-map;
> + reg = <0x9e770000 0x100>;
> + compatible = "shared-dma-pool";
> + };
> + /* 1GB memory */
> + vga_memory: region@bf000000 {
> + no-map;
> + compatible = "shared-dma-pool";
> + reg = <0xbf000000 0x01000000>; /* 16M */
> + };
> + ssp_memory: ssp_memory {
> + size = <0x02000000>;
> + alignment = <0x01000000>;
> + compatible = "shared-dma-pool";
> + no-map;
> + };
> + };
> +
> + vcc_sdhci0: regulator-vcc-sdhci0 {
> + compatible = "regulator-fixed";
> + status = "disabled";
Why? It makes it entirely pointless.
Kelly: I've removed it and loaded into our X4TF platform and it boot into BMC console. I have resent my patch.
> + regulator-name = "SDHCI0 Vcc";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + gpios = <&gpio0 ASPEED_GPIO(V, 0) GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + };
> +
> + vccq_sdhci0: regulator-vccq-sdhci0 {
> + compatible = "regulator-gpio";
> + status = "disabled";
Pointless node.
Kelly: I've removed it and loaded into our X4TF platform and it boot into BMC console. I have resent my patch.
> + regulator-name = "SDHCI0 VccQ";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3300000>;
> + gpios = <&gpio0 ASPEED_GPIO(V, 1) GPIO_ACTIVE_HIGH>;
> + gpios-states = <1>;
> + states = <3300000 1>,
> + <1800000 0>;
> + };
> +
> + vcc_sdhci1: regulator-vcc-sdhci1 {
> + compatible = "regulator-fixed";
> + status = "disabled";
Pointless node.
Kelly: I've removed it and loaded into our X4TF platform and it boot into BMC console. I have resent my patch.
> + regulator-name = "SDHCI1 Vcc";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + gpios = <&gpio0 ASPEED_GPIO(V, 2) GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + };
> +
> + vccq_sdhci1: regulator-vccq-sdhci1 {
> + compatible = "regulator-gpio";
> + status = "disabled";
Pointless node.
Kelly: I've removed it and loaded into our X4TF platform and it boot into BMC console. I have resent my patch.
> + regulator-name = "SDHCI1 VccQ";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3300000>;
> + gpios = <&gpio0 ASPEED_GPIO(V, 3) GPIO_ACTIVE_HIGH>;
> + gpios-states = <1>;
> + states = <3300000 1>,
> + <1800000 0>;
> + };
Missing blank line.
Kelly: I've review our dts and add blank line or remove redundant blank lines.
> + iio-hwmon {
> + compatible = "iio-hwmon";
> + io-channels = <&adc0 0>, <&adc0 1>, <&adc0 2>, <&adc0 3>,
> + <&adc0 4>, <&adc0 5>, <&adc0 6>, <&adc0 7>,
> + <&adc1 0>, <&adc1 1>, <&adc1 2>, <&adc1 3>,
> + <&adc1 4>, <&adc1 5>, <&adc1 6>, <&adc1 7>;
> + };
> +> + video-engine@1e700000 {
Wrong placement. Also tools would tell you that.
It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Kelly: I've checked our dts, removed unnecessary parts and run the DTS check script.
> + compatible = "aspeed,ast2600-video-engine";
> + reg = <0x1e700000 0x20000>;
> + clocks = <&syscon ASPEED_CLK_GATE_VCLK>, <&syscon ASPEED_CLK_GATE_ECLK>;
> + clock-names = "vclk", "eclk";
> + interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
> + memory-region = <&video_engine_memory>;
> + //resets = <&syscon ASPEED_RESET_VIDEO>;
Dead code.
Kelly: I have removed this part and resent the patch.
> + };
> +
> + leds {
> + compatible = "gpio-leds";
> +
> + heartbeat {
It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Kelly: I added led- for all LED configurations. Heartbeat will be led-heartbeat.
> + gpios = <&gpio0 ASPEED_GPIO(P, 7) GPIO_ACTIVE_LOW>;
> + linux,default-trigger = "heartbeat";
> + };
> + uid_led {
It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Kelly: I added led- for all LED configurations.
> + gpios = <&gpio0 ASPEED_GPIO(P, 1) (GPIO_ACTIVE_LOW | GPIO_OPEN_DRAIN)>;
> + default-state = "off";
> + };
Missing blank line, everywhere.
Kelly: I've review our dts and add blank line or remove redundant blank lines.
> + status_Y {
> + gpios = <&gpio1 ASPEED_GPIO(B, 1) GPIO_ACTIVE_LOW>;
> + default-state = "off";
> + };
> + sys_boot_status {
> + gpios = <&gpio1 ASPEED_GPIO(B, 0) GPIO_ACTIVE_LOW>;
> + default-state = "off";
> + };
> + };
> + spigpio {
It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
> + status = "okay";
Why?
Kelly: I've removed spigpio and tested on our X4TF platform and it boots to the BMC console. I've resent our new patch.
> + compatible = "spi-gpio";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + sck-gpios = <&gpio0 ASPEED_GPIO(Z, 3) GPIO_ACTIVE_HIGH>;
> + mosi-gpios = <&gpio0 ASPEED_GPIO(Z, 4) GPIO_ACTIVE_HIGH>;
> + miso-gpios = <&gpio0 ASPEED_GPIO(Z, 5) GPIO_ACTIVE_HIGH>;
> + num-chipselects = <1>;
> + cs-gpios = <&gpio0 ASPEED_GPIO(Z, 0) GPIO_ACTIVE_HIGH>;
> + };
> +
Redundant blank line.
Kelly: I've review our dts and add blank line or remove redundant blank lines.
> +};
> +
> +&adc0 {
> + vref = <2500>;
> + status = "okay";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_adc0_default &pinctrl_adc1_default
> + &pinctrl_adc2_default &pinctrl_adc3_default
> + &pinctrl_adc4_default &pinctrl_adc5_default
> + &pinctrl_adc6_default &pinctrl_adc7_default>; };
> +
> +&adc1 {
> + vref = <2500>;
> + status = "okay";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_adc8_default &pinctrl_adc9_default
> + &pinctrl_adc10_default &pinctrl_adc11_default
> + &pinctrl_adc12_default &pinctrl_adc13_default
> + &pinctrl_adc14_default &pinctrl_adc15_default>; };
> +
> +&peci0 {
> + status = "okay";
> +};
> +
> +&lpc_snoop {
> + snoop-ports = <0x80>;
> + status = "okay";
> +};
> +
> +
Redundant blank line. Clean this code before sending upstream from such trivialities.
Kelly: I've review our dts and add blank line or remove redundant blank lines.
> +&mdio0 {
> + status = "disabled";
> +};
> +
> +
> +&mdio1 {
> + status = "disabled";
> +};
> +
> +&mdio2 {
> + status = "okay";
> +
> + ethphy2: ethernet-phy@0 {
> + compatible = "ethernet-phy-ieee802.3-c22";
> + reg = <0>;
> + };
> +};
> +
> +&mdio3 {
> + status = "okay";
> +
> + ethphy3: ethernet-phy@0 {
> + compatible = "ethernet-phy-ieee802.3-c22";
> + reg = <0>;
> + };
> +};
> +
> +&mac0 {
> + status = "disabled";
> +};
> +
> +&mac1 {
> + status = "disabled";
> +};
> +
> +//for X4TF
> +&mac2 {
> + status = "okay";
> + phy-mode = "rmii";
> + #phy-handle = <ðphy2>;
> + use-ncsi;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_rmii3_default>; };
> +
> +
Ditto
Kelly: I've review our dts and add blank line or remove redundant blank lines.
> +&mac3 {
> + status = "okay";
> + phy-mode = "rmii";
> + #phy-handle = <ðphy3>;
> + use-ncsi;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_rmii4_default>; };
> +
> +
Ditto
Kelly: I've review our dts and add blank line or remove redundant blank lines.
> +&syscon {
> + uart-clock-high-speed;
That's a syscon property?
It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Kelly: I've removed syscon and tested on our X4TF platform and it boots to the BMC console. I've resent our new patch.
> + status = "okay";
> +};
> +
> +&rtc {
> + status = "disabled";
> +};
> +
> +&fmc {
> + status = "okay";
> + flash@0 {
> + status = "okay";
Drop. Everywhere where it is not needed.
Kelly: I've adjusted fmc config and resent the patch.
> + m25p,fast-read;
> + label = "bmc-spi";
> + spi-max-frequency = <50000000>;
> + spi-bus-width = <1>;
> + partitions {
> + compatible = "fixed-partitions";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + bmc@0 {
> + label = "bmc";
> + reg = <0x0 0x4000000>;
> + };
> + u-boot@0 {
> + label = "u-boot";
> + reg = <0x0 0x200000>;
> + };
> + u-boot-env@1f0000 {
> + label = "u-boot-env";
> + reg = <0x1f0000 0x10000>;
> + };
> + kernel@200000 {
> + label = "kernel";
> + reg = <0x200000 0xc00000>;
> + };
> + rofs@a00000 {
> + label = "rofs";
> + reg = <0xa00000 0x2a00000>;
> + };
> + rwfs@2a00000 {
> + label = "rwfs";
> + reg = <0x2a00000 0x43f0000>;
> + };
> + };
> + };
> +};
> +
> +&spi1 {
> + status = "okay";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_spi1_default>;
> +
> + flash@0 {
> + status = "okay";
> + w25q256,fast-read;
> + label = "bios-spi";
> + spi-max-frequency = <50000000>;
> + partitions {
> + compatible = "fixed-partitions";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + biosfullimg@0 {
> + reg = <0x0 0x2000000>; // 32768 *1024 = 0x2000000, 32 MB
> + label = "biosfullimg";
> + };
> + };
> + };
> +};
> +
> +&i2c0 {
> + status = "okay";
> +};
> +
> +&i2c1 {
> + status = "okay";
> +};
> +
> +&i2c2 {
> + status = "okay";
> +};
> +
> +&i2c3 {
> + status = "okay";
> +};
> +
> +&i2c4 {
> + status = "okay";
> + tmp75@48 {
Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "ti,tmp75";
> + reg = <0x48>;
> + };
> + tmp75@49 {
Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
I am going to skip the rest. Please fix all the trivialities and test your patches with tools.
Kelly: I have renamed tmp75 as temperature-sensor.
I've checked our dts, removed unnecessary parts and run the DTS check script.
Best regards,
Krzysztof
<p></p>
===================================================================================================================================
This email and any attachments to it contain confidential information and are intended solely for the use of the individual to whom it is addressed. If you are not the intended recipient or receive it accidentally, please immediately notify the sender by e-mail and delete the message and any attachments from your computer system, and destroy all hard copies. Please be advised that any unauthorized disclosure, copying, distribution or any action taken or omitted in reliance on this, is illegal and prohibited. Any views or opinions expressed are solely those of the author and do not represent those of ASUSTeK.
For pricing information, ASUS is only entitled to set a recommendation resale price. All customers are free to set their own price as they wish.
===================================================================================================================================
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
2024-03-04 10:45 ` Kelly Hung(洪嘉莉)
@ 2024-03-04 11:23 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 35+ messages in thread
From: Krzysztof Kozlowski @ 2024-03-04 11:23 UTC (permalink / raw)
To: Kelly Hung(洪嘉莉), Kelly Hung, robh+dt
Cc: krzysztof.kozlowski+dt, conor+dt, joel, andrew, devicetree,
linux-arm-kernel, linux-aspeed, linux-kernel,
AllenYY Hsu(許幼岳)
On 04/03/2024 11:45, Kelly Hung(洪嘉莉) wrote:
> Hi, Krzysztof,
>
> Thanks for review, I notice there were a lot of errors. I've corrected them and done a schema and patch check, then resend the patch on 2/22.
And what happened with my other messages? Why you were not replying to
them? Why only some parts were implemented?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
@ 2024-03-04 11:23 ` Krzysztof Kozlowski
0 siblings, 0 replies; 35+ messages in thread
From: Krzysztof Kozlowski @ 2024-03-04 11:23 UTC (permalink / raw)
To: Kelly Hung(洪嘉莉), Kelly Hung, robh+dt
Cc: krzysztof.kozlowski+dt, conor+dt, joel, andrew, devicetree,
linux-arm-kernel, linux-aspeed, linux-kernel,
AllenYY Hsu(許幼岳)
On 04/03/2024 11:45, Kelly Hung(洪嘉莉) wrote:
> Hi, Krzysztof,
>
> Thanks for review, I notice there were a lot of errors. I've corrected them and done a schema and patch check, then resend the patch on 2/22.
And what happened with my other messages? Why you were not replying to
them? Why only some parts were implemented?
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 35+ messages in thread
* RE: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
2024-01-30 10:39 ` Krzysztof Kozlowski
@ 2024-03-04 10:45 ` Kelly Hung(洪嘉莉)
-1 siblings, 0 replies; 35+ messages in thread
From: Kelly Hung(洪嘉莉) @ 2024-03-04 10:45 UTC (permalink / raw)
To: Krzysztof Kozlowski, Kelly Hung, robh+dt
Cc: krzysztof.kozlowski+dt, conor+dt, joel, andrew, devicetree,
linux-arm-kernel, linux-aspeed, linux-kernel,
AllenYY Hsu(許幼岳)
Hi, Krzysztof,
Thanks for review, I notice there were a lot of errors. I've corrected them and done a schema and patch check, then resend the patch on 2/22.
Best Regards
Kelly
-----Original Message-----
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Sent: Tuesday, January 30, 2024 6:39 PM
To: Kelly Hung <ppighouse@gmail.com>; robh+dt@kernel.org
Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; joel@jms.id.au; andrew@codeconstruct.com.au; devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org; Kelly Hung(洪嘉莉) <Kelly_Hung@asus.com>
Subject: Re: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
External email : Ensure your email is secure before opening links and attachments.
On 30/01/2024 09:56, Kelly Hung wrote:
> From: kelly1732000 <Kelly_Hung@asus.com>
>
> This initial device-tree provides the necessary configuration for
> basic BMC functionality and work on ASUS X4TF production.
>
> Signed-off-by: kelly1732000 <Kelly_Hung@asus.com>
> ---
> .../boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts | 828
> ++++++++++++++++++
> 1 file changed, 828 insertions(+)
> create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts
It's impossible to test this file. You miss Makefile.
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts
> b/arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts
> new file mode 100644
> index 000000000000..723bbb33137f
> --- /dev/null
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts
> @@ -0,0 +1,828 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later // Copyright 2023 ASUS
> +Corp.
> +/dts-v1/;
> +
> +#include "aspeed-g6.dtsi"
> +#include <dt-bindings/gpio/aspeed-gpio.h> #include
> +<dt-bindings/i2c/i2c.h>
> +
> +
> +/ {
> + model = "ASUS-X4TF";
> + compatible = "asus,x4tf", "aspeed,ast2600";
> +
> + chosen {
> + stdout-path = &uart5;
> + bootargs = "console=ttyS4,115200n8 earlycon";
earlycon is a debugging feature, not mainline. Also, move console to stdout-path, so entire bootargs can be dropped.
> + };
> +
> + memory@80000000 {
> + device_type = "memory";
> + reg = <0x80000000 0x40000000>;
> + };
> +
> + reserved-memory {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + gfx_memory: framebuffer {
> + size = <0x01000000>;
> + alignment = <0x01000000>;
> + compatible = "shared-dma-pool";
> + reusable;
> + };
> +
> + video_engine_memory: video {
> + size = <0x04000000>;
> + alignment = <0x01000000>;
> + compatible = "shared-dma-pool";
> + reusable;
> + };
> +
> + rvas_memory: rvas {
> + size = <0x04000000>;
> + alignment = <0x01000000>;
> + compatible = "shared-dma-pool";
> + reusable;
> + };
> +
> + bmc_dev_memory: bmc_dev_memory {
No underscores in node names. This applies everywhere.
> + size = <0x00100000>;
> + alignment = <0x00100000>;
> + compatible = "shared-dma-pool";
> + no-map;
> + };
> +
> + pci_msi_memory: pci_msi_memory {
> + no-map;
> + reg = <0x9e770000 0x100>;
> + compatible = "shared-dma-pool";
> + };
> + /* 1GB memory */
> + vga_memory: region@bf000000 {
> + no-map;
> + compatible = "shared-dma-pool";
> + reg = <0xbf000000 0x01000000>; /* 16M */
> + };
> + ssp_memory: ssp_memory {
> + size = <0x02000000>;
> + alignment = <0x01000000>;
> + compatible = "shared-dma-pool";
> + no-map;
> + };
> + };
> +
> + vcc_sdhci0: regulator-vcc-sdhci0 {
> + compatible = "regulator-fixed";
> + status = "disabled";
Why? It makes it entirely pointless.
> + regulator-name = "SDHCI0 Vcc";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + gpios = <&gpio0 ASPEED_GPIO(V, 0) GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + };
> +
> + vccq_sdhci0: regulator-vccq-sdhci0 {
> + compatible = "regulator-gpio";
> + status = "disabled";
Pointless node.
> + regulator-name = "SDHCI0 VccQ";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3300000>;
> + gpios = <&gpio0 ASPEED_GPIO(V, 1) GPIO_ACTIVE_HIGH>;
> + gpios-states = <1>;
> + states = <3300000 1>,
> + <1800000 0>;
> + };
> +
> + vcc_sdhci1: regulator-vcc-sdhci1 {
> + compatible = "regulator-fixed";
> + status = "disabled";
Pointless node.
> + regulator-name = "SDHCI1 Vcc";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + gpios = <&gpio0 ASPEED_GPIO(V, 2) GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + };
> +
> + vccq_sdhci1: regulator-vccq-sdhci1 {
> + compatible = "regulator-gpio";
> + status = "disabled";
Pointless node.
> + regulator-name = "SDHCI1 VccQ";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3300000>;
> + gpios = <&gpio0 ASPEED_GPIO(V, 3) GPIO_ACTIVE_HIGH>;
> + gpios-states = <1>;
> + states = <3300000 1>,
> + <1800000 0>;
> + };
Missing blank line.
> + iio-hwmon {
> + compatible = "iio-hwmon";
> + io-channels = <&adc0 0>, <&adc0 1>, <&adc0 2>, <&adc0 3>,
> + <&adc0 4>, <&adc0 5>, <&adc0 6>, <&adc0 7>,
> + <&adc1 0>, <&adc1 1>, <&adc1 2>, <&adc1 3>,
> + <&adc1 4>, <&adc1 5>, <&adc1 6>, <&adc1 7>;
> + };
> +> + video-engine@1e700000 {
Wrong placement. Also tools would tell you that.
It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
> + compatible = "aspeed,ast2600-video-engine";
> + reg = <0x1e700000 0x20000>;
> + clocks = <&syscon ASPEED_CLK_GATE_VCLK>, <&syscon ASPEED_CLK_GATE_ECLK>;
> + clock-names = "vclk", "eclk";
> + interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
> + memory-region = <&video_engine_memory>;
> + //resets = <&syscon ASPEED_RESET_VIDEO>;
Dead code.
> + };
> +
> + leds {
> + compatible = "gpio-leds";
> +
> + heartbeat {
It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
> + gpios = <&gpio0 ASPEED_GPIO(P, 7) GPIO_ACTIVE_LOW>;
> + linux,default-trigger = "heartbeat";
> + };
> + uid_led {
It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
> + gpios = <&gpio0 ASPEED_GPIO(P, 1) (GPIO_ACTIVE_LOW | GPIO_OPEN_DRAIN)>;
> + default-state = "off";
> + };
Missing blank line, everywhere.
> + status_Y {
> + gpios = <&gpio1 ASPEED_GPIO(B, 1) GPIO_ACTIVE_LOW>;
> + default-state = "off";
> + };
> + sys_boot_status {
> + gpios = <&gpio1 ASPEED_GPIO(B, 0) GPIO_ACTIVE_LOW>;
> + default-state = "off";
> + };
> + };
> + spigpio {
It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
> + status = "okay";
Why?
> + compatible = "spi-gpio";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + sck-gpios = <&gpio0 ASPEED_GPIO(Z, 3) GPIO_ACTIVE_HIGH>;
> + mosi-gpios = <&gpio0 ASPEED_GPIO(Z, 4) GPIO_ACTIVE_HIGH>;
> + miso-gpios = <&gpio0 ASPEED_GPIO(Z, 5) GPIO_ACTIVE_HIGH>;
> + num-chipselects = <1>;
> + cs-gpios = <&gpio0 ASPEED_GPIO(Z, 0) GPIO_ACTIVE_HIGH>;
> + };
> +
Redundant blank line.
> +};
> +
> +&adc0 {
> + vref = <2500>;
> + status = "okay";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_adc0_default &pinctrl_adc1_default
> + &pinctrl_adc2_default &pinctrl_adc3_default
> + &pinctrl_adc4_default &pinctrl_adc5_default
> + &pinctrl_adc6_default &pinctrl_adc7_default>; };
> +
> +&adc1 {
> + vref = <2500>;
> + status = "okay";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_adc8_default &pinctrl_adc9_default
> + &pinctrl_adc10_default &pinctrl_adc11_default
> + &pinctrl_adc12_default &pinctrl_adc13_default
> + &pinctrl_adc14_default &pinctrl_adc15_default>; };
> +
> +&peci0 {
> + status = "okay";
> +};
> +
> +&lpc_snoop {
> + snoop-ports = <0x80>;
> + status = "okay";
> +};
> +
> +
Redundant blank line. Clean this code before sending upstream from such trivialities.
> +&mdio0 {
> + status = "disabled";
> +};
> +
> +
> +&mdio1 {
> + status = "disabled";
> +};
> +
> +&mdio2 {
> + status = "okay";
> +
> + ethphy2: ethernet-phy@0 {
> + compatible = "ethernet-phy-ieee802.3-c22";
> + reg = <0>;
> + };
> +};
> +
> +&mdio3 {
> + status = "okay";
> +
> + ethphy3: ethernet-phy@0 {
> + compatible = "ethernet-phy-ieee802.3-c22";
> + reg = <0>;
> + };
> +};
> +
> +&mac0 {
> + status = "disabled";
> +};
> +
> +&mac1 {
> + status = "disabled";
> +};
> +
> +//for X4TF
> +&mac2 {
> + status = "okay";
> + phy-mode = "rmii";
> + #phy-handle = <ðphy2>;
> + use-ncsi;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_rmii3_default>; };
> +
> +
Ditto
> +&mac3 {
> + status = "okay";
> + phy-mode = "rmii";
> + #phy-handle = <ðphy3>;
> + use-ncsi;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_rmii4_default>; };
> +
> +
Ditto
> +&syscon {
> + uart-clock-high-speed;
That's a syscon property?
It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
> + status = "okay";
> +};
> +
> +&rtc {
> + status = "disabled";
> +};
> +
> +&fmc {
> + status = "okay";
> + flash@0 {
> + status = "okay";
Drop. Everywhere where it is not needed.
> + m25p,fast-read;
> + label = "bmc-spi";
> + spi-max-frequency = <50000000>;
> + spi-bus-width = <1>;
> + partitions {
> + compatible = "fixed-partitions";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + bmc@0 {
> + label = "bmc";
> + reg = <0x0 0x4000000>;
> + };
> + u-boot@0 {
> + label = "u-boot";
> + reg = <0x0 0x200000>;
> + };
> + u-boot-env@1f0000 {
> + label = "u-boot-env";
> + reg = <0x1f0000 0x10000>;
> + };
> + kernel@200000 {
> + label = "kernel";
> + reg = <0x200000 0xc00000>;
> + };
> + rofs@a00000 {
> + label = "rofs";
> + reg = <0xa00000 0x2a00000>;
> + };
> + rwfs@2a00000 {
> + label = "rwfs";
> + reg = <0x2a00000 0x43f0000>;
> + };
> + };
> + };
> +};
> +
> +&spi1 {
> + status = "okay";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_spi1_default>;
> +
> + flash@0 {
> + status = "okay";
> + w25q256,fast-read;
> + label = "bios-spi";
> + spi-max-frequency = <50000000>;
> + partitions {
> + compatible = "fixed-partitions";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + biosfullimg@0 {
> + reg = <0x0 0x2000000>; // 32768 *1024 = 0x2000000, 32 MB
> + label = "biosfullimg";
> + };
> + };
> + };
> +};
> +
> +&i2c0 {
> + status = "okay";
> +};
> +
> +&i2c1 {
> + status = "okay";
> +};
> +
> +&i2c2 {
> + status = "okay";
> +};
> +
> +&i2c3 {
> + status = "okay";
> +};
> +
> +&i2c4 {
> + status = "okay";
> + tmp75@48 {
Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "ti,tmp75";
> + reg = <0x48>;
> + };
> + tmp75@49 {
Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
I am going to skip the rest. Please fix all the trivialities and test your patches with tools.
Best regards,
Krzysztof
<p></p>
===================================================================================================================================
This email and any attachments to it contain confidential information and are intended solely for the use of the individual to whom it is addressed. If you are not the intended recipient or receive it accidentally, please immediately notify the sender by e-mail and delete the message and any attachments from your computer system, and destroy all hard copies. Please be advised that any unauthorized disclosure, copying, distribution or any action taken or omitted in reliance on this, is illegal and prohibited. Any views or opinions expressed are solely those of the author and do not represent those of ASUSTeK.
For pricing information, ASUS is only entitled to set a recommendation resale price. All customers are free to set their own price as they wish.
===================================================================================================================================
^ permalink raw reply [flat|nested] 35+ messages in thread
* RE: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
@ 2024-03-04 10:45 ` Kelly Hung(洪嘉莉)
0 siblings, 0 replies; 35+ messages in thread
From: Kelly Hung(洪嘉莉) @ 2024-03-04 10:45 UTC (permalink / raw)
To: Krzysztof Kozlowski, Kelly Hung, robh+dt
Cc: krzysztof.kozlowski+dt, conor+dt, joel, andrew, devicetree,
linux-arm-kernel, linux-aspeed, linux-kernel,
AllenYY Hsu(許幼岳)
Hi, Krzysztof,
Thanks for review, I notice there were a lot of errors. I've corrected them and done a schema and patch check, then resend the patch on 2/22.
Best Regards
Kelly
-----Original Message-----
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Sent: Tuesday, January 30, 2024 6:39 PM
To: Kelly Hung <ppighouse@gmail.com>; robh+dt@kernel.org
Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; joel@jms.id.au; andrew@codeconstruct.com.au; devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org; Kelly Hung(洪嘉莉) <Kelly_Hung@asus.com>
Subject: Re: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
External email : Ensure your email is secure before opening links and attachments.
On 30/01/2024 09:56, Kelly Hung wrote:
> From: kelly1732000 <Kelly_Hung@asus.com>
>
> This initial device-tree provides the necessary configuration for
> basic BMC functionality and work on ASUS X4TF production.
>
> Signed-off-by: kelly1732000 <Kelly_Hung@asus.com>
> ---
> .../boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts | 828
> ++++++++++++++++++
> 1 file changed, 828 insertions(+)
> create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts
It's impossible to test this file. You miss Makefile.
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts
> b/arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts
> new file mode 100644
> index 000000000000..723bbb33137f
> --- /dev/null
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts
> @@ -0,0 +1,828 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later // Copyright 2023 ASUS
> +Corp.
> +/dts-v1/;
> +
> +#include "aspeed-g6.dtsi"
> +#include <dt-bindings/gpio/aspeed-gpio.h> #include
> +<dt-bindings/i2c/i2c.h>
> +
> +
> +/ {
> + model = "ASUS-X4TF";
> + compatible = "asus,x4tf", "aspeed,ast2600";
> +
> + chosen {
> + stdout-path = &uart5;
> + bootargs = "console=ttyS4,115200n8 earlycon";
earlycon is a debugging feature, not mainline. Also, move console to stdout-path, so entire bootargs can be dropped.
> + };
> +
> + memory@80000000 {
> + device_type = "memory";
> + reg = <0x80000000 0x40000000>;
> + };
> +
> + reserved-memory {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + gfx_memory: framebuffer {
> + size = <0x01000000>;
> + alignment = <0x01000000>;
> + compatible = "shared-dma-pool";
> + reusable;
> + };
> +
> + video_engine_memory: video {
> + size = <0x04000000>;
> + alignment = <0x01000000>;
> + compatible = "shared-dma-pool";
> + reusable;
> + };
> +
> + rvas_memory: rvas {
> + size = <0x04000000>;
> + alignment = <0x01000000>;
> + compatible = "shared-dma-pool";
> + reusable;
> + };
> +
> + bmc_dev_memory: bmc_dev_memory {
No underscores in node names. This applies everywhere.
> + size = <0x00100000>;
> + alignment = <0x00100000>;
> + compatible = "shared-dma-pool";
> + no-map;
> + };
> +
> + pci_msi_memory: pci_msi_memory {
> + no-map;
> + reg = <0x9e770000 0x100>;
> + compatible = "shared-dma-pool";
> + };
> + /* 1GB memory */
> + vga_memory: region@bf000000 {
> + no-map;
> + compatible = "shared-dma-pool";
> + reg = <0xbf000000 0x01000000>; /* 16M */
> + };
> + ssp_memory: ssp_memory {
> + size = <0x02000000>;
> + alignment = <0x01000000>;
> + compatible = "shared-dma-pool";
> + no-map;
> + };
> + };
> +
> + vcc_sdhci0: regulator-vcc-sdhci0 {
> + compatible = "regulator-fixed";
> + status = "disabled";
Why? It makes it entirely pointless.
> + regulator-name = "SDHCI0 Vcc";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + gpios = <&gpio0 ASPEED_GPIO(V, 0) GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + };
> +
> + vccq_sdhci0: regulator-vccq-sdhci0 {
> + compatible = "regulator-gpio";
> + status = "disabled";
Pointless node.
> + regulator-name = "SDHCI0 VccQ";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3300000>;
> + gpios = <&gpio0 ASPEED_GPIO(V, 1) GPIO_ACTIVE_HIGH>;
> + gpios-states = <1>;
> + states = <3300000 1>,
> + <1800000 0>;
> + };
> +
> + vcc_sdhci1: regulator-vcc-sdhci1 {
> + compatible = "regulator-fixed";
> + status = "disabled";
Pointless node.
> + regulator-name = "SDHCI1 Vcc";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + gpios = <&gpio0 ASPEED_GPIO(V, 2) GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + };
> +
> + vccq_sdhci1: regulator-vccq-sdhci1 {
> + compatible = "regulator-gpio";
> + status = "disabled";
Pointless node.
> + regulator-name = "SDHCI1 VccQ";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3300000>;
> + gpios = <&gpio0 ASPEED_GPIO(V, 3) GPIO_ACTIVE_HIGH>;
> + gpios-states = <1>;
> + states = <3300000 1>,
> + <1800000 0>;
> + };
Missing blank line.
> + iio-hwmon {
> + compatible = "iio-hwmon";
> + io-channels = <&adc0 0>, <&adc0 1>, <&adc0 2>, <&adc0 3>,
> + <&adc0 4>, <&adc0 5>, <&adc0 6>, <&adc0 7>,
> + <&adc1 0>, <&adc1 1>, <&adc1 2>, <&adc1 3>,
> + <&adc1 4>, <&adc1 5>, <&adc1 6>, <&adc1 7>;
> + };
> +> + video-engine@1e700000 {
Wrong placement. Also tools would tell you that.
It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
> + compatible = "aspeed,ast2600-video-engine";
> + reg = <0x1e700000 0x20000>;
> + clocks = <&syscon ASPEED_CLK_GATE_VCLK>, <&syscon ASPEED_CLK_GATE_ECLK>;
> + clock-names = "vclk", "eclk";
> + interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
> + memory-region = <&video_engine_memory>;
> + //resets = <&syscon ASPEED_RESET_VIDEO>;
Dead code.
> + };
> +
> + leds {
> + compatible = "gpio-leds";
> +
> + heartbeat {
It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
> + gpios = <&gpio0 ASPEED_GPIO(P, 7) GPIO_ACTIVE_LOW>;
> + linux,default-trigger = "heartbeat";
> + };
> + uid_led {
It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
> + gpios = <&gpio0 ASPEED_GPIO(P, 1) (GPIO_ACTIVE_LOW | GPIO_OPEN_DRAIN)>;
> + default-state = "off";
> + };
Missing blank line, everywhere.
> + status_Y {
> + gpios = <&gpio1 ASPEED_GPIO(B, 1) GPIO_ACTIVE_LOW>;
> + default-state = "off";
> + };
> + sys_boot_status {
> + gpios = <&gpio1 ASPEED_GPIO(B, 0) GPIO_ACTIVE_LOW>;
> + default-state = "off";
> + };
> + };
> + spigpio {
It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
> + status = "okay";
Why?
> + compatible = "spi-gpio";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + sck-gpios = <&gpio0 ASPEED_GPIO(Z, 3) GPIO_ACTIVE_HIGH>;
> + mosi-gpios = <&gpio0 ASPEED_GPIO(Z, 4) GPIO_ACTIVE_HIGH>;
> + miso-gpios = <&gpio0 ASPEED_GPIO(Z, 5) GPIO_ACTIVE_HIGH>;
> + num-chipselects = <1>;
> + cs-gpios = <&gpio0 ASPEED_GPIO(Z, 0) GPIO_ACTIVE_HIGH>;
> + };
> +
Redundant blank line.
> +};
> +
> +&adc0 {
> + vref = <2500>;
> + status = "okay";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_adc0_default &pinctrl_adc1_default
> + &pinctrl_adc2_default &pinctrl_adc3_default
> + &pinctrl_adc4_default &pinctrl_adc5_default
> + &pinctrl_adc6_default &pinctrl_adc7_default>; };
> +
> +&adc1 {
> + vref = <2500>;
> + status = "okay";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_adc8_default &pinctrl_adc9_default
> + &pinctrl_adc10_default &pinctrl_adc11_default
> + &pinctrl_adc12_default &pinctrl_adc13_default
> + &pinctrl_adc14_default &pinctrl_adc15_default>; };
> +
> +&peci0 {
> + status = "okay";
> +};
> +
> +&lpc_snoop {
> + snoop-ports = <0x80>;
> + status = "okay";
> +};
> +
> +
Redundant blank line. Clean this code before sending upstream from such trivialities.
> +&mdio0 {
> + status = "disabled";
> +};
> +
> +
> +&mdio1 {
> + status = "disabled";
> +};
> +
> +&mdio2 {
> + status = "okay";
> +
> + ethphy2: ethernet-phy@0 {
> + compatible = "ethernet-phy-ieee802.3-c22";
> + reg = <0>;
> + };
> +};
> +
> +&mdio3 {
> + status = "okay";
> +
> + ethphy3: ethernet-phy@0 {
> + compatible = "ethernet-phy-ieee802.3-c22";
> + reg = <0>;
> + };
> +};
> +
> +&mac0 {
> + status = "disabled";
> +};
> +
> +&mac1 {
> + status = "disabled";
> +};
> +
> +//for X4TF
> +&mac2 {
> + status = "okay";
> + phy-mode = "rmii";
> + #phy-handle = <ðphy2>;
> + use-ncsi;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_rmii3_default>; };
> +
> +
Ditto
> +&mac3 {
> + status = "okay";
> + phy-mode = "rmii";
> + #phy-handle = <ðphy3>;
> + use-ncsi;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_rmii4_default>; };
> +
> +
Ditto
> +&syscon {
> + uart-clock-high-speed;
That's a syscon property?
It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
> + status = "okay";
> +};
> +
> +&rtc {
> + status = "disabled";
> +};
> +
> +&fmc {
> + status = "okay";
> + flash@0 {
> + status = "okay";
Drop. Everywhere where it is not needed.
> + m25p,fast-read;
> + label = "bmc-spi";
> + spi-max-frequency = <50000000>;
> + spi-bus-width = <1>;
> + partitions {
> + compatible = "fixed-partitions";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + bmc@0 {
> + label = "bmc";
> + reg = <0x0 0x4000000>;
> + };
> + u-boot@0 {
> + label = "u-boot";
> + reg = <0x0 0x200000>;
> + };
> + u-boot-env@1f0000 {
> + label = "u-boot-env";
> + reg = <0x1f0000 0x10000>;
> + };
> + kernel@200000 {
> + label = "kernel";
> + reg = <0x200000 0xc00000>;
> + };
> + rofs@a00000 {
> + label = "rofs";
> + reg = <0xa00000 0x2a00000>;
> + };
> + rwfs@2a00000 {
> + label = "rwfs";
> + reg = <0x2a00000 0x43f0000>;
> + };
> + };
> + };
> +};
> +
> +&spi1 {
> + status = "okay";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_spi1_default>;
> +
> + flash@0 {
> + status = "okay";
> + w25q256,fast-read;
> + label = "bios-spi";
> + spi-max-frequency = <50000000>;
> + partitions {
> + compatible = "fixed-partitions";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + biosfullimg@0 {
> + reg = <0x0 0x2000000>; // 32768 *1024 = 0x2000000, 32 MB
> + label = "biosfullimg";
> + };
> + };
> + };
> +};
> +
> +&i2c0 {
> + status = "okay";
> +};
> +
> +&i2c1 {
> + status = "okay";
> +};
> +
> +&i2c2 {
> + status = "okay";
> +};
> +
> +&i2c3 {
> + status = "okay";
> +};
> +
> +&i2c4 {
> + status = "okay";
> + tmp75@48 {
Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "ti,tmp75";
> + reg = <0x48>;
> + };
> + tmp75@49 {
Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
I am going to skip the rest. Please fix all the trivialities and test your patches with tools.
Best regards,
Krzysztof
<p></p>
===================================================================================================================================
This email and any attachments to it contain confidential information and are intended solely for the use of the individual to whom it is addressed. If you are not the intended recipient or receive it accidentally, please immediately notify the sender by e-mail and delete the message and any attachments from your computer system, and destroy all hard copies. Please be advised that any unauthorized disclosure, copying, distribution or any action taken or omitted in reliance on this, is illegal and prohibited. Any views or opinions expressed are solely those of the author and do not represent those of ASUSTeK.
For pricing information, ASUS is only entitled to set a recommendation resale price. All customers are free to set their own price as they wish.
===================================================================================================================================
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
2024-01-30 8:56 ` Kelly Hung
@ 2024-01-30 10:39 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 35+ messages in thread
From: Krzysztof Kozlowski @ 2024-01-30 10:39 UTC (permalink / raw)
To: Kelly Hung, robh+dt
Cc: krzysztof.kozlowski+dt, conor+dt, joel, andrew, devicetree,
linux-arm-kernel, linux-aspeed, linux-kernel, kelly_hung
On 30/01/2024 09:56, Kelly Hung wrote:
> From: kelly1732000 <Kelly_Hung@asus.com>
>
> This initial device-tree provides the necessary configuration for
> basic BMC functionality and work on ASUS X4TF production.
>
> Signed-off-by: kelly1732000 <Kelly_Hung@asus.com>
Please use full name.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
@ 2024-01-30 10:39 ` Krzysztof Kozlowski
0 siblings, 0 replies; 35+ messages in thread
From: Krzysztof Kozlowski @ 2024-01-30 10:39 UTC (permalink / raw)
To: Kelly Hung, robh+dt
Cc: krzysztof.kozlowski+dt, conor+dt, joel, andrew, devicetree,
linux-arm-kernel, linux-aspeed, linux-kernel, kelly_hung
On 30/01/2024 09:56, Kelly Hung wrote:
> From: kelly1732000 <Kelly_Hung@asus.com>
>
> This initial device-tree provides the necessary configuration for
> basic BMC functionality and work on ASUS X4TF production.
>
> Signed-off-by: kelly1732000 <Kelly_Hung@asus.com>
Please use full name.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
2024-01-30 8:56 ` Kelly Hung
@ 2024-01-30 10:39 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 35+ messages in thread
From: Krzysztof Kozlowski @ 2024-01-30 10:39 UTC (permalink / raw)
To: Kelly Hung, robh+dt
Cc: krzysztof.kozlowski+dt, conor+dt, joel, andrew, devicetree,
linux-arm-kernel, linux-aspeed, linux-kernel, kelly_hung
On 30/01/2024 09:56, Kelly Hung wrote:
> From: kelly1732000 <Kelly_Hung@asus.com>
>
> This initial device-tree provides the necessary configuration for
> basic BMC functionality and work on ASUS X4TF production.
>
> Signed-off-by: kelly1732000 <Kelly_Hung@asus.com>
> ---
> .../boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts | 828 ++++++++++++++++++
> 1 file changed, 828 insertions(+)
> create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts
It's impossible to test this file. You miss Makefile.
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts
> new file mode 100644
> index 000000000000..723bbb33137f
> --- /dev/null
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts
> @@ -0,0 +1,828 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +// Copyright 2023 ASUS Corp.
> +/dts-v1/;
> +
> +#include "aspeed-g6.dtsi"
> +#include <dt-bindings/gpio/aspeed-gpio.h>
> +#include <dt-bindings/i2c/i2c.h>
> +
> +
> +/ {
> + model = "ASUS-X4TF";
> + compatible = "asus,x4tf", "aspeed,ast2600";
> +
> + chosen {
> + stdout-path = &uart5;
> + bootargs = "console=ttyS4,115200n8 earlycon";
earlycon is a debugging feature, not mainline. Also, move console to
stdout-path, so entire bootargs can be dropped.
> + };
> +
> + memory@80000000 {
> + device_type = "memory";
> + reg = <0x80000000 0x40000000>;
> + };
> +
> + reserved-memory {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + gfx_memory: framebuffer {
> + size = <0x01000000>;
> + alignment = <0x01000000>;
> + compatible = "shared-dma-pool";
> + reusable;
> + };
> +
> + video_engine_memory: video {
> + size = <0x04000000>;
> + alignment = <0x01000000>;
> + compatible = "shared-dma-pool";
> + reusable;
> + };
> +
> + rvas_memory: rvas {
> + size = <0x04000000>;
> + alignment = <0x01000000>;
> + compatible = "shared-dma-pool";
> + reusable;
> + };
> +
> + bmc_dev_memory: bmc_dev_memory {
No underscores in node names. This applies everywhere.
> + size = <0x00100000>;
> + alignment = <0x00100000>;
> + compatible = "shared-dma-pool";
> + no-map;
> + };
> +
> + pci_msi_memory: pci_msi_memory {
> + no-map;
> + reg = <0x9e770000 0x100>;
> + compatible = "shared-dma-pool";
> + };
> + /* 1GB memory */
> + vga_memory: region@bf000000 {
> + no-map;
> + compatible = "shared-dma-pool";
> + reg = <0xbf000000 0x01000000>; /* 16M */
> + };
> + ssp_memory: ssp_memory {
> + size = <0x02000000>;
> + alignment = <0x01000000>;
> + compatible = "shared-dma-pool";
> + no-map;
> + };
> + };
> +
> + vcc_sdhci0: regulator-vcc-sdhci0 {
> + compatible = "regulator-fixed";
> + status = "disabled";
Why? It makes it entirely pointless.
> + regulator-name = "SDHCI0 Vcc";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + gpios = <&gpio0 ASPEED_GPIO(V, 0) GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + };
> +
> + vccq_sdhci0: regulator-vccq-sdhci0 {
> + compatible = "regulator-gpio";
> + status = "disabled";
Pointless node.
> + regulator-name = "SDHCI0 VccQ";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3300000>;
> + gpios = <&gpio0 ASPEED_GPIO(V, 1) GPIO_ACTIVE_HIGH>;
> + gpios-states = <1>;
> + states = <3300000 1>,
> + <1800000 0>;
> + };
> +
> + vcc_sdhci1: regulator-vcc-sdhci1 {
> + compatible = "regulator-fixed";
> + status = "disabled";
Pointless node.
> + regulator-name = "SDHCI1 Vcc";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + gpios = <&gpio0 ASPEED_GPIO(V, 2) GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + };
> +
> + vccq_sdhci1: regulator-vccq-sdhci1 {
> + compatible = "regulator-gpio";
> + status = "disabled";
Pointless node.
> + regulator-name = "SDHCI1 VccQ";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3300000>;
> + gpios = <&gpio0 ASPEED_GPIO(V, 3) GPIO_ACTIVE_HIGH>;
> + gpios-states = <1>;
> + states = <3300000 1>,
> + <1800000 0>;
> + };
Missing blank line.
> + iio-hwmon {
> + compatible = "iio-hwmon";
> + io-channels = <&adc0 0>, <&adc0 1>, <&adc0 2>, <&adc0 3>,
> + <&adc0 4>, <&adc0 5>, <&adc0 6>, <&adc0 7>,
> + <&adc1 0>, <&adc1 1>, <&adc1 2>, <&adc1 3>,
> + <&adc1 4>, <&adc1 5>, <&adc1 6>, <&adc1 7>;
> + };
> +> + video-engine@1e700000 {
Wrong placement. Also tools would tell you that.
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
> + compatible = "aspeed,ast2600-video-engine";
> + reg = <0x1e700000 0x20000>;
> + clocks = <&syscon ASPEED_CLK_GATE_VCLK>, <&syscon ASPEED_CLK_GATE_ECLK>;
> + clock-names = "vclk", "eclk";
> + interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
> + memory-region = <&video_engine_memory>;
> + //resets = <&syscon ASPEED_RESET_VIDEO>;
Dead code.
> + };
> +
> + leds {
> + compatible = "gpio-leds";
> +
> + heartbeat {
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
> + gpios = <&gpio0 ASPEED_GPIO(P, 7) GPIO_ACTIVE_LOW>;
> + linux,default-trigger = "heartbeat";
> + };
> + uid_led {
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
> + gpios = <&gpio0 ASPEED_GPIO(P, 1) (GPIO_ACTIVE_LOW | GPIO_OPEN_DRAIN)>;
> + default-state = "off";
> + };
Missing blank line, everywhere.
> + status_Y {
> + gpios = <&gpio1 ASPEED_GPIO(B, 1) GPIO_ACTIVE_LOW>;
> + default-state = "off";
> + };
> + sys_boot_status {
> + gpios = <&gpio1 ASPEED_GPIO(B, 0) GPIO_ACTIVE_LOW>;
> + default-state = "off";
> + };
> + };
> + spigpio {
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
> + status = "okay";
Why?
> + compatible = "spi-gpio";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + sck-gpios = <&gpio0 ASPEED_GPIO(Z, 3) GPIO_ACTIVE_HIGH>;
> + mosi-gpios = <&gpio0 ASPEED_GPIO(Z, 4) GPIO_ACTIVE_HIGH>;
> + miso-gpios = <&gpio0 ASPEED_GPIO(Z, 5) GPIO_ACTIVE_HIGH>;
> + num-chipselects = <1>;
> + cs-gpios = <&gpio0 ASPEED_GPIO(Z, 0) GPIO_ACTIVE_HIGH>;
> + };
> +
Redundant blank line.
> +};
> +
> +&adc0 {
> + vref = <2500>;
> + status = "okay";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_adc0_default &pinctrl_adc1_default
> + &pinctrl_adc2_default &pinctrl_adc3_default
> + &pinctrl_adc4_default &pinctrl_adc5_default
> + &pinctrl_adc6_default &pinctrl_adc7_default>;
> +};
> +
> +&adc1 {
> + vref = <2500>;
> + status = "okay";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_adc8_default &pinctrl_adc9_default
> + &pinctrl_adc10_default &pinctrl_adc11_default
> + &pinctrl_adc12_default &pinctrl_adc13_default
> + &pinctrl_adc14_default &pinctrl_adc15_default>;
> +};
> +
> +&peci0 {
> + status = "okay";
> +};
> +
> +&lpc_snoop {
> + snoop-ports = <0x80>;
> + status = "okay";
> +};
> +
> +
Redundant blank line. Clean this code before sending upstream from such
trivialities.
> +&mdio0 {
> + status = "disabled";
> +};
> +
> +
> +&mdio1 {
> + status = "disabled";
> +};
> +
> +&mdio2 {
> + status = "okay";
> +
> + ethphy2: ethernet-phy@0 {
> + compatible = "ethernet-phy-ieee802.3-c22";
> + reg = <0>;
> + };
> +};
> +
> +&mdio3 {
> + status = "okay";
> +
> + ethphy3: ethernet-phy@0 {
> + compatible = "ethernet-phy-ieee802.3-c22";
> + reg = <0>;
> + };
> +};
> +
> +&mac0 {
> + status = "disabled";
> +};
> +
> +&mac1 {
> + status = "disabled";
> +};
> +
> +//for X4TF
> +&mac2 {
> + status = "okay";
> + phy-mode = "rmii";
> + #phy-handle = <ðphy2>;
> + use-ncsi;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_rmii3_default>;
> +};
> +
> +
Ditto
> +&mac3 {
> + status = "okay";
> + phy-mode = "rmii";
> + #phy-handle = <ðphy3>;
> + use-ncsi;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_rmii4_default>;
> +};
> +
> +
Ditto
> +&syscon {
> + uart-clock-high-speed;
That's a syscon property?
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
> + status = "okay";
> +};
> +
> +&rtc {
> + status = "disabled";
> +};
> +
> +&fmc {
> + status = "okay";
> + flash@0 {
> + status = "okay";
Drop. Everywhere where it is not needed.
> + m25p,fast-read;
> + label = "bmc-spi";
> + spi-max-frequency = <50000000>;
> + spi-bus-width = <1>;
> + partitions {
> + compatible = "fixed-partitions";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + bmc@0 {
> + label = "bmc";
> + reg = <0x0 0x4000000>;
> + };
> + u-boot@0 {
> + label = "u-boot";
> + reg = <0x0 0x200000>;
> + };
> + u-boot-env@1f0000 {
> + label = "u-boot-env";
> + reg = <0x1f0000 0x10000>;
> + };
> + kernel@200000 {
> + label = "kernel";
> + reg = <0x200000 0xc00000>;
> + };
> + rofs@a00000 {
> + label = "rofs";
> + reg = <0xa00000 0x2a00000>;
> + };
> + rwfs@2a00000 {
> + label = "rwfs";
> + reg = <0x2a00000 0x43f0000>;
> + };
> + };
> + };
> +};
> +
> +&spi1 {
> + status = "okay";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_spi1_default>;
> +
> + flash@0 {
> + status = "okay";
> + w25q256,fast-read;
> + label = "bios-spi";
> + spi-max-frequency = <50000000>;
> + partitions {
> + compatible = "fixed-partitions";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + biosfullimg@0 {
> + reg = <0x0 0x2000000>; // 32768 *1024 = 0x2000000, 32 MB
> + label = "biosfullimg";
> + };
> + };
> + };
> +};
> +
> +&i2c0 {
> + status = "okay";
> +};
> +
> +&i2c1 {
> + status = "okay";
> +};
> +
> +&i2c2 {
> + status = "okay";
> +};
> +
> +&i2c3 {
> + status = "okay";
> +};
> +
> +&i2c4 {
> + status = "okay";
> + tmp75@48 {
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "ti,tmp75";
> + reg = <0x48>;
> + };
> + tmp75@49 {
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
I am going to skip the rest. Please fix all the trivialities and test
your patches with tools.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
@ 2024-01-30 10:39 ` Krzysztof Kozlowski
0 siblings, 0 replies; 35+ messages in thread
From: Krzysztof Kozlowski @ 2024-01-30 10:39 UTC (permalink / raw)
To: Kelly Hung, robh+dt
Cc: krzysztof.kozlowski+dt, conor+dt, joel, andrew, devicetree,
linux-arm-kernel, linux-aspeed, linux-kernel, kelly_hung
On 30/01/2024 09:56, Kelly Hung wrote:
> From: kelly1732000 <Kelly_Hung@asus.com>
>
> This initial device-tree provides the necessary configuration for
> basic BMC functionality and work on ASUS X4TF production.
>
> Signed-off-by: kelly1732000 <Kelly_Hung@asus.com>
> ---
> .../boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts | 828 ++++++++++++++++++
> 1 file changed, 828 insertions(+)
> create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts
It's impossible to test this file. You miss Makefile.
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts
> new file mode 100644
> index 000000000000..723bbb33137f
> --- /dev/null
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts
> @@ -0,0 +1,828 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +// Copyright 2023 ASUS Corp.
> +/dts-v1/;
> +
> +#include "aspeed-g6.dtsi"
> +#include <dt-bindings/gpio/aspeed-gpio.h>
> +#include <dt-bindings/i2c/i2c.h>
> +
> +
> +/ {
> + model = "ASUS-X4TF";
> + compatible = "asus,x4tf", "aspeed,ast2600";
> +
> + chosen {
> + stdout-path = &uart5;
> + bootargs = "console=ttyS4,115200n8 earlycon";
earlycon is a debugging feature, not mainline. Also, move console to
stdout-path, so entire bootargs can be dropped.
> + };
> +
> + memory@80000000 {
> + device_type = "memory";
> + reg = <0x80000000 0x40000000>;
> + };
> +
> + reserved-memory {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + gfx_memory: framebuffer {
> + size = <0x01000000>;
> + alignment = <0x01000000>;
> + compatible = "shared-dma-pool";
> + reusable;
> + };
> +
> + video_engine_memory: video {
> + size = <0x04000000>;
> + alignment = <0x01000000>;
> + compatible = "shared-dma-pool";
> + reusable;
> + };
> +
> + rvas_memory: rvas {
> + size = <0x04000000>;
> + alignment = <0x01000000>;
> + compatible = "shared-dma-pool";
> + reusable;
> + };
> +
> + bmc_dev_memory: bmc_dev_memory {
No underscores in node names. This applies everywhere.
> + size = <0x00100000>;
> + alignment = <0x00100000>;
> + compatible = "shared-dma-pool";
> + no-map;
> + };
> +
> + pci_msi_memory: pci_msi_memory {
> + no-map;
> + reg = <0x9e770000 0x100>;
> + compatible = "shared-dma-pool";
> + };
> + /* 1GB memory */
> + vga_memory: region@bf000000 {
> + no-map;
> + compatible = "shared-dma-pool";
> + reg = <0xbf000000 0x01000000>; /* 16M */
> + };
> + ssp_memory: ssp_memory {
> + size = <0x02000000>;
> + alignment = <0x01000000>;
> + compatible = "shared-dma-pool";
> + no-map;
> + };
> + };
> +
> + vcc_sdhci0: regulator-vcc-sdhci0 {
> + compatible = "regulator-fixed";
> + status = "disabled";
Why? It makes it entirely pointless.
> + regulator-name = "SDHCI0 Vcc";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + gpios = <&gpio0 ASPEED_GPIO(V, 0) GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + };
> +
> + vccq_sdhci0: regulator-vccq-sdhci0 {
> + compatible = "regulator-gpio";
> + status = "disabled";
Pointless node.
> + regulator-name = "SDHCI0 VccQ";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3300000>;
> + gpios = <&gpio0 ASPEED_GPIO(V, 1) GPIO_ACTIVE_HIGH>;
> + gpios-states = <1>;
> + states = <3300000 1>,
> + <1800000 0>;
> + };
> +
> + vcc_sdhci1: regulator-vcc-sdhci1 {
> + compatible = "regulator-fixed";
> + status = "disabled";
Pointless node.
> + regulator-name = "SDHCI1 Vcc";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + gpios = <&gpio0 ASPEED_GPIO(V, 2) GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + };
> +
> + vccq_sdhci1: regulator-vccq-sdhci1 {
> + compatible = "regulator-gpio";
> + status = "disabled";
Pointless node.
> + regulator-name = "SDHCI1 VccQ";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3300000>;
> + gpios = <&gpio0 ASPEED_GPIO(V, 3) GPIO_ACTIVE_HIGH>;
> + gpios-states = <1>;
> + states = <3300000 1>,
> + <1800000 0>;
> + };
Missing blank line.
> + iio-hwmon {
> + compatible = "iio-hwmon";
> + io-channels = <&adc0 0>, <&adc0 1>, <&adc0 2>, <&adc0 3>,
> + <&adc0 4>, <&adc0 5>, <&adc0 6>, <&adc0 7>,
> + <&adc1 0>, <&adc1 1>, <&adc1 2>, <&adc1 3>,
> + <&adc1 4>, <&adc1 5>, <&adc1 6>, <&adc1 7>;
> + };
> +> + video-engine@1e700000 {
Wrong placement. Also tools would tell you that.
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
> + compatible = "aspeed,ast2600-video-engine";
> + reg = <0x1e700000 0x20000>;
> + clocks = <&syscon ASPEED_CLK_GATE_VCLK>, <&syscon ASPEED_CLK_GATE_ECLK>;
> + clock-names = "vclk", "eclk";
> + interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
> + memory-region = <&video_engine_memory>;
> + //resets = <&syscon ASPEED_RESET_VIDEO>;
Dead code.
> + };
> +
> + leds {
> + compatible = "gpio-leds";
> +
> + heartbeat {
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
> + gpios = <&gpio0 ASPEED_GPIO(P, 7) GPIO_ACTIVE_LOW>;
> + linux,default-trigger = "heartbeat";
> + };
> + uid_led {
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
> + gpios = <&gpio0 ASPEED_GPIO(P, 1) (GPIO_ACTIVE_LOW | GPIO_OPEN_DRAIN)>;
> + default-state = "off";
> + };
Missing blank line, everywhere.
> + status_Y {
> + gpios = <&gpio1 ASPEED_GPIO(B, 1) GPIO_ACTIVE_LOW>;
> + default-state = "off";
> + };
> + sys_boot_status {
> + gpios = <&gpio1 ASPEED_GPIO(B, 0) GPIO_ACTIVE_LOW>;
> + default-state = "off";
> + };
> + };
> + spigpio {
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
> + status = "okay";
Why?
> + compatible = "spi-gpio";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + sck-gpios = <&gpio0 ASPEED_GPIO(Z, 3) GPIO_ACTIVE_HIGH>;
> + mosi-gpios = <&gpio0 ASPEED_GPIO(Z, 4) GPIO_ACTIVE_HIGH>;
> + miso-gpios = <&gpio0 ASPEED_GPIO(Z, 5) GPIO_ACTIVE_HIGH>;
> + num-chipselects = <1>;
> + cs-gpios = <&gpio0 ASPEED_GPIO(Z, 0) GPIO_ACTIVE_HIGH>;
> + };
> +
Redundant blank line.
> +};
> +
> +&adc0 {
> + vref = <2500>;
> + status = "okay";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_adc0_default &pinctrl_adc1_default
> + &pinctrl_adc2_default &pinctrl_adc3_default
> + &pinctrl_adc4_default &pinctrl_adc5_default
> + &pinctrl_adc6_default &pinctrl_adc7_default>;
> +};
> +
> +&adc1 {
> + vref = <2500>;
> + status = "okay";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_adc8_default &pinctrl_adc9_default
> + &pinctrl_adc10_default &pinctrl_adc11_default
> + &pinctrl_adc12_default &pinctrl_adc13_default
> + &pinctrl_adc14_default &pinctrl_adc15_default>;
> +};
> +
> +&peci0 {
> + status = "okay";
> +};
> +
> +&lpc_snoop {
> + snoop-ports = <0x80>;
> + status = "okay";
> +};
> +
> +
Redundant blank line. Clean this code before sending upstream from such
trivialities.
> +&mdio0 {
> + status = "disabled";
> +};
> +
> +
> +&mdio1 {
> + status = "disabled";
> +};
> +
> +&mdio2 {
> + status = "okay";
> +
> + ethphy2: ethernet-phy@0 {
> + compatible = "ethernet-phy-ieee802.3-c22";
> + reg = <0>;
> + };
> +};
> +
> +&mdio3 {
> + status = "okay";
> +
> + ethphy3: ethernet-phy@0 {
> + compatible = "ethernet-phy-ieee802.3-c22";
> + reg = <0>;
> + };
> +};
> +
> +&mac0 {
> + status = "disabled";
> +};
> +
> +&mac1 {
> + status = "disabled";
> +};
> +
> +//for X4TF
> +&mac2 {
> + status = "okay";
> + phy-mode = "rmii";
> + #phy-handle = <ðphy2>;
> + use-ncsi;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_rmii3_default>;
> +};
> +
> +
Ditto
> +&mac3 {
> + status = "okay";
> + phy-mode = "rmii";
> + #phy-handle = <ðphy3>;
> + use-ncsi;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_rmii4_default>;
> +};
> +
> +
Ditto
> +&syscon {
> + uart-clock-high-speed;
That's a syscon property?
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
> + status = "okay";
> +};
> +
> +&rtc {
> + status = "disabled";
> +};
> +
> +&fmc {
> + status = "okay";
> + flash@0 {
> + status = "okay";
Drop. Everywhere where it is not needed.
> + m25p,fast-read;
> + label = "bmc-spi";
> + spi-max-frequency = <50000000>;
> + spi-bus-width = <1>;
> + partitions {
> + compatible = "fixed-partitions";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + bmc@0 {
> + label = "bmc";
> + reg = <0x0 0x4000000>;
> + };
> + u-boot@0 {
> + label = "u-boot";
> + reg = <0x0 0x200000>;
> + };
> + u-boot-env@1f0000 {
> + label = "u-boot-env";
> + reg = <0x1f0000 0x10000>;
> + };
> + kernel@200000 {
> + label = "kernel";
> + reg = <0x200000 0xc00000>;
> + };
> + rofs@a00000 {
> + label = "rofs";
> + reg = <0xa00000 0x2a00000>;
> + };
> + rwfs@2a00000 {
> + label = "rwfs";
> + reg = <0x2a00000 0x43f0000>;
> + };
> + };
> + };
> +};
> +
> +&spi1 {
> + status = "okay";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_spi1_default>;
> +
> + flash@0 {
> + status = "okay";
> + w25q256,fast-read;
> + label = "bios-spi";
> + spi-max-frequency = <50000000>;
> + partitions {
> + compatible = "fixed-partitions";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + biosfullimg@0 {
> + reg = <0x0 0x2000000>; // 32768 *1024 = 0x2000000, 32 MB
> + label = "biosfullimg";
> + };
> + };
> + };
> +};
> +
> +&i2c0 {
> + status = "okay";
> +};
> +
> +&i2c1 {
> + status = "okay";
> +};
> +
> +&i2c2 {
> + status = "okay";
> +};
> +
> +&i2c3 {
> + status = "okay";
> +};
> +
> +&i2c4 {
> + status = "okay";
> + tmp75@48 {
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "ti,tmp75";
> + reg = <0x48>;
> + };
> + tmp75@49 {
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
I am going to skip the rest. Please fix all the trivialities and test
your patches with tools.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
2024-01-30 8:56 ` Kelly Hung
@ 2024-01-30 10:35 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 35+ messages in thread
From: Krzysztof Kozlowski @ 2024-01-30 10:35 UTC (permalink / raw)
To: Kelly Hung, robh+dt
Cc: krzysztof.kozlowski+dt, conor+dt, joel, andrew, devicetree,
linux-arm-kernel, linux-aspeed, linux-kernel, kelly_hung
On 30/01/2024 09:56, Kelly Hung wrote:
> This initial device-tree provides the necessary configuration for
> basic BMC functionality and work on ASUS X4TF production.
>
> Signed-off-by: Kelly Hung <Kelly_Hung@asus.com>
Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
@ 2024-01-30 10:35 ` Krzysztof Kozlowski
0 siblings, 0 replies; 35+ messages in thread
From: Krzysztof Kozlowski @ 2024-01-30 10:35 UTC (permalink / raw)
To: Kelly Hung, robh+dt
Cc: krzysztof.kozlowski+dt, conor+dt, joel, andrew, devicetree,
linux-arm-kernel, linux-aspeed, linux-kernel, kelly_hung
On 30/01/2024 09:56, Kelly Hung wrote:
> This initial device-tree provides the necessary configuration for
> basic BMC functionality and work on ASUS X4TF production.
>
> Signed-off-by: Kelly Hung <Kelly_Hung@asus.com>
Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 35+ messages in thread
* [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
2024-01-30 8:56 ` Kelly Hung
@ 2024-01-30 8:56 ` Kelly Hung
-1 siblings, 0 replies; 35+ messages in thread
From: Kelly Hung @ 2024-01-30 8:56 UTC (permalink / raw)
To: robh+dt
Cc: krzysztof.kozlowski+dt, conor+dt, joel, andrew, devicetree,
linux-arm-kernel, linux-aspeed, linux-kernel, kelly_hung,
kelly1732000
From: kelly1732000 <Kelly_Hung@asus.com>
This initial device-tree provides the necessary configuration for
basic BMC functionality and work on ASUS X4TF production.
Signed-off-by: kelly1732000 <Kelly_Hung@asus.com>
---
.../boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts | 828 ++++++++++++++++++
1 file changed, 828 insertions(+)
create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts
new file mode 100644
index 000000000000..723bbb33137f
--- /dev/null
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts
@@ -0,0 +1,828 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+// Copyright 2023 ASUS Corp.
+/dts-v1/;
+
+#include "aspeed-g6.dtsi"
+#include <dt-bindings/gpio/aspeed-gpio.h>
+#include <dt-bindings/i2c/i2c.h>
+
+
+/ {
+ model = "ASUS-X4TF";
+ compatible = "asus,x4tf", "aspeed,ast2600";
+
+ chosen {
+ stdout-path = &uart5;
+ bootargs = "console=ttyS4,115200n8 earlycon";
+ };
+
+ memory@80000000 {
+ device_type = "memory";
+ reg = <0x80000000 0x40000000>;
+ };
+
+ reserved-memory {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges;
+
+ gfx_memory: framebuffer {
+ size = <0x01000000>;
+ alignment = <0x01000000>;
+ compatible = "shared-dma-pool";
+ reusable;
+ };
+
+ video_engine_memory: video {
+ size = <0x04000000>;
+ alignment = <0x01000000>;
+ compatible = "shared-dma-pool";
+ reusable;
+ };
+
+ rvas_memory: rvas {
+ size = <0x04000000>;
+ alignment = <0x01000000>;
+ compatible = "shared-dma-pool";
+ reusable;
+ };
+
+ bmc_dev_memory: bmc_dev_memory {
+ size = <0x00100000>;
+ alignment = <0x00100000>;
+ compatible = "shared-dma-pool";
+ no-map;
+ };
+
+ pci_msi_memory: pci_msi_memory {
+ no-map;
+ reg = <0x9e770000 0x100>;
+ compatible = "shared-dma-pool";
+ };
+ /* 1GB memory */
+ vga_memory: region@bf000000 {
+ no-map;
+ compatible = "shared-dma-pool";
+ reg = <0xbf000000 0x01000000>; /* 16M */
+ };
+ ssp_memory: ssp_memory {
+ size = <0x02000000>;
+ alignment = <0x01000000>;
+ compatible = "shared-dma-pool";
+ no-map;
+ };
+ };
+
+ vcc_sdhci0: regulator-vcc-sdhci0 {
+ compatible = "regulator-fixed";
+ status = "disabled";
+ regulator-name = "SDHCI0 Vcc";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ gpios = <&gpio0 ASPEED_GPIO(V, 0) GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ };
+
+ vccq_sdhci0: regulator-vccq-sdhci0 {
+ compatible = "regulator-gpio";
+ status = "disabled";
+ regulator-name = "SDHCI0 VccQ";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ gpios = <&gpio0 ASPEED_GPIO(V, 1) GPIO_ACTIVE_HIGH>;
+ gpios-states = <1>;
+ states = <3300000 1>,
+ <1800000 0>;
+ };
+
+ vcc_sdhci1: regulator-vcc-sdhci1 {
+ compatible = "regulator-fixed";
+ status = "disabled";
+ regulator-name = "SDHCI1 Vcc";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ gpios = <&gpio0 ASPEED_GPIO(V, 2) GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ };
+
+ vccq_sdhci1: regulator-vccq-sdhci1 {
+ compatible = "regulator-gpio";
+ status = "disabled";
+ regulator-name = "SDHCI1 VccQ";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ gpios = <&gpio0 ASPEED_GPIO(V, 3) GPIO_ACTIVE_HIGH>;
+ gpios-states = <1>;
+ states = <3300000 1>,
+ <1800000 0>;
+ };
+ iio-hwmon {
+ compatible = "iio-hwmon";
+ io-channels = <&adc0 0>, <&adc0 1>, <&adc0 2>, <&adc0 3>,
+ <&adc0 4>, <&adc0 5>, <&adc0 6>, <&adc0 7>,
+ <&adc1 0>, <&adc1 1>, <&adc1 2>, <&adc1 3>,
+ <&adc1 4>, <&adc1 5>, <&adc1 6>, <&adc1 7>;
+ };
+
+ video-engine@1e700000 {
+ compatible = "aspeed,ast2600-video-engine";
+ reg = <0x1e700000 0x20000>;
+ clocks = <&syscon ASPEED_CLK_GATE_VCLK>, <&syscon ASPEED_CLK_GATE_ECLK>;
+ clock-names = "vclk", "eclk";
+ interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
+ memory-region = <&video_engine_memory>;
+ //resets = <&syscon ASPEED_RESET_VIDEO>;
+ };
+
+ leds {
+ compatible = "gpio-leds";
+
+ heartbeat {
+ gpios = <&gpio0 ASPEED_GPIO(P, 7) GPIO_ACTIVE_LOW>;
+ linux,default-trigger = "heartbeat";
+ };
+ uid_led {
+ gpios = <&gpio0 ASPEED_GPIO(P, 1) (GPIO_ACTIVE_LOW | GPIO_OPEN_DRAIN)>;
+ default-state = "off";
+ };
+ status_Y {
+ gpios = <&gpio1 ASPEED_GPIO(B, 1) GPIO_ACTIVE_LOW>;
+ default-state = "off";
+ };
+ sys_boot_status {
+ gpios = <&gpio1 ASPEED_GPIO(B, 0) GPIO_ACTIVE_LOW>;
+ default-state = "off";
+ };
+ };
+ spigpio {
+ status = "okay";
+ compatible = "spi-gpio";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ sck-gpios = <&gpio0 ASPEED_GPIO(Z, 3) GPIO_ACTIVE_HIGH>;
+ mosi-gpios = <&gpio0 ASPEED_GPIO(Z, 4) GPIO_ACTIVE_HIGH>;
+ miso-gpios = <&gpio0 ASPEED_GPIO(Z, 5) GPIO_ACTIVE_HIGH>;
+ num-chipselects = <1>;
+ cs-gpios = <&gpio0 ASPEED_GPIO(Z, 0) GPIO_ACTIVE_HIGH>;
+ };
+
+};
+
+&adc0 {
+ vref = <2500>;
+ status = "okay";
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_adc0_default &pinctrl_adc1_default
+ &pinctrl_adc2_default &pinctrl_adc3_default
+ &pinctrl_adc4_default &pinctrl_adc5_default
+ &pinctrl_adc6_default &pinctrl_adc7_default>;
+};
+
+&adc1 {
+ vref = <2500>;
+ status = "okay";
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_adc8_default &pinctrl_adc9_default
+ &pinctrl_adc10_default &pinctrl_adc11_default
+ &pinctrl_adc12_default &pinctrl_adc13_default
+ &pinctrl_adc14_default &pinctrl_adc15_default>;
+};
+
+&peci0 {
+ status = "okay";
+};
+
+&lpc_snoop {
+ snoop-ports = <0x80>;
+ status = "okay";
+};
+
+
+&mdio0 {
+ status = "disabled";
+};
+
+
+&mdio1 {
+ status = "disabled";
+};
+
+&mdio2 {
+ status = "okay";
+
+ ethphy2: ethernet-phy@0 {
+ compatible = "ethernet-phy-ieee802.3-c22";
+ reg = <0>;
+ };
+};
+
+&mdio3 {
+ status = "okay";
+
+ ethphy3: ethernet-phy@0 {
+ compatible = "ethernet-phy-ieee802.3-c22";
+ reg = <0>;
+ };
+};
+
+&mac0 {
+ status = "disabled";
+};
+
+&mac1 {
+ status = "disabled";
+};
+
+//for X4TF
+&mac2 {
+ status = "okay";
+ phy-mode = "rmii";
+ #phy-handle = <ðphy2>;
+ use-ncsi;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_rmii3_default>;
+};
+
+
+&mac3 {
+ status = "okay";
+ phy-mode = "rmii";
+ #phy-handle = <ðphy3>;
+ use-ncsi;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_rmii4_default>;
+};
+
+
+&syscon {
+ uart-clock-high-speed;
+ status = "okay";
+};
+
+&rtc {
+ status = "disabled";
+};
+
+&fmc {
+ status = "okay";
+ flash@0 {
+ status = "okay";
+ m25p,fast-read;
+ label = "bmc-spi";
+ spi-max-frequency = <50000000>;
+ spi-bus-width = <1>;
+ partitions {
+ compatible = "fixed-partitions";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ bmc@0 {
+ label = "bmc";
+ reg = <0x0 0x4000000>;
+ };
+ u-boot@0 {
+ label = "u-boot";
+ reg = <0x0 0x200000>;
+ };
+ u-boot-env@1f0000 {
+ label = "u-boot-env";
+ reg = <0x1f0000 0x10000>;
+ };
+ kernel@200000 {
+ label = "kernel";
+ reg = <0x200000 0xc00000>;
+ };
+ rofs@a00000 {
+ label = "rofs";
+ reg = <0xa00000 0x2a00000>;
+ };
+ rwfs@2a00000 {
+ label = "rwfs";
+ reg = <0x2a00000 0x43f0000>;
+ };
+ };
+ };
+};
+
+&spi1 {
+ status = "okay";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_spi1_default>;
+
+ flash@0 {
+ status = "okay";
+ w25q256,fast-read;
+ label = "bios-spi";
+ spi-max-frequency = <50000000>;
+ partitions {
+ compatible = "fixed-partitions";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ biosfullimg@0 {
+ reg = <0x0 0x2000000>; // 32768 *1024 = 0x2000000, 32 MB
+ label = "biosfullimg";
+ };
+ };
+ };
+};
+
+&i2c0 {
+ status = "okay";
+};
+
+&i2c1 {
+ status = "okay";
+};
+
+&i2c2 {
+ status = "okay";
+};
+
+&i2c3 {
+ status = "okay";
+};
+
+&i2c4 {
+ status = "okay";
+ tmp75@48 {
+ compatible = "ti,tmp75";
+ reg = <0x48>;
+ };
+ tmp75@49 {
+ compatible = "ti,tmp75";
+ reg = <0x49>;
+ };
+
+ pca9555_4_20: gpio@20 {
+ compatible = "nxp,pca9555";
+ reg = <0x20>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+
+ pca9555_4_22: gpio@22 {
+ compatible = "nxp,pca9555";
+ reg = <0x22>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+
+ pca9555_4_24: gpio@24 {
+ compatible = "nxp,pca9555";
+ reg = <0x24>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ gpio-line-names =
+ /*A0 - A7 0*/ "", "STRAP_BMC_BATTERY_GPIO1", "", "", "", "", "", "",
+ /*B0 - B7 8*/ "", "", "", "", "", "", "", "";
+ };
+
+ pca9555_4_26: gpio@26 {
+ compatible = "nxp,pca9555";
+ reg = <0x26>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+
+ i2c-switch@70 {
+ compatible = "nxp,pca9546";
+ status = "okay";
+ reg = <0x70>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ channel_1: i2c@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0>;
+ };
+
+ channel_2: i2c@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <1>;
+ };
+
+ channel_3: i2c@2 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <2>;
+ };
+
+ channel_4: i2c@3 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <3>;
+ };
+ };
+};
+
+&i2c5 {
+ status = "okay";
+ pca9555_5_24: gpio@24 {
+ compatible = "nxp,pca9555";
+ reg = <0x24>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+
+ i2c-switch@70 {
+ compatible = "nxp,pca9546";
+ status = "okay";
+ reg = <0x70 >;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ channel_5: i2c@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0>;
+ pca9555_5_5_20: gpio@20 {
+ compatible = "nxp,pca9555";
+ reg = <0x20>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ gpio-line-names =
+ /*A0 0*/ "", "", "", "", "", "", "", "",
+ /*B0 8*/ "", "", "SYS_FAN6", "SYS_FAN5",
+ /*B4 12*/ "SYS_FAN4", "SYS_FAN3", "SYS_FAN2", "SYS_FAN1";
+ };
+ pca9555_5_5_21: gpio@21 {
+ compatible = "nxp,pca9555";
+ reg = <0x21>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+ ina219@0x44 {
+ compatible = "ti,ina219";
+ reg = <0x44>;
+ rshunt = <2>;
+ };
+ };
+
+ channel_6: i2c@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <1>;
+ };
+
+ channel_7: i2c@2 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <2>;
+ };
+
+ channel_8: i2c@3 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <3>;
+ };
+ };
+};
+
+&i2c6 {
+ status = "okay";
+ pca9555_6_27: gpio@27 {
+ compatible = "nxp,pca9555";
+ reg = <0x27>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+ pca9555_6_20: gpio@20 {
+ compatible = "nxp,pca9555";
+ reg = <0x20>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ gpio-line-names =
+ /*A0 - A7 0*/ "", "", "", "", "", "", "", "",
+ /*B0 - B7 8*/ "Drive_NVMe1", "Drive_NVMe2", "", "", "", "", "", "";
+ };
+ pca9555_6_21: gpio@21 {
+ compatible = "nxp,pca9555";
+ reg = <0x21>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+};
+
+&i2c7 {
+ status = "okay";
+ i2c-switch@70 {
+ compatible = "nxp,pca9546";
+ status = "okay";
+ reg = <0x70>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ idle-state = <1>;
+
+ channel_9: i2c@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0>;
+ tmp75@48 {
+ compatible = "ti,tmp75";
+ reg = <0x48>;
+ };
+ tmp75@49 {
+ compatible = "ti,tmp75";
+ reg = <0x49>;
+ };
+ ina219@0x40 {
+ compatible = "ti,ina219";
+ reg = <0x40>;
+ rshunt = <2>;
+ };
+ ina219@0x41 {
+ compatible = "ti,ina219";
+ reg = <0x41>;
+ rshunt = <5>;
+ };
+ };
+
+ channel_10: i2c@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <1>;
+ };
+
+ channel_11: i2c@2 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <2>;
+ };
+
+ channel_12: i2c@3 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <3>;
+ };
+ };
+ i2c-switch@71 {
+ compatible = "nxp,pca9546";
+ status = "okay";
+ reg = <0x71>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ i2c-mux-idle-disconnect;
+
+ channel_13: i2c@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0>;
+ };
+
+ channel_14: i2c@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <1>;
+ };
+
+ channel_15: i2c@2 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <2>;
+ };
+
+ channel_16: i2c@3 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <3>;
+ };
+ };
+};
+
+&i2c8 {
+ status = "okay";
+ i2c-switch@70 {
+ compatible = "nxp,pca9546";
+ status = "okay";
+ reg = <0x70>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ i2c-mux-idle-disconnect;
+
+ channel_17: i2c@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0>;
+ };
+
+ channel_18: i2c@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <1>;
+ tmp75@48 {
+ compatible = "ti,tmp75";
+ reg = <0x48>;
+ };
+ ina219@0x41 {
+ compatible = "ti,ina219";
+ reg = <0x41>;
+ rshunt = <5>;
+ };
+ };
+
+ channel_19: i2c@2 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <2>;
+ };
+
+ channel_20: i2c@3 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <3>;
+ };
+ };
+};
+
+&i2c9 {
+ status = "okay";
+};
+
+&i2c10 {
+ status = "okay";
+};
+
+&i2c11 {
+ status = "okay";
+};
+
+&i2c12 {
+ status = "disabled";
+};
+
+&i2c13 {
+ status = "disabled";
+};
+
+&i2c14 {
+ status = "okay";
+ multi-master;
+ eeprom@50 {
+ compatible = "atmel,24c08";
+ reg = <0x50>;
+ };
+ eeprom@51 {
+ compatible = "atmel,24c08";
+ reg = <0x51>;
+ };
+};
+
+&sgpiom0 {
+ status = "okay";
+};
+
+&gfx {
+ pcie-reset-detect;
+ status = "disabled";
+ memory-region = <&gfx_memory>;
+};
+
+&sdc {
+ status = "okay";
+};
+
+&sdhci0 {
+ status = "disabled";
+ bus-width = <4>;
+ max-frequency = <100000000>;
+ sdhci-drive-type = /bits/ 8 <3>;
+ /* SDR104/DDR50/SDR50 bits in CAPA2 is not supported */
+ sdhci-caps-mask = <0x7 0x580000>;
+ sdhci,wp-inverted;
+};
+
+#if !defined(CONFIG_SPX_FEATURE_ENABLE_SSP)
+&sdhci1 {
+ status = "disabled";
+ bus-width = <4>;
+ max-frequency = <100000000>;
+ sdhci-drive-type = /bits/ 8 <3>;
+ sdhci-caps-mask = <0x7 0x580000>;
+ sdhci,wp-inverted;
+};
+#endif
+
+&lpc_snoop {
+ status = "okay";
+ snoop-ports = <0x80>;
+};
+
+&ibt {
+ status = "disabled";
+};
+
+&kcs1 {
+ kcs_addr = <0xca0>;
+ status = "okay";
+};
+
+&kcs2 {
+ kcs_addr = <0xca8>;
+ status = "okay";
+};
+
+&kcs3 {
+ kcs_addr = <0xca2>;
+ status = "okay";
+};
+
+&kcs4 {
+ kcs_addr = <0xca4>;
+ status = "disabled";
+};
+
+&uart1 {
+ status = "disabled";
+};
+
+&uart2 {
+ status = "disabled";
+};
+
+&uart3 {
+ status = "okay";
+};
+
+&uart4 {
+ status = "okay";
+ /* GPIOB6 will be used in ASD function, do not set to be TXD4 */
+ //pinctrl-0 = <&pinctrl_txd4_default &pinctrl_rxd4_default>;
+ pinctrl-0 = <&pinctrl_txd2_default &pinctrl_rxd2_default>;
+};
+
+&uart_routing {
+ status = "okay";
+};
+
+&uart5 {
+ status = "okay";
+};
+
+#if defined(CONFIG_SPX_FEATURE_ENABLE_SSP)
+&uart7 {
+ status = "okay";
+};
+#endif
+
+#if defined(CONFIG_SPX_FEATURE_PLATGUARDPLUS_SUPPORT)
+&uart11 {
+ status = "okay";
+};
+#endif
+#ifdef CONFIG_SPX_FEATURE_USB_PORT_B_HOST_SUPPORT
+&ehci1 {
+ status = "okay";
+};
+
+&uhci {
+ status = "okay";
+};
+#endif
+
+&vhub {
+ status = "okay";
+};
+
+#ifdef CONFIG_SPX_FEATURE_USB_PORT_B_SUPPORT
+&udc {
+ status = "okay";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usb2bd_default>;
+};
+#endif
+
+&gpio0 {
+ gpio-line-names =
+ /*A0 0*/ "", "", "", "", "", "", "", "",
+ /*B0 8*/ "", "", "", "", "", "", "PS_PWROK", "",
+ /*C0 16*/ "", "", "", "", "", "", "", "",
+ /*D0 24*/ "", "", "", "", "", "", "", "",
+ /*E0 32*/ "", "", "", "", "", "", "", "",
+ /*F0 40*/ "", "", "", "", "", "", "", "",
+ /*G0 48*/ "", "", "", "", "", "", "", "",
+ /*H0 56*/ "", "", "", "", "", "", "", "",
+ /*I0 64*/ "", "", "", "", "", "", "", "",
+ /*J0 72*/ "", "", "", "", "", "", "", "",
+ /*K0 80*/ "", "", "", "", "", "", "", "",
+ /*L0 88*/ "", "", "", "", "", "", "", "",
+ /*M0 96*/ "", "", "", "", "", "", "", "",
+ /*N0 104*/ "", "", "", "",
+ /*N4 108*/ "POST_COMPLETE", "ESR1_GPIO_AST_SPISEL", "", "",
+ /*O0 112*/ "", "", "", "", "", "", "", "",
+ /*P0 120*/ "ID_BUTTON", "ID_OUT", "POWER_BUTTON", "POWER_OUT",
+ /*P4 124*/ "RESET_BUTTON", "RESET_OUT", "", "HEARTBEAT",
+ /*Q0 128*/ "", "", "", "", "", "", "", "",
+ /*R0 136*/ "", "", "", "", "", "", "", "",
+ /*S0 144*/ "", "", "", "", "", "", "", "",
+ /*T0 152*/ "", "", "", "", "", "", "", "",
+ /*U0 160*/ "", "", "", "", "", "", "", "",
+ /*V0 168*/ "", "", "", "", "", "", "", "",
+ /*W0 176*/ "", "", "", "", "", "", "", "",
+ /*X0 184*/ "", "", "", "", "", "", "", "",
+ /*Y0 192*/ "", "", "", "", "", "", "", "",
+ /*Z0 200*/ "", "", "", "", "", "", "", "";
+};
--
2.25.1
^ permalink raw reply related [flat|nested] 35+ messages in thread
* [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
@ 2024-01-30 8:56 ` Kelly Hung
0 siblings, 0 replies; 35+ messages in thread
From: Kelly Hung @ 2024-01-30 8:56 UTC (permalink / raw)
To: robh+dt
Cc: krzysztof.kozlowski+dt, conor+dt, joel, andrew, devicetree,
linux-arm-kernel, linux-aspeed, linux-kernel, kelly_hung,
kelly1732000
From: kelly1732000 <Kelly_Hung@asus.com>
This initial device-tree provides the necessary configuration for
basic BMC functionality and work on ASUS X4TF production.
Signed-off-by: kelly1732000 <Kelly_Hung@asus.com>
---
.../boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts | 828 ++++++++++++++++++
1 file changed, 828 insertions(+)
create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts
new file mode 100644
index 000000000000..723bbb33137f
--- /dev/null
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts
@@ -0,0 +1,828 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+// Copyright 2023 ASUS Corp.
+/dts-v1/;
+
+#include "aspeed-g6.dtsi"
+#include <dt-bindings/gpio/aspeed-gpio.h>
+#include <dt-bindings/i2c/i2c.h>
+
+
+/ {
+ model = "ASUS-X4TF";
+ compatible = "asus,x4tf", "aspeed,ast2600";
+
+ chosen {
+ stdout-path = &uart5;
+ bootargs = "console=ttyS4,115200n8 earlycon";
+ };
+
+ memory@80000000 {
+ device_type = "memory";
+ reg = <0x80000000 0x40000000>;
+ };
+
+ reserved-memory {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges;
+
+ gfx_memory: framebuffer {
+ size = <0x01000000>;
+ alignment = <0x01000000>;
+ compatible = "shared-dma-pool";
+ reusable;
+ };
+
+ video_engine_memory: video {
+ size = <0x04000000>;
+ alignment = <0x01000000>;
+ compatible = "shared-dma-pool";
+ reusable;
+ };
+
+ rvas_memory: rvas {
+ size = <0x04000000>;
+ alignment = <0x01000000>;
+ compatible = "shared-dma-pool";
+ reusable;
+ };
+
+ bmc_dev_memory: bmc_dev_memory {
+ size = <0x00100000>;
+ alignment = <0x00100000>;
+ compatible = "shared-dma-pool";
+ no-map;
+ };
+
+ pci_msi_memory: pci_msi_memory {
+ no-map;
+ reg = <0x9e770000 0x100>;
+ compatible = "shared-dma-pool";
+ };
+ /* 1GB memory */
+ vga_memory: region@bf000000 {
+ no-map;
+ compatible = "shared-dma-pool";
+ reg = <0xbf000000 0x01000000>; /* 16M */
+ };
+ ssp_memory: ssp_memory {
+ size = <0x02000000>;
+ alignment = <0x01000000>;
+ compatible = "shared-dma-pool";
+ no-map;
+ };
+ };
+
+ vcc_sdhci0: regulator-vcc-sdhci0 {
+ compatible = "regulator-fixed";
+ status = "disabled";
+ regulator-name = "SDHCI0 Vcc";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ gpios = <&gpio0 ASPEED_GPIO(V, 0) GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ };
+
+ vccq_sdhci0: regulator-vccq-sdhci0 {
+ compatible = "regulator-gpio";
+ status = "disabled";
+ regulator-name = "SDHCI0 VccQ";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ gpios = <&gpio0 ASPEED_GPIO(V, 1) GPIO_ACTIVE_HIGH>;
+ gpios-states = <1>;
+ states = <3300000 1>,
+ <1800000 0>;
+ };
+
+ vcc_sdhci1: regulator-vcc-sdhci1 {
+ compatible = "regulator-fixed";
+ status = "disabled";
+ regulator-name = "SDHCI1 Vcc";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ gpios = <&gpio0 ASPEED_GPIO(V, 2) GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ };
+
+ vccq_sdhci1: regulator-vccq-sdhci1 {
+ compatible = "regulator-gpio";
+ status = "disabled";
+ regulator-name = "SDHCI1 VccQ";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ gpios = <&gpio0 ASPEED_GPIO(V, 3) GPIO_ACTIVE_HIGH>;
+ gpios-states = <1>;
+ states = <3300000 1>,
+ <1800000 0>;
+ };
+ iio-hwmon {
+ compatible = "iio-hwmon";
+ io-channels = <&adc0 0>, <&adc0 1>, <&adc0 2>, <&adc0 3>,
+ <&adc0 4>, <&adc0 5>, <&adc0 6>, <&adc0 7>,
+ <&adc1 0>, <&adc1 1>, <&adc1 2>, <&adc1 3>,
+ <&adc1 4>, <&adc1 5>, <&adc1 6>, <&adc1 7>;
+ };
+
+ video-engine@1e700000 {
+ compatible = "aspeed,ast2600-video-engine";
+ reg = <0x1e700000 0x20000>;
+ clocks = <&syscon ASPEED_CLK_GATE_VCLK>, <&syscon ASPEED_CLK_GATE_ECLK>;
+ clock-names = "vclk", "eclk";
+ interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
+ memory-region = <&video_engine_memory>;
+ //resets = <&syscon ASPEED_RESET_VIDEO>;
+ };
+
+ leds {
+ compatible = "gpio-leds";
+
+ heartbeat {
+ gpios = <&gpio0 ASPEED_GPIO(P, 7) GPIO_ACTIVE_LOW>;
+ linux,default-trigger = "heartbeat";
+ };
+ uid_led {
+ gpios = <&gpio0 ASPEED_GPIO(P, 1) (GPIO_ACTIVE_LOW | GPIO_OPEN_DRAIN)>;
+ default-state = "off";
+ };
+ status_Y {
+ gpios = <&gpio1 ASPEED_GPIO(B, 1) GPIO_ACTIVE_LOW>;
+ default-state = "off";
+ };
+ sys_boot_status {
+ gpios = <&gpio1 ASPEED_GPIO(B, 0) GPIO_ACTIVE_LOW>;
+ default-state = "off";
+ };
+ };
+ spigpio {
+ status = "okay";
+ compatible = "spi-gpio";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ sck-gpios = <&gpio0 ASPEED_GPIO(Z, 3) GPIO_ACTIVE_HIGH>;
+ mosi-gpios = <&gpio0 ASPEED_GPIO(Z, 4) GPIO_ACTIVE_HIGH>;
+ miso-gpios = <&gpio0 ASPEED_GPIO(Z, 5) GPIO_ACTIVE_HIGH>;
+ num-chipselects = <1>;
+ cs-gpios = <&gpio0 ASPEED_GPIO(Z, 0) GPIO_ACTIVE_HIGH>;
+ };
+
+};
+
+&adc0 {
+ vref = <2500>;
+ status = "okay";
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_adc0_default &pinctrl_adc1_default
+ &pinctrl_adc2_default &pinctrl_adc3_default
+ &pinctrl_adc4_default &pinctrl_adc5_default
+ &pinctrl_adc6_default &pinctrl_adc7_default>;
+};
+
+&adc1 {
+ vref = <2500>;
+ status = "okay";
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_adc8_default &pinctrl_adc9_default
+ &pinctrl_adc10_default &pinctrl_adc11_default
+ &pinctrl_adc12_default &pinctrl_adc13_default
+ &pinctrl_adc14_default &pinctrl_adc15_default>;
+};
+
+&peci0 {
+ status = "okay";
+};
+
+&lpc_snoop {
+ snoop-ports = <0x80>;
+ status = "okay";
+};
+
+
+&mdio0 {
+ status = "disabled";
+};
+
+
+&mdio1 {
+ status = "disabled";
+};
+
+&mdio2 {
+ status = "okay";
+
+ ethphy2: ethernet-phy@0 {
+ compatible = "ethernet-phy-ieee802.3-c22";
+ reg = <0>;
+ };
+};
+
+&mdio3 {
+ status = "okay";
+
+ ethphy3: ethernet-phy@0 {
+ compatible = "ethernet-phy-ieee802.3-c22";
+ reg = <0>;
+ };
+};
+
+&mac0 {
+ status = "disabled";
+};
+
+&mac1 {
+ status = "disabled";
+};
+
+//for X4TF
+&mac2 {
+ status = "okay";
+ phy-mode = "rmii";
+ #phy-handle = <ðphy2>;
+ use-ncsi;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_rmii3_default>;
+};
+
+
+&mac3 {
+ status = "okay";
+ phy-mode = "rmii";
+ #phy-handle = <ðphy3>;
+ use-ncsi;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_rmii4_default>;
+};
+
+
+&syscon {
+ uart-clock-high-speed;
+ status = "okay";
+};
+
+&rtc {
+ status = "disabled";
+};
+
+&fmc {
+ status = "okay";
+ flash@0 {
+ status = "okay";
+ m25p,fast-read;
+ label = "bmc-spi";
+ spi-max-frequency = <50000000>;
+ spi-bus-width = <1>;
+ partitions {
+ compatible = "fixed-partitions";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ bmc@0 {
+ label = "bmc";
+ reg = <0x0 0x4000000>;
+ };
+ u-boot@0 {
+ label = "u-boot";
+ reg = <0x0 0x200000>;
+ };
+ u-boot-env@1f0000 {
+ label = "u-boot-env";
+ reg = <0x1f0000 0x10000>;
+ };
+ kernel@200000 {
+ label = "kernel";
+ reg = <0x200000 0xc00000>;
+ };
+ rofs@a00000 {
+ label = "rofs";
+ reg = <0xa00000 0x2a00000>;
+ };
+ rwfs@2a00000 {
+ label = "rwfs";
+ reg = <0x2a00000 0x43f0000>;
+ };
+ };
+ };
+};
+
+&spi1 {
+ status = "okay";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_spi1_default>;
+
+ flash@0 {
+ status = "okay";
+ w25q256,fast-read;
+ label = "bios-spi";
+ spi-max-frequency = <50000000>;
+ partitions {
+ compatible = "fixed-partitions";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ biosfullimg@0 {
+ reg = <0x0 0x2000000>; // 32768 *1024 = 0x2000000, 32 MB
+ label = "biosfullimg";
+ };
+ };
+ };
+};
+
+&i2c0 {
+ status = "okay";
+};
+
+&i2c1 {
+ status = "okay";
+};
+
+&i2c2 {
+ status = "okay";
+};
+
+&i2c3 {
+ status = "okay";
+};
+
+&i2c4 {
+ status = "okay";
+ tmp75@48 {
+ compatible = "ti,tmp75";
+ reg = <0x48>;
+ };
+ tmp75@49 {
+ compatible = "ti,tmp75";
+ reg = <0x49>;
+ };
+
+ pca9555_4_20: gpio@20 {
+ compatible = "nxp,pca9555";
+ reg = <0x20>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+
+ pca9555_4_22: gpio@22 {
+ compatible = "nxp,pca9555";
+ reg = <0x22>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+
+ pca9555_4_24: gpio@24 {
+ compatible = "nxp,pca9555";
+ reg = <0x24>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ gpio-line-names =
+ /*A0 - A7 0*/ "", "STRAP_BMC_BATTERY_GPIO1", "", "", "", "", "", "",
+ /*B0 - B7 8*/ "", "", "", "", "", "", "", "";
+ };
+
+ pca9555_4_26: gpio@26 {
+ compatible = "nxp,pca9555";
+ reg = <0x26>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+
+ i2c-switch@70 {
+ compatible = "nxp,pca9546";
+ status = "okay";
+ reg = <0x70>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ channel_1: i2c@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0>;
+ };
+
+ channel_2: i2c@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <1>;
+ };
+
+ channel_3: i2c@2 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <2>;
+ };
+
+ channel_4: i2c@3 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <3>;
+ };
+ };
+};
+
+&i2c5 {
+ status = "okay";
+ pca9555_5_24: gpio@24 {
+ compatible = "nxp,pca9555";
+ reg = <0x24>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+
+ i2c-switch@70 {
+ compatible = "nxp,pca9546";
+ status = "okay";
+ reg = <0x70 >;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ channel_5: i2c@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0>;
+ pca9555_5_5_20: gpio@20 {
+ compatible = "nxp,pca9555";
+ reg = <0x20>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ gpio-line-names =
+ /*A0 0*/ "", "", "", "", "", "", "", "",
+ /*B0 8*/ "", "", "SYS_FAN6", "SYS_FAN5",
+ /*B4 12*/ "SYS_FAN4", "SYS_FAN3", "SYS_FAN2", "SYS_FAN1";
+ };
+ pca9555_5_5_21: gpio@21 {
+ compatible = "nxp,pca9555";
+ reg = <0x21>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+ ina219@0x44 {
+ compatible = "ti,ina219";
+ reg = <0x44>;
+ rshunt = <2>;
+ };
+ };
+
+ channel_6: i2c@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <1>;
+ };
+
+ channel_7: i2c@2 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <2>;
+ };
+
+ channel_8: i2c@3 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <3>;
+ };
+ };
+};
+
+&i2c6 {
+ status = "okay";
+ pca9555_6_27: gpio@27 {
+ compatible = "nxp,pca9555";
+ reg = <0x27>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+ pca9555_6_20: gpio@20 {
+ compatible = "nxp,pca9555";
+ reg = <0x20>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ gpio-line-names =
+ /*A0 - A7 0*/ "", "", "", "", "", "", "", "",
+ /*B0 - B7 8*/ "Drive_NVMe1", "Drive_NVMe2", "", "", "", "", "", "";
+ };
+ pca9555_6_21: gpio@21 {
+ compatible = "nxp,pca9555";
+ reg = <0x21>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+};
+
+&i2c7 {
+ status = "okay";
+ i2c-switch@70 {
+ compatible = "nxp,pca9546";
+ status = "okay";
+ reg = <0x70>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ idle-state = <1>;
+
+ channel_9: i2c@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0>;
+ tmp75@48 {
+ compatible = "ti,tmp75";
+ reg = <0x48>;
+ };
+ tmp75@49 {
+ compatible = "ti,tmp75";
+ reg = <0x49>;
+ };
+ ina219@0x40 {
+ compatible = "ti,ina219";
+ reg = <0x40>;
+ rshunt = <2>;
+ };
+ ina219@0x41 {
+ compatible = "ti,ina219";
+ reg = <0x41>;
+ rshunt = <5>;
+ };
+ };
+
+ channel_10: i2c@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <1>;
+ };
+
+ channel_11: i2c@2 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <2>;
+ };
+
+ channel_12: i2c@3 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <3>;
+ };
+ };
+ i2c-switch@71 {
+ compatible = "nxp,pca9546";
+ status = "okay";
+ reg = <0x71>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ i2c-mux-idle-disconnect;
+
+ channel_13: i2c@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0>;
+ };
+
+ channel_14: i2c@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <1>;
+ };
+
+ channel_15: i2c@2 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <2>;
+ };
+
+ channel_16: i2c@3 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <3>;
+ };
+ };
+};
+
+&i2c8 {
+ status = "okay";
+ i2c-switch@70 {
+ compatible = "nxp,pca9546";
+ status = "okay";
+ reg = <0x70>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ i2c-mux-idle-disconnect;
+
+ channel_17: i2c@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0>;
+ };
+
+ channel_18: i2c@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <1>;
+ tmp75@48 {
+ compatible = "ti,tmp75";
+ reg = <0x48>;
+ };
+ ina219@0x41 {
+ compatible = "ti,ina219";
+ reg = <0x41>;
+ rshunt = <5>;
+ };
+ };
+
+ channel_19: i2c@2 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <2>;
+ };
+
+ channel_20: i2c@3 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <3>;
+ };
+ };
+};
+
+&i2c9 {
+ status = "okay";
+};
+
+&i2c10 {
+ status = "okay";
+};
+
+&i2c11 {
+ status = "okay";
+};
+
+&i2c12 {
+ status = "disabled";
+};
+
+&i2c13 {
+ status = "disabled";
+};
+
+&i2c14 {
+ status = "okay";
+ multi-master;
+ eeprom@50 {
+ compatible = "atmel,24c08";
+ reg = <0x50>;
+ };
+ eeprom@51 {
+ compatible = "atmel,24c08";
+ reg = <0x51>;
+ };
+};
+
+&sgpiom0 {
+ status = "okay";
+};
+
+&gfx {
+ pcie-reset-detect;
+ status = "disabled";
+ memory-region = <&gfx_memory>;
+};
+
+&sdc {
+ status = "okay";
+};
+
+&sdhci0 {
+ status = "disabled";
+ bus-width = <4>;
+ max-frequency = <100000000>;
+ sdhci-drive-type = /bits/ 8 <3>;
+ /* SDR104/DDR50/SDR50 bits in CAPA2 is not supported */
+ sdhci-caps-mask = <0x7 0x580000>;
+ sdhci,wp-inverted;
+};
+
+#if !defined(CONFIG_SPX_FEATURE_ENABLE_SSP)
+&sdhci1 {
+ status = "disabled";
+ bus-width = <4>;
+ max-frequency = <100000000>;
+ sdhci-drive-type = /bits/ 8 <3>;
+ sdhci-caps-mask = <0x7 0x580000>;
+ sdhci,wp-inverted;
+};
+#endif
+
+&lpc_snoop {
+ status = "okay";
+ snoop-ports = <0x80>;
+};
+
+&ibt {
+ status = "disabled";
+};
+
+&kcs1 {
+ kcs_addr = <0xca0>;
+ status = "okay";
+};
+
+&kcs2 {
+ kcs_addr = <0xca8>;
+ status = "okay";
+};
+
+&kcs3 {
+ kcs_addr = <0xca2>;
+ status = "okay";
+};
+
+&kcs4 {
+ kcs_addr = <0xca4>;
+ status = "disabled";
+};
+
+&uart1 {
+ status = "disabled";
+};
+
+&uart2 {
+ status = "disabled";
+};
+
+&uart3 {
+ status = "okay";
+};
+
+&uart4 {
+ status = "okay";
+ /* GPIOB6 will be used in ASD function, do not set to be TXD4 */
+ //pinctrl-0 = <&pinctrl_txd4_default &pinctrl_rxd4_default>;
+ pinctrl-0 = <&pinctrl_txd2_default &pinctrl_rxd2_default>;
+};
+
+&uart_routing {
+ status = "okay";
+};
+
+&uart5 {
+ status = "okay";
+};
+
+#if defined(CONFIG_SPX_FEATURE_ENABLE_SSP)
+&uart7 {
+ status = "okay";
+};
+#endif
+
+#if defined(CONFIG_SPX_FEATURE_PLATGUARDPLUS_SUPPORT)
+&uart11 {
+ status = "okay";
+};
+#endif
+#ifdef CONFIG_SPX_FEATURE_USB_PORT_B_HOST_SUPPORT
+&ehci1 {
+ status = "okay";
+};
+
+&uhci {
+ status = "okay";
+};
+#endif
+
+&vhub {
+ status = "okay";
+};
+
+#ifdef CONFIG_SPX_FEATURE_USB_PORT_B_SUPPORT
+&udc {
+ status = "okay";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usb2bd_default>;
+};
+#endif
+
+&gpio0 {
+ gpio-line-names =
+ /*A0 0*/ "", "", "", "", "", "", "", "",
+ /*B0 8*/ "", "", "", "", "", "", "PS_PWROK", "",
+ /*C0 16*/ "", "", "", "", "", "", "", "",
+ /*D0 24*/ "", "", "", "", "", "", "", "",
+ /*E0 32*/ "", "", "", "", "", "", "", "",
+ /*F0 40*/ "", "", "", "", "", "", "", "",
+ /*G0 48*/ "", "", "", "", "", "", "", "",
+ /*H0 56*/ "", "", "", "", "", "", "", "",
+ /*I0 64*/ "", "", "", "", "", "", "", "",
+ /*J0 72*/ "", "", "", "", "", "", "", "",
+ /*K0 80*/ "", "", "", "", "", "", "", "",
+ /*L0 88*/ "", "", "", "", "", "", "", "",
+ /*M0 96*/ "", "", "", "", "", "", "", "",
+ /*N0 104*/ "", "", "", "",
+ /*N4 108*/ "POST_COMPLETE", "ESR1_GPIO_AST_SPISEL", "", "",
+ /*O0 112*/ "", "", "", "", "", "", "", "",
+ /*P0 120*/ "ID_BUTTON", "ID_OUT", "POWER_BUTTON", "POWER_OUT",
+ /*P4 124*/ "RESET_BUTTON", "RESET_OUT", "", "HEARTBEAT",
+ /*Q0 128*/ "", "", "", "", "", "", "", "",
+ /*R0 136*/ "", "", "", "", "", "", "", "",
+ /*S0 144*/ "", "", "", "", "", "", "", "",
+ /*T0 152*/ "", "", "", "", "", "", "", "",
+ /*U0 160*/ "", "", "", "", "", "", "", "",
+ /*V0 168*/ "", "", "", "", "", "", "", "",
+ /*W0 176*/ "", "", "", "", "", "", "", "",
+ /*X0 184*/ "", "", "", "", "", "", "", "",
+ /*Y0 192*/ "", "", "", "", "", "", "", "",
+ /*Z0 200*/ "", "", "", "", "", "", "", "";
+};
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 35+ messages in thread
* [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
@ 2024-01-30 8:56 ` Kelly Hung
0 siblings, 0 replies; 35+ messages in thread
From: Kelly Hung @ 2024-01-30 8:56 UTC (permalink / raw)
To: robh+dt
Cc: krzysztof.kozlowski+dt, conor+dt, joel, andrew, devicetree,
linux-arm-kernel, linux-aspeed, linux-kernel, kelly_hung,
Kelly Hung
This initial device-tree provides the necessary configuration for
basic BMC functionality and work on ASUS X4TF production.
Signed-off-by: Kelly Hung <Kelly_Hung@asus.com>
---
Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
index 749ee54a3ff8..80009948e14a 100644
--- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
+++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
@@ -74,6 +74,7 @@ properties:
- ampere,mtmitchell-bmc
- aspeed,ast2600-evb
- aspeed,ast2600-evb-a1
+ - asus,x4tf
- facebook,bletchley-bmc
- facebook,cloudripper-bmc
- facebook,elbert-bmc
--
2.25.1
^ permalink raw reply related [flat|nested] 35+ messages in thread
* [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC
@ 2024-01-30 8:56 ` Kelly Hung
0 siblings, 0 replies; 35+ messages in thread
From: Kelly Hung @ 2024-01-30 8:56 UTC (permalink / raw)
To: robh+dt
Cc: krzysztof.kozlowski+dt, conor+dt, joel, andrew, devicetree,
linux-arm-kernel, linux-aspeed, linux-kernel, kelly_hung,
Kelly Hung
This initial device-tree provides the necessary configuration for
basic BMC functionality and work on ASUS X4TF production.
Signed-off-by: Kelly Hung <Kelly_Hung@asus.com>
---
Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
index 749ee54a3ff8..80009948e14a 100644
--- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
+++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
@@ -74,6 +74,7 @@ properties:
- ampere,mtmitchell-bmc
- aspeed,ast2600-evb
- aspeed,ast2600-evb-a1
+ - asus,x4tf
- facebook,bletchley-bmc
- facebook,cloudripper-bmc
- facebook,elbert-bmc
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 35+ messages in thread
end of thread, other threads:[~2024-03-26 11:30 UTC | newest]
Thread overview: 35+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-30 9:04 [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC Kelly Hung
2024-01-30 9:04 ` Kelly Hung
2024-02-01 9:24 ` Krzysztof Kozlowski
2024-03-05 6:30 ` Kelly Hung(洪嘉莉)
2024-03-05 7:09 ` Krzysztof Kozlowski
2024-03-05 9:42 ` Kelly Hung(洪嘉莉)
2024-03-05 9:44 ` Krzysztof Kozlowski
2024-03-05 9:57 ` Chia Li Hung
2024-03-26 8:19 ` Chia Li Hung
2024-03-26 8:43 ` Krzysztof Kozlowski
2024-03-26 10:53 ` Chia Li Hung
2024-03-26 11:29 ` Krzysztof Kozlowski
-- strict thread matches above, loose matches on Subject: below --
2024-01-30 8:56 Kelly Hung
2024-01-30 8:56 ` Kelly Hung
2024-01-30 8:56 ` Kelly Hung
2024-01-30 8:56 ` Kelly Hung
2024-01-30 10:39 ` Krzysztof Kozlowski
2024-01-30 10:39 ` Krzysztof Kozlowski
2024-03-04 10:45 ` Kelly Hung(洪嘉莉)
2024-03-04 10:45 ` Kelly Hung(洪嘉莉)
2024-03-04 11:23 ` Krzysztof Kozlowski
2024-03-04 11:23 ` Krzysztof Kozlowski
2024-03-26 8:14 ` Chia Li Hung
2024-03-05 3:52 ` Kelly Hung(洪嘉莉)
2024-03-05 3:52 ` Kelly Hung(洪嘉莉)
2024-03-26 8:10 ` Chia Li Hung
2024-01-30 10:39 ` Krzysztof Kozlowski
2024-01-30 10:39 ` Krzysztof Kozlowski
2024-03-05 4:04 ` Kelly Hung(洪嘉莉)
2024-03-05 4:04 ` Kelly Hung(洪嘉莉)
2024-01-30 10:35 ` Krzysztof Kozlowski
2024-01-30 10:35 ` Krzysztof Kozlowski
2024-03-05 4:15 ` Kelly Hung(洪嘉莉)
2024-03-05 4:15 ` Kelly Hung(洪嘉莉)
2024-03-26 7:57 ` Chia Li Hung
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.